gloomberb 0.7.2 → 0.7.4

package/src/plugins/builtin/options.tsx

@@ -5,8 +5,9 @@ import type { GloomPlugin } from "../../types/plugin";
 import type { OptionContract, OptionsChain } from "../../types/financials";
 import { usePaneTicker } from "../../state/app-context";
 import { blendHex, colors, hoverBg } from "../../theme/colors";
-import { blendForContrast, contrastRatio, higherContrast } from "../../theme/color-utils";
+import { blendForContrast, contrastRatio } from "../../theme/color-utils";
 import { formatCompact, formatNumber } from "../../utils/format";
+import { isPlainKey } from "../../utils/keyboard";
 import { formatMarketPrice } from "../../utils/market-format";
 import { formatExpDate, resolveOptionsTarget } from "../../utils/options";
 import { useOptionsQuery, useResolvedEntryValue } from "../../market-data/hooks";
@@ -48,15 +49,6 @@ type OptionColorRole = "call" | "put" | "price" | "activity" | "iv" | "strike";
 
 const OPTION_TEXT_MIN_CONTRAST = 4.5;
 
-const OPTION_BASE_COLORS: Record<OptionColorRole, string> = {
-  call: "#5ed69a",
-  put: "#ff9c7a",
-  price: "#dfc05b",
-  activity: "#35a7d6",
-  iv: "#8bd878",
-  strike: "#8fb7ff",
-};
-
 const OPTION_COLUMNS: Array<Omit<OptionColumn, "headerColor">> = [
   { id: "callOpenInterest", label: "C OI", width: 6, align: "right" },
   { id: "callVolume", label: "C VOL", width: 6, align: "right" },
@@ -227,7 +219,7 @@ export function OptionsView({ width, height, focused, onCapture = () => {} }: Op
       return true;
     }
 
-    if (event.name === "j" || event.name === "down") {
+    if (isPlainKey(event, "j", "down")) {
       if (strikes.length === 0) return true;
       event.preventDefault?.();
       event.stopPropagation?.();
@@ -236,7 +228,7 @@ export function OptionsView({ width, height, focused, onCapture = () => {} }: Op
       setStrikeIdx((i) => Math.min(i + 1, strikes.length - 1));
       return true;
     }
-    if (event.name === "k" || event.name === "up") {
+    if (isPlainKey(event, "k", "up")) {
       if (strikes.length === 0) return true;
       event.preventDefault?.();
       event.stopPropagation?.();
@@ -404,14 +396,13 @@ function mostReadableColor(surface: string, candidates: readonly string[]): stri
 }
 
 export function optionRoleColor(role: OptionColorRole, surface: string): string {
-  const preferred = OPTION_BASE_COLORS[role];
-  const themeColor = optionRoleThemeColor(role);
+  const preferred = optionRoleThemeColor(role);
   const fallback = mostReadableColor(surface, [
     preferred,
-    themeColor,
     colors.text,
     colors.textBright,
-    higherContrast("#ffffff", "#000000", surface),
+    colors.selectedText,
+    colors.neutral,
   ]);
   return blendForContrast(preferred, surface, fallback, OPTION_TEXT_MIN_CONTRAST);
 }
@@ -421,7 +412,8 @@ export function optionMutedColor(surface: string): string {
     colors.textDim,
     colors.text,
     colors.textBright,
-    higherContrast("#ffffff", "#000000", surface),
+    colors.selectedText,
+    colors.neutral,
   ]);
   return blendForContrast(colors.textDim, surface, fallback, OPTION_TEXT_MIN_CONTRAST);
 }

package/src/plugins/builtin/portfolio-list/cli/commands.ts

@@ -23,6 +23,7 @@ import type { CliCommandContext, CliCommandDef } from "../../../../types/plugin"
 import type { TickerRecord } from "../../../../types/ticker";
 import {
   addTickerToPortfolio,
+  addTickerToWatchlist,
   createManualPortfolio,
   deleteManualPortfolio,
   findPortfolio,
@@ -415,7 +416,7 @@ async function deleteWatchlist(name: string, ctx: CliCommandContext) {
   persistence.close();
 }
 
-async function addTickerToWatchlist(watchlistName: string, symbol: string, ctx: CliCommandContext) {
+async function addTickerToWatchlistCommand(watchlistName: string, symbol: string, ctx: CliCommandContext) {
   const { config, store, dataProvider, persistence } = await ctx.initMarketData();
   const watchlist = findWatchlist(config, watchlistName);
   if (!watchlist) {
@@ -424,19 +425,14 @@ async function addTickerToWatchlist(watchlistName: string, symbol: string, ctx:
 
   try {
     const ticker = await resolveTickerForCli(symbol, store, dataProvider);
-    if (ticker.metadata.watchlists.includes(watchlist.id)) {
+    const result = addTickerToWatchlist(ticker, watchlist.id);
+    if (!result.changed) {
       console.log(cliStyles.warning(`${ticker.metadata.ticker} is already in "${watchlist.name}".`));
       persistence.close();
       return;
     }
 
-    const nextTicker: TickerRecord = {
-      ...ticker,
-      metadata: {
-        ...ticker.metadata,
-        watchlists: [...ticker.metadata.watchlists, watchlist.id],
-      },
-    };
+    const nextTicker = result.ticker;
     await store.saveTicker(nextTicker);
     console.log(cliStyles.success(`Added ${nextTicker.metadata.ticker} to "${watchlist.name}".`));
     if (nextTicker.metadata.name) {
@@ -644,7 +640,7 @@ export const watchlistCliCommand: CliCommandDef = {
       const symbol = args.at(-1);
       const name = args.slice(1, -1).join(" ");
       if (!name || !symbol) ctx.fail("Usage: gloomberb watchlist add <watchlist> <ticker>");
-      await addTickerToWatchlist(name!, symbol!, ctx);
+      await addTickerToWatchlistCommand(name!, symbol!, ctx);
       return;
     }
 

package/src/plugins/builtin/portfolio-list/metrics.ts

@@ -3,11 +3,12 @@ import type { ColumnConfig } from "../../../types/config";
 import type { TickerFinancials } from "../../../types/financials";
 import type { TickerRecord } from "../../../types/ticker";
 import { priceColor } from "../../../theme/colors";
-import { clampQuoteTimestamp, formatQuoteAgeWithSource } from "../../../utils/quote-time";
+import { formatQuoteAgeWithSource, resolveQuoteAgeTimestamp } from "../../../utils/quote-time";
 import { convertCurrency, formatCompact, formatNumber, formatPercentRaw } from "../../../utils/format";
 import { formatMarketCost, formatMarketPrice, formatMarketQuantity, formatSignedMarketPrice, type MarketFormatOptions } from "../../../utils/market-format";
 import { getActiveQuoteDisplay, marketStateDot, type ActiveQuoteDisplay } from "../../../utils/market-status";
 import { formatOptionTicker } from "../../../utils/options";
+import { PRICE_SPARKLINE_COLUMN_ID } from "../../../components/price-sparkline-view";
 
 export interface ColumnContext {
   activeTab?: string;
@@ -293,6 +294,8 @@ export function getColumnValue(
       return { text: "—" };
     case "latency":
       return { text: formatQuoteAgeWithSource(quote, ctx.now) };
+    case PRICE_SPARKLINE_COLUMN_ID:
+      return { text: "" };
     default:
       return { text: "—" };
   }
@@ -386,7 +389,15 @@ export function getSortValue(
       }
       return null;
     case "latency":
-      return quote?.lastUpdated != null ? ctx.now - (clampQuoteTimestamp(quote.lastUpdated, ctx.now) ?? ctx.now) : null;
+      return quote ? ctx.now - (resolveQuoteAgeTimestamp(quote, ctx.now) ?? ctx.now) : null;
+    case PRICE_SPARKLINE_COLUMN_ID: {
+      const values = (financials?.priceHistory ?? [])
+        .map((point) => point.close)
+        .filter((value) => Number.isFinite(value));
+      const first = values[0];
+      const last = values.at(-1);
+      return first != null && last != null && first !== 0 ? ((last - first) / Math.abs(first)) * 100 : null;
+    }
     default:
       return null;
   }

package/src/plugins/builtin/portfolio-list/mutations.ts

@@ -121,6 +121,23 @@ export function addTickerToPortfolio(
   };
 }
 
+export function addTickerToWatchlist(
+  ticker: TickerRecord,
+  watchlistId: string,
+): { changed: boolean; ticker: TickerRecord } {
+  if (ticker.metadata.watchlists.includes(watchlistId)) {
+    return { changed: false, ticker };
+  }
+
+  return {
+    changed: true,
+    ticker: replaceTickerMetadata(ticker, {
+      ...ticker.metadata,
+      watchlists: [...ticker.metadata.watchlists, watchlistId],
+    }),
+  };
+}
+
 export function removeTickerFromPortfolio(
   ticker: TickerRecord,
   portfolioId: string,

package/src/plugins/builtin/portfolio-list/pane.tsx

@@ -43,20 +43,50 @@ import {
 } from "./settings";
 import { formatPercentRaw } from "../../../utils/format";
 import { getMostRecentQuoteUpdate } from "../../../utils/quote-time";
+import { isQuoteStaleForCurrentSession } from "../../../utils/quote-freshness";
 import { priceColor } from "../../../theme/colors";
 import { PortfolioTickerTable, type QuoteFlashDirection } from "./table";
 import { useThrottledCursorSymbol } from "./use-throttled-cursor-symbol";
+import { isManualPortfolio } from "./mutations";
+import { QuickAddTickerInput, type QuickAddCollectionKind } from "./quick-add";
+import { PRICE_SPARKLINE_COLUMN_ID } from "../../../components/price-sparkline-view";
 
 const VISIBLE_FINANCIAL_REFRESH_COOLDOWN_MS = 5 * 60_000;
 const VISIBLE_FINANCIAL_WARMUP_DELAY_MS = 350;
+const VISIBLE_SNAPSHOT_WARMUP_BATCH_LIMIT = 3;
 const STREAM_OVERSCAN_ROWS = 6;
+const FUNDAMENTAL_COLUMN_IDS = new Set(["pe", "forward_pe", "dividend_yield"]);
 const sortValueCache = createRowValueCache<string, ReturnType<typeof getSortValue>>(5000);
 
-function needsVisibleFinancialWarmup(ticker: TickerRecord, financials: TickerFinancials | undefined): boolean {
+interface VisibleWarmupRequirements {
+  fundamentals: boolean;
+  priceHistory: boolean;
+}
+
+function resolveVisibleWarmupRequirements(columns: ColumnConfig[]): VisibleWarmupRequirements {
+  return {
+    fundamentals: columns.some((column) => FUNDAMENTAL_COLUMN_IDS.has(column.id)),
+    priceHistory: columns.some((column) => column.id === PRICE_SPARKLINE_COLUMN_ID),
+  };
+}
+
+function visibleWarmupKey(kind: "quote" | "snapshot", ticker: TickerRecord): string {
+  return `${kind}:${ticker.metadata.ticker}:${ticker.metadata.exchange ?? ""}`;
+}
+
+function needsVisibleQuoteWarmup(ticker: TickerRecord, financials: TickerFinancials | undefined, now = Date.now()): boolean {
+  return !financials?.quote || isQuoteStaleForCurrentSession(financials.quote, now);
+}
+
+function needsVisibleSnapshotWarmup(
+  ticker: TickerRecord,
+  financials: TickerFinancials | undefined,
+  requirements: VisibleWarmupRequirements,
+): boolean {
   if (ticker.metadata.assetCategory === "OPT") return false;
-  if (!financials) return true;
-  if (Object.keys(financials.fundamentals ?? {}).length === 0) return true;
-  return financials.priceHistory.length === 0;
+  if (!financials?.quote) return false;
+  if (requirements.fundamentals && Object.keys(financials.fundamentals ?? {}).length === 0) return true;
+  return requirements.priceHistory && financials.priceHistory.length === 0;
 }
 
 export function selectStreamTickers(
@@ -209,6 +239,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
   const [now, setNow] = useState(Date.now());
   const [flashSymbols, setFlashSymbols] = useState<Map<string, QuoteFlashDirection>>(new Map());
   const [streamWindow, setStreamWindow] = useState({ start: 0, end: 24 });
+  const [quickAddFocused, setQuickAddFocused] = useState(false);
 
   const previousPricesRef = useRef<Map<string, number>>(new Map());
   const mountedRef = useRef(true);
@@ -235,6 +266,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
   );
   const activeCollectionId = resolveActiveCollectionId(currentCollectionId, visibleCollections);
   const isPortfolioTab = getCollectionTypeFromConfig(config, activeCollectionId) === "portfolio";
+  const activeCollectionEntry = visibleCollections.find((collection) => collection.id === activeCollectionId) ?? null;
   const currentPortfolio = useMemo(() => (
     isPortfolioTab
       ? config.portfolios.find((portfolio) => portfolio.id === activeCollectionId) ?? null
@@ -248,12 +280,12 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
   const marketFinancialsMap = useTickerFinancialsMap(tickers);
   const sharedCoordinator = getSharedMarketDataCoordinator();
   const financialsMap = useMemo(() => {
-    const merged = sharedCoordinator ? new Map<string, TickerFinancials>() : new Map(cachedFinancials);
+    const merged = new Map(cachedFinancials);
     for (const [symbol, financials] of marketFinancialsMap) {
       merged.set(symbol, financials);
     }
     return merged;
-  }, [cachedFinancials, marketFinancialsMap, sharedCoordinator]);
+  }, [cachedFinancials, marketFinancialsMap]);
 
   const accountStateInput = useMemo(() => ({ brokerAccounts, config }), [brokerAccounts, config]);
   const accountState = usePortfolioAccountState(currentPortfolio, accountStateInput);
@@ -261,6 +293,10 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     () => resolveVisibleColumns(paneSettings.columnIds, isPortfolioTab),
     [isPortfolioTab, paneSettings.columnIds],
   );
+  const visibleWarmupRequirements = useMemo(
+    () => resolveVisibleWarmupRequirements(columns),
+    [columns],
+  );
 
   const trackedCurrencies = useMemo(
     () => buildTrackedCurrencies(tickers, financialsMap, accountState, config.baseCurrency),
@@ -334,6 +370,9 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     flushCursorSymbol(ticker.metadata.ticker);
     openTickerFloating(ticker.metadata.ticker);
   }, [flushCursorSymbol, openTickerFloating]);
+  const handleTickerAdded = useCallback((symbol: string) => {
+    setCursorSymbol(symbol, { immediate: true });
+  }, [setCursorSymbol]);
 
   const handleTableKeyDown = useCallback((event: DataTableKeyEvent) => {
     if (!focused) return;
@@ -425,11 +464,28 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     () => selectStreamTickers(sortedTickers, streamWindow, cursorSymbol),
     [cursorSymbol, sortedTickers, streamWindow],
   );
+  const priorityStreamSymbols = useMemo(
+    () => new Set(streamTickers.map((ticker) => ticker.metadata.ticker)),
+    [streamTickers],
+  );
+  const streamSurface = isPortfolioTab ? "portfolio" : "watchlist";
   const streamTargets = useMemo(() => (
-    streamTickers
-      .map((ticker) => quoteSubscriptionTargetFromTicker(ticker, ticker.metadata.ticker, "provider"))
+    sortedTickers
+      .map((ticker) => {
+        const target = quoteSubscriptionTargetFromTicker(ticker, ticker.metadata.ticker, "provider");
+        if (!target) return null;
+        const selected = ticker.metadata.ticker === cursorSymbol;
+        const visible = priorityStreamSymbols.has(ticker.metadata.ticker);
+        return {
+          ...target,
+          surface: streamSurface,
+          visible,
+          selected,
+          weight: selected ? 100 : visible ? 80 : 10,
+        };
+      })
       .filter((target): target is NonNullable<typeof target> => target != null)
-  ), [streamTickers]);
+  ), [cursorSymbol, priorityStreamSymbols, sortedTickers, streamSurface]);
   const visibleFinancialTickers = useMemo(
     () => sortedTickers.slice(streamWindow.start, streamWindow.end),
     [sortedTickers, streamWindow.end, streamWindow.start],
@@ -441,31 +497,64 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     if (!sharedCoordinator) return;
 
     const nowTimestamp = Date.now();
-    const queue = visibleFinancialTickers.filter((ticker) => {
-      const key = `${ticker.metadata.ticker}:${ticker.metadata.exchange ?? ""}`;
-      if (warmupInFlightRef.current.has(key)) return false;
-      if (nowTimestamp - (warmupAttemptRef.current.get(key) ?? 0) < VISIBLE_FINANCIAL_REFRESH_COOLDOWN_MS) return false;
-      return needsVisibleFinancialWarmup(ticker, financialsMap.get(ticker.metadata.ticker));
-    });
-    if (queue.length === 0) return;
+    const quoteQueue: TickerRecord[] = [];
+    const snapshotQueue: TickerRecord[] = [];
+    for (const ticker of visibleFinancialTickers) {
+      const financials = financialsMap.get(ticker.metadata.ticker);
+      const quoteKey = visibleWarmupKey("quote", ticker);
+      if (
+        needsVisibleQuoteWarmup(ticker, financials, nowTimestamp)
+        && !warmupInFlightRef.current.has(quoteKey)
+        && nowTimestamp - (warmupAttemptRef.current.get(quoteKey) ?? 0) >= VISIBLE_FINANCIAL_REFRESH_COOLDOWN_MS
+      ) {
+        quoteQueue.push(ticker);
+        continue;
+      }
+
+      const snapshotKey = visibleWarmupKey("snapshot", ticker);
+      if (
+        needsVisibleSnapshotWarmup(ticker, financials, visibleWarmupRequirements)
+        && !warmupInFlightRef.current.has(snapshotKey)
+        && nowTimestamp - (warmupAttemptRef.current.get(snapshotKey) ?? 0) >= VISIBLE_FINANCIAL_REFRESH_COOLDOWN_MS
+      ) {
+        snapshotQueue.push(ticker);
+      }
+    }
+    const limitedSnapshotQueue = snapshotQueue.slice(0, VISIBLE_SNAPSHOT_WARMUP_BATCH_LIMIT);
+    if (quoteQueue.length === 0 && limitedSnapshotQueue.length === 0) return;
 
     let cancelled = false;
     const runBatch = async (): Promise<void> => {
-      const entries = queue.flatMap((ticker) => {
+      const quoteEntries = quoteQueue.flatMap((ticker) => {
+        const instrument = instrumentFromTicker(ticker, ticker.metadata.ticker);
+        if (!instrument) return [];
+        const key = visibleWarmupKey("quote", ticker);
+        warmupInFlightRef.current.add(key);
+        warmupAttemptRef.current.set(key, nowTimestamp);
+        return [{ key, instrument }];
+      });
+      const snapshotEntries = limitedSnapshotQueue.flatMap((ticker) => {
         const instrument = instrumentFromTicker(ticker, ticker.metadata.ticker);
         if (!instrument) return [];
-        const key = `${ticker.metadata.ticker}:${ticker.metadata.exchange ?? ""}`;
+        const key = visibleWarmupKey("snapshot", ticker);
         warmupInFlightRef.current.add(key);
         warmupAttemptRef.current.set(key, nowTimestamp);
         return [{ key, instrument }];
       });
-      if (entries.length === 0) return;
+      if (quoteEntries.length === 0 && snapshotEntries.length === 0) return;
       try {
-        await sharedCoordinator.loadSnapshotsBatch(entries.map((entry) => entry.instrument));
+        await Promise.allSettled([
+          quoteEntries.length > 0
+            ? sharedCoordinator.loadQuotesBatch(quoteEntries.map((entry) => entry.instrument))
+            : Promise.resolve(),
+          snapshotEntries.length > 0
+            ? sharedCoordinator.loadSnapshotsBatch(snapshotEntries.map((entry) => entry.instrument))
+            : Promise.resolve(),
+        ]);
       } catch {
         // Best-effort warmup for visible rows only.
       } finally {
-        for (const entry of entries) {
+        for (const entry of [...quoteEntries, ...snapshotEntries]) {
           warmupInFlightRef.current.delete(entry.key);
         }
       }
@@ -479,7 +568,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
       cancelled = true;
       clearTimeout(timeoutId);
     };
-  }, [appActive, financialsMap, focused, sharedCoordinator, visibleFinancialTickers]);
+  }, [appActive, financialsMap, focused, sharedCoordinator, visibleFinancialTickers, visibleWarmupRequirements]);
 
   useQuoteStreaming(streamTargets);
 
@@ -555,6 +644,30 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
       : [],
   }), [cashDrawerExpanded, setCashDrawerExpanded, showCashDrawer, summaryFooterInfo]);
 
+  const quickAddCollectionKind = useMemo<QuickAddCollectionKind | null>(() => {
+    if (!activeCollectionId) return null;
+    const collectionType = getCollectionTypeFromConfig(config, activeCollectionId);
+    if (collectionType === "watchlist") return "watchlist";
+    if (collectionType === "portfolio" && currentPortfolio && isManualPortfolio(currentPortfolio)) {
+      return "portfolio";
+    }
+    return null;
+  }, [activeCollectionId, config, currentPortfolio]);
+  const showQuickAdd = !!(activeCollectionId && activeCollectionEntry && quickAddCollectionKind);
+  const quickAddHeight = showQuickAdd ? 1 : 0;
+  const tableHeight = Math.max(1, height - headerHeight - drawerHeight - quickAddHeight);
+  const quickAddRow = activeCollectionId && activeCollectionEntry && quickAddCollectionKind ? (
+    <QuickAddTickerInput
+      collectionId={activeCollectionId}
+      collectionKind={quickAddCollectionKind}
+      collectionName={activeCollectionEntry.name}
+      focused={focused}
+      width={width}
+      onAdded={handleTickerAdded}
+      onFocusChange={setQuickAddFocused}
+    />
+  ) : null;
+
   return (
     <Box flexDirection="column" width={width} height={height}>
       <Box flexDirection="column" height={headerHeight}>
@@ -575,7 +688,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
 
       <PortfolioTickerTable
         columns={columns}
-        focused={focused}
+        focused={focused && !quickAddFocused}
         sortColumnId={activeSort.columnId}
         sortDirection={activeSort.direction}
         onHeaderClick={handleHeaderClick}
@@ -590,8 +703,11 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
         visibleRangeBuffer={3}
         resetScrollKey={activeCollectionId}
         onRowActivate={handleRowActivate}
+        rootHeight={tableHeight}
       />
 
+      {quickAddRow}
+
       {showCashDrawer && accountState && (
         <Box height={drawerHeight} paddingX={1}>
           <PortfolioCashMarginDrawer