gloomberb 0.7.2 → 0.7.4

package/src/components/ticker-list-table.tsx

@@ -18,8 +18,7 @@ import type { ColumnConfig } from "../types/config";
 import type { TickerFinancials, PricePoint } from "../types/financials";
 import type { TickerRecord } from "../types/ticker";
 import { padTo } from "../utils/format";
-import { renderChart, resolveChartPalette, type StyledContent } from "./chart/chart-renderer";
-import type { ProjectedChartPoint } from "./chart/chart-data";
+import { PRICE_SPARKLINE_COLUMN_ID, PriceSparkline } from "./price-sparkline-view";
 import { tableContentWidthProps, useMeasuredTableContentWidth } from "./ui/table-layout";
 import { useViewport } from "../react/input";
 import { measurePerf } from "../utils/perf-marks";
@@ -57,17 +56,6 @@ const FLASHABLE_QUOTE_COLUMN_IDS = new Set([
   "pnl_pct",
 ]);
 
-function resolveQuoteFlashColor(direction: QuoteFlashDirection, fallbackColor: string): string {
-  switch (direction) {
-    case "up":
-      return colors.positive;
-    case "down":
-      return colors.negative;
-    default:
-      return fallbackColor === colors.textDim ? colors.text : colors.textBright;
-  }
-}
-
 export interface TickerListTableProps {
   columns: ColumnConfig[];
   tickers: TickerRecord[];
@@ -88,7 +76,6 @@ export interface TickerListTableProps {
   onRowActivate?: (ticker: TickerRecord) => void;
   emptyTitle?: string;
   emptyHint?: string;
-  showSparklines?: boolean;
   virtualize?: boolean;
   overscan?: number;
 }
@@ -155,38 +142,6 @@ const TickerListHeader = memo(function TickerListHeader({
   );
 });
 
-function renderSparkline(priceHistory: PricePoint[]): StyledContent | null {
-  if (priceHistory.length < 5) return null;
-
-  const last20 = priceHistory.slice(-20);
-  const points: ProjectedChartPoint[] = last20.map((pt) => ({
-    date: pt.date,
-    open: pt.open ?? pt.close,
-    high: pt.high ?? pt.close,
-    low: pt.low ?? pt.close,
-    close: pt.close,
-    volume: pt.volume ?? 0,
-  }));
-
-  const first = last20[0]?.close ?? 0;
-  const last = last20[last20.length - 1]?.close ?? 0;
-  const trend = last >= first ? "positive" : "negative";
-  const palette = resolveChartPalette(colors, trend);
-
-  const result = renderChart(points, {
-    width: 10,
-    height: 1,
-    showVolume: false,
-    volumeHeight: 0,
-    cursorX: null,
-    cursorY: null,
-    mode: "line",
-    colors: palette,
-  });
-
-  return result.lines[0] ?? null;
-}
-
 const TickerListRow = memo(function TickerListRow({
   columns,
   ticker,
@@ -201,7 +156,6 @@ const TickerListRow = memo(function TickerListRow({
   onRowActivate,
   onRowContextMenu,
   openContextMenuOnMouseDown,
-  showSparklines,
   priceHistory,
   contentWidth,
 }: {
@@ -218,7 +172,6 @@ const TickerListRow = memo(function TickerListRow({
   onRowActivate?: (ticker: TickerRecord) => void;
   onRowContextMenu: (ticker: TickerRecord, financials: TickerFinancials | undefined, event: unknown) => void;
   openContextMenuOnMouseDown: boolean;
-  showSparklines?: boolean;
   priceHistory?: PricePoint[];
   contentWidth: number;
 }) {
@@ -226,10 +179,6 @@ const TickerListRow = memo(function TickerListRow({
   const lastActivatedAtRef = useRef<number | null>(null);
   const rowBg = isSelected ? colors.selected : isHovered ? hoverBg() : colors.bg;
 
-  const sparkline = showSparklines && priceHistory && priceHistory.length >= 5
-    ? renderSparkline(priceHistory)
-    : null;
-
   return (
     <Box
       flexDirection="row"
@@ -268,26 +217,29 @@ const TickerListRow = memo(function TickerListRow({
       }}
     >
       {columns.map((column) => {
+        if (column.id === PRICE_SPARKLINE_COLUMN_ID) {
+          return (
+            <Box key={column.id} width={column.width + 1} overflow="hidden">
+              <PriceSparkline priceHistory={priceHistory} width={column.width} />
+            </Box>
+          );
+        }
+
         const { text, color } = resolveCell(column, ticker, financials);
         const baseFg = color || (isSelected ? colors.selectedText : colors.text);
         const shouldFlash = flashDirection != null && FLASHABLE_QUOTE_COLUMN_IDS.has(column.id);
-        const cellFg = shouldFlash
-          ? resolveQuoteFlashColor(flashDirection, baseFg)
-          : baseFg;
 
         return (
           <Box key={column.id} width={column.width + 1}>
-            <Text fg={cellFg}>
+            <Text
+              fg={baseFg}
+              attributes={shouldFlash ? TextAttributes.DIM : TextAttributes.NONE}
+            >
               {padTo(text, column.width, column.align)}
             </Text>
           </Box>
         );
       })}
-      {sparkline && (
-        <Box width={12}>
-          <Text content={sparkline} />
-        </Box>
-      )}
     </Box>
   );
 }, (previous, next) => (
@@ -304,7 +256,6 @@ const TickerListRow = memo(function TickerListRow({
   && previous.onRowActivate === next.onRowActivate
   && previous.onRowContextMenu === next.onRowContextMenu
   && previous.openContextMenuOnMouseDown === next.openContextMenuOnMouseDown
-  && previous.showSparklines === next.showSparklines
   && previous.priceHistory === next.priceHistory
   && previous.contentWidth === next.contentWidth
 ));
@@ -329,7 +280,6 @@ export function TickerListTable({
   onRowActivate,
   emptyTitle = "No tickers.",
   emptyHint = "Press Ctrl+P to add one.",
-  showSparklines,
   virtualize = true,
   overscan = 4,
 }: TickerListTableProps) {
@@ -347,8 +297,8 @@ export function TickerListTable({
   hoveredIdxRef.current = hoveredIdx;
   const safeFlashSymbols = flashSymbols ?? EMPTY_FLASH_SYMBOLS;
   const tableWidth = useMemo(
-    () => columns.reduce((sum, column) => sum + column.width + 1, 2) + (showSparklines ? 12 : 0),
-    [columns, showSparklines],
+    () => columns.reduce((sum, column) => sum + column.width + 1, 2),
+    [columns],
   );
   const { contentWidth, measureContentWidth } = useMeasuredTableContentWidth(
     tableWidth,
@@ -492,7 +442,6 @@ export function TickerListTable({
                 onRowActivate={onRowActivate}
                 onRowContextMenu={handleRowContextMenu}
                 openContextMenuOnMouseDown={nativeContextMenu !== true}
-                showSparklines={showSparklines}
                 priceHistory={financialsMap.get(ticker.metadata.ticker)?.priceHistory}
                 contentWidth={contentWidth}
               />

package/src/components/toggle-list.tsx

@@ -1,6 +1,6 @@
 import { Box, Text, useUiHost } from "../ui";
 import { TextAttributes } from "../ui";
-import { colors } from "../theme/colors";
+import { blendHex, colors } from "../theme/colors";
 import { ListView, type ListRowState, type ListViewItem } from "./ui/list-view";
 
 export interface ToggleListItem {
@@ -76,8 +76,8 @@ function DesktopToggleRow({
           border: `1px solid ${checkboxBorder}`,
           borderRadius: 4,
           boxShadow: enabled
-            ? "inset 0 1px 0 rgba(255,255,255,0.28)"
-            : "inset 0 1px 0 rgba(255,255,255,0.05)",
+            ? `inset 0 1px 0 ${blendHex(colors.borderFocused, colors.textBright, 0.28)}`
+            : `inset 0 1px 0 ${blendHex(colors.bg, colors.textBright, 0.05)}`,
         }}
       >
         {enabled && (

package/src/components/ui/choice-dialog.tsx

@@ -2,6 +2,7 @@ import { useEffect, useMemo, useState } from "react";
 import { Box, Text } from "../../ui";
 import { type PromptContext, useDialogKeyboard } from "../../ui/dialog";
 import { colors } from "../../theme/colors";
+import { isPlainKey } from "../../utils/keyboard";
 import { DialogFrame } from "./frame";
 import { ListView, type ListViewItem } from "./list-view";
 
@@ -58,9 +59,9 @@ export function ChoiceDialog({
 
   useDialogKeyboard((event) => {
     event.stopPropagation();
-    if (event.name === "up" || event.name === "k") {
+    if (isPlainKey(event, "up", "k")) {
       setIndex((current) => clampChoiceIndex(current - 1, choices.length));
-    } else if (event.name === "down" || event.name === "j") {
+    } else if (isPlainKey(event, "down", "j")) {
       setIndex((current) => clampChoiceIndex(current + 1, choices.length));
     } else if (event.name === "enter" || event.name === "return") {
       activateChoice(selectedChoice);

package/src/components/ui/multi-select-dialog.tsx

@@ -5,6 +5,7 @@ import { type AlertContext, useDialog, useDialogKeyboard } from "../../ui/dialog
 import { type ReactNode, useEffect, useMemo, useState } from "react";
 import { colors } from "../../theme/colors";
 import { isDetailBackNavigationKey } from "../../utils/back-navigation";
+import { isPlainKey } from "../../utils/keyboard";
 import { ToggleList } from "../toggle-list";
 import { Button } from "./button";
 import { DialogFrame } from "./frame";
@@ -176,10 +177,10 @@ export function MultiSelectDialogContent({
 
   useDialogKeyboard((event) => {
     event.stopPropagation();
-    if (event.name === "up" || event.name === "k") {
+    if (isPlainKey(event, "up", "k")) {
       const nextIndex = Math.max(0, selectedIndex - 1);
       setSelectedOptionId(displayOptions[nextIndex]?.value ?? selectedOptionId);
-    } else if (event.name === "down" || event.name === "j") {
+    } else if (isPlainKey(event, "down", "j")) {
       const nextIndex = Math.min(displayOptions.length - 1, selectedIndex + 1);
       setSelectedOptionId(displayOptions[nextIndex]?.value ?? selectedOptionId);
     } else if (isSpaceKey(event)) {

package/src/components/ui/native-select.tsx

@@ -2,7 +2,7 @@
 
 import { type CSSProperties } from "react";
 import { Box } from "../../ui";
-import { colors } from "../../theme/colors";
+import { blendHex, colors } from "../../theme/colors";
 
 export type NativeSelectElement = HTMLSelectElement & { showPicker?: () => void };
 
@@ -51,11 +51,11 @@ export function NativeSelect({
     width,
     height: 28,
     color: colors.text,
-    backgroundColor: "rgba(255, 255, 255, 0.06)",
+    backgroundColor: blendHex(colors.panel, colors.textBright, 0.06),
     border: `1px solid ${colors.border}`,
     borderRadius: 6,
     padding: "0 8px",
-    boxShadow: "inset 0 1px 0 rgba(255,255,255,0.05)",
+    boxShadow: `inset 0 1px 0 ${blendHex(colors.bg, colors.textBright, 0.05)}`,
     cursor: "pointer",
     font: "inherit",
     letterSpacing: 0,