gloomberb 0.7.2 → 0.7.4

package/src/news/aggregator.ts

@@ -12,6 +12,9 @@ const MAX_ARTICLES = 500;
 const DEFAULT_POLL_INTERVAL_MS = 2 * 60 * 1000;
 const DEFAULT_GLOBAL_QUERY: NewsQuery = { feed: "latest", limit: MAX_ARTICLES };
 const FEEDS = new Set<NewsFeed>(["latest", "top", "breaking", "ticker", "sector", "topic"]);
+const DETAIL_CAPABLE_ARTICLE = Symbol("detail-capable-news-article");
+
+type DetailCapableArticle = NewsArticle & { [DETAIL_CAPABLE_ARTICLE]?: true };
 
 function normalizeTicker(ticker: string | undefined): string {
   return ticker ? normalizeSymbol(ticker) : "";
@@ -101,6 +104,57 @@ function sortByPublishedAt(items: NewsArticle[]): NewsArticle[] {
   return [...items].sort((a, b) => b.publishedAt.getTime() - a.publishedAt.getTime());
 }
 
+function hasStoryItems(item: NewsArticle | null | undefined): boolean {
+  return (item?.items?.length ?? 0) > 0;
+}
+
+function markDetailCapableArticle(source: NewsCapability, item: NewsArticle): NewsArticle {
+  if (!source.provider.fetchNewsStory) return item;
+  Object.defineProperty(item, DETAIL_CAPABLE_ARTICLE, {
+    value: true,
+    configurable: true,
+  });
+  return item;
+}
+
+function isDetailCapableArticle(item: NewsArticle): boolean {
+  return (item as DetailCapableArticle)[DETAIL_CAPABLE_ARTICLE] === true;
+}
+
+function shouldReplaceDuplicate(existing: NewsArticle, item: NewsArticle): boolean {
+  return (
+    item.importance > existing.importance ||
+    (item.importance === existing.importance && item.publishedAt > existing.publishedAt)
+  );
+}
+
+function selectDetailArticle(
+  existing: NewsArticle,
+  item: NewsArticle,
+  winner: NewsArticle,
+): NewsArticle | null {
+  if (isDetailCapableArticle(winner)) return winner;
+  if (isDetailCapableArticle(item)) return item;
+  if (isDetailCapableArticle(existing)) return existing;
+  if (hasStoryItems(winner)) return winner;
+  if (hasStoryItems(item)) return item;
+  if (hasStoryItems(existing)) return existing;
+  return null;
+}
+
+function mergeDuplicateArticle(existing: NewsArticle, item: NewsArticle): NewsArticle {
+  const winner = shouldReplaceDuplicate(existing, item)
+    ? { ...existing, ...item }
+    : existing;
+  const detailArticle = selectDetailArticle(existing, item, winner);
+  if (!detailArticle || detailArticle.id === winner.id) return winner;
+  return {
+    ...winner,
+    id: detailArticle.id,
+    items: hasStoryItems(detailArticle) ? detailArticle.items : winner.items,
+  };
+}
+
 function dedupeArticles(items: NewsArticle[]): NewsArticle[] {
   const byKey = new Map<string, NewsArticle>();
   for (const item of items) {
@@ -110,12 +164,7 @@ function dedupeArticles(items: NewsArticle[]): NewsArticle[] {
       byKey.set(key, item);
       continue;
     }
-    if (
-      item.importance > existing.importance ||
-      (item.importance === existing.importance && item.publishedAt > existing.publishedAt)
-    ) {
-      byKey.set(key, { ...existing, ...item });
-    }
+    byKey.set(key, mergeDuplicateArticle(existing, item));
   }
   return sortByPublishedAt([...byKey.values()]).slice(0, MAX_ARTICLES);
 }
@@ -382,7 +431,8 @@ export class NewsService {
     let firstEmpty: SourceFetchResult | null = null;
     for (const source of sources) {
       try {
-        const articles = await source.provider.fetchNews(query);
+        const articles = (await source.provider.fetchNews(query))
+          .map((article) => markDetailCapableArticle(source, article));
         const result = { articles, sourceIds: [newsCapabilitySourceId(source)] };
         if (articles.length > 0) return result;
         firstEmpty ??= result;
@@ -397,7 +447,8 @@ export class NewsService {
     const settled = await Promise.allSettled(
       sources.map(async (source) => ({
         source,
-        articles: await source.provider.fetchNews(query),
+        articles: (await source.provider.fetchNews(query))
+          .map((article) => markDetailCapableArticle(source, article)),
       })),
     );
     const articles: NewsArticle[] = [];
@@ -418,7 +469,8 @@ export class NewsService {
     let changed = false;
     for (const query of queries) {
       if (source.isEnabled?.() === false || news.supports?.(query) === false) continue;
-      const cached = news.getCachedNews?.(query) ?? [];
+      const cached = (news.getCachedNews?.(query) ?? [])
+        .map((article) => markDetailCapableArticle(source, article));
       if (cached.length === 0) continue;
       const key = buildNewsQueryKey(query);
       const current = this.queryStates.get(key) ?? createIdleState();

package/src/plugins/builtin/ai/ask-ai-detail-tab.tsx

@@ -300,13 +300,32 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
     nativePaneChrome,
     terminalBottomInset: terminalFooterClearance,
   });
-  const chatHeight = Math.max(height - composerBlockHeight, 0);
+  const chatHeight = nativePaneChrome ? undefined : Math.max(height - composerBlockHeight, 0);
+  const layoutHeight = nativePaneChrome ? "100%" : height;
+  const nativeFillStyle = nativePaneChrome ? { minHeight: 0 } : undefined;
 
   return (
-    <Box flexDirection="column" paddingX={nativePaneChrome ? 0 : 1} height={height} overflow="hidden">
-      {chatHeight > 0 && (
-        <ScrollBox ref={scrollRef} height={chatHeight} scrollY>
-          <Box flexDirection="column" paddingX={nativePaneChrome ? 1 : 0}>
+    <Box
+      flexDirection="column"
+      paddingX={nativePaneChrome ? 0 : 1}
+      height={layoutHeight}
+      flexGrow={nativePaneChrome ? 1 : undefined}
+      overflow="hidden"
+      style={nativeFillStyle}
+    >
+      {(nativePaneChrome || (chatHeight ?? 0) > 0) && (
+        <ScrollBox
+          ref={scrollRef}
+          height={nativePaneChrome ? undefined : chatHeight}
+          flexGrow={nativePaneChrome ? 1 : undefined}
+          scrollY
+          style={nativeFillStyle}
+        >
+          <Box
+            flexDirection="column"
+            paddingX={nativePaneChrome ? 1 : 0}
+            style={nativeFillStyle}
+          >
             {messages.length === 0 ? (
               <Box paddingTop={1}>
                 <Text fg={colors.textDim}>
@@ -354,7 +373,7 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
         placeholder="Ask a question..."
         terminalPrefix=" > "
         terminalBottomInset={terminalFooterClearance}
-        width={nativePaneChrome ? width : contentWidth}
+        width={nativePaneChrome ? "100%" : contentWidth}
         height={composerHeight}
         onFocusRequest={focusInput}
         onInput={(value) => setInputValue(value)}

package/src/plugins/builtin/ai/screener-pane.tsx

@@ -432,6 +432,9 @@ export function AiScreenerPane({ focused, width, height }: PaneProps) {
   const quoteTargets = useMemo(() => (
     sortedTickers
       .map((ticker) => quoteSubscriptionTargetFromTicker(ticker, ticker.metadata.ticker))
+      .map((target) => target
+        ? { ...target, surface: "screener" as const, visible: true, weight: 70 }
+        : null)
       .filter((target): target is NonNullable<ReturnType<typeof quoteSubscriptionTargetFromTicker>> => target != null)
   ), [sortedTickers]);
 

package/src/plugins/builtin/ai/settings.ts

@@ -60,6 +60,9 @@ export function resolveVisibleAiScreenerColumns(columnIds: string[]): ColumnConf
 export function buildAiScreenerPaneSettingsDef(settings: AiScreenerPaneSettings): PaneSettingsDef {
   return {
     title: "AI Screener Settings",
+    values: {
+      columnIds: [...settings.columnIds],
+    },
     fields: [
       {
         key: "columnIds",

package/src/plugins/builtin/broker-manager/index.tsx

@@ -32,6 +32,7 @@ import type { GloomPlugin, PaneProps } from "../../../types/plugin";
 import type { BrokerAccount } from "../../../types/trading";
 import { useDialog, type PromptContext } from "../../../ui/dialog";
 import { formatCurrency } from "../../../utils/format";
+import { isPlainKey } from "../../../utils/keyboard";
 import { usePluginAppActions, usePluginBrokerActions } from "../../plugin-runtime";
 import {
   buildBrokerProfileRows,
@@ -47,7 +48,7 @@ type BrokerColumn = DataTableColumn & { id: BrokerColumnId };
 function stateColor(state: BrokerDisplayState): string {
   switch (state) {
     case "connected": return colors.positive;
-    case "connecting": return "#e5c07b";
+    case "connecting": return colors.warning;
     case "error": return colors.negative;
     case "disabled": return colors.textMuted;
     case "unavailable": return colors.negative;
@@ -442,13 +443,13 @@ export function BrokersPane({ focused, width, height }: PaneProps) {
         saveEdit().catch(() => {});
         return;
       }
-      if (event.name === "up" || event.name === "k") {
+      if (isPlainKey(event, "up", "k")) {
         event.stopPropagation();
         const index = editKeys.indexOf(activeEditKey);
         setActiveEditKey(editKeys[Math.max(0, index - 1)] ?? "label");
         return;
       }
-      if (event.name === "down" || event.name === "j" || event.name === "tab") {
+      if (isPlainKey(event, "down", "j", "tab")) {
         event.stopPropagation();
         const index = editKeys.indexOf(activeEditKey);
         setActiveEditKey(editKeys[Math.min(editKeys.length - 1, index + 1)] ?? "label");