gloomberb 0.18.4 → 0.19.0

package/src/app/runtime/broker-import.ts

@@ -1,4 +1,4 @@
-import { useCallback, type Dispatch } from "react";
+import { useCallback, useRef, type Dispatch } from "react";
 import {
   rebaseBrokerSyncConfig,
   restoreBrokerPortfoliosFromTickerPositions,
@@ -28,7 +28,6 @@ export interface AppBrokerImportRuntime {
 interface BrokerImportOptions {
   refreshImportedTickers?: boolean;
   config?: AppConfig;
-  persistResolvedBrokerConfig?: boolean;
   signal?: AbortSignal;
   onCommitStart?: () => void;
   onCommitEnd?: () => void;
@@ -53,6 +52,7 @@ export function useBrokerImportRuntime({
   stateRef: { current: AppState };
   tickerRepository: AppTickerRepositoryPort;
 }): AppBrokerImportRuntime {
+  const syncRequests = useRef(new Map<string, object>());
   /**
    * Commits a sync: carried onto the app as it is now (a pull or an edit while
    * the broker answered stays) and handed to the app before anything is
@@ -104,36 +104,51 @@ export function useBrokerImportRuntime({
     tickerMap?: Map<string, TickerRecord>,
     options?: BrokerImportOptions,
   ) => {
-    const baseConfig = options?.config ?? stateRef.current.config;
-    const result = await syncBrokerInstance({
-      config: baseConfig,
-      instanceId,
-      brokers: pluginRegistry.brokers,
-      tickerRepository,
-      existingTickers: tickerMap ?? new Map(stateRef.current.tickers),
-      resources: pluginRegistry.persistence.resources,
-      persistResolvedBrokerConfig: options?.persistResolvedBrokerConfig,
-      signal: options?.signal,
-      deferPersistence: true,
-    });
-
-    // A profile removed while its broker was answering stays removed, positions included.
-    if (!options?.config && !getBrokerInstance(stateRef.current.config.brokerInstances, instanceId)) return result;
-    let commitStarted = false;
+    const request = {};
+    syncRequests.current.set(instanceId, request);
+    const report = (error: string | null) => {
+      // A late read must not replace the outcome of a newer manual retry.
+      if (syncRequests.current.get(instanceId) === request && !options?.signal?.aborted) {
+        dispatch({ type: "SET_BROKER_SYNC_ERROR", instanceId, error });
+      }
+    };
     try {
-      throwIfBrokerImportCancelled(options?.signal);
-      options?.onCommitStart?.();
-      commitStarted = true;
-      await applyBrokerImportResult(instanceId, result, baseConfig, {
-        ...options,
-        callerOwnsConfig: options?.config !== undefined,
+      const baseConfig = options?.config ?? stateRef.current.config;
+      const result = await syncBrokerInstance({
+        config: baseConfig,
+        instanceId,
+        brokers: pluginRegistry.brokers,
+        tickerRepository,
+        existingTickers: tickerMap ?? new Map(stateRef.current.tickers),
+        resources: pluginRegistry.persistence.resources,
+        signal: options?.signal,
+        deferPersistence: true,
       });
 
-      return result;
+      // A profile removed while its broker was answering stays removed, positions included.
+      if (!options?.config && !getBrokerInstance(stateRef.current.config.brokerInstances, instanceId)) return result;
+      let commitStarted = false;
+      try {
+        throwIfBrokerImportCancelled(options?.signal);
+        options?.onCommitStart?.();
+        commitStarted = true;
+        await applyBrokerImportResult(instanceId, result, baseConfig, {
+          ...options,
+          callerOwnsConfig: options?.config !== undefined,
+        });
+
+        report(null);
+        return result;
+      } finally {
+        if (commitStarted) options?.onCommitEnd?.();
+      }
+    } catch (error) {
+      report("Positions could not be synced. Use Sync to retry.");
+      throw error;
     } finally {
-      if (commitStarted) options?.onCommitEnd?.();
+      if (syncRequests.current.get(instanceId) === request) syncRequests.current.delete(instanceId);
     }
-  }, [applyBrokerImportResult, pluginRegistry.brokers, pluginRegistry.persistence.resources, stateRef, tickerRepository]);
+  }, [applyBrokerImportResult, dispatch, pluginRegistry.brokers, pluginRegistry.persistence.resources, stateRef, tickerRepository]);
 
   const autoImportBrokerPositions = useCallback(async (tickerMap: Map<string, TickerRecord>) => {
     // Once per install, manual portfolios held in one other currency take it (see adoptHeldPortfolioCurrencies).

package/src/app/runtime/plugin-bindings.ts

@@ -10,6 +10,8 @@ import type { MarketDataCoordinator } from "../../market-data/coordinator";
 import { instrumentFromTicker } from "../../market-data/request-types";
 import type { PluginRegistry } from "../../plugins/registry";
 import { saveConfigImmediately } from "../../state/config-save-scheduler";
+import { persistTickerCleanup } from "../../state/ticker-cleanup";
+import { hasPendingTickerWrites } from "../../data/ticker-writes";
 import { settleWithin } from "../../utils/async-deadline";
 import type { AppAction, AppState } from "../../state/app/context";
 import type { AppConfig, BrokerInstanceConfig } from "../../types/config";
@@ -215,66 +217,81 @@ export function bindPluginRegistryRuntimeAccess({
         else removedPortfolioIds.add(portfolio.id);
       }
 
-      const nextPortfolios = stateRef.current.config.portfolios.flatMap((portfolio) => {
-        if (removedPortfolioIds.has(portfolio.id)) return [];
-        const heirId = heirs.get(portfolio.id);
-        return [heirId ? { ...portfolio, brokerInstanceId: heirId } : portfolio];
+      const removeProfile = (config: AppConfig): AppConfig => ({
+        ...config,
+        brokerInstances: config.brokerInstances.filter((entry) => entry.id !== instanceId),
+        portfolios: config.portfolios.flatMap((portfolio) => {
+          if (removedPortfolioIds.has(portfolio.id)) return [];
+          const heirId = heirs.get(portfolio.id);
+          return [heirId ? { ...portfolio, brokerInstanceId: heirId } : portfolio];
+        }),
       });
-      const nextTickers = new Map(stateRef.current.tickers);
-      const nextBrokerInstances = stateRef.current.config.brokerInstances.filter((entry) => entry.id !== instanceId);
-      // What older removals and pulls from other devices left behind goes as well.
-      const known = knownBrokerHoldings({ portfolios: nextPortfolios, brokerInstances: nextBrokerInstances });
 
-      for (const ticker of stateRef.current.tickers.values()) {
-        // A position here without a profile came from another device's sync of this one.
-        const nextPositions = ticker.metadata.positions.filter((position) => position.brokerInstanceId !== instanceId
-          && !(removedPortfolioIds.has(position.portfolio) && !position.brokerInstanceId));
-        const heldPortfolioIds = new Set(nextPositions.map((position) => position.portfolio));
-        const nextPortfolioRefs = ticker.metadata.portfolios.filter((portfolioId) =>
-          !removedPortfolioIds.has(portfolioId) && (!heirs.has(portfolioId) || heldPortfolioIds.has(portfolioId)));
-        const nextBrokerContracts = (ticker.metadata.broker_contracts ?? []).filter((contract) => contract.brokerInstanceId !== instanceId);
-
-        const removedTicker: TickerRecord = {
-          ...ticker,
-          metadata: {
-            ...ticker.metadata,
-            positions: nextPositions,
-            portfolios: nextPortfolioRefs,
-            broker_contracts: nextBrokerContracts,
-          },
-        };
-        const nextTicker = clearLeftoverBrokerHoldings(removedTicker, known) ?? removedTicker;
-
-        const shouldDeleteTicker =
-          nextTicker.metadata.positions.length === 0
-          && nextTicker.metadata.portfolios.length === 0
-          && nextTicker.metadata.watchlists.length === 0
-          && (nextTicker.metadata.broker_contracts ?? []).length === 0
-          && nextTicker.metadata.tags.length === 0
-          && Object.keys(nextTicker.metadata.custom).length === 0;
+      const cleanTickers = () => persistTickerCleanup({
+        tickerRepository,
+        getTickers: () => stateRef.current.tickers,
+        transform: (ticker) => {
+          // A position without a profile came from another device's sync of this one.
+          const nextPositions = ticker.metadata.positions.filter((position) => position.brokerInstanceId !== instanceId
+            && !(removedPortfolioIds.has(position.portfolio) && !position.brokerInstanceId));
+          const heldPortfolioIds = new Set(nextPositions.map((position) => position.portfolio));
+          const nextPortfolioRefs = ticker.metadata.portfolios.filter((portfolioId) =>
+            !removedPortfolioIds.has(portfolioId) && (!heirs.has(portfolioId) || heldPortfolioIds.has(portfolioId)));
+          const nextBrokerContracts = (ticker.metadata.broker_contracts ?? []).filter((contract) => contract.brokerInstanceId !== instanceId);
+          const changed = nextPositions.length !== ticker.metadata.positions.length
+            || nextPortfolioRefs.length !== ticker.metadata.portfolios.length
+            || nextBrokerContracts.length !== (ticker.metadata.broker_contracts ?? []).length;
+          const removedTicker: TickerRecord = changed ? {
+            ...ticker,
+            metadata: {
+              ...ticker.metadata,
+              positions: nextPositions,
+              portfolios: nextPortfolioRefs,
+              broker_contracts: nextBrokerContracts,
+            },
+          } : ticker;
+          // Also clear holdings left behind by older removals or pulls.
+          const known = knownBrokerHoldings(removeProfile(stateRef.current.config));
+          const nextTicker = clearLeftoverBrokerHoldings(removedTicker, known) ?? removedTicker;
+          if (nextTicker === ticker) return ticker;
+          const empty = nextTicker.metadata.positions.length === 0
+            && nextTicker.metadata.portfolios.length === 0
+            && nextTicker.metadata.watchlists.length === 0
+            && (nextTicker.metadata.broker_contracts ?? []).length === 0
+            && nextTicker.metadata.tags.length === 0
+            && Object.keys(nextTicker.metadata.custom).length === 0;
+          return empty ? null : nextTicker;
+        },
+        publish: (symbol, ticker) => {
+          if (ticker) dispatch({ type: "UPDATE_TICKER", ticker });
+          else {
+            dispatch({ type: "REMOVE_TICKER", symbol });
+            pluginRegistry.events.emit("ticker:removed", { symbol });
+          }
+        },
+      });
 
-        if (shouldDeleteTicker) {
-          nextTickers.delete(ticker.metadata.ticker);
-          await tickerRepository.deleteTicker(ticker.metadata.ticker);
-          dispatch({ type: "REMOVE_TICKER", symbol: ticker.metadata.ticker });
-          pluginRegistry.events.emit("ticker:removed", { symbol: ticker.metadata.ticker });
-        } else {
-          await tickerRepository.saveTicker(nextTicker);
-          nextTickers.set(nextTicker.metadata.ticker, nextTicker);
-          dispatch({ type: "UPDATE_TICKER", ticker: nextTicker });
-        }
+      // Keep the profile available for retry until cleanup and config both
+      // succeed. Rebase after callbacks and edits, including during config saves.
+      let savedRemoval = false;
+      for (;;) {
+        const cleaned = await cleanTickers().catch(async (error: unknown) => {
+          // A config acknowledgement can precede a late row write. If that
+          // cleanup fails, keep its removal intent durable for a restart too.
+          if (savedRemoval) await saveConfigImmediately(stateRef.current.config);
+          throw error;
+        });
+        if (hasPendingTickerWrites(tickerRepository) || stateRef.current.tickers !== cleaned) continue;
+        const source = stateRef.current.config;
+        const nextConfig = removeProfile(source);
+        await saveConfigImmediately(nextConfig);
+        savedRemoval = true;
+        if (stateRef.current.config !== source || stateRef.current.tickers !== cleaned
+          || hasPendingTickerWrites(tickerRepository)) continue;
+        dispatch({ type: "SET_CONFIG", config: nextConfig });
+        pluginRegistry.events.emit("config:changed", { config: nextConfig });
+        break;
       }
-
-      const nextConfig = {
-        ...stateRef.current.config,
-        brokerInstances: nextBrokerInstances,
-        portfolios: nextPortfolios,
-      };
-
-      dispatch({ type: "SET_CONFIG", config: nextConfig });
-      dispatch({ type: "SET_TICKERS", tickers: nextTickers });
-      await saveConfigImmediately(nextConfig);
-      pluginRegistry.events.emit("config:changed", { config: nextConfig });
       // The profile that kept a portfolio fills in what the removed one held there.
       for (const heirId of new Set(heirs.values())) {
         void importBrokerPositions(heirId).catch(logFailure("app.runtime.plugin-bindings", "Replacement broker positions import failed"));

package/src/architecture/core-builtin-allowlist.json

@@ -27,7 +27,7 @@
   "src/components/layout/shell/index.tsx": ["cloud"],
   "src/components/onboarding/use-onboarding-upgrade.ts": ["chat"],
   "src/layout/desks.ts": ["chart-composer"],
-  "src/plugins/catalog-browser.ts": ["alerts","analytics","attention","awards","backtest","bond-calculator","catalysts","cds","central-bank-rates","changelog","chart-composer","clinical-trials","cloud","comment-letters","commodities-energy","commodity-balances","company-attention","company-kpis","connections","correlation","cot","cpi","credit-boards","credit-conditions","credit-documents","crypto-board","crypto-etf-flows","debt-maturities","dividend-yield","docs","doe","earnings-calls","earnings-ripple","econ","econ-statistics","equity-screener","estimate-revisions","executives","exposure","fear-greed","filing-events","fixed-income","futures","futures-curve","fx-matrix","gpu","help","insider","ipo-calendar","iv-history","jobs","jodi","kelly-sizer","layout-manager","macro-day","market-halts","market-heatmap","market-valuation","members","mna","money-markets","news","openfda","options","options-calculator","options-positioning","options-scenario","pe-band","perps","portfolio-list","power","primary-dealers","rate-path","realized-vol","relative-rotation","research","research-search","revenue-breakdown","reverse-dcf","risk-factors","scanner","seasonality","sec","sectors","short-interest","short-volume","social-mentions","supply-chain","ticker-detail","time-sales","trace-bonds","treasury-auctions","treasury-daily","vol-surface","volatility","world-indices","world-venue-map","yield-curve"],
+  "src/plugins/catalog-browser.ts": ["alerts","analytics","attention","awards","backtest","bond-calculator","catalysts","cds","central-bank-rates","changelog","chart-composer","clinical-trials","cloud","comment-letters","commodities-energy","commodity-balances","company-attention","company-kpis","connections","correlation","cot","cpi","credit-boards","credit-conditions","credit-documents","crypto-board","crypto-etf-flows","debt-maturities","dividend-yield","docs","doe","earnings","earnings-calls","earnings-ripple","econ","econ-statistics","equity-screener","estimate-revisions","executives","exposure","fear-greed","filing-events","fixed-income","futures","futures-curve","fx-matrix","gpu","help","holders","insider","ipo-calendar","iv-history","jobs","jodi","kelly-sizer","layout-manager","macro-day","market-halts","market-heatmap","market-valuation","members","mna","money-markets","news","openfda","options","options-calculator","options-positioning","options-scenario","pe-band","perps","portfolio-list","power","primary-dealers","rate-path","realized-vol","relative-rotation","research","research-search","revenue-breakdown","reverse-dcf","risk-factors","scanner","seasonality","sec","sectors","short-interest","short-volume","social-mentions","supply-chain","thirteenf","ticker-detail","time-sales","trace-bonds","treasury-auctions","treasury-daily","vol-surface","volatility","world-indices","world-venue-map","yield-curve"],
   "src/plugins/catalog-ui.ts": ["alerts","clinical-trials","cloud","comment-letters","custom-view","fear-greed","ipo-calendar","market-halts","market-heatmap","members","news","notes","openfda","research-search"],
   "src/plugins/catalog.ts": ["debug"],
   "src/remote/controller.ts": ["custom-view"],

package/src/architecture/pane-tabs-allowlist.json

@@ -53,6 +53,9 @@
   "src/plugins/builtin/research-search/pane.tsx": {
     "signInRequired || verificationRequired": "Signed out or unverified, every mode is the same sign-in wall."
   },
+  "src/plugins/builtin/scanner/flow-pane.tsx": {
+    "!feed.denied": "Signed out or without Pro, every tab is the same sign-in or plan wall."
+  },
   "src/plugins/builtin/shared/filing-year-reader.tsx": {
     "years.length > 1": "The tabs are the filings on record, known once their list answers; a single filing has no other year to pick."
   },

package/src/architecture/ttl-caches-allowlist.json

@@ -0,0 +1,19 @@
+{
+  "src/plugins/builtin/alerts/metric-model.ts": {
+    "deadline: now < cached.retryAt": "A byte-identical copy of Gloom Cloud's delivery model (metric-parity-fixture.json pins its hash), so it cannot import the helper. Its failed-read backoff is the rejectionMs rule; move it when both copies move together.",
+    "map: new Map<string, { day: string; retryAt: number; result: Promise<MetricReading>; }>()": "A byte-identical copy of Gloom Cloud's delivery model (metric-parity-fixture.json pins its hash), so it cannot import the helper. Its failed-read backoff is the rejectionMs rule; move it when both copies move together."
+  },
+  "src/plugins/builtin/cloud-tweets/table.tsx": {
+    "age: Date.now() - cached.fetchedAt < TWEET_CACHE_TTL_MS": "Feed results kept across tab switches and shown stale while a refetch runs; the entry's fetchedAt also drives the pane's auto-refresh and moves with every appended page, so the stamp is state the view reads.",
+    "map: new Map<string, { data: CloudTweetSearchResponse; fetchedAt: number; hasMore: boolean; }>()": "Feed results kept across tab switches and shown stale while a refetch runs; the entry's fetchedAt also drives the pane's auto-refresh and moves with every appended page, so the stamp is state the view reads."
+  },
+  "src/plugins/builtin/correlation/index.tsx": {
+    "map: new Map<string, { values: DailyClose[]; fetchedAt: number; }>()": "Not a TTL cache: the last good series per range, kept so a failed refresh still draws it. Nothing expires, and fetchedAt is shown with the data."
+  },
+  "src/plugins/builtin/portfolio-list/since-last-seen.ts": {
+    "map: new Map<string, Departure>()": "Not loaded data: what a pane showed when it went out of sight, read once on return against the reader's own away threshold, then used up."
+  },
+  "src/plugins/builtin/sec/command-bar-search.ts": {
+    "map: new Map<string, FocusRequest>()": "Not loaded data: a filing to focus handed from the command bar to the SEC pane, taken on first read and dropped after a few seconds unread."
+  }
+}

package/src/brokers/sync-broker-instance.ts

@@ -32,7 +32,6 @@ export interface SyncBrokerInstanceArgs {
   tickerRepository: AppTickerRepositoryPort;
   existingTickers?: Map<string, TickerRecord>;
   resources?: AppResourceStorePort;
-  persistResolvedBrokerConfig?: boolean;
   signal?: AbortSignal;
   deferPersistence?: boolean;
 }
@@ -69,7 +68,6 @@ export interface SyncBrokerInstancesArgs {
   tickerRepository: AppTickerRepositoryPort;
   existingTickers: Map<string, TickerRecord>;
   resources?: AppResourceStorePort;
-  persistResolvedBrokerConfig?: boolean;
   /** Leave each result's ticker writes to `onResult`, which calls `result.commit()`. */
   deferPersistence?: boolean;
   onResult?: (result: SyncBrokerInstanceResult, instance: BrokerInstanceConfig, previousConfig: AppConfig) => void | Promise<void>;
@@ -168,9 +166,8 @@ async function maybePersistResolvedBrokerConfig(
   config: AppConfig,
   instance: BrokerInstanceConfig,
   broker: BrokerAdapter,
-  persistResolvedBrokerConfig: boolean,
 ): Promise<AppConfig> {
-  if (!persistResolvedBrokerConfig || !broker.getPersistedConfigUpdate) {
+  if (!broker.getPersistedConfigUpdate) {
     return config;
   }
 
@@ -203,7 +200,6 @@ export async function syncBrokerInstance({
   tickerRepository,
   existingTickers,
   resources,
-  persistResolvedBrokerConfig = false,
   signal,
   deferPersistence = false,
 }: SyncBrokerInstanceArgs): Promise<SyncBrokerInstanceResult> {
@@ -336,7 +332,7 @@ export async function syncBrokerInstance({
     : []);
 
   nextConfig = removeStaleBrokerPortfolios(nextConfig, instance.id, currentPortfolioIds);
-  nextConfig = await maybePersistResolvedBrokerConfig(nextConfig, instance, broker, persistResolvedBrokerConfig);
+  nextConfig = await maybePersistResolvedBrokerConfig(nextConfig, instance, broker);
   throwIfBrokerImportCancelled(signal);
   nextConfig = markBrokerInstanceSynced(nextConfig, instance.id, syncedAt);
   const syncedConfig = nextConfig;
@@ -436,7 +432,6 @@ export async function syncBrokerInstances({
   tickerRepository,
   existingTickers,
   resources,
-  persistResolvedBrokerConfig = false,
   deferPersistence = false,
   onResult,
 }: SyncBrokerInstancesArgs): Promise<SyncBrokerInstancesResult> {
@@ -457,7 +452,6 @@ export async function syncBrokerInstances({
         tickerRepository,
         existingTickers: nextTickers,
         resources,
-        persistResolvedBrokerConfig,
         deferPersistence,
       });
 

package/src/capabilities/chart-series.ts

@@ -28,7 +28,7 @@ const SERIES_ID_PATTERN = /^[A-Za-z0-9][A-Za-z0-9._~%:/-]{0,239}$/;
 const chartSeriesLog = debugLog.createLogger("chart-series");
 const ranges = new Set<string>(TIME_RANGES);
 const periods = new Set(["auto", "daily", "weekly", "monthly", "quarterly", "annual", "ttm"]);
-const styles = new Set(["line", "area", "step", "columns", "points", "candles", "ohlc", "hlc"]);
+const styles = new Set(["line", "area", "step", "columns", "points", "candles", "hollow", "heikin-ashi", "ohlc", "hlc"]);
 const transforms = new Set(["raw", "percent", "index100", "yoy", "qoq", "log"]);
 const shapes = new Set(["scalar", "ohlcv", "event", "band"]);
 const axes = new Set(["left", "right"]);

package/src/cli/commands/crypto-hints.ts

@@ -1,7 +1,7 @@
 import { isCryptoInstrumentType } from "../../tickers/search/ranking";
 import { isCryptoVenuePerpetual } from "../../tickers/instrument-kind";
 import type { Quote } from "../../types/financials";
-import { isCryptoPairSymbol, MAJOR_COIN_NAMES } from "../../utils/crypto-pair";
+import { isCryptoPairSymbol, TOP_COIN_NAMES } from "../../utils/crypto-pair";
 import { isNotATickerMessage } from "../not-a-ticker";
 import { groupByCompany } from "../../tickers/company-name";
 import { DATA_SERVICE_UNREACHABLE_MESSAGE } from "../../utils/network-failure";
@@ -10,27 +10,49 @@ import type { TickerRecord } from "../../types/ticker";
 /** Where a crypto pair that will not load can still be read. `fn CRYP` takes no argument. */
 export const CRYPTO_BOARD_HINT = "Crypto prices may be briefly unavailable; the CRYP function (gloom fn CRYP) shows the crypto board.";
 
-// How the note names the coin, and what a listing's name has to say before the note applies.
-const MAJOR_COINS = MAJOR_COIN_NAMES;
+// How the note names the coin, and which tickers it speaks for.
+const MAJOR_COINS = TOP_COIN_NAMES;
+
+/** What a coin note reads of a listing: its quote's, or what a saved listing keeps. */
+interface CoinListing {
+  name?: string | null;
+  instrumentType?: string | null;
+  /** The feed says the price is old. */
+  stale?: boolean;
+  /** The exchange removed the listing, or its last trade is all that is known. */
+  delisting?: unknown;
+}
 
 /**
- * A bare coin ticker usually resolves to a listed fund, not the coin. The note applies only when
- * the listing is not crypto and its own name says the coin (a "Bitcoin" trust), so a company that
- * happens to share the letters (Interlink Electronics on LINK) is left alone. Every command that
- * reads a bare symbol as a listing says it: quote, ticker, and the portfolio and watchlist adds.
+ * A bare coin ticker usually resolves to a listing that is not the coin. The note applies to a
+ * top coin's symbol whenever the listing is not a crypto product, and says how sure it is:
+ *
+ * - "SOL is Emeren Group ..., not solana. For solana use SOL-USD." when the listing cannot be
+ *   what was meant: its name says the coin (a "Bitcoin" trust), or it is stale or delisted
+ *   (SOL's Emeren Group last traded months ago).
+ * - "LINK is Interlink Electronics, Inc. Also a coin: LINK-USD." for a live company that
+ *   happens to share the letters, which may well be the one meant.
+ *
+ * Every command that reads a bare symbol as a listing says it: quote, ticker, history, options,
+ * news, charts, alerts, and the portfolio and watchlist adds.
  */
-export function notTheCoinNote(symbol: string, quote: Pick<Quote, "name" | "instrumentType"> | null | undefined): string | null {
+export function notTheCoinNote(symbol: string, listing: CoinListing | null | undefined): string | null {
   const coin = MAJOR_COINS.get(symbol);
-  const type = quote?.instrumentType?.trim();
-  const name = quote?.name?.trim();
+  const type = listing?.instrumentType?.trim();
+  const name = listing?.name?.trim();
   if (!coin || !name || !type || isCryptoInstrumentType(type)) return null;
-  if (!new RegExp(`\\b${coin}\\b`, "i").test(name)) return null;
-  return `${symbol} is ${name}, not ${coin}. For ${coin} use ${symbol}-USD.`;
+  const cannotBeIt = listing?.stale === true || !!listing?.delisting || new RegExp(`\\b${coin}\\b`, "i").test(name);
+  return cannotBeIt
+    ? `${symbol} is ${name}, not ${coin}. For ${coin} use ${symbol}-USD.`
+    : `${symbol} is ${name}${/[.!?]$/.test(name) ? "" : "."} Also a coin: ${symbol}-USD.`;
 }
 
-/** `notTheCoinNote` for a saved listing, by the name and asset category it was saved with. */
-export function savedListingCoinNote(symbol: string, ticker: Pick<TickerRecord, "metadata">): string | null {
-  return notTheCoinNote(symbol, { name: ticker.metadata.name, instrumentType: ticker.metadata.assetCategory });
+/**
+ * `notTheCoinNote` for a saved listing, by the name and asset category it was saved with.
+ * `ended` says the listing stopped trading, which the saved record does not keep.
+ */
+export function savedListingCoinNote(symbol: string, ticker: Pick<TickerRecord, "metadata">, { ended = false }: { ended?: boolean } = {}): string | null {
+  return notTheCoinNote(symbol, { name: ticker.metadata.name, instrumentType: ticker.metadata.assetCategory, stale: ended });
 }
 
 /**
@@ -70,10 +92,10 @@ function failureReason(message: string, symbol: string): string {
 
 /**
  * Text-mode notes under a quote table: one line per distinct failure reason (with the crypto board
- * pointer when a failed symbol is a crypto pair, unless nothing could be reached), then a line for each bare coin ticker that
- * resolved to something else. `--exchange` names the listing on purpose, so it gets no coin note.
+ * pointer when a failed symbol is a crypto pair, unless nothing could be reached), then the perpetual futures line.
+ * A bare coin ticker read as another listing is said with the listing (`listingChoiceNotes`).
  */
-export function quoteNotes(results: QuoteNoteResult[], options: { exchange?: string } = {}): string[] {
+export function quoteNotes(results: QuoteNoteResult[]): string[] {
   const failures = new Map<string, string[]>();
   for (const result of results) {
     if (!result.error || result.quote) continue;
@@ -87,12 +109,6 @@ export function quoteNotes(results: QuoteNoteResult[], options: { exchange?: str
       ? reason
       : `${symbols.join(", ")}: ${reason}${symbols.some(isCryptoPairSymbol) && reason !== DATA_SERVICE_UNREACHABLE_MESSAGE ? `${/[.!?]$/.test(reason) ? "" : "."} ${CRYPTO_BOARD_HINT}` : ""}`
   ));
-  if (!options.exchange) {
-    for (const result of results) {
-      const note = notTheCoinNote(result.target.symbol, result.quote);
-      if (note) notes.push(note);
-    }
-  }
   const perpetuals = results
     .filter((result) => result.quote && isCryptoVenuePerpetual(result.quote.instrumentType, result.quote.name))
     .map((result) => result.target.symbol);

package/src/cli/commands/fred-series.ts

@@ -44,6 +44,11 @@ export function fredInterval(frequency: string | null | undefined): string | nul
   return word || null;
 }
 
+/** Whether a series' dates are days it was observed on (FRED's `Daily`, `Weekly, Ending Friday`), not the start of a period; false when it does not say. */
+export function fredObservesDays(frequency: string | null | undefined): boolean {
+  return /^(?:daily|weekly)\b/i.test(frequency?.trim() ?? "");
+}
+
 /**
  * The observations from the series' first one on: Gloom Cloud answers a
  * `--start` before a series begins with a blank row for every day in between

package/src/cli/commands/keybindings.ts

@@ -1,6 +1,8 @@
 import {
   applyActionBinding,
+  coreActionOnChord,
   describeKeybindingIssue,
+  formatChordForHost,
   isCoreKeybindingActionId,
   isTypingChord,
   parseKeyChord,
@@ -9,7 +11,9 @@ import {
   resolveKeybindings,
   serializeKeyChord,
   setCommandBinding,
+  takenChordMessage,
   updateKeybindingsConfig,
+  type KeyChord,
 } from "../../app/keybindings";
 import type { AppConfig } from "../../types/config";
 
@@ -34,6 +38,21 @@ export function describeKeybindingsForCli(config: AppConfig): Record<string, unk
   };
 }
 
+/**
+ * Why the first of `chords` a built-in action other than `exceptId` already
+ * uses is refused, as the shortcuts editor says it; null when none is. The
+ * table is the terminal's and the desktop's at once, so an action either has
+ * keeps its key.
+ */
+function takenByCoreAction(config: AppConfig, chords: readonly KeyChord[], exceptId?: string): string | null {
+  const resolved = resolveKeybindings(config.keybindings);
+  for (const chord of chords) {
+    const core = coreActionOnChord(resolved, chord, exceptId);
+    if (core) return takenChordMessage(formatChordForHost(chord, "terminal"), core);
+  }
+  return null;
+}
+
 export type KeybindingCliSetResult =
   | { ok: true; config: AppConfig; value: unknown }
   | { ok: false; message: string };
@@ -71,6 +90,8 @@ export function applyKeybindingCliSet(config: AppConfig, key: string, rawValue:
       if (!chord) return { ok: false, message: `"${text}" is not a key chord. Examples: Ctrl+T, CmdOrCtrl+Shift+F, Alt+1, F5, \`` };
       chords.push(chord);
     }
+    const taken = takenByCoreAction(config, chords, target);
+    if (taken) return { ok: false, message: taken };
     return {
       ok: true,
       config: updateKeybindingsConfig(config, applyActionBinding(config.keybindings, target, chords)),
@@ -91,6 +112,8 @@ export function applyKeybindingCliSet(config: AppConfig, key: string, rawValue:
     if (isTypingChord(chord)) {
       return { ok: false, message: `"${target}" would fire while typing; command bindings need Ctrl, Cmd, Alt or a function key.` };
     }
+    const taken = takenByCoreAction(config, [chord]);
+    if (taken) return { ok: false, message: taken };
     return {
       ok: true,
       config: updateKeybindingsConfig(config, setCommandBinding(config.keybindings, chord, value)),