gloomberb 0.18.4 → 0.19.0

package/src/plugins/builtin/chat/content/index.tsx

@@ -57,6 +57,7 @@ import type { ContextMenuItem } from "../../../../types/context-menu";
 import { usePluginAppActions } from "../../../runtime";
 import { openTeamPane } from "../../../../team/pane-request";
 import { openChatPaneLink } from "../pane-links/open";
+import { runChatCommand, useChatFunctions } from "../pane-links/commands";
 import type { ChatMessagePaneLink } from "../pane-links/model";
 import { splitComposerDraft, type ComposerShareLink } from "../pane-links/composer";
 import { teamStore } from "../../../../team/store";
@@ -71,6 +72,7 @@ import {
   detectChatMentionTrigger,
   filterMentionSuggestions,
 } from "./mentions";
+import { applyCommandSuggestion, detectChatCommandTrigger, filterCommandSuggestions } from "./command-suggestions";
 import { getComposerCursorOffset } from "./composer-cursor";
 import { ChatHandlePrompt, chatHandlePromptRows, handleSavedMessage, useChatHandlePrompt } from "./handle-prompt";
 
@@ -321,12 +323,31 @@ export function ChatContent({
     if (!mentionTrigger || mentionTriggerKey === dismissedMentionKey) return [];
     return filterMentionSuggestions(recentMentionSuggestions, mentionTrigger.query);
   }, [dismissedMentionKey, mentionTrigger, mentionTriggerKey, recentMentionSuggestions]);
-  const mentionSelectedIndexSafe = mentionSuggestions.length > 0
-    ? Math.min(mentionSelectedIndex, mentionSuggestions.length - 1)
+  // Desktop and web: after a backtick the same list offers functions, which a message draws as chips there.
+  const commandTrigger = useMemo(() => (
+    nativePaneChrome && !mentionTrigger ? detectChatCommandTrigger(composerDraft, composerCursorOffset) : null
+  ), [composerCursorOffset, composerDraft, mentionTrigger, nativePaneChrome]);
+  const commandTriggerKey = commandTrigger
+    ? `${channelId}:code:${commandTrigger.start}:${commandTrigger.end}:${commandTrigger.query}`
+    : null;
+  const functions = useChatFunctions();
+  const commandSuggestions = useMemo(() => {
+    if (!commandTrigger || commandTriggerKey === dismissedMentionKey) return [];
+    return filterCommandSuggestions(functions, commandTrigger.query);
+  }, [commandTrigger, commandTriggerKey, dismissedMentionKey, functions]);
+  // One list at a time: people after @, functions after a backtick.
+  const suggestionTriggerKey = mentionTriggerKey ?? commandTriggerKey;
+  const suggestionCount = mentionSuggestions.length + commandSuggestions.length;
+  const composerSuggestions = useMemo(() => mentionSuggestions.length > 0
+    ? mentionSuggestions.map((suggestion) => ({ id: suggestion.username, label: `@${suggestion.username}` }))
+    : commandSuggestions.map((suggestion) => ({ id: suggestion.code, label: suggestion.code, detail: suggestion.name })),
+  [commandSuggestions, mentionSuggestions]);
+  const mentionSelectedIndexSafe = suggestionCount > 0
+    ? Math.min(mentionSelectedIndex, suggestionCount - 1)
     : 0;
   useEffect(() => {
     setMentionSelectedIndex(0);
-  }, [mentionTriggerKey]);
+  }, [suggestionTriggerKey]);
   const {
     composerHeight,
     messageAreaHeight,
@@ -335,7 +356,7 @@ export function ChatContent({
     composerRows,
     editingMessage,
     height,
-    mentionSuggestionCount: mentionSuggestions.length,
+    mentionSuggestionCount: suggestionCount,
     nativePaneChrome,
     replyTo,
     stackHeader: stackedNav && !channelListOpen,
@@ -568,12 +589,13 @@ export function ChatContent({
     if (controller.attachToChannel(channelIdRef.current, files.map(uploadFromTransferFile)) > 0) focusInput();
   }, [canAttach, controller, focusInput, imagesAvailable, notify]);
 
-  // A chip under a message: the shared pane, or the story or calendar a Wire post names.
+  // A chip: the shared pane, the story or calendar a Wire post names, or a function written in a message.
   const openPaneLink = useCallback((link: ChatMessagePaneLink) => {
     openChatPaneLink(link, {
       createPaneFromTemplate,
       notify,
       openExternal: (url) => { void rendererHost.openExternal(url); },
+      runCommand: runChatCommand,
     });
   }, [createPaneFromTemplate, notify, rendererHost]);
 
@@ -821,41 +843,48 @@ export function ChatContent({
   }, [directMessageContext, messageUser, selectedMessageAuthor]);
 
   const moveMentionSelection = useCallback((direction: "up" | "down") => {
-    if (mentionSuggestions.length === 0) return false;
+    if (suggestionCount === 0) return false;
     setMentionSelectedIndex((current) => {
-      const safeCurrent = Math.max(0, Math.min(current, mentionSuggestions.length - 1));
+      const safeCurrent = Math.max(0, Math.min(current, suggestionCount - 1));
       if (direction === "up") {
-        return safeCurrent <= 0 ? mentionSuggestions.length - 1 : safeCurrent - 1;
+        return safeCurrent <= 0 ? suggestionCount - 1 : safeCurrent - 1;
       }
-      return safeCurrent >= mentionSuggestions.length - 1 ? 0 : safeCurrent + 1;
+      return safeCurrent >= suggestionCount - 1 ? 0 : safeCurrent + 1;
     });
     return true;
-  }, [mentionSuggestions.length]);
+  }, [suggestionCount]);
 
   const dismissMentionSuggestions = useCallback(() => {
-    if (!mentionTriggerKey || mentionSuggestions.length === 0) return false;
-    setDismissedMentionKey(mentionTriggerKey);
+    if (!suggestionTriggerKey || suggestionCount === 0) return false;
+    setDismissedMentionKey(suggestionTriggerKey);
     return true;
-  }, [mentionSuggestions.length, mentionTriggerKey]);
+  }, [suggestionCount, suggestionTriggerKey]);
 
   const commitMentionSelection = useCallback((index = mentionSelectedIndexSafe) => {
-    if (!mentionTrigger || mentionSuggestions.length === 0) return false;
-    const suggestion = mentionSuggestions[index] ?? mentionSuggestions[0];
-    if (!suggestion) return false;
-    const replacement = applyMentionSuggestion(composerDraft, mentionTrigger, suggestion);
+    let replacement: { draft: string; cursorOffset: number } | null = null;
+    if (mentionTrigger && mentionSuggestions.length > 0) {
+      const suggestion = mentionSuggestions[index] ?? mentionSuggestions[0]!;
+      replacement = applyMentionSuggestion(composerDraft, mentionTrigger, suggestion);
+    } else if (commandTrigger && commandSuggestions.length > 0) {
+      const suggestion = commandSuggestions[index] ?? commandSuggestions[0]!;
+      replacement = applyCommandSuggestion(composerDraft, commandTrigger, suggestion);
+    }
+    if (!replacement) return false;
     replaceComposerDraft(replacement.draft, replacement.cursorOffset);
     setMentionSelectedIndex(0);
-    setDismissedMentionKey(mentionTriggerKey);
+    setDismissedMentionKey(suggestionTriggerKey);
     queueMicrotask(() => focusInput());
     return true;
   }, [
+    commandSuggestions,
+    commandTrigger,
     composerDraft,
     focusInput,
     mentionSelectedIndexSafe,
     mentionSuggestions,
     mentionTrigger,
-    mentionTriggerKey,
     replaceComposerDraft,
+    suggestionTriggerKey,
   ]);
 
   const {
@@ -941,7 +970,7 @@ export function ChatContent({
     inputValueRef,
     loadingOlderMessages,
     messages,
-    mentionMenuOpen: mentionSuggestions.length > 0,
+    mentionMenuOpen: suggestionCount > 0,
     moveMentionSelection,
     dismissMentionSuggestions,
     commitMentionSelection,
@@ -1193,7 +1222,7 @@ export function ChatContent({
         replyPreview={replyPreview}
         replyTo={replyTo}
         sendMessage={sendMessage}
-        mentionSuggestions={mentionSuggestions}
+        suggestions={composerSuggestions}
         mentionSelectedIndex={mentionSelectedIndexSafe}
         onMentionCursorChange={syncComposerCursor}
         onMentionSelect={commitMentionSelection}

package/src/plugins/builtin/chat/content/open-targets.ts

@@ -4,6 +4,7 @@ import { chatMessageTokens } from "../markdown";
 import { chatImageLabel } from "../attachments/model";
 import { wirePaneTarget, type ChatMessagePaneLink } from "../pane-links/model";
 import { chatPaneLinkPane, peekSharePreview } from "../pane-links/previews";
+import { resolveChatCommand, type ChatFunction } from "../pane-links/commands";
 
 export type ChatOpenTarget =
   | { kind: "pane"; link: ChatMessagePaneLink; label: string }
@@ -11,8 +12,9 @@ export type ChatOpenTarget =
   | { kind: "link"; url: string; label: string }
   | { kind: "image"; index: number; url: string; label: string };
 
-/** What the Open list calls a chip: the share's title once read, else its link; a Wire post's pane. */
+/** What the Open list calls a chip: the share's title once read, else its link; a Wire post's pane; a function as written. */
 function paneLinkLabel(link: ChatMessagePaneLink): string {
+  if (link.kind === "command") return link.query;
   if (link.kind === "share") {
     const preview = peekSharePreview(link.id);
     return preview.status === "ready" ? preview.title : link.url;
@@ -27,13 +29,16 @@ function paneLinkLabel(link: ChatMessagePaneLink): string {
  * share links and Wire link open), the ticker badges its text draws (a symbol
  * the catalog does not know stays plain text), its links, then its images.
  * `content` is the text the message draws, without the links its chips stand
- * for. Code is text, so nothing in it is offered.
+ * for. Code is text, so nothing in it is offered, except where `functions` is
+ * given (the desktop and the web): there a function written in backticks is a
+ * chip, offered where the text names it.
  */
 export function chatMessageOpenTargets(
   content: string,
   catalog: Record<string, InlineTickerCatalogEntry>,
   attachments: readonly ChatAttachment[] = [],
   paneLinks: readonly ChatMessagePaneLink[] = [],
+  functions?: ReadonlyMap<string, ChatFunction>,
 ): ChatOpenTarget[] {
   const targets: ChatOpenTarget[] = paneLinks.map((link) => ({ kind: "pane", link, label: paneLinkLabel(link) }));
   const seen = new Set<string>();
@@ -45,7 +50,13 @@ export function chatMessageOpenTargets(
       continue;
     }
     open = null;
-    if (token.kind === "ticker") {
+    const command = functions && token.kind === "text" && token.style?.code ? resolveChatCommand(token.value, functions) : null;
+    if (command) {
+      if (seen.has(`command:${command.query}`)) continue;
+      seen.add(`command:${command.query}`);
+      const link = { kind: "command", query: command.query, name: command.fn.name } as const;
+      targets.push({ kind: "pane", link, label: paneLinkLabel(link) });
+    } else if (token.kind === "ticker") {
       const entry = catalog[token.symbol];
       if (!entry || entry.status === "missing" || seen.has(`ticker:${token.symbol}`)) continue;
       seen.add(`ticker:${token.symbol}`);

package/src/plugins/builtin/chat/controller/session-runtime.ts

@@ -121,7 +121,7 @@ export async function refreshChatControllerSession({
   stopVerificationPolling,
   syncVerificationPolling,
 }: RefreshChatControllerSessionOptions): Promise<void> {
-  session.sessionToken = apiClient.getSessionToken();
+  const cachedToken = session.sessionToken;
   const apiSession = await apiClient.getSession(isCurrent);
   if (!isCurrent()) return;
   if (!apiSession) {
@@ -133,7 +133,9 @@ export async function refreshChatControllerSession({
     // startup from signing the user out.
     if (persistedToken) {
       session.sessionToken = persistedToken;
-      session.user = session.user ?? normalizeSessionUser(apiClient.getCurrentUser());
+      // A failed sign-in can install another token before its user arrives.
+      // Only the credential stored with a cached user can restore that user.
+      session.user = (cachedToken === persistedToken ? session.user : null) ?? normalizeSessionUser(apiClient.getCurrentUser());
       // getSession() clears the API client's cached user when the endpoint
       // answers null. Keep both session views aligned while the protected
       // request validates the preserved native credential.

package/src/plugins/builtin/chat/index.tsx

@@ -23,6 +23,8 @@ import { ChatStatusWidget } from "./status-widget";
 import { UnreadInboxPane } from "./unread-inbox-pane";
 import { installPaneChatSharing } from "./share/flow";
 import { attachChatPaneLinkPanes } from "./pane-links/previews";
+import { attachChatCommands, cachedChatFunctions, chatFunctionsChanged } from "./pane-links/commands";
+import { getSharedRegistry } from "../../registry";
 import { UNREAD_INBOX_PANE_ID, UNREAD_INBOX_TEMPLATE_ID } from "./unread-inbox";
 import { watchUnreadBadge } from "./unread-badge";
 import { getAppBadgeHost } from "../../../notifications/app-badge";
@@ -54,6 +56,7 @@ function isPrivateConversation(channelId: unknown): boolean {
 
 let disposePaneChatSharing: (() => void) | undefined;
 let detachPaneLinkPanes: (() => void) | undefined;
+let detachCommands: (() => void) | undefined;
 let disposeUnreadBadge: (() => void) | undefined;
 
 export const chatModule: PluginModule = {
@@ -154,6 +157,24 @@ export const chatModule: PluginModule = {
     // A chip names the pane it opens (any plugin's) and its letter.
     detachPaneLinkPanes?.();
     detachPaneLinkPanes = attachChatPaneLinkPanes((paneId) => ctx.getPaneDef(paneId));
+    // A function written in a message is a chip for the codes this app runs, and runs in its command bar.
+    detachCommands?.();
+    detachCommands = attachChatCommands({
+      functions: () => {
+        const registry = getSharedRegistry();
+        if (!registry) return cachedChatFunctions(null);
+        const disabledPlugins = ctx.getConfig().disabledPlugins ?? [];
+        return cachedChatFunctions({
+          paneTemplates: registry.paneTemplates,
+          commands: registry.commands,
+          disabledPlugins,
+          isTemplateOff: (templateId) => !!registry.getDisabledPaneTemplateOwner(templateId, disabledPlugins),
+        });
+      },
+      run: (query) => getSharedRegistry()?.runCommandBarQuery(query),
+    });
+    // Messages drawn before a plugin came in, or with one since switched off, draw its codes again.
+    for (const event of ["plugin:registered", "plugin:unregistered", "config:changed"] as const) ctx.on(event, chatFunctionsChanged);
     chatController.attachPersistence(ctx.persistence, ctx.resume);
     chatSidebarStore.attach(ctx.persistence);
     chatHandlePromptStore.attach(ctx.persistence);
@@ -198,6 +219,8 @@ export const chatModule: PluginModule = {
     disposePaneChatSharing = undefined;
     detachPaneLinkPanes?.();
     detachPaneLinkPanes = undefined;
+    detachCommands?.();
+    detachCommands = undefined;
     // Before the controller drops its listeners, so the badge is cleared with the plugin.
     disposeUnreadBadge?.();
     disposeUnreadBadge = undefined;

package/src/plugins/builtin/chat/message/desktop.tsx

@@ -206,6 +206,7 @@ export const DesktopChatMessage = memo(function DesktopChatMessage({
               textColor={state.bodyColor}
               mutedColor={state.bodyMutedColor}
               openTicker={openTicker}
+              openPaneLink={openPaneLink}
               userByUsername={userByUsername}
               onUserHover={onUserHover}
               onUserHoverEnd={onUserHoverEnd}

package/src/plugins/builtin/chat/message/inline-tokens.tsx

@@ -9,6 +9,9 @@ import type { ChatUserSummary } from "../../../../api-client";
 import { parseMarkdownLines, type MarkdownLine } from "../../../../utils/markdown";
 import { chatBadgeTextWidth, type ChatBodyLine } from "../layout";
 import { chatInlineTokens, type ChatInlineToken, type ChatTextStyle } from "../markdown";
+import { resolveChatCommand, useChatFunctions } from "../pane-links/commands";
+import type { ChatMessagePaneLink } from "../pane-links/model";
+import { DesktopChatPaneChip } from "./pane-chip";
 import type { ChatUserAnchor, ChatUserContextMenuEvent } from "./types";
 
 interface ChatUserHandlers {
@@ -25,6 +28,11 @@ interface ChatTextProps extends ChatUserHandlers {
   /** Code, list markers, a quote's bar and a link's host. */
   mutedColor: string;
   openTicker: (symbol: string) => void;
+  /**
+   * Desktop and web: opens a function written in backticks, which then draws
+   * as a chip. Without it, as in the terminal, the code stays text.
+   */
+  openPaneLink?: (link: ChatMessagePaneLink) => void;
 }
 
 /** Desktop and web: a run of text inside a line, which wraps with the line. */
@@ -111,6 +119,7 @@ function ChatTokens({
   hoveredSymbol,
   setHoveredSymbol,
   userByUsername,
+  openPaneLink,
   ...userHandlers
 }: ChatTextProps & {
   tokens: readonly ChatInlineToken[];
@@ -122,12 +131,26 @@ function ChatTokens({
   setHoveredSymbol: (update: (current: string | null) => string | null) => void;
 }) {
   const { nativeContextMenu } = useUiCapabilities();
+  const allFunctions = useChatFunctions();
+  const functions = inline && openPaneLink ? allFunctions : null;
   return (
     <>
       {tokens.map((token, index) => {
         const key = `${keyPrefix}:${index}`;
         if (token.kind === "text") {
           if (!token.value) return null;
+          const command = functions && token.style?.code ? resolveChatCommand(token.value, functions) : null;
+          if (command && openPaneLink) {
+            return (
+              <Box key={key} justifyContent="center" style={INLINE_CHIP_STYLE}>
+                <DesktopChatPaneChip
+                  link={{ kind: "command", query: command.query, name: command.fn.name }}
+                  dimmed={false}
+                  onOpen={openPaneLink}
+                />
+              </Box>
+            );
+          }
           const fg = styleColor(token.style, textColor, mutedColor);
           const attributes = styleAttributes(token.style) || undefined;
           return inline

package/src/plugins/builtin/chat/message/pane-chip.tsx

@@ -14,8 +14,9 @@ import { DESKTOP_DRAFT_STRIP_STYLE } from "../attachments/desktop";
 /**
  * A chip for something a message opens in the terminal: a shared pane (its
  * title and the pane it is, with the picture its sender posted when there is
- * one) or a Gloom Wire post's story or calendar. It always takes the same
- * room, before and after the share is read, so the transcript never moves.
+ * one), a Gloom Wire post's story or calendar, or a function written in
+ * backticks, drawn in its line of text. It always takes the same room, before
+ * and after the share is read, so the transcript never moves.
  */
 
 interface ChatPaneChipContent {
@@ -30,6 +31,7 @@ interface ChatPaneChipContent {
 function useChatPaneChipContent(link: ChatMessagePaneLink): ChatPaneChipContent {
   const shareId = link.kind === "share" ? link.id : "";
   const preview = useSharePreview(shareId);
+  if (link.kind === "command") return { title: link.query, detail: link.name, icon: "" };
   if (link.kind === "share") {
     if (preview.status !== "ready") return { title: link.url, detail: "", icon: "" };
     const pane = chatPaneLinkPane(preview.paneId);
@@ -87,6 +89,52 @@ export function DesktopChatPaneChip({
   const height = compact ? COMPACT_CHIP_HEIGHT : preview ? PICTURE_CHIP_HEIGHT : SHARE_CHIP_HEIGHT;
   const border = hovered ? themeColors.borderFocused : blendHex(themeColors.border, themeColors.bg, 0.35);
   const surface = blendHex(themeColors.panel, themeColors.bg, hovered ? 0.2 : 0.5);
+  const label = [content.title, content.detail].filter(Boolean).join(", ");
+  const pressable = {
+    "aria-label": label || undefined,
+    // A share's link, and what a function written in a message is called.
+    title: link.kind === "share" ? link.url : link.kind === "command" ? link.name : undefined,
+    onMouseEnter: () => setHovered(true),
+    onMouseLeave: () => setHovered(false),
+    // A press on the chip is not a press on the row behind it.
+    onMouseDown: (event: DomEventLike) => event.stopPropagation(),
+    onClick: (event: DomEventLike) => {
+      event.stopPropagation();
+      onOpen(link);
+    },
+  };
+  const buttonReset = { cursor: "pointer", font: "inherit", color: "inherit", textAlign: "left" };
+  const dataAttributes = {
+    "data-gloom-role": "chat-pane-chip",
+    "data-gloom-pane-link": link.kind === "share" ? `share:${link.id}` : link.kind === "command" ? `command:${link.query}` : link.link.kind,
+  };
+  if (link.kind === "command") {
+    // The same frame at the height of the line of text it is written in: the
+    // kit's chip, 16px in an 18px row, as the ticker chips beside it.
+    return createElement("button", {
+      type: "button",
+      ...dataAttributes,
+      ...pressable,
+      style: {
+        ...buttonReset,
+        boxSizing: "border-box",
+        display: "inline-flex",
+        alignItems: "center",
+        height: "calc(100% - 2px)",
+        maxWidth: "100%",
+        padding: "0 var(--gloom-space-sm)",
+        border: `1px solid ${border}`,
+        borderRadius: "var(--gloom-radius-sm)",
+        background: surface,
+        opacity: dimmed ? 0.6 : 1,
+        overflow: "hidden",
+        textOverflow: "ellipsis",
+        whiteSpace: "pre",
+        color: themeColors.textBright,
+        fontWeight: "var(--gloom-weight-bold)",
+      },
+    }, content.title);
+  }
   const showPicture = !!preview && failedUrl !== preview.url;
   const leadSize = compact ? 18 : ICON_SIZE;
   const lead = showPicture
@@ -144,7 +192,6 @@ export function DesktopChatPaneChip({
       fontSize: tone === "title" ? undefined : "0.92em",
     },
   }, text);
-  const label = [content.title, content.detail].filter(Boolean).join(", ");
   const text = compact
     ? createElement("span", {
       key: "text",
@@ -172,23 +219,6 @@ export function DesktopChatPaneChip({
     opacity: dimmed ? 0.6 : 1,
     overflow: "hidden",
   };
-  const pressable = {
-    "aria-label": label || undefined,
-    title: link.kind === "share" ? link.url : undefined,
-    onMouseEnter: () => setHovered(true),
-    onMouseLeave: () => setHovered(false),
-    // A press on the chip is not a press on the row behind it.
-    onMouseDown: (event: DomEventLike) => event.stopPropagation(),
-    onClick: (event: DomEventLike) => {
-      event.stopPropagation();
-      onOpen(link);
-    },
-  };
-  const buttonReset = { cursor: "pointer", font: "inherit", color: "inherit", textAlign: "left" };
-  const dataAttributes = {
-    "data-gloom-role": "chat-pane-chip",
-    "data-gloom-pane-link": link.kind === "share" ? `share:${link.id}` : link.link.kind,
-  };
   if (!onRemove) {
     return createElement("button", { type: "button", ...dataAttributes, ...pressable, style: { ...frame, ...buttonReset } }, lead, text);
   }