gloomberb 0.11.0 → 0.11.2

package/src/components/company-logo.tsx

@@ -0,0 +1,60 @@
+import { ImageSurface, Text, useUiCapabilities } from "../ui";
+import { cloudLogoPath, type CloudLogoKind } from "../api-client/paths";
+import { getCloudApiBaseUrl } from "../api-client/request";
+import { resolveAssetDisplayKind } from "../market-data/market/format";
+import { colors } from "../theme/colors";
+
+export function resolveCompanyLogoSrc(input: {
+  symbol: string;
+  assetCategory?: string;
+}): string | null {
+  const kind = logoKindForAsset(input.assetCategory);
+  if (!kind) return null;
+  const path = cloudLogoPath(kind, input.symbol);
+  return path ? `${getCloudApiBaseUrl()}${path}` : null;
+}
+
+export function CompanyLogo({
+  symbol,
+  assetCategory,
+  name,
+  width = 5,
+  height = 2,
+}: {
+  symbol: string;
+  assetCategory?: string;
+  name?: string;
+  width?: number;
+  height?: number;
+}) {
+  const { nativePaneChrome, cellWidthPx = 8, cellHeightPx = 18 } = useUiCapabilities();
+  const src = nativePaneChrome === true ? resolveCompanyLogoSrc({ symbol, assetCategory }) : null;
+  if (!src) return null;
+
+  return (
+    <ImageSurface
+      src={src}
+      alt={name || symbol}
+      width={width}
+      height={height}
+      marginRight={1}
+      flexShrink={0}
+      alignItems="center"
+      justifyContent="center"
+      objectFit="contain"
+      style={{
+        width: cellWidthPx * width,
+        height: cellHeightPx * height,
+        flexShrink: 0,
+      }}
+    >
+      <Text fg={colors.textDim}>{symbol.trim().charAt(0).toUpperCase() || "?"}</Text>
+    </ImageSurface>
+  );
+}
+
+function logoKindForAsset(assetCategory?: string): CloudLogoKind | null {
+  const kind = resolveAssetDisplayKind({ assetCategory });
+  if (kind === "cash" || kind === "contract") return null;
+  return kind === "crypto" ? "crypto" : "ticker";
+}

package/src/components/feed-data-table/stack-view.tsx

@@ -1,6 +1,6 @@
 import { Box, ScrollBox, Text } from "../../ui";
 import { TextAttributes, type ScrollBoxRenderable } from "../../ui";
-import { useCallback, useEffect, useMemo, useRef, useState, type ReactNode } from "react";
+import { useCallback, useEffect, useMemo, useRef, useState, type ReactNode, type RefObject } from "react";
 import { t } from "../../i18n";
 import { useAppLanguage } from "../../i18n/react";
 import { displayWidth, formatTimeAgo } from "../../utils/format";
@@ -64,6 +64,8 @@ interface FeedDataTableStackViewProps {
   isItemRead?: (item: FeedDataTableItem) => boolean;
   onOpenItem?: (item: FeedDataTableItem, index: number) => void;
   onOpenItemIdChange?: (itemId: string | null) => void;
+  scrollRef?: RefObject<ScrollBoxRenderable | null>;
+  onBodyScrollActivity?: () => void;
 }
 
 function timestampValue(item: FeedDataTableItem): number {
@@ -148,6 +150,8 @@ export function FeedDataTableStackView({
   isItemRead,
   onOpenItem,
   onOpenItemIdChange,
+  scrollRef,
+  onBodyScrollActivity,
 }: FeedDataTableStackViewProps) {
   const language = useAppLanguage();
   const [sortPreference, setSortPreference] = useState<SortPreference>({
@@ -362,6 +366,8 @@ export function FeedDataTableStackView({
       emptyStateTitle={t(emptyStateTitle)}
       emptyStateHint={emptyStateHint}
       showHorizontalScrollbar={false}
+      scrollRef={scrollRef}
+      onBodyScrollActivity={onBodyScrollActivity}
     />
   );
 }

package/src/components/index.ts

@@ -14,6 +14,7 @@ export { TickerListTableView } from "./ticker/list-table-view";
 export type { TickerListVisibleRange } from "./ticker/list-table-view";
 export { TickerBadgeList } from "./ticker/badge/list";
 export { InputSearchBar } from "./input-search-bar";
+export { isTableScrollNearEnd, useTableLoadMore } from "./table-view-shared";
 export { DataTableView } from "./data-table/view";
 export type { DataTableKeyEvent, DataTableRootKeyContext } from "./data-table/view";
 export { DataTableStackView } from "./data-table/stack-view";

package/src/components/layout/detached-pane-shell.tsx

@@ -1,8 +1,8 @@
-import { Box, Span, Text, useRendererHost, useUiCapabilities } from "../../ui";
+import { Box, Span, Text, useContextMenu, useRendererHost, useUiCapabilities } from "../../ui";
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { t } from "../../i18n";
 import { useShortcut, useViewport } from "../../react/input";
-import { useAppDispatch, useAppSelector } from "../../state/app/context";
+import { resolveTickerForPane, useAppDispatch, useAppSelector } from "../../state/app/context";
 import type { DesktopWindowBridge } from "../../types/desktop-window";
 import { findPaneInstance } from "../../types/config";
 import type { PluginRegistry } from "../../plugins/registry";
@@ -20,6 +20,13 @@ import {
   recordDoubleEscapeClose,
   resetDoubleEscapeClose,
 } from "../../utils/double-escape-close";
+import { createShare, openLiveShareUrl } from "../../shares/api";
+import { buildPaneSharePayload } from "../../shares/pane";
+import type { ContextMenuItem } from "../../types/context-menu";
+import {
+  PANE_MANAGEMENT_ACCELERATORS,
+  resolvePaneManagementShortcut,
+} from "./shell/shortcuts";
 
 interface DetachedPaneShellProps {
   pluginRegistry: PluginRegistry;
@@ -35,6 +42,7 @@ export function DetachedPaneShell({ pluginRegistry, desktopWindowBridge }: Detac
   const colors = useThemeColors();
   const dispatch = useAppDispatch();
   const rendererHost = useRendererHost();
+  const { showContextMenu } = useContextMenu();
   const config = useAppSelector((state) => state.config);
   const paneState = useAppSelector((state) => state.paneState);
   const inputCaptured = useAppSelector((state) => state.inputCaptured);
@@ -43,19 +51,34 @@ export function DetachedPaneShell({ pluginRegistry, desktopWindowBridge }: Detac
     typeof document === "undefined" ? true : document.hasFocus()
   ));
   const { width, height } = useViewport();
-  const { cellHeightPx = 18, nativePaneChrome, titleBarOverlay, windowControls } = useUiCapabilities();
-  const showWindowControls = windowControls === "windows";
-  const titlebarLeadingInset = titleBarOverlay ? getTitlebarLeadingInset() : 0;
+  const {
+    cellHeightPx = 18,
+    nativePaneChrome,
+    publicSharing,
+    titleBarOverlay,
+    nativeWindowChrome = titleBarOverlay,
+    windowControls,
+  } = useUiCapabilities();
+  const showWindowControls = nativeWindowChrome && windowControls === "windows";
+  const titlebarLeadingInset = titleBarOverlay && nativeWindowChrome ? getTitlebarLeadingInset() : 0;
   const instance = useAppSelector((state) => findPaneInstance(state.config.layout, desktopWindowBridge.paneId) ?? null);
   const paneDef = instance ? pluginRegistry.panes.get(instance.paneId) ?? null : null;
   const hasPaneSettings = !!instance && pluginRegistry.hasPaneSettings(instance.instanceId);
-  const quickSettings = instance ? pluginRegistry.resolvePaneQuickSettings(instance.instanceId) : [];
   const titleState = useMemo(
-    () => ({ config, paneState }) as Parameters<typeof getPaneDisplayTitle>[0],
+    () => ({ config, paneState }) as Parameters<typeof resolveTickerForPane>[0],
     [config, paneState],
   );
+  const sharePayload = useMemo(() => instance && publicSharing
+    ? buildPaneSharePayload(
+        pluginRegistry,
+        instance,
+        paneState[instance.instanceId] ?? {},
+        resolveTickerForPane(titleState, instance.instanceId),
+      )
+    : null, [instance, paneState, pluginRegistry, publicSharing, titleState]);
+  const quickSettings = instance ? pluginRegistry.resolvePaneQuickSettings(instance.instanceId) : [];
   const title = instance && paneDef
-    ? getPaneDisplayTitle(titleState, instance, paneDef)
+    ? getPaneDisplayTitle(titleState, instance, paneDef, pluginRegistry.panes)
     : "Detached Pane";
   const focused = windowFocused;
 
@@ -112,13 +135,59 @@ export function DetachedPaneShell({ pluginRegistry, desktopWindowBridge }: Detac
 
   const startWindowDrag = useCallback(() => {
     focusPane();
-    void rendererHost.startWindowDrag?.();
-  }, [focusPane, rendererHost]);
+    if (nativeWindowChrome) void rendererHost.startWindowDrag?.();
+  }, [focusPane, nativeWindowChrome, rendererHost]);
+
+  const sharePane = useCallback(async () => {
+    if (!sharePayload) return;
+    try {
+      const { id } = await createShare(sharePayload);
+      await rendererHost.copyText(openLiveShareUrl(id));
+      pluginRegistry.notify({ body: "Share link copied to clipboard", type: "success" });
+    } catch (error) {
+      pluginRegistry.notify({
+        body: error instanceof Error ? error.message : "Could not share this pane.",
+        type: "error",
+      });
+    }
+  }, [pluginRegistry, rendererHost, sharePayload]);
 
-  const openSettings = useCallback((event?: { stopPropagation?: () => void; preventDefault?: () => void }) => {
+  useShortcut((event) => {
+    if (resolvePaneManagementShortcut(event) !== "share" || !sharePayload) return;
+    if (inputCaptured && event.ctrl && !event.meta && !event.super) return;
+    event.preventDefault();
+    event.stopPropagation();
+    void sharePane();
+  });
+
+  const openActions = useCallback((event?: { stopPropagation?: () => void; preventDefault?: () => void }) => {
     stopMouse(event);
-    pluginRegistry.openPaneSettingsFn(desktopWindowBridge.paneId);
-  }, [desktopWindowBridge.paneId, pluginRegistry]);
+    focusPane();
+    const items: ContextMenuItem[] = [];
+    if (hasPaneSettings) {
+      items.push({
+        id: "settings",
+        label: "Settings",
+        onSelect: () => pluginRegistry.openPaneSettingsFn(desktopWindowBridge.paneId),
+      });
+    }
+    if (sharePayload) items.push({
+      id: "share-pane",
+      label: "Share Pane",
+      accelerator: PANE_MANAGEMENT_ACCELERATORS.share,
+      onSelect: sharePane,
+    });
+    void showContextMenu({
+      kind: "pane",
+      paneId: desktopWindowBridge.paneId,
+      paneType: instance?.paneId ?? "",
+      title,
+      floating: true,
+    }, items, event).then((shown) => {
+      if (!shown && hasPaneSettings) pluginRegistry.openPaneSettingsFn(desktopWindowBridge.paneId);
+      else if (!shown && sharePayload) void sharePane();
+    });
+  }, [desktopWindowBridge.paneId, focusPane, hasPaneSettings, instance?.paneId, pluginRegistry, sharePane, sharePayload, showContextMenu, title]);
   const toggleQuickSetting = useCallback((key: string, event?: { stopPropagation?: () => void; preventDefault?: () => void }) => {
     stopMouse(event);
     focusPane();
@@ -224,14 +293,15 @@ export function DetachedPaneShell({ pluginRegistry, desktopWindowBridge }: Detac
                   </Box>
                 ))}
                 <Box flexGrow={1} minWidth={0} />
-                {hasPaneSettings && (
+                {(hasPaneSettings || sharePayload) && (
                   <Text
                     fg={paneTitleText(focused, true, colors)}
                     selectable={false}
                     className="electrobun-webkit-app-region-no-drag"
                     data-gloom-role="pane-action"
                     data-gloom-interactive="true"
-                    onMouseDown={openSettings}
+                    aria-label="Pane actions"
+                    onMouseDown={openActions}
                   >
                     {" ... "}
                   </Text>

package/src/components/layout/header.tsx

@@ -164,9 +164,9 @@ export function Header({
   const rendererHost = useRendererHost();
   const baseCurrency = useAppSelector(selectBaseCurrency);
   const appActive = useAppActive();
-  const { titleBarOverlay, windowControls } = useUiCapabilities();
-  const showWindowControls = windowControls === "windows";
-  const titlebarLeadingInset = titleBarOverlay ? getTitlebarLeadingInset() : 0;
+  const { titleBarOverlay, nativeWindowChrome = titleBarOverlay, windowControls } = useUiCapabilities();
+  const showWindowControls = nativeWindowChrome && windowControls === "windows";
+  const titlebarLeadingInset = titleBarOverlay && nativeWindowChrome ? getTitlebarLeadingInset() : 0;
   const spyQuoteEntry = useQuoteEntry("SPY", null);
   const spyQuote = useResolvedEntryValue(spyQuoteEntry);
   const mktState = spyQuote?.marketState;
@@ -198,9 +198,9 @@ export function Header({
     : "SPY —";
 
   const startWindowDrag = useCallback(() => {
-    if (!titleBarOverlay) return;
+    if (!titleBarOverlay || !nativeWindowChrome) return;
     void rendererHost.startWindowDrag?.();
-  }, [rendererHost, titleBarOverlay]);
+  }, [nativeWindowChrome, rendererHost, titleBarOverlay]);
 
   // Market status
   const mktCountdown = mktState ? marketStateCountdown(mktState, now) : null;

package/src/components/layout/pane/title.ts

@@ -1,9 +1,16 @@
 import { resolveCollectionForPane, resolveTickerForPane, type AppState } from "../../../state/app/context";
-import { t } from "../../../i18n";
-import { TICKER_RESEARCH_PANE_ID, type PaneInstanceConfig } from "../../../types/config";
+import { t, tf } from "../../../i18n";
+import {
+  findPaneInstance,
+  TICKER_RESEARCH_PANE_ID,
+  type PaneInstanceConfig,
+} from "../../../types/config";
 import type { PaneDef } from "../../../types/plugin";
 
-export function getPaneDisplayTitle(
+/** Single-cell link glyph: emoji link icons render double-width in terminals. */
+const LINK_GLYPH = "\u29c9";
+
+function getBasePaneDisplayTitle(
   state: Pick<AppState, "config" | "paneState">,
   instance: PaneInstanceConfig,
   paneDef: PaneDef,
@@ -38,6 +45,27 @@ export function getPaneDisplayTitle(
       ?? t(paneDef.name);
   }
 
+  // A source pane owns the cursor symbol; echoing it in its own title would just repeat the row.
+  if (paneDef.tickerSource) return t(paneDef.name);
+
   const ticker = resolveTickerForPane(state as AppState, instance.instanceId);
   return ticker ? `${t(paneDef.name)}: ${ticker}` : t(paneDef.name);
 }
+
+export function getPaneDisplayTitle(
+  state: Pick<AppState, "config" | "paneState">,
+  instance: PaneInstanceConfig,
+  paneDef: PaneDef,
+  panes?: ReadonlyMap<string, PaneDef>,
+): string {
+  const title = getBasePaneDisplayTitle(state, instance, paneDef);
+  if (instance.paneId !== TICKER_RESEARCH_PANE_ID || instance.binding?.kind !== "follow" || !panes) {
+    return title;
+  }
+
+  const source = findPaneInstance(state.config.layout, instance.binding.sourceInstanceId);
+  const sourceDef = source ? panes.get(source.paneId) : null;
+  if (!source || !sourceDef) return title;
+  const sourceTitle = getBasePaneDisplayTitle(state, source, sourceDef);
+  return `${title}  ${LINK_GLYPH} ${tf("Linked to {source}", { source: sourceTitle })}`;
+}

package/src/components/layout/shell/active-drag.ts

@@ -1,4 +1,4 @@
-import { useCallback, type Dispatch } from "react";
+import { useCallback } from "react";
 import {
   floatAtRect,
   getRememberedFloatingRect,
@@ -10,7 +10,6 @@ import {
   type LayoutBounds,
   type ResolvedPane,
 } from "../../../plugins/pane-manager";
-import type { AppAction } from "../../../state/app/context";
 import type { LayoutConfig } from "../../../types/config";
 import {
   finalizePaneDragRelease,
@@ -32,7 +31,6 @@ interface UseShellActiveDragOptions {
   appHeaderHeight: number;
   bounds: LayoutBounds;
   contentHeight: number;
-  dispatch: Dispatch<AppAction>;
   dockGeometryOptions: DockGeometryOptions;
   dockLeafLayouts: DockLeafLayout[];
   dragRuntime: ShellDragRuntimeState;
@@ -52,7 +50,6 @@ export function useShellActiveDrag({
   appHeaderHeight,
   bounds,
   contentHeight,
-  dispatch,
   dockGeometryOptions,
   dockLeafLayouts,
   dragRuntime,
@@ -168,16 +165,13 @@ export function useShellActiveDrag({
             ? getRememberedFloatingRect(baseLayout, drag.paneId, width, contentHeight, pane?.def)
             : drag.origRect;
           const releaseRect = resolvePaneDragFloatingRect(drag, baseRect, preciseX, preciseShellY, width, contentHeight);
-          const releaseResult = finalizePaneDragRelease(baseLayout, drag.paneId, releaseRect, dockPreviewRef.current);
+          const nextLayout = finalizePaneDragRelease(baseLayout, drag.paneId, releaseRect, dockPreviewRef.current);
           if (windowMode) {
-            updateWindowModePreviewLayout(releaseResult.nextLayout, drag.paneId);
+            updateWindowModePreviewLayout(nextLayout, drag.paneId);
           } else {
-            persistLayout(releaseResult.nextLayout);
+            persistLayout(nextLayout);
           }
           focusPane(drag.paneId);
-          if (!windowMode && releaseResult.shouldShowGridlockTip) {
-            dispatch({ type: "SHOW_GRIDLOCK_TIP" });
-          }
           updateDockPreview(null);
           setDragCursor(null);
           updateDragFloatingRect(null);
@@ -201,7 +195,6 @@ export function useShellActiveDrag({
     appHeaderHeight,
     bounds,
     contentHeight,
-    dispatch,
     dockGeometryOptions,
     dividerPreviewRef,
     dockLeafLayouts,

package/src/components/layout/shell/drag/index.ts

@@ -46,11 +46,6 @@ export type DragPreview =
     rect: FloatingRect;
   };
 
-export interface PaneDragReleaseResult {
-  nextLayout: LayoutConfig;
-  shouldShowGridlockTip: boolean;
-}
-
 export interface PaneDragRectState {
   mode: "docked" | "floating";
   startX: number;
@@ -272,25 +267,14 @@ export function finalizePaneDragRelease(
   paneId: string,
   previewRect: FloatingRect,
   dockPreview: DragPreview | null,
-): PaneDragReleaseResult {
+): LayoutConfig {
   if (dockPreview?.kind === "dock") {
-    return {
-      nextLayout: applyDrop(layout, paneId, dockPreview.target),
-      shouldShowGridlockTip: false,
-    };
+    return applyDrop(layout, paneId, dockPreview.target);
   }
-
   if (dockPreview?.kind === "snap") {
-    return {
-      nextLayout: floatAtRect(layout, paneId, dockPreview.rect),
-      shouldShowGridlockTip: true,
-    };
+    return floatAtRect(layout, paneId, dockPreview.rect);
   }
-
-  return {
-    nextLayout: floatAtRect(layout, paneId, previewRect),
-    shouldShowGridlockTip: false,
-  };
+  return floatAtRect(layout, paneId, previewRect);
 }
 
 export function makeSnapGuides(width: number, height: number): SnapGuide[] {

package/src/components/layout/shell/drag/runtime.ts

@@ -15,7 +15,6 @@ import {
   type LayoutBounds,
   type ResolvedPane,
 } from "../../../../plugins/pane-manager";
-import type { AppAction } from "../../../../state/app/context";
 import type { LayoutConfig } from "../../../../types/config";
 import {
   constrainFloatingRectToBounds,
@@ -165,7 +164,6 @@ interface UseShellPointerRuntimeOptions {
   bounds: LayoutBounds;
   closePaneMenu: () => void;
   contentHeight: number;
-  dispatch: Dispatch<AppAction>;
   dockGeometryOptions: DockGeometryOptions;
   dockDividerLayouts: DockDividerLayout[];
   dockLeafLayouts: DockLeafLayout[];
@@ -193,6 +191,7 @@ interface UseShellPointerRuntimeOptions {
   visibleLayout: LayoutConfig;
   width: number;
   windowMode: WindowEditState | null;
+  commandBarOpen: boolean;
 }
 
 export function useShellPointerRuntime({
@@ -200,7 +199,6 @@ export function useShellPointerRuntime({
   bounds,
   closePaneMenu,
   contentHeight,
-  dispatch,
   dockGeometryOptions,
   dockDividerLayouts,
   dockLeafLayouts,
@@ -224,12 +222,12 @@ export function useShellPointerRuntime({
   visibleLayout,
   width,
   windowMode,
+  commandBarOpen,
 }: UseShellPointerRuntimeOptions) {
   const handleActiveDrag = useShellActiveDrag({
     appHeaderHeight,
     bounds,
     contentHeight,
-    dispatch,
     dockGeometryOptions,
     dockLeafLayouts,
     focusPane,
@@ -282,6 +280,7 @@ export function useShellPointerRuntime({
     setMenuState,
     transientFocusActive,
     windowMode,
+    commandBarOpen,
   });
 
   return {

package/src/components/layout/shell/index.test.tsx

@@ -62,6 +62,7 @@ function createShellPluginRegistry(options?: {
     hasPaneSettings: (paneId: string) => paneId === "portfolio-list:main",
     openPaneSettingsFn: () => {},
     openCommandBar: () => {},
+    showPane: () => {},
     openWindowMode: () => {},
     openWindowModeFn: () => {},
     updateLayoutFn: () => {},
@@ -356,7 +357,8 @@ describe("Shell", () => {
     expect(resolvePaneManagementShortcut({ ...base, name: "D", key: "D" })).toBe("toggle-floating");
     expect(resolvePaneManagementShortcut({ ...base, name: "o", key: "o" })).toBe("pop-out");
     expect(resolvePaneManagementShortcut({ ...base, name: "c", key: "c" })).toBe("copy-screenshot");
-    expect(resolvePaneManagementShortcut({ ...base, name: "l", key: "l" })).toBe("layout-actions");
+    expect(resolvePaneManagementShortcut({ ...base, name: "s", key: "s" })).toBe("share");
+    expect(resolvePaneManagementShortcut({ ...base, name: "l", key: "l" })).toBe("layout-gallery");
     expect(resolvePaneManagementShortcut({ ...base, name: "f", key: "f" })).toBe("toggle-fullscreen");
     expect(resolvePaneManagementShortcut({ ...base, name: "g", key: "g" })).toBe("gridlock-all");
     expect(resolvePaneManagementShortcut({ ...base, name: "m", key: "m" })).toBe("window-mode");
@@ -366,6 +368,18 @@ describe("Shell", () => {
     expect(resolvePaneManagementShortcut({ ...base, name: "d", key: "d", meta: false, super: false })).toBeNull();
   });
 
+  test("opens the layout browser from the primary Shift-L shortcut", async () => {
+    const config = createDefaultConfig("/tmp/gloomberb-shell-layout-browser-shortcut-test");
+    const opened: string[] = [];
+    const registry = createShellPluginRegistry();
+    registry.showPane = (paneId) => opened.push(paneId);
+    await renderShellForWindowModeTest(createInitialState(config), { registry });
+
+    await emitKeypress({ name: "l", ctrl: true, shift: true });
+
+    expect(opened).toEqual(["layout-marketplace"]);
+  });
+
   test("toggles the focused pane fullscreen without persisting layout", async () => {
     const config = createDefaultConfig("/tmp/gloomberb-shell-fullscreen-shortcut-test");
     const mainPane = requireLayoutInstance(config, "portfolio-list:main");
@@ -478,8 +492,8 @@ describe("Shell", () => {
 
     const frame = testSetup!.captureCharFrame();
     const rows = frame.split("\n");
-    expect(rows[2]?.indexOf("┌─:: Main Portfolio") ?? -1).toBeLessThan(0);
-    expect(rows[5]?.indexOf("┌─:: Main Portfolio")).toBeGreaterThanOrEqual(14);
+    expect(rows[2]?.indexOf(":: Main Portfolio") ?? -1).toBeLessThan(0);
+    expect(rows[5]?.indexOf(":: Main Portfolio")).toBeGreaterThanOrEqual(14);
 
     await act(async () => {
       await testSetup!.mockMouse.release(16, 6);