gloomberb 0.11.0 → 0.11.2

package/src/plugins/builtin/news/index.tsx

@@ -5,7 +5,7 @@ import { useArticleSummary, useResolvedEntryValue } from "../../../market-data/h
 import { instrumentFromTicker } from "../../../market-data/request-types";
 import { useDebouncedPluginPaneState, usePluginPaneState } from "../../runtime";
 import { EmptyState } from "../../../components";
-import { useLoadNewsStory, useNewsArticles } from "../../../news/hooks";
+import { useLoadNewsStory, useNewsArticles, useNewsTableLoadMore } from "../../../news/hooks";
 import { newsWireModule } from "./wire";
 import { NewsDetailView, useNewsArticleDetail } from "./wire/news/detail-view";
 import {
@@ -33,18 +33,20 @@ function TickerNewsView({ width, height, focused }: { width: number; height: num
     DEFAULT_SORT,
   );
   const instrument = instrumentFromTicker(ticker, ticker?.metadata.ticker ?? null);
-  const newsState = useNewsArticles(instrument ? {
-    feed: "ticker",
+  const newsQuery = instrument ? {
+    feed: "ticker" as const,
     ticker: instrument.symbol,
     exchange: instrument.exchange,
-    tickerTier: "primary",
+    tickerTier: "primary" as const,
     limit: NEWS_ITEM_LIMIT,
-  } : null);
+  } : null;
+  const newsState = useNewsArticles(newsQuery);
   const news = usePersistedNewsArticles(
     `articles:${instrument?.symbol ?? "none"}:${instrument?.exchange ?? ""}`,
     newsState.articles,
   );
   const { readArticleIds, markArticleRead } = useNewsReadState();
+  const { scrollRef, onBodyScrollActivity } = useNewsTableLoadMore(newsQuery, newsState);
   const loadNewsStory = useLoadNewsStory();
   const { detailArticle, openArticle, closeDetail } = useNewsArticleDetail(news, loadNewsStory);
   const loading = newsState.phase === "loading"
@@ -118,11 +120,13 @@ function TickerNewsView({ width, height, focused }: { width: number; height: num
       })}
       emptyStateTitle={`No news for ${ticker.metadata.ticker}`}
       emptyStateHint="Stories appear as sources publish them."
+      scrollRef={scrollRef}
+      onBodyScrollActivity={onBodyScrollActivity}
     />
   );
 }
 
-const tickerNewsModule: PluginModule = {
+export const tickerNewsModule: PluginModule = {
   panes: [
     {
       id: "ticker-news",
@@ -143,6 +147,7 @@ const tickerNewsModule: PluginModule = {
       description: "Company news for the selected ticker.",
       keywords: ["company", "ticker", "news", "headlines", "cn"],
       shortcut: "CN",
+      publicShare: true,
     }),
   ],
 

package/src/plugins/builtin/news/wire/breaking/notifications.test.ts

@@ -38,6 +38,8 @@ function ready(articles: MarketNewsItem[]): NewsQueryState {
     error: null,
     updatedAt: Date.now(),
     sourceIds: ["test"],
+    nextCursor: null,
+    loadingMore: false,
   };
 }
 

package/src/plugins/builtin/news/wire/breaking/pane.test.tsx

@@ -52,6 +52,8 @@ function createReadyNewsService(articles: NewsArticle[]): { service: NewsService
     error: null,
     updatedAt: Date.now(),
     sourceIds: ["test"],
+    nextCursor: null,
+    loadingMore: false,
   };
   const listeners = new Set<(state: NewsQueryState) => void>();
   let queryStateCalls = 0;

package/src/plugins/builtin/news/wire/breaking/pane.tsx

@@ -1,6 +1,6 @@
 import { Box } from "../../../../../ui";
 import type { PaneProps } from "../../../../../types/plugin";
-import { useLoadNewsStory, useNewsArticles } from "../../../../../news/hooks";
+import { useLoadNewsStory, useNewsArticles, useNewsTableLoadMore } from "../../../../../news/hooks";
 import { useDebouncedPluginPaneState, usePluginPaneState } from "../../../../runtime";
 import { NewsDetailView, useNewsArticleDetail } from "../news/detail-view";
 import {
@@ -18,6 +18,7 @@ const DEFAULT_SORT: NewsSortPreference = { columnId: "importance", direction: "d
 export function BreakingPane({ focused, width, height }: PaneProps) {
   const breakingState = useNewsArticles(NEWS_QUERY_PRESETS.breaking);
   const articles = usePersistedNewsArticles("breaking:articles", breakingState.articles);
+  const { scrollRef, onBodyScrollActivity } = useNewsTableLoadMore(NEWS_QUERY_PRESETS.breaking, breakingState);
   const loading = breakingState.phase === "loading"
     || (breakingState.phase === "refreshing" && articles.length === 0);
   const error = breakingState.error;
@@ -73,6 +74,8 @@ export function BreakingPane({ focused, width, height }: PaneProps) {
       })}
       emptyStateTitle="No breaking news"
       emptyStateHint="Breaking stories appear when high-priority headlines arrive."
+      scrollRef={scrollRef}
+      onBodyScrollActivity={onBodyScrollActivity}
     />
   );
 }

package/src/plugins/builtin/news/wire/feed-config.test.ts

@@ -6,6 +6,7 @@ import {
   getEnabledNewsFeeds,
   loadNewsFeedSettings,
   removeUserNewsFeed,
+  saveNewsFeedSettings,
   setDefaultNewsFeedEnabled,
   updateUserNewsFeed,
 } from "./feed-config";
@@ -31,7 +32,7 @@ class MemoryConfigState implements PluginConfigState {
 }
 
 describe("news feed config", () => {
-  test("normalizes legacy JSON feed storage and migrates disabled default feed names to ids", () => {
+  test("normalizes legacy JSON feed storage and migrates disabled default feed names to ids", async () => {
     const config = new MemoryConfigState();
     config.values.set("feeds", JSON.stringify([
       { url: "https://example.com/rss.xml", name: "Example", authority: 120 },
@@ -41,10 +42,23 @@ describe("news feed config", () => {
 
     const settings = loadNewsFeedSettings(config);
 
+    expect(settings.needsMigration).toBe(true);
     expect(settings.userFeeds).toHaveLength(1);
     expect(settings.userFeeds[0]!.id).toMatch(/^user-/);
     expect(settings.userFeeds[0]!.authority).toBe(100);
     expect(settings.disabledDefaultFeedIds).toEqual(["default-cnbc-top"]);
+
+    await saveNewsFeedSettings(config, settings);
+    expect(loadNewsFeedSettings(config).needsMigration).toBe(false);
+  });
+
+  test("does not rewrite canonical feed settings", async () => {
+    const config = new MemoryConfigState();
+    await addUserNewsFeed(config, {
+      url: "https://example.com/feed",
+      name: "Example",
+    });
+    expect(loadNewsFeedSettings(config).needsMigration).toBe(false);
   });
 
   test("adds, updates, and removes user feeds through typed helpers", async () => {

package/src/plugins/builtin/news/wire/feed-config.ts

@@ -12,7 +12,7 @@ const DEFAULT_FEED_IDS = new Set(DEFAULT_FEEDS.map((feed) => feed.id));
 export interface NewsFeedSettings {
   userFeeds: RssFeedConfig[];
   disabledDefaultFeedIds: string[];
-  migrated: boolean;
+  needsMigration: boolean;
 }
 
 export interface UserNewsFeedInput {
@@ -109,6 +109,26 @@ function normalizeDisabledDefaultFeedIds(values: unknown[]): string[] {
   return [...ids];
 }
 
+function sameUserFeeds(raw: unknown, normalized: RssFeedConfig[]): boolean {
+  if (!Array.isArray(raw) || raw.length !== normalized.length) return false;
+  return raw.every((entry, index) => {
+    const feed = normalized[index];
+    if (!feed || !entry || typeof entry !== "object") return false;
+    const record = entry as Record<string, unknown>;
+    return record.id === feed.id
+      && record.url === feed.url
+      && record.name === feed.name
+      && record.category === feed.category
+      && record.authority === feed.authority
+      && record.enabled === feed.enabled;
+  });
+}
+
+function sameIdList(raw: unknown, normalized: string[]): boolean {
+  if (!Array.isArray(raw) || raw.length !== normalized.length) return false;
+  return raw.every((value, index) => value === normalized[index]);
+}
+
 export function loadNewsFeedSettings(configState: PluginConfigState): NewsFeedSettings {
   const rawUserFeeds = configState.get<unknown>(USER_FEEDS_KEY);
   const userFeedValues = parseJsonArray(rawUserFeeds);
@@ -123,11 +143,11 @@ export function loadNewsFeedSettings(configState: PluginConfigState): NewsFeedSe
     ...parseJsonArray(rawLegacyDisabled),
   ]);
 
-  const migrated = rawUserFeeds !== null
-    || rawDisabledIds !== null
-    || rawLegacyDisabled !== null;
+  const needsMigration = rawLegacyDisabled !== null
+    || (rawUserFeeds !== null && !sameUserFeeds(rawUserFeeds, userFeeds))
+    || (rawDisabledIds !== null && !sameIdList(rawDisabledIds, disabledDefaultFeedIds));
 
-  return { userFeeds, disabledDefaultFeedIds, migrated };
+  return { userFeeds, disabledDefaultFeedIds, needsMigration };
 }
 
 export async function saveNewsFeedSettings(

package/src/plugins/builtin/news/wire/index.tsx

@@ -41,13 +41,13 @@ function createNewsPresetPane(config: NewsPresetPaneConfig) {
 }
 
 const TopPane = createNewsPresetPane({
-  paneKey: "top",
+  paneKey: "top:curated",
   title: "Top News",
   query: NEWS_QUERY_PRESETS.top,
   columns: ["time", "source", "title", "tickers", "categories", "importance"],
   defaultSort: { columnId: "importance", direction: "desc" },
   emptyStateTitle: "No top stories yet",
-  emptyStateHint: "Run the Add News Feed command to wire up another source.",
+  emptyStateHint: "Top stories appear when curated market sources publish them.",
 });
 
 const FeedPane = createNewsPresetPane({
@@ -95,7 +95,7 @@ export const newsWireModule: PluginModule = {
   ],
   setup(ctx) {
     const initialSettings = loadNewsFeedSettings(ctx.configState);
-    if (initialSettings.migrated) {
+    if (initialSettings.needsMigration) {
       void saveNewsFeedSettings(ctx.configState, initialSettings);
     }
 

package/src/plugins/builtin/news/wire/industry-pane.tsx

@@ -2,7 +2,7 @@ import { Box } from "../../../../ui";
 import { useEffect, useMemo } from "react";
 import type { PaneProps } from "../../../../types/plugin";
 import type { MarketNewsItem } from "../../../../types/news-source";
-import { useLoadNewsStory, useNewsArticles } from "../../../../news/hooks";
+import { useLoadNewsStory, useNewsArticles, useNewsTableLoadMore } from "../../../../news/hooks";
 import { useDebouncedPluginPaneState, usePluginPaneState } from "../../../runtime";
 import { Tabs } from "../../../../components";
 import { NewsDetailView, useNewsArticleDetail } from "./news/detail-view";
@@ -34,6 +34,7 @@ function useIndustryArticles(sector: SectorNewsSelection): {
   allArticles: MarketNewsItem[];
   loading: boolean;
   error: string | null;
+  newsState: ReturnType<typeof useNewsArticles>;
 } {
   const allState = useNewsArticles(NEWS_QUERY_PRESETS.sectorAll);
   const allArticles = usePersistedNewsArticles("industry:sector:all:articles", allState.articles);
@@ -50,6 +51,7 @@ function useIndustryArticles(sector: SectorNewsSelection): {
     loading: allState.phase === "loading"
       || (allState.phase === "refreshing" && allArticles.length === 0),
     error: allState.error,
+    newsState: allState,
   };
 }
 
@@ -57,7 +59,8 @@ export function IndustryPane({ focused, width, height }: PaneProps) {
   const [category, setCategory] = usePluginPaneState<SectorNewsSelection>("industry:category", "all");
   const [selectedArticleId, setSelectedArticleId] = useDebouncedPluginPaneState<string | null>("industry:selectedArticleId", null);
   const [sortPreference, setSortPreference] = usePluginPaneState<NewsSortPreference>("industry:sort", DEFAULT_SORT);
-  const { articles, allArticles, loading, error } = useIndustryArticles(category);
+  const { articles, allArticles, loading, error, newsState } = useIndustryArticles(category);
+  const { scrollRef, onBodyScrollActivity } = useNewsTableLoadMore(NEWS_QUERY_PRESETS.sectorAll, newsState);
   const loadNewsStory = useLoadNewsStory();
   const { detailArticle, openArticle, closeDetail } = useNewsArticleDetail(articles, loadNewsStory);
   const { readArticleIds, markArticleRead } = useNewsReadState();
@@ -140,6 +143,8 @@ export function IndustryPane({ focused, width, height }: PaneProps) {
       })}
       emptyStateTitle="No news in this category"
       emptyStateHint="Try another category or wait for the next feed refresh."
+      scrollRef={scrollRef}
+      onBodyScrollActivity={onBodyScrollActivity}
     />
   );
 }

package/src/plugins/builtin/news/wire/news/footer.ts

@@ -1,14 +1,21 @@
-import { useMemo } from "react";
+import { useCallback, useMemo } from "react";
 import type { PaneFooterSegment } from "../../../../../components";
 import { t, tf } from "../../../../../i18n";
 import { useAppLanguage } from "../../../../../i18n/react";
+import { useShortcut } from "../../../../../react/input";
+import { useUiCapabilities } from "../../../../../ui";
+import { isPlainKey } from "../../../../../utils/keyboard";
 import { useCloudAccessFooter } from "../../../shared/cloud-upgrade";
 import { CLOUD_NEWS_DELAY_HOURS } from "../../../shared/plan-access";
 import { usePaneStatusLinkFooter } from "../../../shared/pane-footer";
+import { usePublicShare } from "../../../shared/public-share";
 
 interface NewsFooterArticle {
+  title?: string | null;
+  summary?: string | null;
   source?: string | null;
   url?: string | null;
+  items?: Array<{ title?: string | null; summary?: string | null }>;
 }
 
 interface UseNewsArticleFooterOptions {
@@ -29,6 +36,29 @@ export function useNewsArticleFooter({
   error,
 }: UseNewsArticleFooterOptions) {
   const language = useAppLanguage();
+  const { publicSharing } = useUiCapabilities();
+  const createPublicShare = usePublicShare();
+  const shareArticle = useCallback(() => {
+    if (!article?.title) return;
+    const text = [
+      article.summary,
+      ...(article.items ?? []).map((item) => item.summary || item.title),
+    ].filter((value): value is string => !!value?.trim()).join("\n\n").slice(0, 50_000);
+    void createPublicShare({
+      kind: "article",
+      data: {
+        title: article.title,
+        text,
+        ...(article.url ? { sourceUrl: article.url } : {}),
+      },
+    });
+  }, [article, createPublicShare]);
+  useShortcut((event) => {
+    if (!focused || !publicSharing || !article?.title || !isPlainKey(event, "y")) return;
+    event.preventDefault();
+    event.stopPropagation();
+    shareArticle();
+  });
   const { access, segment } = useCloudAccessFooter({
     delayLabel: tf("{count}h", { count: CLOUD_NEWS_DELAY_HOURS }),
     focused,
@@ -50,6 +80,9 @@ export function useNewsArticleFooter({
     url: article?.url,
     source: article?.source,
     info: footerInfo,
+    hints: publicSharing && article?.title
+      ? [{ id: "share", key: "y", label: " share", onPress: shareArticle }]
+      : undefined,
     showOpenHint: true,
     loading,
     error,

package/src/plugins/builtin/news/wire/news/preset-pane.tsx

@@ -1,6 +1,6 @@
 import { Box } from "../../../../../ui";
 import type { NewsQuery } from "../../../../../news/types";
-import { useLoadNewsStory, useNewsArticles } from "../../../../../news/hooks";
+import { useLoadNewsStory, useNewsArticles, useNewsTableLoadMore } from "../../../../../news/hooks";
 import type { PaneProps } from "../../../../../types/plugin";
 import { useDebouncedPluginPaneState, usePluginPaneState } from "../../../../runtime";
 import { NewsDetailView, useNewsArticleDetail } from "./detail-view";
@@ -36,6 +36,7 @@ export function NewsPresetPane({
 }) {
   const newsState = useNewsArticles(query);
   const articles = usePersistedNewsArticles(`${paneKey}:articles`, newsState.articles);
+  const { scrollRef, onBodyScrollActivity } = useNewsTableLoadMore(query, newsState);
   // The aggregator opens a query in "loading", so the first paint is a loading
   // body rather than a definitive empty wire.
   const loading = newsState.phase === "loading"
@@ -102,6 +103,8 @@ export function NewsPresetPane({
       })}
       emptyStateTitle={emptyStateTitle}
       emptyStateHint={emptyStateHint}
+      scrollRef={scrollRef}
+      onBodyScrollActivity={onBodyScrollActivity}
     />
   );
 }

package/src/plugins/builtin/news/wire/news/table.tsx

@@ -1,5 +1,5 @@
-import { useCallback, useEffect, useMemo, type ReactNode } from "react";
-import { TextAttributes } from "../../../../../ui";
+import { useCallback, useEffect, useMemo, type ReactNode, type RefObject } from "react";
+import { TextAttributes, type ScrollBoxRenderable } from "../../../../../ui";
 import {
   DataTableStackView,
   PaneStatusBody,
@@ -96,6 +96,8 @@ interface NewsArticleStackBaseProps {
   emptyStateTitle: string;
   emptyStateHint?: string;
   titleForArticle?: (article: MarketNewsItem) => string;
+  scrollRef?: RefObject<ScrollBoxRenderable | null>;
+  onBodyScrollActivity?: () => void;
 }
 
 function compareText(a: string, b: string): number {
@@ -223,6 +225,8 @@ export function NewsArticleStackView({
   onArticleRead,
   detailOpen,
   onBack,
+  scrollRef,
+  onBodyScrollActivity,
   detailContent,
   detailTitle,
   rootBefore,
@@ -349,6 +353,8 @@ export function NewsArticleStackView({
       emptyStateTitle={emptyStateTitle}
       emptyStateHint={emptyStateHint}
       showHorizontalScrollbar={false}
+      scrollRef={scrollRef}
+      onBodyScrollActivity={onBodyScrollActivity}
     />
   );
 }

package/src/plugins/builtin/news/wire/rss/source.test.ts

@@ -20,6 +20,18 @@ const RSS_FIXTURE = `<rss version="2.0"><channel><item>
 </item></channel></rss>`;
 
 describe("createRssNewsCapability", () => {
+  test("does not serve unclassified RSS stories as top news", async () => {
+    const fetchText = mock(async () => ({
+      ok: true,
+      text: async () => RSS_FIXTURE,
+    }));
+    const source = createRssNewsCapability([FEED], { fetchText });
+
+    expect(source.provider.supports?.({ feed: "top" })).toBe(false);
+    expect(await source.provider.fetchNews({ feed: "top" })).toEqual([]);
+    expect(fetchText).not.toHaveBeenCalled();
+  });
+
   test("caches fetched feed items with feed authority scoring", async () => {
     const persistence = new MemoryPersistence();
     const fetchText = mock(async () => ({

package/src/plugins/builtin/news/wire/rss/source.ts

@@ -37,7 +37,7 @@ export interface RssNewsCapabilityOptions {
 
 function supportsQuery(query: NewsQuery): boolean {
   const feed = query.feed ?? (query.scope === "ticker" ? "ticker" : "latest");
-  return feed === "latest" || feed === "top";
+  return feed === "latest";
 }
 
 function serializeItem(item: MarketNewsItem): CachedNewsItem {

package/src/plugins/builtin/notes/files.ts

@@ -4,7 +4,15 @@ export interface QuickNoteEntry {
   updatedAt?: number;
 }
 
+/** A stored note: `key` is what `load`/`save` take, not the file path. */
+export interface NoteFileEntry {
+  key: string;
+  text: string;
+  updatedAt: number;
+}
+
 const QUICK_NOTES_INDEX = "__quick-notes-index__";
+const LOCAL_TIMESTAMP_KEY = "gloomberb:notes:__updated-at__";
 
 function joinPath(...parts: string[]): string {
   return parts.join("/").replace(/\/+/g, "/");
@@ -29,6 +37,28 @@ async function readTextFile(path: string): Promise<string> {
   return getLocalStorage()?.getItem(`gloomberb:notes:${path}`) ?? "";
 }
 
+/** Browsers have no mtime, so note writes keep their own timestamp index. */
+function readLocalTimestamps(): Record<string, number> {
+  try {
+    const raw = getLocalStorage()?.getItem(LOCAL_TIMESTAMP_KEY);
+    const parsed: unknown = raw ? JSON.parse(raw) : null;
+    return parsed && typeof parsed === "object" && !Array.isArray(parsed)
+      ? parsed as Record<string, number>
+      : {};
+  } catch {
+    return {};
+  }
+}
+
+function writeLocalTimestamp(path: string, updatedAt: number | null): void {
+  const storage = getLocalStorage();
+  if (!storage) return;
+  const timestamps = readLocalTimestamps();
+  if (updatedAt == null) delete timestamps[path];
+  else timestamps[path] = updatedAt;
+  try { storage.setItem(LOCAL_TIMESTAMP_KEY, JSON.stringify(timestamps)); } catch {}
+}
+
 async function writeTextFile(path: string, value: string): Promise<void> {
   if (typeof Bun !== "undefined") {
     const fsModulePath = "fs/promises";
@@ -37,6 +67,7 @@ async function writeTextFile(path: string, value: string): Promise<void> {
     return;
   }
   getLocalStorage()?.setItem(`gloomberb:notes:${path}`, value);
+  writeLocalTimestamp(path, Date.now());
 }
 
 async function deleteTextFile(path: string): Promise<void> {
@@ -47,6 +78,7 @@ async function deleteTextFile(path: string): Promise<void> {
     return;
   }
   getLocalStorage()?.removeItem(`gloomberb:notes:${path}`);
+  writeLocalTimestamp(path, null);
 }
 
 export class NotesFiles {
@@ -82,6 +114,54 @@ export class NotesFiles {
     }
   }
 
+  /** Every stored note, ticker notes and quick notes alike, newest first. */
+  async list(): Promise<NoteFileEntry[]> {
+    const entries: NoteFileEntry[] = [];
+    for (const [key, updatedAt] of await this.listKeys()) {
+      try {
+        entries.push({ key, text: await this.load(key), updatedAt });
+      } catch {
+        // An unreadable note is skipped rather than synced as empty.
+      }
+    }
+    return entries.sort((left, right) => right.updatedAt - left.updatedAt);
+  }
+
+  private async listKeys(): Promise<Array<[string, number]>> {
+    if (typeof Bun !== "undefined") {
+      const fsModulePath = "fs/promises";
+      const { readdir, stat } = await import(fsModulePath) as typeof import("fs/promises");
+      let names: string[];
+      try {
+        names = await readdir(this.dataDir);
+      } catch {
+        return [];
+      }
+      const keys: Array<[string, number]> = [];
+      for (const name of names) {
+        if (!name.endsWith(".md")) continue;
+        try {
+          const info = await stat(joinPath(this.dataDir, name));
+          keys.push([name.slice(0, -3), Math.round(info.mtimeMs)]);
+        } catch {}
+      }
+      return keys;
+    }
+    const prefix = joinPath(this.dataDir, "");
+    const timestamps = readLocalTimestamps();
+    const storageKeyPrefix = `gloomberb:notes:${prefix}`;
+    // Notes written before the index existed are stamped now rather than at
+    // the epoch, so an older cloud copy cannot overwrite them on first sync.
+    for (const storageKey of Object.keys(globalThis.localStorage ?? {})) {
+      if (!storageKey.startsWith(storageKeyPrefix) || !storageKey.endsWith(".md")) continue;
+      const path = storageKey.slice("gloomberb:notes:".length);
+      if (timestamps[path] == null) writeLocalTimestamp(path, timestamps[path] = Date.now());
+    }
+    return Object.entries(timestamps)
+      .filter(([path]) => path.startsWith(prefix) && path.endsWith(".md"))
+      .map(([path, updatedAt]) => [path.slice(prefix.length, -3), updatedAt]);
+  }
+
   private indexPath(): string {
     return joinPath(this.dataDir, `${QUICK_NOTES_INDEX}.json`);
   }

package/src/plugins/builtin/notes/index.tsx

@@ -1,6 +1,7 @@
 import type { GloomPlugin } from "../../../types/plugin";
 import { NotesFiles } from "./files";
 import { createQuickNotesPane } from "./quick-notes-pane";
+import { createNotesSyncContributor } from "./sync";
 import { createNotesTab } from "./ticker-notes-tab";
 
 export const notesPlugin: GloomPlugin = {
@@ -22,6 +23,8 @@ export const notesPlugin: GloomPlugin = {
       });
     });
 
+    ctx.registerSyncContributor(createNotesSyncContributor(notesFiles));
+
     ctx.registerTickerResearchTab({
       id: "notes",
       name: "Notes",

package/src/plugins/builtin/notes/sync.test.ts

@@ -0,0 +1,49 @@
+import { afterEach, expect, test } from "bun:test";
+import { mkdtemp, rm } from "fs/promises";
+import { tmpdir } from "os";
+import { join } from "path";
+import type { SyncApplyContext } from "../../../sync/types";
+import { NotesFiles } from "./files";
+import { createNotesSyncContributor } from "./sync";
+
+const directories: string[] = [];
+
+afterEach(async () => {
+  for (const directory of directories.splice(0)) {
+    await rm(directory, { recursive: true, force: true });
+  }
+});
+
+async function createNotesFiles(): Promise<NotesFiles> {
+  const directory = await mkdtemp(join(tmpdir(), "gloomberb-notes-sync-"));
+  directories.push(directory);
+  return new NotesFiles(directory);
+}
+
+const applyContext = { isCurrent: () => true } as unknown as SyncApplyContext;
+
+test("resolves each note to whichever side wrote it last", async () => {
+  const notesFiles = await createNotesFiles();
+  await notesFiles.save("AAPL", "local aapl");
+  await notesFiles.save("MSFT", "local msft");
+  const contributor = createNotesSyncContributor(notesFiles);
+
+  await contributor.apply?.({
+    notes: [
+      { key: "AAPL", text: "remote aapl", updatedAt: Date.now() + 60_000 },
+      { key: "MSFT", text: "remote msft", updatedAt: Date.now() - 60_000 },
+      { key: "TSLA", text: "remote tsla", updatedAt: Date.now() },
+    ],
+    quickNotes: [{ id: "note-1", title: "Remote", updatedAt: Date.now() }],
+  }, applyContext);
+
+  expect(await notesFiles.load("AAPL")).toBe("remote aapl");
+  expect(await notesFiles.load("MSFT")).toBe("local msft");
+  expect(await notesFiles.load("TSLA")).toBe("remote tsla");
+  expect(await notesFiles.loadQuickNotesIndex()).toEqual([
+    { id: "note-1", title: "Remote", updatedAt: expect.any(Number) },
+  ]);
+
+  const payload = await contributor.collect({} as never) as { notes: Array<{ key: string }> };
+  expect(payload.notes.map((note) => note.key).sort()).toEqual(["AAPL", "MSFT", "TSLA"]);
+});