gloomberb 0.11.0 → 0.11.2

package/src/plugins/builtin/notes/sync.ts

@@ -0,0 +1,98 @@
+import type { SyncContributor } from "../../../sync/types";
+import type { NoteFileEntry, NotesFiles, QuickNoteEntry } from "./files";
+
+// The server rejects snapshots over 1.5MB, and notes share it with portfolios.
+const MAX_NOTE_CHARS = 100_000;
+const MAX_NOTES_CHARS = 400_000;
+
+interface SyncedNote {
+  key: string;
+  text: string;
+  updatedAt: number;
+}
+
+function isPlainObject(value: unknown): value is Record<string, unknown> {
+  return value != null && typeof value === "object" && !Array.isArray(value);
+}
+
+function parseNotes(value: unknown): SyncedNote[] {
+  if (!Array.isArray(value)) return [];
+  return value.flatMap((entry) => (
+    isPlainObject(entry) && typeof entry.key === "string" && typeof entry.text === "string"
+      ? [{
+        key: entry.key,
+        text: entry.text,
+        updatedAt: typeof entry.updatedAt === "number" && Number.isFinite(entry.updatedAt)
+          ? entry.updatedAt
+          : 0,
+      }]
+      : []
+  ));
+}
+
+function parseQuickNotes(value: unknown): QuickNoteEntry[] {
+  if (!Array.isArray(value)) return [];
+  return value.flatMap((entry) => (
+    isPlainObject(entry) && typeof entry.id === "string" && typeof entry.title === "string"
+      ? [{
+        id: entry.id,
+        title: entry.title,
+        updatedAt: typeof entry.updatedAt === "number" ? entry.updatedAt : undefined,
+      }]
+      : []
+  ));
+}
+
+function withinBudget(entries: NoteFileEntry[]): SyncedNote[] {
+  const notes: SyncedNote[] = [];
+  let total = 0;
+  for (const entry of entries) {
+    if (entry.text.length > MAX_NOTE_CHARS) continue;
+    if (total + entry.text.length > MAX_NOTES_CHARS) break;
+    total += entry.text.length;
+    notes.push(entry);
+  }
+  return notes;
+}
+
+/**
+ * Notes live in files rather than app state, so they carry their own
+ * timestamps and merge per note: newest write wins, identical text is left
+ * alone so the two sides converge instead of ping-ponging.
+ *
+ * ponytail: deletions do not propagate, a note deleted on one device comes
+ * back from the cloud. Add tombstones if that turns out to matter.
+ */
+export function createNotesSyncContributor(notesFiles: NotesFiles): SyncContributor {
+  return {
+    id: "notes",
+    schemaVersion: 1,
+    collect: async () => ({
+      // list() is newest first, so the budget keeps the notes worked on last.
+      notes: withinBudget(await notesFiles.list()),
+      quickNotes: await notesFiles.loadQuickNotesIndex(),
+    }),
+    apply: async (payload, { isCurrent }) => {
+      if (!isPlainObject(payload)) return;
+      const local = new Map((await notesFiles.list()).map((entry) => [entry.key, entry]));
+
+      for (const remote of parseNotes(payload.notes)) {
+        if (!isCurrent()) return;
+        const current = local.get(remote.key);
+        if (current && (current.text === remote.text || current.updatedAt >= remote.updatedAt)) continue;
+        await notesFiles.save(remote.key, remote.text);
+      }
+
+      if (!isCurrent()) return;
+      const merged = new Map((await notesFiles.loadQuickNotesIndex()).map((entry) => [entry.id, entry]));
+      let changed = false;
+      for (const remote of parseQuickNotes(payload.quickNotes)) {
+        const current = merged.get(remote.id);
+        if (current && (current.updatedAt ?? 0) >= (remote.updatedAt ?? 0)) continue;
+        merged.set(remote.id, remote);
+        changed = true;
+      }
+      if (changed) await notesFiles.saveQuickNotesIndex([...merged.values()]);
+    },
+  };
+}

package/src/plugins/builtin/options/index.tsx

@@ -50,6 +50,7 @@ export const optionsModule: PluginModule = {
       description: "Options chain for the selected ticker.",
       keywords: ["options", "chain", "calls", "puts", "omon"],
       shortcut: "OMON",
+      publicShare: true,
     }),
   ],
 

package/src/plugins/builtin/options/view.test.tsx

@@ -1,5 +1,5 @@
 import { afterEach, expect, test } from "bun:test";
-import { act } from "react";
+import { act, useState } from "react";
 import type { ScrollBoxRenderable } from "@opentui/core";
 import { testRender } from "../../../renderers/opentui/test-utils";
 import { MarketDataCoordinator, setSharedMarketDataCoordinator } from "../../../market-data/coordinator";
@@ -17,6 +17,7 @@ import { OptionsView } from "./view";
 const TEST_PANE_ID = "ticker-detail:options-test";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
+let setOptionsQuotePrice: ((price: number) => void) | null = null;
 
 function makeTicker(symbol: string): TickerRecord {
   return {
@@ -125,6 +126,12 @@ function OptionsHarness({
   );
 }
 
+function RealtimeOptionsHarness({ ticker }: { ticker: TickerRecord }) {
+  const [quotePrice, setQuotePrice] = useState(120.2);
+  setOptionsQuotePrice = setQuotePrice;
+  return <OptionsHarness ticker={ticker} quotePrice={quotePrice} />;
+}
+
 async function renderSettled() {
   for (let i = 0; i < 4; i += 1) {
     await act(async () => {
@@ -141,6 +148,7 @@ afterEach(async () => {
     });
     testSetup = undefined;
   }
+  setOptionsQuotePrice = null;
   setSharedMarketDataCoordinator(null);
 });
 
@@ -168,7 +176,7 @@ test("defaults the table around the nearest strike to the current quote", async
   expect(frame).not.toContain(" 50 ");
 });
 
-test("streams every visible option row and overlays live contract quotes", async () => {
+test("streams live quotes without resetting manual scroll", async () => {
   const strikes = Array.from({ length: 100 }, (_, index) => 50 + index);
   const subscriptions: QuoteSubscriptionTarget[][] = [];
   let emitQuote:
@@ -187,7 +195,7 @@ test("streams every visible option row and overlays live contract quotes", async
 
   await act(async () => {
     testSetup = await testRender(
-      <OptionsHarness ticker={makeTicker("AAPL")} quotePrice={120.2} />,
+      <RealtimeOptionsHarness ticker={makeTicker("AAPL")} />,
       {
         width: 124,
         height: 16,
@@ -238,6 +246,20 @@ test("streams every visible option row and overlays live contract quotes", async
     }).data?.mark,
   ).toBe(99.99);
   expect(testSetup!.captureCharFrame()).toContain("99.99");
+
+  const bodyScroll = testSetup!.renderer.root.findDescendantById("options-table-body-scroll") as ScrollBoxRenderable;
+  await act(async () => {
+    bodyScroll.scrollTo(0);
+    await testSetup!.renderOnce();
+  });
+  await renderSettled();
+
+  await act(async () => {
+    setOptionsQuotePrice?.(120.3);
+    await testSetup!.renderOnce();
+  });
+  await renderSettled();
+  expect(bodyScroll.scrollTop).toBe(0);
 });
 
 test("lets the expiration tab row use the full available width", async () => {

package/src/plugins/builtin/options/view.tsx

@@ -465,6 +465,7 @@ export function OptionsView({ width, height, focused, onCapture = () => {} }: Op
         sortDirection="asc"
         onHeaderClick={() => {}}
         onTableMouseDown={enterInteractive}
+        onBodyScrollActivity={() => { userSelectedStrikeRef.current = true; }}
         visibleRangeKey={viewportKey}
         onVisibleRangeChange={handleVisibleStrikeRangeChange}
         getItemKey={(row) => String(row.strike)}

package/src/plugins/builtin/portfolio-list/account-metrics.test.ts

@@ -38,6 +38,28 @@ describe("resolvePortfolioAccountMetrics", () => {
     });
   });
 
+  test("converts broker account money into the app base currency", () => {
+    const account: BrokerAccount = {
+      accountId: "DU12345",
+      name: "DU12345",
+      currency: "EUR",
+      netLiquidation: 10_000,
+      grossPositionValue: 8_000,
+      dailyPnl: 100,
+      unrealizedPnl: 400,
+      realizedPnl: -50,
+    };
+    const toUsd = (value: number) => value * 1.1;
+
+    const metrics = resolvePortfolioAccountMetrics(createTotals(), account, toUsd);
+    expect(metrics.dailyPnl).toBeCloseTo(110);
+    expect(metrics.dailyPnlPct).toBeCloseTo(110 / 10_890 * 100);
+    expect(metrics.unrealizedPnl).toBeCloseTo(440);
+    expect(metrics.unrealizedPnlPct).toBeCloseTo(5.5);
+    expect(metrics.realizedPnl).toBeCloseTo(-55);
+    expect(resolvePortfolioMarketValue(createTotals(), account, toUsd)).toBeCloseTo(8_800);
+  });
+
   test("falls back to reconstructed portfolio totals when broker P&L is missing", () => {
     expect(resolvePortfolioAccountMetrics(createTotals(), null)).toEqual({
       dailyPnl: 50,

package/src/plugins/builtin/portfolio-list/account-metrics.ts

@@ -17,9 +17,12 @@ function percentChange(value: number, previousValue: number): number {
   return previousValue !== 0 ? (value / previousValue) * 100 : 0;
 }
 
-export function resolveBrokerPortfolioMarketValue(account?: BrokerAccount | null): number | null {
+export function resolveBrokerPortfolioMarketValue(
+  account?: BrokerAccount | null,
+  convertAccountValue: (value: number) => number = (value) => value,
+): number | null {
   if (finiteNumber(account?.grossPositionValue)) {
-    return account.grossPositionValue;
+    return convertAccountValue(account.grossPositionValue);
   }
   return null;
 }
@@ -27,24 +30,26 @@ export function resolveBrokerPortfolioMarketValue(account?: BrokerAccount | null
 export function resolvePortfolioMarketValue(
   totals: PortfolioSummaryTotals,
   account?: BrokerAccount | null,
+  convertAccountValue: (value: number) => number = (value) => value,
 ): number {
-  return resolveBrokerPortfolioMarketValue(account) ?? totals.totalMktValue;
+  return resolveBrokerPortfolioMarketValue(account, convertAccountValue) ?? totals.totalMktValue;
 }
 
 export function resolvePortfolioAccountMetrics(
   totals: PortfolioSummaryTotals,
   account?: BrokerAccount | null,
+  convertAccountValue: (value: number) => number = (value) => value,
 ): PortfolioAccountMetrics {
-  const brokerDailyPnl = finiteNumber(account?.dailyPnl) ? account.dailyPnl : null;
+  const brokerDailyPnl = finiteNumber(account?.dailyPnl) ? convertAccountValue(account.dailyPnl) : null;
   const dailyPnl = brokerDailyPnl ?? totals.dailyPnl;
   const previousNetLiquidation = brokerDailyPnl != null && finiteNumber(account?.netLiquidation)
-    ? account.netLiquidation - dailyPnl
+    ? convertAccountValue(account.netLiquidation) - dailyPnl
     : null;
   const dailyPnlPct = previousNetLiquidation != null
     ? percentChange(dailyPnl, previousNetLiquidation)
     : totals.dailyPnlPct;
 
-  const brokerUnrealizedPnl = finiteNumber(account?.unrealizedPnl) ? account.unrealizedPnl : null;
+  const brokerUnrealizedPnl = finiteNumber(account?.unrealizedPnl) ? convertAccountValue(account.unrealizedPnl) : null;
   const unrealizedPnl = brokerUnrealizedPnl ?? totals.unrealizedPnl;
   const unrealizedPnlPct = totals.totalCostBasis !== 0
     ? percentChange(unrealizedPnl, totals.totalCostBasis)
@@ -55,6 +60,6 @@ export function resolvePortfolioAccountMetrics(
     dailyPnlPct,
     unrealizedPnl,
     unrealizedPnlPct,
-    realizedPnl: finiteNumber(account?.realizedPnl) ? account.realizedPnl : undefined,
+    realizedPnl: finiteNumber(account?.realizedPnl) ? convertAccountValue(account.realizedPnl) : undefined,
   };
 }

package/src/plugins/builtin/portfolio-list/cli/render.ts

@@ -142,11 +142,13 @@ async function showCollectionWithMarketData(
         const multiplier = position.multiplier ?? 1;
         const quoteCurrency = quote?.currency ?? ticker.metadata.currency ?? baseCurrency;
         const positionCurrency = position.currency ?? quoteCurrency;
+        const direction = position.side === "short" || position.shares < 0 ? -1 : 1;
+        const magnitude = Math.abs(position.shares);
         const currentValueBase = quote
-          ? await toBase(Math.abs(position.shares) * quote.price * multiplier, quoteCurrency)
+          ? await toBase(magnitude * quote.price * multiplier, quoteCurrency)
           : null;
-        const costBasisBase = await toBase(position.shares * position.avgCost * multiplier, positionCurrency);
-        const pnl = currentValueBase != null ? currentValueBase - costBasisBase : null;
+        const costBasisBase = await toBase(magnitude * position.avgCost * multiplier, positionCurrency);
+        const pnl = currentValueBase != null ? direction * (currentValueBase - costBasisBase) : null;
         if (pnl != null) totalPnl += pnl;
 
         rows.push([

package/src/plugins/builtin/portfolio-list/column-values.ts

@@ -26,6 +26,7 @@ import {
   getPortfolioPositionMetrics,
   resolveBrokerFallbackMarketValue,
   resolveBrokerFallbackPnl,
+  signedQuoteUnrealizedPnl,
 } from "./position-metrics";
 
 export interface ColumnContext {
@@ -332,7 +333,11 @@ export function getColumnValue(
       return { text: "—" };
     case "pnl":
       if (activeQuote && totalPriceUnits !== 0) {
-        const pnl = toBaseQuote(Math.abs(totalPriceUnits) * activeQuote.price) - toBasePosition(totalCost);
+        const pnl = signedQuoteUnrealizedPnl(
+          toBaseQuote(Math.abs(totalPriceUnits) * activeQuote.price),
+          toBasePosition(totalCost),
+          totalPriceUnits,
+        );
         return { text: `${pnl >= 0 ? "+" : ""}${formatCompact(pnl)}`, color: priceColor(pnl) };
       }
       if (brokerFallbackPnl != null) {
@@ -344,7 +349,8 @@ export function getColumnValue(
       if (activeQuote && totalCost !== 0) {
         const marketValue = toBaseQuote(Math.abs(totalPriceUnits) * activeQuote.price);
         const costBasis = toBasePosition(totalCost);
-        const percent = costBasis !== 0 ? ((marketValue - costBasis) / costBasis) * 100 : 0;
+        const pnl = signedQuoteUnrealizedPnl(marketValue, costBasis, totalPriceUnits);
+        const percent = costBasis !== 0 ? (pnl / costBasis) * 100 : 0;
         return { text: formatPercentRaw(percent), color: priceColor(percent) };
       }
       if (brokerFallbackPnl != null && totalCost !== 0) {
@@ -530,7 +536,11 @@ export function getSortValue(
       return null;
     case "pnl":
       if (activeQuote && totalPriceUnits !== 0) {
-        return toBaseQuote(Math.abs(totalPriceUnits) * activeQuote.price) - toBasePosition(totalCost);
+        return signedQuoteUnrealizedPnl(
+          toBaseQuote(Math.abs(totalPriceUnits) * activeQuote.price),
+          toBasePosition(totalCost),
+          totalPriceUnits,
+        );
       }
       if (brokerFallbackPnl != null) {
         return toBasePosition(brokerFallbackPnl);
@@ -540,7 +550,8 @@ export function getSortValue(
       if (activeQuote && totalCost !== 0) {
         const marketValue = toBaseQuote(Math.abs(totalPriceUnits) * activeQuote.price);
         const costBasis = toBasePosition(totalCost);
-        return costBasis !== 0 ? ((marketValue - costBasis) / costBasis) * 100 : null;
+        const pnl = signedQuoteUnrealizedPnl(marketValue, costBasis, totalPriceUnits);
+        return costBasis !== 0 ? (pnl / costBasis) * 100 : null;
       }
       if (brokerFallbackPnl != null && totalCost !== 0) {
         const costBasis = toBasePosition(totalCost);

package/src/plugins/builtin/portfolio-list/header.tsx

@@ -7,7 +7,7 @@ import { colors } from "../../../theme/colors";
 import type { BrokerConnectionStatus } from "../../../types/broker";
 import type { Portfolio } from "../../../types/ticker";
 import type { BrokerAccount } from "../../../types/trading";
-import { formatCompact, padTo } from "../../../utils/format";
+import { convertCurrency, formatCompact, padTo } from "../../../utils/format";
 import { formatMarketQuantity } from "../../../market-data/market/format";
 import { getBrokerInstance } from "../../../utils/broker-instances";
 import { usePluginBrokerActions } from "../../runtime";
@@ -90,14 +90,24 @@ export function PortfolioCashMarginDrawer({
   onToggle,
   width,
   height,
+  baseCurrency,
+  exchangeRates,
 }: {
   accountState: ResolvedPortfolioAccountState;
   expanded: boolean;
   onToggle: () => void;
   width: number;
   height: number;
+  baseCurrency: string;
+  exchangeRates: Map<string, number>;
 }) {
-  const previewText = `${accountState.visibleCashBalances.length} ccy · Cash ${formatCompact(accountState.account.totalCashValue)} · ${accountState.sourceLabel}`;
+  const convertAccountValue = (value: number) => convertCurrency(
+    value,
+    accountState.account.currency || baseCurrency,
+    baseCurrency,
+    exchangeRates,
+  );
+  const previewText = `${accountState.visibleCashBalances.length} ccy · Cash ${formatCompact(convertAccountValue(accountState.account.totalCashValue ?? 0))} · ${accountState.sourceLabel}`;
   const drawerHeight = Math.max(1, height);
 
   if (!expanded) {
@@ -124,7 +134,7 @@ export function PortfolioCashMarginDrawer({
     );
   }
 
-  const metricSegments = buildDrawerMetricSegments(accountState.account, width);
+  const metricSegments = buildDrawerMetricSegments(accountState.account, width, convertAccountValue);
   const currencyRowsHeight = Math.max(1, drawerHeight - 2);
 
   return (

package/src/plugins/builtin/portfolio-list/index.tsx

@@ -47,7 +47,15 @@ export const portfolioListModule: PluginModule = {
       defaultPosition: "left",
       defaultMode: "floating",
       defaultWidth: "40%",
+      tickerSource: true,
       quickSettings: [LIVE_STREAMING_QUICK_SETTING],
+      portableShare: {
+        private: {
+          params: ["collectionId"],
+          settings: ["collectionId", "visibleCollectionIds"],
+          state: ["collectionId", "collectionSorts"],
+        },
+      },
       settings: (context) => withLiveStreamingSetting(
         buildPortfolioPaneSettingsDef(
           context.config,

package/src/plugins/builtin/portfolio-list/metrics.test.ts

@@ -199,7 +199,7 @@ describe("portfolio-metrics", () => {
 
     expect(totals.totalMktValue).toBeCloseTo(58803.06, 2);
     expect(totals.totalCostBasis).toBeCloseTo(50950.7295, 4);
-    expect(totals.unrealizedPnl).toBeCloseTo(7852.3305, 4);
+    expect(totals.unrealizedPnl).toBeCloseTo(7852.33, 4);
     expect(totals.hasPositions).toBe(true);
   });
 
@@ -277,6 +277,36 @@ describe("portfolio-metrics", () => {
     });
   });
 
+  test("signs short unrealized P&L from a live quote", () => {
+    const ticker = createTicker({
+      positions: [{ portfolio: "main", shares: 10, avgCost: 100, broker: "ibkr", side: "short" }],
+    });
+    const financials = createFinancials({
+      quote: { price: 80, change: -20, changePercent: -20, previousClose: 100 },
+    });
+    const dayPnlColumn: ColumnConfig = { id: "day_pnl", label: "DAY", width: 10, align: "right", format: "compact" };
+    const pnlColumn: ColumnConfig = { id: "pnl", label: "P&L", width: 10, align: "right", format: "compact" };
+
+    expect(getSortValue(dayPnlColumn, ticker, financials, defaultColumnContext)).toBe(200);
+    expect(getSortValue(pnlColumn, ticker, financials, defaultColumnContext)).toBe(200);
+    expect(getColumnValue(pnlColumn, ticker, financials, defaultColumnContext)).toEqual({
+      text: "+200",
+      color: expect.any(String),
+    });
+    expect(calculatePortfolioSummaryTotals(
+      [ticker],
+      new Map([["AAPL", financials]]),
+      "USD",
+      new Map([["USD", 1]]),
+      true,
+      "main",
+    )).toMatchObject({
+      totalMktValue: 800,
+      dailyPnl: 200,
+      unrealizedPnl: 200,
+    });
+  });
+
   test("formats derived quote and position columns", () => {
     const ticker = createTicker({
       sector: "Technology",

package/src/plugins/builtin/portfolio-list/pane/index.test.tsx

@@ -431,6 +431,7 @@ async function renderHiddenChangePctSortWarmup(options: { staleCachedSiveSnapsho
           previousClose: 0,
           listingExchangeName: "NASDAQ",
           lastUpdated: Date.now() - 24 * 60 * 60_000,
+          stale: true,
         }),
       },
     }]);

package/src/plugins/builtin/portfolio-list/pane/index.tsx

@@ -6,7 +6,7 @@ import {
   type DataTableKeyEvent,
   type TickerListVisibleRange,
 } from "../../../../components";
-import { usePluginTickerActions } from "../../../runtime";
+import { useTickerSourceActivate } from "../../shared/ticker-source";
 import { useFxRatesMap, useTickerFinancialsMap } from "../../../../market-data/hooks";
 import { useAppActive } from "../../../../state/app/activity";
 import {
@@ -20,7 +20,6 @@ import {
 import { selectEffectiveExchangeRates } from "../../../../utils/exchange-rate-map";
 import type { TickerRecord } from "../../../../types/ticker";
 import type { PaneProps } from "../../../../types/plugin";
-import { TICKER_RESEARCH_PANE_ID } from "../../../../types/config";
 import { calculatePortfolioSummaryTotals, resolveCollectionSortPreference, type ColumnContext } from "../metrics";
 import {
   PortfolioCashMarginDrawer,
@@ -55,7 +54,7 @@ import { useLiveStreamingSetting } from "../../shared/live-streaming";
 import { useThrottledTickerOrder } from "../use-throttled-ticker-order";
 
 export function PortfolioListPane({ focused, width, height }: PaneProps) {
-  const { pinTicker } = usePluginTickerActions();
+  const activateTicker = useTickerSourceActivate();
   const paneInstance = usePaneInstance();
   const appActive = useAppActive();
   const config = useAppSelector((state) => state.config);
@@ -238,9 +237,9 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     setSortPreference({ columnId, direction: "asc" });
   }, [activeSort.columnId, activeSort.direction, setSortPreference]);
 
-  const openTickerFloating = useCallback((symbol: string) => {
-    pinTicker(symbol, { floating: true, paneType: TICKER_RESEARCH_PANE_ID });
-  }, [pinTicker]);
+  const openTickerFloating = useCallback((symbol: string, options?: { newPane?: boolean }) => {
+    activateTicker(symbol, { floating: true, newPane: options?.newPane });
+  }, [activateTicker]);
 
   const toggleViewMode = useCallback(() => {
     if (!isPortfolioTab) return;
@@ -266,7 +265,8 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
       event.stopPropagation?.();
       const ticker = sortedTickers[safeSelectedIdx];
       if (ticker) {
-        openTickerFloating(ticker.metadata.ticker);
+        flushCursorSymbol(ticker.metadata.ticker);
+        openTickerFloating(ticker.metadata.ticker, { newPane: true });
       }
       return true;
     }
@@ -288,6 +288,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     return false;
   }, [
     cashDrawerExpanded,
+    flushCursorSymbol,
     focused,
     isPortfolioTab,
     openTickerFloating,
@@ -475,6 +476,8 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
             onToggle={() => setCashDrawerExpanded(!cashDrawerExpanded)}
             width={Math.max(0, width - 2)}
             height={drawerHeight}
+            baseCurrency={config.baseCurrency}
+            exchangeRates={effectiveExchangeRates}
           />
         </Box>
       )}

package/src/plugins/builtin/portfolio-list/pane/streaming.ts

@@ -71,7 +71,12 @@ export function usePortfolioPaneStreaming({
   const streamTargets = useMemo(() => (
     sortedTickers
       .map((ticker) => {
-        const target = quoteSubscriptionTargetFromTicker(ticker, ticker.metadata.ticker, "provider", instrumentOptions);
+        const target = quoteSubscriptionTargetFromTicker(
+          ticker,
+          ticker.metadata.ticker,
+          isPortfolioTab && (ticker.metadata.broker_contracts?.length ?? 0) > 0 ? "broker" : "provider",
+          instrumentOptions,
+        );
         if (!target) return null;
         const selected = ticker.metadata.ticker === cursorSymbol;
         const visible = priorityStreamSymbols.has(ticker.metadata.ticker);

package/src/plugins/builtin/portfolio-list/position-metrics.ts

@@ -27,6 +27,24 @@ function normalizePositionMultiplier(multiplier: number | undefined): number {
     : 1;
 }
 
+export function signedPositionDirection(position: {
+  shares: number;
+  side?: "long" | "short";
+}): 1 | -1 {
+  if (position.side === "short") return -1;
+  if (position.side === "long") return 1;
+  return position.shares < 0 ? -1 : 1;
+}
+
+/** Quote-path unrealized P&L. Shorts profit when market value falls below cost. */
+export function signedQuoteUnrealizedPnl(
+  absMarketValue: number,
+  cost: number,
+  totalPriceUnits: number,
+): number {
+  return (totalPriceUnits < 0 ? -1 : 1) * (absMarketValue - cost);
+}
+
 function resolvePositionCostMultiplier(
   position: TickerRecord["metadata"]["positions"][number],
 ): number {
@@ -37,7 +55,7 @@ function resolvePositionCostMultiplier(
     return priceMultiplier;
   }
 
-  const costWithoutMultiplier = position.shares * position.avgCost;
+  const costWithoutMultiplier = Math.abs(position.shares) * position.avgCost;
   const costWithMultiplier = costWithoutMultiplier * priceMultiplier;
   const withoutMultiplierError = Math.abs((position.marketValue - costWithoutMultiplier) - position.unrealizedPnl);
   const withMultiplierError = Math.abs((position.marketValue - costWithMultiplier) - position.unrealizedPnl);
@@ -65,15 +83,16 @@ export function getPortfolioPositionMetrics(
   let brokerPnl = 0;
   let hasBrokerPnl = false;
   for (const position of tabPositions) {
-    const direction = position.side === "short" ? -1 : 1;
+    const direction = signedPositionDirection(position);
+    const magnitude = Math.abs(position.shares);
     const priceMultiplier = normalizePositionMultiplier(position.multiplier);
     const costMultiplier = resolvePositionCostMultiplier(position);
     multiplierHint = Math.max(multiplierHint, priceMultiplier, costMultiplier);
 
-    totalShares += position.shares * direction;
-    totalCost += position.shares * position.avgCost * costMultiplier;
-    totalCostUnits += position.shares * costMultiplier;
-    totalPriceUnits += position.shares * priceMultiplier * direction;
+    totalShares += magnitude * direction;
+    totalCost += magnitude * position.avgCost * costMultiplier;
+    totalCostUnits += magnitude * costMultiplier;
+    totalPriceUnits += magnitude * priceMultiplier * direction;
 
     if (position.marketValue != null) {
       brokerMktValue += position.marketValue;