forge-workflow 0.0.10 → 0.1.0-beta.3

package/lib/commands/test.js

@@ -27,6 +27,18 @@ const LOCKFILE_MAP = [
 
 const DEFAULT_TIMEOUT = 120000;
 const BEADS_CHECK_TIMEOUT = 3000;
+const DIRECT_TEST_CANDIDATES = Object.freeze({
+	'bin/forge.js': [
+		'test/cli-flags.test.js',
+		'test/forge-cli-registry.test.js',
+		'test/setup-github-sync.test.js',
+		'test/setup-runtime-flags.test.js',
+	],
+	'lib/lefthook-check.js': ['test/lefthook-check.test.js', 'test/runtime-health.test.js'],
+	'lib/runtime-health.js': ['test/runtime-health.test.js'],
+	'lib/upgrade-safety.js': ['test/commands/upgrade.test.js'],
+	'scripts/test.js': ['test/scripts/test-runner.test.js'],
+});
 
 /**
  * Detect the package manager by checking which lockfile exists.
@@ -115,7 +127,17 @@ function getChangedFiles(execFileSync, options = {}) {
 			encoding: 'utf8',
 			timeout: 5000,
 		}).trim();
-	} catch (_e) { // NOSONAR S2486
+	} catch (err) { // NOSONAR S2486
+		// A git-diff FAILURE is NOT the same as "no files changed": we could not
+		// determine the change set at all. Callers that must fail closed (preflight)
+		// pass { strict: true } so the error surfaces instead of masquerading as an
+		// empty list. The default path keeps the historical empty-list fallback that
+		// `forge test --affected` and the pre-push mapping rely on to run the full
+		// suite, so their semantics are unchanged.
+		if (options.strict) {
+			const reason = err && err.message ? err.message : String(err);
+			throw new Error(`git diff failed while computing changed files: ${reason}`);
+		}
 		/* intentional: git diff failed, no affected files to report */
 		return [];
 	}
@@ -152,22 +174,29 @@ function getAffectedTestFiles(projectRoot, execFileSync, fs = defaultFs, options
 function getTestCandidatesForChangedFile(file) {
 	if (!file) return [];
 
-	if (file === 'lib/lefthook-check.js') {
-		return ['test/lefthook-check.test.js', 'test/runtime-health.test.js'];
-	}
-
-	if (file === 'lib/runtime-health.js') {
-		return ['test/runtime-health.test.js'];
-	}
-
-	if (file === 'scripts/test.js') {
-		return ['test/scripts/test-runner.test.js'];
+	const directCandidates = DIRECT_TEST_CANDIDATES[file];
+	if (directCandidates) {
+		return directCandidates;
 	}
 
 	if (file.startsWith('test/') && file.endsWith('.test.js')) {
 		return [file];
 	}
 
+	if (file === 'README.md'
+		|| file === 'QUICKSTART.md'
+		|| file === 'CHANGELOG.md'
+		|| file === 'AGENTS.md'
+		|| file === 'DEVELOPMENT.md'
+		|| file === 'docs/INDEX.md'
+		|| file === 'docs/PROJECT_DESIGN.md'
+		|| file.startsWith('docs/forge/')
+		|| file.startsWith('docs/guides/')
+		|| file.startsWith('docs/reference/')
+		|| file.startsWith('docs/work/')) {
+		return ['test/docs-consistency.test.js'];
+	}
+
 	if (file.startsWith('lib/') && file.endsWith('.js')) {
 		const relative = file.slice('lib/'.length);
 		return [`test/${relative.replace(/\.js$/, '.test.js')}`];
@@ -196,26 +225,13 @@ function getTestCandidatesForChangedFile(file) {
 		];
 	}
 
-	if (file.startsWith('.claude/commands/') && file.endsWith('.md')) {
-		return [
-			'test/command-sync-check.test.js',
-			'test/structural/command-sync.test.js',
-		];
-	}
-
 	if (file.startsWith('.forge/')
 		|| file.startsWith('.cursor/')
-		|| file.startsWith('.cline/')
-		|| file.startsWith('.roo/')
-		|| file.startsWith('.kilocode/')
-		|| file.startsWith('.opencode/')
-		|| file.startsWith('.codex/skills/')
-		|| file.startsWith('.github/prompts/')) {
+		|| file.startsWith('.codex/')) {
 		return [
 			'test/agent-gaps.test.js',
-			'test/command-sync-check.test.js',
 			'test/scripts/check-agents.test.js',
-			'test/structural/command-sync.test.js',
+			'test/structural/skills-sync-drift.test.js',
 		];
 	}
 
@@ -227,7 +243,7 @@ module.exports = {
 	getAffectedTestFiles,
 	getTestCandidatesForChangedFile,
 	name: 'test',
-	description: 'Run tests with smart defaults (timeout, Beads skip, affected-only)',
+	description: 'Run tests with smart defaults (timeout, affected-only)',
 	usage: 'forge test [--affected]',
 	flags: {
 		'--affected': 'Run only tests for changed files',

package/lib/commands/update.js

@@ -1,5 +1,5 @@
 'use strict';
 
-const { makeAliasCommand } = require('./_issue');
+const { createIssueSubcommand } = require('./_issue');
 
-module.exports = makeAliasCommand('update');
+module.exports = createIssueSubcommand('update');

package/lib/commands/upgrade.js

@@ -0,0 +1,47 @@
+'use strict';
+
+const {
+  applySelfHeal,
+  buildUpgradeDryRunReport,
+  renderUpgradeDryRunReport,
+} = require('../upgrade-safety');
+
+function hasArg(args, name) {
+  return Array.isArray(args) && args.includes(name);
+}
+
+const usage = 'Usage: forge upgrade [--dry-run] [--self-heal]';
+
+async function handler(args, flags, projectRoot) {
+  const dryRun = flags?.dryRun === true || flags?.['dry-run'] === true || hasArg(args, '--dry-run');
+  const selfHeal = flags?.selfHeal === true || flags?.['self-heal'] === true || hasArg(args, '--self-heal');
+
+  if (!dryRun && !selfHeal) {
+    return {
+      success: false,
+      error: usage,
+    };
+  }
+
+  const report = buildUpgradeDryRunReport(projectRoot);
+  const selfHealResult = selfHeal ? applySelfHeal(report.projectRoot, report) : null;
+  const output = renderUpgradeDryRunReport(report, selfHealResult);
+  const success = report.ok && !selfHealResult?.refused;
+
+  return {
+    success,
+    output,
+    error: success ? undefined : output,
+  };
+}
+
+module.exports = {
+  name: 'upgrade',
+  description: 'Preview and self-heal safe Forge upgrade readiness',
+  usage,
+  flags: {
+    '--dry-run': 'Preview upgrade readiness without writing files',
+    '--self-heal': 'Apply safe metadata repairs only; does not snapshot or restore',
+  },
+  handler,
+};

package/lib/commands/validate.js

@@ -11,6 +11,7 @@
 const { execFileSync } = require('node:child_process');
 const fs = require('node:fs');
 const path = require('node:path');
+const { secureExecFileSync } = require('../shell-utils');
 
 // Constants
 const CHECK_TYPES = {
@@ -31,15 +32,11 @@ const CONFLICT_MARKER_IGNORE_DIRS = new Set([
 ]);
 const CONFLICT_MARKER_ALLOWED_DOT_DIRS = new Set([
 	'.claude',
-	'.cline',
 	'.codex',
 	'.cursor',
 	'.forge',
 	'.github',
 	'.husky',
-	'.kilocode',
-	'.opencode',
-	'.roo',
 	'.sonarlint',
 ]);
 const CONFLICT_START_PATTERN = /^<<<<<<<(?: .*)?$/;
@@ -466,7 +463,7 @@ async function runSecurityScan() { // NOSONAR S3776
 		try {
 			let npmRawOutput = null;
 			try {
-				npmRawOutput = execFileSync('npm', ['audit', '--json', '--production'], getExecOptions());  // NOSONAR S4036 - hardcoded CLI command, no user input, developer tool context
+				npmRawOutput = secureExecFileSync('npm', ['audit', '--json', '--production'], getExecOptions());  // NOSONAR S4036 - hardcoded CLI command, no user input, developer tool context
 			} catch (npmExitError) {
 				if (npmExitError.killed && npmExitError.signal === 'SIGTERM') {
 					return {
@@ -566,23 +563,46 @@ async function runSecurityScan() { // NOSONAR S3776
  * const result = await runAllTests();
  * console.log(`${result.passed}/${result.total} tests passed`);
  */
-async function runAllTests() {
+function parseTestCounts(output) {
+	const text = String(output || '');
+	const passed = parseNumber(/(\d+) pass/.exec(text));  // NOSONAR S5852 - bounded \d+ pattern
+	const failed = parseNumber(/(\d+) fail/.exec(text));  // NOSONAR S5852 - bounded \d+ pattern
+	const skipped = parseNumber(/(\d+) skip/.exec(text));  // NOSONAR S5852 - bounded \d+ pattern
+	const ranMatch = /Ran (\d+) tests/.exec(text);  // NOSONAR S5852 - bounded \d+ pattern
+	const total = ranMatch ? parseNumber(ranMatch, 1) : passed + failed + skipped;
+	return { passed, failed, skipped, total, testsFound: total > 0 };
+}
+
+async function runAllTests(exec = execFileSync) {
 	const startTime = Date.now();
 
 	try {
-		const result = execFileSync('bun', ['test', '--timeout', '30000'], getExecOptions());  // NOSONAR S4036 - hardcoded CLI command, no user input, developer tool context
+		const result = exec('bun', ['test', '--timeout', '30000'], getExecOptions());  // NOSONAR S4036 - hardcoded CLI command, no user input, developer tool context
+
+		const { passed, failed, skipped, total, testsFound } = parseTestCounts(result);
 
-		// Parse bun test output
-		const passed = parseNumber(/(\d+) pass/.exec(result));  // NOSONAR S5852 - bounded \d+ pattern
-		const failed = parseNumber(/(\d+) fail/.exec(result));  // NOSONAR S5852 - bounded \d+ pattern
-		const skipped = parseNumber(/(\d+) skip/.exec(result));  // NOSONAR S5852 - bounded \d+ pattern
-		const total = parseNumber(/Ran (\d+) tests/.exec(result), 1, passed + failed + skipped);
+		// B2 (N1): a bun run that executes 0 tests must NEVER report PASS — that
+		// manufactures false confidence. Surface it as an explicit SKIP instead.
+		if (!testsFound) {
+			return {
+				success: true,
+				skipped: true,
+				testsFound: false,
+				duration: Date.now() - startTime,
+				passed,
+				failed,
+				total,
+				message: 'No tests found — 0 tests executed (SKIP, not a pass). Add tests or check the runner config.',
+			};
+		}
 
 		return {
 			success: failed === 0,
+			testsFound: true,
 			duration: Date.now() - startTime,
 			passed,
 			failed,
+			skipped,
 			total,
 			message: failed === 0
 				? `All ${total} tests passed`
@@ -601,28 +621,32 @@ async function runAllTests() {
 			};
 		}
 
-		// Test execution failed
+		// Test runner absent — say so explicitly (do NOT silently pass).
 		if (isCommandNotFound(error)) {
 			return {
 				success: true,
 				skipped: true,
+				testsFound: false,
 				duration: Date.now() - startTime,
 				passed: 0,
 				failed: 0,
 				total: 0,
-				message: 'Tests skipped: bun not found.',
+				message: 'Tests skipped: bun test runner not found. Install bun to run tests.',
 			};
 		}
 
 		// Parse test failures from output
 		const output = error.stdout || error.message;
-		const passed = parseNumber(/(\d+) pass/.exec(output));  // NOSONAR S5852 - bounded \d+ pattern
-		const failed = parseNumber(/(\d+) fail/.exec(output), 1, 1);  // NOSONAR S5852 - bounded \d+ pattern
-		const skipped = parseNumber(/(\d+) skip/.exec(output));  // NOSONAR S5852 - bounded \d+ pattern
-		const total = passed + failed + skipped;
+		const counts = parseTestCounts(output);
+		const passed = counts.passed;
+		// bun exited non-zero: if the output shows no explicit failure count, treat
+		// it as at least one failure rather than swallowing the non-zero exit.
+		const failed = counts.failed > 0 ? counts.failed : Math.max(1, counts.failed);
+		const total = counts.total > 0 ? counts.total : passed + failed + counts.skipped;
 
 		return {
 			success: false,
+			testsFound: counts.testsFound,
 			duration: Date.now() - startTime,
 			passed,
 			failed,
@@ -832,6 +856,7 @@ module.exports = {
 	runLint,
 	runSecurityScan,
 	runAllTests,
+	parseTestCounts,
 	scanForConflictMarkers,
 	executeValidate,
 	executeDebugMode,