forge-workflow 0.0.10 → 0.1.0-beta.3

package/.claude/rules/{greptile-review-process.md → review-process.md}

@@ -1,17 +1,22 @@
-# Greptile Review Handling Process
+# Review Thread Handling Process
 
-**Purpose**: Standardized process for AI agents to systematically handle Greptile review comments.
+**Purpose**: Standardized process for AI agents to systematically handle PR
+review threads from **any review agent** — CodeRabbit, Qodo, Greptile, or a
+human reviewer. The mechanism (GitHub review threads via GraphQL/REST) is the
+same regardless of which tool or person authored the comment; the examples below
+name specific tools only as illustrations.
 
-**Critical**: This process has been problematic for days. AI agents MUST follow these exact steps for EVERY Greptile comment.
+**Critical**: Review threads left unresolved block merges. AI agents MUST follow
+these exact steps for EVERY review comment, whoever authored it.
 
 ---
 
 ## Problem Background
 
 **Previous Issues:**
-- ❌ AI agents replied to PR with general comments instead of replying directly to each Greptile review thread
+- ❌ AI agents replied to the PR with general comments instead of replying directly to each review thread
 - ❌ AI agents didn't mark conversation threads as "resolved" after fixing issues
-- ❌ No systematic process for tracking which Greptile comments are addressed vs pending
+- ❌ No systematic process for tracking which review comments are addressed vs pending
 - ❌ Caused confusion and manual tracking overhead for maintainers
 
 **Why This Matters:**
@@ -39,28 +44,31 @@
 - Reply explains what was fixed and why
 - Resolve marks the thread as addressed
 
+These two GitHub operations are author-agnostic: they work identically for a
+CodeRabbit thread, a Qodo thread, a Greptile thread, or a human reviewer's thread.
+
 ---
 
 ## For AI Agents: Mandatory Steps
 
-When Greptile Quality Gate fails (score < 4/5) or when review comments exist:
+When a review-agent quality gate fails or when review comments exist:
 
-### Step 1: List ALL Greptile Feedback (Inline + Direct Comments)
+### Step 1: List ALL Review Feedback (Inline + Direct Comments)
 
-Greptile posts feedback in **two places**:
+Review agents post feedback in **two places**:
 1. **Inline review threads** — attached to specific code lines (resolvable via GraphQL)
-2. **Direct PR issue comments** — "Additional Comments (N)" posted as regular PR comments (reply with `gh pr comment`)
+2. **Direct PR issue comments** — summaries or "Additional Comments (N)" posted as regular PR comments (reply with `gh pr comment`)
 
 Always run `list-all` to see both:
 
 ```bash
-bash .claude/scripts/greptile-resolve.sh list-all <pr-number>
+bash .claude/scripts/review-resolve.sh list-all <pr-number>
 ```
 
 Or just inline threads (unresolved only):
 
 ```bash
-bash .claude/scripts/greptile-resolve.sh list <pr-number> --unresolved
+bash .claude/scripts/review-resolve.sh list <pr-number> --unresolved
 ```
 
 **Output shows:**
@@ -68,6 +76,7 @@ bash .claude/scripts/greptile-resolve.sh list <pr-number> --unresolved
 - Comment ID (for replying to inline threads)
 - File path and line number
 - Issue description
+- Author (so you can see whether it came from CodeRabbit, Greptile, Qodo, a human, etc.)
 - Direct PR comment IDs and previews (reply with `gh pr comment`)
 
 **Example:**
@@ -85,7 +94,7 @@ bash .claude/scripts/greptile-resolve.sh list <pr-number> --unresolved
 
 1. **Read the comment** and understand the issue
    - Use the file path and line number to locate the code
-   - Understand what Greptile is flagging
+   - Understand what the reviewer is flagging
 
 2. **Fix the issue** if the comment is valid
    - Make the necessary code changes
@@ -93,7 +102,7 @@ bash .claude/scripts/greptile-resolve.sh list <pr-number> --unresolved
 
 3. **Reply to the thread** with explanation
    ```bash
-   bash .claude/scripts/greptile-resolve.sh reply <pr-number> <comment-id> "✅ Fixed: [description]
+   bash .claude/scripts/review-resolve.sh reply <pr-number> <comment-id> "✅ Fixed: [description]
 
    Changed: [what was changed]
    Reason: [why this fixes the issue]
@@ -102,14 +111,14 @@ bash .claude/scripts/greptile-resolve.sh list <pr-number> --unresolved
 
 4. **Resolve the thread**
    ```bash
-   bash .claude/scripts/greptile-resolve.sh resolve <pr-number> <thread-id>
+   bash .claude/scripts/review-resolve.sh resolve <pr-number> <thread-id>
    ```
 
 5. **Track progress**: Mark comment as addressed in your notes
 
 **Alternative (all-in-one):**
 ```bash
-bash .claude/scripts/greptile-resolve.sh reply-and-resolve <pr-number> <comment-id> <thread-id> "✅ Fixed: [description]
+bash .claude/scripts/review-resolve.sh reply-and-resolve <pr-number> <comment-id> <thread-id> "✅ Fixed: [description]
 
 Changed: [what was changed]
 Reason: [why this fixes the issue]
@@ -119,17 +128,17 @@ Commit: [commit-sha]"
 ### Step 3: Verify All Threads Resolved
 
 ```bash
-bash .claude/scripts/greptile-resolve.sh list <pr-number> --unresolved
+bash .claude/scripts/review-resolve.sh list <pr-number> --unresolved
 ```
 
 **Should show**: "No unresolved comments" or empty list
 
 **Confirm with stats:**
 ```bash
-bash .claude/scripts/greptile-resolve.sh stats <pr-number>
+bash .claude/scripts/review-resolve.sh stats <pr-number>
 ```
 
-**Should show**: "✓ All Greptile threads resolved!"
+**Should show**: all tracked review threads resolved.
 
 ### Step 4: Push Changes & Poll Briefly for Re-review
 
@@ -137,10 +146,10 @@ bash .claude/scripts/greptile-resolve.sh stats <pr-number>
 git push
 ```
 
-**Greptile will automatically:**
+**The review agent will automatically:**
 - Re-analyze the PR
-- Update the confidence score
-- Re-run the Quality Gate check
+- Update any confidence/quality score
+- Re-run its quality gate check
 
 ---
 
@@ -148,7 +157,7 @@ git push
 
 ```bash
 # 1. List unresolved threads
-$ bash .claude/scripts/greptile-resolve.sh list 24 --unresolved
+$ bash .claude/scripts/review-resolve.sh list 24 --unresolved
 
 ✗ UNRESOLVED | docs/ROADMAP.md:280
   Thread ID: PRRT_kwDORErEU85tuh6I
@@ -160,7 +169,7 @@ $ git add docs/ROADMAP.md
 $ git commit -m "fix: replace Windows absolute paths with relative paths"
 
 # 3. Reply and resolve in one step
-$ bash .claude/scripts/greptile-resolve.sh reply-and-resolve 24 2787717459 PRRT_kwDORErEU85tuh6I \
+$ bash .claude/scripts/review-resolve.sh reply-and-resolve 24 2787717459 PRRT_kwDORErEU85tuh6I \
   "✅ Fixed: Replaced Windows absolute paths with repo-relative paths
 
 Changed: C:\\Users\\...\\plans\\... → .claude/plans/*.md
@@ -171,10 +180,10 @@ Commit: abc123"
 ✅ Thread resolved successfully
 
 # 4. Verify all resolved
-$ bash .claude/scripts/greptile-resolve.sh stats 24
+$ bash .claude/scripts/review-resolve.sh stats 24
 
-Greptile unresolved: 0
-✓ All Greptile threads resolved!
+Unresolved: 0
+✓ All review threads resolved!
 
 # 5. Push changes
 $ git push
@@ -188,7 +197,7 @@ $ git push
 - **Reply to EACH comment thread** using the script (not as separate PR comment)
 - **Mark EACH thread as resolved** after fixing using the script
 - **Track progress** (X of Y fixed) in your notes
-- **Poll for Greptile re-review for at most 60 seconds** after pushing fixes, then stop and hand off if it is still pending
+- **Poll for re-review for at most 60 seconds** after pushing fixes, then stop and hand off if it is still pending
 - **Use comment ID for replies**, thread ID for resolving
 - **Commit fixes BEFORE replying** so you can reference commit SHA
 
@@ -204,54 +213,60 @@ $ git push
 
 ## Script Commands Reference
 
+The `.claude/scripts/review-resolve.sh` helper works for review threads authored
+by any tool or person. The `list-all`, `resolve-all`, and `stats` commands
+additionally recognize `greptile-apps`-authored threads as a built-in convenience
+(Greptile is one supported review tool); the core commands below are fully
+author-agnostic.
+
 ### List Threads
 ```bash
 # All threads
-bash .claude/scripts/greptile-resolve.sh list <pr-number>
+bash .claude/scripts/review-resolve.sh list <pr-number>
 
 # Only unresolved
-bash .claude/scripts/greptile-resolve.sh list <pr-number> --unresolved
+bash .claude/scripts/review-resolve.sh list <pr-number> --unresolved
 ```
 
 ### Reply to Thread
 ```bash
-bash .claude/scripts/greptile-resolve.sh reply <pr-number> <comment-id> "<message>"
+bash .claude/scripts/review-resolve.sh reply <pr-number> <comment-id> "<message>"
 ```
 
 ### Resolve Thread
 ```bash
-bash .claude/scripts/greptile-resolve.sh resolve <pr-number> <thread-id>
+bash .claude/scripts/review-resolve.sh resolve <pr-number> <thread-id>
 ```
 
 ### Reply and Resolve (Recommended)
 ```bash
-bash .claude/scripts/greptile-resolve.sh reply-and-resolve <pr-number> <comment-id> <thread-id> "<message>"
+bash .claude/scripts/review-resolve.sh reply-and-resolve <pr-number> <comment-id> <thread-id> "<message>"
 ```
 
 ### Batch Resolve (After all issues fixed)
 ```bash
-bash .claude/scripts/greptile-resolve.sh resolve-all <pr-number>
+bash .claude/scripts/review-resolve.sh resolve-all <pr-number>
 ```
 **⚠️ Warning**: Only use after ALL issues are fixed and replied to
 
 ### Statistics
 ```bash
-bash .claude/scripts/greptile-resolve.sh stats <pr-number>
+bash .claude/scripts/review-resolve.sh stats <pr-number>
 ```
 
 ---
 
 ## Integration with `/review` Command
 
-The `/review` command should now include these steps:
+The `/review` command includes these steps:
 
 1. Run `/review` as usual to analyze PR feedback
-2. For Greptile comments, use the script to:
+2. For review-agent comments (CodeRabbit, Qodo, Greptile, human), use the script to:
    - List unresolved threads
    - Fix each issue
    - Reply and resolve systematically
 3. Verify all threads resolved before declaring review complete
-4. Push changes and poll briefly for Greptile re-review
+4. Push changes and poll briefly for re-review
 
 ---
 
@@ -269,17 +284,17 @@ The `/review` command should now include these steps:
 **Cause**: GitHub UI caching
 **Solution**: Refresh page, or check with GraphQL query
 
-### Greptile score not updating after fixes
+### Review score not updating after fixes
 **Cause**: Must push commits to trigger re-analysis
-**Solution**: `git push`, check once immediately, and poll for up to 60 seconds. If Greptile is still pending after that, stop and wait for the user to resume later.
+**Solution**: `git push`, check once immediately, and poll for up to 60 seconds. If the review agent is still pending after that, stop and wait for the user to resume later.
 
 ---
 
 ## Success Criteria
 
 **A review is complete when:**
-- ✅ All Greptile threads are resolved (verified with `stats` command)
+- ✅ All review threads are resolved (verified with the `stats` command)
 - ✅ All threads have replies explaining fixes
-- ✅ Greptile Quality Gate passes (≥4/5 score)
+- ✅ Any review-agent quality gate passes
 - ✅ Branch protection allows merge
 - ✅ No manual tracking needed by maintainers

package/.claude/scripts/{greptile-resolve.sh → review-resolve.sh}

@@ -1,10 +1,20 @@
 #!/bin/bash
-# Greptile Review Thread Resolution Tool
-# Uses GitHub GraphQL API to systematically resolve review threads
-# Uses GitHub REST API to reply to review comments
+# Review Thread Resolution Tool
+# Resolves GitHub PR review threads from ANY review author — CodeRabbit, Qodo,
+# Greptile, or a human reviewer — the mechanism is author-agnostic.
+# Uses GitHub GraphQL API to systematically resolve review threads.
+# Uses GitHub REST API to reply to review comments.
+# Note: the `list-all`, `resolve-all`, and `stats` convenience commands additionally
+# recognize `greptile-apps`-authored threads (Greptile is one supported review tool);
+# the core list/reply/resolve/reply-and-resolve commands work for every author.
 
 set -e
 
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+if [ -f "$SCRIPT_DIR/../../scripts/bootstrap-windows-tools.sh" ]; then
+    source "$SCRIPT_DIR/../../scripts/bootstrap-windows-tools.sh"
+fi
+
 # Colors for output (defined before use)
 RED='\033[0;31m'
 GREEN='\033[0;32m'

package/.cursor/rules/permissions-guidance.mdc

@@ -13,7 +13,7 @@ Bash(git status *), Bash(git log *), Bash(git diff *), Bash(git branch *)
 Bash(git add *), Bash(git commit *), Bash(git push *), Bash(git stash *)
 Bash(git checkout *), Bash(git switch *), Bash(git merge *), Bash(git worktree *)
 Bash(bun *), Bash(bunx *), Bash(npm *), Bash(npx *), Bash(node *)
-Bash(bd *), Bash(gh *), Bash(openspec *)
+Bash(forge *), Bash(gh *), Bash(openspec *)
 Bash(ls *), Bash(cat *), Bash(grep *), Bash(find *), Bash(pwd *), Bash(which *)
 Bash(echo *), Bash(head *), Bash(tail *), Bash(sort *), Bash(wc *)
 Bash(mkdir *), Bash(touch *), Bash(cp *), Bash(mv *)
@@ -21,7 +21,7 @@ Bash(mkdir *), Bash(touch *), Bash(cp *), Bash(mv *)
 
 ## Confirm Before Running (prompt each time)
 
-<!-- git reset --hard moved from Deny to Confirm to match opencode.json "ask" policy.
+<!-- git reset --hard moved from Deny to Confirm ("ask" policy).
      Rationale: agents may need it for worktree cleanup during /verify stage,
      but it should always require user confirmation since it discards uncommitted changes. -->
 ```

package/.forge/hooks/check-tdd.js

@@ -14,6 +14,70 @@ const fs = require("node:fs");
 const path = require("node:path");
 const readline = require("node:readline");
 
+// ── Config-honest enforcement (issue eda6d866) ──────────────────────────────
+// This pre-commit gate must be INERT when the TDD rail is disabled in
+// .forge/config.yaml. The hook is self-contained (target projects have
+// .forge/hooks/*.js but NOT lib/), so it reads the config directly. `forge gate
+// disable rail.tdd_intent` writes workflow.gates['rail.tdd_intent']; the `full`
+// profile writes top-level rails.tdd_intent — honor either. Missing/unparseable
+// config FAILS TOWARD enforcement (returns true) so a gate the user did not
+// disable is never silently dropped.
+function isTddEnabled(projectRoot) {
+  let raw;
+  try {
+    raw = fs.readFileSync(path.join(projectRoot, ".forge", "config.yaml"), "utf8");
+  } catch {
+    return true; // no config → enforce
+  }
+  if (!raw || !raw.trim()) return true;
+
+  const railDisabled = (config) =>
+    isExplicitlyDisabled(config?.workflow?.gates?.["rail.tdd_intent"]) ||
+    isExplicitlyDisabled(config?.rails?.tdd_intent);
+
+  let YAML;
+  try {
+    YAML = require("yaml");
+  } catch {
+    // The yaml MODULE is genuinely unavailable → conservative raw-text scan for the
+    // disabled block. Parser presence and parse success are split so a MALFORMED file
+    // never reaches this fuzzy scan.
+    return !(rawKeyDisabled(raw, "rail.tdd_intent") || rawKeyDisabled(raw, "tdd_intent"));
+  }
+  try {
+    const parsed = YAML.parse(raw);
+    if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return true;
+    return !railDisabled(parsed);
+  } catch {
+    // MALFORMED YAML (module present, parse threw) → FAIL TOWARD ENFORCEMENT (return
+    // true). Never fall to the raw-text scan: a broken file with a `rail.tdd_intent:
+    // enabled: false` fragment must not switch the gate off (issue eda6d866).
+    return true;
+  }
+}
+
+function isExplicitlyDisabled(node) {
+  return Boolean(node) && typeof node === "object" && node.enabled === false;
+}
+
+// Scan raw YAML for a `<key>:` block whose immediate child is `enabled: false`.
+function rawKeyDisabled(raw, key) {
+  const lines = String(raw).split(/\r?\n/);
+  const keyRe = new RegExp(`^(\\s*)"?${key.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}"?\\s*:\\s*$`);
+  for (let i = 0; i < lines.length; i += 1) {
+    const m = lines[i].match(keyRe);
+    if (!m) continue;
+    const parentIndent = m[1].length;
+    for (let j = i + 1; j < lines.length; j += 1) {
+      if (!lines[j].trim()) continue;
+      const childIndent = lines[j].match(/^\s*/)[0].length;
+      if (childIndent <= parentIndent) break;
+      if (/^\s*enabled\s*:\s*false\s*$/.test(lines[j])) return true;
+    }
+  }
+  return false;
+}
+
 // Get staged files using git diff --cached
 function getStagedFiles() {
   try {
@@ -111,6 +175,9 @@ function hasTestFile(sourceFile, stagedFiles) {
     sourceFile.replace(/^bin\//, 'test/cli/').replace(ext, `.spec${ext}`),
     sourceFile.replace(/^bin\//, 'test/bin/').replace(ext, `.test${ext}`),
     sourceFile.replace(/^bin\//, 'test/bin/').replace(ext, `.spec${ext}`),
+    // Workspace packages (packages/<pkg>/src/**/foo.js → packages/<pkg>/test/foo.test.js)
+    sourceFile.replace(/^(packages\/[^/]+)\/src\/(?:.*\/)?([^/]+)$/, `$1/test/$2`).replace(ext, `.test${ext}`),
+    sourceFile.replace(/^(packages\/[^/]+)\/src\/(?:.*\/)?([^/]+)$/, `$1/test/$2`).replace(ext, `.spec${ext}`),
   ];
 
   // Check if test file exists in staged files or filesystem
@@ -160,6 +227,12 @@ function promptUser(question, options) {
 
 // Main hook logic
 async function main() {
+  // Project root is two levels up from this installed hook (<root>/.forge/hooks/).
+  // When the TDD rail is disabled in config, the gate is inert — allow the commit.
+  if (!isTddEnabled(path.resolve(__dirname, "..", ".."))) {
+    process.exit(0);
+  }
+
   console.log("🔍 TDD Check: Verifying test coverage for staged files...\n");
 
   const stagedFiles = getStagedFiles();
@@ -233,8 +306,12 @@ async function main() {
   }
 }
 
-// Run with error handling
-main().catch((error) => {
-  console.error("Error in TDD check hook:", error.message);
-  process.exit(1);
-});
+module.exports = { isTddEnabled };
+
+// Run with error handling (only as a script, not when required by tests).
+if (require.main === module) {
+  main().catch((error) => {
+    console.error("Error in TDD check hook:", error.message);
+    process.exit(1);
+  });
+}