eslint 5.6.0 → 5.9.0

package/lib/rules/no-irregular-whitespace.js

@@ -27,6 +27,8 @@ const LINE_BREAK = astUtils.createGlobalLinebreakMatcher();
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow irregular whitespace outside of strings and comments",
             category: "Possible Errors",
@@ -81,9 +83,7 @@ module.exports = {
             const locStart = node.loc.start;
             const locEnd = node.loc.end;
 
-            errors = errors.filter(error => {
-                const errorLoc = error[1];
-
+            errors = errors.filter(({ loc: errorLoc }) => {
                 if (errorLoc.line >= locStart.line && errorLoc.line <= locEnd.line) {
                     if (errorLoc.column >= locStart.column && (errorLoc.column <= locEnd.column || errorLoc.line < locEnd.line)) {
                         return false;
@@ -157,7 +157,7 @@ module.exports = {
                         column: match.index
                     };
 
-                    errors.push([node, location, "Irregular whitespace not allowed."]);
+                    errors.push({ node, message: "Irregular whitespace not allowed.", loc: location });
                 }
             });
         }
@@ -182,7 +182,7 @@ module.exports = {
                     column: sourceLines[lineIndex].length
                 };
 
-                errors.push([node, location, "Irregular whitespace not allowed."]);
+                errors.push({ node, message: "Irregular whitespace not allowed.", loc: location });
                 lastLineIndex = lineIndex;
             }
         }
@@ -224,9 +224,7 @@ module.exports = {
                 }
 
                 // If we have any errors remaining report on them
-                errors.forEach(error => {
-                    context.report(...error);
-                });
+                errors.forEach(error => context.report(error));
             };
         } else {
             nodes.Program = noop;

package/lib/rules/no-iterator.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of the `__iterator__` property",
             category: "Best Practices",

package/lib/rules/no-label-var.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow labels that share a name with a variable",
             category: "Variables",

package/lib/rules/no-labels.js

@@ -16,6 +16,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow labeled statements",
             category: "Best Practices",

package/lib/rules/no-lone-blocks.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary nested blocks",
             category: "Best Practices",

package/lib/rules/no-lonely-if.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `if` statements as the only statement in `else` blocks",
             category: "Stylistic Issues",
@@ -18,7 +20,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-loop-func.js

@@ -154,6 +154,8 @@ function isSafe(loopNode, reference) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `function` declarations and expressions inside loop statements",
             category: "Best Practices",

package/lib/rules/no-magic-numbers.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow magic numbers",
             category: "Best Practices",
@@ -40,6 +42,7 @@ module.exports = {
             },
             additionalProperties: false
         }],
+
         messages: {
             useConst: "Number constants declarations must use 'const'.",
             noMagic: "No magic number: {{raw}}."

package/lib/rules/no-misleading-character-class.js

@@ -101,13 +101,17 @@ const kinds = Object.keys(hasCharacterSequence);
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow characters which are made with multiple code points in character class syntax",
             category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-misleading-character-class"
         },
+
         schema: [],
+
         messages: {
             surrogatePairWithoutUFlag: "Unexpected surrogate pair in character class. Use 'u' flag.",
             combiningClass: "Unexpected combined character in character class.",

package/lib/rules/no-mixed-operators.js

@@ -71,12 +71,15 @@ function includesBothInAGroup(groups, left, right) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow mixed binary operators",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-mixed-operators"
         },
+
         schema: [
             {
                 type: "object",

package/lib/rules/no-mixed-requires.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `require` calls to be mixed with regular variable declarations",
             category: "Node.js and CommonJS",

package/lib/rules/no-mixed-spaces-and-tabs.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow mixed spaces and tabs for indentation",
             category: "Stylistic Issues",

package/lib/rules/no-multi-assign.js

@@ -12,12 +12,15 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow use of chained assignment expressions",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-multi-assign"
         },
+
         schema: []
     },
 

package/lib/rules/no-multi-spaces.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow multiple spaces",
             category: "Best Practices",

package/lib/rules/no-multi-str.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow multiline strings",
             category: "Best Practices",

package/lib/rules/no-multiple-empty-lines.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow multiple empty lines",
             category: "Stylistic Issues",

package/lib/rules/no-native-reassign.js

@@ -12,16 +12,19 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow assignments to native objects or read-only global variables",
             category: "Best Practices",
             recommended: false,
-            replacedBy: ["no-global-assign"],
             url: "https://eslint.org/docs/rules/no-native-reassign"
         },
 
         deprecated: true,
 
+        replacedBy: ["no-global-assign"],
+
         schema: [
             {
                 type: "object",

package/lib/rules/no-negated-condition.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow negated conditions",
             category: "Stylistic Issues",

package/lib/rules/no-negated-in-lhs.js

@@ -12,15 +12,18 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow negating the left operand in `in` expressions",
             category: "Possible Errors",
             recommended: false,
-            replacedBy: ["no-unsafe-negation"],
             url: "https://eslint.org/docs/rules/no-negated-in-lhs"
         },
-        deprecated: true,
 
+        replacedBy: ["no-unsafe-negation"],
+
+        deprecated: true,
         schema: []
     },
 

package/lib/rules/no-nested-ternary.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow nested ternary expressions",
             category: "Stylistic Issues",

package/lib/rules/no-new-func.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `new` operators with the `Function` object",
             category: "Best Practices",

package/lib/rules/no-new-object.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `Object` constructors",
             category: "Stylistic Issues",

package/lib/rules/no-new-require.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `new` operators with calls to `require`",
             category: "Node.js and CommonJS",

package/lib/rules/no-new-symbol.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow `new` operators with the `Symbol` object",
             category: "ECMAScript 6",

package/lib/rules/no-new-wrappers.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `new` operators with the `String`, `Number`, and `Boolean` objects",
             category: "Best Practices",

package/lib/rules/no-new.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `new` operators outside of assignments or comparisons",
             category: "Best Practices",

package/lib/rules/no-obj-calls.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow calling global object properties as functions",
             category: "Possible Errors",

package/lib/rules/no-octal-escape.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow octal escape sequences in string literals",
             category: "Best Practices",

package/lib/rules/no-octal.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow octal literals",
             category: "Best Practices",

package/lib/rules/no-param-reassign.js

@@ -12,6 +12,8 @@ const stopNodePattern = /(?:Statement|Declaration|Function(?:Expression)?|Progra
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow reassigning `function` parameters",
             category: "Best Practices",

package/lib/rules/no-path-concat.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow string concatenation with `__dirname` and `__filename`",
             category: "Node.js and CommonJS",

package/lib/rules/no-plusplus.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the unary operators `++` and `--`",
             category: "Stylistic Issues",

package/lib/rules/no-process-env.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `process.env`",
             category: "Node.js and CommonJS",

package/lib/rules/no-process-exit.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `process.exit()`",
             category: "Node.js and CommonJS",

package/lib/rules/no-proto.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of the `__proto__` property",
             category: "Best Practices",

package/lib/rules/no-prototype-builtins.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow calling some `Object.prototype` methods directly on objects",
             category: "Possible Errors",

package/lib/rules/no-redeclare.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow variable redeclaration",
             category: "Best Practices",

package/lib/rules/no-regex-spaces.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow multiple spaces in regular expressions",
             category: "Possible Errors",
@@ -21,7 +23,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-restricted-globals.js

@@ -17,6 +17,8 @@ const DEFAULT_MESSAGE_TEMPLATE = "Unexpected use of '{{name}}'.",
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified global variables",
             category: "Variables",

package/lib/rules/no-restricted-imports.js

@@ -53,6 +53,8 @@ const arrayOfStringsOrObjects = {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified modules when loaded by `import`",
             category: "ECMAScript 6",
@@ -234,31 +236,47 @@ module.exports = {
             return restrictedPatterns.length > 0 && restrictedPatternsMatcher.ignores(importSource);
         }
 
-        return {
-            ImportDeclaration(node) {
-                const importSource = node.source.value.trim();
-                const importNames = node.specifiers.reduce((set, specifier) => {
-                    if (specifier.type === "ImportDefaultSpecifier") {
-                        set.add("default");
-                    } else if (specifier.type === "ImportNamespaceSpecifier") {
-                        set.add("*");
-                    } else {
-                        set.add(specifier.imported.name);
-                    }
-                    return set;
-                }, new Set());
-
-                if (isRestrictedForEverythingImported(importSource, importNames)) {
-                    reportPathForEverythingImported(importSource, node);
+        /**
+         * Checks a node to see if any problems should be reported.
+         * @param {ASTNode} node The node to check.
+         * @returns {void}
+         * @private
+         */
+        function checkNode(node) {
+            const importSource = node.source.value.trim();
+            const importNames = node.specifiers ? node.specifiers.reduce((set, specifier) => {
+                if (specifier.type === "ImportDefaultSpecifier") {
+                    set.add("default");
+                } else if (specifier.type === "ImportNamespaceSpecifier") {
+                    set.add("*");
+                } else if (specifier.imported) {
+                    set.add(specifier.imported.name);
+                } else if (specifier.local) {
+                    set.add(specifier.local.name);
                 }
+                return set;
+            }, new Set()) : new Set();
 
-                if (isRestrictedPath(importSource, importNames)) {
-                    reportPath(node);
-                }
-                if (isRestrictedPattern(importSource)) {
-                    reportPathForPatterns(node);
-                }
+            if (isRestrictedForEverythingImported(importSource, importNames)) {
+                reportPathForEverythingImported(importSource, node);
+            }
+
+            if (isRestrictedPath(importSource, importNames)) {
+                reportPath(node);
+            }
+            if (isRestrictedPattern(importSource)) {
+                reportPathForPatterns(node);
             }
+        }
+
+        return {
+            ImportDeclaration: checkNode,
+            ExportNamedDeclaration(node) {
+                if (node.source) {
+                    checkNode(node);
+                }
+            },
+            ExportAllDeclaration: checkNode
         };
     }
 };

package/lib/rules/no-restricted-modules.js

@@ -47,6 +47,8 @@ const arrayOfStringsOrObjects = {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified modules when loaded by `require`",
             category: "Node.js and CommonJS",

package/lib/rules/no-restricted-properties.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow certain properties on certain objects",
             category: "Best Practices",

package/lib/rules/no-restricted-syntax.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified syntax",
             category: "Stylistic Issues",

package/lib/rules/no-return-assign.js

@@ -22,6 +22,8 @@ const SENTINEL_TYPE = /^(?:[a-zA-Z]+?Statement|ArrowFunctionExpression|FunctionE
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow assignment operators in `return` statements",
             category: "Best Practices",

package/lib/rules/no-return-await.js

@@ -14,6 +14,8 @@ const message = "Redundant use of `await` on a return value.";
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary `return await`",
             category: "Best Practices",
@@ -22,7 +24,9 @@ module.exports = {
 
             url: "https://eslint.org/docs/rules/no-return-await"
         },
+
         fixable: null,
+
         schema: [
         ]
     },

package/lib/rules/no-script-url.js

@@ -13,6 +13,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `javascript:` urls",
             category: "Best Practices",