eslint 5.6.0 → 5.9.0

package/lib/rules/no-bitwise.js

@@ -22,6 +22,8 @@ const BITWISE_OPERATORS = [
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow bitwise operators",
             category: "Stylistic Issues",

package/lib/rules/no-buffer-constructor.js

@@ -10,13 +10,17 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow use of the `Buffer()` constructor",
             category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-buffer-constructor"
         },
+
         schema: [],
+
         messages: {
             deprecated: "{{expr}} is deprecated. Use Buffer.from(), Buffer.alloc(), or Buffer.allocUnsafe() instead."
         }

package/lib/rules/no-caller.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `arguments.caller` or `arguments.callee`",
             category: "Best Practices",

package/lib/rules/no-case-declarations.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow lexical declarations in case clauses",
             category: "Best Practices",

package/lib/rules/no-catch-shadow.js

@@ -18,15 +18,18 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `catch` clause parameters from shadowing variables in the outer scope",
             category: "Variables",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-catch-shadow",
-            replacedBy: ["no-shadow"]
+            url: "https://eslint.org/docs/rules/no-catch-shadow"
         },
-        deprecated: true,
 
+        replacedBy: ["no-shadow"],
+
+        deprecated: true,
         schema: [],
 
         messages: {

package/lib/rules/no-class-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning class members",
             category: "ECMAScript 6",

package/lib/rules/no-compare-neg-zero.js

@@ -10,14 +10,18 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow comparing against -0",
             category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-compare-neg-zero"
         },
+
         fixable: null,
         schema: [],
+
         messages: {
             unexpected: "Do not use the '{{operator}}' operator to compare against -0."
         }

package/lib/rules/no-cond-assign.js

@@ -19,6 +19,8 @@ const NODE_DESCRIPTIONS = {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow assignment operators in conditional expressions",
             category: "Possible Errors",

package/lib/rules/no-confusing-arrow.js

@@ -27,6 +27,8 @@ function isConditional(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow arrow functions where they could be confused with comparisons",
             category: "ECMAScript 6",

package/lib/rules/no-console.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `console`",
             category: "Possible Errors",

package/lib/rules/no-const-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning `const` variables",
             category: "ECMAScript 6",

package/lib/rules/no-constant-condition.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow constant expressions in conditions",
             category: "Possible Errors",

package/lib/rules/no-continue.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `continue` statements",
             category: "Stylistic Issues",

package/lib/rules/no-control-regex.js

@@ -6,7 +6,7 @@
 "use strict";
 
 const RegExpValidator = require("regexpp").RegExpValidator;
-const collector = new class {
+const collector = new (class {
     constructor() {
         this.ecmaVersion = 2018;
         this._source = "";
@@ -41,7 +41,7 @@ const collector = new class {
         }
         return this._controlChars;
     }
-}();
+})();
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -49,6 +49,8 @@ const collector = new class {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow control characters in regular expressions",
             category: "Possible Errors",

package/lib/rules/no-debugger.js

@@ -11,14 +11,18 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow the use of `debugger`",
             category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-debugger"
         },
+
         fixable: null,
         schema: [],
+
         messages: {
             unexpected: "Unexpected 'debugger' statement."
         }

package/lib/rules/no-delete-var.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow deleting variables",
             category: "Variables",

package/lib/rules/no-div-regex.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow division operators explicitly at the beginning of regular expressions",
             category: "Best Practices",

package/lib/rules/no-dupe-args.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate arguments in `function` definitions",
             category: "Possible Errors",

package/lib/rules/no-dupe-class-members.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate class members",
             category: "ECMAScript 6",

package/lib/rules/no-dupe-keys.js

@@ -84,6 +84,8 @@ class ObjectInfo {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate keys in object literals",
             category: "Possible Errors",

package/lib/rules/no-duplicate-case.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate case labels",
             category: "Possible Errors",

package/lib/rules/no-duplicate-imports.js

@@ -101,6 +101,8 @@ function handleExports(context, importsInFile, exportsInFile) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow duplicate module imports",
             category: "ECMAScript 6",

package/lib/rules/no-else-return.js

@@ -18,6 +18,8 @@ const FixTracker = require("../util/fix-tracker");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `else` blocks after `return` statements in `if` statements",
             category: "Best Practices",

package/lib/rules/no-empty-character-class.js

@@ -29,6 +29,8 @@ const regex = /^\/([^\\[]|\\.|\[([^\\\]]|\\.)+])*\/[gimuys]*$/;
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow empty character classes in regular expressions",
             category: "Possible Errors",

package/lib/rules/no-empty-function.js

@@ -90,6 +90,8 @@ function getKind(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow empty functions",
             category: "Best Practices",

package/lib/rules/no-empty-pattern.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow empty destructuring patterns",
             category: "Best Practices",

package/lib/rules/no-empty.js

@@ -16,6 +16,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow empty block statements",
             category: "Possible Errors",

package/lib/rules/no-eq-null.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `null` comparisons without type-checking operators",
             category: "Best Practices",

package/lib/rules/no-eval.js

@@ -76,6 +76,8 @@ function isMember(node, name) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `eval()`",
             category: "Best Practices",

package/lib/rules/no-ex-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning exceptions in `catch` clauses",
             category: "Possible Errors",

package/lib/rules/no-extend-native.js

@@ -24,6 +24,8 @@ const propertyDefinitionMethods = new Set(["defineProperty", "defineProperties"]
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow extending native types",
             category: "Best Practices",

package/lib/rules/no-extra-bind.js

@@ -10,12 +10,20 @@
 
 const astUtils = require("../util/ast-utils");
 
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+const SIDE_EFFECT_FREE_NODE_TYPES = new Set(["Literal", "Identifier", "ThisExpression", "FunctionExpression"]);
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary calls to `.bind()`",
             category: "Best Practices",
@@ -24,7 +32,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {
@@ -35,6 +42,18 @@ module.exports = {
     create(context) {
         let scopeInfo = null;
 
+        /**
+         * Checks if a node is free of side effects.
+         *
+         * This check is stricter than it needs to be, in order to keep the implementation simple.
+         *
+         * @param {ASTNode} node A node to check.
+         * @returns {boolean} True if the node is known to be side-effect free, false otherwise.
+         */
+        function isSideEffectFree(node) {
+            return SIDE_EFFECT_FREE_NODE_TYPES.has(node.type);
+        }
+
         /**
          * Reports a given function node.
          *
@@ -48,6 +67,10 @@ module.exports = {
                 messageId: "unexpected",
                 loc: node.parent.property.loc.start,
                 fix(fixer) {
+                    if (node.parent.parent.arguments.length && !isSideEffectFree(node.parent.parent.arguments[0])) {
+                        return null;
+                    }
+
                     const firstTokenToRemove = context.getSourceCode()
                         .getFirstTokenBetween(node.parent.object, node.parent.property, astUtils.isNotClosingParenToken);
 

package/lib/rules/no-extra-boolean-cast.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary boolean casts",
             category: "Possible Errors",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {

package/lib/rules/no-extra-label.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary labels",
             category: "Best Practices",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {

package/lib/rules/no-extra-parens.js

@@ -12,6 +12,8 @@ const astUtils = require("../util/ast-utils.js");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow unnecessary parentheses",
             category: "Possible Errors",
@@ -382,8 +384,7 @@ module.exports = {
                          * Allow extra parens around a new expression if
                          * there are intervening parentheses.
                          */
-                        callee.type === "MemberExpression" &&
-                        doesMemberExpressionContainCallExpression(callee)
+                        (callee.type === "MemberExpression" && doesMemberExpressionContainCallExpression(callee))
                     )
                 ) {
                     report(node.callee);
@@ -574,15 +575,13 @@ module.exports = {
                              * If `let` is the only thing on the left side of the loop, it's the loop variable: `for ((let) of foo);`
                              * Removing it will cause a syntax error, because it will be parsed as the start of a VariableDeclarator.
                              */
-                            firstLeftToken.range[1] === node.left.range[1] ||
-
-                            /*
+                            (firstLeftToken.range[1] === node.left.range[1] || /*
                              * If `let` is followed by a `[` token, it's a property access on the `let` value: `for ((let[foo]) of bar);`
                              * Removing it will cause the property access to be parsed as a destructuring declaration of `foo` instead.
                              */
                             astUtils.isOpeningBracketToken(
                                 sourceCode.getTokenAfter(firstLeftToken, astUtils.isNotClosingParenToken)
-                            )
+                            ))
                         )
                     ) {
                         tokensToIgnore.add(firstLeftToken);

package/lib/rules/no-extra-semi.js

@@ -18,6 +18,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary semicolons",
             category: "Possible Errors",

package/lib/rules/no-fallthrough.js

@@ -55,6 +55,8 @@ function hasBlankLinesBetween(node, token) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow fallthrough of `case` statements",
             category: "Best Practices",

package/lib/rules/no-floating-decimal.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow leading or trailing decimal points in numeric literals",
             category: "Best Practices",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-func-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning `function` declarations",
             category: "Possible Errors",

package/lib/rules/no-global-assign.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow assignments to native objects or read-only global variables",
             category: "Best Practices",

package/lib/rules/no-implicit-coercion.js

@@ -152,6 +152,8 @@ function getNonEmptyOperand(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow shorthand type conversions",
             category: "Best Practices",
@@ -160,6 +162,7 @@ module.exports = {
         },
 
         fixable: "code",
+
         schema: [{
             type: "object",
             properties: {

package/lib/rules/no-implicit-globals.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow variable and `function` declarations in the global scope",
             category: "Best Practices",

package/lib/rules/no-implied-eval.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `eval()`-like methods",
             category: "Best Practices",

package/lib/rules/no-inline-comments.js

@@ -12,6 +12,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow inline comments after code",
             category: "Stylistic Issues",

package/lib/rules/no-inner-declarations.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow variable or `function` declarations in nested blocks",
             category: "Possible Errors",

package/lib/rules/no-invalid-regexp.js

@@ -19,6 +19,8 @@ const undefined1 = void 0;
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow invalid regular expression strings in `RegExp` constructors",
             category: "Possible Errors",

package/lib/rules/no-invalid-this.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `this` keywords outside of classes or class-like objects",
             category: "Best Practices",