eslint 5.6.0 → 5.9.0

package/lib/rules/camelcase.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce camelcase naming convention",
             category: "Stylistic Issues",
@@ -27,6 +29,16 @@ module.exports = {
                     },
                     properties: {
                         enum: ["always", "never"]
+                    },
+                    allow: {
+                        type: "array",
+                        items: [
+                            {
+                                type: "string"
+                            }
+                        ],
+                        minItems: 0,
+                        uniqueItems: true
                     }
                 },
                 additionalProperties: false
@@ -40,6 +52,15 @@ module.exports = {
 
     create(context) {
 
+        const options = context.options[0] || {};
+        let properties = options.properties || "";
+        const ignoreDestructuring = options.ignoreDestructuring || false;
+        const allow = options.allow || [];
+
+        if (properties !== "always" && properties !== "never") {
+            properties = "always";
+        }
+
         //--------------------------------------------------------------------------
         // Helpers
         //--------------------------------------------------------------------------
@@ -60,6 +81,18 @@ module.exports = {
             return name.indexOf("_") > -1 && name !== name.toUpperCase();
         }
 
+        /**
+         * Checks if a string match the ignore list
+         * @param {string} name The string to check.
+         * @returns {boolean} if the string is ignored
+         * @private
+         */
+        function isAllowed(name) {
+            return allow.findIndex(
+                entry => name === entry || name.match(new RegExp(entry))
+            ) !== -1;
+        }
+
         /**
          * Checks if a parent of a node is an ObjectPattern.
          * @param {ASTNode} node The node to check.
@@ -93,14 +126,6 @@ module.exports = {
             }
         }
 
-        const options = context.options[0] || {};
-        let properties = options.properties || "";
-        const ignoreDestructuring = options.ignoreDestructuring || false;
-
-        if (properties !== "always" && properties !== "never") {
-            properties = "always";
-        }
-
         return {
 
             Identifier(node) {
@@ -112,6 +137,11 @@ module.exports = {
                 const name = node.name.replace(/^_+|_+$/g, ""),
                     effectiveParent = (node.parent.type === "MemberExpression") ? node.parent.parent : node.parent;
 
+                // First, we ignore the node if it match the ignore list
+                if (isAllowed(name)) {
+                    return;
+                }
+
                 // MemberExpressions get special rules
                 if (node.parent.type === "MemberExpression") {
 

package/lib/rules/capitalized-comments.js

@@ -108,13 +108,17 @@ function createRegExpForIgnorePatterns(normalizedOptions) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce or disallow capitalization of the first letter of a comment",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/capitalized-comments"
         },
+
         fixable: "code",
+
         schema: [
             { enum: ["always", "never"] },
             {

package/lib/rules/class-methods-use-this.js

@@ -11,12 +11,15 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce that class methods utilize `this`",
             category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/class-methods-use-this"
         },
+
         schema: [{
             type: "object",
             properties: {

package/lib/rules/comma-dangle.js

@@ -76,13 +76,17 @@ function normalizeOptions(optionValue) {
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "require or disallow trailing commas",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/comma-dangle"
         },
+
         fixable: "code",
+
         schema: {
             definitions: {
                 value: {

package/lib/rules/comma-spacing.js

@@ -12,6 +12,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "enforce consistent spacing before and after commas",
             category: "Stylistic Issues",

package/lib/rules/comma-style.js

@@ -13,13 +13,17 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "enforce consistent comma style",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/comma-style"
         },
+
         fixable: "code",
+
         schema: [
             {
                 enum: ["first", "last"]
@@ -37,6 +41,7 @@ module.exports = {
                 additionalProperties: false
             }
         ],
+
         messages: {
             unexpectedLineBeforeAndAfterComma: "Bad line breaking before and after ','.",
             expectedCommaFirst: "',' should be placed first.",

package/lib/rules/complexity.js

@@ -20,6 +20,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce a maximum cyclomatic complexity allowed in a program",
             category: "Best Practices",

package/lib/rules/computed-property-spacing.js

@@ -12,6 +12,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "enforce consistent spacing inside computed property brackets",
             category: "Stylistic Issues",

package/lib/rules/consistent-return.js

@@ -53,6 +53,8 @@ function isClassConstructor(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "require `return` statements to either always or never specify values",
             category: "Best Practices",

package/lib/rules/consistent-this.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce consistent naming when capturing the current execution context",
             category: "Stylistic Issues",

package/lib/rules/constructor-super.js

@@ -92,6 +92,8 @@ function isPossibleConstructor(node) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "require `super()` calls in constructors",
             category: "ECMAScript 6",

package/lib/rules/curly.js

@@ -16,6 +16,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce consistent brace style for all control statements",
             category: "Best Practices",

package/lib/rules/default-case.js

@@ -12,6 +12,8 @@ const DEFAULT_COMMENT_PATTERN = /^no default$/i;
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "require `default` cases in `switch` statements",
             category: "Best Practices",

package/lib/rules/dot-location.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "enforce consistent newlines before and after dots",
             category: "Best Practices",

package/lib/rules/dot-notation.js

@@ -19,6 +19,8 @@ const keywords = require("../util/keywords");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce dot notation whenever possible",
             category: "Best Practices",

package/lib/rules/eol-last.js

@@ -16,18 +16,23 @@ const lodash = require("lodash");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "require or disallow newline at the end of files",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/eol-last"
         },
+
         fixable: "whitespace",
+
         schema: [
             {
                 enum: ["always", "never", "unix", "windows"]
             }
         ],
+
         messages: {
             missing: "Newline required at end of file but not found.",
             unexpected: "Newline not allowed at end of file."

package/lib/rules/eqeqeq.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "require the use of `===` and `!==`",
             category: "Best Practices",

package/lib/rules/for-direction.js

@@ -11,14 +11,18 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "enforce \"for\" loop update clause moving the counter in the right direction.",
             category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/for-direction"
         },
+
         fixable: null,
         schema: [],
+
         messages: {
             incorrectDirection: "The update clause in this loop moves the variable in the wrong direction."
         }

package/lib/rules/func-call-spacing.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "require or disallow spacing between function identifiers and their invocations",
             category: "Stylistic Issues",
@@ -25,6 +27,7 @@ module.exports = {
         },
 
         fixable: "whitespace",
+
         schema: {
             anyOf: [
                 {
@@ -58,6 +61,7 @@ module.exports = {
                 }
             ]
         },
+
         messages: {
             unexpected: "Unexpected newline between function name and paren.",
             missing: "Missing space between function name and paren."

package/lib/rules/func-name-matching.js

@@ -70,6 +70,8 @@ const optionsObject = {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "require function names to match the name of the variable or property to which they are assigned",
             category: "Stylistic Issues",
@@ -88,6 +90,7 @@ module.exports = {
                 items: [optionsObject]
             }]
         },
+
         messages: {
             matchProperty: "Function name `{{funcName}}` should match property name `{{name}}`",
             matchVariable: "Function name `{{funcName}}` should match variable name `{{name}}`",

package/lib/rules/func-names.js

@@ -26,6 +26,8 @@ function isFunctionName(variable) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "require or disallow named `function` expressions",
             category: "Stylistic Issues",
@@ -58,6 +60,7 @@ module.exports = {
                 }
             ]
         },
+
         messages: {
             unnamed: "Unexpected unnamed {{name}}.",
             named: "Unexpected named {{name}}."

package/lib/rules/func-style.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce the consistent use of either `function` declarations or expressions",
             category: "Stylistic Issues",
@@ -31,6 +33,7 @@ module.exports = {
                 additionalProperties: false
             }
         ],
+
         messages: {
             expression: "Expected a function expression.",
             declaration: "Expected a function declaration."

package/lib/rules/function-paren-newline.js

@@ -16,13 +16,17 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "enforce consistent line breaks inside function parentheses",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/function-paren-newline"
         },
+
         fixable: "whitespace",
+
         schema: [
             {
                 oneOf: [
@@ -42,6 +46,7 @@ module.exports = {
                 ]
             }
         ],
+
         messages: {
             expectedBefore: "Expected newline before ')'.",
             expectedAfter: "Expected newline after '('.",

package/lib/rules/generator-star-spacing.js

@@ -27,6 +27,8 @@ const OVERRIDE_SCHEMA = {
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "enforce consistent spacing around `*` operators in generator functions",
             category: "ECMAScript 6",
@@ -56,6 +58,7 @@ module.exports = {
                 ]
             }
         ],
+
         messages: {
             missingBefore: "Missing space before *.",
             missingAfter: "Missing space after *.",

package/lib/rules/getter-return.js

@@ -44,13 +44,17 @@ function getId(node) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "enforce `return` statements in getters",
             category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/getter-return"
         },
+
         fixable: null,
+
         schema: [
             {
                 type: "object",
@@ -62,6 +66,7 @@ module.exports = {
                 additionalProperties: false
             }
         ],
+
         messages: {
             expected: "Expected to return a value in {{name}}.",
             expectedAlways: "Expected {{name}} to always return a value."

package/lib/rules/global-require.js

@@ -48,6 +48,8 @@ function isShadowed(scope, node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "require `require()` calls to be placed at top-level module scope",
             category: "Node.js and CommonJS",

package/lib/rules/guard-for-in.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "require `for-in` loops to include an `if` statement",
             category: "Best Practices",

package/lib/rules/handle-callback-err.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "require error handling in callbacks",
             category: "Node.js and CommonJS",

package/lib/rules/id-blacklist.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified identifiers",
             category: "Stylistic Issues",

package/lib/rules/id-length.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "enforce minimum and maximum identifier lengths",
             category: "Stylistic Issues",