eslint 4.12.1 → 4.15.0

package/lib/rules/no-useless-return.js

@@ -76,7 +76,8 @@ module.exports = {
         docs: {
             description: "disallow redundant return statements",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-useless-return"
         },
         fixable: "code",
         schema: []

package/lib/rules/no-var.js

@@ -183,7 +183,8 @@ module.exports = {
         docs: {
             description: "require `let` or `const` instead of `var`",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-var"
         },
 
         schema: [],

package/lib/rules/no-void.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow `void` operators",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-void"
         },
 
         schema: []

package/lib/rules/no-warning-comments.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow specified warning terms in comments",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-warning-comments"
         },
 
         schema: [

package/lib/rules/no-whitespace-before-property.js

@@ -19,7 +19,8 @@ module.exports = {
         docs: {
             description: "disallow whitespace before properties",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-whitespace-before-property"
         },
 
         fixable: "whitespace",

package/lib/rules/no-with.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow `with` statements",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-with"
         },
 
         schema: []

package/lib/rules/nonblock-statement-body-position.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "enforce the location of single-line statements",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/nonblock-statement-body-position"
         },
         fixable: "whitespace",
         schema: [

package/lib/rules/object-curly-newline.js

@@ -97,7 +97,8 @@ module.exports = {
         docs: {
             description: "enforce consistent line breaks inside braces",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/object-curly-newline"
         },
         fixable: "whitespace",
         schema: [

package/lib/rules/object-curly-spacing.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "enforce consistent spacing inside braces",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/object-curly-spacing"
         },
 
         fixable: "whitespace",

package/lib/rules/object-property-newline.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "enforce placing object properties on separate lines",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/object-property-newline"
         },
 
         schema: [

package/lib/rules/object-shorthand.js

@@ -27,7 +27,8 @@ module.exports = {
         docs: {
             description: "require or disallow method and property shorthand syntax for object literals",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/object-shorthand"
         },
 
         fixable: "code",

package/lib/rules/one-var-declaration-per-line.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "require or disallow newlines around variable declarations",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/one-var-declaration-per-line"
         },
 
         schema: [

package/lib/rules/one-var.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "enforce variables to be declared either together or separately in functions",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/one-var"
         },
 
         schema: [
@@ -26,6 +27,9 @@ module.exports = {
                     {
                         type: "object",
                         properties: {
+                            separateRequires: {
+                                type: "boolean"
+                            },
                             var: {
                                 enum: ["always", "never"]
                             },
@@ -62,21 +66,23 @@ module.exports = {
 
         const mode = context.options[0] || MODE_ALWAYS;
 
-        const options = {
-        };
+        const options = {};
 
         if (typeof mode === "string") { // simple options configuration with just a string
             options.var = { uninitialized: mode, initialized: mode };
             options.let = { uninitialized: mode, initialized: mode };
             options.const = { uninitialized: mode, initialized: mode };
         } else if (typeof mode === "object") { // options configuration is an object
-            if (mode.hasOwnProperty("var") && typeof mode.var === "string") {
+            if (mode.hasOwnProperty("separateRequires")) {
+                options.separateRequires = !!mode.separateRequires;
+            }
+            if (mode.hasOwnProperty("var")) {
                 options.var = { uninitialized: mode.var, initialized: mode.var };
             }
-            if (mode.hasOwnProperty("let") && typeof mode.let === "string") {
+            if (mode.hasOwnProperty("let")) {
                 options.let = { uninitialized: mode.let, initialized: mode.let };
             }
-            if (mode.hasOwnProperty("const") && typeof mode.const === "string") {
+            if (mode.hasOwnProperty("const")) {
                 options.const = { uninitialized: mode.const, initialized: mode.const };
             }
             if (mode.hasOwnProperty("uninitialized")) {
@@ -158,7 +164,17 @@ module.exports = {
         }
 
         /**
-         * Records whether initialized or uninitialized variables are defined in current scope.
+         * Check if a variable declaration is a require.
+         * @param {ASTNode} decl variable declaration Node
+         * @returns {bool} if decl is a require, return true; else return false.
+         * @private
+         */
+        function isRequire(decl) {
+            return decl.init && decl.init.type === "CallExpression" && decl.init.callee.name === "require";
+        }
+
+        /**
+         * Records whether initialized/uninitialized/required variables are defined in current scope.
          * @param {string} statementType node.kind, one of: "var", "let", or "const"
          * @param {ASTNode[]} declarations List of declarations
          * @param {Object} currentScope The scope being investigated
@@ -173,7 +189,11 @@ module.exports = {
                     }
                 } else {
                     if (options[statementType] && options[statementType].initialized === MODE_ALWAYS) {
-                        currentScope.initialized = true;
+                        if (options.separateRequires && isRequire(declarations[i])) {
+                            currentScope.required = true;
+                        } else {
+                            currentScope.initialized = true;
+                        }
                     }
                 }
             }
@@ -228,6 +248,7 @@ module.exports = {
             const declarationCounts = countDeclarations(declarations);
             const currentOptions = options[statementType] || {};
             const currentScope = getCurrentScope(statementType);
+            const hasRequires = declarations.some(isRequire);
 
             if (currentOptions.uninitialized === MODE_ALWAYS && currentOptions.initialized === MODE_ALWAYS) {
                 if (currentScope.uninitialized || currentScope.initialized) {
@@ -245,6 +266,9 @@ module.exports = {
                     return false;
                 }
             }
+            if (currentScope.required && hasRequires) {
+                return false;
+            }
             recordTypes(statementType, declarations, currentScope);
             return true;
         }
@@ -275,6 +299,16 @@ module.exports = {
 
                 const declarations = node.declarations;
                 const declarationCounts = countDeclarations(declarations);
+                const mixedRequires = declarations.some(isRequire) && !declarations.every(isRequire);
+
+                if (options[type].initialized === MODE_ALWAYS) {
+                    if (options.separateRequires && mixedRequires) {
+                        context.report({
+                            node,
+                            message: "Split requires to be separated into a single block."
+                        });
+                    }
+                }
 
                 // always
                 if (!hasOnlyOneStatement(type, declarations)) {

package/lib/rules/operator-assignment.js

@@ -92,7 +92,8 @@ module.exports = {
         docs: {
             description: "require or disallow assignment operator shorthand where possible",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/operator-assignment"
         },
 
         schema: [

package/lib/rules/operator-linebreak.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "enforce consistent linebreak style for operators",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/operator-linebreak"
         },
 
         schema: [

package/lib/rules/padded-blocks.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "require or disallow padding within blocks",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/padded-blocks"
         },
 
         fixable: "whitespace",

package/lib/rules/padding-line-between-statements.js

@@ -394,7 +394,8 @@ module.exports = {
         docs: {
             description: "require or disallow padding lines between statements",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/padding-line-between-statements"
         },
         fixable: "whitespace",
         schema: {

package/lib/rules/prefer-arrow-callback.js

@@ -134,7 +134,8 @@ module.exports = {
         docs: {
             description: "require using arrow functions for callbacks",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/prefer-arrow-callback"
         },
 
         schema: [

package/lib/rules/prefer-const.js

@@ -233,7 +233,8 @@ module.exports = {
         docs: {
             description: "require `const` declarations for variables that are never reassigned after declared",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/prefer-const"
         },
 
         fixable: "code",

package/lib/rules/prefer-destructuring.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "require destructuring from arrays and/or objects",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/prefer-destructuring"
         },
         schema: [
             {

package/lib/rules/prefer-numeric-literals.js

@@ -41,7 +41,8 @@ module.exports = {
         docs: {
             description: "disallow `parseInt()` and `Number.parseInt()` in favor of binary, octal, and hexadecimal literals",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/prefer-numeric-literals"
         },
 
         schema: [],

package/lib/rules/prefer-promise-reject-errors.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "require using Error objects as Promise rejection reasons",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/prefer-promise-reject-errors"
         },
         fixable: null,
         schema: [

package/lib/rules/prefer-reflect.js

@@ -15,7 +15,8 @@ module.exports = {
             description: "require `Reflect` methods where applicable",
             category: "ECMAScript 6",
             recommended: false,
-            replacedBy: []
+            replacedBy: [],
+            url: "https://eslint.org/docs/rules/prefer-reflect"
         },
 
         deprecated: true,

package/lib/rules/prefer-rest-params.js

@@ -65,7 +65,8 @@ module.exports = {
         docs: {
             description: "require rest parameters instead of `arguments`",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/prefer-rest-params"
         },
 
         schema: []

package/lib/rules/prefer-spread.js

@@ -52,7 +52,8 @@ module.exports = {
         docs: {
             description: "require spread operators instead of `.apply()`",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/prefer-spread"
         },
 
         schema: [],

package/lib/rules/prefer-template.js

@@ -103,7 +103,8 @@ module.exports = {
         docs: {
             description: "require template literals instead of string concatenation",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/prefer-template"
         },
 
         schema: [],

package/lib/rules/quote-props.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "require quotes around object literal property names",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/quote-props"
         },
 
         schema: {

package/lib/rules/quotes.js

@@ -79,7 +79,8 @@ module.exports = {
         docs: {
             description: "enforce the consistent use of either backticks, double, or single quotes",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/quotes"
         },
 
         fixable: "code",

package/lib/rules/radix.js

@@ -81,7 +81,8 @@ module.exports = {
         docs: {
             description: "enforce the consistent use of the radix argument when using `parseInt()`",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/radix"
         },
 
         schema: [

package/lib/rules/require-await.js

@@ -34,7 +34,8 @@ module.exports = {
         docs: {
             description: "disallow async functions which have no `await` expression",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/require-await"
         },
         schema: []
     },

package/lib/rules/require-jsdoc.js

@@ -9,7 +9,8 @@ module.exports = {
         docs: {
             description: "require JSDoc comments",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/require-jsdoc"
         },
 
         schema: [

package/lib/rules/require-yield.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "require generator functions to contain `yield`",
             category: "ECMAScript 6",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/require-yield"
         },
 
         schema: []

package/lib/rules/rest-spread-spacing.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "enforce spacing between rest and spread operators and their expressions",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/rest-spread-spacing"
         },
         fixable: "whitespace",
         schema: [

package/lib/rules/semi-spacing.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "enforce consistent spacing before and after semicolons",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/semi-spacing"
         },
 
         fixable: "whitespace",

package/lib/rules/semi-style.js

@@ -68,7 +68,8 @@ module.exports = {
         docs: {
             description: "enforce location of semicolons",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/semi-style"
         },
         schema: [{ enum: ["last", "first"] }],
         fixable: "whitespace"

package/lib/rules/semi.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "require or disallow semicolons instead of ASI",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/semi"
         },
 
         fixable: "code",

package/lib/rules/sort-imports.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "enforce sorted import declarations within modules",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/sort-imports"
         },
 
         schema: [

package/lib/rules/sort-keys.js

@@ -76,7 +76,8 @@ module.exports = {
         docs: {
             description: "require object keys to be sorted",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/sort-keys"
         },
         schema: [
             {

package/lib/rules/sort-vars.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "require variables within the same declaration block to be sorted",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/sort-vars"
         },
 
         schema: [

package/lib/rules/space-before-blocks.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "enforce consistent spacing before blocks",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/space-before-blocks"
         },
 
         fixable: "whitespace",

package/lib/rules/space-before-function-paren.js

@@ -19,7 +19,8 @@ module.exports = {
         docs: {
             description: "enforce consistent spacing before `function` definition opening parenthesis",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/space-before-function-paren"
         },
 
         fixable: "whitespace",

package/lib/rules/space-in-parens.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "enforce consistent spacing inside parentheses",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/space-in-parens"
         },
 
         fixable: "whitespace",

package/lib/rules/space-infix-ops.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "require spacing around infix operators",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/space-infix-ops"
         },
 
         fixable: "whitespace",

package/lib/rules/space-unary-ops.js

@@ -19,7 +19,8 @@ module.exports = {
         docs: {
             description: "enforce consistent spacing before or after unary operators",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/space-unary-ops"
         },
 
         fixable: "whitespace",

package/lib/rules/spaced-comment.js

@@ -158,7 +158,8 @@ module.exports = {
         docs: {
             description: "enforce consistent spacing after the `//` or `/*` in a comment",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/spaced-comment"
         },
 
         fixable: "whitespace",

package/lib/rules/strict.js

@@ -83,7 +83,8 @@ module.exports = {
         docs: {
             description: "require or disallow strict mode directives",
             category: "Strict Mode",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/strict"
         },
 
         schema: [

package/lib/rules/switch-colon-spacing.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "enforce spacing around colons of switch statements",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/switch-colon-spacing"
         },
         schema: [
             {

package/lib/rules/symbol-description.js

@@ -21,7 +21,8 @@ module.exports = {
         docs: {
             description: "require symbol descriptions",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/symbol-description"
         },
 
         schema: []