eslint 4.12.1 → 4.15.0

package/lib/rules/linebreak-style.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "enforce consistent linebreak style",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/linebreak-style"
         },
 
         fixable: "whitespace",

package/lib/rules/lines-around-comment.js

@@ -55,7 +55,8 @@ module.exports = {
         docs: {
             description: "require empty lines around comments",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/lines-around-comment"
         },
 
         fixable: "whitespace",

package/lib/rules/lines-around-directive.js

@@ -18,7 +18,8 @@ module.exports = {
             description: "require or disallow newlines around directives",
             category: "Stylistic Issues",
             recommended: false,
-            replacedBy: ["padding-line-between-statements"]
+            replacedBy: ["padding-line-between-statements"],
+            url: "https://eslint.org/docs/rules/lines-around-directive"
         },
         schema: [{
             oneOf: [

package/lib/rules/lines-between-class-members.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "require or disallow an empty line between class members",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/lines-between-class-members"
         },
 
         fixable: "whitespace",
@@ -55,7 +56,56 @@ module.exports = {
          * @returns {boolean} True if there is at least a line between the tokens
          */
         function isPaddingBetweenTokens(first, second) {
-            return second.loc.start.line - first.loc.end.line >= 2;
+            const comments = sourceCode.getCommentsBefore(second);
+            const len = comments.length;
+
+            // If there is no comments
+            if (len === 0) {
+                const linesBetweenFstAndSnd = second.loc.start.line - first.loc.end.line - 1;
+
+                return linesBetweenFstAndSnd >= 1;
+            }
+
+
+            // If there are comments
+            let sumOfCommentLines = 0; // the numbers of lines of comments
+            let prevCommentLineNum = -1; // line number of the end of the previous comment
+
+            for (let i = 0; i < len; i++) {
+                const commentLinesOfThisComment = comments[i].loc.end.line - comments[i].loc.start.line + 1;
+
+                sumOfCommentLines += commentLinesOfThisComment;
+
+                /*
+                 * If this comment and the previous comment are in the same line,
+                 * the count of comment lines is duplicated. So decrement sumOfCommentLines.
+                 */
+                if (prevCommentLineNum === comments[i].loc.start.line) {
+                    sumOfCommentLines -= 1;
+                }
+
+                prevCommentLineNum = comments[i].loc.end.line;
+            }
+
+            /*
+             * If the first block and the first comment are in the same line,
+             * the count of comment lines is duplicated. So decrement sumOfCommentLines.
+             */
+            if (first.loc.end.line === comments[0].loc.start.line) {
+                sumOfCommentLines -= 1;
+            }
+
+            /*
+             * If the last comment and the second block are in the same line,
+             * the count of comment lines is duplicated. So decrement sumOfCommentLines.
+             */
+            if (comments[len - 1].loc.end.line === second.loc.start.line) {
+                sumOfCommentLines -= 1;
+            }
+
+            const linesBetweenFstAndSnd = second.loc.start.line - first.loc.end.line - 1;
+
+            return linesBetweenFstAndSnd - sumOfCommentLines >= 1;
         }
 
         return {
@@ -65,8 +115,7 @@ module.exports = {
                 for (let i = 0; i < body.length - 1; i++) {
                     const curFirst = sourceCode.getFirstToken(body[i]);
                     const curLast = sourceCode.getLastToken(body[i]);
-                    const comments = sourceCode.getCommentsBefore(body[i + 1]);
-                    const nextFirst = comments.length ? comments[0] : sourceCode.getFirstToken(body[i + 1]);
+                    const nextFirst = sourceCode.getFirstToken(body[i + 1]);
                     const isPadded = isPaddingBetweenTokens(curLast, nextFirst);
                     const isMulti = !astUtils.isTokenOnSameLine(curFirst, curLast);
                     const skip = !isMulti && options[1].exceptAfterSingleLine;

package/lib/rules/max-depth.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "enforce a maximum depth that blocks can be nested",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/max-depth"
         },
 
         schema: [

package/lib/rules/max-len.js

@@ -68,7 +68,8 @@ module.exports = {
         docs: {
             description: "enforce a maximum line length",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/max-len"
         },
 
         schema: [

package/lib/rules/max-lines.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "enforce a maximum number of lines per file",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/max-lines"
         },
 
         schema: [

package/lib/rules/max-nested-callbacks.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "enforce a maximum depth that callbacks can be nested",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/max-nested-callbacks"
         },
 
         schema: [

package/lib/rules/max-params.js

@@ -22,7 +22,8 @@ module.exports = {
         docs: {
             description: "enforce a maximum number of parameters in function definitions",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/max-params"
         },
 
         schema: [

package/lib/rules/max-statements-per-line.js

@@ -19,7 +19,8 @@ module.exports = {
         docs: {
             description: "enforce a maximum number of statements allowed per line",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/max-statements-per-line"
         },
 
         schema: [

package/lib/rules/max-statements.js

@@ -22,7 +22,8 @@ module.exports = {
         docs: {
             description: "enforce a maximum number of statements allowed in function blocks",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/max-statements"
         },
 
         schema: [

package/lib/rules/multiline-comment-style.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "enforce a particular style for multiline comments",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/multiline-comment-style"
         },
         fixable: "whitespace",
         schema: [{ enum: ["starred-block", "separate-lines", "bare-block"] }]

package/lib/rules/multiline-ternary.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "enforce newlines between operands of ternary expressions",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/multiline-ternary"
         },
         schema: [
             {

package/lib/rules/new-cap.js

@@ -77,7 +77,8 @@ module.exports = {
         docs: {
             description: "require constructor names to begin with a capital letter",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/new-cap"
         },
 
         schema: [

package/lib/rules/new-parens.js

@@ -24,7 +24,8 @@ module.exports = {
         docs: {
             description: "require parentheses when invoking a constructor with no arguments",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/new-parens"
         },
 
         schema: [],

package/lib/rules/newline-after-var.js

@@ -22,7 +22,8 @@ module.exports = {
             description: "require or disallow an empty line after variable declarations",
             category: "Stylistic Issues",
             recommended: false,
-            replacedBy: ["padding-line-between-statements"]
+            replacedBy: ["padding-line-between-statements"],
+            url: "https://eslint.org/docs/rules/newline-after-var"
         },
 
         schema: [

package/lib/rules/newline-before-return.js

@@ -15,7 +15,8 @@ module.exports = {
             description: "require an empty line before `return` statements",
             category: "Stylistic Issues",
             recommended: false,
-            replacedBy: ["padding-line-between-statements"]
+            replacedBy: ["padding-line-between-statements"],
+            url: "https://eslint.org/docs/rules/newline-before-return"
         },
         fixable: "whitespace",
         schema: [],

package/lib/rules/newline-per-chained-call.js

@@ -17,7 +17,8 @@ module.exports = {
         docs: {
             description: "require a newline after each call in a method chain",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/newline-per-chained-call"
         },
         fixable: "whitespace",
         schema: [{

package/lib/rules/no-alert.js

@@ -88,7 +88,8 @@ module.exports = {
         docs: {
             description: "disallow the use of `alert`, `confirm`, and `prompt`",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-alert"
         },
 
         schema: []

package/lib/rules/no-array-constructor.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow `Array` constructors",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-array-constructor"
         },
 
         schema: []

package/lib/rules/no-await-in-loop.js

@@ -28,7 +28,8 @@ module.exports = {
         docs: {
             description: "disallow `await` inside of loops",
             category: "Possible Errors",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-await-in-loop"
         },
         schema: []
     },

package/lib/rules/no-bitwise.js

@@ -25,7 +25,8 @@ module.exports = {
         docs: {
             description: "disallow bitwise operators",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-bitwise"
         },
 
         schema: [

package/lib/rules/no-buffer-constructor.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow use of the Buffer() constructor",
             category: "Node.js and CommonJS",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-buffer-constructor"
         },
         schema: []
     },

package/lib/rules/no-caller.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow the use of `arguments.caller` or `arguments.callee`",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-caller"
         },
 
         schema: []

package/lib/rules/no-case-declarations.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow lexical declarations in case clauses",
             category: "Best Practices",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-case-declarations"
         },
 
         schema: []

package/lib/rules/no-catch-shadow.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "disallow `catch` clause parameters from shadowing variables in the outer scope",
             category: "Variables",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-catch-shadow"
         },
 
         schema: []

package/lib/rules/no-class-assign.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow reassigning class members",
             category: "ECMAScript 6",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-class-assign"
         },
 
         schema: []

package/lib/rules/no-compare-neg-zero.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow comparing against -0",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-compare-neg-zero"
         },
         fixable: null,
         schema: []

package/lib/rules/no-cond-assign.js

@@ -22,7 +22,8 @@ module.exports = {
         docs: {
             description: "disallow assignment operators in conditional expressions",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-cond-assign"
         },
 
         schema: [

package/lib/rules/no-confusing-arrow.js

@@ -30,7 +30,8 @@ module.exports = {
         docs: {
             description: "disallow arrow functions where they could be confused with comparisons",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-confusing-arrow"
         },
 
         fixable: "code",

package/lib/rules/no-console.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "disallow the use of `console`",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-console"
         },
 
         schema: [

package/lib/rules/no-const-assign.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow reassigning `const` variables",
             category: "ECMAScript 6",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-const-assign"
         },
 
         schema: []

package/lib/rules/no-constant-condition.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow constant expressions in conditions",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-constant-condition"
         },
 
         schema: [

package/lib/rules/no-continue.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow `continue` statements",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-continue"
         },
 
         schema: []

package/lib/rules/no-control-regex.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow control characters in regular expressions",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-control-regex"
         },
 
         schema: []

package/lib/rules/no-debugger.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow the use of `debugger`",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-debugger"
         },
         fixable: "code",
         schema: []

package/lib/rules/no-delete-var.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow deleting variables",
             category: "Variables",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-delete-var"
         },
 
         schema: []

package/lib/rules/no-div-regex.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow division operators explicitly at the beginning of regular expressions",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-div-regex"
         },
 
         schema: []

package/lib/rules/no-dupe-args.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow duplicate arguments in `function` definitions",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-dupe-args"
         },
 
         schema: []

package/lib/rules/no-dupe-class-members.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow duplicate class members",
             category: "ECMAScript 6",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-dupe-class-members"
         },
 
         schema: []

package/lib/rules/no-dupe-keys.js

@@ -87,7 +87,8 @@ module.exports = {
         docs: {
             description: "disallow duplicate keys in object literals",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-dupe-keys"
         },
 
         schema: []

package/lib/rules/no-duplicate-case.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "disallow duplicate case labels",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-duplicate-case"
         },
 
         schema: []

package/lib/rules/no-duplicate-imports.js

@@ -104,7 +104,8 @@ module.exports = {
         docs: {
             description: "disallow duplicate module imports",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-duplicate-imports"
         },
 
         schema: [{

package/lib/rules/no-else-return.js

@@ -21,7 +21,8 @@ module.exports = {
         docs: {
             description: "disallow `else` blocks after `return` statements in `if` statements",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-else-return"
         },
 
         schema: [{

package/lib/rules/no-empty-character-class.js

@@ -32,7 +32,8 @@ module.exports = {
         docs: {
             description: "disallow empty character classes in regular expressions",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-empty-character-class"
         },
 
         schema: []

package/lib/rules/no-empty-function.js

@@ -93,7 +93,8 @@ module.exports = {
         docs: {
             description: "disallow empty functions",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-empty-function"
         },
 
         schema: [

package/lib/rules/no-empty-pattern.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow empty destructuring patterns",
             category: "Best Practices",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-empty-pattern"
         },
 
         schema: []

package/lib/rules/no-empty.js

@@ -19,7 +19,8 @@ module.exports = {
         docs: {
             description: "disallow empty block statements",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-empty"
         },
 
         schema: [

package/lib/rules/no-eq-null.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "disallow `null` comparisons without type-checking operators",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-eq-null"
         },
 
         schema: []

package/lib/rules/no-eval.js

@@ -79,7 +79,8 @@ module.exports = {
         docs: {
             description: "disallow the use of `eval()`",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-eval"
         },
 
         schema: [

package/lib/rules/no-ex-assign.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow reassigning exceptions in `catch` clauses",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-ex-assign"
         },
 
         schema: []