eslint 4.12.1 → 4.15.0

package/lib/rules/no-restricted-modules.js

@@ -50,7 +50,8 @@ module.exports = {
         docs: {
             description: "disallow specified modules when loaded by `require`",
             category: "Node.js and CommonJS",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-restricted-modules"
         },
 
         schema: {

package/lib/rules/no-restricted-properties.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow certain properties on certain objects",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-restricted-properties"
         },
 
         schema: {

package/lib/rules/no-restricted-syntax.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow specified syntax",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-restricted-syntax"
         },
 
         schema: {

package/lib/rules/no-return-assign.js

@@ -25,7 +25,8 @@ module.exports = {
         docs: {
             description: "disallow assignment operators in `return` statements",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-return-assign"
         },
 
         schema: [

package/lib/rules/no-return-await.js

@@ -17,7 +17,11 @@ module.exports = {
         docs: {
             description: "disallow unnecessary `return await`",
             category: "Best Practices",
-            recommended: false // TODO: set to true
+
+            // TODO: set to true
+            recommended: false,
+
+            url: "https://eslint.org/docs/rules/no-return-await"
         },
         fixable: null,
         schema: [

package/lib/rules/no-script-url.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow `javascript:` urls",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-script-url"
         },
 
         schema: []

package/lib/rules/no-self-assign.js

@@ -166,7 +166,8 @@ module.exports = {
         docs: {
             description: "disallow assignments where both sides are exactly the same",
             category: "Best Practices",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-self-assign"
         },
 
         schema: [

package/lib/rules/no-self-compare.js

@@ -15,7 +15,8 @@ module.exports = {
         docs: {
             description: "disallow comparisons where both sides are exactly the same",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-self-compare"
         },
 
         schema: []

package/lib/rules/no-sequences.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "disallow comma operators",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-sequences"
         },
 
         schema: []

package/lib/rules/no-shadow-restricted-names.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow identifiers from shadowing restricted names",
             category: "Variables",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-shadow-restricted-names"
         },
 
         schema: []

package/lib/rules/no-shadow.js

@@ -20,7 +20,8 @@ module.exports = {
         docs: {
             description: "disallow variable declarations from shadowing variables declared in the outer scope",
             category: "Variables",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-shadow"
         },
 
         schema: [

package/lib/rules/no-spaced-func.js

@@ -16,7 +16,8 @@ module.exports = {
             description: "disallow spacing between function identifiers and their applications (deprecated)",
             category: "Stylistic Issues",
             recommended: false,
-            replacedBy: ["func-call-spacing"]
+            replacedBy: ["func-call-spacing"],
+            url: "https://eslint.org/docs/rules/no-spaced-func"
         },
 
         deprecated: true,

package/lib/rules/no-sparse-arrays.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow sparse arrays",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-sparse-arrays"
         },
 
         schema: []

package/lib/rules/no-sync.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow synchronous methods",
             category: "Node.js and CommonJS",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-sync"
         },
 
         schema: [

package/lib/rules/no-tabs.js

@@ -19,7 +19,8 @@ module.exports = {
         docs: {
             description: "disallow all tabs",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-tabs"
         },
         schema: []
     },

package/lib/rules/no-template-curly-in-string.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow template literal placeholder syntax in regular strings",
             category: "Possible Errors",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-template-curly-in-string"
         },
 
         schema: []

package/lib/rules/no-ternary.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow ternary operators",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-ternary"
         },
 
         schema: []

package/lib/rules/no-this-before-super.js

@@ -39,7 +39,8 @@ module.exports = {
         docs: {
             description: "disallow `this`/`super` before calling `super()` in constructors",
             category: "ECMAScript 6",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-this-before-super"
         },
 
         schema: []

package/lib/rules/no-throw-literal.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow throwing literals as exceptions",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-throw-literal"
         },
 
         schema: []

package/lib/rules/no-trailing-spaces.js

@@ -19,7 +19,8 @@ module.exports = {
         docs: {
             description: "disallow trailing whitespace at the end of lines",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-trailing-spaces"
         },
 
         fixable: "whitespace",

package/lib/rules/no-undef-init.js

@@ -16,7 +16,8 @@ module.exports = {
         docs: {
             description: "disallow initializing variables to `undefined`",
             category: "Variables",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-undef-init"
         },
 
         schema: [],

package/lib/rules/no-undef.js

@@ -28,7 +28,8 @@ module.exports = {
         docs: {
             description: "disallow the use of undeclared variables unless mentioned in `/*global */` comments",
             category: "Variables",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-undef"
         },
 
         schema: [

package/lib/rules/no-undefined.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow the use of `undefined` as an identifier",
             category: "Variables",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-undefined"
         },
 
         schema: []

package/lib/rules/no-underscore-dangle.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow dangling underscores in identifiers",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-underscore-dangle"
         },
 
         schema: [

package/lib/rules/no-unexpected-multiline.js

@@ -19,7 +19,8 @@ module.exports = {
         docs: {
             description: "disallow confusing multiline expressions",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-unexpected-multiline"
         },
 
         schema: []

package/lib/rules/no-unmodified-loop-condition.js

@@ -106,84 +106,6 @@ const isInLoop = {
     }
 };
 
-/**
- * Checks whether or not a given group node has any dynamic elements.
- *
- * @param {ASTNode} root - A node to check.
- *      This node is one of BinaryExpression or ConditionalExpression.
- * @returns {boolean} `true` if the node is dynamic.
- */
-function hasDynamicExpressions(root) {
-    let retv = false;
-    const traverser = new Traverser();
-
-    traverser.traverse(root, {
-        enter(node) {
-            if (DYNAMIC_PATTERN.test(node.type)) {
-                retv = true;
-                this.break();
-            } else if (SKIP_PATTERN.test(node.type)) {
-                this.skip();
-            }
-        }
-    });
-
-    return retv;
-}
-
-/**
- * Creates the loop condition information from a given reference.
- *
- * @param {eslint-scope.Reference} reference - A reference to create.
- * @returns {LoopConditionInfo|null} Created loop condition info, or null.
- */
-function toLoopCondition(reference) {
-    if (reference.init) {
-        return null;
-    }
-
-    let group = null;
-    let child = reference.identifier;
-    let node = child.parent;
-
-    while (node) {
-        if (SENTINEL_PATTERN.test(node.type)) {
-            if (LOOP_PATTERN.test(node.type) && node.test === child) {
-
-                // This reference is inside of a loop condition.
-                return {
-                    reference,
-                    group,
-                    isInLoop: isInLoop[node.type].bind(null, node),
-                    modified: false
-                };
-            }
-
-            // This reference is outside of a loop condition.
-            break;
-        }
-
-        /*
-         * If it's inside of a group, OK if either operand is modified.
-         * So stores the group this reference belongs to.
-         */
-        if (GROUP_PATTERN.test(node.type)) {
-
-            // If this expression is dynamic, no need to check.
-            if (hasDynamicExpressions(node)) {
-                break;
-            } else {
-                group = node;
-            }
-        }
-
-        child = node;
-        node = node.parent;
-    }
-
-    return null;
-}
-
 /**
  * Gets the function which encloses a given reference.
  * This supports only FunctionDeclaration.
@@ -247,13 +169,15 @@ module.exports = {
         docs: {
             description: "disallow unmodified loop conditions",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-unmodified-loop-condition"
         },
 
         schema: []
     },
 
     create(context) {
+        const sourceCode = context.getSourceCode();
         let groupMap = null;
 
         /**
@@ -307,6 +231,84 @@ module.exports = {
             }
         }
 
+        /**
+         * Checks whether or not a given group node has any dynamic elements.
+         *
+         * @param {ASTNode} root - A node to check.
+         *      This node is one of BinaryExpression or ConditionalExpression.
+         * @returns {boolean} `true` if the node is dynamic.
+         */
+        function hasDynamicExpressions(root) {
+            let retv = false;
+
+            Traverser.traverse(root, {
+                visitorKeys: sourceCode.visitorKeys,
+                enter(node) {
+                    if (DYNAMIC_PATTERN.test(node.type)) {
+                        retv = true;
+                        this.break();
+                    } else if (SKIP_PATTERN.test(node.type)) {
+                        this.skip();
+                    }
+                }
+            });
+
+            return retv;
+        }
+
+        /**
+         * Creates the loop condition information from a given reference.
+         *
+         * @param {eslint-scope.Reference} reference - A reference to create.
+         * @returns {LoopConditionInfo|null} Created loop condition info, or null.
+         */
+        function toLoopCondition(reference) {
+            if (reference.init) {
+                return null;
+            }
+
+            let group = null;
+            let child = reference.identifier;
+            let node = child.parent;
+
+            while (node) {
+                if (SENTINEL_PATTERN.test(node.type)) {
+                    if (LOOP_PATTERN.test(node.type) && node.test === child) {
+
+                        // This reference is inside of a loop condition.
+                        return {
+                            reference,
+                            group,
+                            isInLoop: isInLoop[node.type].bind(null, node),
+                            modified: false
+                        };
+                    }
+
+                    // This reference is outside of a loop condition.
+                    break;
+                }
+
+                /*
+                 * If it's inside of a group, OK if either operand is modified.
+                 * So stores the group this reference belongs to.
+                 */
+                if (GROUP_PATTERN.test(node.type)) {
+
+                    // If this expression is dynamic, no need to check.
+                    if (hasDynamicExpressions(node)) {
+                        break;
+                    } else {
+                        group = node;
+                    }
+                }
+
+                child = node;
+                node = node.parent;
+            }
+
+            return null;
+        }
+
         /**
          * Finds unmodified references which are inside of a loop condition.
          * Then reports the references which are outside of groups.

package/lib/rules/no-unneeded-ternary.js

@@ -27,7 +27,8 @@ module.exports = {
         docs: {
             description: "disallow ternary operators when simpler alternatives exist",
             category: "Stylistic Issues",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-unneeded-ternary"
         },
 
         schema: [

package/lib/rules/no-unreachable.js

@@ -104,7 +104,8 @@ module.exports = {
         docs: {
             description: "disallow unreachable code after `return`, `throw`, `continue`, and `break` statements",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-unreachable"
         },
 
         schema: []

package/lib/rules/no-unsafe-finally.js

@@ -23,7 +23,8 @@ module.exports = {
         docs: {
             description: "disallow control flow statements in `finally` blocks",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-unsafe-finally"
         },
 
         schema: []

package/lib/rules/no-unsafe-negation.js

@@ -44,7 +44,8 @@ module.exports = {
         docs: {
             description: "disallow negating the left operand of relational operators",
             category: "Possible Errors",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-unsafe-negation"
         },
         schema: [],
         fixable: "code"

package/lib/rules/no-unused-expressions.js

@@ -13,7 +13,8 @@ module.exports = {
         docs: {
             description: "disallow unused expressions",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-unused-expressions"
         },
 
         schema: [

package/lib/rules/no-unused-labels.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow unused labels",
             category: "Best Practices",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-unused-labels"
         },
 
         schema: [],

package/lib/rules/no-unused-vars.js

@@ -21,7 +21,8 @@ module.exports = {
         docs: {
             description: "disallow unused variables",
             category: "Variables",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-unused-vars"
         },
 
         schema: [
@@ -105,26 +106,21 @@ module.exports = {
          * @returns {string} The warning message to be used with this unused variable.
          */
         function getDefinedMessage(unusedVar) {
+            const defType = unusedVar.defs && unusedVar.defs[0] && unusedVar.defs[0].type;
             let type;
             let pattern;
 
-            if (config.varsIgnorePattern) {
+            if (defType === "CatchClause" && config.caughtErrorsIgnorePattern) {
+                type = "args";
+                pattern = config.caughtErrorsIgnorePattern.toString();
+            } else if (defType === "Parameter" && config.argsIgnorePattern) {
+                type = "args";
+                pattern = config.argsIgnorePattern.toString();
+            } else if (defType !== "Parameter" && config.varsIgnorePattern) {
                 type = "vars";
                 pattern = config.varsIgnorePattern.toString();
             }
 
-            if (unusedVar.defs && unusedVar.defs[0] && unusedVar.defs[0].type) {
-                const defType = unusedVar.defs[0].type;
-
-                if (defType === "CatchClause" && config.caughtErrorsIgnorePattern) {
-                    type = "args";
-                    pattern = config.caughtErrorsIgnorePattern.toString();
-                } else if (defType === "Parameter" && config.argsIgnorePattern) {
-                    type = "args";
-                    pattern = config.argsIgnorePattern.toString();
-                }
-            }
-
             const additional = type ? ` Allowed unused ${type} must match ${pattern}.` : "";
 
             return `'{{name}}' is defined but never used.${additional}`;

package/lib/rules/no-use-before-define.js

@@ -139,7 +139,8 @@ module.exports = {
         docs: {
             description: "disallow the use of variables before they are defined",
             category: "Variables",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-use-before-define"
         },
 
         schema: [

package/lib/rules/no-useless-call.js

@@ -52,7 +52,8 @@ module.exports = {
         docs: {
             description: "disallow unnecessary calls to `.call()` and `.apply()`",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-useless-call"
         },
 
         schema: []

package/lib/rules/no-useless-computed-key.js

@@ -21,7 +21,8 @@ module.exports = {
         docs: {
             description: "disallow unnecessary computed property keys in object literals",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-useless-computed-key"
         },
 
         schema: [],

package/lib/rules/no-useless-concat.js

@@ -69,7 +69,8 @@ module.exports = {
         docs: {
             description: "disallow unnecessary concatenation of literals or template literals",
             category: "Best Practices",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-useless-concat"
         },
 
         schema: []

package/lib/rules/no-useless-constructor.js

@@ -145,7 +145,8 @@ module.exports = {
         docs: {
             description: "disallow unnecessary constructors",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-useless-constructor"
         },
 
         schema: []

package/lib/rules/no-useless-escape.js

@@ -82,7 +82,8 @@ module.exports = {
         docs: {
             description: "disallow unnecessary escape characters",
             category: "Best Practices",
-            recommended: true
+            recommended: true,
+            url: "https://eslint.org/docs/rules/no-useless-escape"
         },
 
         schema: []

package/lib/rules/no-useless-rename.js

@@ -14,7 +14,8 @@ module.exports = {
         docs: {
             description: "disallow renaming import, export, and destructured assignments to the same name",
             category: "ECMAScript 6",
-            recommended: false
+            recommended: false,
+            url: "https://eslint.org/docs/rules/no-useless-rename"
         },
         fixable: "code",
         schema: [