eslint 0.22.0 → 0.24.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +20 -20
- package/README.md +111 -95
- package/bin/eslint.js +41 -41
- package/conf/environments.js +87 -81
- package/conf/eslint.json +186 -179
- package/lib/api.js +13 -12
- package/lib/cli-engine.js +441 -451
- package/lib/cli.js +196 -196
- package/lib/config-initializer.js +145 -145
- package/lib/config-validator.js +110 -110
- package/lib/config.js +428 -416
- package/lib/eslint.js +1072 -1073
- package/lib/file-finder.js +167 -167
- package/lib/formatters/checkstyle.js +68 -68
- package/lib/formatters/compact.js +53 -53
- package/lib/formatters/jslint-xml.js +40 -40
- package/lib/formatters/junit.js +63 -63
- package/lib/formatters/stylish.js +90 -90
- package/lib/formatters/tap.js +86 -86
- package/lib/ignored-paths.js +137 -137
- package/lib/load-rules.js +39 -39
- package/lib/options.js +132 -126
- package/lib/rule-context.js +107 -107
- package/lib/rules/accessor-pairs.js +65 -65
- package/lib/rules/array-bracket-spacing.js +180 -0
- package/lib/rules/block-scoped-var.js +339 -320
- package/lib/rules/brace-style.js +228 -228
- package/lib/rules/camelcase.js +111 -111
- package/lib/rules/comma-dangle.js +67 -64
- package/lib/rules/comma-spacing.js +191 -191
- package/lib/rules/comma-style.js +195 -195
- package/lib/rules/complexity.js +94 -94
- package/lib/rules/computed-property-spacing.js +144 -0
- package/lib/rules/consistent-return.js +75 -75
- package/lib/rules/consistent-this.js +119 -119
- package/lib/rules/constructor-super.js +108 -0
- package/lib/rules/curly.js +109 -109
- package/lib/rules/default-case.js +66 -66
- package/lib/rules/dot-location.js +63 -63
- package/lib/rules/dot-notation.js +119 -119
- package/lib/rules/eol-last.js +38 -38
- package/lib/rules/eqeqeq.js +96 -96
- package/lib/rules/func-names.js +45 -45
- package/lib/rules/func-style.js +49 -49
- package/lib/rules/generator-star-spacing.js +104 -87
- package/lib/rules/generator-star.js +76 -76
- package/lib/rules/global-strict.js +49 -49
- package/lib/rules/guard-for-in.js +32 -32
- package/lib/rules/handle-callback-err.js +81 -124
- package/lib/rules/indent.js +486 -486
- package/lib/rules/key-spacing.js +325 -325
- package/lib/rules/linebreak-style.js +44 -44
- package/lib/rules/lines-around-comment.js +228 -160
- package/lib/rules/max-depth.js +89 -89
- package/lib/rules/max-len.js +76 -76
- package/lib/rules/max-nested-callbacks.js +73 -73
- package/lib/rules/max-params.js +45 -45
- package/lib/rules/max-statements.js +61 -61
- package/lib/rules/new-cap.js +224 -224
- package/lib/rules/new-parens.js +29 -29
- package/lib/rules/newline-after-var.js +127 -127
- package/lib/rules/no-alert.js +153 -153
- package/lib/rules/no-array-constructor.js +31 -31
- package/lib/rules/no-bitwise.js +57 -57
- package/lib/rules/no-caller.js +29 -29
- package/lib/rules/no-catch-shadow.js +52 -52
- package/lib/rules/no-comma-dangle.js +45 -45
- package/lib/rules/no-cond-assign.js +123 -123
- package/lib/rules/no-console.js +27 -27
- package/lib/rules/no-constant-condition.js +73 -73
- package/lib/rules/no-continue.js +23 -23
- package/lib/rules/no-control-regex.js +58 -58
- package/lib/rules/no-debugger.js +22 -22
- package/lib/rules/no-delete-var.js +25 -25
- package/lib/rules/no-div-regex.js +27 -27
- package/lib/rules/no-dupe-args.js +89 -85
- package/lib/rules/no-dupe-keys.js +43 -43
- package/lib/rules/no-duplicate-case.js +67 -67
- package/lib/rules/no-else-return.js +125 -125
- package/lib/rules/no-empty-character-class.js +43 -43
- package/lib/rules/no-empty-class.js +45 -45
- package/lib/rules/no-empty-label.js +27 -27
- package/lib/rules/no-empty.js +49 -49
- package/lib/rules/no-eq-null.js +29 -29
- package/lib/rules/no-eval.js +26 -26
- package/lib/rules/no-ex-assign.js +42 -42
- package/lib/rules/no-extend-native.js +103 -103
- package/lib/rules/no-extra-bind.js +81 -81
- package/lib/rules/no-extra-boolean-cast.js +71 -71
- package/lib/rules/no-extra-parens.js +368 -355
- package/lib/rules/no-extra-semi.js +70 -23
- package/lib/rules/no-extra-strict.js +86 -86
- package/lib/rules/no-fallthrough.js +97 -97
- package/lib/rules/no-floating-decimal.js +30 -30
- package/lib/rules/no-func-assign.js +83 -83
- package/lib/rules/no-implied-eval.js +76 -76
- package/lib/rules/no-inline-comments.js +49 -49
- package/lib/rules/no-inner-declarations.js +78 -78
- package/lib/rules/no-invalid-regexp.js +53 -53
- package/lib/rules/no-irregular-whitespace.js +135 -135
- package/lib/rules/no-iterator.js +28 -28
- package/lib/rules/no-label-var.js +64 -64
- package/lib/rules/no-labels.js +44 -44
- package/lib/rules/no-lone-blocks.js +106 -27
- package/lib/rules/no-lonely-if.js +30 -30
- package/lib/rules/no-loop-func.js +58 -58
- package/lib/rules/no-mixed-requires.js +165 -165
- package/lib/rules/no-mixed-spaces-and-tabs.js +74 -74
- package/lib/rules/no-multi-spaces.js +119 -119
- package/lib/rules/no-multi-str.js +43 -43
- package/lib/rules/no-multiple-empty-lines.js +98 -98
- package/lib/rules/no-native-reassign.js +62 -62
- package/lib/rules/no-negated-in-lhs.js +25 -25
- package/lib/rules/no-nested-ternary.js +24 -24
- package/lib/rules/no-new-func.js +25 -25
- package/lib/rules/no-new-object.js +25 -25
- package/lib/rules/no-new-require.js +25 -25
- package/lib/rules/no-new-wrappers.js +26 -26
- package/lib/rules/no-new.js +27 -27
- package/lib/rules/no-obj-calls.js +28 -28
- package/lib/rules/no-octal-escape.js +39 -39
- package/lib/rules/no-octal.js +25 -25
- package/lib/rules/no-param-reassign.js +87 -87
- package/lib/rules/no-path-concat.js +39 -39
- package/lib/rules/no-plusplus.js +24 -24
- package/lib/rules/no-process-env.js +30 -30
- package/lib/rules/no-process-exit.js +33 -33
- package/lib/rules/no-proto.js +28 -28
- package/lib/rules/no-redeclare.js +68 -68
- package/lib/rules/no-regex-spaces.js +35 -35
- package/lib/rules/no-reserved-keys.js +56 -56
- package/lib/rules/no-restricted-modules.js +85 -85
- package/lib/rules/no-return-assign.js +53 -24
- package/lib/rules/no-script-url.js +34 -34
- package/lib/rules/no-self-compare.js +29 -29
- package/lib/rules/no-sequences.js +94 -94
- package/lib/rules/no-shadow-restricted-names.js +51 -51
- package/lib/rules/no-shadow.js +181 -136
- package/lib/rules/no-space-before-semi.js +98 -98
- package/lib/rules/no-spaced-func.js +37 -37
- package/lib/rules/no-sparse-arrays.js +33 -33
- package/lib/rules/no-sync.js +30 -30
- package/lib/rules/no-ternary.js +24 -24
- package/lib/rules/no-this-before-super.js +144 -0
- package/lib/rules/no-throw-literal.js +33 -33
- package/lib/rules/no-trailing-spaces.js +74 -63
- package/lib/rules/no-undef-init.js +28 -28
- package/lib/rules/no-undef.js +92 -92
- package/lib/rules/no-undefined.js +27 -27
- package/lib/rules/no-underscore-dangle.js +73 -73
- package/lib/rules/no-unexpected-multiline.js +58 -0
- package/lib/rules/no-unneeded-ternary.js +48 -48
- package/lib/rules/no-unreachable.js +98 -98
- package/lib/rules/no-unused-expressions.js +76 -76
- package/lib/rules/no-unused-vars.js +252 -250
- package/lib/rules/no-use-before-define.js +105 -105
- package/lib/rules/no-var.js +26 -26
- package/lib/rules/no-void.js +28 -28
- package/lib/rules/no-warning-comments.js +102 -102
- package/lib/rules/no-with.js +22 -22
- package/lib/rules/no-wrap-func.js +65 -65
- package/lib/rules/object-curly-spacing.js +231 -206
- package/lib/rules/object-shorthand.js +74 -73
- package/lib/rules/one-var.js +311 -304
- package/lib/rules/operator-assignment.js +118 -118
- package/lib/rules/operator-linebreak.js +114 -114
- package/lib/rules/padded-blocks.js +98 -98
- package/lib/rules/prefer-const.js +91 -0
- package/lib/rules/quote-props.js +72 -72
- package/lib/rules/quotes.js +92 -92
- package/lib/rules/radix.js +41 -41
- package/lib/rules/semi-spacing.js +167 -167
- package/lib/rules/semi.js +136 -136
- package/lib/rules/sort-vars.js +49 -49
- package/lib/rules/space-after-function-name.js +49 -49
- package/lib/rules/space-after-keywords.js +82 -82
- package/lib/rules/space-before-blocks.js +91 -91
- package/lib/rules/space-before-function-paren.js +139 -139
- package/lib/rules/space-before-function-parentheses.js +139 -139
- package/lib/rules/space-in-brackets.js +305 -305
- package/lib/rules/space-in-parens.js +281 -281
- package/lib/rules/space-infix-ops.js +106 -106
- package/lib/rules/space-return-throw-case.js +38 -38
- package/lib/rules/space-unary-ops.js +124 -133
- package/lib/rules/spaced-comment.js +143 -0
- package/lib/rules/spaced-line-comment.js +89 -89
- package/lib/rules/strict.js +242 -242
- package/lib/rules/use-isnan.js +26 -26
- package/lib/rules/valid-jsdoc.js +215 -215
- package/lib/rules/valid-typeof.js +42 -42
- package/lib/rules/vars-on-top.js +115 -115
- package/lib/rules/wrap-iife.js +48 -48
- package/lib/rules/wrap-regex.js +38 -38
- package/lib/rules/yoda.js +242 -225
- package/lib/rules.js +88 -88
- package/lib/timing.js +109 -109
- package/lib/token-store.js +201 -201
- package/lib/util/traverse.js +105 -105
- package/lib/util.js +125 -85
- package/package.json +6 -6
- package/CHANGELOG.md +0 -1638
@@ -1,305 +1,305 @@
|
|
1
|
-
/**
|
2
|
-
* @fileoverview Disallows or enforces spaces inside of brackets.
|
3
|
-
* @author Ian Christian Myers
|
4
|
-
* @copyright 2014 Brandyn Bennett. All rights reserved.
|
5
|
-
* @copyright 2014 Michael Ficarra. No rights reserved.
|
6
|
-
* @copyright 2014 Vignesh Anand. All rights reserved.
|
7
|
-
*/
|
8
|
-
"use strict";
|
9
|
-
|
10
|
-
//------------------------------------------------------------------------------
|
11
|
-
// Rule Definition
|
12
|
-
//------------------------------------------------------------------------------
|
13
|
-
|
14
|
-
module.exports = function(context) {
|
15
|
-
var spaced = context.options[0] === "always";
|
16
|
-
|
17
|
-
/**
|
18
|
-
* Determines whether an option is set, relative to the spacing option.
|
19
|
-
* If spaced is "always", then check whether option is set to false.
|
20
|
-
* If spaced is "never", then check whether option is set to true.
|
21
|
-
* @param {Object} option - The option to exclude.
|
22
|
-
* @returns {boolean} Whether or not the property is excluded.
|
23
|
-
*/
|
24
|
-
function isOptionSet(option) {
|
25
|
-
return context.options[1] != null ? context.options[1][option] === !spaced : false;
|
26
|
-
}
|
27
|
-
|
28
|
-
var options = {
|
29
|
-
spaced: spaced,
|
30
|
-
singleElementException: isOptionSet("singleValue"),
|
31
|
-
objectsInArraysException: isOptionSet("objectsInArrays"),
|
32
|
-
arraysInArraysException: isOptionSet("arraysInArrays"),
|
33
|
-
arraysInObjectsException: isOptionSet("arraysInObjects"),
|
34
|
-
objectsInObjectsException: isOptionSet("objectsInObjects"),
|
35
|
-
propertyNameException: isOptionSet("propertyName")
|
36
|
-
};
|
37
|
-
|
38
|
-
//--------------------------------------------------------------------------
|
39
|
-
// Helpers
|
40
|
-
//--------------------------------------------------------------------------
|
41
|
-
|
42
|
-
/**
|
43
|
-
* Determines whether two adjacent tokens are have whitespace between them.
|
44
|
-
* @param {Object} left - The left token object.
|
45
|
-
* @param {Object} right - The right token object.
|
46
|
-
* @returns {boolean} Whether or not there is space between the tokens.
|
47
|
-
*/
|
48
|
-
function isSpaced(left, right) {
|
49
|
-
return left.range[1] < right.range[0];
|
50
|
-
}
|
51
|
-
|
52
|
-
/**
|
53
|
-
* Determines whether two adjacent tokens are on the same line.
|
54
|
-
* @param {Object} left - The left token object.
|
55
|
-
* @param {Object} right - The right token object.
|
56
|
-
* @returns {boolean} Whether or not the tokens are on the same line.
|
57
|
-
*/
|
58
|
-
function isSameLine(left, right) {
|
59
|
-
return left.loc.start.line === right.loc.start.line;
|
60
|
-
}
|
61
|
-
|
62
|
-
/**
|
63
|
-
* Reports that there shouldn't be a space after the first token
|
64
|
-
* @param {ASTNode} node - The node to report in the event of an error.
|
65
|
-
* @param {Token} token - The token to use for the report.
|
66
|
-
* @returns {void}
|
67
|
-
*/
|
68
|
-
function reportNoBeginningSpace(node, token) {
|
69
|
-
context.report(node, token.loc.start,
|
70
|
-
"There should be no space after '" + token.value + "'");
|
71
|
-
}
|
72
|
-
|
73
|
-
/**
|
74
|
-
* Reports that there shouldn't be a space before the last token
|
75
|
-
* @param {ASTNode} node - The node to report in the event of an error.
|
76
|
-
* @param {Token} token - The token to use for the report.
|
77
|
-
* @returns {void}
|
78
|
-
*/
|
79
|
-
function reportNoEndingSpace(node, token) {
|
80
|
-
context.report(node, token.loc.start,
|
81
|
-
"There should be no space before '" + token.value + "'");
|
82
|
-
}
|
83
|
-
|
84
|
-
/**
|
85
|
-
* Reports that there should be a space after the first token
|
86
|
-
* @param {ASTNode} node - The node to report in the event of an error.
|
87
|
-
* @param {Token} token - The token to use for the report.
|
88
|
-
* @returns {void}
|
89
|
-
*/
|
90
|
-
function reportRequiredBeginningSpace(node, token) {
|
91
|
-
context.report(node, token.loc.start,
|
92
|
-
"A space is required after '" + token.value + "'");
|
93
|
-
}
|
94
|
-
|
95
|
-
/**
|
96
|
-
* Reports that there should be a space before the last token
|
97
|
-
* @param {ASTNode} node - The node to report in the event of an error.
|
98
|
-
* @param {Token} token - The token to use for the report.
|
99
|
-
* @returns {void}
|
100
|
-
*/
|
101
|
-
function reportRequiredEndingSpace(node, token) {
|
102
|
-
context.report(node, token.loc.start,
|
103
|
-
"A space is required before '" + token.value + "'");
|
104
|
-
}
|
105
|
-
|
106
|
-
|
107
|
-
/**
|
108
|
-
* Determines if spacing in curly braces is valid.
|
109
|
-
* @param {ASTNode} node The AST node to check.
|
110
|
-
* @param {Token} first The first token to check (should be the opening brace)
|
111
|
-
* @param {Token} second The second token to check (should be first after the opening brace)
|
112
|
-
* @param {Token} penultimate The penultimate token to check (should be last before closing brace)
|
113
|
-
* @param {Token} last The last token to check (should be closing brace)
|
114
|
-
* @returns {void}
|
115
|
-
*/
|
116
|
-
function validateBraceSpacing(node, first, second, penultimate, last) {
|
117
|
-
var closingCurlyBraceMustBeSpaced =
|
118
|
-
options.arraysInObjectsException && penultimate.value === "]" ||
|
119
|
-
options.objectsInObjectsException && penultimate.value === "}"
|
120
|
-
? !options.spaced : options.spaced;
|
121
|
-
|
122
|
-
if (isSameLine(first, second)) {
|
123
|
-
if (options.spaced && !isSpaced(first, second)) {
|
124
|
-
reportRequiredBeginningSpace(node, first);
|
125
|
-
}
|
126
|
-
if (!options.spaced && isSpaced(first, second)) {
|
127
|
-
reportNoBeginningSpace(node, first);
|
128
|
-
}
|
129
|
-
}
|
130
|
-
|
131
|
-
if (isSameLine(penultimate, last)) {
|
132
|
-
if (closingCurlyBraceMustBeSpaced && !isSpaced(penultimate, last)) {
|
133
|
-
reportRequiredEndingSpace(node, last);
|
134
|
-
}
|
135
|
-
if (!closingCurlyBraceMustBeSpaced && isSpaced(penultimate, last)) {
|
136
|
-
reportNoEndingSpace(node, last);
|
137
|
-
}
|
138
|
-
}
|
139
|
-
}
|
140
|
-
|
141
|
-
//--------------------------------------------------------------------------
|
142
|
-
// Public
|
143
|
-
//--------------------------------------------------------------------------
|
144
|
-
|
145
|
-
return {
|
146
|
-
|
147
|
-
MemberExpression: function(node) {
|
148
|
-
if (!node.computed) {
|
149
|
-
return;
|
150
|
-
}
|
151
|
-
|
152
|
-
var property = node.property,
|
153
|
-
before = context.getTokenBefore(property),
|
154
|
-
first = context.getFirstToken(property),
|
155
|
-
last = context.getLastToken(property),
|
156
|
-
after = context.getTokenAfter(property);
|
157
|
-
|
158
|
-
var propertyNameMustBeSpaced = options.propertyNameException ?
|
159
|
-
!options.spaced : options.spaced;
|
160
|
-
|
161
|
-
if (isSameLine(before, first)) {
|
162
|
-
if (propertyNameMustBeSpaced) {
|
163
|
-
if (!isSpaced(before, first) && isSameLine(before, first)) {
|
164
|
-
reportRequiredBeginningSpace(node, before);
|
165
|
-
}
|
166
|
-
} else {
|
167
|
-
if (isSpaced(before, first)) {
|
168
|
-
reportNoBeginningSpace(node, before);
|
169
|
-
}
|
170
|
-
}
|
171
|
-
}
|
172
|
-
|
173
|
-
if (isSameLine(last, after)) {
|
174
|
-
if (propertyNameMustBeSpaced) {
|
175
|
-
if (!isSpaced(last, after) && isSameLine(last, after)) {
|
176
|
-
reportRequiredEndingSpace(node, after);
|
177
|
-
}
|
178
|
-
} else {
|
179
|
-
if (isSpaced(last, after)) {
|
180
|
-
reportNoEndingSpace(node, after);
|
181
|
-
}
|
182
|
-
}
|
183
|
-
}
|
184
|
-
},
|
185
|
-
|
186
|
-
ArrayExpression: function(node) {
|
187
|
-
if (node.elements.length === 0) {
|
188
|
-
return;
|
189
|
-
}
|
190
|
-
|
191
|
-
var first = context.getFirstToken(node),
|
192
|
-
second = context.getFirstToken(node, 1),
|
193
|
-
penultimate = context.getLastToken(node, 1),
|
194
|
-
last = context.getLastToken(node);
|
195
|
-
|
196
|
-
var openingBracketMustBeSpaced =
|
197
|
-
options.objectsInArraysException && second.value === "{" ||
|
198
|
-
options.arraysInArraysException && second.value === "[" ||
|
199
|
-
options.singleElementException && node.elements.length === 1
|
200
|
-
? !options.spaced : options.spaced;
|
201
|
-
|
202
|
-
var closingBracketMustBeSpaced =
|
203
|
-
options.objectsInArraysException && penultimate.value === "}" ||
|
204
|
-
options.arraysInArraysException && penultimate.value === "]" ||
|
205
|
-
options.singleElementException && node.elements.length === 1
|
206
|
-
? !options.spaced : options.spaced;
|
207
|
-
|
208
|
-
if (isSameLine(first, second)) {
|
209
|
-
if (openingBracketMustBeSpaced && !isSpaced(first, second)) {
|
210
|
-
reportRequiredBeginningSpace(node, first);
|
211
|
-
}
|
212
|
-
if (!openingBracketMustBeSpaced && isSpaced(first, second)) {
|
213
|
-
reportNoBeginningSpace(node, first);
|
214
|
-
}
|
215
|
-
}
|
216
|
-
|
217
|
-
if (isSameLine(penultimate, last)) {
|
218
|
-
if (closingBracketMustBeSpaced && !isSpaced(penultimate, last)) {
|
219
|
-
reportRequiredEndingSpace(node, last);
|
220
|
-
}
|
221
|
-
if (!closingBracketMustBeSpaced && isSpaced(penultimate, last)) {
|
222
|
-
reportNoEndingSpace(node, last);
|
223
|
-
}
|
224
|
-
}
|
225
|
-
},
|
226
|
-
|
227
|
-
ImportDeclaration: function(node) {
|
228
|
-
|
229
|
-
var firstSpecifier = node.specifiers[0],
|
230
|
-
lastSpecifier = node.specifiers[node.specifiers.length - 1];
|
231
|
-
|
232
|
-
// don't do anything for namespace or default imports
|
233
|
-
if (firstSpecifier && lastSpecifier && firstSpecifier.type === "ImportSpecifier" && lastSpecifier.type === "ImportSpecifier") {
|
234
|
-
var first = context.getTokenBefore(firstSpecifier),
|
235
|
-
second = context.getFirstToken(firstSpecifier),
|
236
|
-
penultimate = context.getLastToken(lastSpecifier),
|
237
|
-
last = context.getTokenAfter(lastSpecifier);
|
238
|
-
|
239
|
-
validateBraceSpacing(node, first, second, penultimate, last);
|
240
|
-
}
|
241
|
-
|
242
|
-
},
|
243
|
-
|
244
|
-
ExportNamedDeclaration: function(node) {
|
245
|
-
if (!node.specifiers.length) {
|
246
|
-
return;
|
247
|
-
}
|
248
|
-
|
249
|
-
var firstSpecifier = node.specifiers[0],
|
250
|
-
lastSpecifier = node.specifiers[node.specifiers.length - 1],
|
251
|
-
first = context.getTokenBefore(firstSpecifier),
|
252
|
-
second = context.getFirstToken(firstSpecifier),
|
253
|
-
penultimate = context.getLastToken(lastSpecifier),
|
254
|
-
last = context.getTokenAfter(lastSpecifier);
|
255
|
-
|
256
|
-
validateBraceSpacing(node, first, second, penultimate, last);
|
257
|
-
|
258
|
-
},
|
259
|
-
|
260
|
-
ObjectExpression: function(node) {
|
261
|
-
if (node.properties.length === 0) {
|
262
|
-
return;
|
263
|
-
}
|
264
|
-
|
265
|
-
var first = context.getFirstToken(node),
|
266
|
-
second = context.getFirstToken(node, 1),
|
267
|
-
penultimate = context.getLastToken(node, 1),
|
268
|
-
last = context.getLastToken(node);
|
269
|
-
|
270
|
-
validateBraceSpacing(node, first, second, penultimate, last);
|
271
|
-
}
|
272
|
-
|
273
|
-
};
|
274
|
-
|
275
|
-
};
|
276
|
-
|
277
|
-
module.exports.schema = [
|
278
|
-
{
|
279
|
-
"enum": ["always", "never"]
|
280
|
-
},
|
281
|
-
{
|
282
|
-
"type": "object",
|
283
|
-
"properties": {
|
284
|
-
"singleValue": {
|
285
|
-
"type": "boolean"
|
286
|
-
},
|
287
|
-
"objectsInArrays": {
|
288
|
-
"type": "boolean"
|
289
|
-
},
|
290
|
-
"arraysInArrays": {
|
291
|
-
"type": "boolean"
|
292
|
-
},
|
293
|
-
"arraysInObjects": {
|
294
|
-
"type": "boolean"
|
295
|
-
},
|
296
|
-
"objectsInObjects": {
|
297
|
-
"type": "boolean"
|
298
|
-
},
|
299
|
-
"propertyName": {
|
300
|
-
"type": "boolean"
|
301
|
-
}
|
302
|
-
},
|
303
|
-
"additionalProperties": false
|
304
|
-
}
|
305
|
-
];
|
1
|
+
/**
|
2
|
+
* @fileoverview Disallows or enforces spaces inside of brackets.
|
3
|
+
* @author Ian Christian Myers
|
4
|
+
* @copyright 2014 Brandyn Bennett. All rights reserved.
|
5
|
+
* @copyright 2014 Michael Ficarra. No rights reserved.
|
6
|
+
* @copyright 2014 Vignesh Anand. All rights reserved.
|
7
|
+
*/
|
8
|
+
"use strict";
|
9
|
+
|
10
|
+
//------------------------------------------------------------------------------
|
11
|
+
// Rule Definition
|
12
|
+
//------------------------------------------------------------------------------
|
13
|
+
|
14
|
+
module.exports = function(context) {
|
15
|
+
var spaced = context.options[0] === "always";
|
16
|
+
|
17
|
+
/**
|
18
|
+
* Determines whether an option is set, relative to the spacing option.
|
19
|
+
* If spaced is "always", then check whether option is set to false.
|
20
|
+
* If spaced is "never", then check whether option is set to true.
|
21
|
+
* @param {Object} option - The option to exclude.
|
22
|
+
* @returns {boolean} Whether or not the property is excluded.
|
23
|
+
*/
|
24
|
+
function isOptionSet(option) {
|
25
|
+
return context.options[1] != null ? context.options[1][option] === !spaced : false;
|
26
|
+
}
|
27
|
+
|
28
|
+
var options = {
|
29
|
+
spaced: spaced,
|
30
|
+
singleElementException: isOptionSet("singleValue"),
|
31
|
+
objectsInArraysException: isOptionSet("objectsInArrays"),
|
32
|
+
arraysInArraysException: isOptionSet("arraysInArrays"),
|
33
|
+
arraysInObjectsException: isOptionSet("arraysInObjects"),
|
34
|
+
objectsInObjectsException: isOptionSet("objectsInObjects"),
|
35
|
+
propertyNameException: isOptionSet("propertyName")
|
36
|
+
};
|
37
|
+
|
38
|
+
//--------------------------------------------------------------------------
|
39
|
+
// Helpers
|
40
|
+
//--------------------------------------------------------------------------
|
41
|
+
|
42
|
+
/**
|
43
|
+
* Determines whether two adjacent tokens are have whitespace between them.
|
44
|
+
* @param {Object} left - The left token object.
|
45
|
+
* @param {Object} right - The right token object.
|
46
|
+
* @returns {boolean} Whether or not there is space between the tokens.
|
47
|
+
*/
|
48
|
+
function isSpaced(left, right) {
|
49
|
+
return left.range[1] < right.range[0];
|
50
|
+
}
|
51
|
+
|
52
|
+
/**
|
53
|
+
* Determines whether two adjacent tokens are on the same line.
|
54
|
+
* @param {Object} left - The left token object.
|
55
|
+
* @param {Object} right - The right token object.
|
56
|
+
* @returns {boolean} Whether or not the tokens are on the same line.
|
57
|
+
*/
|
58
|
+
function isSameLine(left, right) {
|
59
|
+
return left.loc.start.line === right.loc.start.line;
|
60
|
+
}
|
61
|
+
|
62
|
+
/**
|
63
|
+
* Reports that there shouldn't be a space after the first token
|
64
|
+
* @param {ASTNode} node - The node to report in the event of an error.
|
65
|
+
* @param {Token} token - The token to use for the report.
|
66
|
+
* @returns {void}
|
67
|
+
*/
|
68
|
+
function reportNoBeginningSpace(node, token) {
|
69
|
+
context.report(node, token.loc.start,
|
70
|
+
"There should be no space after '" + token.value + "'");
|
71
|
+
}
|
72
|
+
|
73
|
+
/**
|
74
|
+
* Reports that there shouldn't be a space before the last token
|
75
|
+
* @param {ASTNode} node - The node to report in the event of an error.
|
76
|
+
* @param {Token} token - The token to use for the report.
|
77
|
+
* @returns {void}
|
78
|
+
*/
|
79
|
+
function reportNoEndingSpace(node, token) {
|
80
|
+
context.report(node, token.loc.start,
|
81
|
+
"There should be no space before '" + token.value + "'");
|
82
|
+
}
|
83
|
+
|
84
|
+
/**
|
85
|
+
* Reports that there should be a space after the first token
|
86
|
+
* @param {ASTNode} node - The node to report in the event of an error.
|
87
|
+
* @param {Token} token - The token to use for the report.
|
88
|
+
* @returns {void}
|
89
|
+
*/
|
90
|
+
function reportRequiredBeginningSpace(node, token) {
|
91
|
+
context.report(node, token.loc.start,
|
92
|
+
"A space is required after '" + token.value + "'");
|
93
|
+
}
|
94
|
+
|
95
|
+
/**
|
96
|
+
* Reports that there should be a space before the last token
|
97
|
+
* @param {ASTNode} node - The node to report in the event of an error.
|
98
|
+
* @param {Token} token - The token to use for the report.
|
99
|
+
* @returns {void}
|
100
|
+
*/
|
101
|
+
function reportRequiredEndingSpace(node, token) {
|
102
|
+
context.report(node, token.loc.start,
|
103
|
+
"A space is required before '" + token.value + "'");
|
104
|
+
}
|
105
|
+
|
106
|
+
|
107
|
+
/**
|
108
|
+
* Determines if spacing in curly braces is valid.
|
109
|
+
* @param {ASTNode} node The AST node to check.
|
110
|
+
* @param {Token} first The first token to check (should be the opening brace)
|
111
|
+
* @param {Token} second The second token to check (should be first after the opening brace)
|
112
|
+
* @param {Token} penultimate The penultimate token to check (should be last before closing brace)
|
113
|
+
* @param {Token} last The last token to check (should be closing brace)
|
114
|
+
* @returns {void}
|
115
|
+
*/
|
116
|
+
function validateBraceSpacing(node, first, second, penultimate, last) {
|
117
|
+
var closingCurlyBraceMustBeSpaced =
|
118
|
+
options.arraysInObjectsException && penultimate.value === "]" ||
|
119
|
+
options.objectsInObjectsException && penultimate.value === "}"
|
120
|
+
? !options.spaced : options.spaced;
|
121
|
+
|
122
|
+
if (isSameLine(first, second)) {
|
123
|
+
if (options.spaced && !isSpaced(first, second)) {
|
124
|
+
reportRequiredBeginningSpace(node, first);
|
125
|
+
}
|
126
|
+
if (!options.spaced && isSpaced(first, second)) {
|
127
|
+
reportNoBeginningSpace(node, first);
|
128
|
+
}
|
129
|
+
}
|
130
|
+
|
131
|
+
if (isSameLine(penultimate, last)) {
|
132
|
+
if (closingCurlyBraceMustBeSpaced && !isSpaced(penultimate, last)) {
|
133
|
+
reportRequiredEndingSpace(node, last);
|
134
|
+
}
|
135
|
+
if (!closingCurlyBraceMustBeSpaced && isSpaced(penultimate, last)) {
|
136
|
+
reportNoEndingSpace(node, last);
|
137
|
+
}
|
138
|
+
}
|
139
|
+
}
|
140
|
+
|
141
|
+
//--------------------------------------------------------------------------
|
142
|
+
// Public
|
143
|
+
//--------------------------------------------------------------------------
|
144
|
+
|
145
|
+
return {
|
146
|
+
|
147
|
+
MemberExpression: function(node) {
|
148
|
+
if (!node.computed) {
|
149
|
+
return;
|
150
|
+
}
|
151
|
+
|
152
|
+
var property = node.property,
|
153
|
+
before = context.getTokenBefore(property),
|
154
|
+
first = context.getFirstToken(property),
|
155
|
+
last = context.getLastToken(property),
|
156
|
+
after = context.getTokenAfter(property);
|
157
|
+
|
158
|
+
var propertyNameMustBeSpaced = options.propertyNameException ?
|
159
|
+
!options.spaced : options.spaced;
|
160
|
+
|
161
|
+
if (isSameLine(before, first)) {
|
162
|
+
if (propertyNameMustBeSpaced) {
|
163
|
+
if (!isSpaced(before, first) && isSameLine(before, first)) {
|
164
|
+
reportRequiredBeginningSpace(node, before);
|
165
|
+
}
|
166
|
+
} else {
|
167
|
+
if (isSpaced(before, first)) {
|
168
|
+
reportNoBeginningSpace(node, before);
|
169
|
+
}
|
170
|
+
}
|
171
|
+
}
|
172
|
+
|
173
|
+
if (isSameLine(last, after)) {
|
174
|
+
if (propertyNameMustBeSpaced) {
|
175
|
+
if (!isSpaced(last, after) && isSameLine(last, after)) {
|
176
|
+
reportRequiredEndingSpace(node, after);
|
177
|
+
}
|
178
|
+
} else {
|
179
|
+
if (isSpaced(last, after)) {
|
180
|
+
reportNoEndingSpace(node, after);
|
181
|
+
}
|
182
|
+
}
|
183
|
+
}
|
184
|
+
},
|
185
|
+
|
186
|
+
ArrayExpression: function(node) {
|
187
|
+
if (node.elements.length === 0) {
|
188
|
+
return;
|
189
|
+
}
|
190
|
+
|
191
|
+
var first = context.getFirstToken(node),
|
192
|
+
second = context.getFirstToken(node, 1),
|
193
|
+
penultimate = context.getLastToken(node, 1),
|
194
|
+
last = context.getLastToken(node);
|
195
|
+
|
196
|
+
var openingBracketMustBeSpaced =
|
197
|
+
options.objectsInArraysException && second.value === "{" ||
|
198
|
+
options.arraysInArraysException && second.value === "[" ||
|
199
|
+
options.singleElementException && node.elements.length === 1
|
200
|
+
? !options.spaced : options.spaced;
|
201
|
+
|
202
|
+
var closingBracketMustBeSpaced =
|
203
|
+
options.objectsInArraysException && penultimate.value === "}" ||
|
204
|
+
options.arraysInArraysException && penultimate.value === "]" ||
|
205
|
+
options.singleElementException && node.elements.length === 1
|
206
|
+
? !options.spaced : options.spaced;
|
207
|
+
|
208
|
+
if (isSameLine(first, second)) {
|
209
|
+
if (openingBracketMustBeSpaced && !isSpaced(first, second)) {
|
210
|
+
reportRequiredBeginningSpace(node, first);
|
211
|
+
}
|
212
|
+
if (!openingBracketMustBeSpaced && isSpaced(first, second)) {
|
213
|
+
reportNoBeginningSpace(node, first);
|
214
|
+
}
|
215
|
+
}
|
216
|
+
|
217
|
+
if (isSameLine(penultimate, last)) {
|
218
|
+
if (closingBracketMustBeSpaced && !isSpaced(penultimate, last)) {
|
219
|
+
reportRequiredEndingSpace(node, last);
|
220
|
+
}
|
221
|
+
if (!closingBracketMustBeSpaced && isSpaced(penultimate, last)) {
|
222
|
+
reportNoEndingSpace(node, last);
|
223
|
+
}
|
224
|
+
}
|
225
|
+
},
|
226
|
+
|
227
|
+
ImportDeclaration: function(node) {
|
228
|
+
|
229
|
+
var firstSpecifier = node.specifiers[0],
|
230
|
+
lastSpecifier = node.specifiers[node.specifiers.length - 1];
|
231
|
+
|
232
|
+
// don't do anything for namespace or default imports
|
233
|
+
if (firstSpecifier && lastSpecifier && firstSpecifier.type === "ImportSpecifier" && lastSpecifier.type === "ImportSpecifier") {
|
234
|
+
var first = context.getTokenBefore(firstSpecifier),
|
235
|
+
second = context.getFirstToken(firstSpecifier),
|
236
|
+
penultimate = context.getLastToken(lastSpecifier),
|
237
|
+
last = context.getTokenAfter(lastSpecifier);
|
238
|
+
|
239
|
+
validateBraceSpacing(node, first, second, penultimate, last);
|
240
|
+
}
|
241
|
+
|
242
|
+
},
|
243
|
+
|
244
|
+
ExportNamedDeclaration: function(node) {
|
245
|
+
if (!node.specifiers.length) {
|
246
|
+
return;
|
247
|
+
}
|
248
|
+
|
249
|
+
var firstSpecifier = node.specifiers[0],
|
250
|
+
lastSpecifier = node.specifiers[node.specifiers.length - 1],
|
251
|
+
first = context.getTokenBefore(firstSpecifier),
|
252
|
+
second = context.getFirstToken(firstSpecifier),
|
253
|
+
penultimate = context.getLastToken(lastSpecifier),
|
254
|
+
last = context.getTokenAfter(lastSpecifier);
|
255
|
+
|
256
|
+
validateBraceSpacing(node, first, second, penultimate, last);
|
257
|
+
|
258
|
+
},
|
259
|
+
|
260
|
+
ObjectExpression: function(node) {
|
261
|
+
if (node.properties.length === 0) {
|
262
|
+
return;
|
263
|
+
}
|
264
|
+
|
265
|
+
var first = context.getFirstToken(node),
|
266
|
+
second = context.getFirstToken(node, 1),
|
267
|
+
penultimate = context.getLastToken(node, 1),
|
268
|
+
last = context.getLastToken(node);
|
269
|
+
|
270
|
+
validateBraceSpacing(node, first, second, penultimate, last);
|
271
|
+
}
|
272
|
+
|
273
|
+
};
|
274
|
+
|
275
|
+
};
|
276
|
+
|
277
|
+
module.exports.schema = [
|
278
|
+
{
|
279
|
+
"enum": ["always", "never"]
|
280
|
+
},
|
281
|
+
{
|
282
|
+
"type": "object",
|
283
|
+
"properties": {
|
284
|
+
"singleValue": {
|
285
|
+
"type": "boolean"
|
286
|
+
},
|
287
|
+
"objectsInArrays": {
|
288
|
+
"type": "boolean"
|
289
|
+
},
|
290
|
+
"arraysInArrays": {
|
291
|
+
"type": "boolean"
|
292
|
+
},
|
293
|
+
"arraysInObjects": {
|
294
|
+
"type": "boolean"
|
295
|
+
},
|
296
|
+
"objectsInObjects": {
|
297
|
+
"type": "boolean"
|
298
|
+
},
|
299
|
+
"propertyName": {
|
300
|
+
"type": "boolean"
|
301
|
+
}
|
302
|
+
},
|
303
|
+
"additionalProperties": false
|
304
|
+
}
|
305
|
+
];
|