eslint 0.22.0 → 0.24.1

package/lib/rules/newline-after-var.js

@@ -1,127 +1,127 @@
-/**
- * @fileoverview Rule to check empty newline after "var" statement
- * @author Gopal Venkatesan
- * @copyright 2015 Gopal Venkatesan. All rights reserved.
- * @copyright 2015 Casey Visco. All rights reserved.
- */
-
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = function(context) {
-
-    var ALWAYS_MESSAGE = "Expected blank line after variable declarations.",
-        NEVER_MESSAGE = "Unexpected blank line after variable declarations.";
-
-    // Default `mode` to "always". This means that invalid options will also
-    // be treated as "always" and the only special case is "never"
-    var mode = context.options[0] === "never" ? "never" : "always";
-
-    // Cache line numbers of comments for faster lookup
-    var comments = context.getAllComments().map(function (token) {
-        return token.loc.start.line;
-    });
-
-
-    //--------------------------------------------------------------------------
-    // Helpers
-    //--------------------------------------------------------------------------
-
-    /**
-     * Determine if provided keyword is a variable declaration
-     * @private
-     * @param {string} keyword - keyword to test
-     * @returns {boolean} True if `keyword` is a type of var
-     */
-    function isVar(keyword) {
-        return keyword === "var" || keyword === "let" || keyword === "const";
-    }
-
-    /**
-     * Determine if provided keyword is a variant of for specifiers
-     * @private
-     * @param {string} keyword - keyword to test
-     * @returns {boolean} True if `keyword` is a variant of for specifier
-     */
-    function isForTypeSpecifier(keyword) {
-        return keyword === "ForStatement" || keyword === "ForInStatement" || keyword === "ForOfStatement";
-    }
-
-    /**
-     * Determine if provided keyword is an export specifiers
-     * @private
-     * @param {string} nodeType - nodeType to test
-     * @returns {boolean} True if `nodeType` is an export specifier
-     */
-    function isExportSpecifier(nodeType) {
-        return nodeType === "ExportNamedDeclaration" || nodeType === "ExportSpecifier" ||
-            nodeType === "ExportDefaultDeclaration" || nodeType === "ExportAllDeclaration";
-    }
-
-    /**
-     * Checks that a blank line exists after a variable declaration when mode is
-     * set to "always", or checks that there is no blank line when mode is set
-     * to "never"
-     * @private
-     * @param {ASTNode} node - `VariableDeclaration` node to test
-     * @returns {void}
-     */
-    function checkForBlankLine(node) {
-        var lastToken = context.getLastToken(node),
-            nextToken = context.getTokenAfter(node),
-            nextLineNum = lastToken.loc.end.line + 1,
-            noNextLineToken,
-            hasNextLineComment;
-
-        // Ignore if there is no following statement
-        if (!nextToken) {
-            return;
-        }
-
-        // Ignore if parent of node is a for variant
-        if (isForTypeSpecifier(node.parent.type)) {
-            return;
-        }
-
-        // Ignore if parent of node is an export specifier
-        if (isExportSpecifier(node.parent.type)) {
-            return;
-        }
-
-        // Some coding styles use multiple `var` statements, so do nothing if
-        // the next token is a `var` statement.
-        if (nextToken.type === "Keyword" && isVar(nextToken.value)) {
-            return;
-        }
-
-        // Next statement is not a `var`...
-        noNextLineToken = nextToken.loc.start.line > nextLineNum;
-        hasNextLineComment = comments.indexOf(nextLineNum) >= 0;
-
-        if (mode === "never" && noNextLineToken && !hasNextLineComment) {
-            context.report(node, NEVER_MESSAGE, { identifier: node.name });
-        }
-
-        if (mode === "always" && (!noNextLineToken || hasNextLineComment)) {
-            context.report(node, ALWAYS_MESSAGE, { identifier: node.name });
-        }
-    }
-
-    //--------------------------------------------------------------------------
-    // Public
-    //--------------------------------------------------------------------------
-
-    return {
-        "VariableDeclaration": checkForBlankLine
-    };
-
-};
-
-module.exports.schema = [
-    {
-        "enum": ["never", "always"]
-    }
-];
+/**
+ * @fileoverview Rule to check empty newline after "var" statement
+ * @author Gopal Venkatesan
+ * @copyright 2015 Gopal Venkatesan. All rights reserved.
+ * @copyright 2015 Casey Visco. All rights reserved.
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+    var ALWAYS_MESSAGE = "Expected blank line after variable declarations.",
+        NEVER_MESSAGE = "Unexpected blank line after variable declarations.";
+
+    // Default `mode` to "always". This means that invalid options will also
+    // be treated as "always" and the only special case is "never"
+    var mode = context.options[0] === "never" ? "never" : "always";
+
+    // Cache line numbers of comments for faster lookup
+    var comments = context.getAllComments().map(function (token) {
+        return token.loc.start.line;
+    });
+
+
+    //--------------------------------------------------------------------------
+    // Helpers
+    //--------------------------------------------------------------------------
+
+    /**
+     * Determine if provided keyword is a variable declaration
+     * @private
+     * @param {string} keyword - keyword to test
+     * @returns {boolean} True if `keyword` is a type of var
+     */
+    function isVar(keyword) {
+        return keyword === "var" || keyword === "let" || keyword === "const";
+    }
+
+    /**
+     * Determine if provided keyword is a variant of for specifiers
+     * @private
+     * @param {string} keyword - keyword to test
+     * @returns {boolean} True if `keyword` is a variant of for specifier
+     */
+    function isForTypeSpecifier(keyword) {
+        return keyword === "ForStatement" || keyword === "ForInStatement" || keyword === "ForOfStatement";
+    }
+
+    /**
+     * Determine if provided keyword is an export specifiers
+     * @private
+     * @param {string} nodeType - nodeType to test
+     * @returns {boolean} True if `nodeType` is an export specifier
+     */
+    function isExportSpecifier(nodeType) {
+        return nodeType === "ExportNamedDeclaration" || nodeType === "ExportSpecifier" ||
+            nodeType === "ExportDefaultDeclaration" || nodeType === "ExportAllDeclaration";
+    }
+
+    /**
+     * Checks that a blank line exists after a variable declaration when mode is
+     * set to "always", or checks that there is no blank line when mode is set
+     * to "never"
+     * @private
+     * @param {ASTNode} node - `VariableDeclaration` node to test
+     * @returns {void}
+     */
+    function checkForBlankLine(node) {
+        var lastToken = context.getLastToken(node),
+            nextToken = context.getTokenAfter(node),
+            nextLineNum = lastToken.loc.end.line + 1,
+            noNextLineToken,
+            hasNextLineComment;
+
+        // Ignore if there is no following statement
+        if (!nextToken) {
+            return;
+        }
+
+        // Ignore if parent of node is a for variant
+        if (isForTypeSpecifier(node.parent.type)) {
+            return;
+        }
+
+        // Ignore if parent of node is an export specifier
+        if (isExportSpecifier(node.parent.type)) {
+            return;
+        }
+
+        // Some coding styles use multiple `var` statements, so do nothing if
+        // the next token is a `var` statement.
+        if (nextToken.type === "Keyword" && isVar(nextToken.value)) {
+            return;
+        }
+
+        // Next statement is not a `var`...
+        noNextLineToken = nextToken.loc.start.line > nextLineNum;
+        hasNextLineComment = comments.indexOf(nextLineNum) >= 0;
+
+        if (mode === "never" && noNextLineToken && !hasNextLineComment) {
+            context.report(node, NEVER_MESSAGE, { identifier: node.name });
+        }
+
+        if (mode === "always" && (!noNextLineToken || hasNextLineComment)) {
+            context.report(node, ALWAYS_MESSAGE, { identifier: node.name });
+        }
+    }
+
+    //--------------------------------------------------------------------------
+    // Public
+    //--------------------------------------------------------------------------
+
+    return {
+        "VariableDeclaration": checkForBlankLine
+    };
+
+};
+
+module.exports.schema = [
+    {
+        "enum": ["never", "always"]
+    }
+];

package/lib/rules/no-alert.js

@@ -1,153 +1,153 @@
-/**
- * @fileoverview Rule to flag use of alert, confirm, prompt
- * @author Nicholas C. Zakas
- * @copyright 2015 Mathias Schreck
- * @copyright 2013 Nicholas C. Zakas
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Helpers
-//------------------------------------------------------------------------------
-
-/**
- * Checks if the given name is a prohibited identifier.
- * @param {string} name The name to check
- * @returns {boolean} Whether or not the name is prohibited.
- */
-function isProhibitedIdentifier(name) {
-    return /^(alert|confirm|prompt)$/.test(name);
-}
-
-/**
- * Reports the given node and identifier name.
- * @param {RuleContext} context The ESLint rule context.
- * @param {ASTNode} node The node to report on.
- * @param {string} identifierName The name of the identifier.
- * @returns {void}
- */
-function report(context, node, identifierName) {
-    context.report(node, "Unexpected {{name}}.", { name: identifierName });
-}
-
-/**
- * Returns the property name of a MemberExpression.
- * @param {ASTNode} memberExpressionNode The MemberExpression node.
- * @returns {string|undefined} Returns the property name if available, undefined else.
- */
-function getPropertyName(memberExpressionNode) {
-    if (memberExpressionNode.computed) {
-        if (memberExpressionNode.property.type === "Literal") {
-            return memberExpressionNode.property.value;
-        }
-    } else {
-        return memberExpressionNode.property.name;
-    }
-}
-
-/**
- * Finds the escope reference in the given scope.
- * @param {Object} scope The scope to search.
- * @param {ASTNode} node The identifier node.
- * @returns {Reference|undefined} Returns the found reference or undefined if none were found.
- */
-function findReference(scope, node) {
-    var references = scope.references.filter(function (reference) {
-        return reference.identifier.range[0] === node.range[0] &&
-            reference.identifier.range[1] === node.range[1];
-    });
-
-    if (references.length === 1) {
-        return references[0];
-    }
-}
-
-/**
- * Checks if the given identifier name is shadowed in the given global scope.
- * @param {Object} globalScope The global scope.
- * @param {string} identifierName The identifier name to check
- * @returns {boolean} Whether or not the name is shadowed globally.
- */
-function isGloballyShadowed(globalScope, identifierName) {
-    return globalScope.variables.some(function (variable) {
-        return variable.name === identifierName && variable.defs.length > 0;
-    });
-}
-
-/**
- * Checks if the given identifier node is shadowed in the given scope.
- * @param {Object} scope The current scope.
- * @param {Object} globalScope The global scope.
- * @param {string} node The identifier node to check
- * @returns {boolean} Whether or not the name is shadowed.
- */
-function isShadowed(scope, globalScope, node) {
-    var reference = findReference(scope, node),
-        identifierName = node.name;
-
-    if (reference) {
-        if (reference.resolved || isGloballyShadowed(globalScope, identifierName)) {
-            return true;
-        }
-    }
-
-    return false;
-}
-
-/**
- * Checks if the given identifier node is a ThisExpression in the global scope or the global window property.
- * @param {Object} scope The current scope.
- * @param {Object} globalScope The global scope.
- * @param {string} node The identifier node to check
- * @returns {boolean} Whether or not the node is a reference to the global object.
- */
-function isGlobalThisReferenceOrGlobalWindow(scope, globalScope, node) {
-    if (scope.type === "global" && node.type === "ThisExpression") {
-        return true;
-    } else if (node.name === "window") {
-        return !isShadowed(scope, globalScope, node);
-    }
-
-    return false;
-}
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = function(context) {
-    var globalScope;
-
-    return {
-
-        "Program": function () {
-            globalScope = context.getScope();
-        },
-
-        "CallExpression": function(node) {
-            var callee = node.callee,
-                identifierName,
-                currentScope = context.getScope();
-
-            // without window.
-            if (callee.type === "Identifier") {
-                identifierName = callee.name;
-
-                if (!isShadowed(currentScope, globalScope, callee) && isProhibitedIdentifier(callee.name)) {
-                    report(context, node, identifierName);
-                }
-
-            } else if (callee.type === "MemberExpression" && isGlobalThisReferenceOrGlobalWindow(currentScope, globalScope, callee.object)) {
-                identifierName = getPropertyName(callee);
-
-                if (isProhibitedIdentifier(identifierName)) {
-                    report(context, node, identifierName);
-                }
-            }
-
-        }
-    };
-
-};
-
-module.exports.schema = [];
+/**
+ * @fileoverview Rule to flag use of alert, confirm, prompt
+ * @author Nicholas C. Zakas
+ * @copyright 2015 Mathias Schreck
+ * @copyright 2013 Nicholas C. Zakas
+ */
+"use strict";
+
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+/**
+ * Checks if the given name is a prohibited identifier.
+ * @param {string} name The name to check
+ * @returns {boolean} Whether or not the name is prohibited.
+ */
+function isProhibitedIdentifier(name) {
+    return /^(alert|confirm|prompt)$/.test(name);
+}
+
+/**
+ * Reports the given node and identifier name.
+ * @param {RuleContext} context The ESLint rule context.
+ * @param {ASTNode} node The node to report on.
+ * @param {string} identifierName The name of the identifier.
+ * @returns {void}
+ */
+function report(context, node, identifierName) {
+    context.report(node, "Unexpected {{name}}.", { name: identifierName });
+}
+
+/**
+ * Returns the property name of a MemberExpression.
+ * @param {ASTNode} memberExpressionNode The MemberExpression node.
+ * @returns {string|undefined} Returns the property name if available, undefined else.
+ */
+function getPropertyName(memberExpressionNode) {
+    if (memberExpressionNode.computed) {
+        if (memberExpressionNode.property.type === "Literal") {
+            return memberExpressionNode.property.value;
+        }
+    } else {
+        return memberExpressionNode.property.name;
+    }
+}
+
+/**
+ * Finds the escope reference in the given scope.
+ * @param {Object} scope The scope to search.
+ * @param {ASTNode} node The identifier node.
+ * @returns {Reference|undefined} Returns the found reference or undefined if none were found.
+ */
+function findReference(scope, node) {
+    var references = scope.references.filter(function (reference) {
+        return reference.identifier.range[0] === node.range[0] &&
+            reference.identifier.range[1] === node.range[1];
+    });
+
+    if (references.length === 1) {
+        return references[0];
+    }
+}
+
+/**
+ * Checks if the given identifier name is shadowed in the given global scope.
+ * @param {Object} globalScope The global scope.
+ * @param {string} identifierName The identifier name to check
+ * @returns {boolean} Whether or not the name is shadowed globally.
+ */
+function isGloballyShadowed(globalScope, identifierName) {
+    return globalScope.variables.some(function (variable) {
+        return variable.name === identifierName && variable.defs.length > 0;
+    });
+}
+
+/**
+ * Checks if the given identifier node is shadowed in the given scope.
+ * @param {Object} scope The current scope.
+ * @param {Object} globalScope The global scope.
+ * @param {string} node The identifier node to check
+ * @returns {boolean} Whether or not the name is shadowed.
+ */
+function isShadowed(scope, globalScope, node) {
+    var reference = findReference(scope, node),
+        identifierName = node.name;
+
+    if (reference) {
+        if (reference.resolved || isGloballyShadowed(globalScope, identifierName)) {
+            return true;
+        }
+    }
+
+    return false;
+}
+
+/**
+ * Checks if the given identifier node is a ThisExpression in the global scope or the global window property.
+ * @param {Object} scope The current scope.
+ * @param {Object} globalScope The global scope.
+ * @param {string} node The identifier node to check
+ * @returns {boolean} Whether or not the node is a reference to the global object.
+ */
+function isGlobalThisReferenceOrGlobalWindow(scope, globalScope, node) {
+    if (scope.type === "global" && node.type === "ThisExpression") {
+        return true;
+    } else if (node.name === "window") {
+        return !isShadowed(scope, globalScope, node);
+    }
+
+    return false;
+}
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+    var globalScope;
+
+    return {
+
+        "Program": function () {
+            globalScope = context.getScope();
+        },
+
+        "CallExpression": function(node) {
+            var callee = node.callee,
+                identifierName,
+                currentScope = context.getScope();
+
+            // without window.
+            if (callee.type === "Identifier") {
+                identifierName = callee.name;
+
+                if (!isShadowed(currentScope, globalScope, callee) && isProhibitedIdentifier(callee.name)) {
+                    report(context, node, identifierName);
+                }
+
+            } else if (callee.type === "MemberExpression" && isGlobalThisReferenceOrGlobalWindow(currentScope, globalScope, callee.object)) {
+                identifierName = getPropertyName(callee);
+
+                if (isProhibitedIdentifier(identifierName)) {
+                    report(context, node, identifierName);
+                }
+            }
+
+        }
+    };
+
+};
+
+module.exports.schema = [];

package/lib/rules/no-array-constructor.js

@@ -1,31 +1,31 @@
-/**
- * @fileoverview Disallow construction of dense arrays using the Array constructor
- * @author Matt DuVall <http://www.mattduvall.com/>
- */
-
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = function(context) {
-
-    function check(node) {
-        if (
-            node.arguments.length !== 1 &&
-            node.callee.type === "Identifier" &&
-            node.callee.name === "Array"
-        ) {
-            context.report(node, "The array literal notation [] is preferrable.");
-        }
-    }
-
-    return {
-        "CallExpression": check,
-        "NewExpression": check
-    };
-
-};
-
-module.exports.schema = [];
+/**
+ * @fileoverview Disallow construction of dense arrays using the Array constructor
+ * @author Matt DuVall <http://www.mattduvall.com/>
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+    function check(node) {
+        if (
+            node.arguments.length !== 1 &&
+            node.callee.type === "Identifier" &&
+            node.callee.name === "Array"
+        ) {
+            context.report(node, "The array literal notation [] is preferrable.");
+        }
+    }
+
+    return {
+        "CallExpression": check,
+        "NewExpression": check
+    };
+
+};
+
+module.exports.schema = [];