eslint 0.22.0 → 0.24.1

package/lib/rules/no-sync.js

@@ -1,30 +1,30 @@
-/**
- * @fileoverview Rule to check for properties whose identifier ends with the string Sync
- * @author Matt DuVall<http://mattduvall.com/>
- */
-
-/*jshint node:true*/
-
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = function(context) {
-
-    return {
-
-        "MemberExpression": function(node) {
-            var propertyName = node.property.name,
-                syncRegex = /.*Sync$/;
-
-            if (syncRegex.exec(propertyName) !== null) {
-                context.report(node, "Unexpected sync method: '" + propertyName + "'.");
-            }
-        }
-    };
-
-};
-
-module.exports.schema = [];
+/**
+ * @fileoverview Rule to check for properties whose identifier ends with the string Sync
+ * @author Matt DuVall<http://mattduvall.com/>
+ */
+
+/*jshint node:true*/
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+    return {
+
+        "MemberExpression": function(node) {
+            var propertyName = node.property.name,
+                syncRegex = /.*Sync$/;
+
+            if (syncRegex.exec(propertyName) !== null) {
+                context.report(node, "Unexpected sync method: '" + propertyName + "'.");
+            }
+        }
+    };
+
+};
+
+module.exports.schema = [];

package/lib/rules/no-ternary.js

@@ -1,24 +1,24 @@
-/**
- * @fileoverview Rule to flag use of ternary operators.
- * @author Ian Christian Myers
- */
-
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = function(context) {
-
-    return {
-
-        "ConditionalExpression": function(node) {
-            context.report(node, "Ternary operator used.");
-        }
-
-    };
-
-};
-
-module.exports.schema = [];
+/**
+ * @fileoverview Rule to flag use of ternary operators.
+ * @author Ian Christian Myers
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+    return {
+
+        "ConditionalExpression": function(node) {
+            context.report(node, "Ternary operator used.");
+        }
+
+    };
+
+};
+
+module.exports.schema = [];

package/lib/rules/no-this-before-super.js

@@ -0,0 +1,144 @@
+/**
+ * @fileoverview A rule to disallow using `this`/`super` before `super()`.
+ * @author Toru Nagashima
+ * @copyright 2015 Toru Nagashima. All rights reserved.
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+    /**
+     * Searches a class node that a node is belonging to.
+     * @param {Node} node - A node to start searching.
+     * @returns {ClassDeclaration|ClassExpression|null} the found class node, or `null`.
+     */
+    function getClassInAncestor(node) {
+        while (node != null) {
+            if (node.type === "ClassDeclaration" || node.type === "ClassExpression") {
+                return node;
+            }
+            node = node.parent;
+        }
+        /* istanbul ignore next */
+        return null;
+    }
+
+    /**
+     * Checks whether or not a node is the null literal.
+     * @param {Node} node - A node to check.
+     * @returns {boolean} whether or not a node is the null literal.
+     */
+    function isNullLiteral(node) {
+        return node != null && node.type === "Literal" && node.value === null;
+    }
+
+    /**
+     * Checks whether or not a node is the callee of a call expression.
+     * @param {Node} node - A node to check.
+     * @returns {boolean} whether or not a node is the callee of a call expression.
+     */
+    function isCallee(node) {
+        return node != null && node.parent.type === "CallExpression" && node.parent.callee === node;
+    }
+
+    /**
+     * Checks whether or not the current traversal context is before `super()`.
+     * @param {object} item - A checking context.
+     * @returns {boolean} whether or not the current traversal context is before `super()`.
+     */
+    function isBeforeSuperCalling(item) {
+        return (
+            item != null &&
+            item.scope === context.getScope().variableScope.upper.variableScope &&
+            item.superCalled === false
+        );
+    }
+
+    var stack = [];
+
+    return {
+        /**
+         * Start checking.
+         * @param {MethodDefinition} node - A target node.
+         * @returns {void}
+         */
+        "MethodDefinition": function(node) {
+            if (node.kind !== "constructor") {
+                return;
+            }
+            stack.push({
+                thisOrSuperBeforeSuperCalled: [],
+                superCalled: false,
+                scope: context.getScope().variableScope
+            });
+        },
+
+        /**
+         * Treats the result of checking and reports invalid `this`/`super`.
+         * @param {MethodDefinition} node - A target node.
+         * @returns {void}
+         */
+        "MethodDefinition:exit": function(node) {
+            if (node.kind !== "constructor") {
+                return;
+            }
+            var result = stack.pop();
+
+            // Skip if it has no extends or `extends null`.
+            var classNode = getClassInAncestor(node);
+            if (classNode == null || classNode.superClass == null || isNullLiteral(classNode.superClass)) {
+                return;
+            }
+
+            // Reports.
+            result.thisOrSuperBeforeSuperCalled.forEach(function(thisOrSuper) {
+                var type = (thisOrSuper.type === "Super" ? "super" : "this");
+                context.report(thisOrSuper, "\"{{type}}\" is not allowed before super()", {type: type});
+            });
+        },
+
+        /**
+         * Marks the node if is before `super()`.
+         * @param {ThisExpression} node - A target node.
+         * @returns {void}
+         */
+        "ThisExpression": function(node) {
+            var item = stack[stack.length - 1];
+            if (isBeforeSuperCalling(item)) {
+                item.thisOrSuperBeforeSuperCalled.push(node);
+            }
+        },
+
+        /**
+         * Marks the node if is before `super()`. (exclude `super()` itself)
+         * @param {Super} node - A target node.
+         * @returns {void}
+         */
+        "Super": function(node) {
+            var item = stack[stack.length - 1];
+            if (isBeforeSuperCalling(item) && isCallee(node) === false) {
+                item.thisOrSuperBeforeSuperCalled.push(node);
+            }
+        },
+
+        /**
+         * Marks `super()` called.
+         * To catch `super(this.a);`, marks on `CallExpression:exit`.
+         * @param {CallExpression} node - A target node.
+         * @returns {void}
+         */
+        "CallExpression:exit": function(node) {
+            var item = stack[stack.length - 1];
+            if (isBeforeSuperCalling(item) && node.callee.type === "Super") {
+                item.superCalled = true;
+            }
+        }
+    };
+};
+
+module.exports.schema = [];

package/lib/rules/no-throw-literal.js

@@ -1,33 +1,33 @@
-/**
- * @fileoverview Rule to restrict what can be thrown as an exception.
- * @author Dieter Oberkofler
- * @copyright 2015 Dieter Oberkofler. All rights reserved.
- */
-
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = function(context) {
-
-    return {
-
-        "ThrowStatement": function(node) {
-
-            if (node.argument.type === "Literal") {
-                context.report(node, "Do not throw a literal.");
-            } else if (node.argument.type === "Identifier") {
-                if (node.argument.name === "undefined") {
-                    context.report(node, "Do not throw undefined.");
-                }
-            }
-
-        }
-
-    };
-
-};
-
-module.exports.schema = [];
+/**
+ * @fileoverview Rule to restrict what can be thrown as an exception.
+ * @author Dieter Oberkofler
+ * @copyright 2015 Dieter Oberkofler. All rights reserved.
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+    return {
+
+        "ThrowStatement": function(node) {
+
+            if (node.argument.type === "Literal") {
+                context.report(node, "Do not throw a literal.");
+            } else if (node.argument.type === "Identifier") {
+                if (node.argument.name === "undefined") {
+                    context.report(node, "Do not throw undefined.");
+                }
+            }
+
+        }
+
+    };
+
+};
+
+module.exports.schema = [];

package/lib/rules/no-trailing-spaces.js

@@ -1,63 +1,74 @@
-/**
- * @fileoverview Disallow trailing spaces at the end of lines.
- * @author Nodeca Team <https://github.com/nodeca>
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = function(context) {
-
-    var BLANK_PREFIX = "[^( |\t)]",
-        TRAILER = "[ \t\u00a0\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200a\u200b\u2028\u2029\u3000]$";
-
-    var options = context.options[0] || {},
-        skipBlankLines = options.skipBlankLines || false;
-
-
-    //--------------------------------------------------------------------------
-    // Public
-    //--------------------------------------------------------------------------
-
-    return {
-
-        "Program": function checkTrailingSpaces(node) {
-
-            // Let's hack. Since Esprima does not return whitespace nodes,
-            // fetch the source code and do black magic via regexps.
-
-            var src = context.getSource(),
-                re = new RegExp((skipBlankLines ? BLANK_PREFIX : "") + TRAILER, "mg"),
-                match, lines, location;
-
-            while ((match = re.exec(src)) !== null) {
-                lines = src.slice(0, re.lastIndex).split(/\r?\n/g);
-
-                location = {
-                    line: lines.length,
-                    column: lines[lines.length - 1].length - match[0].length + 1
-                };
-
-                // Passing node is a bit dirty, because message data will contain
-                // big text in `source`. But... who cares :) ?
-                // One more kludge will not make worse the bloody wizardry of this plugin.
-                context.report(node, location, "Trailing spaces not allowed.");
-            }
-        }
-
-    };
-};
-
-module.exports.schema = [
-    {
-        "type": "object",
-        "properties": {
-            "skipBlankLines": {
-                "type": "boolean"
-            }
-        },
-        "additionalProperties": false
-    }
-];
+/**
+ * @fileoverview Disallow trailing spaces at the end of lines.
+ * @author Nodeca Team <https://github.com/nodeca>
+ * @copyright 2015 Greg Cochard
+ */
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+    var BLANK_CLASS = "[ \t\u00a0\u2000-\u200b\u2028\u2029\u3000]",
+        SKIP_BLANK = "^" + BLANK_CLASS + "*$",
+        NONBLANK = BLANK_CLASS + "$";
+
+    var options = context.options[0] || {},
+        skipBlankLines = options.skipBlankLines || false;
+
+
+    //--------------------------------------------------------------------------
+    // Public
+    //--------------------------------------------------------------------------
+
+    return {
+
+        "Program": function checkTrailingSpaces(node) {
+
+            // Let's hack. Since Espree does not return whitespace nodes,
+            // fetch the source code and do matching via regexps.
+
+            var src = context.getSource(),
+                re = new RegExp(NONBLANK),
+                skipMatch = new RegExp(SKIP_BLANK),
+                matches, lines = src.split(/\r?\n/), location;
+
+            for (var i = 0, ii = lines.length; i < ii; i++) {
+
+                matches = re.exec(lines[i]);
+                if (matches) {
+
+                    // If the line has only whitespace, and skipBlankLines
+                    // is true, don't report it
+                    if (skipBlankLines && skipMatch.test(lines[i])) {
+                        continue;
+                    }
+                    location = {
+                        line: i + 1,
+                        column: lines[i].length - matches[0].length + 1
+                    };
+
+                    // Passing node is a bit dirty, because message data will contain
+                    // big text in `source`. But... who cares :) ?
+                    // One more kludge will not make worse the bloody wizardry of this plugin.
+                    context.report(node, location, "Trailing spaces not allowed.");
+                }
+            }
+        }
+
+    };
+};
+
+module.exports.schema = [
+    {
+        "type": "object",
+        "properties": {
+            "skipBlankLines": {
+                "type": "boolean"
+            }
+        },
+        "additionalProperties": false
+    }
+];

package/lib/rules/no-undef-init.js

@@ -1,28 +1,28 @@
-/**
- * @fileoverview Rule to flag when initializing to undefined
- * @author Ilya Volodin
- */
-
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = function(context) {
-
-    return {
-
-        "VariableDeclarator": function(node) {
-            var name = node.id.name;
-            var init = node.init && node.init.name;
-
-            if (init === "undefined") {
-                context.report(node, "It's not necessary to initialize '{{name}}' to undefined.", { name: name });
-            }
-        }
-    };
-
-};
-
-module.exports.schema = [];
+/**
+ * @fileoverview Rule to flag when initializing to undefined
+ * @author Ilya Volodin
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+    return {
+
+        "VariableDeclarator": function(node) {
+            var name = node.id.name;
+            var init = node.init && node.init.name;
+
+            if (init === "undefined") {
+                context.report(node, "It's not necessary to initialize '{{name}}' to undefined.", { name: name });
+            }
+        }
+    };
+
+};
+
+module.exports.schema = [];