eslint-plugin-sonarjs 4.0.0 → 4.0.2

package/cjs/S2392/rule.js

@@ -51,10 +51,12 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const collection_js_1 = require("../helpers/collection.js");
+const location_js_1 = require("../helpers/location.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta),
+    meta: (0, generate_meta_js_1.generateMeta)(meta),
     create(context) {
         let scopeRanges = [];
         let reported = [];
@@ -84,7 +86,7 @@ exports.rule = {
                 if (varDeclaration.kind !== 'var') {
                     return;
                 }
-                const scopeRange = (0, index_js_1.last)(scopeRanges);
+                const scopeRange = (0, collection_js_1.last)(scopeRanges);
                 function isOutsideOfScope(reference) {
                     const idRange = reference.range;
                     return idRange[0] < scopeRange[0] || idRange[1] > scopeRange[1];
@@ -98,11 +100,11 @@ exports.rule = {
                     }
                     const definition = variable.defs.find(def => varDeclaration.declarations.includes(def.node));
                     if (definition && !reported.includes(definition.name)) {
-                        (0, index_js_1.report)(context, {
+                        (0, location_js_1.report)(context, {
                             node: definition.name,
                             message: `Consider moving declaration of '${variable.name}' ` +
                                 `as it is referenced outside current binding context.`,
-                        }, referencesOutside.map(node => (0, index_js_1.toSecondaryLocation)(node, 'Outside reference.')));
+                        }, referencesOutside.map(node => (0, location_js_1.toSecondaryLocation)(node, 'Outside reference.')));
                         for (const defId of variable.defs.map(def => def.name)) {
                             reported.push(defId);
                         }

package/cjs/S2424/rule.js

@@ -55,10 +55,10 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
 const globals_1 = __importDefault(require("globals"));
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             removeOverride: 'Remove this override of "{{overridden}}".',
         },

package/cjs/S2428/rule.js

@@ -51,10 +51,12 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const equivalence_js_1 = require("../helpers/equivalence.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const ast_js_1 = require("../helpers/ast.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             declarePropertiesInsideObject: 'Declare one or more properties of this object inside of the object literal syntax instead of using separate statements.',
         },
@@ -63,7 +65,7 @@ exports.rule = {
         return {
             BlockStatement: (node) => checkObjectInitialization(node.body, context),
             Program: (node) => {
-                checkObjectInitialization((0, index_js_1.getProgramStatements)(node), context);
+                checkObjectInitialization((0, ast_js_1.getProgramStatements)(node), context);
             },
         };
     },
@@ -72,7 +74,7 @@ function checkObjectInitialization(statements, context) {
     let index = 0;
     while (index < statements.length - 1) {
         const objectDeclaration = getObjectDeclaration(statements[index]);
-        if (objectDeclaration && (0, index_js_1.isIdentifier)(objectDeclaration.id)) {
+        if (objectDeclaration && (0, ast_js_1.isIdentifier)(objectDeclaration.id)) {
             const nextStmt = statements[index + 1];
             if (isPropertyAssignment(nextStmt, objectDeclaration.id, context.sourceCode)) {
                 context.report({ messageId: 'declarePropertiesInsideObject', node: objectDeclaration });
@@ -97,8 +99,8 @@ function isPropertyAssignment(statement, objectIdentifier, sourceCode) {
         if (left.type === 'MemberExpression') {
             return (!left.computed &&
                 isSingleLineExpression(right, sourceCode) &&
-                (0, index_js_1.areEquivalent)(left.object, objectIdentifier, sourceCode) &&
-                !(0, index_js_1.areEquivalent)(left.object, right, sourceCode));
+                (0, equivalence_js_1.areEquivalent)(left.object, objectIdentifier, sourceCode) &&
+                !(0, equivalence_js_1.areEquivalent)(left.object, right, sourceCode));
         }
     }
     return false;

package/cjs/S2486/rule.js

@@ -51,10 +51,11 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const ast_js_1 = require("../helpers/ast.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             handleException: "Handle this exception or don't catch it at all.",
         },
@@ -64,7 +65,7 @@ exports.rule = {
             'CatchClause[param.type="Identifier"]'(node) {
                 const param = node.param;
                 const scope = context.sourceCode.getScope(node);
-                const variable = (0, index_js_1.getVariableFromScope)(scope, param.name);
+                const variable = (0, ast_js_1.getVariableFromScope)(scope, param.name);
                 if (variable?.references.length === 0) {
                     context.report({
                         messageId: 'handleException',

package/cjs/S2589/rule.js

@@ -51,11 +51,13 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const ast_js_1 = require("../helpers/ast.js");
+const location_js_1 = require("../helpers/location.js");
 const meta = __importStar(require("./generated-meta.js"));
 const message = 'This always evaluates to {{value}}. Consider refactoring this code.';
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             refactorBooleanExpression: message,
         },
@@ -76,7 +78,7 @@ exports.rule = {
             },
             ':statement': (node) => {
                 const { parent } = node;
-                if ((0, index_js_1.isIfStatement)(parent)) {
+                if ((0, ast_js_1.isIfStatement)(parent)) {
                     // we visit 'consequent' and 'alternate' and not if-statement directly in order to get scope for 'consequent'
                     const currentScope = context.sourceCode.getScope(node);
                     if (parent.consequent === node) {
@@ -84,7 +86,7 @@ exports.rule = {
                         truthyMap.set(parent.consequent, transformAndFilter(truthy, currentScope));
                         falsyMap.set(parent.consequent, transformAndFilter(falsy, currentScope));
                     }
-                    else if (parent.alternate === node && (0, index_js_1.isIdentifier)(parent.test)) {
+                    else if (parent.alternate === node && (0, ast_js_1.isIdentifier)(parent.test)) {
                         falsyMap.set(parent.alternate, transformAndFilter([parent.test], currentScope));
                     }
                 }
@@ -103,7 +105,7 @@ exports.rule = {
                 }
                 if (!isLogicalAnd(parent) &&
                     !isLogicalOrLhs(id, parent) &&
-                    !(0, index_js_1.isIfStatement)(parent) &&
+                    !(0, ast_js_1.isIfStatement)(parent) &&
                     !isLogicalNegation(parent)) {
                     return;
                 }
@@ -129,14 +131,14 @@ function collectKnownIdentifiers(expression) {
     const truthy = [];
     const falsy = [];
     const checkExpr = (expr) => {
-        if ((0, index_js_1.isIdentifier)(expr)) {
+        if ((0, ast_js_1.isIdentifier)(expr)) {
             truthy.push(expr);
         }
         else if (isLogicalNegation(expr)) {
-            if ((0, index_js_1.isIdentifier)(expr.argument)) {
+            if ((0, ast_js_1.isIdentifier)(expr.argument)) {
                 falsy.push(expr.argument);
             }
-            else if (isLogicalNegation(expr.argument) && (0, index_js_1.isIdentifier)(expr.argument.argument)) {
+            else if (isLogicalNegation(expr.argument) && (0, ast_js_1.isIdentifier)(expr.argument.argument)) {
                 truthy.push(expr.argument.argument);
             }
         }
@@ -212,11 +214,11 @@ function transformAndFilter(ids, currentScope) {
 }
 function reportIssue(id, ref, context, truthy) {
     const value = truthy ? 'truthy' : 'falsy';
-    (0, index_js_1.report)(context, {
+    (0, location_js_1.report)(context, {
         message,
         data: {
             value,
         },
         node: id,
-    }, ref?.identifier ? [(0, index_js_1.toSecondaryLocation)(ref.identifier, `Evaluated here to be ${value}`)] : []);
+    }, ref?.identifier ? [(0, location_js_1.toSecondaryLocation)(ref.identifier, `Evaluated here to be ${value}`)] : []);
 }

package/cjs/S2598/rule.js

@@ -52,7 +52,10 @@ var __importStar = (this && this.__importStar) || (function () {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
 exports.getVariablePropertyFromAssignment = getVariablePropertyFromAssignment;
-const index_js_1 = require("../helpers/index.js");
+const location_js_1 = require("../helpers/location.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const module_js_1 = require("../helpers/module.js");
+const ast_js_1 = require("../helpers/ast.js");
 const meta = __importStar(require("./generated-meta.js"));
 const FORMIDABLE_MODULE = 'formidable';
 const KEEP_EXTENSIONS = 'keepExtensions';
@@ -62,7 +65,7 @@ const STORAGE_OPTION = 'storage';
 const DESTINATION_OPTION = 'destination';
 const formidableObjects = new Map();
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta),
+    meta: (0, generate_meta_js_1.generateMeta)(meta),
     create(context) {
         return {
             NewExpression(node) {
@@ -90,7 +93,7 @@ function checkCallExpression(context, callExpression) {
     if (callee.type !== 'Identifier') {
         return;
     }
-    const fqn = (0, index_js_1.getFullyQualifiedName)(context, callee);
+    const fqn = (0, module_js_1.getFullyQualifiedName)(context, callee);
     if (!fqn) {
         return;
     }
@@ -104,7 +107,7 @@ function checkCallExpression(context, callExpression) {
 }
 function checkFormidable(context, callExpression) {
     if (callExpression.arguments.length === 0) {
-        const formVariable = (0, index_js_1.getLhsVariable)(context, callExpression);
+        const formVariable = (0, ast_js_1.getLhsVariable)(context, callExpression);
         if (formVariable) {
             formidableObjects.set(formVariable, {
                 uploadDirSet: false,
@@ -114,26 +117,26 @@ function checkFormidable(context, callExpression) {
         }
         return;
     }
-    const options = (0, index_js_1.getValueOfExpression)(context, callExpression.arguments[0], 'ObjectExpression');
+    const options = (0, ast_js_1.getValueOfExpression)(context, callExpression.arguments[0], 'ObjectExpression');
     if (options) {
-        report(context, !!(0, index_js_1.getProperty)(options, UPLOAD_DIR, context), keepExtensionsValue((0, index_js_1.getProperty)(options, KEEP_EXTENSIONS, context)?.value), callExpression);
+        report(context, !!(0, ast_js_1.getProperty)(options, UPLOAD_DIR, context), keepExtensionsValue((0, ast_js_1.getProperty)(options, KEEP_EXTENSIONS, context)?.value), callExpression);
     }
 }
 function checkMulter(context, callExpression) {
     if (callExpression.arguments.length === 0) {
         return;
     }
-    const multerOptions = (0, index_js_1.getValueOfExpression)(context, callExpression.arguments[0], 'ObjectExpression');
+    const multerOptions = (0, ast_js_1.getValueOfExpression)(context, callExpression.arguments[0], 'ObjectExpression');
     if (!multerOptions) {
         return;
     }
-    const storagePropertyValue = (0, index_js_1.getProperty)(multerOptions, STORAGE_OPTION, context)?.value;
+    const storagePropertyValue = (0, ast_js_1.getProperty)(multerOptions, STORAGE_OPTION, context)?.value;
     if (storagePropertyValue) {
-        const storageValue = (0, index_js_1.getValueOfExpression)(context, storagePropertyValue, 'CallExpression');
+        const storageValue = (0, ast_js_1.getValueOfExpression)(context, storagePropertyValue, 'CallExpression');
         if (storageValue) {
             const diskStorageCallee = getDiskStorageCalleeIfUnsafeStorage(context, storageValue);
             if (diskStorageCallee) {
-                report(context, false, false, callExpression, (0, index_js_1.toSecondaryLocation)(diskStorageCallee, 'no destination specified'));
+                report(context, false, false, callExpression, (0, location_js_1.toSecondaryLocation)(diskStorageCallee, 'no destination specified'));
             }
         }
     }
@@ -141,8 +144,8 @@ function checkMulter(context, callExpression) {
 function getDiskStorageCalleeIfUnsafeStorage(context, storageCreation) {
     const { arguments: args, callee } = storageCreation;
     if (args.length > 0 && isMemberWithProperty(callee, 'diskStorage')) {
-        const storageOptions = (0, index_js_1.getValueOfExpression)(context, args[0], 'ObjectExpression');
-        if (storageOptions && !(0, index_js_1.getProperty)(storageOptions, DESTINATION_OPTION, context)) {
+        const storageOptions = (0, ast_js_1.getValueOfExpression)(context, args[0], 'ObjectExpression');
+        if (storageOptions && !(0, ast_js_1.getProperty)(storageOptions, DESTINATION_OPTION, context)) {
             return callee;
         }
     }
@@ -184,7 +187,7 @@ function getVariablePropertyFromAssignment(context, assignment) {
     }
     const memberExpr = assignment.left;
     if (memberExpr.object.type === 'Identifier' && memberExpr.property.type === 'Identifier') {
-        const objectVariable = (0, index_js_1.getVariableFromName)(context, memberExpr.object.name, memberExpr);
+        const objectVariable = (0, ast_js_1.getVariableFromName)(context, memberExpr.object.name, memberExpr);
         if (objectVariable) {
             return { objectVariable, property: memberExpr.property.name };
         }
@@ -203,7 +206,7 @@ function report(context, uploadDirSet, keepExtensions, callExpression, secondary
         message = 'Restrict the extension and folder destination of uploaded files.';
     }
     if (message) {
-        (0, index_js_1.report)(context, {
+        (0, location_js_1.report)(context, {
             message,
             node: callExpression.callee,
         }, secondaryLocation ? [secondaryLocation] : []);

package/cjs/S2612/generated-meta.js

@@ -36,7 +36,7 @@ __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
     docs: {
-        description: 'Setting loose POSIX file permissions is security-sensitive',
+        description: 'File permissions should not be set to world-accessible values',
         recommended: true,
         url: 'https://sonarsource.github.io/rspec/#/rspec/S2612/javascript',
         requiresTypeChecking: false,

package/cjs/S2612/rule.js

@@ -51,11 +51,13 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const module_js_1 = require("../helpers/module.js");
+const ast_js_1 = require("../helpers/ast.js");
 const meta = __importStar(require("./generated-meta.js"));
 const chmodLikeFunction = ['chmod', 'chmodSync', 'fchmod', 'fchmodSync', 'lchmod', 'lchmodSync'];
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             safePermission: 'Make sure this permission is safe.',
         },
@@ -78,7 +80,7 @@ exports.rule = {
         };
         function modeFromMemberExpression(modeExpr) {
             const { object, property } = modeExpr;
-            if ((0, index_js_1.isMemberExpression)(object, 'fs', 'constants') && property.type === 'Identifier') {
+            if ((0, ast_js_1.isMemberExpression)(object, 'fs', 'constants') && property.type === 'Identifier') {
                 return FS_CONST[property.name];
             }
             return null;
@@ -94,7 +96,7 @@ exports.rule = {
                 return modeFromLiteral(expr);
             }
             else if (expr.type === 'Identifier') {
-                const usage = (0, index_js_1.getUniqueWriteUsage)(context, expr.name, expr);
+                const usage = (0, ast_js_1.getUniqueWriteUsage)(context, expr.name, expr);
                 if (usage && !visited.has(usage)) {
                     visited.add(usage);
                     return modeFromExpression(usage, visited);
@@ -129,7 +131,7 @@ exports.rule = {
                     checkModeArgument(callExpression.arguments[0], 0);
                     checkModeArgument(callExpression.arguments[1], 0);
                 }
-                else if ((0, index_js_1.getFullyQualifiedName)(context, callExpression) === 'process.umask') {
+                else if ((0, module_js_1.getFullyQualifiedName)(context, callExpression) === 'process.umask') {
                     checkModeArgument(callExpression.arguments[0], 7);
                 }
             },
@@ -142,7 +144,7 @@ function isChmodLikeFunction(node) {
         return false;
     }
     // to support fs promises we are only checking the name of the function
-    return (0, index_js_1.isIdentifier)(callee.property, ...chmodLikeFunction);
+    return (0, ast_js_1.isIdentifier)(callee.property, ...chmodLikeFunction);
 }
 function modeFromLiteral(modeExpr) {
     const modeValue = modeExpr.value;

package/cjs/S2639/rule.js

@@ -51,7 +51,7 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
 const meta = __importStar(require("./generated-meta.js"));
 const rule_template_js_1 = require("../helpers/regex/rule-template.js");
 exports.rule = (0, rule_template_js_1.createRegExpRule)(context => {
@@ -66,7 +66,7 @@ exports.rule = (0, rule_template_js_1.createRegExpRule)(context => {
             }
         },
     };
-}, (0, index_js_1.generateMeta)(meta, {
+}, (0, generate_meta_js_1.generateMeta)(meta, {
     messages: {
         issue: "Rework this empty character class that doesn't match anything.",
     },

package/cjs/S2681/rule.js

@@ -51,7 +51,7 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
 const meta = __importStar(require("./generated-meta.js"));
 const NestingStatementLike = new Set([
     'IfStatement',
@@ -61,7 +61,7 @@ const NestingStatementLike = new Set([
     'WhileStatement',
 ]);
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta),
+    meta: (0, generate_meta_js_1.generateMeta)(meta),
     create(context) {
         return {
             Program: (node) => checkStatements(node.body, context),

package/cjs/S2692/rule.js

@@ -51,17 +51,19 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const parser_services_js_1 = require("../helpers/parser-services.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const type_js_1 = require("../helpers/type.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             considerIncludes: "This check ignores index 0; consider using 'includes' method to make this check safe and explicit.",
         },
     }),
     create(context) {
         const services = context.sourceCode.parserServices;
-        if (!(0, index_js_1.isRequiredParserServices)(services)) {
+        if (!(0, parser_services_js_1.isRequiredParserServices)(services)) {
             return {};
         }
         return {
@@ -85,5 +87,5 @@ function isArrayIndexOfCall(node, services) {
         node.callee.type === 'MemberExpression' &&
         node.callee.property.type === 'Identifier' &&
         node.callee.property.name === 'indexOf' &&
-        (0, index_js_1.isArray)(node.callee.object, services));
+        (0, type_js_1.isArray)(node.callee.object, services));
 }

package/cjs/S2699/generated-meta.js

@@ -39,7 +39,7 @@ exports.meta = {
         description: 'Tests should include assertions',
         recommended: true,
         url: 'https://sonarsource.github.io/rspec/#/rspec/S2699/javascript',
-        requiresTypeChecking: false,
+        requiresTypeChecking: true,
     },
     fixable: undefined,
     deprecated: false,

package/cjs/S2699/rule.js

@@ -37,8 +37,17 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
-const supertest_js_1 = require("../helpers/supertest.js");
+const Chai = __importStar(require("../helpers/chai.js"));
+const ancestor_js_1 = require("../helpers/ancestor.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const module_js_1 = require("../helpers/module.js");
+const module_ts_js_1 = require("../helpers/module-ts.js");
+const ast_js_1 = require("../helpers/ast.js");
+const parser_services_js_1 = require("../helpers/parser-services.js");
+const Mocha = __importStar(require("../helpers/mocha.js"));
+const Sinon = __importStar(require("../helpers/sinon.js"));
+const Vitest = __importStar(require("../helpers/vitest.js"));
+const Supertest = __importStar(require("../helpers/supertest.js"));
 const meta = __importStar(require("./generated-meta.js"));
 const typescript_1 = __importDefault(require("typescript"));
 /**
@@ -47,19 +56,19 @@ const typescript_1 = __importDefault(require("typescript"));
  * libX and the imported library was libY.
  */
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta),
+    meta: (0, generate_meta_js_1.generateMeta)(meta),
     create(context) {
-        if (!(index_js_1.Chai.isImported(context) ||
-            index_js_1.Sinon.isImported(context) ||
-            index_js_1.Vitest.isImported(context) ||
-            supertest_js_1.Supertest.isImported(context))) {
+        if (!(Chai.isImported(context) ||
+            Sinon.isImported(context) ||
+            Vitest.isImported(context) ||
+            Supertest.isImported(context))) {
             return {};
         }
         const visitedNodes = new Map();
         const visitedTSNodes = new Map();
         return {
             'CallExpression:exit': (node) => {
-                const testCase = index_js_1.Mocha.extractTestCase(node);
+                const testCase = Mocha.extractTestCase(node);
                 if (testCase !== null) {
                     checkAssertions(testCase, context, visitedNodes, visitedTSNodes);
                 }
@@ -90,7 +99,7 @@ function hasDoneCallbackAssertion(callback, context) {
         return false;
     }
     const firstParam = callback.params[0];
-    if (!(0, index_js_1.isIdentifier)(firstParam)) {
+    if (!(0, ast_js_1.isIdentifier)(firstParam)) {
         return false;
     }
     const doneParamName = firstParam.name;
@@ -106,27 +115,27 @@ function isValidDoneMethodCallPattern(node, doneParamName, context) {
     // Pattern 2: .catch(done) - done receives rejection error
     if (methodName === 'catch' &&
         node.arguments.length === 1 &&
-        (0, index_js_1.isIdentifier)(node.arguments[0], doneParamName)) {
+        (0, ast_js_1.isIdentifier)(node.arguments[0], doneParamName)) {
         return true;
     }
     // Pattern 3: .then(_, done) - done as second argument
     if (methodName === 'then' &&
         node.arguments.length >= 2 &&
-        (0, index_js_1.isIdentifier)(node.arguments[1], doneParamName)) {
+        (0, ast_js_1.isIdentifier)(node.arguments[1], doneParamName)) {
         return true;
     }
     // Pattern 4: .subscribe(_, done) - done as second argument (error position)
     if (methodName === 'subscribe' &&
         node.arguments.length >= 2 &&
-        (0, index_js_1.isIdentifier)(node.arguments[1], doneParamName)) {
+        (0, ast_js_1.isIdentifier)(node.arguments[1], doneParamName)) {
         return true;
     }
     // Pattern 5: .subscribe({ error: done }) - done in error property
     if (methodName === 'subscribe' &&
         node.arguments.length === 1 &&
         node.arguments[0].type === 'ObjectExpression') {
-        const errorProp = (0, index_js_1.getProperty)(node.arguments[0], 'error', context);
-        return errorProp != null && (0, index_js_1.isIdentifier)(errorProp.value, doneParamName);
+        const errorProp = (0, ast_js_1.getProperty)(node.arguments[0], 'error', context);
+        return errorProp != null && (0, ast_js_1.isIdentifier)(errorProp.value, doneParamName);
     }
     return false;
 }
@@ -136,16 +145,16 @@ function isValidDoneMethodCallPattern(node, doneParamName, context) {
 function containsValidDoneAssertion(node, doneParamName, visitorKeys, context) {
     if (node.type === 'CallExpression') {
         // Pattern 1: done(arg) - direct call with at least one argument
-        if ((0, index_js_1.isIdentifier)(node.callee, doneParamName) && node.arguments.length > 0) {
+        if ((0, ast_js_1.isIdentifier)(node.callee, doneParamName) && node.arguments.length > 0) {
             return true;
         }
         // Check method call patterns
-        if ((0, index_js_1.isMethodCall)(node) && isValidDoneMethodCallPattern(node, doneParamName, context)) {
+        if ((0, ast_js_1.isMethodCall)(node) && isValidDoneMethodCallPattern(node, doneParamName, context)) {
             return true;
         }
     }
     // Recurse through children
-    for (const child of (0, index_js_1.childrenOf)(node, visitorKeys)) {
+    for (const child of (0, ancestor_js_1.childrenOf)(node, visitorKeys)) {
         if (containsValidDoneAssertion(child, doneParamName, visitorKeys, context)) {
             return true;
         }
@@ -161,7 +170,7 @@ function checkAssertions(testCase, context, visitedNodes, visitedTSNodes) {
     const visitor = new TestCaseAssertionVisitor(context);
     const parserServices = context.sourceCode.parserServices;
     let hasAssertions = false;
-    if ((0, index_js_1.isRequiredParserServices)(parserServices)) {
+    if ((0, parser_services_js_1.isRequiredParserServices)(parserServices)) {
         const tsNode = parserServices.esTreeNodeToTSNodeMap.get(callback);
         hasAssertions = visitor.visitTSNode(parserServices, tsNode, visitedTSNodes);
     }
@@ -183,10 +192,10 @@ class TestCaseAssertionVisitor {
         }
         visitedTSNodes.set(node, false);
         if (isGlobalTSAssertion(services, node) ||
-            index_js_1.Chai.isTSAssertion(services, node) ||
-            index_js_1.Sinon.isTSAssertion(services, node) ||
-            supertest_js_1.Supertest.isTSAssertion(services, node) ||
-            index_js_1.Vitest.isTSAssertion(services, node)) {
+            Chai.isTSAssertion(services, node) ||
+            Sinon.isTSAssertion(services, node) ||
+            Supertest.isTSAssertion(services, node) ||
+            Vitest.isTSAssertion(services, node)) {
             visitedTSNodes.set(node, true);
             return true;
         }
@@ -210,23 +219,23 @@ class TestCaseAssertionVisitor {
             return visitedNodes.get(node);
         }
         visitedNodes.set(node, false);
-        if (index_js_1.Chai.isAssertion(context, node) ||
-            index_js_1.Sinon.isAssertion(context, node) ||
-            index_js_1.Vitest.isAssertion(context, node) ||
-            supertest_js_1.Supertest.isAssertion(context, node) ||
+        if (Chai.isAssertion(context, node) ||
+            Sinon.isAssertion(context, node) ||
+            Vitest.isAssertion(context, node) ||
+            Supertest.isAssertion(context, node) ||
             isGlobalAssertion(context, node)) {
             visitedNodes.set(node, true);
             return true;
         }
         let nodeHasAssertions = false;
-        if ((0, index_js_1.isFunctionCall)(node)) {
+        if ((0, ast_js_1.isFunctionCall)(node)) {
             const { callee } = node;
-            const functionDef = (0, index_js_1.resolveFunction)(this.context, callee);
+            const functionDef = (0, ast_js_1.resolveFunction)(this.context, callee);
             if (functionDef) {
                 nodeHasAssertions ||= this.visit(context, functionDef.body, visitedNodes);
             }
         }
-        for (const child of (0, index_js_1.childrenOf)(node, this.visitorKeys)) {
+        for (const child of (0, ancestor_js_1.childrenOf)(node, this.visitorKeys)) {
             nodeHasAssertions ||= this.visit(context, child, visitedNodes);
         }
         visitedNodes.set(node, nodeHasAssertions);
@@ -263,7 +272,7 @@ function isGlobalExpectExpression(node) {
         innerCallExpression.expression.text.startsWith('expect'));
 }
 function isFunctionCallFromNodeAssertTS(services, node) {
-    const fqn = (0, index_js_1.getFullyQualifiedNameTS)(services, node);
+    const fqn = (0, module_ts_js_1.getFullyQualifiedNameTS)(services, node);
     return fqn ? fqn?.startsWith('assert') : false;
 }
 function isGlobalAssertion(context, node) {
@@ -301,6 +310,6 @@ function isGlobalExpectExpressionJS(node) {
     return innerCall.callee.type === 'Identifier' && innerCall.callee.name.startsWith('expect');
 }
 function isFunctionCallFromNodeAssert(context, node) {
-    const fullyQualifiedName = (0, index_js_1.getFullyQualifiedName)(context, node);
+    const fullyQualifiedName = (0, module_js_1.getFullyQualifiedName)(context, node);
     return fullyQualifiedName?.split('.')[0] === 'assert';
 }

package/cjs/S2703/rule.js

@@ -55,11 +55,11 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
 const globals_1 = __importDefault(require("globals"));
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
 const meta = __importStar(require("./generated-meta.js"));
 const excludedNames = new Set(Object.values(globals_1.default).flatMap(env => Object.keys(env)));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             explicitModifier: 'Add the "let", "const" or "var" keyword to this declaration of "{{variable}}" to make it explicit.',
         },