eslint-plugin-sonarjs 4.0.0 → 4.0.2

package/cjs/S3801/rule.js

@@ -55,14 +55,18 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
 const typescript_1 = __importDefault(require("typescript"));
-const index_js_1 = require("../helpers/index.js");
+const parser_services_js_1 = require("../helpers/parser-services.js");
+const type_js_1 = require("../helpers/type.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const location_js_1 = require("../helpers/location.js");
+const ancestor_js_1 = require("../helpers/ancestor.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta),
+    meta: (0, generate_meta_js_1.generateMeta)(meta),
     create(context) {
         const sourceCode = context.sourceCode;
         const services = sourceCode.parserServices;
-        const hasTypeInformation = (0, index_js_1.isRequiredParserServices)(services);
+        const hasTypeInformation = (0, parser_services_js_1.isRequiredParserServices)(services);
         const functionContextStack = [];
         const checkOnFunctionExit = (node) => checkFunctionLikeDeclaration(node, functionContextStack.at(-1), hasTypeInformation ? services : undefined);
         // tracks the segments we've traversed in the current code path
@@ -78,9 +82,9 @@ exports.rule = {
             checkFunctionForImplicitReturn(functionContext, services);
             if (hasInconsistentReturns(functionContext)) {
                 const secondaryLocations = getSecondaryLocations(functionContext, node);
-                (0, index_js_1.report)(context, {
+                (0, location_js_1.report)(context, {
                     message: `Refactor this function to use "return" consistently.`,
-                    loc: (0, index_js_1.getMainFunctionTokenLocation)(node, (0, index_js_1.getParent)(context, node), context),
+                    loc: (0, location_js_1.getMainFunctionTokenLocation)(node, (0, ancestor_js_1.getParent)(context, node), context),
                 }, secondaryLocations);
             }
         }
@@ -109,11 +113,11 @@ exports.rule = {
         function getSecondaryLocations(functionContext, node) {
             const secondaryLocations = functionContext.returnStatements
                 .slice()
-                .map(returnStatement => (0, index_js_1.toSecondaryLocation)(returnStatement, returnStatement.argument ? 'Return with value' : 'Return without value'));
+                .map(returnStatement => (0, location_js_1.toSecondaryLocation)(returnStatement, returnStatement.argument ? 'Return with value' : 'Return without value'));
             if (functionContext.containsImplicitReturn) {
                 const closeCurlyBraceToken = sourceCode.getLastToken(node, token => token.value === '}');
                 if (!!closeCurlyBraceToken) {
-                    secondaryLocations.push((0, index_js_1.toSecondaryLocation)(closeCurlyBraceToken, 'Implicit return without value'));
+                    secondaryLocations.push((0, location_js_1.toSecondaryLocation)(closeCurlyBraceToken, 'Implicit return without value'));
                 }
             }
             return secondaryLocations;
@@ -171,7 +175,7 @@ exports.rule = {
                 if (!currentContext) {
                     return;
                 }
-                const switchStmt = (0, index_js_1.getParent)(context, node);
+                const switchStmt = (0, ancestor_js_1.getParent)(context, node);
                 const lastCase = switchStmt.cases.at(-1);
                 // Only track the last case - all fall-throughs eventually reach it
                 if (node === lastCase) {
@@ -223,7 +227,7 @@ function isExhaustiveSwitch(switchStmt, services) {
         return true;
     }
     // Without a default, verify all union/enum members are covered
-    const discriminantType = (0, index_js_1.getTypeFromTreeNode)(switchStmt.discriminant, services);
+    const discriminantType = (0, type_js_1.getTypeFromTreeNode)(switchStmt.discriminant, services);
     const types = discriminantType.isUnion() ? discriminantType.types : [discriminantType];
     // Must be a union or enum type to be exhaustive without a default
     if (types.length <= 1 && !isEnumType(discriminantType)) {
@@ -233,7 +237,7 @@ function isExhaustiveSwitch(switchStmt, services) {
     const coveredTypes = new Set();
     for (const caseClause of switchStmt.cases) {
         if (caseClause.test) {
-            const testType = (0, index_js_1.getTypeFromTreeNode)(caseClause.test, services);
+            const testType = (0, type_js_1.getTypeFromTreeNode)(caseClause.test, services);
             if (testType.isUnion()) {
                 testType.types.forEach(t => coveredTypes.add(t));
             }
@@ -257,7 +261,7 @@ function isEnumType(type) {
  * last statement calls a function that never returns.
  */
 function isNeverReturningCall(callExpr, services) {
-    const signature = (0, index_js_1.getSignatureFromCallee)(callExpr, services);
+    const signature = (0, type_js_1.getSignatureFromCallee)(callExpr, services);
     if (!signature) {
         return false;
     }

package/cjs/S3827/rule.js

@@ -34,7 +34,10 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const ancestor_js_1 = require("../helpers/ancestor.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const vue_js_1 = require("../helpers/vue.js");
+const location_js_1 = require("../helpers/location.js");
 const meta = __importStar(require("./generated-meta.js"));
 // https://vuejs.org/api/sfc-script-setup.html#defineprops-defineemits
 const vueMacroNames = new Set([
@@ -46,7 +49,7 @@ const vueMacroNames = new Set([
     'withDefaults',
 ]);
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta),
+    meta: (0, generate_meta_js_1.generateMeta)(meta),
     create(context) {
         const excludedNames = new Set();
         const undeclaredIdentifiersByName = new Map();
@@ -66,7 +69,7 @@ exports.rule = {
                         excludedNames.add(identifier.name);
                         continue;
                     }
-                    if (vueMacroNames.has(identifier.name) && (0, index_js_1.isInsideVueSetupScript)(identifier, context)) {
+                    if (vueMacroNames.has(identifier.name) && (0, vue_js_1.isInsideVueSetupScript)(identifier, context)) {
                         continue;
                     }
                     const undeclaredIndentifiers = undeclaredIdentifiersByName.get(identifier.name);
@@ -78,17 +81,17 @@ exports.rule = {
                     }
                 }
                 for (const [name, identifiers] of undeclaredIdentifiersByName.entries()) {
-                    (0, index_js_1.report)(context, {
+                    (0, location_js_1.report)(context, {
                         node: identifiers[0],
                         message: `"${name}" does not exist. Change its name or declare it so that its usage doesn't result in a "ReferenceError".`,
-                    }, identifiers.slice(1).map(node => (0, index_js_1.toSecondaryLocation)(node)));
+                    }, identifiers.slice(1).map(node => (0, location_js_1.toSecondaryLocation)(node)));
                 }
             },
         };
     },
 };
 function isWithinWithStatement(node) {
-    return !!(0, index_js_1.findFirstMatchingAncestor)(node, ancestor => ancestor.type === 'WithStatement');
+    return !!(0, ancestor_js_1.findFirstMatchingAncestor)(node, ancestor => ancestor.type === 'WithStatement');
 }
 function hasTypeOfOperator(node) {
     const parent = node.parent;

package/cjs/S3923/rule.js

@@ -51,10 +51,13 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const equivalence_js_1 = require("../helpers/equivalence.js");
+const conditions_js_1 = require("../helpers/conditions.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const ast_js_1 = require("../helpers/ast.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             removeOrEditConditionalStructure: "Remove this conditional structure or edit its code blocks so that they're not all the same.",
             returnsTheSameValue: 'This conditional operation returns the same value whether the condition is "true" or "false".',
@@ -64,15 +67,15 @@ exports.rule = {
         return {
             IfStatement(ifStmt) {
                 // don't visit `else if` statements
-                if (!(0, index_js_1.isIfStatement)(ifStmt.parent)) {
-                    const { branches, endsWithElse } = (0, index_js_1.collectIfBranches)(ifStmt);
+                if (!(0, ast_js_1.isIfStatement)(ifStmt.parent)) {
+                    const { branches, endsWithElse } = (0, conditions_js_1.collectIfBranches)(ifStmt);
                     if (endsWithElse && allDuplicated(branches)) {
                         context.report({ messageId: 'removeOrEditConditionalStructure', node: ifStmt });
                     }
                 }
             },
             SwitchStatement(switchStmt) {
-                const { branches, endsWithDefault } = (0, index_js_1.collectSwitchBranches)(switchStmt);
+                const { branches, endsWithDefault } = (0, conditions_js_1.collectSwitchBranches)(switchStmt);
                 if (endsWithDefault && allDuplicated(branches)) {
                     context.report({ messageId: 'removeOrEditConditionalStructure', node: switchStmt });
                 }
@@ -87,7 +90,7 @@ exports.rule = {
         function allDuplicated(branches) {
             return (branches.length > 1 &&
                 branches.slice(1).every((branch, index) => {
-                    return (0, index_js_1.areEquivalent)(branch, branches[index], context.sourceCode);
+                    return (0, equivalence_js_1.areEquivalent)(branch, branches[index], context.sourceCode);
                 }));
         }
     },

package/cjs/S3972/rule.js

@@ -51,11 +51,12 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const location_js_1 = require("../helpers/location.js");
 const meta = __importStar(require("./generated-meta.js"));
 const message = 'Move this "if" to a new line or add the missing "else".';
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         hasSuggestions: true,
         messages: {
             sameLineCondition: message,
@@ -76,7 +77,7 @@ exports.rule = {
                     precedingIf.loc.start.line !== followingIf.loc.end.line) {
                     const precedingIfLastToken = sourceCode.getLastToken(precedingIf);
                     const followingIfToken = sourceCode.getFirstToken(followingIf);
-                    (0, index_js_1.report)(context, {
+                    (0, location_js_1.report)(context, {
                         messageId: 'sameLineCondition',
                         message,
                         loc: followingIfToken.loc,
@@ -90,7 +91,7 @@ exports.rule = {
                                 fix: fixer => fixer.replaceTextRange([precedingIf.range[1], followingIf.range[0]], '\n' + ' '.repeat(precedingIf.loc.start.column)),
                             },
                         ],
-                    }, [(0, index_js_1.toSecondaryLocation)(precedingIfLastToken)]);
+                    }, [(0, location_js_1.toSecondaryLocation)(precedingIfLastToken)]);
                 }
             }
         }

package/cjs/S3973/rule.js

@@ -51,16 +51,18 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const ancestor_js_1 = require("../helpers/ancestor.js");
+const location_js_1 = require("../helpers/location.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta),
+    meta: (0, generate_meta_js_1.generateMeta)(meta),
     create(context) {
         const sourceCode = context.sourceCode;
         return {
             IfStatement: (node) => {
                 const ifStatement = node;
-                const parent = (0, index_js_1.getParent)(context, node);
+                const parent = (0, ancestor_js_1.getParent)(context, node);
                 if (parent && parent.type !== 'IfStatement') {
                     const firstToken = sourceCode.getFirstToken(node);
                     checkIndentation(firstToken, ifStatement.consequent, context);
@@ -91,10 +93,10 @@ function checkIndentation(firstToken, statement, context, tokenToReport = firstT
             firstToken.loc.start.column >= firstStatementToken.loc.start.column) {
             const message = `Use curly braces or indentation to denote the code conditionally ` +
                 `executed by this "${tokenToReport.value}".`;
-            (0, index_js_1.report)(context, {
+            (0, location_js_1.report)(context, {
                 message,
                 loc: tokenToReport.loc,
-            }, [(0, index_js_1.toSecondaryLocation)(firstStatementToken)]);
+            }, [(0, location_js_1.toSecondaryLocation)(firstStatementToken)]);
         }
     }
 }

package/cjs/S3981/rule.js

@@ -51,12 +51,13 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const parser_services_js_1 = require("../helpers/parser-services.js");
 const meta = __importStar(require("./generated-meta.js"));
 const CollectionLike = new Set(['Array', 'Map', 'Set', 'WeakMap', 'WeakSet']);
 const CollectionSizeLike = new Set(['length', 'size']);
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             fixCollectionSizeCheck: 'Fix this expression; {{propertyName}} of "{{objectName}}" is always greater or equal to zero.',
             suggestFixedSizeCheck: 'Use "{{operator}}" for {{operation}} check',
@@ -65,7 +66,7 @@ exports.rule = {
     }),
     create(context) {
         const services = context.sourceCode.parserServices;
-        const isTypeCheckerAvailable = (0, index_js_1.isRequiredParserServices)(services);
+        const isTypeCheckerAvailable = (0, parser_services_js_1.isRequiredParserServices)(services);
         return {
             BinaryExpression: (node) => {
                 if (['<', '>='].includes(node.operator)) {

package/cjs/S3984/rule.js

@@ -51,10 +51,11 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const ancestor_js_1 = require("../helpers/ancestor.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         hasSuggestions: true,
         messages: {
             throwOrRemoveError: 'Throw this error or remove this useless statement.',
@@ -76,7 +77,7 @@ exports.rule = {
                         suggest: [
                             {
                                 messageId: 'suggestThrowError',
-                                fix: fixer => fixer.insertTextBefore((0, index_js_1.getParent)(context, node), 'throw '),
+                                fix: fixer => fixer.insertTextBefore((0, ancestor_js_1.getParent)(context, node), 'throw '),
                             },
                         ],
                     });

package/cjs/S4030/rule.js

@@ -51,10 +51,13 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const collection_js_1 = require("../helpers/collection.js");
+const ancestor_js_1 = require("../helpers/ancestor.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const ast_js_1 = require("../helpers/ast.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             unusedCollection: "Either use this collection's contents or remove the collection.",
         },
@@ -114,7 +117,7 @@ function isUnusedCollection(variable) {
     return assignCollection;
 }
 function isReferenceAssigningCollection(ref) {
-    const declOrExprStmt = (0, index_js_1.findFirstMatchingAncestor)(ref.identifier, n => n.type === 'VariableDeclarator' || n.type === 'ExpressionStatement');
+    const declOrExprStmt = (0, ancestor_js_1.findFirstMatchingAncestor)(ref.identifier, n => n.type === 'VariableDeclarator' || n.type === 'ExpressionStatement');
     if (declOrExprStmt) {
         if (declOrExprStmt.type === 'VariableDeclarator' && declOrExprStmt.init) {
             return isCollectionType(declOrExprStmt.init);
@@ -133,14 +136,14 @@ function isCollectionType(node) {
         return true;
     }
     else if (node?.type === 'CallExpression' || node?.type === 'NewExpression') {
-        return (0, index_js_1.isIdentifier)(node.callee, ...index_js_1.collectionConstructor);
+        return (0, ast_js_1.isIdentifier)(node.callee, ...collection_js_1.collectionConstructor);
     }
     return false;
 }
 function isRead(ref) {
-    const expressionStatement = (0, index_js_1.findFirstMatchingAncestor)(ref.identifier, n => n.type === 'ExpressionStatement');
+    const expressionStatement = (0, ancestor_js_1.findFirstMatchingAncestor)(ref.identifier, n => n.type === 'ExpressionStatement');
     if (expressionStatement) {
-        return !((0, index_js_1.isElementWrite)(expressionStatement, ref, false) ||
+        return !((0, ast_js_1.isElementWrite)(expressionStatement, ref, false) ||
             isWritingMethodCall(expressionStatement, ref));
     }
     //All the write statement that we search are part of ExpressionStatement, if there is none, it's a read
@@ -155,7 +158,7 @@ function isWritingMethodCall(statement, ref) {
         const { callee } = statement.expression;
         if (callee.type === 'MemberExpression') {
             const { property } = callee;
-            return isReferenceTo(ref, callee.object) && (0, index_js_1.isIdentifier)(property, ...index_js_1.writingMethods);
+            return isReferenceTo(ref, callee.object) && (0, ast_js_1.isIdentifier)(property, ...collection_js_1.writingMethods);
         }
     }
     return false;

package/cjs/S4036/rule.js

@@ -51,12 +51,14 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const module_js_1 = require("../helpers/module.js");
+const ast_js_1 = require("../helpers/ast.js");
 const meta = __importStar(require("./generated-meta.js"));
 const SENSITIVE_METHODS = ['exec', 'execSync', 'spawn', 'spawnSync', 'execFile', 'execFileSync'];
 const REQUIRED_PATH_PREFIXES = ['./', '.\\', '../', '..\\', '/', '\\', 'C:\\'];
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             issue: 'Make sure the "PATH" variable only contains fixed, unwriteable directories.',
         },
@@ -64,7 +66,7 @@ exports.rule = {
     create(context) {
         return {
             CallExpression: (node) => {
-                const fqn = (0, index_js_1.getFullyQualifiedName)(context, node);
+                const fqn = (0, module_js_1.getFullyQualifiedName)(context, node);
                 if (SENSITIVE_METHODS.some(method => fqn === `child_process.${method}`)) {
                     const sensitiveArg = findSensitiveArgument(context, node.arguments);
                     if (sensitiveArg !== null) {
@@ -83,9 +85,9 @@ function findSensitiveArgument(context, functionArgs) {
         return null;
     }
     const pathArg = functionArgs[0]; // we know this for the SENSITIVE_METHODS
-    const literalInExpression = (0, index_js_1.getValueOfExpression)(context, pathArg, 'Literal');
+    const literalInExpression = (0, ast_js_1.getValueOfExpression)(context, pathArg, 'Literal');
     let stringLiteral;
-    if (literalInExpression !== undefined && (0, index_js_1.isStringLiteral)(literalInExpression)) {
+    if (literalInExpression !== undefined && (0, ast_js_1.isStringLiteral)(literalInExpression)) {
         stringLiteral = literalInExpression;
     }
     else {

package/cjs/S4043/rule.js

@@ -55,11 +55,15 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
 const typescript_1 = __importDefault(require("typescript"));
-const index_js_1 = require("../helpers/index.js");
+const parser_services_js_1 = require("../helpers/parser-services.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const type_js_1 = require("../helpers/type.js");
+const ancestor_js_1 = require("../helpers/ancestor.js");
+const collection_js_1 = require("../helpers/collection.js");
 const meta = __importStar(require("./generated-meta.js"));
-const arrayMutatingMethods = new Set(['reverse', "'reverse'", '"reverse"', ...index_js_1.sortLike]);
+const arrayMutatingMethods = new Set(['reverse', "'reverse'", '"reverse"', ...collection_js_1.sortLike]);
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         hasSuggestions: true,
         messages: {
             moveMethod: 'Move this array "{{method}}" operation to a separate statement or replace it with "{{suggestedMethod}}".',
@@ -68,7 +72,7 @@ exports.rule = {
     }),
     create(context) {
         const services = context.sourceCode.parserServices;
-        if (!(0, index_js_1.isRequiredParserServices)(services)) {
+        if (!(0, parser_services_js_1.isRequiredParserServices)(services)) {
             return {};
         }
         return {
@@ -119,14 +123,14 @@ function formatMethod(mutatingMethod) {
     }
 }
 function isArrayMutatingCall(memberExpression, services, propertyText) {
-    return arrayMutatingMethods.has(propertyText) && (0, index_js_1.isArray)(memberExpression.object, services);
+    return arrayMutatingMethods.has(propertyText) && (0, type_js_1.isArray)(memberExpression.object, services);
 }
 function isIdentifierOrPropertyAccessExpression(node, services) {
     return (node.type === 'Identifier' ||
         (node.type === 'MemberExpression' && !isGetAccessor(node.property, services)));
 }
 function isGetAccessor(node, services) {
-    const symbol = (0, index_js_1.getSymbolAtLocation)(node, services);
+    const symbol = (0, type_js_1.getSymbolAtLocation)(node, services);
     const declarations = symbol?.declarations;
     return declarations?.length === 1 && declarations[0].kind === typescript_1.default.SyntaxKind.GetAccessor;
 }
@@ -144,7 +148,7 @@ function isForbiddenOperation(node) {
     return !isStandaloneExpression(node) && !isReturnedExpression(node);
 }
 function isStandaloneExpression(node) {
-    const ancestors = (0, index_js_1.localAncestorsChain)(node);
+    const ancestors = (0, ancestor_js_1.localAncestorsChain)(node);
     const returnIdx = ancestors.findIndex(ancestor => ancestor.type === 'ExpressionStatement');
     return (returnIdx > -1 &&
         ancestors
@@ -152,7 +156,7 @@ function isStandaloneExpression(node) {
             .every(ancestor => ['ChainExpression', 'LogicalExpression'].includes(ancestor.type)));
 }
 function isReturnedExpression(node) {
-    const ancestors = (0, index_js_1.localAncestorsChain)(node);
+    const ancestors = (0, ancestor_js_1.localAncestorsChain)(node);
     const returnIdx = ancestors.findIndex(ancestor => ancestor.type === 'ReturnStatement');
     return (returnIdx > -1 &&
         ancestors

package/cjs/S4139/rule.js

@@ -51,22 +51,24 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const type_js_1 = require("../helpers/type.js");
+const parser_services_js_1 = require("../helpers/parser-services.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             useForOf: 'Use "for...of" to iterate over this "{{iterable}}".',
         },
     }),
     create(context) {
         const services = context.sourceCode.parserServices;
-        if (!(0, index_js_1.isRequiredParserServices)(services)) {
+        if (!(0, parser_services_js_1.isRequiredParserServices)(services)) {
             return {};
         }
         return {
             ForInStatement: (node) => {
-                const type = (0, index_js_1.getTypeFromTreeNode)(node.right, services);
+                const type = (0, type_js_1.getTypeFromTreeNode)(node.right, services);
                 if (isIterable(type)) {
                     const iterable = type.symbol ? type.symbol.name : 'String';
                     context.report({
@@ -78,7 +80,7 @@ exports.rule = {
             },
         };
         function isIterable(type) {
-            return isCollection(type) || (0, index_js_1.isStringType)(type) || (0, index_js_1.isArrayLikeType)(type, services);
+            return isCollection(type) || (0, type_js_1.isStringType)(type) || (0, type_js_1.isArrayLikeType)(type, services);
         }
     },
 };

package/cjs/S4143/rule.js

@@ -51,11 +51,14 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const equivalence_js_1 = require("../helpers/equivalence.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const ast_js_1 = require("../helpers/ast.js");
+const location_js_1 = require("../helpers/location.js");
 const meta = __importStar(require("./generated-meta.js"));
 const message = 'Verify this is the index that was intended; "{{index}}" was already set on line {{line}}.';
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             verifyIntendedIndex: message,
         },
@@ -69,7 +72,7 @@ exports.rule = {
                 checkStatements(node.body);
             },
             Program(node) {
-                checkStatements((0, index_js_1.getProgramStatements)(node));
+                checkStatements((0, ast_js_1.getProgramStatements)(node));
             },
         };
         function checkStatements(statements) {
@@ -79,15 +82,15 @@ exports.rule = {
                 const keyWriteUsage = getKeyWriteUsage(statement);
                 if (keyWriteUsage) {
                     if (collection &&
-                        !(0, index_js_1.areEquivalent)(keyWriteUsage.collectionNode, collection, context.sourceCode)) {
+                        !(0, equivalence_js_1.areEquivalent)(keyWriteUsage.collectionNode, collection, context.sourceCode)) {
                         usedKeys.clear();
                     }
                     const sameKeyWriteUsage = usedKeys.get(keyWriteUsage.indexOrKey);
                     if (sameKeyWriteUsage?.node.loc) {
                         const secondaryLocations = [
-                            (0, index_js_1.toSecondaryLocation)(sameKeyWriteUsage.node, 'Original value'),
+                            (0, location_js_1.toSecondaryLocation)(sameKeyWriteUsage.node, 'Original value'),
                         ];
-                        (0, index_js_1.report)(context, {
+                        (0, location_js_1.report)(context, {
                             node: keyWriteUsage.node,
                             messageId: 'verifyIntendedIndex',
                             message,
@@ -153,11 +156,11 @@ function isSimpleAssignment(node) {
     return node.type === 'AssignmentExpression' && node.operator === '=';
 }
 function extractIndex(node) {
-    if ((0, index_js_1.isLiteral)(node)) {
+    if ((0, ast_js_1.isLiteral)(node)) {
         const { value } = node;
         return typeof value === 'number' || typeof value === 'string' ? String(value) : undefined;
     }
-    else if ((0, index_js_1.isIdentifier)(node)) {
+    else if ((0, ast_js_1.isIdentifier)(node)) {
         return node.name;
     }
     return undefined;
@@ -165,7 +168,7 @@ function extractIndex(node) {
 function mapOrSetKeyWriteUsage(node) {
     if (node.type === 'CallExpression' && node.callee.type === 'MemberExpression') {
         const propertyAccess = node.callee;
-        if ((0, index_js_1.isIdentifier)(propertyAccess.property)) {
+        if ((0, ast_js_1.isIdentifier)(propertyAccess.property)) {
             const methodName = propertyAccess.property.name;
             const addMethod = methodName === 'add' && node.arguments.length === 1;
             const setMethod = methodName === 'set' && node.arguments.length === 2;

package/cjs/S4144/rule.js

@@ -51,12 +51,15 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
-const index_js_1 = require("../helpers/index.js");
+const equivalence_js_1 = require("../helpers/equivalence.js");
+const generate_meta_js_1 = require("../helpers/generate-meta.js");
+const location_js_1 = require("../helpers/location.js");
+const collection_js_1 = require("../helpers/collection.js");
 const meta = __importStar(require("./generated-meta.js"));
 const DEFAULT_MIN_LINES = 3;
 const message = 'Update this function so that its implementation is not identical to the one on line {{line}}.';
 exports.rule = {
-    meta: (0, index_js_1.generateMeta)(meta, {
+    meta: (0, generate_meta_js_1.generateMeta)(meta, {
         messages: {
             identicalFunctions: message,
         },
@@ -88,14 +91,14 @@ exports.rule = {
                 const duplicatingFunction = functions[i].function;
                 for (let j = 0; j < i; j++) {
                     const originalFunction = functions[j].function;
-                    if ((0, index_js_1.areEquivalent)(duplicatingFunction.body, originalFunction.body, context.sourceCode) &&
+                    if ((0, equivalence_js_1.areEquivalent)(duplicatingFunction.body, originalFunction.body, context.sourceCode) &&
                         originalFunction.loc) {
-                        const loc = (0, index_js_1.getMainFunctionTokenLocation)(duplicatingFunction, functions[i].parent, context);
-                        const originalFunctionLoc = (0, index_js_1.getMainFunctionTokenLocation)(originalFunction, functions[j].parent, context);
+                        const loc = (0, location_js_1.getMainFunctionTokenLocation)(duplicatingFunction, functions[i].parent, context);
+                        const originalFunctionLoc = (0, location_js_1.getMainFunctionTokenLocation)(originalFunction, functions[j].parent, context);
                         const secondaryLocations = [
-                            (0, index_js_1.toSecondaryLocation)({ loc: originalFunctionLoc }, 'Original implementation'),
+                            (0, location_js_1.toSecondaryLocation)({ loc: originalFunctionLoc }, 'Original implementation'),
                         ];
-                        (0, index_js_1.report)(context, {
+                        (0, location_js_1.report)(context, {
                             message,
                             data: {
                                 line: originalFunction.loc.start.line,
@@ -112,12 +115,12 @@ exports.rule = {
             if (tokens.length > 0 && tokens[0].value === '{') {
                 tokens.shift();
             }
-            if (tokens.length > 0 && (0, index_js_1.last)(tokens).value === '}') {
+            if (tokens.length > 0 && (0, collection_js_1.last)(tokens).value === '}') {
                 tokens.pop();
             }
             if (tokens.length > 0) {
                 const firstLine = tokens[0].loc.start.line;
-                const lastLine = (0, index_js_1.last)(tokens).loc.end.line;
+                const lastLine = (0, collection_js_1.last)(tokens).loc.end.line;
                 return lastLine - firstLine + 1 >= minLines;
             }
             return false;