eslint-plugin-sonarjs 4.0.0 → 4.0.2

package/cjs/helpers/mocha.js

@@ -1,58 +1,54 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Mocha = void 0;
-const index_js_1 = require("./index.js");
-var Mocha;
-(function (Mocha) {
-    const TEST_CONSTRUCTS = [
-        'describe',
-        'context',
-        'it',
-        'specify',
-        'before',
-        'after',
-        'beforeEach',
-        'afterEach',
-    ];
-    function isTestConstruct(node, constructs = TEST_CONSTRUCTS) {
-        return constructs.some(construct => {
-            return (node.type === 'CallExpression' &&
-                ((0, index_js_1.isIdentifier)(node.callee, construct) ||
-                    (node.callee.type === 'MemberExpression' &&
-                        (0, index_js_1.isIdentifier)(node.callee.object, construct) &&
-                        (0, index_js_1.isIdentifier)(node.callee.property, 'only', 'skip'))));
-        });
-    }
-    Mocha.isTestConstruct = isTestConstruct;
-    function extractTestCase(node) {
-        if (isTestCase(node)) {
-            const callExpr = node;
-            const [, callback] = callExpr.arguments;
-            if (callback && index_js_1.FUNCTION_NODES.includes(callback.type)) {
-                return { node: callExpr.callee, callback: callback };
-            }
+exports.isTestConstruct = isTestConstruct;
+exports.extractTestCase = extractTestCase;
+exports.isTestCase = isTestCase;
+exports.isDescribeCase = isDescribeCase;
+const ast_js_1 = require("./ast.js");
+const TEST_CONSTRUCTS = [
+    'describe',
+    'context',
+    'it',
+    'specify',
+    'before',
+    'after',
+    'beforeEach',
+    'afterEach',
+];
+function isTestConstruct(node, constructs = TEST_CONSTRUCTS) {
+    return constructs.some(construct => {
+        return (node.type === 'CallExpression' &&
+            ((0, ast_js_1.isIdentifier)(node.callee, construct) ||
+                (node.callee.type === 'MemberExpression' &&
+                    (0, ast_js_1.isIdentifier)(node.callee.object, construct) &&
+                    (0, ast_js_1.isIdentifier)(node.callee.property, 'only', 'skip'))));
+    });
+}
+function extractTestCase(node) {
+    if (isTestCase(node)) {
+        const callExpr = node;
+        const [, callback] = callExpr.arguments;
+        if (callback && ast_js_1.FUNCTION_NODES.includes(callback.type)) {
+            return { node: callExpr.callee, callback: callback };
         }
-        return null;
-    }
-    Mocha.extractTestCase = extractTestCase;
-    /**
-     * returns true if the node is a test case
-     *
-     * @param node
-     * @returns
-     */
-    function isTestCase(node) {
-        return isTestConstruct(node, ['it', 'specify']);
-    }
-    Mocha.isTestCase = isTestCase;
-    /**
-     * returns true if the node is a describe block
-     *
-     * @param node
-     * @returns
-     */
-    function isDescribeCase(node) {
-        return isTestConstruct(node, ['describe']);
     }
-    Mocha.isDescribeCase = isDescribeCase;
-})(Mocha || (exports.Mocha = Mocha = {}));
+    return null;
+}
+/**
+ * returns true if the node is a test case
+ *
+ * @param node
+ * @returns
+ */
+function isTestCase(node) {
+    return isTestConstruct(node, ['it', 'specify']);
+}
+/**
+ * returns true if the node is a describe block
+ *
+ * @param node
+ * @returns
+ */
+function isDescribeCase(node) {
+    return isTestConstruct(node, ['describe']);
+}

package/cjs/helpers/regex/ast.js

@@ -3,7 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.isRegExpConstructor = isRegExpConstructor;
 exports.isStringReplaceCall = isStringReplaceCall;
 exports.isStringRegexMethodCall = isStringRegexMethodCall;
-const index_js_1 = require("../index.js");
+const ast_js_1 = require("../ast.js");
+const type_js_1 = require("../type.js");
 function isRegExpConstructor(node) {
     return (((node.type === 'CallExpression' || node.type === 'NewExpression') &&
         node.callee.type === 'Identifier' &&
@@ -17,7 +18,7 @@ function isStringReplaceCall(call, services) {
         !call.callee.computed &&
         ['replace', 'replaceAll'].includes(call.callee.property.name) &&
         call.arguments.length > 1 &&
-        (0, index_js_1.isString)(call.callee.object, services));
+        (0, type_js_1.isString)(call.callee.object, services));
 }
 function isStringRegexMethodCall(call, services) {
     return (call.callee.type === 'MemberExpression' &&
@@ -25,13 +26,13 @@ function isStringRegexMethodCall(call, services) {
         !call.callee.computed &&
         ['match', 'matchAll', 'search'].includes(call.callee.property.name) &&
         call.arguments.length > 0 &&
-        (0, index_js_1.isString)(call.callee.object, services) &&
-        (0, index_js_1.isString)(call.arguments[0], services));
+        (0, type_js_1.isString)(call.callee.object, services) &&
+        (0, type_js_1.isString)(call.arguments[0], services));
 }
 function isRegExpWithGlobalThis(node) {
     return (node.type === 'NewExpression' &&
         node.callee.type === 'MemberExpression' &&
-        (0, index_js_1.isIdentifier)(node.callee.object, 'globalThis') &&
-        (0, index_js_1.isIdentifier)(node.callee.property, 'RegExp') &&
+        (0, ast_js_1.isIdentifier)(node.callee.object, 'globalThis') &&
+        (0, ast_js_1.isIdentifier)(node.callee.property, 'RegExp') &&
         node.arguments.length > 0);
 }

package/cjs/helpers/regex/extract.js

@@ -36,8 +36,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.getParsedRegex = getParsedRegex;
 exports.getPatternFromNode = getPatternFromNode;
 const regexpp = __importStar(require("@eslint-community/regexpp"));
-const index_js_1 = require("../index.js");
-const ast_js_1 = require("./ast.js");
+const ast_js_1 = require("../ast.js");
+const ast_js_2 = require("./ast.js");
 const flags_js_1 = require("./flags.js");
 function getParsedRegex(node, context) {
     const patternAndFlags = getPatternFromNode(node, context);
@@ -52,7 +52,7 @@ function getParsedRegex(node, context) {
     return null;
 }
 function getPatternFromNode(node, context) {
-    if ((0, ast_js_1.isRegExpConstructor)(node)) {
+    if ((0, ast_js_2.isRegExpConstructor)(node)) {
         const patternOnly = getPatternFromNode(node.arguments[0], context);
         const flags = (0, flags_js_1.getFlags)(node, context);
         if (patternOnly && flags !== null) {
@@ -61,26 +61,26 @@ function getPatternFromNode(node, context) {
             return { pattern: patternOnly.pattern, flags };
         }
     }
-    else if ((0, index_js_1.isRegexLiteral)(node)) {
+    else if ((0, ast_js_1.isRegexLiteral)(node)) {
         return node.regex;
     }
-    else if ((0, index_js_1.isStringLiteral)(node)) {
+    else if ((0, ast_js_1.isStringLiteral)(node)) {
         return { pattern: node.value, flags: '' };
     }
-    else if ((0, index_js_1.isStaticTemplateLiteral)(node)) {
+    else if ((0, ast_js_1.isStaticTemplateLiteral)(node)) {
         return { pattern: node.quasis[0].value.raw, flags: '' };
     }
-    else if ((0, index_js_1.isSimpleRawString)(node)) {
-        return { pattern: (0, index_js_1.getSimpleRawStringValue)(node), flags: '' };
+    else if ((0, ast_js_1.isSimpleRawString)(node)) {
+        return { pattern: (0, ast_js_1.getSimpleRawStringValue)(node), flags: '' };
     }
-    else if ((0, index_js_1.isIdentifier)(node)) {
-        const assignedExpression = (0, index_js_1.getUniqueWriteUsage)(context, node.name, node);
+    else if ((0, ast_js_1.isIdentifier)(node)) {
+        const assignedExpression = (0, ast_js_1.getUniqueWriteUsage)(context, node.name, node);
         if (assignedExpression &&
             assignedExpression.parent?.type === 'VariableDeclarator') {
             return getPatternFromNode(assignedExpression, context);
         }
     }
-    else if ((0, index_js_1.isBinaryPlus)(node)) {
+    else if ((0, ast_js_1.isBinaryPlus)(node)) {
         const left = getPatternFromNode(node.left, context);
         const right = getPatternFromNode(node.right, context);
         if (left && right) {

package/cjs/helpers/regex/group.js

@@ -1,10 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.extractReferences = extractReferences;
-const index_js_1 = require("../index.js");
+const ast_js_1 = require("../ast.js");
 function extractReferences(node) {
     const references = [];
-    if ((0, index_js_1.isStringLiteral)(node)) {
+    if ((0, ast_js_1.isStringLiteral)(node)) {
         const str = node.value;
         const reg = /\$(\d+)|\$<([a-zA-Z]\w*)>/g;
         let match;

package/cjs/helpers/regex/location.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getRegexpLocation = getRegexpLocation;
-const index_js_1 = require("../index.js");
+const ast_js_1 = require("../ast.js");
 const range_js_1 = require("./range.js");
 /**
  * Gets the regexp node location in the ESLint referential
@@ -13,7 +13,7 @@ const range_js_1 = require("./range.js");
  */
 function getRegexpLocation(node, regexpNode, context, offset = [0, 0]) {
     let loc;
-    if ((0, index_js_1.isRegexLiteral)(node) || (0, index_js_1.isStringLiteral)(node)) {
+    if ((0, ast_js_1.isRegexLiteral)(node) || (0, ast_js_1.isStringLiteral)(node)) {
         const source = context.sourceCode;
         const [start] = node.range;
         const [reStart, reEnd] = (0, range_js_1.getRegexpRange)(node, regexpNode);

package/cjs/helpers/regex/range.js

@@ -1,17 +1,18 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getRegexpRange = getRegexpRange;
-const index_js_1 = require("../index.js");
+const collection_js_1 = require("../collection.js");
+const ast_js_1 = require("../ast.js");
 const tokenizer_js_1 = require("./tokenizer.js");
 /**
  * Returns the location of regexpNode relative to the node, which is regexp string or literal. If the computation
  * of location fails, it returns the range of the whole node.
  */
 function getRegexpRange(node, regexpNode) {
-    if ((0, index_js_1.isRegexLiteral)(node)) {
+    if ((0, ast_js_1.isRegexLiteral)(node)) {
         return [regexpNode.start, regexpNode.end];
     }
-    if ((0, index_js_1.isStringLiteral)(node)) {
+    if ((0, ast_js_1.isStringLiteral)(node)) {
         if (node.value === '') {
             return [0, 2];
         }
@@ -30,7 +31,7 @@ function getRegexpRange(node, regexpNode) {
             else {
                 // '|' second empty alternative regex node will have start = 2, end = 2
                 // +1 is to account for string quote
-                return [(0, index_js_1.last)(tokens).range[1] + 1, (0, index_js_1.last)(tokens).range[1] + 1];
+                return [(0, collection_js_1.last)(tokens).range[1] + 1, (0, collection_js_1.last)(tokens).range[1] + 1];
             }
         }
         // regexpNode positions are 1 - based, we need to -1 to report as 0 - based

package/cjs/helpers/regex/rule-template.js

@@ -38,7 +38,8 @@ const regexpp = __importStar(require("@eslint-community/regexpp"));
 const ast_js_1 = require("./ast.js");
 const extract_js_1 = require("./extract.js");
 const location_js_1 = require("./location.js");
-const index_js_1 = require("../index.js");
+const location_js_2 = require("../location.js");
+const parser_services_js_1 = require("../parser-services.js");
 /**
  * Rule template to create regex rules.
  * @param handlers - the regexpp node handlers
@@ -49,7 +50,7 @@ function createRegExpRule(handlers, meta = {}) {
     return {
         meta,
         create(context) {
-            const services = (0, index_js_1.isRequiredParserServices)(context.sourceCode.parserServices)
+            const services = (0, parser_services_js_1.isRequiredParserServices)(context.sourceCode.parserServices)
                 ? context.sourceCode.parserServices
                 : null;
             function checkRegex(node, regExpAST) {
@@ -66,7 +67,7 @@ function createRegExpRule(handlers, meta = {}) {
                 const loc = (0, location_js_1.getRegexpLocation)(node, regexpNode, context, offset);
                 if (loc) {
                     if (secondaryLocations?.length) {
-                        (0, index_js_1.report)(context, { ...rest, loc }, secondaryLocations);
+                        (0, location_js_2.report)(context, { ...rest, loc }, secondaryLocations);
                     }
                     else {
                         context.report({ ...rest, loc });

package/cjs/helpers/sinon.js

@@ -3,43 +3,40 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Sinon = void 0;
-const index_js_1 = require("./index.js");
+exports.isImported = isImported;
+exports.isAssertion = isAssertion;
+exports.isTSAssertion = isTSAssertion;
+const module_js_1 = require("./module.js");
+const module_ts_js_1 = require("./module-ts.js");
 const typescript_1 = __importDefault(require("typescript"));
-var Sinon;
-(function (Sinon) {
-    function isImported(context) {
-        return ((0, index_js_1.getRequireCalls)(context).some(r => r.arguments[0].type === 'Literal' && r.arguments[0].value === 'sinon') || (0, index_js_1.getImportDeclarations)(context).some(i => i.source.value === 'sinon'));
+function isImported(context) {
+    return ((0, module_js_1.getRequireCalls)(context).some(r => r.arguments[0].type === 'Literal' && r.arguments[0].value === 'sinon') || (0, module_js_1.getImportDeclarations)(context).some(i => i.source.value === 'sinon'));
+}
+function isAssertion(context, node) {
+    return isAssertUsage(context, node);
+}
+function isTSAssertion(services, node) {
+    if (node.kind !== typescript_1.default.SyntaxKind.CallExpression) {
+        return false;
     }
-    Sinon.isImported = isImported;
-    function isAssertion(context, node) {
-        return isAssertUsage(context, node);
+    const fqn = (0, module_ts_js_1.getFullyQualifiedNameTS)(services, node);
+    return isFQNAssertion(fqn);
+}
+function isAssertUsage(context, node) {
+    // assert.<expr>(), sinon.assert.<expr>()
+    const fqn = extractFQNforCallExpression(context, node);
+    return isFQNAssertion(fqn);
+}
+function isFQNAssertion(fqn) {
+    if (!fqn) {
+        return false;
     }
-    Sinon.isAssertion = isAssertion;
-    function isTSAssertion(services, node) {
-        if (node.kind !== typescript_1.default.SyntaxKind.CallExpression) {
-            return false;
-        }
-        const fqn = (0, index_js_1.getFullyQualifiedNameTS)(services, node);
-        return isFQNAssertion(fqn);
+    const names = fqn.split('.');
+    return names.length === 3 && names[0] === 'sinon' && names[1] === 'assert';
+}
+function extractFQNforCallExpression(context, node) {
+    if (node.type !== 'CallExpression') {
+        return undefined;
     }
-    Sinon.isTSAssertion = isTSAssertion;
-    function isAssertUsage(context, node) {
-        // assert.<expr>(), sinon.assert.<expr>()
-        const fqn = extractFQNforCallExpression(context, node);
-        return isFQNAssertion(fqn);
-    }
-    function isFQNAssertion(fqn) {
-        if (!fqn) {
-            return false;
-        }
-        const names = fqn.split('.');
-        return names.length === 3 && names[0] === 'sinon' && names[1] === 'assert';
-    }
-    function extractFQNforCallExpression(context, node) {
-        if (node.type !== 'CallExpression') {
-            return undefined;
-        }
-        return (0, index_js_1.getFullyQualifiedName)(context, node);
-    }
-})(Sinon || (exports.Sinon = Sinon = {}));
+    return (0, module_js_1.getFullyQualifiedName)(context, node);
+}

package/cjs/helpers/supertest.js

@@ -3,44 +3,41 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Supertest = void 0;
-const index_js_1 = require("./index.js");
+exports.isImported = isImported;
+exports.isAssertion = isAssertion;
+exports.isTSAssertion = isTSAssertion;
+const module_js_1 = require("./module.js");
+const module_ts_js_1 = require("./module-ts.js");
 const typescript_1 = __importDefault(require("typescript"));
-var Supertest;
-(function (Supertest) {
-    function isImported(context) {
-        return ((0, index_js_1.getRequireCalls)(context).some(r => r.arguments[0].type === 'Literal' && r.arguments[0].value === 'supertest') || (0, index_js_1.getImportDeclarations)(context).some(i => i.source.value === 'supertest'));
+function isImported(context) {
+    return ((0, module_js_1.getRequireCalls)(context).some(r => r.arguments[0].type === 'Literal' && r.arguments[0].value === 'supertest') || (0, module_js_1.getImportDeclarations)(context).some(i => i.source.value === 'supertest'));
+}
+function isAssertion(context, node) {
+    const fqn = extractFQNForCallExpression(context, node);
+    return isFQNAssertion(fqn);
+}
+function isTSAssertion(services, node) {
+    if (node.kind !== typescript_1.default.SyntaxKind.CallExpression) {
+        return false;
     }
-    Supertest.isImported = isImported;
-    function isAssertion(context, node) {
-        const fqn = extractFQNForCallExpression(context, node);
-        return isFQNAssertion(fqn);
+    const fqn = (0, module_ts_js_1.getFullyQualifiedNameTS)(services, node);
+    return isFQNAssertion(fqn);
+}
+function isFQNAssertion(fqn) {
+    if (!fqn) {
+        return false;
     }
-    Supertest.isAssertion = isAssertion;
-    function isTSAssertion(services, node) {
-        if (node.kind !== typescript_1.default.SyntaxKind.CallExpression) {
-            return false;
-        }
-        const fqn = (0, index_js_1.getFullyQualifiedNameTS)(services, node);
-        return isFQNAssertion(fqn);
+    const names = fqn.split('.');
+    /**
+     * supertest assertions look like `[supertest instance](...).[HTTP verb](...).expect(...)`, typically:
+     * `supertest(application).get('/foo').expect(200)`
+     * hence only the first and third values matter, the second one being an HTTP verb irrelevant for assertion detection
+     */
+    return names.length >= 3 && names[0] === 'supertest' && names[2] === 'expect';
+}
+function extractFQNForCallExpression(context, node) {
+    if (node.type !== 'CallExpression') {
+        return undefined;
     }
-    Supertest.isTSAssertion = isTSAssertion;
-    function isFQNAssertion(fqn) {
-        if (!fqn) {
-            return false;
-        }
-        const names = fqn.split('.');
-        /**
-         * supertest assertions look like `[supertest instance](...).[HTTP verb](...).expect(...)`, typically:
-         * `supertest(application).get('/foo').expect(200)`
-         * hence only the first and third values matter, the second one being an HTTP verb irrelevant for assertion detection
-         */
-        return names.length >= 3 && names[0] === 'supertest' && names[2] === 'expect';
-    }
-    function extractFQNForCallExpression(context, node) {
-        if (node.type !== 'CallExpression') {
-            return undefined;
-        }
-        return (0, index_js_1.getFullyQualifiedName)(context, node);
-    }
-})(Supertest || (exports.Supertest = Supertest = {}));
+    return (0, module_js_1.getFullyQualifiedName)(context, node);
+}

package/cjs/helpers/vitest.js

@@ -3,39 +3,36 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Vitest = void 0;
-const index_js_1 = require("./index.js");
+exports.isImported = isImported;
+exports.isAssertion = isAssertion;
+exports.isTSAssertion = isTSAssertion;
+const module_js_1 = require("./module.js");
+const module_ts_js_1 = require("./module-ts.js");
 const typescript_1 = __importDefault(require("typescript"));
-var Vitest;
-(function (Vitest) {
-    function isImported(context) {
-        return ((0, index_js_1.getRequireCalls)(context).some(r => r.arguments[0].type === 'Literal' && r.arguments[0].value === 'vitest') || (0, index_js_1.getImportDeclarations)(context).some(i => i.source.value === 'vitest'));
+function isImported(context) {
+    return ((0, module_js_1.getRequireCalls)(context).some(r => r.arguments[0].type === 'Literal' && r.arguments[0].value === 'vitest') || (0, module_js_1.getImportDeclarations)(context).some(i => i.source.value === 'vitest'));
+}
+function isAssertion(context, node) {
+    const fullyQualifiedName = extractFQNforCallExpression(context, node);
+    return isFQNAssertion(fullyQualifiedName);
+}
+function isTSAssertion(services, node) {
+    if (node.kind !== typescript_1.default.SyntaxKind.CallExpression) {
+        return false;
     }
-    Vitest.isImported = isImported;
-    function isAssertion(context, node) {
-        const fullyQualifiedName = extractFQNforCallExpression(context, node);
-        return isFQNAssertion(fullyQualifiedName);
+    const fqn = (0, module_ts_js_1.getFullyQualifiedNameTS)(services, node);
+    return isFQNAssertion(fqn);
+}
+function isFQNAssertion(fqn) {
+    if (!fqn) {
+        return false;
     }
-    Vitest.isAssertion = isAssertion;
-    function isTSAssertion(services, node) {
-        if (node.kind !== typescript_1.default.SyntaxKind.CallExpression) {
-            return false;
-        }
-        const fqn = (0, index_js_1.getFullyQualifiedNameTS)(services, node);
-        return isFQNAssertion(fqn);
+    const validAssertionCalls = ['vitest.expect', 'vitest.expectTypeOf', 'vitest.assertType'];
+    return validAssertionCalls.some(callPrefix => fqn.startsWith(callPrefix));
+}
+function extractFQNforCallExpression(context, node) {
+    if (node.type !== 'CallExpression') {
+        return undefined;
     }
-    Vitest.isTSAssertion = isTSAssertion;
-    function isFQNAssertion(fqn) {
-        if (!fqn) {
-            return false;
-        }
-        const validAssertionCalls = ['vitest.expect', 'vitest.expectTypeOf', 'vitest.assertType'];
-        return validAssertionCalls.some(callPrefix => fqn.startsWith(callPrefix));
-    }
-    function extractFQNforCallExpression(context, node) {
-        if (node.type !== 'CallExpression') {
-            return undefined;
-        }
-        return (0, index_js_1.getFullyQualifiedName)(context, node);
-    }
-})(Vitest || (exports.Vitest = Vitest = {}));
+    return (0, module_js_1.getFullyQualifiedName)(context, node);
+}