ember-inspector 4.13.1 → 4.15.0

package/tests/unit/resizable-columns-test.js

@@ -82,34 +82,34 @@ module('Unit | Lib | ResizableColumns', function (hooks) {
     assert.strictEqual(
       resizableColumns.columns[0].width,
       5,
-      'first column should have the correct width'
+      'first column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[1].width,
       10,
-      'second column should have the correct width'
+      'second column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[2].width,
       15,
-      'last column should have the correct width'
+      'last column should have the correct width',
     );
 
     resizableColumns.updateColumnWidth('1', 15);
     assert.strictEqual(
       resizableColumns.columns[0].width,
       15,
-      'first column should have the correct width'
+      'first column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[1].width,
       10,
-      'second column should have the correct width'
+      'second column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[2].width,
       5,
-      'last column should have the correct width'
+      'last column should have the correct width',
     );
 
     // Check if it caches the updated widths
@@ -118,34 +118,34 @@ module('Unit | Lib | ResizableColumns', function (hooks) {
     assert.strictEqual(
       resizableColumns.columns[0].width,
       15,
-      'first column should have the correct width'
+      'first column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[1].width,
       10,
-      'second column should have the correct width'
+      'second column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[2].width,
       5,
-      'last column should have the correct width'
+      'last column should have the correct width',
     );
 
     resizableColumns.resetWidths();
     assert.strictEqual(
       resizableColumns.columns[0].width,
       10,
-      'first column should have the correct width'
+      'first column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[1].width,
       10,
-      'second column should have the correct width'
+      'second column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[2].width,
       10,
-      'last column should have the correct width'
+      'last column should have the correct width',
     );
 
     // Table width upate
@@ -153,17 +153,17 @@ module('Unit | Lib | ResizableColumns', function (hooks) {
     assert.strictEqual(
       resizableColumns.columns[0].width,
       5,
-      'first column should have the correct width'
+      'first column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[1].width,
       5,
-      'second column should have the correct width'
+      'second column should have the correct width',
     );
     assert.strictEqual(
       resizableColumns.columns[2].width,
       5,
-      'last column should have the correct width'
+      'last column should have the correct width',
     );
   });
 
@@ -173,12 +173,12 @@ module('Unit | Lib | ResizableColumns', function (hooks) {
     assert.strictEqual(
       this.options.storage.keys().length,
       1,
-      'Only uses one key'
+      'Only uses one key',
     );
     assert.strictEqual(
       this.options.storage.keys()[0],
-      'list__my-key',
-      'Uses the correct key'
+      'list-my-key',
+      'Uses the correct key',
     );
   });
 
@@ -188,59 +188,62 @@ module('Unit | Lib | ResizableColumns', function (hooks) {
     resizableColumns.build();
 
     assert.deepEqual(
-      resizableColumns.columns.filterBy('visible').mapBy('id'),
+      resizableColumns.columns
+        .filter((col) => col.visible)
+        .map((col) => col.id),
       ['1', '2'],
-      'shows/hides according to schema'
+      'shows/hides according to schema',
+    );
+    assert.deepEqual(
+      resizableColumns.getColumnVisibility().map((col) => col.visible),
+      [true, true, false],
     );
-    assert.deepEqual(resizableColumns.getColumnVisibility().mapBy('visible'), [
-      true,
-      true,
-      false,
-    ]);
 
     resizableColumns.toggleVisibility('3');
     assert.deepEqual(
-      resizableColumns.columns.filterBy('visible').mapBy('id'),
+      resizableColumns.columns
+        .filter((col) => col.visible)
+        .map((col) => col.id),
       ['1', '2', '3'],
-      'toggles the third column correctly'
+      'toggles the third column correctly',
+    );
+    assert.deepEqual(
+      resizableColumns.getColumnVisibility().map((col) => col.visible),
+      [true, true, true],
     );
-    assert.deepEqual(resizableColumns.getColumnVisibility().mapBy('visible'), [
-      true,
-      true,
-      true,
-    ]);
 
     resizableColumns.toggleVisibility('1');
     assert.deepEqual(
-      resizableColumns.columns.filterBy('visible').mapBy('id'),
+      resizableColumns.columns
+        .filter((col) => col.visible)
+        .map((col) => col.id),
       ['2', '3'],
-      'toggles the first column correctly'
+      'toggles the first column correctly',
+    );
+    assert.deepEqual(
+      resizableColumns.getColumnVisibility().map((col) => col.visible),
+      [false, true, true],
     );
-    assert.deepEqual(resizableColumns.getColumnVisibility().mapBy('visible'), [
-      false,
-      true,
-      true,
-    ]);
 
     // Confirm correct caching
     resizableColumns = new ResizableColumns(this.options);
     resizableColumns.build();
     assert.deepEqual(
-      resizableColumns.columns.filterBy('visible').mapBy('id'),
+      resizableColumns.columns
+        .filter((col) => col.visible)
+        .map((col) => col.id),
       ['2', '3'],
-      'caching overrides schema visibility settings'
+      'caching overrides schema visibility settings',
+    );
+    assert.deepEqual(
+      resizableColumns.getColumnVisibility().map((col) => col.visible),
+      [false, true, true],
     );
-    assert.deepEqual(resizableColumns.getColumnVisibility().mapBy('visible'), [
-      false,
-      true,
-      true,
-    ]);
   });
 
   test("resets cache correctly if schema doesn't match cache", function (assert) {
-    assert.expect(1);
     this.options.storage.removeItem = (key) => {
-      assert.strictEqual(key, 'list__my-key', 'cache was cleared');
+      assert.strictEqual(key, 'list-my-key', 'cache was cleared');
     };
     let resizableColumns = new ResizableColumns(this.options);
     resizableColumns.build();
@@ -257,10 +260,9 @@ module('Unit | Lib | ResizableColumns', function (hooks) {
 
   test('clears expired cache', function (assert) {
     let sixtyDaysAgo = 1000 * 60 * 60 * 24 * 30 * 2;
-    storage['list__my-key'] = { updatedAt: Date.now() - sixtyDaysAgo };
-    assert.expect(1);
+    storage['list-my-key'] = { updatedAt: Date.now() - sixtyDaysAgo };
     this.options.storage.removeItem = (key) => {
-      assert.strictEqual(key, 'list__my-key', 'cache was cleared');
+      assert.strictEqual(key, 'list-my-key', 'cache was cleared');
     };
     let resizableColumns = new ResizableColumns(this.options);
     resizableColumns.build();

package/tests/unit/utils/parse-text-test.js

@@ -7,18 +7,18 @@ module('Unit | Utility | parseText', function () {
     assert.strictEqual(
       parseText('foo'),
       'foo',
-      'does not add quotes for string'
+      'does not add quotes for string',
     );
     assert.strictEqual(
       parseText('"foo"'),
       'foo',
-      'removes quotes when simple string is already wrapped in quotes'
+      'removes quotes when simple string is already wrapped in quotes',
     );
     assert.strictEqual(parseText('1'), 1);
     assert.strictEqual(
       parseText('"{"name":"teddy"}"'),
       '{"name":"teddy"}',
-      'removes quotes around JSON strings'
+      'removes quotes around JSON strings',
     );
   });
 });

package/tests/unit/utils/search-match-test.js

@@ -5,27 +5,27 @@ module('Unit | Utility | searchMatch', function () {
   test('searchMatch returns the correct results', function (assert) {
     assert.ok(
       searchMatch('something-component-test', 'something'),
-      'simple search with dash in text'
+      'simple search with dash in text',
     );
 
     assert.ok(
       searchMatch('something-component-test', 'something-comp'),
-      'content with dash; query with dash'
+      'content with dash; query with dash',
     );
 
     assert.ok(
       searchMatch('something-component-test', 'somethingcomp'),
-      'content with dash; query without dash'
+      'content with dash; query without dash',
     );
 
     assert.ok(
       searchMatch('Something-component-test', 'somethingComp'),
-      'content with dash and capital; query with capital and without dash'
+      'content with dash and capital; query with capital and without dash',
     );
 
     assert.notOk(
       searchMatch('Something-component-test', 'xxx'),
-      'match not found'
+      'match not found',
     );
   });
 });

package/tests/unit/utils/type-check-test.js

@@ -0,0 +1,27 @@
+import { module, test } from 'qunit';
+import TypeCheckImport from 'ember-debug/type-check';
+let inspect;
+
+module('Unit | Utility | type-check', function (hooks) {
+  hooks.before(async function () {
+    inspect = (await TypeCheckImport).inspect;
+  });
+
+  test('inspect | An POJO with Symbols is correctly transformed into preview', async function (assert) {
+    let symbol = Symbol('test');
+    let symbolValue = Symbol('value');
+
+    let inspected = {
+      [symbol]: 'Symbol Value',
+      symbolVal: symbolValue,
+    };
+
+    let obj = inspect(inspected);
+
+    assert.deepEqual(
+      obj,
+      '{ symbolVal: Symbol(value) }',
+      'object is in expected shape',
+    );
+  });
+});

package/tsconfig.json

@@ -5,6 +5,7 @@
     // layout, which is not resolvable with the Node resolution algorithm, to
     // work with TypeScript.
     "baseUrl": ".",
+    "lib": ["ES2023", "DOM"],
     "paths": {
       "ember-debug/deps/*": ["node_modules/*"],
       "ember-debug/*": ["ember_debug/*"],
@@ -15,7 +16,8 @@
       "ui/test-support": ["lib/ui/addon-test-support"],
       "ui/test-support/*": ["lib/ui/addon-test-support/*"],
       "*": ["types/*"]
-    }
+    },
+    "types": ["chrome", "./node_modules/ember-source/types/stable"]
   },
   "include": ["app/**/*", "tests/**/*", "types/**/*", "lib/ui/**/*"]
 }

package/types/ember-inspector/index.d.ts

@@ -3,7 +3,8 @@ import Ember from 'ember';
 declare global {
   // Prevents ESLint from "fixing" this via its auto-fix to turn it into a type
   // alias (e.g. after running any Ember CLI generator)
-  // eslint-disable-next-line @typescript-eslint/no-empty-interface
+
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   interface Array<T> extends Ember.ArrayPrototypeExtensions<T> {}
   // interface Function extends Ember.FunctionPrototypeExtensions {}
 }

package/types/global.d.ts

@@ -1,7 +1 @@
-// Types for compiled templates
-declare module 'ember-inspector/templates/*' {
-  import { TemplateFactory } from 'ember-cli-htmlbars';
-
-  const tmpl: TemplateFactory;
-  export default tmpl;
-}
+import '@glint/environment-ember-loose';

package/.eslintignore

@@ -1,33 +0,0 @@
-# unconventional js
-/blueprints/*/files/
-/vendor/
-
-# compiled output
-/dist/
-/tmp/
-
-# dependencies
-/bower_components/
-/node_modules/
-
-# misc
-/coverage/
-!.*
-.*/
-.eslintcache
-
-# ember-try
-/.node_modules.ember-try/
-/bower.json.ember-try
-/npm-shrinkwrap.json.ember-try
-/package.json.ember-try
-/package-lock.json.ember-try
-/yarn.lock.ember-try
-
-# ember-inspector specific
-/dist_prev/
-/skeletons/
-/ember_debug/vendor/startup-wrapper.js
-
-# Safari build
-/Ember Inspector/

package/.eslintrc.js

@@ -1,86 +0,0 @@
-'use strict';
-
-module.exports = {
-  root: true,
-  parser: '@babel/eslint-parser',
-  parserOptions: {
-    ecmaVersion: 2020,
-    sourceType: 'module',
-    ecmaFeatures: {
-      legacyDecorators: true,
-    },
-  },
-  plugins: ['ember'],
-  extends: [
-    'eslint:recommended',
-    'plugin:ember/recommended',
-    'plugin:prettier/recommended',
-  ],
-  env: {
-    browser: true,
-  },
-  globals: {
-    basicContext: false,
-    require: false,
-    requireModule: false,
-  },
-  rules: {
-    'no-prototype-builtins': 'off',
-
-    'ember/no-jquery': 'error',
-
-    // Temporarily turn these off
-    'ember/classic-decorator-hooks': 'off',
-    'ember/classic-decorator-no-classic-methods': 'off',
-    'ember/no-classic-classes': 'off',
-    'ember/no-classic-components': 'off',
-    'ember/no-computed-properties-in-native-classes': 'off',
-    'ember/no-get': 'off',
-
-    // Best practice
-    'no-duplicate-imports': 'error',
-    'ember/no-mixins': 'error',
-  },
-  overrides: [
-    // node files
-    {
-      files: [
-        './.eslintrc.js',
-        './.prettierrc.js',
-        './.stylelintrc.js',
-        './.template-lintrc.js',
-        './ember-cli-build.js',
-        './testem.js',
-        './blueprints/*/index.js',
-        './config/**/*.js',
-        './lib/*/index.js',
-        './scripts/**/*.js',
-        './server/**/*.js',
-      ],
-      excludedFiles: ['app/**'],
-      parserOptions: {
-        sourceType: 'script',
-      },
-      env: {
-        browser: false,
-        node: true,
-      },
-      plugins: ['node'],
-      extends: ['plugin:node/recommended'],
-      rules: {
-        // this can be removed once the following is fixed
-        // https://github.com/mysticatea/eslint-plugin-node/issues/77
-        'node/no-unpublished-require': 'off',
-      },
-    },
-    {
-      // test files
-      files: ['tests/**/*-test.{js,ts}'],
-      extends: ['plugin:qunit/recommended'],
-      rules: {
-        'qunit/no-conditional-assertions': 'off',
-        'qunit/no-early-return': 'off',
-      },
-    },
-  ],
-};

package/app/components/list-content.js

@@ -1,130 +0,0 @@
-import { action, computed } from '@ember/object';
-import { inject as service } from '@ember/service';
-import Component from '@ember/component';
-import { htmlSafe } from '@ember/template';
-import Evented from '@ember/object/evented';
-import { schedule } from '@ember/runloop';
-
-/**
- * Base list view config
- *
- * @module Components
- * @extends Component
- * @class List
- * @namespace Components
- */
-export default class ListContent extends Component.extend(Evented) {
-  /**
-   * The layout service. Used to observe the app's content height.
-   *
-   * @property layoutService
-   * @type {Service}
-   */
-  @service('layout') layoutService;
-
-  constructor() {
-    super(...arguments);
-
-    /**
-     * Array of objects representing the columns to render
-     * and their corresponding widths. This array is passed
-     * through the template.
-     *
-     * Each item in the array has `width` and `id` properties.
-     *
-     * @property columns
-     * @type {Array}
-     */
-    this.columns = [];
-  }
-
-  /**
-   * Hook called when content element is inserted.
-   *
-   * @method elementInserted
-   */
-  @action
-  elementInserted() {
-    schedule('afterRender', this, this.setupHeight);
-  }
-
-  /**
-   * Set up the content height and listen to any updates to that property.
-   *
-   * @method setupHeight
-   */
-  @action
-  setupHeight() {
-    this.set('contentHeight', this.get('layoutService.contentHeight'));
-    this.layoutService.on(
-      'content-height-update',
-      this,
-      this.updateContentHeight
-    );
-  }
-
-  /**
-   * Triggered whenever the app's content height changes. This usually happens
-   * when the window is resized. Once we detect a change we:
-   * 1. Update this component's `contentHeight` property and consequently its `height` style.
-   * 2. Check the previous height. If previous height was zero that means the inspector launched
-   * in the background and was therefore not visible. Go to (a). Otherwise skip (a).
-   *   a. Rerender the component. This is needed because smoke and mirrors doesn't know that the content height
-   *   has changed.
-   *
-   * @method updateContentHeight
-   * @param  {Number} height The app's new content height
-   */
-  updateContentHeight(height) {
-    let previousHeight = this.contentHeight;
-    this.set('contentHeight', height);
-    if (previousHeight === 0 && height > 0) {
-      this.rerender();
-    }
-  }
-
-  /**
-   * Hook called before destruction. Clean up events listeners.
-   *
-   * @method willDestroy
-   */
-  willDestroy() {
-    this.layoutService.off(
-      'content-height-update',
-      this,
-      this.updateContentHeight
-    );
-    return super.willDestroy(...arguments);
-  }
-
-  @computed('height')
-  get style() {
-    return htmlSafe(`height:${this.height}px`);
-  }
-
-  /**
-   * Number passed from `list`. Indicates the header height
-   * in pixels.
-   *
-   * @property headerHeight
-   * @type {Number}
-   */
-  headerHeight = null;
-
-  /**
-   * @property height
-   * @type {Integer}
-   */
-  @computed('contentHeight', 'headerHeight')
-  get height() {
-    let headerHeight = this.headerHeight;
-    let contentHeight = this.contentHeight;
-
-    // In testing list-view is created before `contentHeight` is set
-    // which will trigger an exception
-    if (!contentHeight) {
-      return 1;
-    }
-    return contentHeight - headerHeight;
-  }
-}