ember-inspector 4.13.1 → 4.15.0

package/tests/acceptance/whats-new-test.js

@@ -6,7 +6,7 @@ import { setupTestAdapter } from '../test-adapter';
 
 function urlFor(ref) {
   return `https://raw.githubusercontent.com/emberjs/ember-inspector/${encodeURIComponent(
-    ref
+    ref,
   )}/CHANGELOG.md`;
 }
 
@@ -17,7 +17,7 @@ function generateContent(main = false) {
 
   if (main) {
     content.push(`
-## [Unreleased](https://github.com/emberjs/ember-inspector/tree/HEAD)
+## Release [Unreleased](https://github.com/emberjs/ember-inspector/tree/HEAD)
 
 **Merged pull requests:**
 
@@ -25,7 +25,7 @@ function generateContent(main = false) {
   }
 
   content.push(`
-## v4.5.3 (2021-11-18)
+## Release (2021-11-18)
 
 [Full Changelog](https://emberjs.com)
 
@@ -33,7 +33,7 @@ function generateContent(main = false) {
 
 - Stuff
 
-## v4.5.2 (2021-11-17)
+## Release (2021-11-17)
 
 [Full Changelog](https://emberjs.com)
 
@@ -76,7 +76,7 @@ module('Whats New', function (outer) {
 
     test('Changelog is parsed and displayed', async function (assert) {
       this.server = new Pretender(function () {
-        this.get(urlFor('v4.5.3'), () => [
+        this.get(urlFor('v4.5.3-ember-inspector'), () => [
           200,
           { 'Content-Type': 'text/plain' },
           generateContent(),
@@ -91,14 +91,14 @@ module('Whats New', function (outer) {
 
       assert.strictEqual(
         find('.whats-new h2').textContent,
-        'v4.5.3 (2021-11-18)',
-        'correct section of markdown is rendered'
+        'Release (2021-11-18)',
+        'correct section of markdown is rendered',
       );
     });
 
     test('Error message is displayed on request failure', async function (assert) {
       this.server = new Pretender(function () {
-        this.get(urlFor('v4.5.3'), () => [404, {}, '']);
+        this.get(urlFor('v4.5.3-ember-inspector'), () => [404, {}, '']);
       });
 
       await visit('/info/whats-new');
@@ -116,7 +116,7 @@ module('Whats New', function (outer) {
 
     test('Changelog is parsed and displayed', async function (assert) {
       this.server = new Pretender(function () {
-        this.get(urlFor('main'), () => [
+        this.get(urlFor('release-preview'), () => [
           200,
           { 'Content-Type': 'text/plain' },
           generateContent(true),
@@ -132,13 +132,13 @@ module('Whats New', function (outer) {
       assert.strictEqual(
         find('.whats-new h2 a').text,
         'Unreleased',
-        'correct section of markdown is rendered'
+        'correct section of markdown is rendered',
       );
     });
 
     test('Error message is displayed on request failure', async function (assert) {
       this.server = new Pretender(function () {
-        this.get(urlFor('main'), () => [404, {}, '']);
+        this.get(urlFor('release-preview'), () => [404, {}, '']);
       });
 
       await visit('/info/whats-new');

package/tests/ember_debug/container-debug-test.js

@@ -3,22 +3,13 @@ import { settled, visit, waitUntil } from '@ember/test-helpers';
 import { A as emberA } from '@ember/array';
 
 import EmberDebug from 'ember-debug/main';
-import Port from 'ember-debug/port';
 import setupEmberDebugTest from '../helpers/setup-ember-debug-test';
 
 // TODO: Figure out why these tests are flaky and enable them again
 module('Ember Debug - Container', function (hooks) {
   let name, message;
 
-  setupEmberDebugTest(hooks, {
-    Port: class extends Port {
-      init() {}
-      send(n, m) {
-        name = n;
-        message = m;
-      }
-    },
-  });
+  setupEmberDebugTest(hooks);
 
   skip('#getTypes', async function t(assert) {
     await visit('/simple');
@@ -30,13 +21,13 @@ module('Ember Debug - Container', function (hooks) {
       function () {
         return name === 'container:types';
       },
-      { timeout: 3000 }
+      { timeout: 3000 },
     );
 
     assert.strictEqual(name, 'container:types');
     let types = emberA(message.types);
-    assert.ok(types.findBy('name', 'controller'));
-    assert.ok(types.findBy('name', 'route'));
+    assert.ok(types.find((x) => x.name === 'controller'));
+    assert.ok(types.find((x) => x.name === 'route'));
   });
 
   skip('#getInstances', async function t(assert) {
@@ -49,7 +40,7 @@ module('Ember Debug - Container', function (hooks) {
 
     assert.strictEqual(name, 'container:instances');
     let instances = emberA(message.instances);
-    assert.ok(instances.findBy('name', 'simple'));
+    assert.ok(instances.find((x) => x.name === 'simple'));
   });
 
   skip('#getInstances on a non existing type', async function t(assert) {

package/tests/ember_debug/deprecation-debug-test.js

@@ -4,10 +4,16 @@ import Route from '@ember/routing/route';
 import RSVP from 'rsvp';
 import { run } from '@ember/runloop';
 import { module, test } from 'qunit';
-import EmberDebug from 'ember-debug/main';
 import setupEmberDebugTest from '../helpers/setup-ember-debug-test';
 
+import EmberDebugImport from 'ember-debug/main';
+let EmberDebug;
+
 module('Ember Debug - Deprecation', function (hooks) {
+  hooks.before(async function () {
+    EmberDebug = (await EmberDebugImport).default;
+  });
+
   setupEmberDebugTest(hooks);
 
   hooks.beforeEach(async function () {
@@ -35,6 +41,7 @@ module('Ember Debug - Deprecation', function (hooks) {
 
     this.owner.register(
       'route:application',
+      // eslint-disable-next-line ember/no-classic-classes
       Route.extend({
         setupController() {
           EmberDebug.IGNORE_DEPRECATIONS = false;
@@ -59,9 +66,10 @@ module('Ember Debug - Deprecation', function (hooks) {
           });
           EmberDebug.IGNORE_DEPRECATIONS = true;
         },
-      })
+      }),
     );
 
+    // eslint-disable-next-line ember/no-runloop
     run(EmberDebug.port, 'trigger', 'deprecation:watch');
 
     await visit('/');
@@ -74,7 +82,7 @@ module('Ember Debug - Deprecation', function (hooks) {
     assert.strictEqual(
       deprecation.sources.length,
       2,
-      'Correctly separated by source'
+      'Correctly separated by source',
     );
 
     deprecation = deprecations[1];
@@ -87,14 +95,14 @@ module('Ember Debug - Deprecation', function (hooks) {
   });
 
   test('Warns once about deprecations', async function t(assert) {
-    assert.expect(2);
     let count = 0;
+    // eslint-disable-next-line ember/no-runloop
     run(EmberDebug.port, 'trigger', 'deprecation:watch');
     EmberDebug.port.adapter.reopen({
       warn(message) {
         assert.strictEqual(
           message,
-          'Deprecations were detected, see the Ember Inspector deprecations tab for more details.'
+          'Deprecations were detected, see the Ember Inspector deprecations tab for more details.',
         );
         assert.strictEqual(++count, 1, 'Warns once');
       },
@@ -102,6 +110,7 @@ module('Ember Debug - Deprecation', function (hooks) {
 
     this.owner.register(
       'route:application',
+      // eslint-disable-next-line ember/no-classic-classes
       Route.extend({
         setupController() {
           EmberDebug.IGNORE_DEPRECATIONS = false;
@@ -119,7 +128,7 @@ module('Ember Debug - Deprecation', function (hooks) {
           });
           EmberDebug.IGNORE_DEPRECATIONS = true;
         },
-      })
+      }),
     );
 
     await visit('/');

package/tests/ember_debug/ember-data-test.js

@@ -1,8 +1,10 @@
 import { module, test } from 'qunit';
-import EmberDebug from 'ember-debug/main';
 import { setupApplicationTest } from 'ember-qunit';
 import EmberObject from '@ember/object';
 
+import EmberDebugImport from 'ember-debug/main';
+let EmberDebug = EmberDebugImport;
+
 class Adapter extends EmberObject {
   watchModelTypes() {}
 }
@@ -10,6 +12,10 @@ class Adapter extends EmberObject {
 module('Ember Debug - Data', function (hooks) {
   setupApplicationTest(hooks);
 
+  hooks.before(async function () {
+    EmberDebug = (await EmberDebug).default;
+  });
+
   hooks.beforeEach(function () {
     this.owner.register('data-adapter:main', Adapter);
     EmberDebug.isTesting = true;

package/tests/ember_debug/ember-debug-test.js

@@ -1,38 +1,39 @@
 import EmberObject from '@ember/object';
 import { module, test } from 'qunit';
 import setupEmberDebugTest from '../helpers/setup-ember-debug-test';
-import EmberDebug from 'ember-debug/main';
-import Port from 'ember-debug/port';
 import { settled } from '@ember/test-helpers';
 
+import EmberDebugImport from 'ember-debug/main';
+let EmberDebug;
+
 module('Ember Debug', function (hooks) {
   let name, adapter;
 
-  setupEmberDebugTest(hooks, {
-    Port: class extends Port {
-      init() {}
-      send(n) {
-        name = n;
-      }
-    },
+  hooks.before(async function () {
+    EmberDebug = (await EmberDebugImport).default;
   });
 
+  setupEmberDebugTest(hooks);
+
   hooks.beforeEach(async function () {
     adapter = EmberDebug.port.adapter;
+    EmberDebug.port.reopen({
+      send(n) {
+        name = n;
+      },
+    });
   });
 
   function cantSend(obj, assert) {
     try {
       EmberDebug.inspect(obj);
       assert.ok(false);
-    } catch (e) {
+    } catch {
       // Intentionally empty
     }
   }
 
   test('EmberDebug#inspect sends inspectable objects', function (assert) {
-    assert.expect(2);
-
     let obj = EmberObject.create();
     EmberDebug.inspect(obj);
     assert.strictEqual(name, 'objectInspector:updateObject');
@@ -46,7 +47,6 @@ module('Ember Debug', function (hooks) {
   });
 
   test('Errors are caught and handled by EmberDebug', async function t(assert) {
-    assert.expect(1);
     const error = new Error('test error');
     EmberDebug.port.on('test:errors', () => {
       throw error;