ember-inspector 4.13.1 → 4.15.0

package/tests/ember_debug/object-inspector-test.js

@@ -1,31 +1,36 @@
-/* eslint-disable ember/avoid-leaking-state-in-ember-objects, ember/no-new-mixins */
+/* eslint-disable ember/avoid-leaking-state-in-ember-objects, ember/no-classic-classes, ember/no-new-mixins, ember/no-runloop */
 import { find, visit } from '@ember/test-helpers';
 import Mixin from '@ember/object/mixin';
+// eslint-disable-next-line ember/no-classic-components
 import Component from '@ember/component';
 import { inspect } from '@ember/debug';
 import { run } from '@ember/runloop';
 import { guidFor } from '@ember/object/internals';
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import EmberObject, { computed } from '@ember/object';
 import MutableArray from '@ember/array/mutable';
 import ArrayProxy from '@ember/array/proxy';
 import ObjectProxy from '@ember/object/proxy';
-import Service from '@ember/service';
+import Service, { inject as service } from '@ember/service';
 import { VERSION } from '@ember/version';
 import { tracked } from '@glimmer/tracking';
 import { module, skip, test } from 'qunit';
 import { hbs } from 'ember-cli-htmlbars';
 import require from 'require';
 import hasEmberVersion from '@ember/test-helpers/has-ember-version';
-import { compareVersion } from 'ember-debug/utils/version';
-import EmberDebug from 'ember-debug/main';
+import { compareVersion } from 'ember-debug/version';
 import setupEmberDebugTest from '../helpers/setup-ember-debug-test';
 import EmberRoute from '@ember/routing/route';
 import Controller from '@ember/controller';
+import { setOwner } from '@ember/application';
+
+import EmberDebugImport from 'ember-debug/main';
+let EmberDebug = EmberDebugImport;
 
 const GlimmerComponent = (function () {
   try {
     return require('@glimmer/component').default;
-  } catch (e) {
+  } catch {
     // ignore, return undefined
   }
 })();
@@ -74,6 +79,10 @@ async function inspectObject(object) {
 }
 
 module('Ember Debug - Object Inspector', function (hooks) {
+  hooks.before(async function () {
+    EmberDebug = (await EmberDebugImport).default;
+  });
+
   setupEmberDebugTest(hooks, {
     routes() {
       this.route('simple');
@@ -89,8 +98,8 @@ module('Ember Debug - Object Inspector', function (hooks) {
       'template:application',
       hbs(
         '<div class="application" style="line-height: normal;">{{outlet}}</div>',
-        { moduleName: 'my-app/templates/application.hbs' }
-      )
+        { moduleName: 'my-app/templates/application.hbs' },
+      ),
     );
     this.owner.register('route:simple', EmberRoute);
     this.owner.register('component:x-simple', Component);
@@ -99,7 +108,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
       hbs`
       {{! template-lint-disable}}
       Simple <Input class="simple-input"/> {{x-simple class="simple-view"}}
-      `
+      `,
     );
 
     objectInspector = EmberDebug.objectInspector;
@@ -138,7 +147,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
     assert.strictEqual(
       firstDetail.properties.length,
       4,
-      'methods are included'
+      'methods are included',
     );
 
     let idProperty = firstDetail.properties[0];
@@ -185,7 +194,6 @@ module('Ember Debug - Object Inspector', function (hooks) {
     }
 
     class Parent {
-      // eslint-disable-next-line constructor-super
       constructor(param) {
         Object.assign(this, param);
       }
@@ -236,7 +244,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
     assert.strictEqual(
       firstDetail.properties.length,
       6,
-      'methods are included'
+      'methods are included',
     );
 
     let objectWithTrackedProperty = firstDetail.properties[0];
@@ -370,7 +378,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
     expectedMixinNames.forEach((expectedMixinName, i) => {
       assert.ok(
         mixinNames[i].includes(expectedMixinName),
-        `${mixinNames[i]} : ${expectedMixinName}`
+        `${mixinNames[i]} : ${expectedMixinName}`,
       );
     });
   });
@@ -463,7 +471,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
     assert.strictEqual(
       details[0].properties.length,
       1,
-      'should not show mixin properties'
+      'should not show mixin properties',
     );
     assert.strictEqual(details[0].properties[0].name, 'ownProp');
 
@@ -471,22 +479,22 @@ module('Ember Debug - Object Inspector', function (hooks) {
     assert.strictEqual(
       details[2].properties.length,
       1,
-      'should only show own mixin properties'
+      'should only show own mixin properties',
     );
     assert.strictEqual(
       details[2].properties[0].value.inspect,
-      inspect('custom1')
+      inspect('custom1'),
     );
 
     assert.strictEqual(details[3].name, 'MyMixin2');
     assert.strictEqual(
       details[3].properties.length,
       1,
-      'should only show own mixin properties'
+      'should only show own mixin properties',
     );
     assert.strictEqual(
       details[3].properties[0].value.inspect,
-      inspect('custom2')
+      inspect('custom2'),
     );
   });
 
@@ -648,7 +656,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
       });
     });
 
-    assert.strictEqual(inspected.get('name'), 'Alex');
+    assert.strictEqual(inspected.name, 'Alex');
 
     assert.strictEqual(message.property, 'name');
     assert.strictEqual(message.value.inspect, inspect('Alex'));
@@ -674,9 +682,9 @@ module('Ember Debug - Object Inspector', function (hooks) {
       });
     });
 
-    assert.strictEqual(inspected.get('date').getFullYear(), 2015);
-    assert.strictEqual(inspected.get('date').getMonth(), 0);
-    assert.strictEqual(inspected.get('date').getDate(), 1);
+    assert.strictEqual(inspected.date.getFullYear(), 2015);
+    assert.strictEqual(inspected.date.getMonth(), 0);
+    assert.strictEqual(inspected.date.getDate(), 1);
 
     assert.strictEqual(message.property, 'date');
     assert.strictEqual(message.value.inspect, inspect(newDate));
@@ -746,42 +754,42 @@ module('Ember Debug - Object Inspector', function (hooks) {
     assert.strictEqual(
       message.details[2].properties.length,
       0,
-      'Correctly skips properties'
+      'Correctly skips properties',
     );
 
     assert.strictEqual(message.details[3].name, 'TestObject');
     assert.strictEqual(
       message.details[3].properties.length,
       3,
-      'Correctly merges properties'
+      'Correctly merges properties',
     );
 
     const toString = message.details[3].properties.find(
-      (p) => p.name === 'toString'
+      (p) => p.name === 'toString',
     );
     const hasChildren = message.details[3].properties.find(
-      (p) => p.name === 'hasChildren'
+      (p) => p.name === 'hasChildren',
     );
     const expensiveProperty = message.details[3].properties.find(
-      (p) => p.name === 'expensiveProperty'
+      (p) => p.name === 'expensiveProperty',
     );
     assert.ok(toString, 'has toString');
     assert.ok(hasChildren, 'has hasChildren');
     assert.strictEqual(
       expensiveProperty.name,
       'expensiveProperty',
-      'property name is correct'
+      'property name is correct',
     );
     assert.strictEqual(
       expensiveProperty.value.isCalculated,
       undefined,
-      'Does not calculate expensive properties'
+      'Does not calculate expensive properties',
     );
 
     assert.notStrictEqual(
       message.details[3].name,
       'MixinToSkip',
-      'Correctly skips mixins'
+      'Correctly skips mixins',
     );
   });
 
@@ -846,7 +854,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
 
     assert.ok(
       message.name.includes('ObjectProxy'),
-      'object name should start with <ObjectProxy:'
+      'object name should start with <ObjectProxy:',
     );
 
     assert.strictEqual(message.details[0].name, 'Basic Info');
@@ -861,38 +869,38 @@ module('Ember Debug - Object Inspector', function (hooks) {
     assert.strictEqual(
       message.details[2].properties.length,
       0,
-      'Correctly skips properties'
+      'Correctly skips properties',
     );
 
     assert.strictEqual(message.details[3].name, 'TestObject');
     assert.strictEqual(
       message.details[3].properties.length,
       3,
-      'Correctly merges properties'
+      'Correctly merges properties',
     );
 
     const hasChildren = message.details[3].properties.find(
-      (p) => p.name === 'hasChildren'
+      (p) => p.name === 'hasChildren',
     );
     const expensiveProperty = message.details[3].properties.find(
-      (p) => p.name === 'expensiveProperty'
+      (p) => p.name === 'expensiveProperty',
     );
     assert.strictEqual(hasChildren.name, 'hasChildren');
     assert.strictEqual(
       expensiveProperty.name,
       'expensiveProperty',
-      'property name is correct'
+      'property name is correct',
     );
     assert.strictEqual(
       expensiveProperty.value.isCalculated,
       undefined,
-      'Does not calculate expensive properties'
+      'Does not calculate expensive properties',
     );
 
     assert.notStrictEqual(
       message.details[3].name,
       'MixinToSkip',
-      'Correctly skips mixins'
+      'Correctly skips mixins',
     );
   });
 
@@ -901,17 +909,22 @@ module('Ember Debug - Object Inspector', function (hooks) {
       fooBoo() {
         return true;
       },
-    }).create();
+    });
+
+    this.owner.register('service:test-inspect-service', inspectedService);
 
     let inspected = EmberObject.extend({
-      service: inspectedService,
-    }).create();
+      service: inspectedService.create(),
+      service2: service('test-inspect-service'),
+    }).create(this);
 
     let message = await inspectObject(inspected);
 
     let serializedServiceProperty = message.details[1].properties[0];
+    let serializedService2Property = message.details[1].properties[1];
 
     assert.true(serializedServiceProperty.isService);
+    assert.true(serializedService2Property.isService);
   });
 
   test('Proxy Service should be successfully tagged as service on serialization', async function (assert) {
@@ -962,7 +975,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
 
     assert.ok(
       objectInspector.sentObjects[objectId],
-      'Object successfully retained.'
+      'Object successfully retained.',
     );
 
     await visit('/');
@@ -985,7 +998,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
 
     assert.ok(
       objectInspector.sentObjects[objectId],
-      'Object successfully retained.'
+      'Object successfully retained.',
     );
 
     message = await captureMessage('objectInspector:droppedObject', () => {
@@ -997,7 +1010,6 @@ module('Ember Debug - Object Inspector', function (hooks) {
     assert.deepEqual(message, { objectId });
   });
 
-  // eslint-disable-next-line qunit/require-expect
   test('Properties ending with `Binding` are skipped', async function (assert) {
     let object = EmberObject.create({
       bar: 'test',
@@ -1011,14 +1023,14 @@ module('Ember Debug - Object Inspector', function (hooks) {
       assert.strictEqual(
         props.length,
         2,
-        'Props should be foo and bar without fooBinding'
+        'Props should be foo and bar without fooBinding',
       );
       assert.strictEqual(props[1].name, 'foo');
     } else {
       assert.strictEqual(
         props.length,
         1,
-        'Props should be only bar without fooBinding, in Ember 3.0+'
+        'Props should be only bar without fooBinding, in Ember 3.0+',
       );
     }
     assert.strictEqual(props[0].name, 'bar');
@@ -1058,7 +1070,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
           }
           return 'bar';
         }),
-      }).create()
+      }).create(),
     );
 
     let message = await inspectObject(object);
@@ -1219,6 +1231,59 @@ module('Ember Debug - Object Inspector', function (hooks) {
         'inspector: updateProperty',
       ]);
     });
+
+    test('Inspected objects pass along their owner they have one', async function (assert) {
+      class Owner {}
+      class Foo {
+        bar = 'baz';
+      }
+
+      let owner = new Owner();
+      let inspected = new Foo();
+      let message = await inspectObject(inspected);
+      let ownerId = guidFor(owner);
+
+      assert.false(
+        message.details.some(({ name }) => name === 'Container'),
+        "Objects without an owner don't report an undefined owner in their last details object",
+      );
+      assert.strictEqual(message.details.length, 2);
+
+      setOwner(inspected, owner);
+
+      message = await inspectObject(inspected);
+
+      assert.strictEqual(
+        message.details.length,
+        3,
+        'Object with owner have an additional details object',
+      );
+
+      assert.strictEqual(
+        message.details.filter(({ name }) => name === 'Container').length,
+        1,
+        'Objects with an owner have exactly one container item in their details',
+      );
+      assert.deepEqual(
+        message.details.at(-1),
+        {
+          id: ownerId,
+          name: 'Container',
+          expand: false,
+          properties: [
+            {
+              name: '__owner__',
+              value: {
+                inspect: `<Owner:${ownerId}>`,
+                objectId: ownerId,
+                type: 'type-owner',
+              },
+            },
+          ],
+        },
+        'the container is the last mixin in the list',
+      );
+    });
   }
 
   // @glimmer/component 1.0 doesn't seem to support 3.4, even though it has the manager API
@@ -1253,7 +1318,7 @@ module('Ember Debug - Object Inspector', function (hooks) {
         `template:components/foo`,
         hbs('text only', {
           moduleName: 'my-app/templates/components/foo.hbs',
-        })
+        }),
       );
       await visit('/simple');
 
@@ -1280,17 +1345,17 @@ module('Ember Debug - Object Inspector', function (hooks) {
       assert.strictEqual(
         properties.indexOf('bounds'),
         -1,
-        'does not contain bounds'
+        'does not contain bounds',
       );
       assert.strictEqual(
         properties.indexOf('element'),
         -1,
-        'does not contain element'
+        'does not contain element',
       );
       assert.strictEqual(
         properties.indexOf('debugName'),
         -1,
-        'does not contain debugName'
+        'does not contain debugName',
       );
     });
   }