ebay-mcp 1.18.0 → 1.18.2

package/build/tools/defineTool.js

@@ -1,11 +1,16 @@
 import { uiArchetypes } from '../tools/ui/archetypes.js';
-import { decodeEffectSchemaSync, z } from '../utils/effectSchema.js';
+import { formatZodIssues } from '../utils/zodIssues.js';
+import { Data } from 'effect';
+import { z } from 'zod';
+/** Tagged failure thrown when tool arguments do not match the tool's input schema. */
+export class ToolInputError extends Data.TaggedError('ToolInputError') {
+}
 /**
  * Erases the compile-time result type from a {@link ToolUiSpec} so the binding can
  * live on the non-generic {@link ToolEntry}, and resolves the archetype's
  * `resourceUri` from the single-source-of-truth {@link uiArchetypes} manifest.
  *
- * The `result as Result` cast is the type-erasure boundary: at runtime `map` only
+ * The `handlerOutput as Result` cast is the type-erasure boundary: at runtime `map` only
  * ever receives the very value its own handler returned, so the cast restores the
  * type the mapper was written and type-checked against.
  */
@@ -13,7 +18,7 @@ function resolveToolUi(ui) {
     return {
         archetype: ui.archetype,
         resourceUri: uiArchetypes[ui.archetype].uri,
-        map: (result) => ui.map(result),
+        map: (handlerOutput) => ui.map(handlerOutput),
     };
 }
 /** Builds the public MCP definition from the richer tool spec. */
@@ -29,14 +34,15 @@ function toDefinition(spec) {
     };
 }
 /**
- * Binds a tool's Effect-backed input shape to its handler so the shape is the single
+ * Binds a tool's Zod input shape to its handler so the shape is the single
  * source of truth for both the advertised MCP schema and the handler's
  * compile-time argument types.
  *
  * The returned {@link ToolEntry} carries a `ToolHandler` that validates raw
- * arguments against the Effect schema before delegating. Re-validating on the
- * SDK path is intentional and cheap: input schemas contain no async refinements,
- * so the second decode is idempotent.
+ * arguments against the shape before delegating, throwing {@link ToolInputError}
+ * on a mismatch. The SDK already validates registered tools, but callers that
+ * bypass it (the dynamic-mode tool runner, `executeTool`) rely on this check.
+ * Input schemas contain no async refinements, so the second parse is idempotent.
  *
  * @param spec - Tool definition, input schema, handler, and optional UI projection.
  * @returns A registry entry whose handler validates args from the schema before execution.
@@ -53,10 +59,19 @@ function toDefinition(spec) {
  */
 export const defineTool = (spec) => {
     const schema = z.object(spec.inputSchema);
-    // Non-async: Effect decode runs synchronously so invalid input rejects via
-    // the caller's `await`, and the handler's returned promise passes straight
+    // Non-async: parsing runs synchronously so invalid input rejects via the
+    // caller's `await`, and the handler's returned promise passes straight
     // through without an extra await layer.
-    const handler = (api, args) => spec.handler(api, decodeEffectSchemaSync(schema, args));
+    const handler = (api, args) => {
+        const parsedArgs = schema.safeParse(args);
+        if (!parsedArgs.success) {
+            throw new ToolInputError({
+                toolName: spec.name,
+                message: `Invalid arguments for ${spec.name}: ${formatZodIssues(parsedArgs.error)}`,
+            });
+        }
+        return spec.handler(api, parsedArgs.data);
+    };
     const formatResult = spec.formatResult;
     return {
         definition: toDefinition(spec),
@@ -64,7 +79,7 @@ export const defineTool = (spec) => {
         ui: spec.ui ? resolveToolUi(spec.ui) : undefined,
         // Registry erases the result/argument types; defineTool checks their relationship here.
         formatResult: formatResult
-            ? (result, args) => formatResult(result, args)
+            ? (handlerOutput, args) => formatResult(handlerOutput, args)
             : undefined,
     };
 };
@@ -105,7 +120,7 @@ export const rawTool = (spec) => {
         ui: spec.ui ? resolveToolUi(spec.ui) : undefined,
         // Registry erases the result/argument types; defineTool checks their relationship here.
         formatResult: formatResult
-            ? (result, args) => formatResult(result, args)
+            ? (handlerOutput, args) => formatResult(handlerOutput, args)
             : undefined,
     };
 };

package/build/tools/registry.js

@@ -106,7 +106,7 @@ export const getToolHandler = (toolName) => handlerByName[toolName];
  *
  * @example
  * ```ts
- * const result = await executeTool(api, 'ebay_get_custom_policies', {});
+ * const customPolicies = await executeTool(api, 'ebay_get_custom_policies', {});
  * ```
  */
 export const executeTool = async (api, toolName, args) => Effect.runPromise(Effect.gen(function* () {
@@ -118,7 +118,7 @@ export const executeTool = async (api, toolName, args) => Effect.runPromise(Effe
         }));
     }
     return yield* Effect.tryPromise({
-        try: () => Promise.resolve(handler(api, args)),
+        try: async () => handler(api, args),
         catch: (error) => error,
     });
 }));

package/build/tools/schemas.js

@@ -1,7 +1,7 @@
-import { z } from '../utils/effectSchema.js';
+import { z } from 'zod';
 import { TimeDurationUnit, RegionType, ShippingCostType, ShippingOptionType, DepositType, RefundMethod, ReturnMethod, ReturnShippingCostPayer, Condition, LengthUnit, WeightUnit, PricingVisibility, FormatType, ListingDuration, LocationType, MerchantLocationStatus, DayOfWeek, ReasonForRefund, FundingModel, MessageReferenceType, FeedbackRating, ReportedItemType, } from '../types/ebayEnums.js';
 /**
- * Reusable Effect-backed schemas for eBay API tool input validation
+ * Reusable Zod schemas for eBay API tool input validation
  *
  * These schemas provide type-safe validation while remaining flexible
  * enough to accept the full complexity of eBay API request objects.

package/build/tools/ui/mapHelpers.js

@@ -86,7 +86,7 @@ export const statusTone = (status) => {
  * strings) to a finite number. Missing or invalid values return `null` so chart
  * mappers can omit the point instead of inventing a zero.
  *
- * @param value - Analytics value leaf from an eBay report response.
+ * @param leaf - Analytics value leaf from an eBay report response.
  * @returns A finite number for chart points, or null for non-numeric input.
  *
  * @example
@@ -94,12 +94,12 @@ export const statusTone = (status) => {
  * toNumber('42');
  * ```
  */
-export const toNumber = (value) => {
-    if (typeof value === 'number') {
-        return Number.isFinite(value) ? value : null;
+export const toNumber = (leaf) => {
+    if (typeof leaf === 'number') {
+        return Number.isFinite(leaf) ? leaf : null;
     }
-    if (typeof value === 'string') {
-        const parsed = Number(value);
+    if (typeof leaf === 'string') {
+        const parsed = Number(leaf);
         return Number.isFinite(parsed) ? parsed : null;
     }
     return null;
@@ -108,7 +108,7 @@ export const toNumber = (value) => {
  * Coerces an untyped JSON leaf to a chart-axis label string, returning `''` for
  * values that have no sensible textual form (objects, `null`, `undefined`).
  *
- * @param value - Analytics dimension leaf from an eBay report response.
+ * @param leaf - Analytics dimension leaf from an eBay report response.
  * @returns A primitive label string, or an empty string when no label is available.
  *
  * @example
@@ -116,12 +116,12 @@ export const toNumber = (value) => {
  * toLabel(7);
  * ```
  */
-export const toLabel = (value) => {
-    if (typeof value === 'string') {
-        return value;
+export const toLabel = (leaf) => {
+    if (typeof leaf === 'string') {
+        return leaf;
     }
-    if (typeof value === 'number' || typeof value === 'boolean') {
-        return String(value);
+    if (typeof leaf === 'number' || typeof leaf === 'boolean') {
+        return String(leaf);
     }
     return '';
 };