ebay-mcp 1.18.0 → 1.18.2

package/README.md

@@ -31,23 +31,11 @@
   <a href="https://mseep.ai/app/yosefhayim-ebay-api-mcp-server"><img src="https://mseep.net/pr/yosefhayim-ebay-api-mcp-server-badge.png" alt="MseeP.ai Security Assessment Badge" height="40" /></a>
 </p>
 
-<p align="center">
-  <strong>English</strong> ·
-  <a href="README.zh-CN.md">简体中文</a> ·
-  <a href="README.es.md">Español</a> ·
-  <a href="README.pt-BR.md">Português (BR)</a> ·
-  <a href="README.ja.md">日本語</a> ·
-  <a href="README.ko.md">한국어</a> ·
-  <a href="README.fr.md">Français</a> ·
-  <a href="README.de.md">Deutsch</a> ·
-  <a href="README.ru.md">Русский</a>
-</p>
-
 ---
 
 **eBay MCP** is a local [Model Context Protocol](https://modelcontextprotocol.io) server that connects AI assistants — [Claude Desktop](https://claude.ai/download), [Claude Code](https://code.claude.com/docs/en/overview), [Cursor](https://cursor.com/), [Cline](https://cline.bot/), [Windsurf](https://windsurf.com/), [Zed](https://zed.dev/), [Continue.dev](https://docs.continue.dev/), [Roo Code](https://roocode.com/), and [Amazon Q Developer](https://aws.amazon.com/q/developer/) — directly to **[eBay's Sell APIs](https://developer.ebay.com/api-docs/sell/static/overview.html)**. It exposes **384 tools** spanning **100% of eBay's Sell API surface** (360 unique endpoints) for inventory management, order fulfillment, promoted-listings marketing, analytics, and developer tooling. Everything runs on your machine over STDIO or local HTTP — **no cloud relay**, and your eBay credentials never leave your computer.
 
-> **Disclaimer:** Unofficial, third-party project — **not affiliated with or endorsed by eBay Inc.** Provided "as is" without warranty. You are responsible for complying with [eBay's API License Agreement](https://developer.ebay.com/join/api-license-agreement) and [data-handling requirements](https://developer.ebay.com/api-docs/static/data-handling-update.html), keeping your credentials secure, and staying within rate limits. Test in sandbox before production. See [LICENSE](LICENSE), [SECURITY.md](SECURITY.md), and [EBAY_COMPLIANCE.md](EBAY_COMPLIANCE.md).
+> **Disclaimer:** Unofficial, third-party project — **not affiliated with or endorsed by eBay Inc.** Provided "as is" without warranty. You are responsible for complying with [eBay's API License Agreement](https://developer.ebay.com/join/api-license-agreement) and [data-handling requirements](https://developer.ebay.com/api-docs/static/data-handling-update.html), keeping your credentials secure, and staying within rate limits. Test in sandbox before production. See [LICENSE](LICENSE).
 
 ## Table of contents
 
@@ -75,7 +63,7 @@
 - **9 AI clients, auto-configured** — Claude Desktop, Cursor, Zed, Cline, Continue.dev, Windsurf, Roo Code, Claude Code CLI, and Amazon Q Developer.
 - **OAuth 2.0 built in** — full user-token management with automatic refresh, and smart fallback from user tokens (10k–50k req/day) to client credentials (1k req/day).
 - **Resilient by default** — automatic retry with exponential backoff on `429` rate limits, and consistent, loud error surfacing.
-- **Type-safe** — [TypeScript](https://www.typescriptlang.org/) end to end, [Effect](https://effect.website/docs)-backed tool input validation, and [OpenAPI](https://www.openapis.org/)-generated types.
+- **Type-safe** — [TypeScript](https://www.typescriptlang.org/) end to end, [Zod](https://zod.dev/)-validated tool inputs, and [OpenAPI](https://www.openapis.org/)-generated types.
 - **Local-first & private** — runs over STDIO or local HTTP; your credentials and data never leave your machine.
 - **Sandbox and production** — switch environments with a single variable.
 - **One-command setup** — `npm run setup` configures credentials, OAuth, and your MCP client, with a browser auto-opened for the OAuth flow.
@@ -276,7 +264,7 @@ Both talk to the same eBay endpoints — the difference is everything you'd othe
 | Interface | Natural language through your AI assistant | Hand-written HTTP requests and JSON parsing |
 | OAuth & token refresh | Built in, with automatic refresh | You implement and maintain it |
 | Rate-limit handling | Automatic retry with exponential backoff | Manual `429` handling and backoff |
-| Input validation | Effect-backed schemas + TypeScript types on every tool | None — you validate your own payloads |
+| Input validation | Zod schemas + TypeScript types on every tool | None — you validate your own payloads |
 | Setup | One wizard (`npm run setup`) | Per-call auth, headers, and marketplace wiring |
 | AI client support | 9 clients auto-configured | Not applicable |
 | API coverage | 384 tools across 100% of the Sell APIs, ready to call | Build each request from the docs |
@@ -393,7 +381,7 @@ https://github.com/user-attachments/assets/0173c8df-221c-4943-a4ce-cd20bce79f4b
 <details open>
 <summary><strong>Environment variables, tool exposure, auth &amp; client compatibility</strong></summary>
 
-> 📖 Full reference — every environment variable, OAuth step, and scope — is in the [Configuration Guide](docs/auth/CONFIGURATION.md). `npm run setup` writes the `.env` for you; the variables below are for reference.
+> `npm run setup` writes the `.env` for you; the variables below are for reference.
 
 ```bash
 EBAY_CLIENT_ID=your_client_id
@@ -414,6 +402,7 @@ EBAY_READ_ONLY=false                # when true, only register read-only tools (
 # MCP_HOST=0.0.0.0                  # default is 0.0.0.0 when PORT is set
 # MCP_PORT=3000                     # preferred over platform PORT
 # MCP_AUTH_TOKEN=secret             # static Bearer for HTTP MCP (skips OAuth verifier)
+# MCP_CORS_ORIGINS=https://app.example.com  # browser origins allowed cross-origin (comma-separated); default: loopback origins only
 ```
 
 ### Tool exposure (`EBAY_MCP_TOOLS`)
@@ -435,7 +424,7 @@ The family list is literal — you get exactly what you name. ChatGPT connectors
 | **Client credentials** (default) | 1,000 req/day   | Development, testing    | Automatic with Client ID + Secret |
 | **User token** (recommended)     | 10k–50k req/day | Production, high volume | OAuth via `npm run setup`         |
 
-User-token limits vary by account tier (Individual 10k · Commercial 25k · Enterprise 50k+). On a `429`, the server retries with exponential backoff and surfaces the error. See the [Configuration Guide](docs/auth/CONFIGURATION.md) and [OAuth Quick Reference](docs/auth/OAUTH_QUICK_REFERENCE.md) for details, and monitor usage in the [Developer Portal](https://developer.ebay.com/my/api_usage).
+User-token limits vary by account tier (Individual 10k · Commercial 25k · Enterprise 50k+). On a `429`, the server retries with exponential backoff and surfaces the error. Monitor usage in the [Developer Portal](https://developer.ebay.com/my/api_usage).
 
 ### MCP client compatibility
 
@@ -511,7 +500,7 @@ On hosts that support [MCP Apps](https://modelcontextprotocol.io), common read t
 | **Chart** | `ebay_get_traffic_report`, `ebay_get_customer_service_metric` |
 | **Stat** | `ebay_get_rate_limits`, `ebay_get_user_rate_limits` |
 
-The views build into self-contained HTML with `npm run build` (or `npm run build:ui`); they ship in the published package and load with no network access of their own.
+The views build into self-contained HTML with `pnpm build` (or `pnpm build:mcp-apps`); they ship in the published package and load with no network access of their own.
 
 </details>
 
@@ -540,8 +529,8 @@ Common tasks, phrased as you'd ask your AI assistant:
 
 ## Logging & troubleshooting
 
-- **Logging** — Winston-based, written to stderr (MCP-safe) with optional file output. See [docs/logging.md](docs/logging.md).
-- **Troubleshooting** — server not appearing, auth errors, rate limits, empty results. Start with `npm run diagnose`, then see [docs/troubleshooting.md](docs/troubleshooting.md).
+- **Logging** — Winston-based, written to stderr (MCP-safe) with optional file output.
+- **Troubleshooting** — server not appearing, auth errors, rate limits, empty results. Start with `npm run diagnose`.
 
 ## FAQ
 
@@ -576,7 +565,7 @@ Yes. It works with Claude Desktop and Claude Code out of the box, with Cursor an
 <details>
 <summary><strong>Why don't I see the interactive tables and charts?</strong></summary>
 
-Interactive [MCP Apps](#interactive-ui-mcp-apps) views only appear on hosts that announce the capability (e.g. Claude); other clients get the same data as plain JSON. Also confirm you have not set `EBAY_MCP_UI=off` and that the views are built (`npm run build` runs `build:ui`).
+Interactive [MCP Apps](#interactive-ui-mcp-apps) views only appear on hosts that announce the capability (e.g. Claude); other clients get the same data as plain JSON. Also confirm you have not set `EBAY_MCP_UI=off` and that the views are built (`pnpm build` runs `build:mcp-apps`).
 
 </details>
 
@@ -625,14 +614,14 @@ Yes. Switch with the `EBAY_ENVIRONMENT` variable (`sandbox` or `production`).
 <details>
 <summary><strong>Are my credentials and data secure?</strong></summary>
 
-Credentials are stored locally in your `.env` file and used only to call eBay directly. See [SECURITY.md](SECURITY.md) and [EBAY_COMPLIANCE.md](EBAY_COMPLIANCE.md).
+Credentials are stored locally in your `.env` file and used only to call eBay directly.
 
 </details>
 
 <details>
 <summary><strong>How is this different from calling the eBay API directly?</strong></summary>
 
-You interact in natural language through your AI assistant. OAuth token management, automatic retries with backoff, and type-safe Effect-backed validation are built in. See the [comparison table](#ebay-mcp-vs-the-raw-ebay-api) above.
+You interact in natural language through your AI assistant. OAuth token management, automatic retries with backoff, and type-safe Zod validation are built in. See the [comparison table](#ebay-mcp-vs-the-raw-ebay-api) above.
 
 </details>
 
@@ -667,7 +656,7 @@ Complete the OAuth flow with `npm run setup` to authenticate with a user token (
 <details>
 <summary><strong>What is it built with?</strong></summary>
 
-TypeScript and Node.js (ESM), using the official MCP SDK, Effect-backed validation with a Zod-compatible MCP adapter, and OpenAPI-generated types.
+TypeScript and Node.js (ESM), using the official MCP SDK, Zod schemas for tool inputs, Effect for typed async errors, and OpenAPI-generated types.
 
 </details>
 
@@ -687,28 +676,28 @@ No. "Runs locally" means the server process runs on your machine — it still ne
 
 ## Contributing
 
-Contributions welcome. Fork → branch → add tests → `npm run check && npm test` → commit with [Conventional Commits](https://www.conventionalcommits.org/) → open a PR.
+Contributions welcome. Fork → branch → add tests → run the checks below → commit with [Conventional Commits](https://www.conventionalcommits.org/) → open a PR.
 
-- Working on the codebase or with a coding agent? Start with **[AGENTS.md](AGENTS.md)** — build/test commands, module map, and the add-an-endpoint workflow.
-- Code style lives in **[CODE-STYLE.md](CODE-STYLE.md)**. Architecture and decision context live in **[ARCHITECTURE.md](ARCHITECTURE.md)** and [ADRs](docs/adr/current/).
-- Full contribution guidelines: **[CONTRIBUTING.md](CONTRIBUTING.md)**.
+```bash
+pnpm typecheck && pnpm typecheck:mcp-apps   # TypeScript (server + MCP Apps views)
+pnpm check:ci                              # Biome lint + format
+pnpm test && pnpm test:integration         # Vitest unit + integration
+pnpm build                                 # Build to build/
+```
 
 ## Resources
 
 Project docs:
 
-- [Configuration Guide](docs/auth/CONFIGURATION.md) — every environment variable, OAuth step, and eBay scope.
-- [OAuth Quick Reference](docs/auth/OAUTH_QUICK_REFERENCE.md) — scopes, troubleshooting, and examples.
-- [Logging Guide](docs/logging.md) and [Troubleshooting Guide](docs/troubleshooting.md) — operational help after setup.
-- [Architecture](ARCHITECTURE.md), [CODE-STYLE.md](CODE-STYLE.md), [AGENTS.md](AGENTS.md), and [llms.txt](llms.txt) — contributor and agent entry points.
-- [CHANGELOG.md](CHANGELOG.md), [SECURITY.md](SECURITY.md), [CODE_OF_CONDUCT.md](CODE_OF_CONDUCT.md), and the [Issue Tracker](https://github.com/YosefHayim/ebay-mcp/issues).
+- [llms.txt](llms.txt) — a compact project summary for AI agents.
+- [Releases](https://github.com/YosefHayim/ebay-mcp/releases) and the [Issue Tracker](https://github.com/YosefHayim/ebay-mcp/issues).
 
 Official specs and tooling:
 
 - [eBay Developer Portal](https://developer.ebay.com/), [Sell API docs](https://developer.ebay.com/api-docs/sell/static/overview.html), [API License Agreement](https://developer.ebay.com/join/api-license-agreement), [Data Handling Requirements](https://developer.ebay.com/api-docs/static/data-handling-update.html), and [API Status](https://developer.ebay.com/support/api-status).
 - [Model Context Protocol](https://modelcontextprotocol.io/) and the [MCP Apps SDK](https://github.com/modelcontextprotocol/ext-apps).
-- [Node.js](https://nodejs.org/en), [npm package](https://www.npmjs.com/package/ebay-mcp), [TypeScript](https://www.typescriptlang.org/), [Effect](https://effect.website/docs), [Biome](https://biomejs.dev/), [Vitest](https://vitest.dev/), and [GitHub Actions](https://docs.github.com/en/actions).
-- [AGENTS.md convention](https://agents.md/), [Claude Code](https://code.claude.com/docs/en/overview), [GitHub Copilot repository instructions](https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/add-custom-instructions/add-repository-instructions), and [llms.txt](https://llmstxt.org/).
+- [Node.js](https://nodejs.org/en), [npm package](https://www.npmjs.com/package/ebay-mcp), [TypeScript](https://www.typescriptlang.org/), [Zod](https://zod.dev/), [Effect](https://effect.website/docs), [Biome](https://biomejs.dev/), [Vitest](https://vitest.dev/), and [GitHub Actions](https://docs.github.com/en/actions).
+- [Claude Code](https://code.claude.com/docs/en/overview) and [llms.txt](https://llmstxt.org/).
 
 ## License
 

package/build/api/account-management/accountV2.js

@@ -23,8 +23,8 @@ export class AccountV2Api {
     getRateTable = (input) => {
         const { client, basePath } = this;
         return Effect.gen(function* () {
-            const request = yield* requireObjectEffect(input, 'input');
-            const rateTableId = yield* requireStringEffect(request.rateTableId, 'rateTableId');
+            const validInput = yield* requireObjectEffect(input, 'input');
+            const rateTableId = yield* requireStringEffect(validInput.rateTableId, 'rateTableId');
             return yield* requestGetEffect(client, `${basePath}/rate_table/${encodeURIComponent(rateTableId)}`);
         });
     };
@@ -49,11 +49,11 @@ export class AccountV2Api {
     updateShippingCost = (input) => {
         const { client, basePath } = this;
         return Effect.gen(function* () {
-            const request = yield* requireObjectEffect(input, 'input');
-            const rateTableId = yield* requireStringEffect(request.rateTableId, 'rateTableId');
-            const body = yield* requireObjectEffect(request.rateTableUpdate, 'rateTableUpdate');
+            const validInput = yield* requireObjectEffect(input, 'input');
+            const rateTableId = yield* requireStringEffect(validInput.rateTableId, 'rateTableId');
+            const rateTableUpdate = yield* requireObjectEffect(validInput.rateTableUpdate, 'rateTableUpdate');
             const path = `${basePath}/rate_table/${encodeURIComponent(rateTableId)}/update_shipping_cost`;
-            return yield* requestPostEffect(client, path, body);
+            return yield* requestPostEffect(client, path, rateTableUpdate);
         });
     };
     /**
@@ -98,9 +98,9 @@ export class AccountV2Api {
         const { client } = this;
         const path = `${this.basePath}/payout_settings/update_percentage`;
         return Effect.gen(function* () {
-            const request = yield* requireObjectEffect(input, 'input');
-            const body = yield* requireObjectEffect(request.payoutSplit, 'payoutSplit');
-            return yield* requestPostEffect(client, path, body);
+            const validInput = yield* requireObjectEffect(input, 'input');
+            const payoutSplit = yield* requireObjectEffect(validInput.payoutSplit, 'payoutSplit');
+            return yield* requestPostEffect(client, path, payoutSplit);
         });
     };
     /**
@@ -182,8 +182,8 @@ export class AccountV2Api {
         const { client } = this;
         const path = `${this.basePath}/combined_shipping_rules`;
         return Effect.gen(function* () {
-            const request = yield* requireObjectEffect(input, 'input');
-            const marketplaceId = yield* requireStringEffect(request.marketplaceId, 'marketplaceId');
+            const validInput = yield* requireObjectEffect(input, 'input');
+            const marketplaceId = yield* requireStringEffect(validInput.marketplaceId, 'marketplaceId');
             return yield* requestGetEffect(client, path, undefined, marketplaceHeader(marketplaceId));
         });
     };
@@ -286,9 +286,9 @@ export class AccountV2Api {
         const { client } = this;
         const path = `${this.basePath}/user_preferences`;
         return Effect.gen(function* () {
-            const request = yield* requireObjectEffect(input, 'input');
-            const marketplaceId = yield* requireStringEffect(request.marketplaceId, 'marketplaceId');
-            const fieldgroups = yield* optionalStringEffect(request.fieldgroups, 'fieldgroups');
+            const validInput = yield* requireObjectEffect(input, 'input');
+            const marketplaceId = yield* requireStringEffect(validInput.marketplaceId, 'marketplaceId');
+            const fieldgroups = yield* optionalStringEffect(validInput.fieldgroups, 'fieldgroups');
             const params = buildEndpointParams({
                 fieldgroups: { wireName: 'fieldgroups', value: fieldgroups },
             });
@@ -324,10 +324,10 @@ export class AccountV2Api {
         const { client } = this;
         const path = `${this.basePath}/user_preferences`;
         return Effect.gen(function* () {
-            const request = yield* requireObjectEffect(input, 'input');
-            const marketplaceId = yield* requireStringEffect(request.marketplaceId, 'marketplaceId');
-            const body = yield* requireObjectEffect(request.preferences, 'preferences');
-            return yield* requestPatchEffect(client, path, body, marketplaceHeader(marketplaceId));
+            const validInput = yield* requireObjectEffect(input, 'input');
+            const marketplaceId = yield* requireStringEffect(validInput.marketplaceId, 'marketplaceId');
+            const preferences = yield* requireObjectEffect(validInput.preferences, 'preferences');
+            return yield* requestPatchEffect(client, path, preferences, marketplaceHeader(marketplaceId));
         });
     };
     /**
@@ -338,10 +338,10 @@ export class AccountV2Api {
         const { client } = this;
         const path = `${this.basePath}/combined_shipping_rules/${operation}`;
         return Effect.gen(function* () {
-            const request = yield* requireObjectEffect(input, 'input');
-            const marketplaceId = yield* requireStringEffect(request.marketplaceId, 'marketplaceId');
-            const body = yield* requireObjectEffect(request[bodyField], bodyField);
-            return yield* requestPostEffect(client, path, body, marketplaceHeader(marketplaceId));
+            const validInput = yield* requireObjectEffect(input, 'input');
+            const marketplaceId = yield* requireStringEffect(validInput.marketplaceId, 'marketplaceId');
+            const rules = yield* requireObjectEffect(validInput[bodyField], bodyField);
+            return yield* requestPostEffect(client, path, rules, marketplaceHeader(marketplaceId));
         });
     };
 }

package/build/api/account-management/finances.js

@@ -61,8 +61,8 @@ export class FinancesApi {
     getOrderEarnings = (input = {}) => {
         const getFromApiz = this.getFromApiz;
         return Effect.gen(function* () {
-            const request = yield* decodeEndpointInputEffect(getOrderEarningsInputSchema, input);
-            return yield* getFromApiz(`${BASE_PATH}/order_earnings`, pageQuery(request), request.marketplaceId);
+            const validatedInput = yield* decodeEndpointInputEffect(getOrderEarningsInputSchema, input);
+            return yield* getFromApiz(`${BASE_PATH}/order_earnings`, pageQuery(validatedInput), validatedInput.marketplaceId);
         });
     };
     /**
@@ -146,8 +146,8 @@ export class FinancesApi {
     getPayouts = (input = {}) => {
         const getFromApiz = this.getFromApiz;
         return Effect.gen(function* () {
-            const request = yield* decodeEndpointInputEffect(getPayoutsInputSchema, input);
-            return yield* getFromApiz(`${BASE_PATH}/payout`, pageQuery(request), request.marketplaceId);
+            const validatedInput = yield* decodeEndpointInputEffect(getPayoutsInputSchema, input);
+            return yield* getFromApiz(`${BASE_PATH}/payout`, pageQuery(validatedInput), validatedInput.marketplaceId);
         });
     };
     /**
@@ -211,8 +211,8 @@ export class FinancesApi {
     getTransactions = (input = {}) => {
         const getFromApiz = this.getFromApiz;
         return Effect.gen(function* () {
-            const request = yield* decodeEndpointInputEffect(getTransactionsInputSchema, input);
-            return yield* getFromApiz(`${BASE_PATH}/transaction`, pageQuery(request), request.marketplaceId);
+            const validatedInput = yield* decodeEndpointInputEffect(getTransactionsInputSchema, input);
+            return yield* getFromApiz(`${BASE_PATH}/transaction`, pageQuery(validatedInput), validatedInput.marketplaceId);
         });
     };
     /**
@@ -279,11 +279,11 @@ export class FinancesApi {
     getBillingActivities = (input) => {
         const client = this.client;
         return Effect.gen(function* () {
-            const request = yield* decodeEndpointInputEffect(getBillingActivitiesInputSchema, input);
-            const config = request.acceptLanguage === undefined
+            const validatedInput = yield* decodeEndpointInputEffect(getBillingActivitiesInputSchema, input);
+            const config = validatedInput.acceptLanguage === undefined
                 ? undefined
-                : { headers: { 'Accept-Language': request.acceptLanguage } };
-            return yield* requestGetEffect(client, `${BASE_PATH}/billing_activity`, pageQuery(request), config);
+                : { headers: { 'Accept-Language': validatedInput.acceptLanguage } };
+            return yield* requestGetEffect(client, `${BASE_PATH}/billing_activity`, pageQuery(validatedInput), config);
         });
     };
 }

package/build/api/analytics-and-report/analytics.js

@@ -2,7 +2,7 @@ import { buildEndpointParams, optionalStringEffect, requestGetEffect, requireObj
 import { Effect } from 'effect';
 /**
  * Analytics API - Sales and traffic analytics
- * Based on: docs/sell-apps/analytics-and-report/sell_analytics_v1_oas3.json
+ * Based on: sell_analytics_v1_oas3.json
  */
 export class AnalyticsApi {
     basePath = '/sell/analytics/v1';

package/build/api/{client.js → client/ebayApiClient.js}

@@ -1,17 +1,17 @@
-import { EbayOAuthClient } from '../auth/oauth.js';
-import { clientRequestError } from '../api/clientRequestError.js';
-import { RateLimitTracker } from '../api/rateLimitTracker.js';
-import { getBaseUrl } from '../config/environment.js';
-import { getErrorMessage } from '../utils/errors.js';
-import { httpRequestEffect, isHttpError, } from '../utils/http.js';
-import { isRecord } from '../utils/typeGuards.js';
-import { apiLogger, logRequest, logResponse, logErrorResponse } from '../utils/logger.js';
+import { EbayOAuthClient } from '../../auth/oauth.js';
+import { clientRequestError, } from '../../api/client/ebayClientRequestError.js';
+import { RateLimitTracker } from '../../api/client/rateLimitTracker.js';
+import { getBaseUrl } from '../../config/environment.js';
+import { getErrorMessage } from '../../utils/errors.js';
+import { httpRequestEffect, isHttpError, } from '../../utils/http.js';
+import { isRecord } from '../../utils/typeGuards.js';
+import { apiLogger, logRequest, logResponse, logErrorResponse } from '../../utils/logger.js';
 import { Cause, Effect, Exit } from 'effect';
 /** Bodies that must never be echoed into debug logs. */
-const isBinaryBody = (data) => data instanceof FormData ||
-    data instanceof Blob ||
-    data instanceof Uint8Array ||
-    data instanceof ArrayBuffer;
+const isBinaryBody = (requestBody) => requestBody instanceof FormData ||
+    requestBody instanceof Blob ||
+    requestBody instanceof Uint8Array ||
+    requestBody instanceof ArrayBuffer;
 const CONTENT_TYPE_HEADER = 'content-type';
 const hasHeader = (headers, name) => headers !== undefined && Object.keys(headers).some((key) => key.toLowerCase() === name);
 /** Removes every spelling of a header so fetch can derive it from the body. */
@@ -31,10 +31,6 @@ const deleteHeader = (headers, name) => {
 const tokenFailureRemediation = (tokenType) => tokenType === 'application'
     ? 'This endpoint requires an application access token minted from client credentials, which a user token cannot supply. Check EBAY_CLIENT_ID and EBAY_CLIENT_SECRET.'
     : 'Please use the ebay_set_user_tokens_with_expiry tool to provide valid tokens.';
-/** Sleep for a retry backoff delay without exposing timers to callers. */
-const sleep = (delayMs) => Effect.promise(() => new Promise((resolve) => {
-    setTimeout(resolve, delayMs);
-}));
 /**
  * Base client for making eBay API requests.
  *
@@ -103,9 +99,9 @@ export class EbayApiClient {
      * Pull the most descriptive eBay error string from a response body when present.
      * eBay REST errors arrive as `{ errors: [{ message, longMessage }] }`.
      */
-    ebayErrorDetail(data) {
-        if (isRecord(data) && Array.isArray(data.errors)) {
-            const [firstError] = data.errors;
+    ebayErrorDetail(errorBody) {
+        if (isRecord(errorBody) && Array.isArray(errorBody.errors)) {
+            const [firstError] = errorBody.errors;
             if (isRecord(firstError)) {
                 const detail = firstError.longMessage ?? firstError.message;
                 if (typeof detail === 'string') {
@@ -118,11 +114,11 @@ export class EbayApiClient {
      * Serialize the full error response body so structured fields (errorId, parameters)
      * survive into the thrown message for diagnostics.
      */
-    ebayErrorBody(data) {
-        if (data == null)
+    ebayErrorBody(errorBody) {
+        if (errorBody == null)
             return '';
         try {
-            return ` | response: ${JSON.stringify(data)}`;
+            return ` | response: ${JSON.stringify(errorBody)}`;
         }
         catch {
             return '';
@@ -142,8 +138,8 @@ export class EbayApiClient {
         // rejects with a FiberFailure whose generic message hides eBay response data.
         const exit = await Effect.runPromiseExit(this.requestEffect(method, endpoint, options));
         if (Exit.isSuccess(exit)) {
-            const { data, status, headers } = exit.value;
-            return { data, status, headers };
+            const { data: responseBody, status, headers } = exit.value;
+            return { data: responseBody, status, headers };
         }
         throw Cause.squash(exit.cause);
     }
@@ -222,9 +218,9 @@ export class EbayApiClient {
                 timeoutMs: options.timeoutMs ?? this.timeoutMs,
                 responseType: options.responseType,
                 maxBytes: options.maxBytes,
-            }).pipe(Effect.map((response) => {
-                logResponse(response.status, response.statusText, response.data, response.headers['x-ebay-c-ratelimit-remaining'], response.headers['x-ebay-c-ratelimit-limit']);
-                return response;
+            }).pipe(Effect.map((httpResponse) => {
+                logResponse(httpResponse.status, httpResponse.statusText, httpResponse.data, httpResponse.headers['x-ebay-c-ratelimit-remaining'], httpResponse.headers['x-ebay-c-ratelimit-limit']);
+                return httpResponse;
             }), Effect.catchAll((error) => this.handleRequestFailure(error, { method, url, options, state })));
         });
     }
@@ -309,7 +305,7 @@ export class EbayApiClient {
                 attempt: `${nextServerRetries}/3`,
                 delayMs,
             });
-            return sleep(delayMs).pipe(Effect.flatMap(() => this.sendWithRetry(method, url, options, {
+            return Effect.sleep(delayMs).pipe(Effect.flatMap(() => this.sendWithRetry(method, url, options, {
                 ...state,
                 serverRetries: nextServerRetries,
             })));
@@ -364,16 +360,16 @@ export class EbayApiClient {
     /**
      * Make a POST request to eBay API
      */
-    async post(endpoint, data, config) {
-        return (await this.postForResponse(endpoint, data, config)).data;
+    async post(endpoint, requestBody, config) {
+        return (await this.postForResponse(endpoint, requestBody, config)).data;
     }
     /**
      * Make a POST request and keep the status and headers of the successful
      * response — for endpoints that return their result in a `Location` header.
      */
-    async postForResponse(endpoint, data, config) {
+    async postForResponse(endpoint, requestBody, config) {
         return await this.requestResponse('POST', endpoint, {
-            data,
+            data: requestBody,
             params: config?.params,
             headers: config?.headers,
             responseType: config?.responseType,
@@ -386,16 +382,16 @@ export class EbayApiClient {
     /**
      * Make a PUT request to eBay API
      */
-    async put(endpoint, data, config) {
-        return (await this.putForResponse(endpoint, data, config)).data;
+    async put(endpoint, requestBody, config) {
+        return (await this.putForResponse(endpoint, requestBody, config)).data;
     }
     /**
      * Make a PUT request and keep the status and headers of the successful
      * response — for asynchronous updates that return a task `Location` header.
      */
-    async putForResponse(endpoint, data, config) {
+    async putForResponse(endpoint, requestBody, config) {
         return await this.requestResponse('PUT', endpoint, {
-            data,
+            data: requestBody,
             params: config?.params,
             headers: config?.headers,
             responseType: config?.responseType,
@@ -408,9 +404,9 @@ export class EbayApiClient {
     /**
      * Make a PATCH request to eBay API
      */
-    async patch(endpoint, data, config) {
+    async patch(endpoint, requestBody, config) {
         return await this.request('PATCH', endpoint, {
-            data,
+            data: requestBody,
             params: config?.params,
             headers: config?.headers,
             responseType: config?.responseType,
@@ -429,11 +425,11 @@ export class EbayApiClient {
     /**
      * Make a DELETE request and keep the status and headers of the successful
      * response — for asynchronous deletes that return a task `Location` header.
-     * `data` is the optional body a few eBay DELETE calls document.
+     * `requestBody` is the optional body a few eBay DELETE calls document.
      */
-    async deleteForResponse(endpoint, config, data) {
+    async deleteForResponse(endpoint, config, requestBody) {
         return await this.requestResponse('DELETE', endpoint, {
-            data,
+            data: requestBody,
             params: config?.params,
             headers: config?.headers,
             responseType: config?.responseType,

package/build/api/{clientTrading.js → client/tradingApiClient.js}

@@ -1,12 +1,12 @@
 import XmlBuilder from 'fast-xml-builder';
 import { XMLParser } from 'fast-xml-parser';
-import { TradingApiFailure } from '../api/clientTradingError.js';
-import { EbayApiError } from '../api/shared/request.js';
-import { getBaseUrl, getTradingSiteId } from '../config/environment.js';
-import { getErrorMessage } from '../utils/errors.js';
-import { httpRequestEffect } from '../utils/http.js';
-import { apiLogger } from '../utils/logger.js';
-import { isRecord } from '../utils/typeGuards.js';
+import { TradingApiFailure } from '../../api/client/tradingApiFailure.js';
+import { EbayApiError } from '../../api/shared/request.js';
+import { getBaseUrl, getTradingSiteId } from '../../config/environment.js';
+import { getErrorMessage } from '../../utils/errors.js';
+import { httpRequestEffect } from '../../utils/http.js';
+import { apiLogger } from '../../utils/logger.js';
+import { isRecord } from '../../utils/typeGuards.js';
 import { Effect } from 'effect';
 const COMPAT_LEVEL = '1451';
 const TRADING_ENDPOINT_PATH = '/ws/api.dll';
@@ -73,9 +73,9 @@ const parseTradingXml = ({ parser, responseText, callName, path, }) => Effect.tr
     return Effect.fail(createTradingApiError({ callName, path }, 'response must be an object'));
 }));
 const readTradingPayload = (parsed, responseTag, { callName, path }) => {
-    const resultValue = parsed[responseTag] === undefined ? parsed : parsed[responseTag];
-    if (isRecord(resultValue)) {
-        return Effect.succeed(resultValue);
+    const responsePayload = parsed[responseTag] === undefined ? parsed : parsed[responseTag];
+    if (isRecord(responsePayload)) {
+        return Effect.succeed(responsePayload);
     }
     return Effect.fail(createTradingApiError({ callName, path }, 'response payload is not an object'));
 };
@@ -94,25 +94,25 @@ const extractTradingErrorMessage = (errors) => {
     }
     return 'Trading API returned a failure without an error message';
 };
-const validateTradingAck = (result, { callName, path }) => {
-    if (result.Ack === 'Warning') {
+const validateTradingAck = (tradingPayload, { callName, path }) => {
+    if (tradingPayload.Ack === 'Warning') {
         apiLogger.warn(`Trading API ${callName} returned warnings`, {
-            errors: result.Errors,
+            errors: tradingPayload.Errors,
         });
     }
-    if (result.Ack === 'Failure' || result.Ack === 'PartialFailure') {
+    if (tradingPayload.Ack === 'Failure' || tradingPayload.Ack === 'PartialFailure') {
         return Effect.fail(new EbayApiError({
             method: 'POST',
             path,
             cause: new TradingApiFailure({
                 callName,
                 path,
-                message: extractTradingErrorMessage(result.Errors),
-                cause: result.Errors,
+                message: extractTradingErrorMessage(tradingPayload.Errors),
+                cause: tradingPayload.Errors,
             }),
         }));
     }
-    return Effect.succeed(result);
+    return Effect.succeed(tradingPayload);
 };
 /**
  * XML-based client for eBay Trading API calls that are not covered by REST APIs.
@@ -173,7 +173,7 @@ export class TradingApiClient {
      *
      * @example
      * ```ts
-     * const result = await Effect.runPromise(
+     * const tradingReply = await Effect.runPromise(
      *   tradingClient.execute('GetItem', { ItemID: '12345' }),
      * );
      * ```
@@ -193,7 +193,7 @@ export class TradingApiClient {
                 callName,
                 path,
             });
-            const response = yield* postTradingXml({
+            const xmlResponse = yield* postTradingXml({
                 path,
                 headers: authorizedHeaders,
                 xmlBody,
@@ -201,12 +201,12 @@ export class TradingApiClient {
             });
             const parsed = yield* parseTradingXml({
                 parser: tradingClient.parser,
-                responseText: response.data,
+                responseText: xmlResponse.data,
                 callName,
                 path,
             });
-            const result = yield* readTradingPayload(parsed, responseTag, { callName, path });
-            return yield* validateTradingAck(result, { callName, path });
+            const tradingPayload = yield* readTradingPayload(parsed, responseTag, { callName, path });
+            return yield* validateTradingAck(tradingPayload, { callName, path });
         });
     };
 }