ebay-mcp 1.18.0 → 1.18.2

package/build/scripts/diagnostics.js

@@ -8,7 +8,7 @@
  */
 import chalk from 'chalk';
 import { writeFileSync } from 'fs';
-import { join, dirname, resolve } from 'path';
+import { join, dirname } from 'path';
 import { fileURLToPath } from 'url';
 import { runSecurityChecks, displaySecurityResults } from '../scripts/securityChecker.js';
 import { validateSetup, displayRecommendations } from '../scripts/setupValidator.js';
@@ -16,11 +16,12 @@ import { parseEnvFile } from '../utils/envParser.js';
 import { detectLLMClients } from '../utils/llmClientDetector.js';
 import { displayScopeVerification, parseScopeString } from '../scripts/scopeHelper.js';
 import { readEnvironment } from './setupShared.js';
-import { EbaySellerApi } from '../api/index.js';
+import { EbaySellerApi } from '../api/ebaySellerApi.js';
 import { getErrorMessage } from '../utils/errors.js';
 import { getUpdateInfo, getVersion } from '../utils/version.js';
 import { Effect, Either } from 'effect';
 import process from 'node:process';
+import { isEntryModule } from '../utils/entryModule.js';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 const PROJECT_ROOT = join(__dirname, '../..');
@@ -129,12 +130,12 @@ function displayConfigurationStatus(envVars) {
         { key: 'EBAY_APP_ACCESS_TOKEN', label: 'App Access Token', redact: true },
     ];
     for (const check of checks) {
-        const value = envVars[check.key];
+        const envValue = envVars[check.key];
         let status;
         let displayValue;
-        if (value && value.trim() && !value.includes('_here')) {
+        if (envValue && envValue.trim() && !envValue.includes('_here')) {
             status = chalk.green('✓ Set');
-            displayValue = check.redact ? `${value.substring(0, 10)}...` : value;
+            displayValue = check.redact ? `${envValue.substring(0, 10)}...` : envValue;
         }
         else {
             status = chalk.red('✗ Not set');
@@ -167,18 +168,18 @@ function displayLLMClientStatus() {
  */
 async function displayAuthenticationTest(config) {
     console.log(chalk.bold.cyan('🔐 API Authentication Test\n'));
-    const result = await testEbayAuthentication(config);
-    if (result.success) {
+    const authCheck = await testEbayAuthentication(config);
+    if (authCheck.success) {
         console.log(chalk.green('  ✓ Successfully authenticated with eBay API\n'));
-        if (result.userInfo) {
+        if (authCheck.userInfo) {
             console.log(chalk.bold.white('  User Information:'));
-            console.log(chalk.gray(JSON.stringify(result.userInfo, null, 2)));
+            console.log(chalk.gray(JSON.stringify(authCheck.userInfo, null, 2)));
             console.log('');
         }
     }
     else {
         console.log(chalk.red('  ✗ Authentication failed\n'));
-        console.log(chalk.yellow(`  Error: ${result.error}\n`));
+        console.log(chalk.yellow(`  Error: ${authCheck.error}\n`));
     }
 }
 /**
@@ -299,17 +300,15 @@ export const runDiagnostics = async (exportReport = false) => {
 };
 // Direct script entry (`node build/scripts/diagnostics.js` / `npm run diagnose`).
 // Guarded so importing from the bin does not auto-run diagnostics.
-const entryPath = process.argv[1] ? resolve(process.argv[1]) : undefined;
-const modulePath = resolve(fileURLToPath(import.meta.url));
-if (entryPath && modulePath === entryPath) {
+if (isEntryModule(import.meta.url)) {
     const cliArgs = process.argv.slice(2);
     const exportReport = cliArgs.includes('--export') || cliArgs.includes('-e');
     void Effect.runPromise(Effect.either(Effect.tryPromise({
         try: () => runDiagnostics(exportReport),
         catch: (error) => error,
-    }))).then((result) => {
-        if (Either.isLeft(result)) {
-            console.error(chalk.red('\n❌ Diagnostics failed:'), getErrorMessage(result.left));
+    }))).then((diagnosticsOutcome) => {
+        if (Either.isLeft(diagnosticsOutcome)) {
+            console.error(chalk.red('\n❌ Diagnostics failed:'), getErrorMessage(diagnosticsOutcome.left));
             process.exitCode = 1;
         }
     });

package/build/scripts/interactiveSetup.js

@@ -33,7 +33,7 @@ import { displayScopeCategories, getRecommendedScopes, displayScopeVerification,
 import { detectLLMClients, configureLLMClient } from '../utils/llmClientDetector.js';
 import { validateSetup, displayRecommendations } from '../scripts/setupValidator.js';
 import { loadExistingConfig, readEnvironment } from './setupShared.js';
-import { EbaySellerApi } from '../api/index.js';
+import { EbaySellerApi } from '../api/ebaySellerApi.js';
 import { EbayOAuthClient } from '../auth/oauth.js';
 import { getErrorMessage } from '../utils/errors.js';
 import process from 'node:process';
@@ -49,11 +49,11 @@ const ebayColors = {
     yellow: chalk.hex('#F5AF02'),
     green: chalk.hex('#85B716'),
 };
-function readOptionalEnvironment(value) {
-    if (!value) {
+function readOptionalEnvironment(rawEnvironment) {
+    if (!rawEnvironment) {
         return;
     }
-    return readEnvironment(value);
+    return readEnvironment(rawEnvironment);
 }
 function parseInteractiveArgs() {
     const args = process.argv.slice(2);
@@ -113,8 +113,8 @@ function displayLogo() {
     console.log(EBAY_LOGO);
     console.log(CREATOR_CREDIT);
 }
-function validateRequired(value) {
-    return value.trim().length > 0 || 'This field is required';
+function validateRequired(input) {
+    return input.trim().length > 0 || 'This field is required';
 }
 function generateEnvFile(config, environment) {
     const envPath = join(PROJECT_ROOT, `.env${environment === 'sandbox' ? '' : `.${environment}`}`);
@@ -184,25 +184,25 @@ async function acquireRefreshToken(config, useInteractiveFlow) {
     }
     // Manual flow
     displayManualOAuthInstructions(config.clientId, config.redirectUri || 'http://localhost:3000/oauth/callback', config.environment, getRecommendedScopes(config.environment));
-    const response = await prompts({
+    const pastedToken = await prompts({
         type: 'text',
         name: 'refreshToken',
         message: 'Paste your refresh token here:',
-        validate: (value) => {
-            if (!value || value.trim() === '') {
+        validate: (input) => {
+            if (!input || input.trim() === '') {
                 return 'Refresh token is required';
             }
-            const cleanValue = value.trim().replace(/^["']|["']$/g, '');
-            if (!cleanValue.startsWith('v^1.1#')) {
+            const cleanToken = input.trim().replace(/^["']|["']$/g, '');
+            if (!cleanToken.startsWith('v^1.1#')) {
                 return 'Token should start with "v^1.1#"';
             }
             return true;
         },
     });
-    if (!response.refreshToken) {
+    if (!pastedToken.refreshToken) {
         return null;
     }
-    return response.refreshToken.trim().replace(/^["']|["']$/g, '');
+    return pastedToken.refreshToken.trim().replace(/^["']|["']$/g, '');
 }
 async function validateAndGenerateTokens(config) {
     console.log(chalk.bold.cyan('\n🔄 Validating Credentials & Generating Tokens...\n'));
@@ -286,7 +286,7 @@ async function detectAndConfigureLLMClients() {
     console.log(chalk.bold.cyan('│  🤖 LLM Client Detection & Configuration                   │'));
     console.log(chalk.bold.cyan('└─────────────────────────────────────────────────────────────┘\n'));
     const clients = detectLLMClients();
-    const detectedClients = clients.filter((c) => c.detected);
+    const detectedClients = clients.filter((client) => client.detected);
     if (detectedClients.length === 0) {
         console.log(chalk.yellow('⚠️  No compatible LLM clients detected on your system.\n'));
         console.log(chalk.white('Supported clients:'));
@@ -353,7 +353,7 @@ async function detectAndConfigureLLMClients() {
         chalk.gray(' to select, ') +
         chalk.cyan('Enter') +
         chalk.gray(' to confirm\n'));
-    const response = await prompts({
+    const clientSelection = await prompts({
         type: 'multiselect',
         name: 'selectedClients',
         message: 'Select clients to configure:',
@@ -370,7 +370,7 @@ async function detectAndConfigureLLMClients() {
         hint: '← → or Space to toggle • Enter to confirm',
         instructions: false,
     });
-    if (!response.selectedClients || response.selectedClients.length === 0) {
+    if (!clientSelection.selectedClients || clientSelection.selectedClients.length === 0) {
         console.log(chalk.gray('\n⏭️  Skipping LLM client configuration.\n'));
         return;
     }
@@ -378,8 +378,8 @@ async function detectAndConfigureLLMClients() {
     console.log(chalk.bold.cyan('\n┌─────────────────────────────────────────────────────────────┐'));
     console.log(chalk.bold.cyan('│  ⚙️  Configuring Selected Clients                           │'));
     console.log(chalk.bold.cyan('└─────────────────────────────────────────────────────────────┘\n'));
-    for (const clientName of response.selectedClients) {
-        const client = detectedClients.find((c) => c.name === clientName);
+    for (const clientName of clientSelection.selectedClients) {
+        const client = detectedClients.find((detected) => detected.name === clientName);
         if (!client)
             continue;
         console.log(chalk.cyan(`Configuring ${client.displayName}...`));
@@ -641,12 +641,12 @@ async function runInteractiveSetup(args) {
             name: 'token',
             message: 'Paste your refresh token:',
             initial: refreshToken,
-            validate: (value) => {
-                if (!value || value.trim() === '') {
+            validate: (input) => {
+                if (!input || input.trim() === '') {
                     return 'Refresh token is required';
                 }
-                const cleanValue = value.trim().replace(/^["']|["']$/g, '');
-                if (!cleanValue.startsWith('v^1.1#')) {
+                const cleanToken = input.trim().replace(/^["']|["']$/g, '');
+                if (!cleanToken.startsWith('v^1.1#')) {
                     return 'Token should start with "v^1.1#"';
                 }
                 return true;
@@ -746,9 +746,9 @@ process.on('SIGINT', () => {
 void Effect.runPromise(Effect.either(Effect.tryPromise({
     try: () => main(),
     catch: (error) => error,
-}))).then((result) => {
-    if (Either.isLeft(result)) {
-        console.error(chalk.red('\n❌ Setup failed:'), getErrorMessage(result.left));
+}))).then((setupOutcome) => {
+    if (Either.isLeft(setupOutcome)) {
+        console.error(chalk.red('\n❌ Setup failed:'), getErrorMessage(setupOutcome.left));
         process.exitCode = 1;
     }
 });

package/build/scripts/scopeHelper.js

@@ -266,5 +266,5 @@ export const getAllScopesString = (environment) => getRecommendedScopes(environm
  */
 export const parseScopeString = (scopeString) => scopeString
     .split(/\s+/)
-    .map((s) => s.trim())
-    .filter((s) => s.length > 0);
+    .map((scope) => scope.trim())
+    .filter((scope) => scope.length > 0);

package/build/scripts/securityChecker.js

@@ -14,7 +14,7 @@ import { writeCliLine } from '../utils/cliOutput.js';
  * @returns A security check result for the active Node.js process.
  * @example
  * ```ts
- * const result = checkNodeVersion();
+ * const nodeVersionCheck = checkNodeVersion();
  * ```
  */
 export const checkNodeVersion = () => {
@@ -43,7 +43,7 @@ export const checkNodeVersion = () => {
  * @returns A security check result for credential file ignore coverage.
  * @example
  * ```ts
- * const result = checkGitignore(process.cwd());
+ * const gitignoreCheck = checkGitignore(process.cwd());
  * ```
  */
 export const checkGitignore = (projectRoot) => {
@@ -84,7 +84,7 @@ export const checkGitignore = (projectRoot) => {
  * @returns A security check result for the eBay API reachability probe.
  * @example
  * ```ts
- * const result = await checkNetworkConnectivity();
+ * const connectivityCheck = await checkNetworkConnectivity();
  * ```
  */
 export const checkNetworkConnectivity = async () => {
@@ -107,8 +107,8 @@ export const checkNetworkConnectivity = async () => {
             fix: 'Check your internet connection, proxy settings, and firewall',
         };
     }
-    const response = reached.right;
-    if (response.ok || response.status === 404) {
+    const healthResponse = reached.right;
+    if (healthResponse.ok || healthResponse.status === 404) {
         // 404 is fine, means we can reach eBay servers
         return {
             check: 'Network Connectivity',
@@ -120,7 +120,7 @@ export const checkNetworkConnectivity = async () => {
     return {
         check: 'Network Connectivity',
         passed: false,
-        message: `Unexpected response from eBay API: ${response.status}`,
+        message: `Unexpected response from eBay API: ${healthResponse.status}`,
         severity: 'warning',
         fix: 'Check your internet connection and firewall settings',
     };
@@ -132,7 +132,7 @@ export const checkNetworkConnectivity = async () => {
  * @returns A security check result for build output presence.
  * @example
  * ```ts
- * const result = checkProjectBuild(process.cwd());
+ * const buildCheck = checkProjectBuild(process.cwd());
  * ```
  */
 export const checkProjectBuild = (projectRoot) => {
@@ -160,7 +160,7 @@ export const checkProjectBuild = (projectRoot) => {
  * @returns A security check result for dependency installation state.
  * @example
  * ```ts
- * const result = checkDependencies(process.cwd());
+ * const dependencyCheck = checkDependencies(process.cwd());
  * ```
  */
 export const checkDependencies = (projectRoot) => {
@@ -188,7 +188,7 @@ export const checkDependencies = (projectRoot) => {
  * @returns A security check result for credential tracking risk.
  * @example
  * ```ts
- * const result = checkGitTracking(process.cwd());
+ * const gitTrackingCheck = checkGitTracking(process.cwd());
  * ```
  */
 export const checkGitTracking = (projectRoot) => {
@@ -275,24 +275,24 @@ export const runSecurityChecks = async (projectRoot) => {
  */
 export const displaySecurityResults = (results) => {
     writeCliLine(chalk.bold.cyan('\n🔒 Security & Environment Checks\n'));
-    for (const result of results) {
-        const icon = result.passed ? chalk.green('✓') : chalk.red('✗');
+    for (const checkResult of results) {
+        const icon = checkResult.passed ? chalk.green('✓') : chalk.red('✗');
         let severity = chalk.gray('[INFO]');
-        if (result.severity === 'critical') {
+        if (checkResult.severity === 'critical') {
             severity = chalk.red('[CRITICAL]');
         }
-        else if (result.severity === 'warning') {
+        else if (checkResult.severity === 'warning') {
             severity = chalk.yellow('[WARNING]');
         }
-        writeCliLine(`${icon} ${chalk.bold(result.check)}: ${severity}`);
-        writeCliLine(`  ${chalk.gray(result.message)}`);
-        if (result.fix) {
-            writeCliLine(`  ${chalk.yellow('→ Fix:')} ${result.fix}`);
+        writeCliLine(`${icon} ${chalk.bold(checkResult.check)}: ${severity}`);
+        writeCliLine(`  ${chalk.gray(checkResult.message)}`);
+        if (checkResult.fix) {
+            writeCliLine(`  ${chalk.yellow('→ Fix:')} ${checkResult.fix}`);
         }
         writeCliLine('');
     }
-    const critical = results.filter((r) => !r.passed && r.severity === 'critical');
-    const warnings = results.filter((r) => !r.passed && r.severity === 'warning');
+    const critical = results.filter((checkResult) => !checkResult.passed && checkResult.severity === 'critical');
+    const warnings = results.filter((checkResult) => !checkResult.passed && checkResult.severity === 'warning');
     if (critical.length > 0) {
         writeCliLine(chalk.red.bold(`⚠️  ${critical.length} critical issue(s) found. Please fix before continuing.\n`));
     }
@@ -313,4 +313,4 @@ export const displaySecurityResults = (results) => {
  * if (hasCriticalFailures(results)) process.exit(1);
  * ```
  */
-export const hasCriticalFailures = (results) => results.some((r) => !r.passed && r.severity === 'critical');
+export const hasCriticalFailures = (results) => results.some((check) => !check.passed && check.severity === 'critical');