create-byan-agent 2.1.0 → 2.1.1

package/_bmad/tea/workflows/testarch/test-review/steps-c/step-03-quality-evaluation.md

@@ -1,184 +0,0 @@
----
-name: 'step-03-quality-evaluation'
-description: 'Orchestrate parallel quality dimension checks (5 subprocesses)'
-nextStepFile: './step-03f-aggregate-scores.md'
----
-
-# Step 3: Orchestrate Parallel Quality Evaluation
-
-## STEP GOAL
-
-Launch 5 parallel subprocesses to evaluate independent quality dimensions simultaneously for maximum performance.
-
-## MANDATORY EXECUTION RULES
-
-- 📖 Read the entire step file before acting
-- ✅ Speak in `{communication_language}`
-- ✅ Launch FIVE subprocesses in PARALLEL
-- ✅ Wait for ALL subprocesses to complete
-- ❌ Do NOT evaluate quality sequentially (use subprocesses)
-- ❌ Do NOT proceed until all subprocesses finish
-
----
-
-## EXECUTION PROTOCOLS:
-
-- 🎯 Follow the MANDATORY SEQUENCE exactly
-- 💾 Wait for subprocess outputs
-- 📖 Load the next step only when instructed
-
-## CONTEXT BOUNDARIES:
-
-- Available context: test files from Step 2, knowledge fragments
-- Focus: subprocess orchestration only
-- Limits: do not evaluate quality directly (delegate to subprocesses)
-
----
-
-## MANDATORY SEQUENCE
-
-### 1. Prepare Subprocess Inputs
-
-**Generate unique timestamp:**
-
-```javascript
-const timestamp = new Date().toISOString().replace(/[:.]/g, '-');
-```
-
-**Prepare context for all subprocesses:**
-
-```javascript
-const subprocessContext = {
-  test_files: /* from Step 2 */,
-  knowledge_fragments_loaded: ['test-quality'],
-  timestamp: timestamp
-};
-```
-
----
-
-### 2. Launch 5 Parallel Quality Subprocesses
-
-**Subprocess A: Determinism Check**
-
-- File: `./step-03a-subprocess-determinism.md`
-- Output: `/tmp/tea-test-review-determinism-${timestamp}.json`
-- Status: Running in parallel... ⟳
-
-**Subprocess B: Isolation Check**
-
-- File: `./step-03b-subprocess-isolation.md`
-- Output: `/tmp/tea-test-review-isolation-${timestamp}.json`
-- Status: Running in parallel... ⟳
-
-**Subprocess C: Maintainability Check**
-
-- File: `./step-03c-subprocess-maintainability.md`
-- Output: `/tmp/tea-test-review-maintainability-${timestamp}.json`
-- Status: Running in parallel... ⟳
-
-**Subprocess D: Coverage Check**
-
-- File: `./step-03d-subprocess-coverage.md`
-- Output: `/tmp/tea-test-review-coverage-${timestamp}.json`
-- Status: Running in parallel... ⟳
-
-**Subprocess E: Performance Check**
-
-- File: `./step-03e-subprocess-performance.md`
-- Output: `/tmp/tea-test-review-performance-${timestamp}.json`
-- Status: Running in parallel... ⟳
-
----
-
-### 3. Wait for All Subprocesses
-
-```
-⏳ Waiting for 5 quality subprocesses to complete...
-  ├── Subprocess A (Determinism): Running... ⟳
-  ├── Subprocess B (Isolation): Running... ⟳
-  ├── Subprocess C (Maintainability): Running... ⟳
-  ├── Subprocess D (Coverage): Running... ⟳
-  └── Subprocess E (Performance): Running... ⟳
-
-[... time passes ...]
-
-  ├── Subprocess A (Determinism): Complete ✅
-  ├── Subprocess B (Isolation): Complete ✅
-  ├── Subprocess C (Maintainability): Complete ✅
-  ├── Subprocess D (Coverage): Complete ✅
-  └── Subprocess E (Performance): Complete ✅
-
-✅ All 5 quality subprocesses completed successfully!
-```
-
----
-
-### 4. Verify All Outputs Exist
-
-```javascript
-const outputs = ['determinism', 'isolation', 'maintainability', 'coverage', 'performance'].map(
-  (dim) => `/tmp/tea-test-review-${dim}-${timestamp}.json`,
-);
-
-outputs.forEach((output) => {
-  if (!fs.existsSync(output)) {
-    throw new Error(`Subprocess output missing: ${output}`);
-  }
-});
-```
-
----
-
-### 5. Performance Report
-
-```
-🚀 Performance Report:
-- Execution Mode: PARALLEL (5 subprocesses)
-- Total Elapsed: ~max(all subprocesses) minutes
-- Sequential Would Take: ~sum(all subprocesses) minutes
-- Performance Gain: ~60-70% faster!
-```
-
----
-
-### 6. Proceed to Aggregation
-
-Load next step: `{nextStepFile}`
-
-The aggregation step (3F) will:
-
-- Read all 5 subprocess outputs
-- Calculate weighted overall score (0-100)
-- Aggregate violations by severity
-- Generate review report with top suggestions
-
----
-
-## EXIT CONDITION
-
-Proceed to Step 3F when:
-
-- ✅ All 5 subprocesses completed successfully
-- ✅ All output files exist and are valid JSON
-- ✅ Performance metrics displayed
-
-**Do NOT proceed if any subprocess failed.**
-
----
-
-## 🚨 SYSTEM SUCCESS METRICS
-
-### ✅ SUCCESS:
-
-- All 5 subprocesses launched and completed
-- Output files generated and valid
-- Parallel execution achieved ~60% performance gain
-
-### ❌ FAILURE:
-
-- One or more subprocesses failed
-- Output files missing or invalid
-- Sequential evaluation instead of parallel
-
-**Master Rule:** Parallel subprocess execution is MANDATORY for performance.

package/_bmad/tea/workflows/testarch/test-review/steps-c/step-03a-subprocess-determinism.md

@@ -1,214 +0,0 @@
----
-name: 'step-03a-subprocess-determinism'
-description: 'Subprocess: Check test determinism (no random/time dependencies)'
-subprocess: true
-outputFile: '/tmp/tea-test-review-determinism-{{timestamp}}.json'
----
-
-# Subprocess 3A: Determinism Quality Check
-
-## SUBPROCESS CONTEXT
-
-This is an **isolated subprocess** running in parallel with other quality dimension checks.
-
-**What you have from parent workflow:**
-
-- Test files discovered in Step 2
-- Knowledge fragment: test-quality (determinism criteria)
-- Config: test framework
-
-**Your task:** Analyze test files for DETERMINISM violations only.
-
----
-
-## MANDATORY EXECUTION RULES
-
-- 📖 Read this entire subprocess file before acting
-- ✅ Check DETERMINISM only (not other quality dimensions)
-- ✅ Output structured JSON to temp file
-- ❌ Do NOT check isolation, maintainability, coverage, or performance (other subprocesses)
-- ❌ Do NOT modify test files (read-only analysis)
-- ❌ Do NOT run tests (just analyze code)
-
----
-
-## SUBPROCESS TASK
-
-### 1. Identify Determinism Violations
-
-**Scan test files for non-deterministic patterns:**
-
-**HIGH SEVERITY Violations**:
-
-- `Math.random()` - Random number generation
-- `Date.now()` or `new Date()` without mocking
-- `setTimeout` / `setInterval` without proper waits
-- External API calls without mocking
-- File system operations on random paths
-- Database queries with non-deterministic ordering
-
-**MEDIUM SEVERITY Violations**:
-
-- `page.waitForTimeout(N)` - Hard waits instead of conditions
-- Flaky selectors (CSS classes that may change)
-- Race conditions (missing proper synchronization)
-- Test order dependencies (test A must run before test B)
-
-**LOW SEVERITY Violations**:
-
-- Missing test isolation (shared state between tests)
-- Console timestamps without fixed timezone
-
-### 2. Analyze Each Test File
-
-For each test file from Step 2:
-
-```javascript
-const violations = [];
-
-// Check for Math.random()
-if (testFileContent.includes('Math.random()')) {
-  violations.push({
-    file: testFile,
-    line: findLineNumber('Math.random()'),
-    severity: 'HIGH',
-    category: 'random-generation',
-    description: 'Test uses Math.random() - non-deterministic',
-    suggestion: 'Use faker.seed(12345) for deterministic random data',
-  });
-}
-
-// Check for Date.now()
-if (testFileContent.includes('Date.now()') || testFileContent.includes('new Date()')) {
-  violations.push({
-    file: testFile,
-    line: findLineNumber('Date.now()'),
-    severity: 'HIGH',
-    category: 'time-dependency',
-    description: 'Test uses Date.now() or new Date() without mocking',
-    suggestion: 'Mock system time with test.useFakeTimers() or use fixed timestamps',
-  });
-}
-
-// Check for hard waits
-if (testFileContent.includes('waitForTimeout')) {
-  violations.push({
-    file: testFile,
-    line: findLineNumber('waitForTimeout'),
-    severity: 'MEDIUM',
-    category: 'hard-wait',
-    description: 'Test uses waitForTimeout - creates flakiness',
-    suggestion: 'Replace with expect(locator).toBeVisible() or waitForResponse',
-  });
-}
-
-// ... check other patterns
-```
-
-### 3. Calculate Determinism Score
-
-**Scoring Logic**:
-
-```javascript
-const totalChecks = testFiles.length * checksPerFile;
-const failedChecks = violations.length;
-const passedChecks = totalChecks - failedChecks;
-
-// Weight violations by severity
-const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
-const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
-
-// Score: 100 - (penalty points)
-const score = Math.max(0, 100 - totalPenalty);
-```
-
----
-
-## OUTPUT FORMAT
-
-Write JSON to temp file: `/tmp/tea-test-review-determinism-{{timestamp}}.json`
-
-```json
-{
-  "dimension": "determinism",
-  "score": 85,
-  "max_score": 100,
-  "grade": "B",
-  "violations": [
-    {
-      "file": "tests/api/user.spec.ts",
-      "line": 42,
-      "severity": "HIGH",
-      "category": "random-generation",
-      "description": "Test uses Math.random() - non-deterministic",
-      "suggestion": "Use faker.seed(12345) for deterministic random data",
-      "code_snippet": "const userId = Math.random() * 1000;"
-    },
-    {
-      "file": "tests/e2e/checkout.spec.ts",
-      "line": 78,
-      "severity": "MEDIUM",
-      "category": "hard-wait",
-      "description": "Test uses waitForTimeout - creates flakiness",
-      "suggestion": "Replace with expect(locator).toBeVisible()",
-      "code_snippet": "await page.waitForTimeout(5000);"
-    }
-  ],
-  "passed_checks": 12,
-  "failed_checks": 3,
-  "total_checks": 15,
-  "violation_summary": {
-    "HIGH": 1,
-    "MEDIUM": 1,
-    "LOW": 1
-  },
-  "recommendations": [
-    "Use faker with fixed seed for all random data",
-    "Replace all waitForTimeout with conditional waits",
-    "Mock Date.now() in tests that use current time"
-  ],
-  "summary": "Tests are mostly deterministic with 3 violations (1 HIGH, 1 MEDIUM, 1 LOW)"
-}
-```
-
-**On Error:**
-
-```json
-{
-  "dimension": "determinism",
-  "success": false,
-  "error": "Error message describing what went wrong"
-}
-```
-
----
-
-## EXIT CONDITION
-
-Subprocess completes when:
-
-- ✅ All test files analyzed for determinism violations
-- ✅ Score calculated (0-100)
-- ✅ Violations categorized by severity
-- ✅ Recommendations generated
-- ✅ JSON output written to temp file
-
-**Subprocess terminates here.** Parent workflow will read output and aggregate with other quality dimensions.
-
----
-
-## 🚨 SUBPROCESS SUCCESS METRICS
-
-### ✅ SUCCESS:
-
-- All test files scanned for determinism violations
-- Score calculated with proper severity weighting
-- JSON output valid and complete
-- Only determinism checked (not other dimensions)
-
-### ❌ FAILURE:
-
-- Checked quality dimensions other than determinism
-- Invalid or missing JSON output
-- Score calculation incorrect
-- Modified test files (should be read-only)

package/_bmad/tea/workflows/testarch/test-review/steps-c/step-03b-subprocess-isolation.md

@@ -1,125 +0,0 @@
----
-name: 'step-03b-subprocess-isolation'
-description: 'Subprocess: Check test isolation (no shared state/dependencies)'
-subprocess: true
-outputFile: '/tmp/tea-test-review-isolation-{{timestamp}}.json'
----
-
-# Subprocess 3B: Isolation Quality Check
-
-## SUBPROCESS CONTEXT
-
-This is an **isolated subprocess** running in parallel with other quality dimension checks.
-
-**Your task:** Analyze test files for ISOLATION violations only.
-
----
-
-## MANDATORY EXECUTION RULES
-
-- ✅ Check ISOLATION only (not other quality dimensions)
-- ✅ Output structured JSON to temp file
-- ❌ Do NOT check determinism, maintainability, coverage, or performance
-- ❌ Do NOT modify test files (read-only analysis)
-
----
-
-## SUBPROCESS TASK
-
-### 1. Identify Isolation Violations
-
-**Scan test files for isolation issues:**
-
-**HIGH SEVERITY Violations**:
-
-- Global state mutations (global variables modified)
-- Test order dependencies (test B depends on test A running first)
-- Shared database records without cleanup
-- beforeAll/afterAll with side effects leaking to other tests
-
-**MEDIUM SEVERITY Violations**:
-
-- Missing test cleanup (created data not deleted)
-- Shared fixtures that mutate state
-- Tests that assume specific execution order
-- Environment variables modified without restoration
-
-**LOW SEVERITY Violations**:
-
-- Tests sharing test data (but not mutating)
-- Missing test.describe grouping
-- Tests that could be more isolated
-
-### 2. Calculate Isolation Score
-
-```javascript
-const totalChecks = testFiles.length * checksPerFile;
-const failedChecks = violations.length;
-const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
-const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
-const score = Math.max(0, 100 - totalPenalty);
-```
-
----
-
-## OUTPUT FORMAT
-
-```json
-{
-  "dimension": "isolation",
-  "score": 90,
-  "max_score": 100,
-  "grade": "A-",
-  "violations": [
-    {
-      "file": "tests/api/integration.spec.ts",
-      "line": 15,
-      "severity": "HIGH",
-      "category": "test-order-dependency",
-      "description": "Test depends on previous test creating user record",
-      "suggestion": "Each test should create its own test data in beforeEach",
-      "code_snippet": "test('should update user', async () => { /* assumes user exists */ });"
-    }
-  ],
-  "passed_checks": 14,
-  "failed_checks": 1,
-  "total_checks": 15,
-  "violation_summary": {
-    "HIGH": 1,
-    "MEDIUM": 0,
-    "LOW": 0
-  },
-  "recommendations": [
-    "Add beforeEach hooks to create test data",
-    "Add afterEach hooks to cleanup created records",
-    "Use test.describe.configure({ mode: 'parallel' }) to enforce isolation"
-  ],
-  "summary": "Tests are well isolated with 1 HIGH severity violation"
-}
-```
-
----
-
-## EXIT CONDITION
-
-Subprocess completes when:
-
-- ✅ All test files analyzed for isolation violations
-- ✅ Score calculated
-- ✅ JSON output written to temp file
-
-**Subprocess terminates here.**
-
----
-
-## 🚨 SUBPROCESS SUCCESS METRICS
-
-### ✅ SUCCESS:
-
-- Only isolation checked (not other dimensions)
-- JSON output valid and complete
-
-### ❌ FAILURE:
-
-- Checked quality dimensions other than isolation
-- Invalid or missing JSON output

package/_bmad/tea/workflows/testarch/test-review/steps-c/step-03c-subprocess-maintainability.md

@@ -1,102 +0,0 @@
----
-name: 'step-03c-subprocess-maintainability'
-description: 'Subprocess: Check test maintainability (readability, structure, DRY)'
-subprocess: true
-outputFile: '/tmp/tea-test-review-maintainability-{{timestamp}}.json'
----
-
-# Subprocess 3C: Maintainability Quality Check
-
-## SUBPROCESS CONTEXT
-
-This is an **isolated subprocess** running in parallel with other quality dimension checks.
-
-**Your task:** Analyze test files for MAINTAINABILITY violations only.
-
----
-
-## MANDATORY EXECUTION RULES
-
-- ✅ Check MAINTAINABILITY only (not other quality dimensions)
-- ✅ Output structured JSON to temp file
-- ❌ Do NOT check determinism, isolation, coverage, or performance
-
----
-
-## SUBPROCESS TASK
-
-### 1. Identify Maintainability Violations
-
-**HIGH SEVERITY Violations**:
-
-- Tests >100 lines (too complex)
-- No test.describe grouping
-- Duplicate test logic (copy-paste)
-- Unclear test names (no Given/When/Then structure)
-- Magic numbers/strings without constants
-
-**MEDIUM SEVERITY Violations**:
-
-- Tests missing comments for complex logic
-- Inconsistent naming conventions
-- Excessive nesting (>3 levels)
-- Large setup/teardown blocks
-
-**LOW SEVERITY Violations**:
-
-- Minor code style issues
-- Could benefit from helper functions
-- Inconsistent assertion styles
-
-### 2. Calculate Maintainability Score
-
-```javascript
-const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
-const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
-const score = Math.max(0, 100 - totalPenalty);
-```
-
----
-
-## OUTPUT FORMAT
-
-```json
-{
-  "dimension": "maintainability",
-  "score": 75,
-  "max_score": 100,
-  "grade": "C",
-  "violations": [
-    {
-      "file": "tests/e2e/complex-flow.spec.ts",
-      "line": 1,
-      "severity": "HIGH",
-      "category": "test-too-long",
-      "description": "Test file is 250 lines - too complex to maintain",
-      "suggestion": "Split into multiple smaller test files by feature area",
-      "code_snippet": "test.describe('Complex flow', () => { /* 250 lines */ });"
-    }
-  ],
-  "passed_checks": 10,
-  "failed_checks": 5,
-  "violation_summary": {
-    "HIGH": 2,
-    "MEDIUM": 2,
-    "LOW": 1
-  },
-  "recommendations": [
-    "Split large test files into smaller, focused files (<100 lines each)",
-    "Add test.describe grouping for related tests",
-    "Extract duplicate logic into helper functions"
-  ],
-  "summary": "Tests have maintainability issues - 5 violations (2 HIGH)"
-}
-```
-
----
-
-## EXIT CONDITION
-
-Subprocess completes when JSON output written to temp file.
-
-**Subprocess terminates here.**