claude-brain 0.30.2 → 0.30.3

package/src/routing/intent-classifier.ts

@@ -1,552 +1,552 @@
-/**
- * Brain Intent Classifier
- * Phase 16 + Phase 19: Rule-based intent classification for the unified brain() tool
- *
- * Priority-ordered — first confident match wins.
- * No LLM calls, pure pattern matching.
- *
- * Phase 19 changes:
- * - B1: Question confidence raised (? → 0.95, question word → 0.90)
- * - B2: session_start narrowed (must be at start + no progress indicators)
- * - B3: Temporal signal detection added to secondary intents
- */
-
-export type Intent =
-  | 'session_start'
-  | 'context_needed'
-  | 'decision_made'
-  | 'store_this'
-  | 'pattern_found'
-  | 'mistake_learned'
-  | 'progress_update'
-  | 'question'
-  | 'comparison'
-  | 'exploration'
-  | 'list_all'
-  | 'update_memory'
-  | 'delete_memory'
-  | 'detail_request'
-  | 'timeline'
-  | 'no_action'
-
-export interface ClassificationResult {
-  primary: Intent
-  confidence: number
-  secondary: Intent[]
-}
-
-// Decision-indicating phrases
-const DECISION_PHRASES = [
-  'i recommend', 'you should use', 'the best approach',
-  'i suggest', 'better to use', 'prefer using',
-  'go with', 'decided to', "let's use", 'we will use',
-  'the solution is', 'implement using', 'going with',
-  'switching to', 'adopting', 'we chose', 'the plan is to',
-  'i decided that', 'decided that', 'choosing', 'we picked',
-  'settled on', 'committing to', 'opting for', 'sticking with',
-  // BUG-006: "Chose X because Y" — bare "chose" at start
-  'chose ',
-]
-
-// Explicit "store this" phrases — the user wants to persist something
-const STORE_PHRASES = [
-  'remember:', 'remember this:', 'remember that',
-  'note to self:', 'note to self', 'note:', 'save this:',
-  'save this', 'store this', 'keep this', 'record this',
-  'i prefer', 'my preference is', 'my convention is',
-  'i like to', 'i always', 'always use', 'never use this',
-  'from now on', 'going forward', 'the rule is',
-  'my approach is', 'my standard is', 'the standard is',
-  'we should always', 'we should never',
-  'i want to remember', 'don\'t forget',
-  'for future reference', 'for the record',
-  'important:', 'key decision:', 'takeaway:',
-  // Issue 3: Declarative patterns ("X should be Y")
-  'should be', 'must be', 'needs to be', 'has to be',
-  'is set to', 'will be set', 'is always', 'are always',
-  'is configured to', 'is configured as',
-  // Issue 6: "I learned that" is a store, not a mistake
-  'i learned that',
-  // Phase 25: Session summary storage
-  'session summary:', 'session summary ',
-  // Explicit prefix signal for preference storage
-  'preference:', 'my preference:',
-]
-
-const REASONING_PHRASES = [
-  'because', 'since', 'due to', 'as it', 'which provides',
-  'this allows', 'this ensures', 'given that', 'considering',
-  'the reason is', 'this way'
-]
-
-// Mistake/correction indicators
-const MISTAKE_PHRASES = [
-  'bug was', 'the issue was', 'the problem was', 'mistake was',
-  'should have', "shouldn't have", 'should not have',
-  'lesson learned', "don't use", 'avoid using',
-  'the fix is', 'the fix was', 'fixed by', 'solved by',
-  'was wrong', 'was broken', 'was incorrect',
-  'gotcha:', 'pitfall:', 'watch out for', 'be careful with',
-  'turns out that',
-  // BUG-006: "Mistake:" prefix (colon form, e.g. "Mistake: I was using...")
-  'mistake:',
-  // Explicit prefix signals for category classification
-  'lesson:', 'lesson learned:',
-]
-
-// Progress indicators
-const PROGRESS_PHRASES = [
-  'finished', 'completed', 'done with', 'implemented',
-  'built', 'created', 'added', 'fixed', 'resolved',
-  'shipped', 'deployed', 'merged', 'released',
-  "i'm working on", 'currently working', 'making progress',
-  'just did', 'just finished',
-  // Phase 23b: present-tense statement patterns
-  "i'm implementing", "i'm building", "i'm adding",
-  "i'm fixing", "i'm refactoring", "i'm setting up",
-  "i'm migrating", "i'm updating", "i'm creating",
-  'started implementing', 'started building', 'started adding'
-]
-
-// Comparison indicators
-const COMPARISON_PHRASES = [
-  ' vs ', ' versus ', 'or should', 'compared to', 'comparing ',
-  'which is better', 'should i use', 'should we use',
-  'what if we switch', 'what if we change', 'what if we replace',
-  'pros and cons', 'tradeoffs', 'trade-offs'
-]
-
-// Pattern indicators
-const PATTERN_PHRASES = [
-  'pattern:', 'best practice:', 'anti-pattern:', 'reusable solution',
-  'reusable approach', 'common issue:', 'this pattern',
-  'recognized pattern', 'document this pattern'
-]
-
-// Exploration indicators
-const EXPLORATION_PHRASES = [
-  'show me', 'timeline', 'trends', 'evolution of',
-  'history of', 'graph', 'how has', 'what happened',
-  'decisions about', 'when did we', 'list episodes'
-]
-
-// Session start indicators — Phase 19: narrowed to require start-of-message
-const SESSION_START_PHRASES = [
-  'starting work', 'beginning work', 'resuming',
-  'picking up', 'getting started', 'opening',
-  'starting on', 'working on', 'beginning on'
-]
-
-// Progress indicators that disqualify session_start
-const PROGRESS_INDICATORS = [
-  'finished', 'completed', 'done', 'fixed', 'resolved',
-  'shipped', 'deployed', 'merged', 'released', 'just did',
-  'making progress', 'currently working'
-]
-
-// Question indicators
-const QUESTION_WORDS = [
-  'what', 'how', 'when', 'why', 'where', 'which',
-  'who', 'can', 'does', 'is', 'are', 'should', 'could', 'would'
-]
-
-// No-action indicators
-const NO_ACTION_PHRASES = [
-  'ok', 'okay', 'thanks', 'thank you', 'got it',
-  'sure', 'yes', 'no', 'cool', 'nice', 'great',
-  'understood', 'noted', 'alright', 'right'
-]
-
-// List/browse indicators
-const LIST_PHRASES = [
-  'list all', 'show all', 'what decisions',
-  'what have i decided', 'all my decisions', 'all decisions',
-  'everything about', 'what do i know', 'what do we know',
-  'show me everything', 'list decisions', 'list memories',
-  'browse', 'dump all', 'show my',
-  // Issue 4: Additional list phrases
-  'list everything', "everything i've stored", "everything i know",
-  "what have i stored", "stored in my brain", "what's in my brain",
-  "what have i remembered", "what do i have stored"
-]
-
-// Update/correct existing memory
-const UPDATE_PHRASES = [
-  'actually,', 'actually ', 'correction:', 'update that',
-  'i changed my mind', 'changed my mind', 'change that to', 'instead of what i said',
-  'supersedes', 'override', 'revise that', 'amend that',
-  'that should be', 'update the decision', 'modify that',
-  'replace that with', 'no wait', 'scratch that, use',
-  // Phase 23b: additional update triggers
-  'switch to', 'instead use', 'use instead', 'no longer using',
-  'moved to', 'migrated to', 'replaced with'
-]
-
-// Delete/forget memory
-const DELETE_PHRASES = [
-  'forget that', 'forget about', 'delete that', 'delete the memory', 'delete the decision',
-  'remove that memory', 'remove that decision', 'that was wrong',
-  'discard that', 'erase that', 'undo that decision',
-  'remove the memory', 'clear that', 'drop that',
-  // BUG-006: Bulk delete support
-  'delete all',
-]
-
-// Phase 19 B3: Temporal signal phrases
-const TEMPORAL_PHRASES = [
-  'last week', 'last month', 'last year', 'yesterday', 'today',
-  'this week', 'this month', 'this year',
-  'since january', 'since february', 'since march', 'since april',
-  'since may', 'since june', 'since july', 'since august',
-  'since september', 'since october', 'since november', 'since december',
-  'in january', 'in february', 'in march', 'in april',
-  'in may', 'in june', 'in july', 'in august',
-  'in september', 'in october', 'in november', 'in december',
-  'ago', 'recently', 'before', 'after', 'during',
-  'last few days', 'past week', 'past month',
-  'earlier this', 'earlier today', 'over the past'
-]
-
-// Phase 27: Detail request patterns — "details obs_abc123", "show me obs_abc123"
-const DETAIL_PATTERNS = [
-  /^details?\s+(\S+)/i,           // "details obs_abc123"
-  /^show\s+(?:me\s+)?(\S+)/i,     // "show me obs_abc123" (only when followed by an ID-like string)
-  /^get\s+(?:details?\s+)?(\S+)/i, // "get details obs_abc123"
-  /^expand\s+(\S+)/i,              // "expand obs_abc123"
-  /^more\s+(?:about\s+)?(\S+)/i,   // "more about obs_abc123"
-]
-
-// Phase 27: Timeline patterns
-const TIMELINE_PATTERNS = [
-  /timeline\s+(?:for\s+)?(.+)/i,    // "timeline for expense-tracker"
-  /what\s+did\s+I\s+do\s+(.+)/i,    // "what did I do yesterday"
-  /show\s+(?:me\s+)?history/i,       // "show me history"
-  /recent\s+(?:activity|changes)/i,  // "recent activity"
-]
-
-/** Check if a string looks like an observation ID (contains underscores or 8+ alphanumeric chars) */
-function isIdLike(s: string): boolean {
-  return /[_-]/.test(s) || /^[a-f0-9]{8,}$/i.test(s)
-}
-
-export class IntentClassifier {
-  /**
-   * Classify the intent of a message
-   */
-  classify(message: string): ClassificationResult {
-    const lower = message.toLowerCase().trim()
-    const secondary: Intent[] = []
-
-    // Phase 19 B3: Detect temporal signals for secondary intent
-    const hasTemporal = this.hasTemporalSignal(lower)
-
-    // SLM Phase 1A: Log classification for training data collection
-    const startTime = Date.now()
-
-    // Check in priority order — first confident match wins
-
-    // Helper to log + return in one step
-    const ret = (result: ClassificationResult): ClassificationResult => {
-      this._logTraining(message, result, startTime)
-      return result
-    }
-
-    // 1. no_action: very short messages, greetings, acknowledgments
-    if (this.isNoAction(lower)) {
-      return ret({ primary: 'no_action', confidence: 0.95, secondary: [] })
-    }
-
-    // 2. delete_memory: "forget that", "delete", "remove"
-    if (this.isDeleteMemory(lower)) {
-      return ret({ primary: 'delete_memory', confidence: 0.90, secondary })
-    }
-
-    // 3. update_memory: "actually", "correction:", "change that to"
-    if (this.isUpdateMemory(lower)) {
-      return ret({ primary: 'update_memory', confidence: 0.85, secondary })
-    }
-
-    // 4. store_this: explicit "remember:", "save this:", "I prefer" (never for questions)
-    if (this.isStoreThis(lower, message)) {
-      if (this.hasDecisionSignal(lower)) secondary.push('decision_made')
-      return ret({ primary: 'store_this', confidence: 0.90, secondary })
-    }
-
-    // 5. decision_made: decision phrases + reasoning (never for questions)
-    if (this.isDecisionMade(lower, message)) {
-      if (this.hasComparisonSignal(lower)) secondary.push('comparison')
-      return ret({ primary: 'decision_made', confidence: 0.85, secondary })
-    }
-
-    // 6. mistake_learned: correction/bug/lesson indicators
-    if (this.isMistakeLearned(lower)) {
-      return ret({ primary: 'mistake_learned', confidence: 0.85, secondary })
-    }
-
-    // 7. list_all: "list all", "what decisions", "show all"
-    if (this.isListAll(lower, message)) {
-      return ret({ primary: 'list_all', confidence: 0.85, secondary })
-    }
-
-    // 8. progress_update: completed task indicators (NOT questions)
-    if (this.isProgressUpdate(lower, message)) {
-      if (this.hasSessionSignal(lower)) secondary.push('session_start')
-      return ret({ primary: 'progress_update', confidence: 0.85, secondary })
-    }
-
-    // 9. comparison: vs, which is better, etc.
-    if (this.isComparison(lower)) {
-      if (this.isQuestion(lower, message)) secondary.push('question')
-      if (hasTemporal) secondary.push('exploration')
-      return ret({ primary: 'comparison', confidence: 0.85, secondary })
-    }
-
-    // 10. pattern_found: explicit pattern documentation
-    if (this.isPatternFound(lower)) {
-      return ret({ primary: 'pattern_found', confidence: 0.80, secondary })
-    }
-
-    // 11. session_start: starting/resuming work (Phase 19: narrowed check)
-    if (this.isSessionStart(lower)) {
-      secondary.push('context_needed')
-      return ret({ primary: 'session_start', confidence: 0.90, secondary })
-    }
-
-    // 12. detail_request: "details obs_abc123", "show me <id>" (before exploration to avoid misclassification)
-    if (this.isDetailRequest(lower)) {
-      return ret({ primary: 'detail_request', confidence: 0.90, secondary })
-    }
-
-    // 12b. timeline: "timeline for project", "what did I do yesterday", "recent activity" (before exploration)
-    if (this.isTimeline(lower)) {
-      if (hasTemporal) secondary.push('exploration')
-      return ret({ primary: 'timeline', confidence: 0.85, secondary })
-    }
-
-    // 12c. exploration: trends, graph, evolution, history (general exploration that isn't a specific timeline)
-    if (this.isExploration(lower)) {
-      if (this.isQuestion(lower, message)) secondary.push('question')
-      if (hasTemporal) secondary.push('exploration')
-      return ret({ primary: 'exploration', confidence: 0.75, secondary })
-    }
-
-    // 13. question: starts with question word or ends with ?
-    // Phase 19 B1: Higher confidence for questions
-    if (this.isQuestion(lower, message)) {
-      if (this.hasComparisonSignal(lower)) secondary.push('comparison')
-      if (this.hasExplorationSignal(lower)) secondary.push('exploration')
-      if (hasTemporal) secondary.push('exploration')
-
-      // Phase 19 B1: ? → 0.95, question word → 0.90
-      const confidence = message.trim().endsWith('?') ? 0.95 : 0.90
-      return ret({ primary: 'question', confidence, secondary })
-    }
-
-    // 14. Default: context_needed
-    if (hasTemporal) secondary.push('exploration')
-    const defaultResult = { primary: 'context_needed' as Intent, confidence: 0.60, secondary }
-    this._logTraining(message, defaultResult, startTime)
-    return defaultResult
-  }
-
-  /**
-   * SLM Phase 1A: Log classification result for training data collection.
-   * Fire-and-forget, never blocks the main path.
-   */
-  private _logTraining(message: string, result: ClassificationResult, startTime: number): void {
-    try {
-      const { logTrainingData } = require('@/training/data-store')
-      logTrainingData({
-        task: 'intent' as const,
-        input: message,
-        output: JSON.stringify({ label: result.primary, secondary: result.secondary }),
-        metadata: JSON.stringify({ confidence: result.confidence, elapsed_ms: Date.now() - startTime }),
-      })
-    } catch {
-      // Training data logging is non-critical
-    }
-  }
-
-  private isNoAction(lower: string): boolean {
-    if (lower.length > 30) return false
-    const words = lower.split(/\s+/)
-    if (words.length > 5) return false
-    return NO_ACTION_PHRASES.some(p => lower === p || lower === p + '.' || lower === p + '!')
-  }
-
-  private isStoreThis(lower: string, original?: string): boolean {
-    // Questions are never storage requests — "Do I prefer X?" is a query, not "I prefer X"
-    if (original?.trim().endsWith('?')) return false
-    const firstWord = lower.split(/\s+/)[0] || ''
-    if (QUESTION_WORDS.includes(firstWord)) return false
-    // Phase 19 B4: Additional question guards
-    if (this.startsWithQuestionPattern(lower)) return false
-    if (STORE_PHRASES.some(p => lower.includes(p))) return true
-    // BUG-006: "Using X for Y" at start of message is a declarative preference
-    if (lower.startsWith('using ') && lower.includes(' for ')) return true
-    return false
-  }
-
-  private isDecisionMade(lower: string, original?: string): boolean {
-    // Questions are never decisions — "Did I decide to use X?" is a query
-    if (original?.trim().endsWith('?')) return false
-    const firstWord = lower.split(/\s+/)[0] || ''
-    if (QUESTION_WORDS.includes(firstWord)) return false
-    // Phase 19 B4: Additional question guards
-    if (this.startsWithQuestionPattern(lower)) return false
-
-    const hasDecision = DECISION_PHRASES.some(p => lower.includes(p))
-    if (!hasDecision) return false
-    // Higher confidence if reasoning is also present
-    const hasReasoning = REASONING_PHRASES.some(p => lower.includes(p))
-    return hasReasoning || lower.length > 30
-  }
-
-  private isMistakeLearned(lower: string): boolean {
-    return MISTAKE_PHRASES.some(p => lower.includes(p))
-  }
-
-  private isListAll(lower: string, _original: string): boolean {
-    // "What do I know about X?" is a filtered question, not a list-all
-    // Only treat as list_all when there's no specific topic after the phrase
-    const topicPhrases = ['what do i know about', 'what do we know about', 'everything about']
-    for (const phrase of topicPhrases) {
-      if (lower.includes(phrase)) {
-        const afterPhrase = lower.slice(lower.indexOf(phrase) + phrase.length).trim()
-        // If there's a specific topic after the phrase, it's a question not list_all
-        if (afterPhrase.length > 2 && !afterPhrase.startsWith('this project') && afterPhrase !== '?') {
-          return false
-        }
-      }
-    }
-    return LIST_PHRASES.some(p => lower.includes(p))
-  }
-
-  private isProgressUpdate(lower: string, original: string): boolean {
-    // Must not be a question
-    if (original.trim().endsWith('?')) return false
-    const firstWord = lower.split(/\s+/)[0] || ''
-    if (QUESTION_WORDS.includes(firstWord)) return false
-
-    return PROGRESS_PHRASES.some(p => lower.includes(p))
-  }
-
-  private isComparison(lower: string): boolean {
-    return COMPARISON_PHRASES.some(p => lower.includes(p))
-  }
-
-  private isPatternFound(lower: string): boolean {
-    const hasPattern = PATTERN_PHRASES.some(p => lower.includes(p))
-    // Explicit prefix signals (e.g. "Pattern: ...") need shorter minimum length
-    const hasExplicitPrefix = lower.startsWith('pattern:') || lower.startsWith('best practice:') || lower.startsWith('anti-pattern:')
-    return hasPattern && (hasExplicitPrefix ? lower.length > 20 : lower.length > 50)
-  }
-
-  /**
-   * Phase 19 B2: Narrowed session_start detection.
-   * Must start at beginning of message AND have no progress indicators.
-   * "working on X" in the middle of a sentence is not a session start.
-   */
-  private isSessionStart(lower: string): boolean {
-    // Must NOT have progress indicators (e.g. "finished working on X" is progress, not session start)
-    if (PROGRESS_INDICATORS.some(p => lower.includes(p))) return false
-
-    // Phase 19 B2: Session phrases must match near the start of the message
-    for (const phrase of SESSION_START_PHRASES) {
-      const idx = lower.indexOf(phrase)
-      if (idx !== -1 && idx <= 5) {
-        return true
-      }
-    }
-    return false
-  }
-
-  private isExploration(lower: string): boolean {
-    return EXPLORATION_PHRASES.some(p => lower.includes(p))
-  }
-
-  private isQuestion(lower: string, original: string): boolean {
-    if (original.trim().endsWith('?')) return true
-    const firstWord = lower.split(/\s+/)[0] || ''
-    if (QUESTION_WORDS.includes(firstWord)) return true
-    // Phase 19 B4: "do I", "did we", "have we", "can we" patterns
-    if (this.startsWithQuestionPattern(lower)) return true
-    return false
-  }
-
-  private isUpdateMemory(lower: string): boolean {
-    return UPDATE_PHRASES.some(p => lower.includes(p))
-  }
-
-  private isDeleteMemory(lower: string): boolean {
-    if (lower.length > 150) return false
-    return DELETE_PHRASES.some(p => lower.includes(p))
-  }
-
-  // Secondary signal checks
-  private hasDecisionSignal(lower: string): boolean {
-    return DECISION_PHRASES.some(p => lower.includes(p))
-  }
-
-  private hasComparisonSignal(lower: string): boolean {
-    return COMPARISON_PHRASES.some(p => lower.includes(p))
-  }
-
-  private hasExplorationSignal(lower: string): boolean {
-    return EXPLORATION_PHRASES.some(p => lower.includes(p))
-  }
-
-  private hasSessionSignal(lower: string): boolean {
-    return SESSION_START_PHRASES.some(p => lower.includes(p))
-  }
-
-  /**
-   * Phase 27: Detect detail requests — "details <id>", "show me <id>", "expand <id>"
-   * Only matches when the argument looks like an ID (contains underscores, hyphens, or 8+ hex chars).
-   */
-  private isDetailRequest(lower: string): boolean {
-    for (const pattern of DETAIL_PATTERNS) {
-      const match = lower.match(pattern)
-      if (match && match[1] && isIdLike(match[1])) {
-        return true
-      }
-    }
-    return false
-  }
-
-  /**
-   * Phase 27: Detect timeline requests — "timeline for X", "recent activity", "what did I do yesterday"
-   * Distinct from exploration because it specifically asks for chronological activity view.
-   */
-  private isTimeline(lower: string): boolean {
-    return TIMELINE_PATTERNS.some(p => p.test(lower))
-  }
-
-  /**
-   * Phase 19 B3: Detect temporal signals in the message.
-   * Used to add 'temporal' context to secondary intents.
-   */
-  hasTemporalSignal(lower: string): boolean {
-    return TEMPORAL_PHRASES.some(p => lower.includes(p))
-  }
-
-  /**
-   * Phase 19 B4: Extended question guards.
-   * Catches "do I", "did we", "have we", "can we" etc. patterns
-   * that start with auxiliary verbs not in the QUESTION_WORDS list.
-   */
-  private startsWithQuestionPattern(lower: string): boolean {
-    const questionStarters = [
-      'do i ', 'do we ', 'do you ',
-      'did i ', 'did we ', 'did you ',
-      'have i ', 'have we ', 'have you ',
-      'has it ', 'has the ',
-      'can i ', 'can we ', 'can you ',
-      'will i ', 'will we ', 'will you ',
-      'am i ', 'was i ', 'were we ',
-      'shall we ', 'shall i ',
-      'tell me '
-    ]
-    return questionStarters.some(p => lower.startsWith(p))
-  }
-}
+/**
+ * Brain Intent Classifier
+ * Phase 16 + Phase 19: Rule-based intent classification for the unified brain() tool
+ *
+ * Priority-ordered — first confident match wins.
+ * No LLM calls, pure pattern matching.
+ *
+ * Phase 19 changes:
+ * - B1: Question confidence raised (? → 0.95, question word → 0.90)
+ * - B2: session_start narrowed (must be at start + no progress indicators)
+ * - B3: Temporal signal detection added to secondary intents
+ */
+
+export type Intent =
+  | 'session_start'
+  | 'context_needed'
+  | 'decision_made'
+  | 'store_this'
+  | 'pattern_found'
+  | 'mistake_learned'
+  | 'progress_update'
+  | 'question'
+  | 'comparison'
+  | 'exploration'
+  | 'list_all'
+  | 'update_memory'
+  | 'delete_memory'
+  | 'detail_request'
+  | 'timeline'
+  | 'no_action'
+
+export interface ClassificationResult {
+  primary: Intent
+  confidence: number
+  secondary: Intent[]
+}
+
+// Decision-indicating phrases
+const DECISION_PHRASES = [
+  'i recommend', 'you should use', 'the best approach',
+  'i suggest', 'better to use', 'prefer using',
+  'go with', 'decided to', "let's use", 'we will use',
+  'the solution is', 'implement using', 'going with',
+  'switching to', 'adopting', 'we chose', 'the plan is to',
+  'i decided that', 'decided that', 'choosing', 'we picked',
+  'settled on', 'committing to', 'opting for', 'sticking with',
+  // BUG-006: "Chose X because Y" — bare "chose" at start
+  'chose ',
+]
+
+// Explicit "store this" phrases — the user wants to persist something
+const STORE_PHRASES = [
+  'remember:', 'remember this:', 'remember that',
+  'note to self:', 'note to self', 'note:', 'save this:',
+  'save this', 'store this', 'keep this', 'record this',
+  'i prefer', 'my preference is', 'my convention is',
+  'i like to', 'i always', 'always use', 'never use this',
+  'from now on', 'going forward', 'the rule is',
+  'my approach is', 'my standard is', 'the standard is',
+  'we should always', 'we should never',
+  'i want to remember', 'don\'t forget',
+  'for future reference', 'for the record',
+  'important:', 'key decision:', 'takeaway:',
+  // Issue 3: Declarative patterns ("X should be Y")
+  'should be', 'must be', 'needs to be', 'has to be',
+  'is set to', 'will be set', 'is always', 'are always',
+  'is configured to', 'is configured as',
+  // Issue 6: "I learned that" is a store, not a mistake
+  'i learned that',
+  // Phase 25: Session summary storage
+  'session summary:', 'session summary ',
+  // Explicit prefix signal for preference storage
+  'preference:', 'my preference:',
+]
+
+const REASONING_PHRASES = [
+  'because', 'since', 'due to', 'as it', 'which provides',
+  'this allows', 'this ensures', 'given that', 'considering',
+  'the reason is', 'this way'
+]
+
+// Mistake/correction indicators
+const MISTAKE_PHRASES = [
+  'bug was', 'the issue was', 'the problem was', 'mistake was',
+  'should have', "shouldn't have", 'should not have',
+  'lesson learned', "don't use", 'avoid using',
+  'the fix is', 'the fix was', 'fixed by', 'solved by',
+  'was wrong', 'was broken', 'was incorrect',
+  'gotcha:', 'pitfall:', 'watch out for', 'be careful with',
+  'turns out that',
+  // BUG-006: "Mistake:" prefix (colon form, e.g. "Mistake: I was using...")
+  'mistake:',
+  // Explicit prefix signals for category classification
+  'lesson:', 'lesson learned:',
+]
+
+// Progress indicators
+const PROGRESS_PHRASES = [
+  'finished', 'completed', 'done with', 'implemented',
+  'built', 'created', 'added', 'fixed', 'resolved',
+  'shipped', 'deployed', 'merged', 'released',
+  "i'm working on", 'currently working', 'making progress',
+  'just did', 'just finished',
+  // Phase 23b: present-tense statement patterns
+  "i'm implementing", "i'm building", "i'm adding",
+  "i'm fixing", "i'm refactoring", "i'm setting up",
+  "i'm migrating", "i'm updating", "i'm creating",
+  'started implementing', 'started building', 'started adding'
+]
+
+// Comparison indicators
+const COMPARISON_PHRASES = [
+  ' vs ', ' versus ', 'or should', 'compared to', 'comparing ',
+  'which is better', 'should i use', 'should we use',
+  'what if we switch', 'what if we change', 'what if we replace',
+  'pros and cons', 'tradeoffs', 'trade-offs'
+]
+
+// Pattern indicators
+const PATTERN_PHRASES = [
+  'pattern:', 'best practice:', 'anti-pattern:', 'reusable solution',
+  'reusable approach', 'common issue:', 'this pattern',
+  'recognized pattern', 'document this pattern'
+]
+
+// Exploration indicators
+const EXPLORATION_PHRASES = [
+  'show me', 'timeline', 'trends', 'evolution of',
+  'history of', 'graph', 'how has', 'what happened',
+  'decisions about', 'when did we', 'list episodes'
+]
+
+// Session start indicators — Phase 19: narrowed to require start-of-message
+const SESSION_START_PHRASES = [
+  'starting work', 'beginning work', 'resuming',
+  'picking up', 'getting started', 'opening',
+  'starting on', 'working on', 'beginning on'
+]
+
+// Progress indicators that disqualify session_start
+const PROGRESS_INDICATORS = [
+  'finished', 'completed', 'done', 'fixed', 'resolved',
+  'shipped', 'deployed', 'merged', 'released', 'just did',
+  'making progress', 'currently working'
+]
+
+// Question indicators
+const QUESTION_WORDS = [
+  'what', 'how', 'when', 'why', 'where', 'which',
+  'who', 'can', 'does', 'is', 'are', 'should', 'could', 'would'
+]
+
+// No-action indicators
+const NO_ACTION_PHRASES = [
+  'ok', 'okay', 'thanks', 'thank you', 'got it',
+  'sure', 'yes', 'no', 'cool', 'nice', 'great',
+  'understood', 'noted', 'alright', 'right'
+]
+
+// List/browse indicators
+const LIST_PHRASES = [
+  'list all', 'show all', 'what decisions',
+  'what have i decided', 'all my decisions', 'all decisions',
+  'everything about', 'what do i know', 'what do we know',
+  'show me everything', 'list decisions', 'list memories',
+  'browse', 'dump all', 'show my',
+  // Issue 4: Additional list phrases
+  'list everything', "everything i've stored", "everything i know",
+  "what have i stored", "stored in my brain", "what's in my brain",
+  "what have i remembered", "what do i have stored"
+]
+
+// Update/correct existing memory
+const UPDATE_PHRASES = [
+  'actually,', 'actually ', 'correction:', 'update that',
+  'i changed my mind', 'changed my mind', 'change that to', 'instead of what i said',
+  'supersedes', 'override', 'revise that', 'amend that',
+  'that should be', 'update the decision', 'modify that',
+  'replace that with', 'no wait', 'scratch that, use',
+  // Phase 23b: additional update triggers
+  'switch to', 'instead use', 'use instead', 'no longer using',
+  'moved to', 'migrated to', 'replaced with'
+]
+
+// Delete/forget memory
+const DELETE_PHRASES = [
+  'forget that', 'forget about', 'delete that', 'delete the memory', 'delete the decision',
+  'remove that memory', 'remove that decision', 'that was wrong',
+  'discard that', 'erase that', 'undo that decision',
+  'remove the memory', 'clear that', 'drop that',
+  // BUG-006: Bulk delete support
+  'delete all',
+]
+
+// Phase 19 B3: Temporal signal phrases
+const TEMPORAL_PHRASES = [
+  'last week', 'last month', 'last year', 'yesterday', 'today',
+  'this week', 'this month', 'this year',
+  'since january', 'since february', 'since march', 'since april',
+  'since may', 'since june', 'since july', 'since august',
+  'since september', 'since october', 'since november', 'since december',
+  'in january', 'in february', 'in march', 'in april',
+  'in may', 'in june', 'in july', 'in august',
+  'in september', 'in october', 'in november', 'in december',
+  'ago', 'recently', 'before', 'after', 'during',
+  'last few days', 'past week', 'past month',
+  'earlier this', 'earlier today', 'over the past'
+]
+
+// Phase 27: Detail request patterns — "details obs_abc123", "show me obs_abc123"
+const DETAIL_PATTERNS = [
+  /^details?\s+(\S+)/i,           // "details obs_abc123"
+  /^show\s+(?:me\s+)?(\S+)/i,     // "show me obs_abc123" (only when followed by an ID-like string)
+  /^get\s+(?:details?\s+)?(\S+)/i, // "get details obs_abc123"
+  /^expand\s+(\S+)/i,              // "expand obs_abc123"
+  /^more\s+(?:about\s+)?(\S+)/i,   // "more about obs_abc123"
+]
+
+// Phase 27: Timeline patterns
+const TIMELINE_PATTERNS = [
+  /timeline\s+(?:for\s+)?(.+)/i,    // "timeline for expense-tracker"
+  /what\s+did\s+I\s+do\s+(.+)/i,    // "what did I do yesterday"
+  /show\s+(?:me\s+)?history/i,       // "show me history"
+  /recent\s+(?:activity|changes)/i,  // "recent activity"
+]
+
+/** Check if a string looks like an observation ID (contains underscores or 8+ alphanumeric chars) */
+function isIdLike(s: string): boolean {
+  return /[_-]/.test(s) || /^[a-f0-9]{8,}$/i.test(s)
+}
+
+export class IntentClassifier {
+  /**
+   * Classify the intent of a message
+   */
+  classify(message: string): ClassificationResult {
+    const lower = message.toLowerCase().trim()
+    const secondary: Intent[] = []
+
+    // Phase 19 B3: Detect temporal signals for secondary intent
+    const hasTemporal = this.hasTemporalSignal(lower)
+
+    // SLM Phase 1A: Log classification for training data collection
+    const startTime = Date.now()
+
+    // Check in priority order — first confident match wins
+
+    // Helper to log + return in one step
+    const ret = (result: ClassificationResult): ClassificationResult => {
+      this._logTraining(message, result, startTime)
+      return result
+    }
+
+    // 1. no_action: very short messages, greetings, acknowledgments
+    if (this.isNoAction(lower)) {
+      return ret({ primary: 'no_action', confidence: 0.95, secondary: [] })
+    }
+
+    // 2. delete_memory: "forget that", "delete", "remove"
+    if (this.isDeleteMemory(lower)) {
+      return ret({ primary: 'delete_memory', confidence: 0.90, secondary })
+    }
+
+    // 3. update_memory: "actually", "correction:", "change that to"
+    if (this.isUpdateMemory(lower)) {
+      return ret({ primary: 'update_memory', confidence: 0.85, secondary })
+    }
+
+    // 4. store_this: explicit "remember:", "save this:", "I prefer" (never for questions)
+    if (this.isStoreThis(lower, message)) {
+      if (this.hasDecisionSignal(lower)) secondary.push('decision_made')
+      return ret({ primary: 'store_this', confidence: 0.90, secondary })
+    }
+
+    // 5. decision_made: decision phrases + reasoning (never for questions)
+    if (this.isDecisionMade(lower, message)) {
+      if (this.hasComparisonSignal(lower)) secondary.push('comparison')
+      return ret({ primary: 'decision_made', confidence: 0.85, secondary })
+    }
+
+    // 6. mistake_learned: correction/bug/lesson indicators
+    if (this.isMistakeLearned(lower)) {
+      return ret({ primary: 'mistake_learned', confidence: 0.85, secondary })
+    }
+
+    // 7. list_all: "list all", "what decisions", "show all"
+    if (this.isListAll(lower, message)) {
+      return ret({ primary: 'list_all', confidence: 0.85, secondary })
+    }
+
+    // 8. progress_update: completed task indicators (NOT questions)
+    if (this.isProgressUpdate(lower, message)) {
+      if (this.hasSessionSignal(lower)) secondary.push('session_start')
+      return ret({ primary: 'progress_update', confidence: 0.85, secondary })
+    }
+
+    // 9. comparison: vs, which is better, etc.
+    if (this.isComparison(lower)) {
+      if (this.isQuestion(lower, message)) secondary.push('question')
+      if (hasTemporal) secondary.push('exploration')
+      return ret({ primary: 'comparison', confidence: 0.85, secondary })
+    }
+
+    // 10. pattern_found: explicit pattern documentation
+    if (this.isPatternFound(lower)) {
+      return ret({ primary: 'pattern_found', confidence: 0.80, secondary })
+    }
+
+    // 11. session_start: starting/resuming work (Phase 19: narrowed check)
+    if (this.isSessionStart(lower)) {
+      secondary.push('context_needed')
+      return ret({ primary: 'session_start', confidence: 0.90, secondary })
+    }
+
+    // 12. detail_request: "details obs_abc123", "show me <id>" (before exploration to avoid misclassification)
+    if (this.isDetailRequest(lower)) {
+      return ret({ primary: 'detail_request', confidence: 0.90, secondary })
+    }
+
+    // 12b. timeline: "timeline for project", "what did I do yesterday", "recent activity" (before exploration)
+    if (this.isTimeline(lower)) {
+      if (hasTemporal) secondary.push('exploration')
+      return ret({ primary: 'timeline', confidence: 0.85, secondary })
+    }
+
+    // 12c. exploration: trends, graph, evolution, history (general exploration that isn't a specific timeline)
+    if (this.isExploration(lower)) {
+      if (this.isQuestion(lower, message)) secondary.push('question')
+      if (hasTemporal) secondary.push('exploration')
+      return ret({ primary: 'exploration', confidence: 0.75, secondary })
+    }
+
+    // 13. question: starts with question word or ends with ?
+    // Phase 19 B1: Higher confidence for questions
+    if (this.isQuestion(lower, message)) {
+      if (this.hasComparisonSignal(lower)) secondary.push('comparison')
+      if (this.hasExplorationSignal(lower)) secondary.push('exploration')
+      if (hasTemporal) secondary.push('exploration')
+
+      // Phase 19 B1: ? → 0.95, question word → 0.90
+      const confidence = message.trim().endsWith('?') ? 0.95 : 0.90
+      return ret({ primary: 'question', confidence, secondary })
+    }
+
+    // 14. Default: context_needed
+    if (hasTemporal) secondary.push('exploration')
+    const defaultResult = { primary: 'context_needed' as Intent, confidence: 0.60, secondary }
+    this._logTraining(message, defaultResult, startTime)
+    return defaultResult
+  }
+
+  /**
+   * SLM Phase 1A: Log classification result for training data collection.
+   * Fire-and-forget, never blocks the main path.
+   */
+  private _logTraining(message: string, result: ClassificationResult, startTime: number): void {
+    try {
+      const { logTrainingData } = require('@/training/data-store')
+      logTrainingData({
+        task: 'intent' as const,
+        input: message,
+        output: JSON.stringify({ label: result.primary, secondary: result.secondary }),
+        metadata: JSON.stringify({ confidence: result.confidence, elapsed_ms: Date.now() - startTime }),
+      })
+    } catch {
+      // Training data logging is non-critical
+    }
+  }
+
+  private isNoAction(lower: string): boolean {
+    if (lower.length > 30) return false
+    const words = lower.split(/\s+/)
+    if (words.length > 5) return false
+    return NO_ACTION_PHRASES.some(p => lower === p || lower === p + '.' || lower === p + '!')
+  }
+
+  private isStoreThis(lower: string, original?: string): boolean {
+    // Questions are never storage requests — "Do I prefer X?" is a query, not "I prefer X"
+    if (original?.trim().endsWith('?')) return false
+    const firstWord = lower.split(/\s+/)[0] || ''
+    if (QUESTION_WORDS.includes(firstWord)) return false
+    // Phase 19 B4: Additional question guards
+    if (this.startsWithQuestionPattern(lower)) return false
+    if (STORE_PHRASES.some(p => lower.includes(p))) return true
+    // BUG-006: "Using X for Y" at start of message is a declarative preference
+    if (lower.startsWith('using ') && lower.includes(' for ')) return true
+    return false
+  }
+
+  private isDecisionMade(lower: string, original?: string): boolean {
+    // Questions are never decisions — "Did I decide to use X?" is a query
+    if (original?.trim().endsWith('?')) return false
+    const firstWord = lower.split(/\s+/)[0] || ''
+    if (QUESTION_WORDS.includes(firstWord)) return false
+    // Phase 19 B4: Additional question guards
+    if (this.startsWithQuestionPattern(lower)) return false
+
+    const hasDecision = DECISION_PHRASES.some(p => lower.includes(p))
+    if (!hasDecision) return false
+    // Higher confidence if reasoning is also present
+    const hasReasoning = REASONING_PHRASES.some(p => lower.includes(p))
+    return hasReasoning || lower.length > 30
+  }
+
+  private isMistakeLearned(lower: string): boolean {
+    return MISTAKE_PHRASES.some(p => lower.includes(p))
+  }
+
+  private isListAll(lower: string, _original: string): boolean {
+    // "What do I know about X?" is a filtered question, not a list-all
+    // Only treat as list_all when there's no specific topic after the phrase
+    const topicPhrases = ['what do i know about', 'what do we know about', 'everything about']
+    for (const phrase of topicPhrases) {
+      if (lower.includes(phrase)) {
+        const afterPhrase = lower.slice(lower.indexOf(phrase) + phrase.length).trim()
+        // If there's a specific topic after the phrase, it's a question not list_all
+        if (afterPhrase.length > 2 && !afterPhrase.startsWith('this project') && afterPhrase !== '?') {
+          return false
+        }
+      }
+    }
+    return LIST_PHRASES.some(p => lower.includes(p))
+  }
+
+  private isProgressUpdate(lower: string, original: string): boolean {
+    // Must not be a question
+    if (original.trim().endsWith('?')) return false
+    const firstWord = lower.split(/\s+/)[0] || ''
+    if (QUESTION_WORDS.includes(firstWord)) return false
+
+    return PROGRESS_PHRASES.some(p => lower.includes(p))
+  }
+
+  private isComparison(lower: string): boolean {
+    return COMPARISON_PHRASES.some(p => lower.includes(p))
+  }
+
+  private isPatternFound(lower: string): boolean {
+    const hasPattern = PATTERN_PHRASES.some(p => lower.includes(p))
+    // Explicit prefix signals (e.g. "Pattern: ...") need shorter minimum length
+    const hasExplicitPrefix = lower.startsWith('pattern:') || lower.startsWith('best practice:') || lower.startsWith('anti-pattern:')
+    return hasPattern && (hasExplicitPrefix ? lower.length > 20 : lower.length > 50)
+  }
+
+  /**
+   * Phase 19 B2: Narrowed session_start detection.
+   * Must start at beginning of message AND have no progress indicators.
+   * "working on X" in the middle of a sentence is not a session start.
+   */
+  private isSessionStart(lower: string): boolean {
+    // Must NOT have progress indicators (e.g. "finished working on X" is progress, not session start)
+    if (PROGRESS_INDICATORS.some(p => lower.includes(p))) return false
+
+    // Phase 19 B2: Session phrases must match near the start of the message
+    for (const phrase of SESSION_START_PHRASES) {
+      const idx = lower.indexOf(phrase)
+      if (idx !== -1 && idx <= 5) {
+        return true
+      }
+    }
+    return false
+  }
+
+  private isExploration(lower: string): boolean {
+    return EXPLORATION_PHRASES.some(p => lower.includes(p))
+  }
+
+  private isQuestion(lower: string, original: string): boolean {
+    if (original.trim().endsWith('?')) return true
+    const firstWord = lower.split(/\s+/)[0] || ''
+    if (QUESTION_WORDS.includes(firstWord)) return true
+    // Phase 19 B4: "do I", "did we", "have we", "can we" patterns
+    if (this.startsWithQuestionPattern(lower)) return true
+    return false
+  }
+
+  private isUpdateMemory(lower: string): boolean {
+    return UPDATE_PHRASES.some(p => lower.includes(p))
+  }
+
+  private isDeleteMemory(lower: string): boolean {
+    if (lower.length > 150) return false
+    return DELETE_PHRASES.some(p => lower.includes(p))
+  }
+
+  // Secondary signal checks
+  private hasDecisionSignal(lower: string): boolean {
+    return DECISION_PHRASES.some(p => lower.includes(p))
+  }
+
+  private hasComparisonSignal(lower: string): boolean {
+    return COMPARISON_PHRASES.some(p => lower.includes(p))
+  }
+
+  private hasExplorationSignal(lower: string): boolean {
+    return EXPLORATION_PHRASES.some(p => lower.includes(p))
+  }
+
+  private hasSessionSignal(lower: string): boolean {
+    return SESSION_START_PHRASES.some(p => lower.includes(p))
+  }
+
+  /**
+   * Phase 27: Detect detail requests — "details <id>", "show me <id>", "expand <id>"
+   * Only matches when the argument looks like an ID (contains underscores, hyphens, or 8+ hex chars).
+   */
+  private isDetailRequest(lower: string): boolean {
+    for (const pattern of DETAIL_PATTERNS) {
+      const match = lower.match(pattern)
+      if (match && match[1] && isIdLike(match[1])) {
+        return true
+      }
+    }
+    return false
+  }
+
+  /**
+   * Phase 27: Detect timeline requests — "timeline for X", "recent activity", "what did I do yesterday"
+   * Distinct from exploration because it specifically asks for chronological activity view.
+   */
+  private isTimeline(lower: string): boolean {
+    return TIMELINE_PATTERNS.some(p => p.test(lower))
+  }
+
+  /**
+   * Phase 19 B3: Detect temporal signals in the message.
+   * Used to add 'temporal' context to secondary intents.
+   */
+  hasTemporalSignal(lower: string): boolean {
+    return TEMPORAL_PHRASES.some(p => lower.includes(p))
+  }
+
+  /**
+   * Phase 19 B4: Extended question guards.
+   * Catches "do I", "did we", "have we", "can we" etc. patterns
+   * that start with auxiliary verbs not in the QUESTION_WORDS list.
+   */
+  private startsWithQuestionPattern(lower: string): boolean {
+    const questionStarters = [
+      'do i ', 'do we ', 'do you ',
+      'did i ', 'did we ', 'did you ',
+      'have i ', 'have we ', 'have you ',
+      'has it ', 'has the ',
+      'can i ', 'can we ', 'can you ',
+      'will i ', 'will we ', 'will you ',
+      'am i ', 'was i ', 'were we ',
+      'shall we ', 'shall i ',
+      'tell me '
+    ]
+    return questionStarters.some(p => lower.startsWith(p))
+  }
+}