chrome-devtools-frontend 1.0.950971 → 1.0.952403

package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts

@@ -183,66 +183,66 @@ const DEFAULT_METADATA = {
 // eslint-disable-next-line rulesdir/custom_element_definitions_location
 export class UserAgentClientHintsForm extends HTMLElement {
   static readonly litTagName = LitHtml.literal`devtools-user-agent-client-hints-form`;
-  private readonly shadow = this.attachShadow({mode: 'open'});
+  readonly #shadow = this.attachShadow({mode: 'open'});
 
-  private isFormOpened: boolean = false;
-  private isFormDisabled: boolean = false;
-  private metaData: Protocol.Emulation.UserAgentMetadata = DEFAULT_METADATA;
-  private showMobileCheckbox: boolean = false;
-  private showSubmitButton: boolean = false;
-  private brandsModifiedAriaMessage: string = '';
+  #isFormOpened: boolean = false;
+  #isFormDisabled: boolean = false;
+  #metaData: Protocol.Emulation.UserAgentMetadata = DEFAULT_METADATA;
+  #showMobileCheckbox: boolean = false;
+  #showSubmitButton: boolean = false;
+  #brandsModifiedAriaMessage: string = '';
 
   connectedCallback(): void {
-    this.shadow.adoptedStyleSheets = [userAgentClientHintsFormStyles];
+    this.#shadow.adoptedStyleSheets = [userAgentClientHintsFormStyles];
   }
 
   set value(data: UserAgentClientHintsFormData) {
     const {metaData = DEFAULT_METADATA, showMobileCheckbox = false, showSubmitButton = false} = data;
-    this.metaData = {
-      ...this.metaData,
+    this.#metaData = {
+      ...this.#metaData,
       ...metaData,
     };
-    this.showMobileCheckbox = showMobileCheckbox;
-    this.showSubmitButton = showSubmitButton;
-    this.render();
+    this.#showMobileCheckbox = showMobileCheckbox;
+    this.#showSubmitButton = showSubmitButton;
+    this.#render();
   }
 
   get value(): UserAgentClientHintsFormData {
     return {
-      metaData: this.metaData,
+      metaData: this.#metaData,
     };
   }
 
   set disabled(disableForm: boolean) {
-    this.isFormDisabled = disableForm;
-    this.isFormOpened = false;
-    this.render();
+    this.#isFormDisabled = disableForm;
+    this.#isFormOpened = false;
+    this.#render();
   }
 
   get disabled(): boolean {
-    return this.isFormDisabled;
+    return this.#isFormDisabled;
   }
 
-  private handleTreeExpand = (event: KeyboardEvent): void => {
+  #handleTreeExpand = (event: KeyboardEvent): void => {
     if (event.code === 'Space' || event.code === 'Enter' || event.code === 'ArrowLeft' || event.code === 'ArrowRight') {
       event.stopPropagation();
-      this.handleTreeClick(event.code);
+      this.#handleTreeClick(event.code);
     }
   };
 
-  private handleTreeClick = (key: string): void => {
-    if (this.isFormDisabled) {
+  #handleTreeClick = (key: string): void => {
+    if (this.#isFormDisabled) {
       return;
     }
-    if ((key === 'ArrowLeft' && !this.isFormOpened) || (key === 'ArrowRight' && this.isFormOpened)) {
+    if ((key === 'ArrowLeft' && !this.#isFormOpened) || (key === 'ArrowRight' && this.#isFormOpened)) {
       return;
     }
-    this.isFormOpened = !this.isFormOpened;
-    this.render();
+    this.#isFormOpened = !this.#isFormOpened;
+    this.#render();
   };
 
-  private handleBrandInputChange = (value: string, index: number, brandInputType: 'brandName'|'brandVersion'): void => {
-    const updatedBrands = this.metaData.brands?.map((browserBrand, brandIndex) => {
+  #handleBrandInputChange = (value: string, index: number, brandInputType: 'brandName'|'brandVersion'): void => {
+    const updatedBrands = this.#metaData.brands?.map((browserBrand, brandIndex) => {
       if (brandIndex === index) {
         const {brand, version} = browserBrand;
         if (brandInputType === 'brandName') {
@@ -258,24 +258,24 @@ export class UserAgentClientHintsForm extends HTMLElement {
       }
       return browserBrand;
     });
-    this.metaData = {
-      ...this.metaData,
+    this.#metaData = {
+      ...this.#metaData,
       brands: updatedBrands,
     };
     this.dispatchEvent(new ClientHintsChangeEvent());
-    this.render();
+    this.#render();
   };
 
-  private handleBrandDelete = (index: number): void => {
-    const {brands = []} = this.metaData;
+  #handleBrandDelete = (index: number): void => {
+    const {brands = []} = this.#metaData;
     brands.splice(index, 1);
-    this.metaData = {
-      ...this.metaData,
+    this.#metaData = {
+      ...this.#metaData,
       brands,
     };
     this.dispatchEvent(new ClientHintsChangeEvent());
-    this.brandsModifiedAriaMessage = i18nString(UIStrings.deletedBrand);
-    this.render();
+    this.#brandsModifiedAriaMessage = i18nString(UIStrings.deletedBrand);
+    this.#render();
 
     // after deleting a brand row, focus on next Brand input if available,
     // otherwise focus on the "Add Brand" button
@@ -286,10 +286,10 @@ export class UserAgentClientHintsForm extends HTMLElement {
     (nextFocusElement as HTMLElement)?.focus();
   };
 
-  private handleAddBrandClick = (): void => {
-    const {brands} = this.metaData;
-    this.metaData = {
-      ...this.metaData,
+  #handleAddBrandClick = (): void => {
+    const {brands} = this.#metaData;
+    this.#metaData = {
+      ...this.#metaData,
       brands: [
         ...(Array.isArray(brands) ? brands : []),
         {
@@ -299,8 +299,8 @@ export class UserAgentClientHintsForm extends HTMLElement {
       ],
     };
     this.dispatchEvent(new ClientHintsChangeEvent());
-    this.brandsModifiedAriaMessage = i18nString(UIStrings.addedBrand);
-    this.render();
+    this.#brandsModifiedAriaMessage = i18nString(UIStrings.addedBrand);
+    this.#render();
     const brandInputElements = this.shadowRoot?.querySelectorAll('.brand-name-input');
     if (brandInputElements) {
       const lastBrandInputElement = Array.from(brandInputElements).pop();
@@ -310,45 +310,45 @@ export class UserAgentClientHintsForm extends HTMLElement {
     }
   };
 
-  private handleAddBrandKeyPress = (event: KeyboardEvent): void => {
+  #handleAddBrandKeyPress = (event: KeyboardEvent): void => {
     if (event.code === 'Space' || event.code === 'Enter') {
       event.preventDefault();
-      this.handleAddBrandClick();
+      this.#handleAddBrandClick();
     }
   };
 
-  private handleInputChange = (stateKey: keyof Protocol.Emulation.UserAgentMetadata, value: string|boolean): void => {
-    if (stateKey in this.metaData) {
-      this.metaData = {
-        ...this.metaData,
+  #handleInputChange = (stateKey: keyof Protocol.Emulation.UserAgentMetadata, value: string|boolean): void => {
+    if (stateKey in this.#metaData) {
+      this.#metaData = {
+        ...this.#metaData,
         [stateKey]: value,
       };
-      this.render();
+      this.#render();
     }
     this.dispatchEvent(new ClientHintsChangeEvent());
   };
 
-  private handleLinkPress = (event: KeyboardEvent): void => {
+  #handleLinkPress = (event: KeyboardEvent): void => {
     if (event.code === 'Space' || event.code === 'Enter') {
       event.preventDefault();
       (event.target as HTMLAnchorElement).click();
     }
   };
 
-  private handleSubmit = (event: Event): void => {
+  #handleSubmit = (event: Event): void => {
     event.preventDefault();
-    if (this.showSubmitButton) {
-      this.dispatchEvent(new ClientHintsSubmitEvent(this.metaData));
-      this.render();
+    if (this.#showSubmitButton) {
+      this.dispatchEvent(new ClientHintsSubmitEvent(this.#metaData));
+      this.#render();
     }
   };
 
-  private renderInputWithLabel(
+  #renderInputWithLabel(
       label: string, placeholder: string, value: string,
       stateKey: keyof Protocol.Emulation.UserAgentMetadata): LitHtml.TemplateResult {
     const handleInputChange = (event: KeyboardEvent): void => {
       const value = (event.target as HTMLInputElement).value;
-      this.handleInputChange(stateKey, value);
+      this.#handleInputChange(stateKey, value);
     };
     return LitHtml.html`
       <label class="full-row label input-field-label-container">
@@ -364,15 +364,15 @@ export class UserAgentClientHintsForm extends HTMLElement {
     `;
   }
 
-  private renderPlatformSection(): LitHtml.TemplateResult {
-    const {platform, platformVersion} = this.metaData;
+  #renderPlatformSection(): LitHtml.TemplateResult {
+    const {platform, platformVersion} = this.#metaData;
     const handlePlatformNameChange = (event: KeyboardEvent): void => {
       const value = (event.target as HTMLInputElement).value;
-      this.handleInputChange('platform', value);
+      this.#handleInputChange('platform', value);
     };
     const handlePlatformVersionChange = (event: KeyboardEvent): void => {
       const value = (event.target as HTMLInputElement).value;
-      this.handleInputChange('platformVersion', value);
+      this.#handleInputChange('platformVersion', value);
     };
     return LitHtml.html`
       <span class="full-row label">${i18nString(UIStrings.platformLabel)}</span>
@@ -397,28 +397,28 @@ export class UserAgentClientHintsForm extends HTMLElement {
     `;
   }
 
-  private renderDeviceModelSection(): LitHtml.TemplateResult {
-    const {model, mobile} = this.metaData;
+  #renderDeviceModelSection(): LitHtml.TemplateResult {
+    const {model, mobile} = this.#metaData;
     const handleDeviceModelChange = (event: KeyboardEvent): void => {
       const value = (event.target as HTMLInputElement).value;
-      this.handleInputChange('model', value);
+      this.#handleInputChange('model', value);
     };
     const handleMobileChange = (event: KeyboardEvent): void => {
       const value = (event.target as HTMLInputElement).checked;
-      this.handleInputChange('mobile', value);
+      this.#handleInputChange('mobile', value);
     };
-    const mobileCheckboxInput = this.showMobileCheckbox ? LitHtml.html`
+    const mobileCheckboxInput = this.#showMobileCheckbox ? LitHtml.html`
       <label class="mobile-checkbox-container">
         <input type="checkbox" @input=${handleMobileChange} .checked=${mobile} />
         ${i18nString(UIStrings.mobileCheckboxLabel)}
       </label>
     ` :
-                                                          LitHtml.html``;
+                                                           LitHtml.html``;
     return LitHtml.html`
       <span class="full-row label">${i18nString(UIStrings.deviceModel)}</span>
       <div class="full-row brand-row" aria-label=${i18nString(UIStrings.deviceProperties)} role="group">
         <input
-          class="input-field ${this.showMobileCheckbox ? 'device-model-input' : 'full-row'}"
+          class="input-field ${this.#showMobileCheckbox ? 'device-model-input' : 'full-row'}"
           type="text"
           @input=${handleDeviceModelChange}
           .value=${model}
@@ -429,7 +429,7 @@ export class UserAgentClientHintsForm extends HTMLElement {
     `;
   }
 
-  private renderBrands(): LitHtml.TemplateResult {
+  #renderBrands(): LitHtml.TemplateResult {
     const {
       brands =
           [
@@ -438,11 +438,11 @@ export class UserAgentClientHintsForm extends HTMLElement {
               version: '',
             },
           ],
-    } = this.metaData;
+    } = this.#metaData;
     const brandElements = brands.map((brandRow, index) => {
       const {brand, version} = brandRow;
       const handleDeleteClick = (): void => {
-        this.handleBrandDelete(index);
+        this.#handleBrandDelete(index);
       };
       const handleKeyPress = (event: KeyboardEvent): void => {
         if (event.code === 'Space' || event.code === 'Enter') {
@@ -452,11 +452,11 @@ export class UserAgentClientHintsForm extends HTMLElement {
       };
       const handleBrandBrowserChange = (event: KeyboardEvent): void => {
         const value = (event.target as HTMLInputElement).value;
-        this.handleBrandInputChange(value, index, 'brandName');
+        this.#handleBrandInputChange(value, index, 'brandName');
       };
       const handleBrandVersionChange = (event: KeyboardEvent): void => {
         const value = (event.target as HTMLInputElement).value;
-        this.handleBrandInputChange(value, index, 'brandVersion');
+        this.#handleBrandInputChange(value, index, 'brandVersion');
       };
       return LitHtml.html`
         <div class="full-row brand-row" aria-label=${i18nString(UIStrings.brandProperties)} role="group">
@@ -508,8 +508,8 @@ export class UserAgentClientHintsForm extends HTMLElement {
         tabindex="0"
         id="add-brand-button"
         aria-label=${i18nString(UIStrings.addBrand)}
-        @click=${this.handleAddBrandClick}
-        @keypress=${this.handleAddBrandKeyPress}
+        @click=${this.#handleAddBrandClick}
+        @keypress=${this.#handleAddBrandKeyPress}
       >
         <${IconButton.Icon.Icon.litTagName}
           aria-hidden="true"
@@ -522,18 +522,18 @@ export class UserAgentClientHintsForm extends HTMLElement {
     `;
   }
 
-  private render(): void {
-    const {fullVersion, architecture} = this.metaData;
-    const brandSection = this.renderBrands();
-    const fullBrowserInput = this.renderInputWithLabel(
+  #render(): void {
+    const {fullVersion, architecture} = this.#metaData;
+    const brandSection = this.#renderBrands();
+    const fullBrowserInput = this.#renderInputWithLabel(
         i18nString(UIStrings.fullBrowserVersion), i18nString(UIStrings.fullBrowserVersionPlaceholder),
         fullVersion || '', 'fullVersion');
-    const platformSection = this.renderPlatformSection();
-    const architectureInput = this.renderInputWithLabel(
+    const platformSection = this.#renderPlatformSection();
+    const architectureInput = this.#renderInputWithLabel(
         i18nString(UIStrings.architecture), i18nString(UIStrings.architecturePlaceholder), architecture,
         'architecture');
-    const deviceModelSection = this.renderDeviceModelSection();
-    const submitButton = this.showSubmitButton ? LitHtml.html`
+    const deviceModelSection = this.#renderDeviceModelSection();
+    const submitButton = this.#showSubmitButton ? LitHtml.html`
       <${Buttons.Button.Button.litTagName}
         .variant=${Buttons.Button.Variant.SECONDARY}
         .type=${'submit'}
@@ -541,23 +541,23 @@ export class UserAgentClientHintsForm extends HTMLElement {
         ${i18nString(UIStrings.update)}
       </${Buttons.Button.Button.litTagName}>
     ` :
-                                                 LitHtml.html``;
+                                                  LitHtml.html``;
     const output = LitHtml.html`
       <section class="root">
         <div
           class="tree-title"
           role="button"
-          @click=${this.handleTreeClick}
+          @click=${this.#handleTreeClick}
           tabindex="0"
-          @keydown=${this.handleTreeExpand}
-          aria-expanded=${this.isFormOpened}
+          @keydown=${this.#handleTreeExpand}
+          aria-expanded=${this.#isFormOpened}
           aria-controls="form-container"
-          @disabled=${this.isFormDisabled}
-          aria-disabled=${this.isFormDisabled}
+          @disabled=${this.#isFormDisabled}
+          aria-disabled=${this.#isFormDisabled}
           aria-label=${i18nString(UIStrings.title)}
         >
           <${IconButton.Icon.Icon.litTagName}
-            class=${this.isFormOpened ? '' : 'rotate-icon'}
+            class=${this.#isFormOpened ? '' : 'rotate-icon'}
             .data=${
         {color: 'var(--client-hints-form-icon-color)', iconName: 'chromeSelect', width: '20px'} as
         IconButton.Icon.IconData}
@@ -569,7 +569,7 @@ export class UserAgentClientHintsForm extends HTMLElement {
            href="https://web.dev/user-agent-client-hints/"
            target="_blank"
            class="info-link"
-           @keypress=${this.handleLinkPress}
+           @keypress=${this.#handleLinkPress}
            aria-label=${i18nString(UIStrings.userAgentClientHintsInfo)}
           >
             <${IconButton.Icon.Icon.litTagName}
@@ -582,8 +582,8 @@ export class UserAgentClientHintsForm extends HTMLElement {
         </div>
         <form
           id="form-container"
-          class="form-container ${this.isFormOpened ? '' : 'hide-container'}"
-          @submit=${this.handleSubmit}
+          class="form-container ${this.#isFormOpened ? '' : 'hide-container'}"
+          @submit=${this.#handleSubmit}
         >
           ${brandSection}
           ${fullBrowserInput}
@@ -592,18 +592,18 @@ export class UserAgentClientHintsForm extends HTMLElement {
           ${deviceModelSection}
           ${submitButton}
         </form>
-        <div aria-live="polite" aria-label=${this.brandsModifiedAriaMessage}></div>
+        <div aria-live="polite" aria-label=${this.#brandsModifiedAriaMessage}></div>
       </section>
     `;
     // clang-format off
-    LitHtml.render(output, this.shadow, {host: this});
+    LitHtml.render(output, this.#shadow, {host: this});
     // clang-format on
   }
 
   validate = (): UI.ListWidget.ValidatorResult => {
-    for (const [metaDataKey, metaDataValue] of Object.entries(this.metaData)) {
+    for (const [metaDataKey, metaDataValue] of Object.entries(this.#metaData)) {
       if (metaDataKey === 'brands') {
-        const isBrandValid = this.metaData.brands?.every(({brand, version}) => {
+        const isBrandValid = this.#metaData.brands?.every(({brand, version}) => {
           const brandNameResult = EmulationUtils.UserAgentMetadata.validateAsStructuredHeadersString(
               brand, i18nString(UIStrings.notRepresentable));
           const brandVersionResult = EmulationUtils.UserAgentMetadata.validateAsStructuredHeadersString(

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -172,12 +172,13 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
 
   private onTypeChanged(): void {
     const type = this.breakpointType;
+    this.isLogpoint = type === BreakpointType.Logpoint;
     if (type === BreakpointType.Breakpoint) {
       this.finishEditing(true, '');
-    } else {
-      this.editor.dispatch({effects: this.placeholderCompartment.reconfigure(this.getPlaceholder())});
-      this.updateTooltip();
+      return;
     }
+    this.editor.dispatch({effects: this.placeholderCompartment.reconfigure(this.getPlaceholder())});
+    this.updateTooltip();
   }
 
   private get breakpointType(): string|null {

package/front_end/panels/sources/FilteredUISourceCodeListProvider.ts

@@ -124,7 +124,7 @@ export class FilteredUISourceCodeListProvider extends QuickOpen.FilteredListWidg
 
     titleElement.textContent = uiSourceCode.displayName() + (this.queryLineNumberAndColumnNumber || '');
     this.renderSubtitleElement(subtitleElement, fullDisplayName.substring(0, fileNameIndex + 1));
-    /** @type {!HTMLElement} */ UI.Tooltip.Tooltip.install((subtitleElement as HTMLElement), fullDisplayName);
+    UI.Tooltip.Tooltip.install((subtitleElement as HTMLElement), fullDisplayName);
     const ranges = [];
     for (let i = 0; i < indexes.length; ++i) {
       ranges.push({offset: indexes[i], length: 1});
@@ -151,7 +151,7 @@ export class FilteredUISourceCodeListProvider extends QuickOpen.FilteredListWidg
     first.textContent = text.substring(0, splitPosition);
     const second = element.createChild('div', 'second-part');
     second.textContent = text.substring(splitPosition);
-    /** @type {!HTMLElement} */ UI.Tooltip.Tooltip.install((element as HTMLElement), text);
+    UI.Tooltip.Tooltip.install((element as HTMLElement), text);
   }
 
   selectItem(itemIndex: number|null, promptValue: string): void {

package/front_end/panels/sources/NavigatorView.ts

@@ -559,7 +559,7 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
       if (target) {
         return this.domainNode(uiSourceCode, project, target, frame, projectOrigin);
       }
-      return /** @type {!NavigatorTreeNode} */ this.rootNode.child(project.id()) as NavigatorTreeNode;
+      return this.rootNode.child(project.id()) as NavigatorTreeNode;
     }
 
     const parentNode =
@@ -982,15 +982,11 @@ const boostOrderForNode = new WeakSet<UI.TreeOutline.TreeElement>();
 export class NavigatorFolderTreeElement extends UI.TreeOutline.TreeElement {
   private readonly nodeType: string;
   private readonly navigatorView: NavigatorView;
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  private hoverCallback: ((arg0: boolean) => any)|undefined;
+  private hoverCallback: ((arg0: boolean) => void)|undefined;
   node!: NavigatorTreeNode;
   private hovered?: boolean;
 
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  constructor(navigatorView: NavigatorView, type: string, title: string, hoverCallback?: ((arg0: boolean) => any)) {
+  constructor(navigatorView: NavigatorView, type: string, title: string, hoverCallback?: ((arg0: boolean) => void)) {
     super('', true);
     this.listItemElement.classList.add('navigator-' + type + '-tree-item', 'navigator-folder-tree-item');
     UI.ARIAUtils.setAccessibleName(this.listItemElement, `${title}, ${type}`);
@@ -1392,9 +1388,7 @@ export class NavigatorUISourceCodeTreeNode extends NavigatorTreeNode {
     }
   }
 
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  rename(callback?: ((arg0: boolean) => any)): void {
+  rename(callback?: ((arg0: boolean) => void)): void {
     if (!this.treeElement) {
       return;
     }

package/front_end/panels/sources/ScopeChainSidebarPane.ts

@@ -284,8 +284,7 @@ export class OpenLinearMemoryInspector extends UI.Widget.VBox implements UI.Cont
     }
 
     if (obj instanceof Bindings.DebuggerLanguagePlugins.ValueNode) {
-      const valueNode = /** @type {!Bindings.DebuggerLanguagePlugins.ValueNode} */ obj;
-      return valueNode.inspectableAddress !== undefined;
+      return obj.inspectableAddress !== undefined;
     }
 
     return false;
@@ -307,7 +306,7 @@ export class OpenLinearMemoryInspector extends UI.Widget.VBox implements UI.Cont
     let memoryObj: SDK.RemoteObject.RemoteObject = obj;
 
     if (obj instanceof Bindings.DebuggerLanguagePlugins.ValueNode) {
-      const valueNode = /** @type {!Bindings.DebuggerLanguagePlugins.ValueNode} */ obj;
+      const valueNode = obj;
       address = valueNode.inspectableAddress || 0;
       const callFrame = valueNode.callFrame;
       const response = await obj.debuggerModel().agent.invoke_evaluateOnCallFrame({

package/front_end/panels/sources/SourceMapNamesResolver.ts

@@ -390,16 +390,16 @@ export class RemoteObject extends SDK.RemoteObject.RemoteObject {
 
 // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
 // eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any
-let _scopeResolvedForTest: (...arg0: any[]) => any = function(): void {};
+let _scopeResolvedForTest: (...arg0: any[]) => void = function(): void {};
 
 // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
 // eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any
-export const getScopeResolvedForTest = (): (...arg0: any[]) => any => {
+export const getScopeResolvedForTest = (): (...arg0: any[]) => void => {
   return _scopeResolvedForTest;
 };
 
 // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
 // eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any
-export const setScopeResolvedForTest = (scope: (...arg0: any[]) => any): void => {
+export const setScopeResolvedForTest = (scope: (...arg0: any[]) => void): void => {
   _scopeResolvedForTest = scope;
 };

package/front_end/panels/sources/SourcesPanel.ts

@@ -956,9 +956,7 @@ export class SourcesPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
       return;
     }
     const openText = i18nString(UIStrings.openInSourcesPanel);
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const callback: () => any = this.showUILocation.bind(this, uiSourceCode.uiLocation(0, 0));
+    const callback: () => void = this.showUILocation.bind(this, uiSourceCode.uiLocation(0, 0));
     contextMenu.revealSection().appendItem(openText, callback);
   }
 

package/front_end/panels/sources/SourcesView.ts

@@ -596,9 +596,6 @@ export type EventTypes = {
   [Events.EditorSelected]: Workspace.UISourceCode.UISourceCode,
 };
 
-/**
- * @interface
- */
 export interface EditorAction {
   getOrCreateButton(sourcesView: SourcesView): UI.Toolbar.ToolbarButton;
 }

package/front_end/panels/sources/TabbedEditorContainer.ts

@@ -60,9 +60,6 @@ const UIStrings = {
 };
 const str_ = i18n.i18n.registerUIStrings('panels/sources/TabbedEditorContainer.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-/**
- * @interface
- */
 export interface TabbedEditorContainerDelegate {
   viewForFile(uiSourceCode: Workspace.UISourceCode.UISourceCode): UI.Widget.Widget;
 
@@ -162,7 +159,7 @@ export class TabbedEditorContainer extends Common.ObjectWrapper.ObjectWrapper<Ev
   }
 
   fileViews(): UI.Widget.Widget[] {
-    return /** @type {!Array.<!UI.Widget.Widget>} */ this.tabbedPane.tabViews() as UI.Widget.Widget[];
+    return this.tabbedPane.tabViews();
   }
 
   leftToolbar(): UI.Toolbar.Toolbar {

package/front_end/panels/timeline/TimelineFlameChartDataProvider.ts

@@ -259,8 +259,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
       nestingLevel: 0,
       shareHeaderLine: true,
     };
-    return /** @type {!PerfUI.FlameChart.GroupStyle} */ Object.assign(defaultGroupStyle, extra) as
-        PerfUI.FlameChart.GroupStyle;
+    return Object.assign(defaultGroupStyle, extra);
   }
 
   setModel(performanceModel: PerformanceModel|null): void {
@@ -933,9 +932,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
   }
 
   private entryType(entryIndex: number): EntryType {
-    return this.entryTypeByLevel[/** @type {!PerfUI.FlameChart.TimelineData} */ (
-                                     this.timelineDataInternal as PerfUI.FlameChart.TimelineData)
-                                     .entryLevels[entryIndex]];
+    return this.entryTypeByLevel[(this.timelineDataInternal as PerfUI.FlameChart.TimelineData).entryLevels[entryIndex]];
   }
 
   prepareHighlightedEntryInfo(entryIndex: number): Element|null {

package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts

@@ -101,7 +101,6 @@ export class TimelineFlameChartNetworkDataProvider implements PerfUI.FlameChart.
     if (this.timelineDataInternal) {
       return this.timelineDataInternal;
     }
-    /** @type {!Array<!TimelineModel.TimelineModel.NetworkRequest>} */
     this.requests = [];
     this.timelineDataInternal = new PerfUI.FlameChart.TimelineData([], [], [], []);
     if (this.model) {

package/front_end/panels/timeline/TimelineFlameChartView.ts

@@ -46,7 +46,6 @@ class MainSplitWidget extends UI.SplitWidget.SplitWidget {
   }
 
   setWebVitals(webVitals: WebVitalsIntegrator): void {
-    /** @type {!WebVitalsIntegrator} */
     this.webVitals = webVitals;
     this.webVitals.setMinimumSize(0, 120);
   }
@@ -519,7 +518,7 @@ export class TimelineFlameChartView extends UI.Widget.VBox implements PerfUI.Fla
   }
 
   performSearch(searchConfig: UI.SearchableView.SearchConfig, shouldJump: boolean, jumpBackwards?: boolean): void {
-    this.searchRegex = searchConfig.toSearchRegex();
+    this.searchRegex = searchConfig.toSearchRegex().regex;
     this.updateSearchResults(shouldJump, jumpBackwards);
   }
 }

package/front_end/panels/timeline/TimelineLoader.ts

@@ -256,9 +256,6 @@ export class TimelineLoader implements Common.StringOutputStream.OutputStream {
 
 export const TransferChunkLengthBytes = 5000000;
 
-/**
- * @interface
- */
 export interface Client {
   loadingStarted(): void;
 

package/front_end/panels/timeline/TimelinePanel.ts

@@ -772,7 +772,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
   private async getCoverageViewWidget(): Promise<Coverage.CoverageView.CoverageView> {
     const view = (UI.ViewManager.ViewManager.instance().view('coverage') as UI.View.View);
-    return /** @type {!Coverage.CoverageView.CoverageView} */ await view.widget() as Coverage.CoverageView.CoverageView;
+    return await view.widget() as Coverage.CoverageView.CoverageView;
   }
 
   private async startRecording(): Promise<void> {
@@ -1160,8 +1160,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
   private frameForSelection(selection: TimelineSelection): TimelineModel.TimelineFrameModel.TimelineFrame|null {
     switch (selection.type()) {
       case TimelineSelection.Type.Frame:
-        return /** @type {!TimelineModel.TimelineFrameModel.TimelineFrame} */ selection.object() as
-            TimelineModel.TimelineFrameModel.TimelineFrame;
+        return selection.object() as TimelineModel.TimelineFrameModel.TimelineFrame;
       case TimelineSelection.Type.Range:
         return null;
       case TimelineSelection.Type.TraceEvent: