chrome-devtools-frontend 1.0.950971 → 1.0.952403

package/front_end/models/issues_manager/IssuesManager.ts

@@ -8,6 +8,7 @@ import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
 
 import {AttributionReportingIssue} from './AttributionReportingIssue.js';
+import {ClientHintIssue} from './ClientHintIssue.js';
 import {ContentSecurityPolicyIssue} from './ContentSecurityPolicyIssue.js';
 import {CorsIssue} from './CorsIssue.js';
 import {CrossOriginEmbedderPolicyIssue, isCrossOriginEmbedderPolicyIssue} from './CrossOriginEmbedderPolicyIssue.js';
@@ -104,6 +105,10 @@ const issueCodeHandlers = new Map<
     Protocol.Audits.InspectorIssueCode.DeprecationIssue,
     DeprecationIssue.fromInspectorIssue,
   ],
+  [
+    Protocol.Audits.InspectorIssueCode.ClientHintIssue,
+    ClientHintIssue.fromInspectorIssue,
+  ],
 ]);
 
 /**
@@ -160,30 +165,30 @@ export function getHideIssueByCodeSetting(): Common.Settings.Setting<HideIssueMe
  */
 export class IssuesManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes> implements
     SDK.TargetManager.SDKModelObserver<SDK.IssuesModel.IssuesModel> {
-  private eventListeners = new WeakMap<SDK.IssuesModel.IssuesModel, Common.EventTarget.EventDescriptor>();
-  private allIssues = new Map<string, Issue>();
-  private filteredIssues = new Map<string, Issue>();
-  private issueCounts = new Map<IssueKind, number>();
-  private hiddenIssueCount = new Map<IssueKind, number>();
-  private hasSeenTopFrameNavigated = false;
-  private sourceFrameIssuesManager = new SourceFrameIssuesManager(this);
-  private issuesById: Map<string, Issue> = new Map();
+  #eventListeners = new WeakMap<SDK.IssuesModel.IssuesModel, Common.EventTarget.EventDescriptor>();
+  #allIssues = new Map<string, Issue>();
+  #filteredIssues = new Map<string, Issue>();
+  #issueCounts = new Map<IssueKind, number>();
+  #hiddenIssueCount = new Map<IssueKind, number>();
+  #hasSeenTopFrameNavigated = false;
+  #issuesById: Map<string, Issue> = new Map();
 
   constructor(
       private readonly showThirdPartyIssuesSetting?: Common.Settings.Setting<boolean>,
       private readonly hideIssueSetting?: Common.Settings.Setting<HideIssueMenuSetting>) {
     super();
+    new SourceFrameIssuesManager(this);
     SDK.TargetManager.TargetManager.instance().observeModels(SDK.IssuesModel.IssuesModel, this);
     SDK.FrameManager.FrameManager.instance().addEventListener(
-        SDK.FrameManager.Events.TopFrameNavigated, this.onTopFrameNavigated, this);
+        SDK.FrameManager.Events.TopFrameNavigated, this.#onTopFrameNavigated, this);
     SDK.FrameManager.FrameManager.instance().addEventListener(
-        SDK.FrameManager.Events.FrameAddedToTarget, this.onFrameAddedToTarget, this);
+        SDK.FrameManager.Events.FrameAddedToTarget, this.#onFrameAddedToTarget, this);
 
     // issueFilter uses the 'showThirdPartyIssues' setting. Clients of IssuesManager need
     // a full update when the setting changes to get an up-to-date issues list.
-    this.showThirdPartyIssuesSetting?.addChangeListener(() => this.updateFilteredIssues());
+    this.showThirdPartyIssuesSetting?.addChangeListener(() => this.#updateFilteredIssues());
     if (Root.Runtime.experiments.isEnabled('hideIssuesFeature')) {
-      this.hideIssueSetting?.addChangeListener(() => this.updateFilteredIssues());
+      this.hideIssueSetting?.addChangeListener(() => this.#updateFilteredIssues());
     }
   }
 
@@ -210,48 +215,48 @@ export class IssuesManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
    * during navigation.
    */
   reloadForAccurateInformationRequired(): boolean {
-    return !this.hasSeenTopFrameNavigated;
+    return !this.#hasSeenTopFrameNavigated;
   }
 
-  private onTopFrameNavigated(
-      event: Common.EventTarget.EventTargetEvent<{frame: SDK.ResourceTreeModel.ResourceTreeFrame}>): void {
+  #onTopFrameNavigated(event: Common.EventTarget.EventTargetEvent<{frame: SDK.ResourceTreeModel.ResourceTreeFrame}>):
+      void {
     const {frame} = event.data;
     const keptIssues = new Map<string, Issue>();
-    for (const [key, issue] of this.allIssues.entries()) {
+    for (const [key, issue] of this.#allIssues.entries()) {
       if (issue.isAssociatedWithRequestId(frame.loaderId)) {
         keptIssues.set(key, issue);
       }
     }
-    this.allIssues = keptIssues;
-    this.hasSeenTopFrameNavigated = true;
-    this.updateFilteredIssues();
+    this.#allIssues = keptIssues;
+    this.#hasSeenTopFrameNavigated = true;
+    this.#updateFilteredIssues();
   }
 
-  private onFrameAddedToTarget(
-      event: Common.EventTarget.EventTargetEvent<{frame: SDK.ResourceTreeModel.ResourceTreeFrame}>): void {
+  #onFrameAddedToTarget(event: Common.EventTarget.EventTargetEvent<{frame: SDK.ResourceTreeModel.ResourceTreeFrame}>):
+      void {
     const {frame} = event.data;
     // Determining third-party status usually requires the registered domain of the top frame.
     // When DevTools is opened after navigation has completed, issues may be received
     // before the top frame is available. Thus, we trigger a recalcuation of third-party-ness
     // when we attach to the top frame.
     if (frame.isTopFrame()) {
-      this.updateFilteredIssues();
+      this.#updateFilteredIssues();
     }
   }
 
   modelAdded(issuesModel: SDK.IssuesModel.IssuesModel): void {
-    const listener = issuesModel.addEventListener(SDK.IssuesModel.Events.IssueAdded, this.onIssueAddedEvent, this);
-    this.eventListeners.set(issuesModel, listener);
+    const listener = issuesModel.addEventListener(SDK.IssuesModel.Events.IssueAdded, this.#onIssueAddedEvent, this);
+    this.#eventListeners.set(issuesModel, listener);
   }
 
   modelRemoved(issuesModel: SDK.IssuesModel.IssuesModel): void {
-    const listener = this.eventListeners.get(issuesModel);
+    const listener = this.#eventListeners.get(issuesModel);
     if (listener) {
       Common.EventTarget.removeEventListeners([listener]);
     }
   }
 
-  private onIssueAddedEvent(event: Common.EventTarget.EventTargetEvent<SDK.IssuesModel.IssueAddedEvent>): void {
+  #onIssueAddedEvent(event: Common.EventTarget.EventTargetEvent<SDK.IssuesModel.IssueAddedEvent>): void {
     const {issuesModel, inspectorIssue} = event.data;
     const issues = createIssuesFromProtocolIssue(issuesModel, inspectorIssue);
     for (const issue of issues) {
@@ -265,25 +270,25 @@ export class IssuesManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
       return;
     }
     const primaryKey = issue.primaryKey();
-    if (this.allIssues.has(primaryKey)) {
+    if (this.#allIssues.has(primaryKey)) {
       return;
     }
-    this.allIssues.set(primaryKey, issue);
+    this.#allIssues.set(primaryKey, issue);
 
-    if (this.issueFilter(issue)) {
-      this.filteredIssues.set(primaryKey, issue);
-      this.issueCounts.set(issue.getKind(), 1 + (this.issueCounts.get(issue.getKind()) || 0));
+    if (this.#issueFilter(issue)) {
+      this.#filteredIssues.set(primaryKey, issue);
+      this.#issueCounts.set(issue.getKind(), 1 + (this.#issueCounts.get(issue.getKind()) || 0));
       const issueId = issue.getIssueId();
       if (issueId) {
-        this.issuesById.set(issueId, issue);
+        this.#issuesById.set(issueId, issue);
       }
       const values = this.hideIssueSetting?.get();
       const hideIssuesFeature = Root.Runtime.experiments.isEnabled('hideIssuesFeature');
       if (hideIssuesFeature) {
-        this.updateIssueHiddenStatus(issue, values);
+        this.#updateIssueHiddenStatus(issue, values);
       }
       if (issue.isHidden()) {
-        this.hiddenIssueCount.set(issue.getKind(), 1 + (this.hiddenIssueCount.get(issue.getKind()) || 0));
+        this.#hiddenIssueCount.set(issue.getKind(), 1 + (this.#hiddenIssueCount.get(issue.getKind()) || 0));
       }
       this.dispatchEventToListeners(Events.IssueAdded, {issuesModel, issue});
     }
@@ -293,36 +298,36 @@ export class IssuesManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
   }
 
   issues(): Iterable<Issue> {
-    return this.filteredIssues.values();
+    return this.#filteredIssues.values();
   }
 
   numberOfIssues(kind?: IssueKind): number {
     if (kind) {
-      return (this.issueCounts.get(kind) ?? 0) - this.numberOfHiddenIssues(kind);
+      return (this.#issueCounts.get(kind) ?? 0) - this.numberOfHiddenIssues(kind);
     }
-    return this.filteredIssues.size - this.numberOfHiddenIssues();
+    return this.#filteredIssues.size - this.numberOfHiddenIssues();
   }
 
   numberOfHiddenIssues(kind?: IssueKind): number {
     if (kind) {
-      return this.hiddenIssueCount.get(kind) ?? 0;
+      return this.#hiddenIssueCount.get(kind) ?? 0;
     }
     let count = 0;
-    for (const num of this.hiddenIssueCount.values()) {
+    for (const num of this.#hiddenIssueCount.values()) {
       count += num;
     }
     return count;
   }
 
   numberOfAllStoredIssues(): number {
-    return this.allIssues.size;
+    return this.#allIssues.size;
   }
 
-  private issueFilter(issue: Issue): boolean {
+  #issueFilter(issue: Issue): boolean {
     return this.showThirdPartyIssuesSetting?.get() || !issue.isCausedByThirdParty();
   }
 
-  private updateIssueHiddenStatus(issue: Issue, values: HideIssueMenuSetting|undefined): void {
+  #updateIssueHiddenStatus(issue: Issue, values: HideIssueMenuSetting|undefined): void {
     const code = issue.code();
     // All issues are hidden via their code.
     // For hiding we check whether the issue code is present and has a value of IssueStatus.Hidden
@@ -340,26 +345,26 @@ export class IssuesManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
     }
   }
 
-  private updateFilteredIssues(): void {
-    this.filteredIssues.clear();
-    this.issueCounts.clear();
-    this.issuesById.clear();
-    this.hiddenIssueCount.clear();
+  #updateFilteredIssues(): void {
+    this.#filteredIssues.clear();
+    this.#issueCounts.clear();
+    this.#issuesById.clear();
+    this.#hiddenIssueCount.clear();
     const values = this.hideIssueSetting?.get();
     const hideIssuesFeature = Root.Runtime.experiments.isEnabled('hideIssuesFeature');
-    for (const [key, issue] of this.allIssues) {
-      if (this.issueFilter(issue)) {
+    for (const [key, issue] of this.#allIssues) {
+      if (this.#issueFilter(issue)) {
         if (hideIssuesFeature) {
-          this.updateIssueHiddenStatus(issue, values);
+          this.#updateIssueHiddenStatus(issue, values);
         }
-        this.filteredIssues.set(key, issue);
-        this.issueCounts.set(issue.getKind(), 1 + (this.issueCounts.get(issue.getKind()) ?? 0));
+        this.#filteredIssues.set(key, issue);
+        this.#issueCounts.set(issue.getKind(), 1 + (this.#issueCounts.get(issue.getKind()) ?? 0));
         if (issue.isHidden()) {
-          this.hiddenIssueCount.set(issue.getKind(), 1 + (this.hiddenIssueCount.get(issue.getKind()) || 0));
+          this.#hiddenIssueCount.set(issue.getKind(), 1 + (this.#hiddenIssueCount.get(issue.getKind()) || 0));
         }
         const issueId = issue.getIssueId();
         if (issueId) {
-          this.issuesById.set(issueId, issue);
+          this.#issuesById.set(issueId, issue);
         }
       }
     }
@@ -368,14 +373,14 @@ export class IssuesManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
   }
 
   unhideAllIssues(): void {
-    for (const issue of this.allIssues.values()) {
+    for (const issue of this.#allIssues.values()) {
       issue.setHidden(false);
     }
     this.hideIssueSetting?.set(defaultHideIssueByCodeSetting());
   }
 
   getIssueById(id: string): Issue|undefined {
-    return this.issuesById.get(id);
+    return this.#issuesById.get(id);
   }
 }
 

package/front_end/models/issues_manager/LowTextContrastIssue.ts

@@ -19,17 +19,17 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/LowTextContrastI
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class LowTextContrastIssue extends Issue {
-  private issueDetails: Protocol.Audits.LowTextContrastIssueDetails;
+  #issueDetails: Protocol.Audits.LowTextContrastIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.LowTextContrastIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     super('LowTextContrastIssue', issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   primaryKey(): string {
     // We intend to keep only one issue per element so other issues for the element will be discarded even
     // if the issue content is slightly different.
-    return `${this.code()}-(${this.issueDetails.violatingNodeId})`;
+    return `${this.code()}-(${this.#issueDetails.violatingNodeId})`;
   }
 
   getCategory(): IssueCategory {
@@ -37,7 +37,7 @@ export class LowTextContrastIssue extends Issue {
   }
 
   details(): Protocol.Audits.LowTextContrastIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription {

package/front_end/models/issues_manager/MixedContentIssue.ts

@@ -19,22 +19,22 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/MixedContentIssu
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class MixedContentIssue extends Issue {
-  private issueDetails: Protocol.Audits.MixedContentIssueDetails;
+  #issueDetails: Protocol.Audits.MixedContentIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.MixedContentIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     super(Protocol.Audits.InspectorIssueCode.MixedContentIssue, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   requests(): Iterable<Protocol.Audits.AffectedRequest> {
-    if (this.issueDetails.request) {
-      return [this.issueDetails.request];
+    if (this.#issueDetails.request) {
+      return [this.#issueDetails.request];
     }
     return [];
   }
 
   getDetails(): Protocol.Audits.MixedContentIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -50,11 +50,11 @@ export class MixedContentIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {
-    switch (this.issueDetails.resolutionStatus) {
+    switch (this.#issueDetails.resolutionStatus) {
       case Protocol.Audits.MixedContentResolutionStatus.MixedContentAutomaticallyUpgraded:
         return IssueKind.Improvement;
       case Protocol.Audits.MixedContentResolutionStatus.MixedContentBlocked:

package/front_end/models/issues_manager/NavigatorUserAgentIssue.ts

@@ -27,11 +27,11 @@ export enum IssueCode {
 }
 
 export class NavigatorUserAgentIssue extends Issue<IssueCode> {
-  private issueDetails: Protocol.Audits.NavigatorUserAgentIssueDetails;
+  #issueDetails: Protocol.Audits.NavigatorUserAgentIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.NavigatorUserAgentIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     super(IssueCode.NavigatorUserAgentIssue, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -39,7 +39,7 @@ export class NavigatorUserAgentIssue extends Issue<IssueCode> {
   }
 
   details(): Protocol.Audits.NavigatorUserAgentIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription|null {
@@ -53,14 +53,14 @@ export class NavigatorUserAgentIssue extends Issue<IssueCode> {
   }
 
   sources(): Iterable<Protocol.Audits.SourceCodeLocation> {
-    if (this.issueDetails.location) {
-      return [this.issueDetails.location];
+    if (this.#issueDetails.location) {
+      return [this.#issueDetails.location];
     }
     return [];
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {
@@ -69,7 +69,7 @@ export class NavigatorUserAgentIssue extends Issue<IssueCode> {
 
   isCausedByThirdParty(): boolean {
     const topFrame = SDK.FrameManager.FrameManager.instance().getTopFrame();
-    return isCausedByThirdParty(topFrame, this.issueDetails.url);
+    return isCausedByThirdParty(topFrame, this.#issueDetails.url);
   }
 
   static fromInspectorIssue(issuesModel: SDK.IssuesModel.IssuesModel, inspectorIssue: Protocol.Audits.InspectorIssue):

package/front_end/models/issues_manager/QuirksModeIssue.ts

@@ -19,17 +19,17 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/QuirksModeIssue.
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class QuirksModeIssue extends Issue {
-  private issueDetails: Protocol.Audits.QuirksModeIssueDetails;
+  #issueDetails: Protocol.Audits.QuirksModeIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.QuirksModeIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     const mode = issueDetails.isLimitedQuirksMode ? 'LimitedQuirksMode' : 'QuirksMode';
     const umaCode = [Protocol.Audits.InspectorIssueCode.QuirksModeIssue, mode].join('::');
     super({code: Protocol.Audits.InspectorIssueCode.QuirksModeIssue, umaCode}, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   primaryKey(): string {
-    return `${this.code()}-(${this.issueDetails.documentNodeId})-(${this.issueDetails.url})`;
+    return `${this.code()}-(${this.#issueDetails.documentNodeId})-(${this.#issueDetails.url})`;
   }
 
   getCategory(): IssueCategory {
@@ -37,7 +37,7 @@ export class QuirksModeIssue extends Issue {
   }
 
   details(): Protocol.Audits.QuirksModeIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription {

package/front_end/models/issues_manager/SameSiteCookieIssue.ts

@@ -38,27 +38,27 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/SameSiteCookieIs
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export class SameSiteCookieIssue extends Issue {
-  private issueDetails: Protocol.Audits.SameSiteCookieIssueDetails;
+  #issueDetails: Protocol.Audits.SameSiteCookieIssueDetails;
 
   constructor(
       code: string, issueDetails: Protocol.Audits.SameSiteCookieIssueDetails,
       issuesModel: SDK.IssuesModel.IssuesModel) {
     super(code, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
-  private cookieId(): string {
-    if (this.issueDetails.cookie) {
-      const {domain, path, name} = this.issueDetails.cookie;
+  #cookieId(): string {
+    if (this.#issueDetails.cookie) {
+      const {domain, path, name} = this.#issueDetails.cookie;
       const cookieId = `${domain};${path};${name}`;
       return cookieId;
     }
-    return this.issueDetails.rawCookieLine ?? 'no-cookie-info';
+    return this.#issueDetails.rawCookieLine ?? 'no-cookie-info';
   }
 
   primaryKey(): string {
-    const requestId = this.issueDetails.request ? this.issueDetails.request.requestId : 'no-request';
-    return `${this.code()}-(${this.cookieId()})-(${requestId})`;
+    const requestId = this.#issueDetails.request ? this.#issueDetails.request.requestId : 'no-request';
+    return `${this.code()}-(${this.#cookieId()})-(${requestId})`;
   }
 
   /**
@@ -67,8 +67,7 @@ export class SameSiteCookieIssue extends Issue {
   static createIssuesFromSameSiteDetails(
       sameSiteDetails: Protocol.Audits.SameSiteCookieIssueDetails,
       issuesModel: SDK.IssuesModel.IssuesModel): SameSiteCookieIssue[] {
-    /** @type {!Array<!Issue>} */
-    const issues = [];
+    const issues: SameSiteCookieIssue[] = [];
 
     // Exclusion reasons have priority. It means a cookie was blocked. Create an issue
     // for every exclusion reason but ignore warning reasons if the cookie was blocked.
@@ -163,22 +162,22 @@ export class SameSiteCookieIssue extends Issue {
   }
 
   cookies(): Iterable<Protocol.Audits.AffectedCookie> {
-    if (this.issueDetails.cookie) {
-      return [this.issueDetails.cookie];
+    if (this.#issueDetails.cookie) {
+      return [this.#issueDetails.cookie];
     }
     return [];
   }
 
   rawCookieLines(): Iterable<string> {
-    if (this.issueDetails.rawCookieLine) {
-      return [this.issueDetails.rawCookieLine];
+    if (this.#issueDetails.rawCookieLine) {
+      return [this.#issueDetails.rawCookieLine];
     }
     return [];
   }
 
   requests(): Iterable<Protocol.Audits.AffectedRequest> {
-    if (this.issueDetails.request) {
-      return [this.issueDetails.request];
+    if (this.#issueDetails.request) {
+      return [this.#issueDetails.request];
     }
     return [];
   }
@@ -197,11 +196,11 @@ export class SameSiteCookieIssue extends Issue {
 
   isCausedByThirdParty(): boolean {
     const topFrame = SDK.FrameManager.FrameManager.instance().getTopFrame();
-    return isCausedByThirdParty(topFrame, this.issueDetails.cookieUrl);
+    return isCausedByThirdParty(topFrame, this.#issueDetails.cookieUrl);
   }
 
   getKind(): IssueKind {
-    if (this.issueDetails.cookieExclusionReasons?.length > 0) {
+    if (this.#issueDetails.cookieExclusionReasons?.length > 0) {
       return IssueKind.PageError;
     }
     return IssueKind.BreakingChange;

package/front_end/models/issues_manager/SharedArrayBufferIssue.ts

@@ -20,12 +20,12 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/SharedArrayBuffe
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class SharedArrayBufferIssue extends Issue {
-  private issueDetails: Protocol.Audits.SharedArrayBufferIssueDetails;
+  #issueDetails: Protocol.Audits.SharedArrayBufferIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.SharedArrayBufferIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     const umaCode = [Protocol.Audits.InspectorIssueCode.SharedArrayBufferIssue, issueDetails.type].join('::');
     super({code: Protocol.Audits.InspectorIssueCode.SharedArrayBufferIssue, umaCode}, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -33,7 +33,7 @@ export class SharedArrayBufferIssue extends Issue {
   }
 
   details(): Protocol.Audits.SharedArrayBufferIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription {
@@ -47,11 +47,11 @@ export class SharedArrayBufferIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {
-    if (this.issueDetails.isWarning) {
+    if (this.#issueDetails.isWarning) {
       return IssueKind.BreakingChange;
     }
     return IssueKind.PageError;