chrome-devtools-frontend 1.0.950971 → 1.0.952403

package/front_end/models/issues_manager/ContentSecurityPolicyIssue.ts

@@ -36,7 +36,7 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/ContentSecurityP
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export class ContentSecurityPolicyIssue extends Issue {
-  private issueDetails: Protocol.Audits.ContentSecurityPolicyIssueDetails;
+  #issueDetails: Protocol.Audits.ContentSecurityPolicyIssueDetails;
 
   constructor(
       issueDetails: Protocol.Audits.ContentSecurityPolicyIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel,
@@ -46,7 +46,7 @@ export class ContentSecurityPolicyIssue extends Issue {
       issueDetails.contentSecurityPolicyViolationType,
     ].join('::');
     super(issueCode, issuesModel, issueId);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -54,7 +54,7 @@ export class ContentSecurityPolicyIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails, [
+    return JSON.stringify(this.#issueDetails, [
       'blockedURL',
       'contentSecurityPolicyViolationType',
       'violatedDirective',
@@ -68,7 +68,7 @@ export class ContentSecurityPolicyIssue extends Issue {
   }
 
   getDescription(): MarkdownIssueDescription|null {
-    const description = issueDescriptions.get(this.issueDetails.contentSecurityPolicyViolationType);
+    const description = issueDescriptions.get(this.#issueDetails.contentSecurityPolicyViolationType);
     if (!description) {
       return null;
     }
@@ -76,11 +76,11 @@ export class ContentSecurityPolicyIssue extends Issue {
   }
 
   details(): Protocol.Audits.ContentSecurityPolicyIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getKind(): IssueKind {
-    if (this.issueDetails.isReportOnly) {
+    if (this.#issueDetails.isReportOnly) {
       return IssueKind.Improvement;
     }
     return IssueKind.PageError;

package/front_end/models/issues_manager/ContrastCheckTrigger.ts

@@ -9,9 +9,9 @@ import * as SDK from '../../core/sdk/sdk.js';
 let contrastCheckTriggerInstance: ContrastCheckTrigger|null = null;
 
 export class ContrastCheckTrigger {
-  private pageLoadListeners: WeakMap<SDK.ResourceTreeModel.ResourceTreeModel, Common.EventTarget.EventDescriptor> =
+  #pageLoadListeners: WeakMap<SDK.ResourceTreeModel.ResourceTreeModel, Common.EventTarget.EventDescriptor> =
       new WeakMap();
-  private frameAddedListeners: WeakMap<SDK.ResourceTreeModel.ResourceTreeModel, Common.EventTarget.EventDescriptor> =
+  #frameAddedListeners: WeakMap<SDK.ResourceTreeModel.ResourceTreeModel, Common.EventTarget.EventDescriptor> =
       new WeakMap();
 
   constructor() {
@@ -27,40 +27,40 @@ export class ContrastCheckTrigger {
   }
 
   async modelAdded(resourceTreeModel: SDK.ResourceTreeModel.ResourceTreeModel): Promise<void> {
-    this.pageLoadListeners.set(
+    this.#pageLoadListeners.set(
         resourceTreeModel,
-        resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.Load, this.pageLoaded, this));
-    this.frameAddedListeners.set(
+        resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.Load, this.#pageLoaded, this));
+    this.#frameAddedListeners.set(
         resourceTreeModel,
-        resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.FrameAdded, this.frameAdded, this));
+        resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.FrameAdded, this.#frameAdded, this));
   }
 
   modelRemoved(resourceTreeModel: SDK.ResourceTreeModel.ResourceTreeModel): void {
-    const pageLoadListener = this.pageLoadListeners.get(resourceTreeModel);
+    const pageLoadListener = this.#pageLoadListeners.get(resourceTreeModel);
     if (pageLoadListener) {
       Common.EventTarget.removeEventListeners([pageLoadListener]);
     }
-    const frameAddedListeners = this.frameAddedListeners.get(resourceTreeModel);
+    const frameAddedListeners = this.#frameAddedListeners.get(resourceTreeModel);
     if (frameAddedListeners) {
       Common.EventTarget.removeEventListeners([frameAddedListeners]);
     }
   }
 
-  private checkContrast(resourceTreeModel: SDK.ResourceTreeModel.ResourceTreeModel): void {
+  #checkContrast(resourceTreeModel: SDK.ResourceTreeModel.ResourceTreeModel): void {
     if (!Root.Runtime.experiments.isEnabled('contrastIssues')) {
       return;
     }
     resourceTreeModel.target().auditsAgent().invoke_checkContrast({});
   }
 
-  private pageLoaded(
-      event: Common.EventTarget
-          .EventTargetEvent<{resourceTreeModel: SDK.ResourceTreeModel.ResourceTreeModel, loadTime: number}>): void {
+  #pageLoaded(event: Common.EventTarget
+                  .EventTargetEvent<{resourceTreeModel: SDK.ResourceTreeModel.ResourceTreeModel, loadTime: number}>):
+      void {
     const {resourceTreeModel} = event.data;
-    this.checkContrast(resourceTreeModel);
+    this.#checkContrast(resourceTreeModel);
   }
 
-  private async frameAdded(event: Common.EventTarget.EventTargetEvent<SDK.ResourceTreeModel.ResourceTreeFrame>):
+  async #frameAdded(event: Common.EventTarget.EventTargetEvent<SDK.ResourceTreeModel.ResourceTreeFrame>):
       Promise<void> {
     if (!Root.Runtime.experiments.isEnabled('contrastIssues')) {
       return;
@@ -74,7 +74,7 @@ export class ContrastCheckTrigger {
     const response = await frame.resourceTreeModel().target().runtimeAgent().invoke_evaluate(
         {expression: 'document.readyState', returnByValue: true});
     if (response.result && response.result.value === 'complete') {
-      this.checkContrast(frame.resourceTreeModel());
+      this.#checkContrast(frame.resourceTreeModel());
     }
   }
 }

package/front_end/models/issues_manager/CorsIssue.ts

@@ -99,13 +99,13 @@ function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
 }
 
 export class CorsIssue extends Issue<IssueCode> {
-  private issueDetails: Protocol.Audits.CorsIssueDetails;
+  #issueDetails: Protocol.Audits.CorsIssueDetails;
 
   constructor(
       issueDetails: Protocol.Audits.CorsIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel,
       issueId: Protocol.Audits.IssueId|undefined) {
     super(getIssueCode(issueDetails), issuesModel, issueId);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -113,11 +113,11 @@ export class CorsIssue extends Issue<IssueCode> {
   }
 
   details(): Protocol.Audits.CorsIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription|null {
-    switch (getIssueCode(this.issueDetails)) {
+    switch (getIssueCode(this.#issueDetails)) {
       case IssueCode.InsecurePrivateNetwork:
         return {
           file: 'corsInsecurePrivateNetwork.md',
@@ -231,15 +231,15 @@ export class CorsIssue extends Issue<IssueCode> {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {
-    if (this.issueDetails.isWarning &&
-        (this.issueDetails.corsErrorStatus.corsError === Protocol.Network.CorsError.InsecurePrivateNetwork ||
-         this.issueDetails.corsErrorStatus.corsError ===
+    if (this.#issueDetails.isWarning &&
+        (this.#issueDetails.corsErrorStatus.corsError === Protocol.Network.CorsError.InsecurePrivateNetwork ||
+         this.#issueDetails.corsErrorStatus.corsError ===
              Protocol.Network.CorsError.PreflightMissingAllowPrivateNetwork ||
-         this.issueDetails.corsErrorStatus.corsError ===
+         this.#issueDetails.corsErrorStatus.corsError ===
              Protocol.Network.CorsError.PreflightInvalidAllowPrivateNetwork)) {
       return IssueKind.BreakingChange;
     }

package/front_end/models/issues_manager/CrossOriginEmbedderPolicyIssue.ts

@@ -40,23 +40,23 @@ export function isCrossOriginEmbedderPolicyIssue(reason: Protocol.Audits.Blocked
 }
 
 export class CrossOriginEmbedderPolicyIssue extends Issue {
-  private issueDetails: Protocol.Audits.BlockedByResponseIssueDetails;
+  #issueDetails: Protocol.Audits.BlockedByResponseIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.BlockedByResponseIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     super(`CrossOriginEmbedderPolicyIssue::${issueDetails.reason}`, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   primaryKey(): string {
-    return `${this.code()}-(${this.issueDetails.request.requestId})`;
+    return `${this.code()}-(${this.#issueDetails.request.requestId})`;
   }
 
   getBlockedByResponseDetails(): Iterable<Protocol.Audits.BlockedByResponseIssueDetails> {
-    return [this.issueDetails];
+    return [this.#issueDetails];
   }
 
   requests(): Iterable<Protocol.Audits.AffectedRequest> {
-    return [this.issueDetails.request];
+    return [this.#issueDetails.request];
   }
 
   getCategory(): IssueCategory {

package/front_end/models/issues_manager/DeprecationIssue.ts

@@ -13,11 +13,11 @@ export const enum IssueCode {
 }
 
 export class DeprecationIssue extends Issue<IssueCode> {
-  private issueDetails: Protocol.Audits.DeprecationIssueDetails;
+  #issueDetails: Protocol.Audits.DeprecationIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.DeprecationIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     super(IssueCode.DeprecationIssue, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -25,7 +25,7 @@ export class DeprecationIssue extends Issue<IssueCode> {
   }
 
   details(): Protocol.Audits.DeprecationIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription|null {
@@ -34,21 +34,21 @@ export class DeprecationIssue extends Issue<IssueCode> {
       substitutions: new Map([
         // TODO(crbug.com/1264960): Re-work format to add i18n support per:
         // https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/devtools_protocol/README.md
-        ['PLACEHOLDER_message', String(this.issueDetails.message)],
+        ['PLACEHOLDER_message', String(this.#issueDetails.message)],
       ]),
       links: [],
     };
   }
 
   sources(): Iterable<Protocol.Audits.SourceCodeLocation> {
-    if (this.issueDetails.sourceCodeLocation) {
-      return [this.issueDetails.sourceCodeLocation];
+    if (this.#issueDetails.sourceCodeLocation) {
+      return [this.#issueDetails.sourceCodeLocation];
     }
     return [];
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {

package/front_end/models/issues_manager/GenericIssue.ts

@@ -20,7 +20,7 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/GenericIssue.ts'
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export class GenericIssue extends Issue {
-  private issueDetails: Protocol.Audits.GenericIssueDetails;
+  #issueDetails: Protocol.Audits.GenericIssueDetails;
 
   constructor(
       issueDetails: Protocol.Audits.GenericIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel,
@@ -30,7 +30,7 @@ export class GenericIssue extends Issue {
       issueDetails.errorType,
     ].join('::');
     super(issueCode, issuesModel, issueId);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -38,11 +38,11 @@ export class GenericIssue extends Issue {
   }
 
   primaryKey(): string {
-    return `${this.code()}-(${this.issueDetails.frameId})`;
+    return `${this.code()}-(${this.#issueDetails.frameId})`;
   }
 
   getDescription(): MarkdownIssueDescription|null {
-    const description = issueDescriptions.get(this.issueDetails.errorType);
+    const description = issueDescriptions.get(this.#issueDetails.errorType);
     if (!description) {
       return null;
     }
@@ -50,7 +50,7 @@ export class GenericIssue extends Issue {
   }
 
   details(): Protocol.Audits.GenericIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getKind(): IssueKind {

package/front_end/models/issues_manager/HeavyAdIssue.ts

@@ -19,20 +19,20 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/HeavyAdIssue.ts'
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class HeavyAdIssue extends Issue {
-  private issueDetails: Protocol.Audits.HeavyAdIssueDetails;
+  #issueDetails: Protocol.Audits.HeavyAdIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.HeavyAdIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     const umaCode = [Protocol.Audits.InspectorIssueCode.HeavyAdIssue, issueDetails.reason].join('::');
     super({code: Protocol.Audits.InspectorIssueCode.HeavyAdIssue, umaCode}, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   details(): Protocol.Audits.HeavyAdIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   primaryKey(): string {
-    return `${Protocol.Audits.InspectorIssueCode.HeavyAdIssue}-${JSON.stringify(this.issueDetails)}`;
+    return `${Protocol.Audits.InspectorIssueCode.HeavyAdIssue}-${JSON.stringify(this.#issueDetails)}`;
   }
 
   getDescription(): MarkdownIssueDescription {
@@ -52,7 +52,7 @@ export class HeavyAdIssue extends Issue {
   }
 
   getKind(): IssueKind {
-    switch (this.issueDetails.resolution) {
+    switch (this.#issueDetails.resolution) {
       case Protocol.Audits.HeavyAdResolutionStatus.HeavyAdBlocked:
         return IssueKind.PageError;
       case Protocol.Audits.HeavyAdResolutionStatus.HeavyAdWarning:

package/front_end/models/issues_manager/Issue.ts

@@ -123,23 +123,23 @@ export interface AffectedElement {
 }
 
 export abstract class Issue<IssueCode extends string = string> {
-  private issueCode: IssueCode;
-  private issuesModel: SDK.IssuesModel.IssuesModel|null;
+  #issueCode: IssueCode;
+  #issuesModel: SDK.IssuesModel.IssuesModel|null;
   protected issueId: Protocol.Audits.IssueId|undefined = undefined;
-  private hidden: boolean;
+  #hidden: boolean;
 
   constructor(
       code: IssueCode|{code: IssueCode, umaCode: string}, issuesModel: SDK.IssuesModel.IssuesModel|null = null,
       issueId?: Protocol.Audits.IssueId) {
-    this.issueCode = typeof code === 'object' ? code.code : code;
-    this.issuesModel = issuesModel;
+    this.#issueCode = typeof code === 'object' ? code.code : code;
+    this.#issuesModel = issuesModel;
     this.issueId = issueId;
     Host.userMetrics.issueCreated(typeof code === 'string' ? code : code.umaCode);
-    this.hidden = false;
+    this.#hidden = false;
   }
 
   code(): IssueCode {
-    return this.issueCode;
+    return this.#issueCode;
   }
 
   abstract primaryKey(): string;
@@ -184,7 +184,7 @@ export abstract class Issue<IssueCode extends string = string> {
    * The model might be unavailable or belong to a target that has already been disposed.
    */
   model(): SDK.IssuesModel.IssuesModel|null {
-    return this.issuesModel;
+    return this.#issuesModel;
   }
 
   isCausedByThirdParty(): boolean {
@@ -196,11 +196,11 @@ export abstract class Issue<IssueCode extends string = string> {
   }
 
   isHidden(): boolean {
-    return this.hidden;
+    return this.#hidden;
   }
 
   setHidden(hidden: boolean): void {
-    this.hidden = hidden;
+    this.#hidden = hidden;
   }
 }
 

package/front_end/models/issues_manager/IssueResolver.ts

@@ -13,19 +13,19 @@ import type {IssueAddedEvent} from './IssuesManager.js';
   * A class that facilitates resolving an issueId to an issue. See `ResolverBase` for more info.
   */
 export class IssueResolver extends Common.ResolverBase.ResolverBase<Protocol.Audits.IssueId, Issue> {
-  private issuesListener: Common.EventTarget.EventDescriptor|null = null;
-  private issuesManager: IssuesManager;
+  #issuesListener: Common.EventTarget.EventDescriptor|null = null;
+  #issuesManager: IssuesManager;
 
   constructor(issuesManager: IssuesManager = IssuesManager.instance()) {
     super();
-    this.issuesManager = issuesManager;
+    this.#issuesManager = issuesManager;
   }
 
   protected override getForId(id: Protocol.Audits.IssueId): Issue|null {
-    return this.issuesManager.getIssueById(id) || null;
+    return this.#issuesManager.getIssueById(id) || null;
   }
 
-  private onIssueAdded(event: Common.EventTarget.EventTargetEvent<IssueAddedEvent>): void {
+  #onIssueAdded(event: Common.EventTarget.EventTargetEvent<IssueAddedEvent>): void {
     const {issue} = event.data;
     const id = issue.getIssueId();
     if (id) {
@@ -34,17 +34,18 @@ export class IssueResolver extends Common.ResolverBase.ResolverBase<Protocol.Aud
   }
 
   protected override startListening(): void {
-    if (this.issuesListener) {
+    if (this.#issuesListener) {
       return;
     }
-    this.issuesListener = this.issuesManager.addEventListener(IssueManagerEvents.IssueAdded, this.onIssueAdded, this);
+    this.#issuesListener =
+        this.#issuesManager.addEventListener(IssueManagerEvents.IssueAdded, this.#onIssueAdded, this);
   }
 
   protected override stopListening(): void {
-    if (!this.issuesListener) {
+    if (!this.#issuesListener) {
       return;
     }
-    Common.EventTarget.removeEventListeners([this.issuesListener]);
-    this.issuesListener = null;
+    Common.EventTarget.removeEventListeners([this.#issuesListener]);
+    this.#issuesListener = null;
   }
 }