chrome-devtools-frontend 1.0.942095 → 1.0.943709

package/WATCHLISTS

@@ -14,7 +14,7 @@
       'filepath': '.',
     },
     'chromedriver': {
-      'filepath': 'front_end/emulated_devices/module.json',
+      'filepath': 'front_end/emulated_devices/',
     },
     'lighthouse': {
       'filepath': '[Ll]ighthouse',

package/config/gni/all_devtools_files.gni

@@ -42,28 +42,19 @@ all_devtools_files = [
   "front_end/legacy_test_runner/elements_test_runner/ElementsTestRunner.js",
   "front_end/legacy_test_runner/elements_test_runner/SetOuterHTMLTestRunner.js",
   "front_end/legacy_test_runner/elements_test_runner/StylesUpdateLinksTestRunner.js",
-  "front_end/emulated_devices/module.json",
-  "front_end/panels/emulation/deviceModeToolbar.css",
-  "front_end/panels/emulation/deviceModeView.css",
-  "front_end/panels/emulation/inspectedPagePlaceholder.css",
-  "front_end/panels/emulation/mediaQueryInspector.css",
-  "front_end/panels/emulation/module.json",
   "front_end/legacy_test_runner/extensions_test_runner/extensions_test_runner.js",
   "front_end/legacy_test_runner/extensions_test_runner/ExtensionsNetworkTestRunner.js",
   "front_end/legacy_test_runner/extensions_test_runner/ExtensionsTestRunner.js",
   "front_end/legacy_test_runner/heap_profiler_test_runner/heap_profiler_test_runner.js",
   "front_end/entrypoints/inspector/inspector.js",
   "front_end/entrypoints/inspector/inspector.json",
-  "front_end/panels/js_profiler/module.json",
   "front_end/legacy_test_runner/layers_test_runner/layers_test_runner.js",
-  "front_end/panels/layers/module.json",
   "front_end/entrypoints/ndb_app/ndb_app.json",
   "front_end/legacy_test_runner/network_test_runner/network_test_runner.js",
   "front_end/entrypoints/node_main/nodeConnectionsPanel.css",
   "front_end/legacy_test_runner/performance_test_runner/performance_test_runner.js",
   "front_end/legacy_test_runner/performance_test_runner/TimelineDataTestRunner.js",
   "front_end/legacy_test_runner/performance_test_runner/TimelineTestRunner.js",
-  "front_end/panels/profiler/module.json",
   "front_end/models/issues_manager/descriptions/arAttributionEventSourceTriggerDataTooLarge.md",
   "front_end/models/issues_manager/descriptions/arAttributionSourceUntrustworthyFrameOrigin.md",
   "front_end/models/issues_manager/descriptions/arAttributionSourceUntrustworthyOrigin.md",
@@ -121,18 +112,9 @@ all_devtools_files = [
   "front_end/models/issues_manager/descriptions/TwaDigitalAssetLinksFailed.md",
   "front_end/models/issues_manager/descriptions/TwaHttpError.md",
   "front_end/models/issues_manager/descriptions/TwaPageUnavailableOffline.md",
-  "front_end/panels/screencast/module.json",
   "front_end/legacy_test_runner/sdk_test_runner/sdk_test_runner.js",
   "front_end/legacy_test_runner/security_test_runner/security_test_runner.js",
   "front_end/entrypoints/shell/shell.json",
-  "front_end/ui/legacy/components/source_frame/fontView.css",
-  "front_end/ui/legacy/components/source_frame/imageView.css",
-  "front_end/ui/legacy/components/source_frame/jsonView.css",
-  "front_end/ui/legacy/components/source_frame/messagesPopover.css",
-  "front_end/ui/legacy/components/source_frame/module.json",
-  "front_end/ui/legacy/components/source_frame/resourceSourceFrame.css",
-  "front_end/ui/legacy/components/source_frame/xmlTree.css",
-  "front_end/ui/legacy/components/source_frame/xmlView.css",
   "front_end/legacy_test_runner/sources_test_runner/sources_test_runner.js",
   "front_end/legacy_test_runner/sources_test_runner/AutocompleteTestRunner.js",
   "front_end/legacy_test_runner/sources_test_runner/DebuggerTestRunner.js",
@@ -143,48 +125,8 @@ all_devtools_files = [
   "front_end/ui/legacy/components/text_editor/autocompleteTooltip.css",
   "front_end/ui/legacy/components/text_editor/cmdevtools.css",
   "front_end/ui/legacy/components/text_editor/module.json",
-  "front_end/third_party/lighthouse/report-assets/report.css",
   "front_end/third_party/lighthouse/report-assets/report.js",
   "front_end/third_party/lighthouse/report-assets/standalone-template.html",
-  "front_end/panels/timeline/module.json",
-  "front_end/ui/legacy/checkboxTextLabel.css",
-  "front_end/ui/legacy/closeButton.css",
-  "front_end/ui/legacy/confirmDialog.css",
-  "front_end/ui/legacy/dialog.css",
-  "front_end/ui/legacy/dropTarget.css",
-  "front_end/ui/legacy/emptyWidget.css",
-  "front_end/ui/legacy/filter.css",
-  "front_end/ui/legacy/glassPane.css",
-  "front_end/ui/legacy/infobar.css",
-  "front_end/ui/legacy/inlineButton.css",
-  "front_end/ui/legacy/inspectorCommon.css",
-  "front_end/ui/legacy/themeColors.css",
-  "front_end/ui/legacy/inspectorSyntaxHighlight.css",
-  "front_end/ui/legacy/inspectorSyntaxHighlightDark.css",
-  "front_end/ui/legacy/inspectorViewTabbedPane.css",
-  "front_end/ui/legacy/listWidget.css",
-  "front_end/ui/legacy/module.json",
-  "front_end/ui/legacy/popover.css",
-  "front_end/ui/legacy/progressIndicator.css",
-  "front_end/ui/legacy/radioButton.css",
-  "front_end/ui/legacy/remoteDebuggingTerminatedScreen.css",
-  "front_end/ui/legacy/reportView.css",
-  "front_end/ui/legacy/rootView.css",
-  "front_end/ui/legacy/searchableView.css",
-  "front_end/ui/legacy/slider.css",
-  "front_end/ui/legacy/smallBubble.css",
-  "front_end/ui/legacy/softContextMenu.css",
-  "front_end/ui/legacy/softDropDown.css",
-  "front_end/ui/legacy/softDropDownButton.css",
-  "front_end/ui/legacy/splitWidget.css",
-  "front_end/ui/legacy/suggestBox.css",
-  "front_end/ui/legacy/tabbedPane.css",
-  "front_end/ui/legacy/targetCrashedScreen.css",
-  "front_end/ui/legacy/textButton.css",
-  "front_end/ui/legacy/textPrompt.css",
-  "front_end/ui/legacy/toolbar.css",
-  "front_end/ui/legacy/treeoutline.css",
-  "front_end/ui/legacy/viewContainers.css",
 ]
 
 lighthouse_locale_files = [

package/config/gni/devtools_grd_files.gni

@@ -53,7 +53,6 @@ grd_files_release_sources = [
   "front_end/Images/errorWave.svg",
   "front_end/Images/error_icon.svg",
   "front_end/Images/feedback_button_icon.svg",
-  "front_end/Images/feedback_thin_16x16_icon.svg",
   "front_end/Images/flex-direction-icon.svg",
   "front_end/Images/flex-nowrap-icon.svg",
   "front_end/Images/flex-wrap-icon.svg",
@@ -133,6 +132,7 @@ grd_files_release_sources = [
   "front_end/Images/smallIcons.svg",
   "front_end/Images/sources_panel_icon.svg",
   "front_end/Images/speech.png",
+  "front_end/Images/survey_feedback_icon.svg",
   "front_end/Images/switcherIcon.svg",
   "front_end/Images/three_dots_menu_icon.svg",
   "front_end/Images/toolbarResizerVertical.png",
@@ -162,7 +162,6 @@ grd_files_release_sources = [
   "front_end/device_mode_emulation_frame.html",
   "front_end/devtools_app.html",
   "front_end/devtools_compatibility.js",
-  "front_end/emulated_devices/emulated_devices_module.js",
   "front_end/emulated_devices/optimized/MotoG4-landscape.avif",
   "front_end/emulated_devices/optimized/MotoG4-portrait.avif",
   "front_end/emulated_devices/optimized/Nexus5X-landscape.avif",
@@ -372,13 +371,11 @@ grd_files_release_sources = [
   "front_end/panels/issues/issues.js",
   "front_end/panels/js_profiler/js_profiler-meta.js",
   "front_end/panels/js_profiler/js_profiler.js",
-  "front_end/panels/js_profiler/js_profiler_module.js",
   "front_end/panels/layer_viewer/layer_viewer-legacy.js",
   "front_end/panels/layer_viewer/layer_viewer-meta.js",
   "front_end/panels/layer_viewer/layer_viewer.js",
   "front_end/panels/layers/layers-meta.js",
   "front_end/panels/layers/layers.js",
-  "front_end/panels/layers/layers_module.js",
   "front_end/panels/lighthouse/lighthouse-legacy.js",
   "front_end/panels/lighthouse/lighthouse-meta.js",
   "front_end/panels/lighthouse/lighthouse.js",
@@ -398,7 +395,6 @@ grd_files_release_sources = [
   "front_end/panels/profiler/profiler-legacy.js",
   "front_end/panels/profiler/profiler-meta.js",
   "front_end/panels/profiler/profiler.js",
-  "front_end/panels/profiler/profiler_module.js",
   "front_end/panels/protocol_monitor/protocol_monitor-meta.js",
   "front_end/panels/protocol_monitor/protocol_monitor.js",
   "front_end/panels/screencast/screencast-meta.js",
@@ -427,7 +423,6 @@ grd_files_release_sources = [
   "front_end/panels/timeline/timeline-legacy.js",
   "front_end/panels/timeline/timeline-meta.js",
   "front_end/panels/timeline/timeline.js",
-  "front_end/panels/timeline/timeline_module.js",
   "front_end/panels/utils/utils.js",
   "front_end/panels/web_audio/graph_visualizer/graph_visualizer.js",
   "front_end/panels/web_audio/web_audio-legacy.js",
@@ -964,6 +959,10 @@ grd_files_debug_sources = [
   "front_end/panels/emulation/InspectedPagePlaceholder.js",
   "front_end/panels/emulation/MediaQueryInspector.js",
   "front_end/panels/emulation/components/DeviceSizeInputElement.js",
+  "front_end/panels/emulation/deviceModeToolbar.css.legacy.js",
+  "front_end/panels/emulation/deviceModeView.css.legacy.js",
+  "front_end/panels/emulation/inspectedPagePlaceholder.css.legacy.js",
+  "front_end/panels/emulation/mediaQueryInspector.css.legacy.js",
   "front_end/panels/event_listeners/EventListenersUtils.js",
   "front_end/panels/event_listeners/EventListenersView.js",
   "front_end/panels/event_listeners/eventListenersView.css.js",
@@ -1297,7 +1296,6 @@ grd_files_debug_sources = [
   "front_end/third_party/i18n/localized-string-set.js",
   "front_end/third_party/intl-messageformat/package/intl-messageformat.esm.js",
   "front_end/third_party/lighthouse/report-assets/report-generator.js",
-  "front_end/third_party/lighthouse/report-assets/report.css.js",
   "front_end/third_party/lighthouse/report-assets/report.js",
   "front_end/third_party/lighthouse/report/bundle.js",
   "front_end/third_party/lit-html/directive.js",
@@ -1469,6 +1467,8 @@ grd_files_debug_sources = [
   "front_end/ui/legacy/XLink.js",
   "front_end/ui/legacy/XWidget.js",
   "front_end/ui/legacy/ZoomManager.js",
+  "front_end/ui/legacy/checkboxTextLabel.css.legacy.js",
+  "front_end/ui/legacy/closeButton.css.legacy.js",
   "front_end/ui/legacy/components/color_picker/ContrastDetails.js",
   "front_end/ui/legacy/components/color_picker/ContrastInfo.js",
   "front_end/ui/legacy/components/color_picker/ContrastOverlay.js",
@@ -1554,6 +1554,12 @@ grd_files_debug_sources = [
   "front_end/ui/legacy/components/source_frame/ResourceSourceFrame.js",
   "front_end/ui/legacy/components/source_frame/SourceFrame.js",
   "front_end/ui/legacy/components/source_frame/XMLView.js",
+  "front_end/ui/legacy/components/source_frame/fontView.css.legacy.js",
+  "front_end/ui/legacy/components/source_frame/imageView.css.legacy.js",
+  "front_end/ui/legacy/components/source_frame/jsonView.css.legacy.js",
+  "front_end/ui/legacy/components/source_frame/resourceSourceFrame.css.legacy.js",
+  "front_end/ui/legacy/components/source_frame/xmlTree.css.legacy.js",
+  "front_end/ui/legacy/components/source_frame/xmlView.css.legacy.js",
   "front_end/ui/legacy/components/text_editor/CodeMirrorTextEditor.js",
   "front_end/ui/legacy/components/text_editor/TextEditorAutocompleteController.js",
   "front_end/ui/legacy/components/text_editor/cm_modes.js",
@@ -1564,15 +1570,50 @@ grd_files_debug_sources = [
   "front_end/ui/legacy/components/utils/TargetDetachedDialog.js",
   "front_end/ui/legacy/components/utils/imagePreview.css.js",
   "front_end/ui/legacy/components/utils/jsUtils.css.js",
+  "front_end/ui/legacy/confirmDialog.css.legacy.js",
+  "front_end/ui/legacy/dialog.css.legacy.js",
+  "front_end/ui/legacy/dropTarget.css.legacy.js",
   "front_end/ui/legacy/emptyWidget.css.js",
+  "front_end/ui/legacy/emptyWidget.css.legacy.js",
+  "front_end/ui/legacy/filter.css.legacy.js",
+  "front_end/ui/legacy/glassPane.css.legacy.js",
+  "front_end/ui/legacy/infobar.css.legacy.js",
+  "front_end/ui/legacy/inlineButton.css.legacy.js",
   "front_end/ui/legacy/inspectorCommon.css.js",
+  "front_end/ui/legacy/inspectorCommon.css.legacy.js",
+  "front_end/ui/legacy/inspectorSyntaxHighlight.css.legacy.js",
+  "front_end/ui/legacy/inspectorSyntaxHighlightDark.css.legacy.js",
+  "front_end/ui/legacy/inspectorViewTabbedPane.css.legacy.js",
+  "front_end/ui/legacy/listWidget.css.legacy.js",
+  "front_end/ui/legacy/popover.css.legacy.js",
+  "front_end/ui/legacy/progressIndicator.css.legacy.js",
+  "front_end/ui/legacy/radioButton.css.legacy.js",
+  "front_end/ui/legacy/remoteDebuggingTerminatedScreen.css.legacy.js",
+  "front_end/ui/legacy/reportView.css.legacy.js",
+  "front_end/ui/legacy/rootView.css.legacy.js",
+  "front_end/ui/legacy/searchableView.css.legacy.js",
+  "front_end/ui/legacy/slider.css.legacy.js",
+  "front_end/ui/legacy/smallBubble.css.legacy.js",
+  "front_end/ui/legacy/softContextMenu.css.legacy.js",
+  "front_end/ui/legacy/softDropDown.css.legacy.js",
+  "front_end/ui/legacy/softDropDownButton.css.legacy.js",
+  "front_end/ui/legacy/splitWidget.css.legacy.js",
+  "front_end/ui/legacy/suggestBox.css.legacy.js",
+  "front_end/ui/legacy/tabbedPane.css.legacy.js",
+  "front_end/ui/legacy/targetCrashedScreen.css.legacy.js",
+  "front_end/ui/legacy/textButton.css.legacy.js",
+  "front_end/ui/legacy/textPrompt.css.legacy.js",
+  "front_end/ui/legacy/themeColors.css.legacy.js",
   "front_end/ui/legacy/theme_support/theme_support_impl.js",
+  "front_end/ui/legacy/toolbar.css.legacy.js",
+  "front_end/ui/legacy/treeoutline.css.legacy.js",
   "front_end/ui/legacy/utils/append-style.js",
   "front_end/ui/legacy/utils/create-shadow-root-with-core-styles.js",
   "front_end/ui/legacy/utils/focus-changed.js",
   "front_end/ui/legacy/utils/inject-core-styles.js",
   "front_end/ui/legacy/utils/measured-scrollbar-width.js",
   "front_end/ui/legacy/utils/register-custom-element.js",
+  "front_end/ui/legacy/viewContainers.css.legacy.js",
   "front_end/ui/lit-html/static.js",
 ]
 

package/config/gni/devtools_image_files.gni

@@ -63,7 +63,6 @@ devtools_svg_sources = [
   "errorWave.svg",
   "error_icon.svg",
   "feedback_button_icon.svg",
-  "feedback_thin_16x16_icon.svg",
   "flex-direction-icon.svg",
   "flex-nowrap-icon.svg",
   "flex-wrap-icon.svg",
@@ -132,6 +131,7 @@ devtools_svg_sources = [
   "settings_14x14_icon.svg",
   "smallIcons.svg",
   "sources_panel_icon.svg",
+  "survey_feedback_icon.svg",
   "switcherIcon.svg",
   "three_dots_menu_icon.svg",
   "trash_bin_icon.svg",

package/front_end/.eslintrc.js

@@ -110,7 +110,17 @@ module.exports = {
             'format': ['camelCase'],
             'leadingUnderscore': 'allow',
           }
-        ]
+        ],
+        'no-restricted-syntax': [
+          'warn', {
+            // Matches the common pattern of `.registerRequiredCSS('path\to\module-styles.css');`.
+            'selector':
+                'CallExpression[callee.property.name="registerRequiredCSS"][arguments.length=1]:has(Literal[value=/css$/])',
+            'message': 'Styles should be imported using `import styles from \'[file name].css(.legacy).js\';` and' +
+                // Intentional double periods.. since trailing period is stripped from output.
+                ' registered using `.registerCSSFiles([styles]);` or `.registerRequiredCSS(legacyStyles);` syntax..',
+          }
+        ],
       }
     },
     {

package/front_end/Images/src/{feedback_thin_16x16_icon.svg → survey_feedback_icon.svg}

@@ -1 +1 @@
-<svg width="16" height="16" fill="none" xmlns="http://www.w3.org/2000/svg"><path fill-rule="evenodd" clip-rule="evenodd" d="M5 11.5h9a1 1 0 001-1v-8a1 1 0 00-1-1H3a1 1 0 00-1 1v12l3-3zm-2 .586L4.586 10.5H14v-8H3v9.586z" fill="#000"/><path fill="#000" d="M8 4h1v3H8zM8 8h1v1H8z"/></svg>
+<svg width="16" height="16" fill="none" xmlns="http://www.w3.org/2000/svg"><path fill-rule="evenodd" clip-rule="evenodd" d="M5 11.5h9a1 1 0 001-1v-8a1 1 0 00-1-1H3a1 1 0 00-1 1v12l3-3zm-2 .586L4.586 10.5H14v-8H3v9.586z" fill="#000"/><path fill="#000" d="M8 4h1v3H8zM8 8h1v1H8z"/></svg>

package/front_end/Tests.js

@@ -1454,38 +1454,6 @@
     this.releaseControl();
   };
 
-  TestSuite.prototype.testInputDispatchEventsToCorrectTarget = async function() {
-    this.takeControl();
-
-    const mainTarget = self.SDK.targetManager.mainTarget();
-    const otherTarget = await createIsolatedTarget('about:blank');
-
-    const setupLogging = `
-      window.logs = [];
-      ['dragenter', 'keydown', 'mousedown', 'mouseenter', 'mouseleave', 'mousemove', 'mouseout', 'mouseover', 'mouseup',
-       'click', 'touchcancel', 'touchend', 'touchmove', 'touchstart',
-      ].forEach((event) => window.addEventListener(event, (e) => logs.push(e.type)));`;
-    await evalCode(mainTarget, setupLogging);
-    await evalCode(otherTarget, setupLogging);
-
-    const inputAgent = mainTarget.inputAgent();
-    await inputAgent.invoke_dispatchMouseEvent({type: 'mousePressed', button: 'left', clickCount: 1, x: 100, y: 250});
-    await inputAgent.invoke_dispatchMouseEvent({type: 'mouseMoved', button: 'left', clickCount: 1, x: 110, y: 270});
-    await inputAgent.invoke_dispatchMouseEvent({type: 'mouseReleased', button: 'left', clickCount: 1, x: 110, y: 270});
-    await inputAgent.invoke_dispatchDragEvent(
-        {type: 'dragEnter', x: 100, y: 250, data: {items: [], dragOperationsMask: 1}});
-    await inputAgent.invoke_synthesizeTapGesture({x: 100, y: 250});
-    await inputAgent.invoke_dispatchKeyEvent({type: 'keyDown', key: 'a'});
-
-    const mainTargetEvents = await evalCode(mainTarget, ' logs.join(\' \')');
-    const otherTargetEvents = await evalCode(otherTarget, 'logs.join(\' \')');
-    this.assertEquals(
-        'mainTargetEvents: mouseover mousedown mousemove mouseup click dragenter keydown; otherTargetEvents: ',
-        `mainTargetEvents: ${mainTargetEvents}; otherTargetEvents: ${otherTargetEvents}`);
-
-    this.releaseControl();
-  };
-
   TestSuite.prototype.testLoadResourceForFrontend = async function(baseURL, fileURL) {
     const test = this;
     const loggedHeaders = new Set(['cache-control', 'pragma']);