chrome-devtools-frontend 1.0.942095 → 1.0.942529

package/front_end/ui/legacy/components/quick_open/filteredListWidget.css

@@ -113,7 +113,7 @@ devtools-text-prompt {
 }
 
 .filtered-list-widget-item .filtered-list-widget-title {
-  flex: auto;
+  flex: initial;
   overflow: hidden;
   text-overflow: ellipsis;
 }
@@ -194,7 +194,7 @@ devtools-text-prompt {
 }
 
 .filtered-list-widget-item.one-row .filtered-list-widget-title {
-  flex: none;
+  padding-right: 8px;
 }
 
 .filtered-list-widget-item.two-rows {

package/front_end/ui/legacy/components/source_frame/FontView.ts

@@ -59,6 +59,7 @@ export class FontView extends UI.View.SimpleView {
   private inResize!: boolean|null;
   constructor(mimeType: string, contentProvider: TextUtils.ContentProvider.ContentProvider) {
     super(i18nString(UIStrings.font));
+    // eslint-disable-next-line no-restricted-syntax -- Should import styles https://crbug.com/1106746
     this.registerRequiredCSS('ui/legacy/components/source_frame/fontView.css');
     this.element.classList.add('font-view');
     this.url = contentProvider.contentURL();

package/front_end/ui/legacy/components/source_frame/ImageView.ts

@@ -96,6 +96,7 @@ export class ImageView extends UI.View.SimpleView {
   private cachedContent?: string|null;
   constructor(mimeType: string, contentProvider: TextUtils.ContentProvider.ContentProvider) {
     super(i18nString(UIStrings.image));
+    // eslint-disable-next-line no-restricted-syntax -- Should import styles https://crbug.com/1106746
     this.registerRequiredCSS('ui/legacy/components/source_frame/imageView.css');
     this.element.tabIndex = -1;
     this.element.classList.add('image-view');

package/front_end/ui/legacy/components/source_frame/JSONView.ts

@@ -54,6 +54,7 @@ export class JSONView extends UI.Widget.VBox implements UI.SearchableView.Search
   constructor(parsedJSON: ParsedJSON, startCollapsed?: boolean) {
     super();
     this.initialized = false;
+    // eslint-disable-next-line no-restricted-syntax -- Should import styles https://crbug.com/1106746
     this.registerRequiredCSS('ui/legacy/components/source_frame/jsonView.css');
     this.parsedJSON = parsedJSON;
     this.startCollapsed = Boolean(startCollapsed);

package/front_end/ui/legacy/components/source_frame/ResourceSourceFrame.ts

@@ -83,6 +83,7 @@ export class SearchableContainer extends UI.Widget.VBox {
 
   constructor(resource: TextUtils.ContentProvider.ContentProvider, contentType: string, autoPrettyPrint?: boolean) {
     super(true);
+    // eslint-disable-next-line no-restricted-syntax -- Should import styles https://crbug.com/1106746
     this.registerRequiredCSS('ui/legacy/components/source_frame/resourceSourceFrame.css');
     const sourceFrame = new ResourceSourceFrame(resource, contentType);
     this.sourceFrame = sourceFrame;

package/front_end/ui/legacy/components/source_frame/XMLView.ts

@@ -25,9 +25,11 @@ export class XMLView extends UI.Widget.Widget implements UI.SearchableView.Searc
 
   constructor(parsedXML: Document) {
     super(true);
+    // eslint-disable-next-line no-restricted-syntax -- Should import styles https://crbug.com/1106746
     this.registerRequiredCSS('ui/legacy/components/source_frame/xmlView.css');
     this.contentElement.classList.add('shadow-xml-view', 'source-code');
     this.treeOutline = new UI.TreeOutline.TreeOutlineInShadow();
+    // eslint-disable-next-line no-restricted-syntax -- Should import styles https://crbug.com/1106746
     this.treeOutline.registerRequiredCSS('ui/legacy/components/source_frame/xmlTree.css');
     this.contentElement.appendChild(this.treeOutline.element);
     this.currentSearchFocusIndex = 0;

package/front_end/ui/legacy/components/source_frame/module.json

@@ -1,7 +1,4 @@
 {
-  "dependencies": [
-    "ui/legacy"
-  ],
     "resources": [
     "fontView.css",
     "imageView.css",

package/front_end/ui/legacy/components/text_editor/CodeMirrorTextEditor.ts

@@ -93,7 +93,9 @@ export class CodeMirrorTextEditor extends
     super();
     this.options = options;
 
+    // eslint-disable-next-line no-restricted-syntax -- Should import styles https://crbug.com/1106746
     this.registerRequiredCSS('third_party/codemirror/codemirror.css');
+    // eslint-disable-next-line no-restricted-syntax -- Should import styles https://crbug.com/1106746
     this.registerRequiredCSS('ui/legacy/components/text_editor/cmdevtools.css');
 
     const {indentWithTabs, indentUnit} = CodeMirrorTextEditor.getIndentation(

package/front_end/ui/legacy/components/text_editor/module.json

@@ -1,7 +1,4 @@
 {
-  "dependencies": [
-    "ui/legacy"
-  ],
   "resources": [
     "../../../../third_party/codemirror/codemirror.css",
     "autocompleteTooltip.css",

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -227,21 +227,13 @@ export class Linkifier implements SDK.TargetManager.Observer {
       return fallbackAnchor;
     }
 
-    let rawLocation;
-    if (scriptId) {
-      rawLocation = debuggerModel.createRawLocationByScriptId(
-          scriptId, lineNumber || 0, columnNumber, linkifyURLOptions.inlineFrameIndex);
-    }
-    // The function createRawLocationByScriptId will always return a raw location. Normally
-    // we rely on the live location that is created from it to update missing information
-    // to create the link. If we, however, already have a similar script with the same source url,
-    // use that one.
-    if (!rawLocation?.script()) {
-      rawLocation = debuggerModel.createRawLocationByURL(
-                        sourceURL, lineNumber || 0, columnNumber, linkifyURLOptions.inlineFrameIndex) ||
-          rawLocation;
-    }
-
+    // Prefer createRawLocationByScriptId() here, since it will always produce a correct
+    // link, since the script ID is unique. Only fall back to createRawLocationByURL()
+    // when all we have is an URL, which is not guaranteed to be unique.
+    const rawLocation = scriptId ? debuggerModel.createRawLocationByScriptId(
+                                       scriptId, lineNumber || 0, columnNumber, linkifyURLOptions.inlineFrameIndex) :
+                                   debuggerModel.createRawLocationByURL(
+                                       sourceURL, lineNumber || 0, columnNumber, linkifyURLOptions.inlineFrameIndex);
     if (!rawLocation) {
       return fallbackAnchor;
     }

package/front_end/ui/legacy/theme_support/theme_support_impl.ts

@@ -35,7 +35,9 @@
 
 import * as Common from '../../../core/common/common.js';
 import * as Platform from '../../../core/platform/platform.js';
-import * as Root from '../../../core/root/root.js';
+
+import inspectorSyntaxHighlightStyles from '../inspectorSyntaxHighlight.css.legacy.js';
+import inspectorSyntaxHighlightDarkStyles from '../inspectorSyntaxHighlightDark.css.legacy.js';
 
 let themeSupportInstance: ThemeSupport;
 
@@ -112,9 +114,9 @@ export class ThemeSupport {
 
   injectHighlightStyleSheets(element: Element|ShadowRoot): void {
     this.injectingStyleSheet = true;
-    this.appendStyle(element, 'ui/legacy/inspectorSyntaxHighlight.css');
+    this.appendStyle(element, inspectorSyntaxHighlightStyles);
     if (this.themeNameInternal === 'dark') {
-      this.appendStyle(element, 'ui/legacy/inspectorSyntaxHighlightDark.css');
+      this.appendStyle(element, inspectorSyntaxHighlightDarkStyles);
     }
     this.injectingStyleSheet = false;
   }
@@ -123,13 +125,9 @@ export class ThemeSupport {
    * Note: this is a duplicate of the function in ui/utils. It exists here
    * so there is no circular dependency between ui/utils and theme_support.
    */
-  private appendStyle(node: Node, cssFile: string): void {
-    const content = Root.Runtime.cachedResources.get(cssFile) || '';
-    if (!content) {
-      console.error(cssFile + ' not preloaded. Check module.json');
-    }
+  private appendStyle(node: Node, {cssContent}: {cssContent: string}): void {
     const styleElement = document.createElement('style');
-    styleElement.textContent = content;
+    styleElement.textContent = cssContent;
     node.appendChild(styleElement);
   }
 

package/front_end/ui/legacy/utils/create-shadow-root-with-core-styles.ts

@@ -7,7 +7,7 @@ import {focusChanged} from './focus-changed.js';
 import {injectCoreStyles} from './inject-core-styles.js';
 
 interface Options {
-  cssFile?: string|CSSStyleSheet[];
+  cssFile?: string|CSSStyleSheet[]|{cssContent: string};
   delegatesFocus?: boolean;
 }
 
@@ -22,7 +22,7 @@ export function createShadowRootWithCoreStyles(element: Element, options: Option
 
   const shadowRoot = element.attachShadow({mode: 'open', delegatesFocus});
   injectCoreStyles(shadowRoot);
-  if (typeof cssFile === 'string') {
+  if (typeof cssFile === 'string' || (cssFile !== undefined && 'cssContent' in cssFile)) {
     appendStyle(shadowRoot, cssFile);
   } else if (cssFile) {
     shadowRoot.adoptedStyleSheets = cssFile;

package/front_end/ui/legacy/utils/inject-core-styles.ts

@@ -2,14 +2,17 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import inspectorCommonStyles from '../inspectorCommon.css.legacy.js';
+import textButtonStyles from '../textButton.css.legacy.js';
 import * as ThemeSupport from '../theme_support/theme_support.js';
+import themeColorsStyles from '../themeColors.css.legacy.js';
+
 import {appendStyle} from './append-style.js';
 
 export function injectCoreStyles(root: Element|ShadowRoot): void {
-  // TODO: Migrate inspectorCommpon.css last https://crbug.com/1222666
-  appendStyle(root, 'ui/legacy/inspectorCommon.css');
-  appendStyle(root, 'ui/legacy/textButton.css');
-  appendStyle(root, 'ui/legacy/themeColors.css');
+  appendStyle(root, inspectorCommonStyles);
+  appendStyle(root, textButtonStyles);
+  appendStyle(root, themeColorsStyles);
 
   ThemeSupport.ThemeSupport.instance().injectHighlightStyleSheets(root);
   ThemeSupport.ThemeSupport.instance().injectCustomStyleSheets(root);

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.942095"
+  "version": "1.0.942529"
 }

package/front_end/panels/emulation/module.json

@@ -1,11 +0,0 @@
-{
-  "dependencies": [
-    "ui/legacy"
-  ],
-    "resources": [
-    "deviceModeToolbar.css",
-    "deviceModeView.css",
-    "inspectedPagePlaceholder.css",
-    "mediaQueryInspector.css"
-  ]
-}