chrome-devtools-frontend 1.0.941208 → 1.0.943182

package/front_end/panels/emulation/emulation-meta.ts

@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Emulation from './emulation.js';
 
 import * as i18n from '../../core/i18n/i18n.js';
@@ -47,11 +46,11 @@ const UIStrings = {
   /**
   *@description Command that shows measuring rulers next to the emulated device.
   */
-  showRulers: 'Show rulers',
+  showRulers: 'Show rulers in the Device Mode toolbar',
   /**
   *@description Command that hides measuring rulers next to the emulated device.
   */
-  hideRulers: 'Hide rulers',
+  hideRulers: 'Hide rulers in the Device Mode toolbar',
   /**
   *@description Command that shows a frame (like a picture frame) around the emulated device.
   */
@@ -69,8 +68,6 @@ let loadedEmulationModule: (typeof Emulation|undefined);
 
 async function loadEmulationModule(): Promise<typeof Emulation> {
   if (!loadedEmulationModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/emulation');
     loadedEmulationModule = await import('./emulation.js');
   }
   return loadedEmulationModule;

package/front_end/panels/help/help-meta.ts

@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Help from './help.js';
 
 const UIStrings = {

package/front_end/panels/input/input-meta.ts

@@ -6,7 +6,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Input from './input.js';
 
 const UIStrings = {

package/front_end/panels/issues/issues-meta.ts

@@ -7,7 +7,6 @@ import * as Root from '../../core/root/root.js';
 import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Issues from './issues.js';
 
 import * as i18n from '../../core/i18n/i18n.js';
@@ -35,8 +34,6 @@ let loadedIssuesModule: (typeof Issues|undefined);
 
 async function loadIssuesModule(): Promise<typeof Issues> {
   if (!loadedIssuesModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/issues');
     loadedIssuesModule = await import('./issues.js');
   }
   return loadedIssuesModule;

package/front_end/panels/js_profiler/js_profiler-meta.ts

@@ -3,10 +3,8 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Profiler from '../profiler/profiler.js';
 
 const UIStrings = {
@@ -30,8 +28,6 @@ let loadedProfilerModule: (typeof Profiler|undefined);
 
 async function loadProfilerModule(): Promise<typeof Profiler> {
   if (!loadedProfilerModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/profiler');
     loadedProfilerModule = await import('../profiler/profiler.js');
   }
   return loadedProfilerModule;

package/front_end/panels/layers/layers-meta.ts

@@ -3,10 +3,8 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Layers from './layers.js';
 
 const UIStrings = {
@@ -26,8 +24,6 @@ let loadedLayersModule: (typeof Layers|undefined);
 
 async function loadLayersModule(): Promise<typeof Layers> {
   if (!loadedLayersModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/layers');
     loadedLayersModule = await import('./layers.js');
   }
   return loadedLayersModule;

package/front_end/panels/lighthouse/LighthousePanel.ts

@@ -7,8 +7,6 @@ import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as EmulationModel from '../../models/emulation/emulation.js';
-/* eslint-disable rulesdir/es_modules_import */
-import reportStyles from '../../third_party/lighthouse/report-assets/report.css.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Emulation from '../emulation/emulation.js';
 
@@ -263,7 +261,6 @@ export class LighthousePanel extends UI.Panel.Panel {
 
     const reportContainer = this.auditResultsElement.createChild('div', 'lh-vars lh-root lh-devtools');
 
-    // @ts-ignore: Second argument will soon be required.
     const dom = new LighthouseReport.DOM(this.auditResultsElement.ownerDocument as Document, reportContainer);
     const renderer = new LighthouseReportRenderer(dom) as LighthouseReport.ReportRenderer;
 
@@ -451,8 +448,9 @@ export class LighthousePanel extends UI.Panel.Panel {
     const inspectedURL = await this.controller.getInspectedURL();
     await resourceTreeModel.navigate(inspectedURL);
   }
+
   wasShown(): void {
     super.wasShown();
-    this.registerCSSFiles([lighthousePanelStyles, reportStyles]);
+    this.registerCSSFiles([lighthousePanelStyles]);
   }
 }

package/front_end/panels/lighthouse/LighthouseReportRenderer.ts

@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as LighthouseReport from '../../third_party/lighthouse/report/report.js';
@@ -202,9 +201,7 @@ export class LighthouseReportUIFeatures extends LighthouseReport.ReportUIFeature
     if (!printWindow) {
       return;
     }
-    const style = printWindow.document.createElement('style');
-    style.textContent = Root.Runtime.cachedResources.get('third_party/lighthouse/report-assets/report.css') || '';
-    printWindow.document.head.appendChild(style);
+
     printWindow.document.body.replaceWith(clonedReport);
     // Linkified nodes are shadow elements, which aren't exposed via `cloneNode`.
     await LighthouseReportRenderer.linkifyNodeDetails(clonedReport as HTMLElement);

package/front_end/panels/lighthouse/lighthouse-meta.ts

@@ -6,7 +6,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Lighthouse from './lighthouse.js';
 
 const UIStrings = {

package/front_end/panels/lighthouse/lighthouseStartView.css

@@ -74,6 +74,10 @@ input[type="radio"]:focus {
   outline-width: 2px;
 }
 
+:host-context(.-theme-with-dark-background) input[type="radio"] {
+  accent-color: var(--color-checkbox-accent-color);
+}
+
 .lighthouse-radio-text {
   margin-left: 3px;
 }

package/front_end/panels/lighthouse/module.json

@@ -1,12 +1,6 @@
 {
-  "dependencies": [
-    "panels/emulation",
-    "panels/timeline",
-    "ui/legacy"
-  ],
   "resources": [
     "../../third_party/lighthouse/report-assets/standalone-template.html",
-    "../../third_party/lighthouse/report-assets/report.css",
     "../../third_party/lighthouse/report-assets/report.js"
   ]
 }

package/front_end/panels/media/media-meta.ts

@@ -3,10 +3,8 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Media from './media.js';
 
 const UIStrings = {
@@ -30,8 +28,6 @@ let loadedMediaModule: (typeof Media|undefined);
 
 async function loadMediaModule(): Promise<typeof Media> {
   if (!loadedMediaModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/media');
     loadedMediaModule = await import('./media.js');
   }
   return loadedMediaModule;

package/front_end/panels/mobile_throttling/mobile_throttling-meta.ts

@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as MobileThrottling from './mobile_throttling.js';
 
 const UIStrings = {

package/front_end/panels/network/ResourceWebSocketFrameView.ts

@@ -331,7 +331,8 @@ export class ResourceWebSocketFrameView extends UI.Widget.VBox {
 
     this.splitWidget.setSidebarWidget(new SourceFrame.ResourceSourceFrame.ResourceSourceFrame(
         TextUtils.StaticContentProvider.StaticContentProvider.fromString(
-            this.request.url(), Common.ResourceType.resourceTypes.WebSocket, content)));
+            this.request.url(), Common.ResourceType.resourceTypes.WebSocket, content),
+        ''));
   }
 
   private onFrameDeselected(): void {

package/front_end/panels/network/network-meta.ts

@@ -3,16 +3,14 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import * as Root from '../../core/root/root.js';
+import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as NetworkForward from '../../panels/network/forward/forward.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Network from './network.js';
 
-import * as i18n from '../../core/i18n/i18n.js';
 const UIStrings = {
   /**
   *@description Command for showing the 'Network' tool
@@ -117,8 +115,6 @@ let loadedNetworkModule: (typeof Network|undefined);
 
 async function loadNetworkModule(): Promise<typeof Network> {
   if (!loadedNetworkModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/network');
     loadedNetworkModule = await import('./network.js');
   }
   return loadedNetworkModule;

package/front_end/panels/performance_monitor/performance_monitor-meta.ts

@@ -5,7 +5,6 @@
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as PerformanceMonitor from './performance_monitor.js';
 
 const UIStrings = {

package/front_end/panels/profiler/CPUProfileView.ts

@@ -149,9 +149,17 @@ export class CPUProfileType extends ProfileType {
     super(CPUProfileType.TypeId, i18nString(UIStrings.recordJavascriptCpuProfile));
     this.recording = false;
 
+    const targetManager = SDK.TargetManager.TargetManager.instance();
+    const profilerModels = targetManager.models(SDK.CPUProfilerModel.CPUProfilerModel);
+    for (const model of profilerModels) {
+      for (const message of model.registeredConsoleProfileMessages) {
+        this.consoleProfileFinished(message);
+      }
+    }
+
     SDK.TargetManager.TargetManager.instance().addModelListener(
         SDK.CPUProfilerModel.CPUProfilerModel, SDK.CPUProfilerModel.Events.ConsoleProfileFinished,
-        this.consoleProfileFinished, this);
+        event => this.consoleProfileFinished(event.data), this);
   }
 
   profileBeingRecorded(): ProfileHeader|null {
@@ -187,8 +195,7 @@ export class CPUProfileType extends ProfileType {
     return i18nString(UIStrings.cpuProfilesShow);
   }
 
-  consoleProfileFinished(event: Common.EventTarget.EventTargetEvent<SDK.CPUProfilerModel.ProfileFinishedData>): void {
-    const data = event.data;
+  consoleProfileFinished(data: SDK.CPUProfilerModel.ProfileFinishedData): void {
     const profile = new CPUProfileHeader(data.cpuProfilerModel, this, data.title);
     profile.setProtocolProfile(data.cpuProfile);
     this.addProfile(profile);

package/front_end/panels/profiler/profiler-meta.ts

@@ -8,7 +8,6 @@ import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Profiler from './profiler.js';
 
 let loadedProfilerModule: (typeof Profiler|undefined);
@@ -57,8 +56,6 @@ const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined
 
 async function loadProfilerModule(): Promise<typeof Profiler> {
   if (!loadedProfilerModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/profiler');
     loadedProfilerModule = await import('./profiler.js');
   }
   return loadedProfilerModule;

package/front_end/panels/protocol_monitor/protocol_monitor-meta.ts

@@ -6,7 +6,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as ProtocolMonitor from './protocol_monitor.js';
 
 const UIStrings = {

package/front_end/panels/screencast/screencast-meta.ts

@@ -3,18 +3,14 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Screencast from './screencast.js';
 
 let loadedScreencastModule: (typeof Screencast|undefined);
 
 async function loadScreencastModule(): Promise<typeof Screencast> {
   if (!loadedScreencastModule) {
-    // Side-effect import rescreencast in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/screencast');
     loadedScreencastModule = await import('./screencast.js');
   }
   return loadedScreencastModule;

package/front_end/panels/security/security-meta.ts

@@ -3,10 +3,8 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Security from './security.js';
 
 const UIStrings = {
@@ -26,8 +24,6 @@ let loadedSecurityModule: (typeof Security|undefined);
 
 async function loadSecurityModule(): Promise<typeof Security> {
   if (!loadedSecurityModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/security');
     loadedSecurityModule = await import('./security.js');
   }
   return loadedSecurityModule;

package/front_end/panels/sensors/sensors-meta.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../core/common/common.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Sensors from './sensors.js';
 
 import * as i18n from '../../core/i18n/i18n.js';

package/front_end/panels/settings/emulation/emulation-meta.ts

@@ -5,7 +5,6 @@
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as UI from '../../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Emulation from './emulation.js';
 
 const UIStrings = {

package/front_end/panels/settings/settings-meta.ts

@@ -8,7 +8,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Settings from './settings.js';
 
 const UIStrings = {

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -3,8 +3,8 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import type * as TextEditor from '../../ui/components/text_editor/text_editor.js';
-import type * as CodeMirror from '../../third_party/codemirror.next/codemirror.next.js';
+import * as CodeMirror from '../../third_party/codemirror.next/codemirror.next.js';
+import * as TextEditor from '../../ui/components/text_editor/text_editor.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 import breakpointEditDialogStyles from './breakpointEditDialog.css.js';
@@ -60,37 +60,23 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
   private readonly typeSelector: UI.Toolbar.ToolbarComboBox;
   private placeholderCompartment: CodeMirror.Compartment;
 
-  static async create(
+  constructor(
       editorLineNumber: number,
       oldCondition: string,
       preferLogpoint: boolean,
       onFinish: (arg0: {committed: boolean, condition: string}) => Promise<void>,
-      ): Promise<BreakpointEditDialog> {
-    const TextEditor = await import('../../ui/components/text_editor/text_editor.js');
-    const CodeMirror = await import('../../third_party/codemirror.next/codemirror.next.js');
+  ) {
+    super(true);
+
     const editorConfig = [
-      (await CodeMirror.javascript()).javascriptLanguage,
+      CodeMirror.javascript.javascriptLanguage,
       TextEditor.Config.baseConfiguration(oldCondition || ''),
       TextEditor.Config.autocompletion,
       CodeMirror.EditorView.lineWrapping,
       TextEditor.Config.showCompletionHint,
-      await TextEditor.JavaScript.completion(),
+      TextEditor.JavaScript.completion(),
       TextEditor.JavaScript.argumentHints(),
     ];
-    return new BreakpointEditDialog(
-        editorLineNumber, oldCondition, preferLogpoint, onFinish, TextEditor, CodeMirror, editorConfig);
-  }
-
-  constructor(
-      editorLineNumber: number,
-      oldCondition: string,
-      preferLogpoint: boolean,
-      onFinish: (arg0: {committed: boolean, condition: string}) => Promise<void>,
-      modTextEditor: typeof TextEditor,
-      readonly modCodeMirror: typeof CodeMirror,
-      editorConfig: CodeMirror.Extension,
-  ) {
-    super(true);
 
     this.onFinish = onFinish;
     this.finished = false;
@@ -119,7 +105,7 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
 
     const content = oldCondition || '';
     const finishIfComplete = (view: CodeMirror.EditorView): boolean => {
-      if (modTextEditor.JavaScript.isExpressionComplete(view.state)) {
+      if (TextEditor.JavaScript.isExpressionComplete(view.state)) {
         this.finishEditing(true, this.editor.state.doc.toString());
         return true;
       }
@@ -135,8 +121,8 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
         run: finishIfComplete,
       },
       {
-        ...modCodeMirror.standardKeymap.find(binding => binding.key === 'Enter') as CodeMirror.KeyBinding,
         key: 'Shift-Enter',
+        run: CodeMirror.insertNewlineAndIndent,
       },
       {
         key: 'Escape',
@@ -147,17 +133,17 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
       },
     ];
 
-    this.placeholderCompartment = new modCodeMirror.Compartment();
+    this.placeholderCompartment = new CodeMirror.Compartment();
 
     const editorWrapper = this.contentElement.appendChild(document.createElement('div'));
     editorWrapper.classList.add('condition-editor');
 
-    this.editor = new modTextEditor.TextEditor.TextEditor(modCodeMirror.EditorState.create({
+    this.editor = new TextEditor.TextEditor.TextEditor(CodeMirror.EditorState.create({
       doc: content,
       selection: {anchor: 0, head: content.length},
       extensions: [
         this.placeholderCompartment.of(this.getPlaceholder()),
-        modCodeMirror.keymap.of(keymap),
+        CodeMirror.keymap.of(keymap),
         editorConfig,
       ],
     }));
@@ -185,7 +171,7 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
     if (type === BreakpointType.Breakpoint) {
       this.finishEditing(true, '');
     } else {
-      this.editor.editor.dispatch({effects: this.placeholderCompartment.reconfigure(this.getPlaceholder())});
+      this.editor.dispatch({effects: this.placeholderCompartment.reconfigure(this.getPlaceholder())});
       this.updateTooltip();
     }
   }
@@ -198,10 +184,10 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
   private getPlaceholder(): CodeMirror.Extension {
     const type = this.breakpointType;
     if (type === BreakpointType.Conditional) {
-      return this.modCodeMirror.placeholder(i18nString(UIStrings.expressionToCheckBeforePausingEg));
+      return CodeMirror.placeholder(i18nString(UIStrings.expressionToCheckBeforePausingEg));
     }
     if (type === BreakpointType.Logpoint) {
-      return this.modCodeMirror.placeholder(i18nString(UIStrings.logMessageEgXIsX));
+      return CodeMirror.placeholder(i18nString(UIStrings.logMessageEgXIsX));
     }
     return [];
   }