chrome-devtools-frontend 1.0.927127 → 1.0.928589

package/scripts/migration/class-fields/migrate.js

@@ -0,0 +1,56 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const {Project, ts, SyntaxKind, StructureKind} = require('ts-morph');
+const path = require('path');
+  const project = new Project({
+  tsConfigFilePath: '../devtools-frontend/tsconfig.json',
+});
+
+function isWithinContructor(classNode, reference) {
+  const constructors = classNode.getConstructors();
+  if (!constructors.length) {
+    return false;
+  }
+
+  if (constructors.length !== 1) {
+    throw new Error('More than one constructor');
+  }
+  return reference.getAncestors().includes(constructors[0]);
+}
+
+const files = project.getSourceFiles();
+for (const file of files) {
+  const filePath = file.getFilePath();
+  if (!filePath.startsWith(
+          path.normalize(path.join(process.cwd(), '..', 'devtools-frontend', 'front_end', process.argv[2])))) {
+    continue;
+  }
+  console.log(filePath);
+  if (filePath.includes('third_party') || filePath.includes('generated') || filePath.endsWith('.d.ts')) {
+    continue;
+  }
+  const classNodes = file.getClasses();
+  for (const classNode of classNodes) {
+    for (const property of classNode.getInstanceProperties()) {
+      const name = property.getStructure().name;
+      console.log(name);
+      if (name.startsWith('#') || !property.hasModifier(SyntaxKind.PrivateKeyword)) {
+        continue;
+      }
+
+      if (isWithinContructor(classNode, property)) {
+        continue;
+      }
+
+      property.toggleModifier('private', false);
+      // https://github.com/dsherret/ts-morph/issues/1198
+      property.rename(`SOME_STUPID_PREFIX_${name}`, {
+        renameInComments: true,
+      });
+    }
+  }
+  file.saveSync();
+}
+// project.save();

package/scripts/migration/class-fields/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "ts-morph": "^12.0.0"
+  }
+}

package/front_end/panels/console/components/SidebarDeprecation.ts

@@ -1,58 +0,0 @@
-// Copyright 2021 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-import * as i18n from '../../../core/i18n/i18n.js';
-import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
-import * as Linkifier from '../../../ui/components/linkifier/linkifier.js';
-import * as LitHtml from '../../../ui/lit-html/lit-html.js';
-
-import sidebarDeprecationStyles from './sidebarDeprecation.css.js';
-
-const UIStrings = {
-  /**
-   * @description The main text for the deprecation warning in the Console Sidebar.
-   */
-  deprecationNotice:
-      'This sidebar will be removed in a future version of Chrome. If you have feedback, please let us know via the',
-  /**
-    * @description the clickable text to take the user to the CRBug to give feedback.
-    */
-  issueTrackerLinkText: 'issue tracker',
-};
-
-const str_ = i18n.i18n.registerUIStrings('panels/console/components/SidebarDeprecation.ts', UIStrings);
-const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-export class SidebarDeprecation extends HTMLElement {
-  static readonly litTagName = LitHtml.literal`devtools-console-sidebar-deprecation`;
-  private readonly shadow = this.attachShadow({mode: 'open'});
-  private readonly renderBound = this.render.bind(this);
-
-  connectedCallback(): void {
-    this.shadow.adoptedStyleSheets = [sidebarDeprecationStyles];
-    ComponentHelpers.ScheduledRender.scheduleRender(this, this.renderBound);
-  }
-
-  private async render(): Promise<void> {
-    if (!ComponentHelpers.ScheduledRender.isScheduledRender(this)) {
-      throw new Error('ConsoleSidebar render was not scheduled');
-    }
-
-    // clang-format off
-    const link = LitHtml.html`<${Linkifier.Linkifier.Linkifier.litTagName} .data=${{
-      url: 'https://crbug.com/1232937',
-    } as Linkifier.Linkifier.LinkifierData}>${i18nString(UIStrings.issueTrackerLinkText)}</${Linkifier.Linkifier.Linkifier.litTagName}>`;
-
-    LitHtml.render(LitHtml.html`<p>
-      ${i18nString(UIStrings.deprecationNotice)} ${link}.
-    </p>`, this.shadow, {host: this});
-    // clang-format on
-  }
-}
-
-ComponentHelpers.CustomElements.defineComponent('devtools-console-sidebar-deprecation', SidebarDeprecation);
-
-declare global {
-  interface HTMLElementTagNameMap {
-    'devtools-console-sidebar-deprecation': SidebarDeprecation;
-  }
-}

package/front_end/panels/console/components/sidebarDeprecation.css

@@ -1,17 +0,0 @@
-/*
- * Copyright 2021 The Chromium Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-:host {
-  display: block;
-  background-color: var(--color-background-elevation-1);
-  padding: 4px 8px;
-  border-bottom: 1px solid var(--color-details-hairline);
-}
-
-.issue-tracker-link {
-  color: var(--color-primary);
-  text-decoration: underline;
-}