chrome-devtools-frontend 1.0.927127 → 1.0.928589

package/front_end/core/sdk/RuntimeModel.ts

@@ -1,3 +1,7 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
@@ -11,7 +15,7 @@
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
- *     * Neither the name of Google Inc. nor the names of its
+ *     * Neither the #name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
@@ -44,18 +48,18 @@ import {SDKModel} from './SDKModel.js';
 
 export class RuntimeModel extends SDKModel<EventTypes> {
   readonly agent: ProtocolProxyApi.RuntimeApi;
-  private readonly executionContextById: Map<number, ExecutionContext>;
-  private executionContextComparatorInternal: (arg0: ExecutionContext, arg1: ExecutionContext) => number;
-  private hasSideEffectSupportInternal: boolean|null;
+  readonly #executionContextById: Map<number, ExecutionContext>;
+  #executionContextComparatorInternal: (arg0: ExecutionContext, arg1: ExecutionContext) => number;
+  #hasSideEffectSupportInternal: boolean|null;
   constructor(target: Target) {
     super(target);
 
     this.agent = target.runtimeAgent();
     this.target().registerRuntimeDispatcher(new RuntimeDispatcher(this));
     this.agent.invoke_enable();
-    this.executionContextById = new Map();
-    this.executionContextComparatorInternal = ExecutionContext.comparator;
-    this.hasSideEffectSupportInternal = null;
+    this.#executionContextById = new Map();
+    this.#executionContextComparatorInternal = ExecutionContext.comparator;
+    this.#hasSideEffectSupportInternal = null;
 
     if (Common.Settings.Settings.instance().moduleSetting('customFormatters').get()) {
       this.agent.invoke_setCustomObjectFormatterEnabled({enabled: true});
@@ -82,17 +86,17 @@ export class RuntimeModel extends SDKModel<EventTypes> {
   }
 
   executionContexts(): ExecutionContext[] {
-    return [...this.executionContextById.values()].sort(this.executionContextComparator());
+    return [...this.#executionContextById.values()].sort(this.executionContextComparator());
   }
 
   setExecutionContextComparator(comparator: (arg0: ExecutionContext, arg1: ExecutionContext) => number): void {
-    this.executionContextComparatorInternal = comparator;
+    this.#executionContextComparatorInternal = comparator;
   }
 
   /** comparator
      */
   executionContextComparator(): (arg0: ExecutionContext, arg1: ExecutionContext) => number {
-    return this.executionContextComparatorInternal;
+    return this.#executionContextComparatorInternal;
   }
 
   defaultExecutionContext(): ExecutionContext|null {
@@ -105,24 +109,24 @@ export class RuntimeModel extends SDKModel<EventTypes> {
   }
 
   executionContext(id: number): ExecutionContext|null {
-    return this.executionContextById.get(id) || null;
+    return this.#executionContextById.get(id) || null;
   }
 
   executionContextCreated(context: Protocol.Runtime.ExecutionContextDescription): void {
     const data = context.auxData || {isDefault: true};
     const executionContext = new ExecutionContext(
         this, context.id, context.uniqueId, context.name, context.origin, data['isDefault'], data['frameId']);
-    this.executionContextById.set(executionContext.id, executionContext);
+    this.#executionContextById.set(executionContext.id, executionContext);
     this.dispatchEventToListeners(Events.ExecutionContextCreated, executionContext);
   }
 
   executionContextDestroyed(executionContextId: number): void {
-    const executionContext = this.executionContextById.get(executionContextId);
+    const executionContext = this.#executionContextById.get(executionContextId);
     if (!executionContext) {
       return;
     }
     this.debuggerModel().executionContextDestroyed(executionContext);
-    this.executionContextById.delete(executionContextId);
+    this.#executionContextById.delete(executionContextId);
     this.dispatchEventToListeners(Events.ExecutionContextDestroyed, executionContext);
   }
 
@@ -133,7 +137,7 @@ export class RuntimeModel extends SDKModel<EventTypes> {
   executionContextsCleared(): void {
     this.debuggerModel().globalObjectCleared();
     const contexts = this.executionContexts();
-    this.executionContextById.clear();
+    this.#executionContextById.clear();
     for (let i = 0; i < contexts.length; ++i) {
       this.dispatchEventToListeners(Events.ExecutionContextDestroyed, contexts[i]);
     }
@@ -412,7 +416,7 @@ export class RuntimeModel extends SDKModel<EventTypes> {
   }
 
   hasSideEffectSupport(): boolean|null {
-    return this.hasSideEffectSupportInternal;
+    return this.#hasSideEffectSupportInternal;
   }
 
   async checkSideEffectSupport(): Promise<boolean> {
@@ -428,9 +432,9 @@ export class RuntimeModel extends SDKModel<EventTypes> {
       throwOnSideEffect: true,
     });
 
-    this.hasSideEffectSupportInternal = response.getError() ? false : RuntimeModel.isSideEffectFailure(response);
+    this.#hasSideEffectSupportInternal = response.getError() ? false : RuntimeModel.isSideEffectFailure(response);
 
-    return this.hasSideEffectSupportInternal;
+    return this.#hasSideEffectSupportInternal;
   }
 
   // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
@@ -497,42 +501,42 @@ export type EventTypes = {
 };
 
 class RuntimeDispatcher implements ProtocolProxyApi.RuntimeDispatcher {
-  private readonly runtimeModel: RuntimeModel;
+  readonly #runtimeModel: RuntimeModel;
   constructor(runtimeModel: RuntimeModel) {
-    this.runtimeModel = runtimeModel;
+    this.#runtimeModel = runtimeModel;
   }
 
   executionContextCreated({context}: Protocol.Runtime.ExecutionContextCreatedEvent): void {
-    this.runtimeModel.executionContextCreated(context);
+    this.#runtimeModel.executionContextCreated(context);
   }
 
   executionContextDestroyed({executionContextId}: Protocol.Runtime.ExecutionContextDestroyedEvent): void {
-    this.runtimeModel.executionContextDestroyed(executionContextId);
+    this.#runtimeModel.executionContextDestroyed(executionContextId);
   }
 
   executionContextsCleared(): void {
-    this.runtimeModel.executionContextsCleared();
+    this.#runtimeModel.executionContextsCleared();
   }
 
   exceptionThrown({timestamp, exceptionDetails}: Protocol.Runtime.ExceptionThrownEvent): void {
-    this.runtimeModel.exceptionThrown(timestamp, exceptionDetails);
+    this.#runtimeModel.exceptionThrown(timestamp, exceptionDetails);
   }
 
   exceptionRevoked({exceptionId}: Protocol.Runtime.ExceptionRevokedEvent): void {
-    this.runtimeModel.exceptionRevoked(exceptionId);
+    this.#runtimeModel.exceptionRevoked(exceptionId);
   }
 
   consoleAPICalled({type, args, executionContextId, timestamp, stackTrace, context}:
                        Protocol.Runtime.ConsoleAPICalledEvent): void {
-    this.runtimeModel.consoleAPICalled(type, args, executionContextId, timestamp, stackTrace, context);
+    this.#runtimeModel.consoleAPICalled(type, args, executionContextId, timestamp, stackTrace, context);
   }
 
   inspectRequested({object, hints, executionContextId}: Protocol.Runtime.InspectRequestedEvent): void {
-    this.runtimeModel.inspectRequested(object, hints, executionContextId);
+    this.#runtimeModel.inspectRequested(object, hints, executionContextId);
   }
 
   bindingCalled(event: Protocol.Runtime.BindingCalledEvent): void {
-    this.runtimeModel.bindingCalled(event);
+    this.#runtimeModel.bindingCalled(event);
   }
 }
 
@@ -540,7 +544,7 @@ export class ExecutionContext {
   id: Protocol.Runtime.ExecutionContextId;
   uniqueId: string;
   name: string;
-  private labelInternal: string|null;
+  #labelInternal: string|null;
   origin: string;
   isDefault: boolean;
   runtimeModel: RuntimeModel;
@@ -552,7 +556,7 @@ export class ExecutionContext {
     this.id = id;
     this.uniqueId = uniqueId;
     this.name = name;
-    this.labelInternal = null;
+    this.#labelInternal = null;
     this.origin = origin;
     this.isDefault = isDefault;
     this.runtimeModel = runtimeModel;
@@ -702,7 +706,7 @@ export class ExecutionContext {
   }
 
   label(): string|null {
-    return this.labelInternal;
+    return this.#labelInternal;
   }
 
   setLabel(label: string): void {
@@ -712,15 +716,15 @@ export class ExecutionContext {
 
   private setLabelInternal(label: string): void {
     if (label) {
-      this.labelInternal = label;
+      this.#labelInternal = label;
       return;
     }
     if (this.name) {
-      this.labelInternal = this.name;
+      this.#labelInternal = this.name;
       return;
     }
     const parsedUrl = Common.ParsedURL.ParsedURL.fromString(this.origin);
-    this.labelInternal = parsedUrl ? parsedUrl.lastPathComponentWithFragment() : '';
+    this.#labelInternal = parsedUrl ? parsedUrl.lastPathComponentWithFragment() : '';
   }
 }
 

package/front_end/core/sdk/SDKModel.ts

@@ -17,15 +17,15 @@ const registeredModels = new Map<new (arg1: Target) => SDKModel, RegistrationInf
 //                         all event emitters and sinks have been migrated.
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export class SDKModel<Events = any> extends Common.ObjectWrapper.ObjectWrapper<Events> {
-  private readonly targetInternal: Target;
+  readonly #targetInternal: Target;
 
   constructor(target: Target) {
     super();
-    this.targetInternal = target;
+    this.#targetInternal = target;
   }
 
   target(): Target {
-    return this.targetInternal;
+    return this.#targetInternal;
   }
 
   /**

package/front_end/core/sdk/ScreenCaptureModel.ts

@@ -11,14 +11,14 @@ import {Capability} from './Target.js';
 import {SDKModel} from './SDKModel.js';
 
 export class ScreenCaptureModel extends SDKModel<void> implements ProtocolProxyApi.PageDispatcher {
-  private readonly agent: ProtocolProxyApi.PageApi;
-  private onScreencastFrame: ((arg0: Protocol.binary, arg1: Protocol.Page.ScreencastFrameMetadata) => void)|null;
-  private onScreencastVisibilityChanged: ((arg0: boolean) => void)|null;
+  readonly #agent: ProtocolProxyApi.PageApi;
+  #onScreencastFrame: ((arg0: Protocol.binary, arg1: Protocol.Page.ScreencastFrameMetadata) => void)|null;
+  #onScreencastVisibilityChanged: ((arg0: boolean) => void)|null;
   constructor(target: Target) {
     super(target);
-    this.agent = target.pageAgent();
-    this.onScreencastFrame = null;
-    this.onScreencastVisibilityChanged = null;
+    this.#agent = target.pageAgent();
+    this.#onScreencastFrame = null;
+    this.#onScreencastVisibilityChanged = null;
     target.registerPageDispatcher(this);
   }
 
@@ -27,22 +27,22 @@ export class ScreenCaptureModel extends SDKModel<void> implements ProtocolProxyA
       maxHeight: number|undefined, everyNthFrame: number|undefined,
       onFrame: (arg0: Protocol.binary, arg1: Protocol.Page.ScreencastFrameMetadata) => void,
       onVisibilityChanged: (arg0: boolean) => void): void {
-    this.onScreencastFrame = onFrame;
-    this.onScreencastVisibilityChanged = onVisibilityChanged;
-    this.agent.invoke_startScreencast({format, quality, maxWidth, maxHeight, everyNthFrame});
+    this.#onScreencastFrame = onFrame;
+    this.#onScreencastVisibilityChanged = onVisibilityChanged;
+    this.#agent.invoke_startScreencast({format, quality, maxWidth, maxHeight, everyNthFrame});
   }
 
   stopScreencast(): void {
-    this.onScreencastFrame = null;
-    this.onScreencastVisibilityChanged = null;
-    this.agent.invoke_stopScreencast();
+    this.#onScreencastFrame = null;
+    this.#onScreencastVisibilityChanged = null;
+    this.#agent.invoke_stopScreencast();
   }
 
   async captureScreenshot(
       format: Protocol.Page.CaptureScreenshotRequestFormat, quality: number,
       clip?: Protocol.Page.Viewport): Promise<string|null> {
     await OverlayModel.muteHighlight();
-    const result = await this.agent.invoke_captureScreenshot(
+    const result = await this.#agent.invoke_captureScreenshot(
         {format, quality, clip, fromSurface: true, captureBeyondViewport: true});
     await OverlayModel.unmuteHighlight();
     return result.data;
@@ -55,7 +55,7 @@ export class ScreenCaptureModel extends SDKModel<void> implements ProtocolProxyA
     contentWidth: number,
     contentHeight: number,
   }|null> {
-    const response = await this.agent.invoke_getLayoutMetrics();
+    const response = await this.#agent.invoke_getLayoutMetrics();
     if (response.getError()) {
       return null;
     }
@@ -69,15 +69,15 @@ export class ScreenCaptureModel extends SDKModel<void> implements ProtocolProxyA
   }
 
   screencastFrame({data, metadata, sessionId}: Protocol.Page.ScreencastFrameEvent): void {
-    this.agent.invoke_screencastFrameAck({sessionId});
-    if (this.onScreencastFrame) {
-      this.onScreencastFrame.call(null, data, metadata);
+    this.#agent.invoke_screencastFrameAck({sessionId});
+    if (this.#onScreencastFrame) {
+      this.#onScreencastFrame.call(null, data, metadata);
     }
   }
 
   screencastVisibilityChanged({visible}: Protocol.Page.ScreencastVisibilityChangedEvent): void {
-    if (this.onScreencastVisibilityChanged) {
-      this.onScreencastVisibilityChanged.call(null, visible);
+    if (this.#onScreencastVisibilityChanged) {
+      this.#onScreencastVisibilityChanged.call(null, visible);
     }
   }
 

package/front_end/core/sdk/Script.ts

@@ -63,18 +63,18 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
   endColumn: number;
   executionContextId: number;
   hash: string;
-  private readonly isContentScriptInternal: boolean;
-  private readonly isLiveEditInternal: boolean;
+  readonly #isContentScriptInternal: boolean;
+  readonly #isLiveEditInternal: boolean;
   sourceMapURL: string|undefined;
   debugSymbols: Protocol.Debugger.DebugSymbols|null;
   hasSourceURL: boolean;
   contentLength: number;
-  private originalContentProviderInternal: TextUtils.ContentProvider.ContentProvider|null;
+  #originalContentProviderInternal: TextUtils.ContentProvider.ContentProvider|null;
   originStackTrace: Protocol.Runtime.StackTrace|null;
-  private readonly codeOffsetInternal: number|null;
-  private readonly language: string|null;
-  private contentPromise: Promise<TextUtils.ContentProvider.DeferredContent>|null;
-  private readonly embedderNameInternal: string|null;
+  readonly #codeOffsetInternal: number|null;
+  readonly #language: string|null;
+  #contentPromise: Promise<TextUtils.ContentProvider.DeferredContent>|null;
+  readonly #embedderNameInternal: string|null;
   readonly isModule: boolean|null;
   constructor(
       debuggerModel: DebuggerModel, scriptId: Protocol.Runtime.ScriptId, sourceURL: string, startLine: number,
@@ -94,22 +94,22 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
 
     this.executionContextId = executionContextId;
     this.hash = hash;
-    this.isContentScriptInternal = isContentScript;
-    this.isLiveEditInternal = isLiveEdit;
+    this.#isContentScriptInternal = isContentScript;
+    this.#isLiveEditInternal = isLiveEdit;
     this.sourceMapURL = sourceMapURL;
     this.debugSymbols = debugSymbols;
     this.hasSourceURL = hasSourceURL;
     this.contentLength = length;
-    this.originalContentProviderInternal = null;
+    this.#originalContentProviderInternal = null;
     this.originStackTrace = originStackTrace;
-    this.codeOffsetInternal = codeOffset;
-    this.language = scriptLanguage;
-    this.contentPromise = null;
-    this.embedderNameInternal = embedderName;
+    this.#codeOffsetInternal = codeOffset;
+    this.#language = scriptLanguage;
+    this.#contentPromise = null;
+    this.#embedderNameInternal = embedderName;
   }
 
   embedderName(): string|null {
-    return this.embedderNameInternal;
+    return this.#embedderNameInternal;
   }
 
   target(): Target {
@@ -136,23 +136,23 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
   }
 
   isContentScript(): boolean {
-    return this.isContentScriptInternal;
+    return this.#isContentScriptInternal;
   }
 
   codeOffset(): number|null {
-    return this.codeOffsetInternal;
+    return this.#codeOffsetInternal;
   }
 
   isJavaScript(): boolean {
-    return this.language === Protocol.Debugger.ScriptLanguage.JavaScript;
+    return this.#language === Protocol.Debugger.ScriptLanguage.JavaScript;
   }
 
   isWasm(): boolean {
-    return this.language === Protocol.Debugger.ScriptLanguage.WebAssembly;
+    return this.#language === Protocol.Debugger.ScriptLanguage.WebAssembly;
   }
 
   scriptLanguage(): string|null {
-    return this.language;
+    return this.#language;
   }
 
   executionContext(): ExecutionContext|null {
@@ -160,7 +160,7 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
   }
 
   isLiveEdit(): boolean {
-    return this.isLiveEditInternal;
+    return this.#isLiveEditInternal;
   }
 
   contentURL(): string {
@@ -176,10 +176,10 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
   }
 
   requestContent(): Promise<TextUtils.ContentProvider.DeferredContent> {
-    if (!this.contentPromise) {
-      this.contentPromise = this.originalContentProvider().requestContent();
+    if (!this.#contentPromise) {
+      this.#contentPromise = this.originalContentProvider().requestContent();
     }
-    return this.contentPromise;
+    return this.#contentPromise;
   }
 
   async getWasmBytecode(): Promise<ArrayBuffer> {
@@ -189,10 +189,10 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
   }
 
   originalContentProvider(): TextUtils.ContentProvider.ContentProvider {
-    if (!this.originalContentProviderInternal) {
+    if (!this.#originalContentProviderInternal) {
       /* } */
       let lazyContentPromise: Promise<TextUtils.ContentProvider.DeferredContent>|null;
-      this.originalContentProviderInternal =
+      this.#originalContentProviderInternal =
           new TextUtils.StaticContentProvider.StaticContentProvider(this.contentURL(), this.contentType(), () => {
             if (!lazyContentPromise) {
               lazyContentPromise = (async(): Promise<{
@@ -232,7 +232,7 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
             return lazyContentPromise;
           });
     }
-    return this.originalContentProviderInternal;
+    return this.#originalContentProviderInternal;
   }
 
   async searchInContent(query: string, caseSensitive: boolean, isRegex: boolean):
@@ -261,7 +261,7 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
            arg2?: Array<Protocol.Debugger.CallFrame>|undefined, arg3?: Protocol.Runtime.StackTrace|undefined,
            arg4?: Protocol.Runtime.StackTraceId|undefined, arg5?: boolean|undefined) => void): Promise<void> {
     newSource = Script.trimSourceURLComment(newSource);
-    // We append correct sourceURL to script for consistency only. It's not actually needed for things to work correctly.
+    // We append correct #sourceURL to script for consistency only. It's not actually needed for things to work correctly.
     newSource = this.appendSourceURLCommentIfNeeded(newSource);
 
     if (!this.scriptId) {
@@ -278,7 +278,7 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
         {scriptId: this.scriptId, scriptSource: newSource});
 
     if (!response.getError() && !response.exceptionDetails) {
-      this.contentPromise = Promise.resolve({content: newSource, isEncoded: false});
+      this.#contentPromise = Promise.resolve({content: newSource, isEncoded: false});
     }
 
     const needsStepIn = Boolean(response.stackChanged);

package/front_end/core/sdk/SecurityOriginManager.ts

@@ -7,33 +7,33 @@ import {Capability} from './Target.js';
 import {SDKModel} from './SDKModel.js';
 
 export class SecurityOriginManager extends SDKModel<EventTypes> {
-  private mainSecurityOriginInternal: string;
-  private unreachableMainSecurityOriginInternal: string|null;
-  private securityOriginsInternal: Set<string>;
+  #mainSecurityOriginInternal: string;
+  #unreachableMainSecurityOriginInternal: string|null;
+  #securityOriginsInternal: Set<string>;
   constructor(target: Target) {
     super(target);
 
     // if a URL is unreachable, the browser will jump to an error page at
-    // 'chrome-error://chromewebdata/', and |this.mainSecurityOriginInternal| stores
+    // 'chrome-error://chromewebdata/', and |this.#mainSecurityOriginInternal| stores
     // its origin. In this situation, the original unreachable URL's security
-    // origin will be stored in |this.unreachableMainSecurityOriginInternal|.
-    this.mainSecurityOriginInternal = '';
-    this.unreachableMainSecurityOriginInternal = '';
+    // origin will be stored in |this.#unreachableMainSecurityOriginInternal|.
+    this.#mainSecurityOriginInternal = '';
+    this.#unreachableMainSecurityOriginInternal = '';
 
-    this.securityOriginsInternal = new Set();
+    this.#securityOriginsInternal = new Set();
   }
 
   updateSecurityOrigins(securityOrigins: Set<string>): void {
-    const oldOrigins = this.securityOriginsInternal;
-    this.securityOriginsInternal = securityOrigins;
+    const oldOrigins = this.#securityOriginsInternal;
+    this.#securityOriginsInternal = securityOrigins;
 
     for (const origin of oldOrigins) {
-      if (!this.securityOriginsInternal.has(origin)) {
+      if (!this.#securityOriginsInternal.has(origin)) {
         this.dispatchEventToListeners(Events.SecurityOriginRemoved, origin);
       }
     }
 
-    for (const origin of this.securityOriginsInternal) {
+    for (const origin of this.#securityOriginsInternal) {
       if (!oldOrigins.has(origin)) {
         this.dispatchEventToListeners(Events.SecurityOriginAdded, origin);
       }
@@ -41,23 +41,23 @@ export class SecurityOriginManager extends SDKModel<EventTypes> {
   }
 
   securityOrigins(): string[] {
-    return [...this.securityOriginsInternal];
+    return [...this.#securityOriginsInternal];
   }
 
   mainSecurityOrigin(): string {
-    return this.mainSecurityOriginInternal;
+    return this.#mainSecurityOriginInternal;
   }
 
   unreachableMainSecurityOrigin(): string|null {
-    return this.unreachableMainSecurityOriginInternal;
+    return this.#unreachableMainSecurityOriginInternal;
   }
 
   setMainSecurityOrigin(securityOrigin: string, unreachableSecurityOrigin: string): void {
-    this.mainSecurityOriginInternal = securityOrigin;
-    this.unreachableMainSecurityOriginInternal = unreachableSecurityOrigin || null;
+    this.#mainSecurityOriginInternal = securityOrigin;
+    this.#unreachableMainSecurityOriginInternal = unreachableSecurityOrigin || null;
     this.dispatchEventToListeners(Events.MainSecurityOriginChanged, {
-      mainSecurityOrigin: this.mainSecurityOriginInternal,
-      unreachableMainSecurityOrigin: this.unreachableMainSecurityOriginInternal,
+      mainSecurityOrigin: this.#mainSecurityOriginInternal,
+      unreachableMainSecurityOrigin: this.#unreachableMainSecurityOriginInternal,
     });
   }
 }

package/front_end/core/sdk/ServerTiming.ts

@@ -73,7 +73,7 @@ export class ServerTiming {
 
   /**
    * TODO(crbug.com/1011811): Instead of using !Object<string, *> we should have a proper type
-   *                          with name, desc and dur properties.
+   *                          with #name, desc and dur properties.
    */
   static createFromHeaderValue(valueString: string): {
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
@@ -165,7 +165,7 @@ export class ServerTiming {
         const parseParameter = this.getParserForParameter(paramName);
         let paramValue: (string|null)|null = null;
         if (consumeDelimiter('=')) {
-          // always parse the value, even if we don't recognize the parameter name
+          // always parse the value, even if we don't recognize the parameter #name
           paramValue = consumeTokenOrQuotedString();
           consumeExtraneous();
         }