chrome-devtools-frontend 1.0.927127 → 1.0.928589

package/front_end/core/sdk/ProfileTreeModel.ts

@@ -49,12 +49,12 @@ export class ProfileNode {
 }
 
 export class ProfileTreeModel {
-  private readonly targetInternal: Target|null;
+  readonly #targetInternal: Target|null;
   root!: ProfileNode;
   total!: number;
   maxDepth!: number;
   constructor(target?: Target|null) {
-    this.targetInternal = target || null;
+    this.#targetInternal = target || null;
   }
 
   initialize(root: ProfileNode): void {
@@ -105,6 +105,6 @@ export class ProfileTreeModel {
   }
 
   target(): Target|null {
-    return this.targetInternal;
+    return this.#targetInternal;
   }
 }

package/front_end/core/sdk/RemoteObject.ts

@@ -1,3 +1,7 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ -11,7 +15,7 @@
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
- *     * Neither the name of Google Inc. nor the names of its
+ *     * Neither the #name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
@@ -172,7 +176,7 @@ export class RemoteObject {
         propertySymbols.push(property);
       } else if (property.isOwn || property.name !== '__proto__') {
         // TODO(crbug/1076820): Eventually we should move away from
-        // showing accessor properties directly on the receiver.
+        // showing accessor #properties directly on the receiver.
         propertiesMap.set(property.name, property);
       }
     }
@@ -295,19 +299,19 @@ export class RemoteObject {
 
 export class RemoteObjectImpl extends RemoteObject {
   runtimeModelInternal: RuntimeModel;
-  private readonly runtimeAgent: ProtocolProxyApi.RuntimeApi;
-  private readonly typeInternal: string;
-  private readonly subtypeInternal: string|undefined;
-  private objectIdInternal: Protocol.Runtime.RemoteObjectId|undefined;
-  private descriptionInternal: string|undefined;
+  readonly #runtimeAgent: ProtocolProxyApi.RuntimeApi;
+  readonly #typeInternal: string;
+  readonly #subtypeInternal: string|undefined;
+  #objectIdInternal: Protocol.Runtime.RemoteObjectId|undefined;
+  #descriptionInternal: string|undefined;
   hasChildrenInternal: boolean;
-  private readonly previewInternal: Protocol.Runtime.ObjectPreview|undefined;
-  private readonly unserializableValueInternal: string|undefined;
+  readonly #previewInternal: Protocol.Runtime.ObjectPreview|undefined;
+  readonly #unserializableValueInternal: string|undefined;
   // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  private readonly valueInternal: any;
-  private readonly customPreviewInternal: Protocol.Runtime.CustomPreview|null;
-  private readonly classNameInternal: string|null;
+  readonly #valueInternal: any;
+  readonly #customPreviewInternal: Protocol.Runtime.CustomPreview|null;
+  readonly #classNameInternal: string|null;
 
   constructor(
       runtimeModel: RuntimeModel, objectId: Protocol.Runtime.RemoteObjectId|undefined, type: string,
@@ -318,27 +322,27 @@ export class RemoteObjectImpl extends RemoteObject {
     super();
 
     this.runtimeModelInternal = runtimeModel;
-    this.runtimeAgent = runtimeModel.target().runtimeAgent();
+    this.#runtimeAgent = runtimeModel.target().runtimeAgent();
 
-    this.typeInternal = type;
-    this.subtypeInternal = subtype;
+    this.#typeInternal = type;
+    this.#subtypeInternal = subtype;
     if (objectId) {
       // handle
-      this.objectIdInternal = objectId;
-      this.descriptionInternal = description;
+      this.#objectIdInternal = objectId;
+      this.#descriptionInternal = description;
       this.hasChildrenInternal = (type !== 'symbol');
-      this.previewInternal = preview;
+      this.#previewInternal = preview;
     } else {
-      this.descriptionInternal = description;
+      this.#descriptionInternal = description;
       if (!this.description && unserializableValue) {
-        this.descriptionInternal = unserializableValue;
+        this.#descriptionInternal = unserializableValue;
       }
-      if (!this.descriptionInternal && (typeof value !== 'object' || value === null)) {
-        this.descriptionInternal = String(value);
+      if (!this.#descriptionInternal && (typeof value !== 'object' || value === null)) {
+        this.#descriptionInternal = String(value);
       }
       this.hasChildrenInternal = false;
       if (typeof unserializableValue === 'string') {
-        this.unserializableValueInternal = unserializableValue;
+        this.#unserializableValueInternal = unserializableValue;
         // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
         // @ts-expect-error
         if (unserializableValue === UnserializableNumber.Infinity ||
@@ -351,53 +355,53 @@ export class RemoteObjectImpl extends RemoteObject {
             // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
             // @ts-expect-error
             unserializableValue === UnserializableNumber.NaN) {
-          this.valueInternal = Number(unserializableValue);
+          this.#valueInternal = Number(unserializableValue);
         } else if (type === 'bigint' && unserializableValue.endsWith('n')) {
-          this.valueInternal = BigInt(unserializableValue.substring(0, unserializableValue.length - 1));
+          this.#valueInternal = BigInt(unserializableValue.substring(0, unserializableValue.length - 1));
         } else {
-          this.valueInternal = unserializableValue;
+          this.#valueInternal = unserializableValue;
         }
 
       } else {
-        this.valueInternal = value;
+        this.#valueInternal = value;
       }
     }
-    this.customPreviewInternal = customPreview || null;
-    this.classNameInternal = typeof className === 'string' ? className : null;
+    this.#customPreviewInternal = customPreview || null;
+    this.#classNameInternal = typeof className === 'string' ? className : null;
   }
 
   customPreview(): Protocol.Runtime.CustomPreview|null {
-    return this.customPreviewInternal;
+    return this.#customPreviewInternal;
   }
 
   get objectId(): Protocol.Runtime.RemoteObjectId|undefined {
-    return this.objectIdInternal;
+    return this.#objectIdInternal;
   }
 
   get type(): string {
-    return this.typeInternal;
+    return this.#typeInternal;
   }
 
   get subtype(): string|undefined {
-    return this.subtypeInternal;
+    return this.#subtypeInternal;
   }
 
   // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   get value(): any {
-    return this.valueInternal;
+    return this.#valueInternal;
   }
 
   unserializableValue(): string|undefined {
-    return this.unserializableValueInternal;
+    return this.#unserializableValueInternal;
   }
 
   get description(): string|undefined {
-    return this.descriptionInternal;
+    return this.#descriptionInternal;
   }
 
   set description(description: string|undefined) {
-    this.descriptionInternal = description;
+    this.#descriptionInternal = description;
   }
 
   get hasChildren(): boolean {
@@ -405,11 +409,11 @@ export class RemoteObjectImpl extends RemoteObject {
   }
 
   get preview(): Protocol.Runtime.ObjectPreview|undefined {
-    return this.previewInternal;
+    return this.#previewInternal;
   }
 
   get className(): string|null {
-    return this.classNameInternal;
+    return this.#classNameInternal;
   }
 
   getOwnProperties(generatePreview: boolean, nonIndexedPropertiesOnly: boolean = false): Promise<GetPropertiesResult> {
@@ -429,12 +433,12 @@ export class RemoteObjectImpl extends RemoteObject {
   async doGetProperties(
       ownProperties: boolean, accessorPropertiesOnly: boolean, nonIndexedPropertiesOnly: boolean,
       generatePreview: boolean): Promise<GetPropertiesResult> {
-    if (!this.objectIdInternal) {
+    if (!this.#objectIdInternal) {
       return {properties: null, internalProperties: null} as GetPropertiesResult;
     }
 
-    const response = await this.runtimeAgent.invoke_getProperties({
-      objectId: this.objectIdInternal,
+    const response = await this.#runtimeAgent.invoke_getProperties({
+      objectId: this.#objectIdInternal,
       ownProperties,
       accessorPropertiesOnly,
       nonIndexedPropertiesOnly,
@@ -490,11 +494,11 @@ export class RemoteObjectImpl extends RemoteObject {
   }
 
   async setPropertyValue(name: string|Protocol.Runtime.CallArgument, value: string): Promise<string|undefined> {
-    if (!this.objectIdInternal) {
+    if (!this.#objectIdInternal) {
       return 'Can’t set a property of non-object.';
     }
 
-    const response = await this.runtimeAgent.invoke_evaluate({expression: value, silent: true});
+    const response = await this.#runtimeAgent.invoke_evaluate({expression: value, silent: true});
     if (response.getError() || response.exceptionDetails) {
       return response.getError() ||
           (response.result.type !== 'string' ? response.result.description : response.result.value as string);
@@ -507,7 +511,7 @@ export class RemoteObjectImpl extends RemoteObject {
     const resultPromise = this.doSetObjectPropertyValue(response.result, name);
 
     if (response.result.objectId) {
-      this.runtimeAgent.invoke_releaseObject({objectId: response.result.objectId});
+      this.#runtimeAgent.invoke_releaseObject({objectId: response.result.objectId});
     }
 
     return resultPromise;
@@ -522,8 +526,8 @@ export class RemoteObjectImpl extends RemoteObject {
     const setPropertyValueFunction = 'function(a, b) { this[a] = b; }';
 
     const argv = [name, RemoteObject.toCallArgument(result)];
-    const response = await this.runtimeAgent.invoke_callFunctionOn({
-      objectId: this.objectIdInternal,
+    const response = await this.#runtimeAgent.invoke_callFunctionOn({
+      objectId: this.#objectIdInternal,
       functionDeclaration: setPropertyValueFunction,
       arguments: argv,
       silent: true,
@@ -533,13 +537,13 @@ export class RemoteObjectImpl extends RemoteObject {
   }
 
   async deleteProperty(name: Protocol.Runtime.CallArgument): Promise<string|undefined> {
-    if (!this.objectIdInternal) {
+    if (!this.#objectIdInternal) {
       return 'Can’t delete a property of non-object.';
     }
 
     const deletePropertyFunction = 'function(a) { delete this[a]; return !(a in this); }';
-    const response = await this.runtimeAgent.invoke_callFunctionOn({
-      objectId: this.objectIdInternal,
+    const response = await this.#runtimeAgent.invoke_callFunctionOn({
+      objectId: this.#objectIdInternal,
       functionDeclaration: deletePropertyFunction,
       arguments: [name],
       silent: true,
@@ -559,8 +563,8 @@ export class RemoteObjectImpl extends RemoteObject {
   async callFunction<T>(
       functionDeclaration: (this: Object, ...arg1: unknown[]) => T,
       args?: Protocol.Runtime.CallArgument[]): Promise<CallFunctionResult> {
-    const response = await this.runtimeAgent.invoke_callFunctionOn({
-      objectId: this.objectIdInternal,
+    const response = await this.#runtimeAgent.invoke_callFunctionOn({
+      objectId: this.#objectIdInternal,
       functionDeclaration: functionDeclaration.toString(),
       arguments: args,
       silent: true,
@@ -578,8 +582,8 @@ export class RemoteObjectImpl extends RemoteObject {
   async callFunctionJSON<T>(
       functionDeclaration: (this: Object, ...arg1: unknown[]) => T,
       args: Protocol.Runtime.CallArgument[]|undefined): Promise<T> {
-    const response = await this.runtimeAgent.invoke_callFunctionOn({
-      objectId: this.objectIdInternal,
+    const response = await this.#runtimeAgent.invoke_callFunctionOn({
+      objectId: this.#objectIdInternal,
       functionDeclaration: functionDeclaration.toString(),
       arguments: args,
       silent: true,
@@ -590,10 +594,10 @@ export class RemoteObjectImpl extends RemoteObject {
   }
 
   release(): void {
-    if (!this.objectIdInternal) {
+    if (!this.#objectIdInternal) {
       return;
     }
-    this.runtimeAgent.invoke_releaseObject({objectId: this.objectIdInternal});
+    this.#runtimeAgent.invoke_releaseObject({objectId: this.#objectIdInternal});
   }
 
   arrayLength(): number {
@@ -613,13 +617,13 @@ export class RemoteObjectImpl extends RemoteObject {
   }
 
   isNode(): boolean {
-    return Boolean(this.objectIdInternal) && this.type === 'object' && this.subtype === 'node';
+    return Boolean(this.#objectIdInternal) && this.type === 'object' && this.subtype === 'node';
   }
 }
 
 export class ScopeRemoteObject extends RemoteObjectImpl {
-  private scopeRef: ScopeRef;
-  private savedScopeProperties: RemoteObjectProperty[]|undefined;
+  #scopeRef: ScopeRef;
+  #savedScopeProperties: RemoteObjectProperty[]|undefined;
 
   constructor(
       runtimeModel: RuntimeModel, objectId: Protocol.Runtime.RemoteObjectId|undefined, scopeRef: ScopeRef, type: string,
@@ -628,8 +632,8 @@ export class ScopeRemoteObject extends RemoteObjectImpl {
       subtype: string|undefined, value: any, unserializableValue?: string, description?: string,
       preview?: Protocol.Runtime.ObjectPreview) {
     super(runtimeModel, objectId, type, subtype, value, unserializableValue, description, preview);
-    this.scopeRef = scopeRef;
-    this.savedScopeProperties = undefined;
+    this.#scopeRef = scopeRef;
+    this.#savedScopeProperties = undefined;
   }
 
   async doGetProperties(ownProperties: boolean, accessorPropertiesOnly: boolean, _generatePreview: boolean):
@@ -638,19 +642,19 @@ export class ScopeRemoteObject extends RemoteObjectImpl {
       return {properties: [], internalProperties: []} as GetPropertiesResult;
     }
 
-    if (this.savedScopeProperties) {
+    if (this.#savedScopeProperties) {
       // No need to reload scope variables, as the remote object never
-      // changes its properties. If variable is updated, the properties
+      // changes its #properties. If variable is updated, the #properties
       // array is patched locally.
-      return {properties: this.savedScopeProperties.slice(), internalProperties: null};
+      return {properties: this.#savedScopeProperties.slice(), internalProperties: null};
     }
 
     const allProperties = await super.doGetProperties(
         ownProperties, accessorPropertiesOnly, false /* nonIndexedPropertiesOnly */, true /* generatePreview */);
-    if (this.scopeRef && Array.isArray(allProperties.properties)) {
-      this.savedScopeProperties = allProperties.properties.slice();
-      if (!this.scopeRef.callFrameId) {
-        for (const property of this.savedScopeProperties) {
+    if (this.#scopeRef && Array.isArray(allProperties.properties)) {
+      this.#savedScopeProperties = allProperties.properties.slice();
+      if (!this.#scopeRef.callFrameId) {
+        for (const property of this.#savedScopeProperties) {
           property.writable = false;
         }
       }
@@ -662,13 +666,13 @@ export class ScopeRemoteObject extends RemoteObjectImpl {
       Promise<string|undefined> {
     const name = (argumentName.value as string);
     const error = await this.debuggerModel().setVariableValue(
-        this.scopeRef.number, name, RemoteObject.toCallArgument(result),
-        (this.scopeRef.callFrameId as Protocol.Debugger.CallFrameId));
+        this.#scopeRef.number, name, RemoteObject.toCallArgument(result),
+        (this.#scopeRef.callFrameId as Protocol.Debugger.CallFrameId));
     if (error) {
       return error;
     }
-    if (this.savedScopeProperties) {
-      for (const property of this.savedScopeProperties) {
+    if (this.#savedScopeProperties) {
+      for (const property of this.#savedScopeProperties) {
         if (property.name === name) {
           property.value = this.runtimeModel().createRemoteObject(result);
         }
@@ -744,15 +748,15 @@ export class RemoteObjectProperty {
 // Below is a wrapper around a local object that implements the RemoteObject interface,
 // which can be used by the UI code (primarily ObjectPropertiesSection).
 // Note that only JSON-compliant objects are currently supported, as there's no provision
-// for traversing prototypes, extracting class names via constructor, handling properties
+// for traversing prototypes, extracting class names via constructor, handling #properties
 // or functions.
 
 export class LocalJSONObject extends RemoteObject {
   // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   valueInternal: any;
-  private cachedDescription!: string;
-  private cachedChildren!: RemoteObjectProperty[];
+  #cachedDescription!: string;
+  #cachedChildren!: RemoteObjectProperty[];
 
   // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -777,8 +781,8 @@ export class LocalJSONObject extends RemoteObject {
   }
 
   get description(): string {
-    if (this.cachedDescription) {
-      return this.cachedDescription;
+    if (this.#cachedDescription) {
+      return this.#cachedDescription;
     }
 
     function formatArrayItem(this: LocalJSONObject, property: RemoteObjectProperty): string {
@@ -796,22 +800,22 @@ export class LocalJSONObject extends RemoteObject {
     if (this.type === 'object') {
       switch (this.subtype) {
         case 'array':
-          this.cachedDescription = this.concatenate('[', ']', formatArrayItem.bind(this));
+          this.#cachedDescription = this.concatenate('[', ']', formatArrayItem.bind(this));
           break;
         case 'date':
-          this.cachedDescription = String(this.valueInternal);
+          this.#cachedDescription = String(this.valueInternal);
           break;
         case 'null':
-          this.cachedDescription = 'null';
+          this.#cachedDescription = 'null';
           break;
         default:
-          this.cachedDescription = this.concatenate('{', '}', formatObjectItem.bind(this));
+          this.#cachedDescription = this.concatenate('{', '}', formatObjectItem.bind(this));
       }
     } else {
-      this.cachedDescription = String(this.valueInternal);
+      this.#cachedDescription = String(this.valueInternal);
     }
 
-    return this.cachedDescription;
+    return this.#cachedDescription;
   }
 
   private formatValue(value: RemoteObject|null): string {
@@ -910,10 +914,10 @@ export class LocalJSONObject extends RemoteObject {
       }
       return new RemoteObjectProperty(propName, propValue);
     }
-    if (!this.cachedChildren) {
-      this.cachedChildren = Object.keys((value as Object)).map(buildProperty);
+    if (!this.#cachedChildren) {
+      this.#cachedChildren = Object.keys((value as Object)).map(buildProperty);
     }
-    return this.cachedChildren;
+    return this.#cachedChildren;
   }
 
   arrayLength(): number {
@@ -957,16 +961,16 @@ export class LocalJSONObject extends RemoteObject {
 }
 
 export class RemoteArrayBuffer {
-  private readonly objectInternal: RemoteObject;
+  readonly #objectInternal: RemoteObject;
   constructor(object: RemoteObject) {
     if (object.type !== 'object' || object.subtype !== 'arraybuffer') {
       throw new Error('Object is not an arraybuffer');
     }
-    this.objectInternal = object;
+    this.#objectInternal = object;
   }
 
   byteLength(): number {
-    return this.objectInternal.arrayBufferByteLength();
+    return this.#objectInternal.arrayBufferByteLength();
   }
 
   // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
@@ -980,7 +984,7 @@ export class RemoteArrayBuffer {
     }
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // @ts-expect-error
-    return await this.objectInternal.callFunctionJSON(bytes, [{value: start}, {value: end - start}]);
+    return await this.#objectInternal.callFunctionJSON(bytes, [{value: start}, {value: end - start}]);
 
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -990,14 +994,14 @@ export class RemoteArrayBuffer {
   }
 
   object(): RemoteObject {
-    return this.objectInternal;
+    return this.#objectInternal;
   }
 }
 
 export class RemoteArray {
-  private readonly objectInternal: RemoteObject;
+  readonly #objectInternal: RemoteObject;
   constructor(object: RemoteObject) {
-    this.objectInternal = object;
+    this.#objectInternal = object;
   }
 
   static objectAsArray(object: RemoteObject|null): RemoteArray {
@@ -1035,12 +1039,12 @@ export class RemoteArray {
   }
 
   at(index: number): Promise<RemoteObject> {
-    if (index < 0 || index > this.objectInternal.arrayLength()) {
+    if (index < 0 || index > this.#objectInternal.arrayLength()) {
       throw new Error('Out of range');
     }
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // @ts-expect-error
-    return this.objectInternal.callFunction(at, [RemoteObject.toCallArgument(index)]).then(assertCallFunctionResult);
+    return this.#objectInternal.callFunction(at, [RemoteObject.toCallArgument(index)]).then(assertCallFunctionResult);
 
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -1057,7 +1061,7 @@ export class RemoteArray {
   }
 
   length(): number {
-    return this.objectInternal.arrayLength();
+    return this.#objectInternal.arrayLength();
   }
 
   map<T>(func: (arg0: RemoteObject) => Promise<T>): Promise<T[]> {
@@ -1069,15 +1073,15 @@ export class RemoteArray {
   }
 
   object(): RemoteObject {
-    return this.objectInternal;
+    return this.#objectInternal;
   }
 }
 
 export class RemoteFunction {
-  private readonly objectInternal: RemoteObject;
+  readonly #objectInternal: RemoteObject;
 
   constructor(object: RemoteObject) {
-    this.objectInternal = object;
+    this.#objectInternal = object;
   }
 
   static objectAsFunction(object: RemoteObject|null): RemoteFunction {
@@ -1088,11 +1092,11 @@ export class RemoteFunction {
   }
 
   targetFunction(): Promise<RemoteObject> {
-    return this.objectInternal.getOwnProperties(false /* generatePreview */).then(targetFunction.bind(this));
+    return this.#objectInternal.getOwnProperties(false /* generatePreview */).then(targetFunction.bind(this));
 
     function targetFunction(this: RemoteFunction, ownProperties: GetPropertiesResult): RemoteObject {
       if (!ownProperties.internalProperties) {
-        return this.objectInternal;
+        return this.#objectInternal;
       }
       const internalProperties = ownProperties.internalProperties;
       for (const property of internalProperties) {
@@ -1100,7 +1104,7 @@ export class RemoteFunction {
           return property.value as RemoteObject;
         }
       }
-      return this.objectInternal;
+      return this.#objectInternal;
     }
   }
 
@@ -1109,7 +1113,7 @@ export class RemoteFunction {
 
     function functionDetails(this: RemoteFunction, targetFunction: RemoteObject): Promise<FunctionDetails|null> {
       const boundReleaseFunctionDetails =
-          releaseTargetFunction.bind(null, this.objectInternal !== targetFunction ? targetFunction : null);
+          releaseTargetFunction.bind(null, this.#objectInternal !== targetFunction ? targetFunction : null);
       return targetFunction.debuggerModel().functionDetailsPromise(targetFunction).then(boundReleaseFunctionDetails);
     }
 
@@ -1123,7 +1127,7 @@ export class RemoteFunction {
   }
 
   object(): RemoteObject {
-    return this.objectInternal;
+    return this.#objectInternal;
   }
 }