chrome-devtools-frontend 1.0.1739869 → 1.0.1742811

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (272) hide show
  1. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  2. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +44 -7
  3. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +1 -1
  6. package/.agents/skills/code-review/SKILL.md +23 -6
  7. package/.agents/skills/devtools-verification/SKILL.md +2 -1
  8. package/.agents/skills/migrate-chromium-test/SKILL.md +1 -0
  9. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +27 -11
  10. package/.agents/skills/ui-eng-vision-orchestrator/SKILL.md +41 -23
  11. package/.agents/skills/ui-eng-vision-test-scaffolder/SKILL.md +12 -7
  12. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +3 -0
  13. package/.agents/skills/ui-widgets/SKILL.md +22 -7
  14. package/.agents/skills/version-control/SKILL.md +10 -1
  15. package/.agents/skills/visual-regression-audit/SKILL.md +88 -0
  16. package/.gitallowed +2 -1
  17. package/.stylelintignore +1 -0
  18. package/.stylelintrc.json +2 -0
  19. package/AUTHORS +1 -0
  20. package/DIR_METADATA +2 -1
  21. package/PRESUBMIT_test.py +143 -0
  22. package/config/owner/INFRA_OWNERS +0 -1
  23. package/docs/contributing/infrastructure.md +2 -2
  24. package/docs/ui_engineering.md +14 -4
  25. package/eslint.config.mjs +1 -18
  26. package/front_end/application_tokens.css +0 -35
  27. package/front_end/core/host/AidaClient.ts +1 -1
  28. package/front_end/core/host/AidaClientTypes.ts +2 -0
  29. package/front_end/core/host/AidaErrors.ts +3 -3
  30. package/front_end/core/host/AidaGcaTranslation.ts +39 -0
  31. package/front_end/core/host/GcaClient.ts +32 -20
  32. package/front_end/core/host/GcaTypes.ts +4 -2
  33. package/front_end/core/host/InspectorFrontendHostAPI.ts +2 -0
  34. package/front_end/core/i18n/DevToolsLocale.ts +0 -1
  35. package/front_end/core/sdk/DebuggerModel.ts +25 -13
  36. package/front_end/core/sdk/PreloadingModel.ts +2 -2
  37. package/front_end/core/sdk/RehydratingConnection.ts +59 -30
  38. package/front_end/core/sdk/StorageKeyManager.ts +0 -1
  39. package/front_end/core/sdk/Target.ts +6 -0
  40. package/front_end/core/sdk/TargetManager.ts +10 -4
  41. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts +12 -2
  42. package/front_end/entrypoints/inspector_main/OutermostTargetSelector.ts +159 -52
  43. package/front_end/entrypoints/inspector_main/outermostTargetSelector.css +77 -25
  44. package/front_end/entrypoints/main/MainImpl.ts +32 -15
  45. package/front_end/models/ai_assistance/AiAgent2.ts +95 -46
  46. package/front_end/models/ai_assistance/AiConversation.ts +1 -1
  47. package/front_end/models/ai_assistance/agents/AiAgent.ts +9 -2
  48. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +3 -2
  49. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +1 -1
  50. package/front_end/models/ai_assistance/data_formatters/FileFormatter.ts +1 -1
  51. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts +5 -4
  52. package/front_end/models/ai_assistance/performance/AICallTree.ts +7 -9
  53. package/front_end/models/ai_assistance/performance/AIQueries.ts +4 -8
  54. package/front_end/models/ai_assistance/skills/SkillRegistry.ts +11 -1
  55. package/front_end/models/ai_assistance/skills/lighthouse.md +1 -0
  56. package/front_end/models/ai_assistance/skills/network.md +3 -4
  57. package/front_end/models/ai_assistance/skills/sources.md +1 -2
  58. package/front_end/models/ai_assistance/skills/styling.md +3 -4
  59. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +11 -3
  60. package/front_end/models/ai_assistance/tools/ListNetworkRequests.ts +84 -23
  61. package/front_end/models/ai_assistance/tools/ListSources.ts +41 -13
  62. package/front_end/models/badges/Badge.ts +0 -1
  63. package/front_end/models/bindings/ResourceMapping.ts +1 -1
  64. package/front_end/models/bindings/ResourceScriptMapping.ts +1 -1
  65. package/front_end/models/breakpoints/BreakpointManager.ts +2 -4
  66. package/front_end/models/breakpoints/RecurringPauseDetector.ts +140 -0
  67. package/front_end/models/breakpoints/breakpoints.ts +2 -1
  68. package/front_end/models/heap_snapshot/HeapSnapshotModel.ts +2 -2
  69. package/front_end/models/persistence/Automapping.ts +0 -1
  70. package/front_end/models/trace/Processor.ts +16 -7
  71. package/front_end/models/trace/README.md +17 -1
  72. package/front_end/models/trace/extras/ThirdParties.ts +4 -6
  73. package/front_end/models/trace/extras/TraceTree.ts +69 -72
  74. package/front_end/models/trace/handlers/MetaHandler.ts +3 -0
  75. package/front_end/models/trace/handlers/types.ts +15 -0
  76. package/front_end/models/trace/helpers/Trace.ts +5 -3
  77. package/front_end/models/trace/lantern/simulation/Simulator.ts +4 -1
  78. package/front_end/models/web_mcp/WebMCPModel.ts +19 -9
  79. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +30 -3
  80. package/front_end/panels/ai_assistance/components/ChatMessage.ts +2 -4
  81. package/front_end/panels/ai_assistance/components/chatMessage.css +1 -22
  82. package/front_end/panels/ai_assistance/components/exploreWidget.css +1 -19
  83. package/front_end/panels/ai_assistance/components/optInChangeDialog.css +1 -1
  84. package/front_end/panels/ai_assistance/components/walkthroughView.css +0 -13
  85. package/front_end/panels/animation/AnimationGroupPreviewUI.ts +3 -2
  86. package/front_end/panels/animation/AnimationTimeline.ts +5 -3
  87. package/front_end/panels/animation/animationTimeline.css +10 -8
  88. package/front_end/panels/application/ApplicationPanelSidebar.ts +14 -11
  89. package/front_end/panels/application/ReportingApiView.ts +0 -1
  90. package/front_end/panels/application/SubAppsView.ts +0 -1
  91. package/front_end/panels/application/WebMCPTreeElement.ts +3 -6
  92. package/front_end/panels/application/WebMCPView.ts +30 -0
  93. package/front_end/panels/application/components/ReportsGrid.ts +0 -1
  94. package/front_end/panels/application/components/backForwardCacheView.css +0 -7
  95. package/front_end/panels/application/components/permissionsPolicySection.css +2 -2
  96. package/front_end/panels/application/components/protocolHandlersView.css +46 -39
  97. package/front_end/panels/application/components/trustTokensView.css +0 -4
  98. package/front_end/panels/application/cookieItemsView.css +0 -7
  99. package/front_end/panels/application/indexedDBViews.css +0 -6
  100. package/front_end/panels/application/preloading/components/PreloadingDetailsReportView.ts +0 -2
  101. package/front_end/panels/application/preloading/components/PreloadingString.ts +0 -1
  102. package/front_end/panels/application/preloading/components/UsedPreloadingView.ts +4 -5
  103. package/front_end/panels/application/preloading/components/preloadingGrid.css +0 -9
  104. package/front_end/panels/application/serviceWorkerUpdateCycleView.css +2 -9
  105. package/front_end/panels/application/serviceWorkersView.css +5 -4
  106. package/front_end/panels/application/storageView.css +0 -5
  107. package/front_end/panels/application/webMCPView.css +17 -0
  108. package/front_end/panels/browser_debugger/ObjectEventListenersSidebarPane.ts +15 -20
  109. package/front_end/panels/changes/changesView.css +0 -5
  110. package/front_end/panels/common/ExtensionServer.ts +80 -10
  111. package/front_end/panels/console/ConsolePanel.ts +92 -18
  112. package/front_end/panels/console/consoleContextSelector.css +1 -8
  113. package/front_end/panels/console/consoleInsightTeaser.css +10 -17
  114. package/front_end/panels/console/consolePinPane.css +3 -1
  115. package/front_end/panels/console/consoleView.css +13 -17
  116. package/front_end/panels/coverage/coverageListView.css +0 -4
  117. package/front_end/panels/css_overview/cssOverviewCompletedView.css +0 -22
  118. package/front_end/panels/css_overview/cssOverviewStartView.css +0 -43
  119. package/front_end/panels/developer_resources/developerResourcesListView.css +0 -4
  120. package/front_end/panels/elements/ColorSwatchPopoverIcon.ts +52 -45
  121. package/front_end/panels/elements/LayoutPane.ts +1 -3
  122. package/front_end/panels/elements/PropertiesWidget.ts +26 -8
  123. package/front_end/panels/elements/PropertyRenderer.ts +45 -21
  124. package/front_end/panels/elements/StandaloneStylesContainer.ts +6 -7
  125. package/front_end/panels/elements/StyleEditorWidget.ts +110 -63
  126. package/front_end/panels/elements/StylePropertiesSection.ts +14 -5
  127. package/front_end/panels/elements/StylePropertyTreeElement.ts +529 -518
  128. package/front_end/panels/elements/StylesContainer.ts +5 -6
  129. package/front_end/panels/elements/StylesSidebarPane.ts +12 -15
  130. package/front_end/panels/elements/components/CSSVariableValueView.ts +17 -4
  131. package/front_end/panels/elements/components/StylePropertyEditor.ts +178 -140
  132. package/front_end/panels/elements/components/cssQuery.css +1 -1
  133. package/front_end/panels/elements/components/stylePropertyEditor.css +60 -56
  134. package/front_end/panels/elements/layoutPane.css +2 -2
  135. package/front_end/panels/elements/metricsSidebarPane.css +6 -7
  136. package/front_end/panels/elements/platformFontsWidget.css +1 -1
  137. package/front_end/panels/elements/stylePropertiesTreeOutline.css +1 -6
  138. package/front_end/panels/elements/stylesSidebarPane.css +3 -4
  139. package/front_end/panels/emulation/deviceModeView.css +1 -1
  140. package/front_end/panels/event_listeners/EventListenersView.ts +9 -2
  141. package/front_end/panels/event_listeners/eventListenersView.css +1 -1
  142. package/front_end/panels/explain/components/consoleInsight.css +1 -2
  143. package/front_end/panels/issues/issuesTree.css +6 -43
  144. package/front_end/panels/layer_viewer/PaintProfilerView.ts +1 -1
  145. package/front_end/panels/layer_viewer/paintProfiler.css +4 -3
  146. package/front_end/panels/lighthouse/LighthouseReportSelector.ts +1 -6
  147. package/front_end/panels/lighthouse/lighthouseStartView.css +5 -16
  148. package/front_end/panels/linear_memory_inspector/components/LinearMemoryValueInterpreter.ts +0 -1
  149. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  150. package/front_end/panels/linear_memory_inspector/components/linearMemoryViewer.css +2 -2
  151. package/front_end/panels/linear_memory_inspector/components/valueInterpreterSettings.css +1 -1
  152. package/front_end/panels/media/playerListView.css +1 -2
  153. package/front_end/panels/media/playerPropertiesView.css +1 -1
  154. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +2 -2
  155. package/front_end/panels/network/NetworkLogView.ts +594 -580
  156. package/front_end/panels/network/RequestCookiesView.ts +0 -1
  157. package/front_end/panels/network/networkConfigView.css +1 -2
  158. package/front_end/panels/network/networkLogView.css +363 -364
  159. package/front_end/panels/network/networkPanel.css +1 -5
  160. package/front_end/panels/network/networkTimingTable.css +1 -1
  161. package/front_end/panels/network/networkWaterfallColumn.css +1 -1
  162. package/front_end/panels/network/requestConditionsDrawer.css +0 -4
  163. package/front_end/panels/network/requestCookiesView.css +7 -1
  164. package/front_end/panels/network/requestPayloadTree.css +0 -4
  165. package/front_end/panels/profiler/HeapProfileView.ts +1 -3
  166. package/front_end/panels/profiler/HeapSnapshotView.ts +0 -7
  167. package/front_end/panels/recorder/RecorderPanel.ts +1 -1
  168. package/front_end/panels/recorder/RecordingView.ts +10 -10
  169. package/front_end/panels/recorder/StepView.ts +5 -4
  170. package/front_end/panels/recorder/createRecordingView.css +1 -1
  171. package/front_end/panels/recorder/recorderPanel.css +0 -8
  172. package/front_end/panels/recorder/recordingListView.css +4 -4
  173. package/front_end/panels/recorder/recordingView.css +12 -20
  174. package/front_end/panels/recorder/stepEditor.css +4 -4
  175. package/front_end/panels/recorder/stepView.css +31 -9
  176. package/front_end/panels/recorder/timelineSection.css +4 -0
  177. package/front_end/panels/screencast/ScreencastApp.ts +0 -1
  178. package/front_end/panels/security/mainView.css +1 -1
  179. package/front_end/panels/security/originView.css +2 -2
  180. package/front_end/panels/sensors/SensorsView.ts +273 -346
  181. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +0 -1
  182. package/front_end/panels/settings/backendLinkingSettingsTab.css +7 -7
  183. package/front_end/panels/settings/components/syncSection.css +0 -1
  184. package/front_end/panels/settings/workspaceSettingsTab.css +0 -5
  185. package/front_end/panels/sources/CSSPlugin.ts +177 -98
  186. package/front_end/panels/sources/DebuggerPausedMessage.ts +100 -27
  187. package/front_end/panels/sources/NavigatorView.ts +926 -946
  188. package/front_end/panels/sources/SourcesPanel.ts +9 -2
  189. package/front_end/panels/sources/breakpointsView.css +6 -29
  190. package/front_end/panels/sources/components/HeadersView.css +2 -2
  191. package/front_end/panels/sources/debuggerPausedMessage.css +7 -0
  192. package/front_end/panels/sources/navigatorTree.css +7 -2
  193. package/front_end/panels/sources/sourcesNavigator.css +0 -9
  194. package/front_end/panels/sources/watchExpressionsSidebarPane.css +0 -10
  195. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +3 -0
  196. package/front_end/panels/timeline/LayoutShiftsTrackAppender.ts +0 -10
  197. package/front_end/panels/timeline/ModificationsManager.ts +0 -1
  198. package/front_end/panels/timeline/ThreadAppender.ts +2 -6
  199. package/front_end/panels/timeline/TimelinePanel.ts +2 -2
  200. package/front_end/panels/timeline/TimelineTreeView.ts +38 -41
  201. package/front_end/panels/timeline/TimelineUIUtils.ts +8 -10
  202. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +0 -2
  203. package/front_end/panels/timeline/components/fieldSettingsDialog.css +1 -6
  204. package/front_end/panels/timeline/components/insights/baseInsightComponent.css +0 -12
  205. package/front_end/panels/timeline/components/interactionBreakdown.css +1 -2
  206. package/front_end/panels/timeline/components/layoutShiftDetails.css +2 -9
  207. package/front_end/panels/timeline/components/liveMetricsView.css +0 -16
  208. package/front_end/panels/timeline/components/metricCard.css +1 -5
  209. package/front_end/panels/timeline/components/networkRequestDetails.css +3 -4
  210. package/front_end/panels/timeline/components/networkRequestTooltip.css +6 -4
  211. package/front_end/panels/timeline/components/sidebarAnnotationsTab.css +1 -1
  212. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -2
  213. package/front_end/panels/timeline/timelineDetailsView.css +1 -12
  214. package/front_end/panels/timeline/timelineFlamechartPopover.css +0 -4
  215. package/front_end/panels/timeline/timelineMiniMap.css +1 -4
  216. package/front_end/panels/timeline/timelinePanel.css +0 -4
  217. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  218. package/front_end/panels/timeline/timelineTreeView.css +0 -12
  219. package/front_end/panels/timeline/utils/EntryNodes.ts +1 -1
  220. package/front_end/panels/webauthn/webauthnPane.css +1 -7
  221. package/front_end/panels/whats_new/ReleaseNoteText.ts +1 -1
  222. package/front_end/third_party/chromium/README.chromium +1 -1
  223. package/front_end/ui/components/adorners/adorner.css +1 -1
  224. package/front_end/ui/components/buttons/button.css +0 -28
  225. package/front_end/ui/components/buttons/textButton.css +1 -45
  226. package/front_end/ui/components/input/checkbox.css +3 -3
  227. package/front_end/ui/components/issue_counter/issueLinkIcon.css +2 -2
  228. package/front_end/ui/components/menus/Menu.ts +14 -0
  229. package/front_end/ui/components/menus/menu.css +2 -14
  230. package/front_end/ui/components/menus/menuItem.css +0 -4
  231. package/front_end/ui/components/request_link_icon/requestLinkIcon.css +2 -2
  232. package/front_end/ui/components/survey_link/SurveyLink.ts +1 -1
  233. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  234. package/front_end/ui/components/switch/switch.css +3 -2
  235. package/front_end/ui/components/text_editor/theme.ts +1 -1
  236. package/front_end/ui/components/tooltips/Tooltip.ts +3 -3
  237. package/front_end/ui/components/tree_outline/treeOutline.css +0 -23
  238. package/front_end/ui/legacy/ContextMenu.ts +5 -5
  239. package/front_end/ui/legacy/SoftContextMenu.ts +24 -8
  240. package/front_end/ui/legacy/Toolbar.ts +1 -1
  241. package/front_end/ui/legacy/Treeoutline.ts +31 -78
  242. package/front_end/ui/legacy/UIUtils.ts +9 -17
  243. package/front_end/ui/legacy/checkboxTextLabel.css +2 -44
  244. package/front_end/ui/legacy/components/color_picker/Spectrum.ts +39 -27
  245. package/front_end/ui/legacy/components/color_picker/spectrum.css +2 -10
  246. package/front_end/ui/legacy/components/data_grid/dataGrid.css +2 -6
  247. package/front_end/ui/legacy/components/inline_editor/BezierEditor.ts +34 -26
  248. package/front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.ts +1 -0
  249. package/front_end/ui/legacy/components/inline_editor/cssShadowEditor.css +1 -1
  250. package/front_end/ui/legacy/components/inline_editor/swatchPopover.css +1 -1
  251. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +49 -1
  252. package/front_end/ui/legacy/components/object_ui/objectPopover.css +0 -4
  253. package/front_end/ui/legacy/components/perf_ui/chartViewport.css +1 -9
  254. package/front_end/ui/legacy/components/perf_ui/filmStripView.css +1 -1
  255. package/front_end/ui/legacy/components/perf_ui/overviewGrid.css +2 -1
  256. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +0 -5
  257. package/front_end/ui/legacy/components/settings_ui/SettingsUI.ts +6 -3
  258. package/front_end/ui/legacy/components/source_frame/JSONView.ts +95 -1
  259. package/front_end/ui/legacy/filter.css +1 -1
  260. package/front_end/ui/legacy/inspectorCommon.css +6 -28
  261. package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +1 -1
  262. package/front_end/ui/legacy/listWidget.css +1 -1
  263. package/front_end/ui/legacy/progressIndicator.css +1 -1
  264. package/front_end/ui/legacy/tabbedPane.css +6 -2
  265. package/front_end/ui/visual_logging/KnownContextValues.ts +1 -0
  266. package/front_end/ui/visual_logging/LoggingDriver.ts +4 -0
  267. package/front_end/ui/visual_logging/visual_logging.ts +1 -1
  268. package/inspector_overlay/common.ts +0 -3
  269. package/inspector_overlay/main.ts +1 -3
  270. package/inspector_overlay/tool_source_order.css +0 -4
  271. package/package.json +1 -1
  272. package/front_end/generated/SupportedCSSProperties.ts +0 -9705
@@ -1,7 +1,6 @@
1
1
  // Copyright 2015 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  import * as SDK from '../../core/sdk/sdk.js';
7
6
  import * as Buttons from '../../ui/components/buttons/buttons.js';
@@ -10,28 +9,23 @@ import * as Lit from '../../ui/lit/lit.js';
10
9
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
11
10
  import * as EventListeners from '../event_listeners/event_listeners.js';
12
11
 
12
+ const {bindToAction} = UI.UIUtils;
13
13
  const {html} = Lit;
14
14
 
15
- export class ObjectEventListenersSidebarPane extends UI.Widget.VBox implements UI.Toolbar.ItemsProvider {
15
+ export class ObjectEventListenersSidebarPane extends EventListeners.EventListenersView.EventListenersView implements
16
+ UI.Toolbar.ItemsProvider {
17
+ protected override readonly jslog: string = `${VisualLogging.section('sources.global-listeners')}`;
16
18
  #lastRequestedContext?: SDK.RuntimeModel.ExecutionContext;
17
19
 
18
- // TODO(bmeurer): This is only public for web tests.
19
- readonly eventListenersView: EventListeners.EventListenersView.EventListenersView;
20
-
21
- constructor() {
22
- super();
23
- this.contentElement.setAttribute('jslog', `${VisualLogging.section('sources.global-listeners')}`);
24
-
25
- this.eventListenersView = new EventListeners.EventListenersView.EventListenersView();
26
- this.eventListenersView.show(this.element);
27
- this.setDefaultFocusedChild(this.eventListenersView);
28
- this.requestUpdate();
29
- }
30
-
31
20
  toolbarItems(): Lit.TemplateResult {
32
- const refreshButton = UI.Toolbar.Toolbar.createActionButton('browser-debugger.refresh-global-event-listeners');
33
- refreshButton.setSize(Buttons.Button.Size.SMALL);
34
- return html`${refreshButton.element}`;
21
+ // clang-format off
22
+ return html`
23
+ <devtools-button
24
+ ${bindToAction('browser-debugger.refresh-global-event-listeners')}
25
+ .size=${Buttons.Button.Size.SMALL}
26
+ ></devtools-button>
27
+ `;
28
+ // clang-format on
35
29
  }
36
30
 
37
31
  override async performUpdate(): Promise<void> {
@@ -58,14 +52,15 @@ export class ObjectEventListenersSidebarPane extends UI.Widget.VBox implements U
58
52
  windowObjects.push(result.object);
59
53
  }
60
54
  }
61
- this.eventListenersView.objects = windowObjects;
62
- await this.eventListenersView.updateComplete;
55
+ this.setObjects(windowObjects);
56
+ await super.performUpdate();
63
57
  }
64
58
 
65
59
  override wasShown(): void {
66
60
  super.wasShown();
67
61
  UI.Context.Context.instance().addFlavorChangeListener(SDK.RuntimeModel.ExecutionContext, this.requestUpdate, this);
68
62
  UI.Context.Context.instance().setFlavor(ObjectEventListenersSidebarPane, this);
63
+ this.requestUpdate();
69
64
  }
70
65
 
71
66
  override willHide(): void {
@@ -32,11 +32,6 @@
32
32
  color: var(--sys-color-on-tonal-container);
33
33
  }
34
34
 
35
- .changes-toolbar {
36
- background-color: var(--sys-color-cdt-base-container);
37
- border-top: var(--sys-size-1) solid var(--sys-color-divider);
38
- }
39
-
40
35
  [hidden] {
41
36
  display: none !important; /* stylelint-disable-line declaration-no-important */
42
37
  }
@@ -4,7 +4,6 @@
4
4
 
5
5
  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
6
6
  /* eslint-disable @typescript-eslint/naming-convention */
7
- /* eslint-disable @devtools/no-imperative-dom-api */
8
7
 
9
8
  import type {Chrome} from '../../../extension-api/ExtensionAPI.js';
10
9
  import * as Common from '../../core/common/common.js';
@@ -24,9 +23,12 @@ import * as Workspace from '../../models/workspace/workspace.js';
24
23
  import * as Components from '../../ui/legacy/components/utils/utils.js';
25
24
  import * as UI from '../../ui/legacy/legacy.js';
26
25
  import * as ThemeSupport from '../../ui/legacy/theme_support/theme_support.js';
26
+ import {Directives, html, render} from '../../ui/lit/lit.js';
27
27
 
28
28
  import {ExtensionButton, ExtensionPanel, ExtensionSidebarPane} from './ExtensionPanel.js';
29
29
 
30
+ const {ifDefined, repeat} = Directives;
31
+
30
32
  const extensionOrigins = new WeakMap<MessagePort, Platform.DevToolsPath.UrlString>();
31
33
 
32
34
  declare global {
@@ -138,6 +140,64 @@ export class RevealableNetworkRequestFilter {
138
140
  }
139
141
  }
140
142
 
143
+ export interface ExtensionFrameDescriptor {
144
+ key: number;
145
+ startPage: string;
146
+ name?: string;
147
+ }
148
+
149
+ export interface ViewInput {
150
+ frames: readonly ExtensionFrameDescriptor[];
151
+ }
152
+
153
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
154
+
155
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
156
+ // clang-format off
157
+ render(html`
158
+ ${repeat(input.frames, frame => frame.key, frame => html`
159
+ <iframe
160
+ src=${frame.startPage}
161
+ data-devtools-extension=${ifDefined(frame.name)}
162
+ style="display: none;"></iframe>
163
+ `)}
164
+ `, target, {container: {attributes: {style: 'display: contents'}}});
165
+ // clang-format on
166
+ };
167
+
168
+ export class ExtensionFramesWidget extends UI.Widget.Widget {
169
+ readonly #view: View;
170
+ readonly #frames: ExtensionFrameDescriptor[] = [];
171
+ #nextKey = 0;
172
+
173
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
174
+ super(element);
175
+ this.#view = view;
176
+ }
177
+
178
+ addFrame({startPage, name}: Host.InspectorFrontendHostAPI.ExtensionDescriptor): void {
179
+ this.#frames.push({key: this.#nextKey++, startPage, name});
180
+ this.requestUpdate();
181
+ }
182
+
183
+ clear(): void {
184
+ this.#frames.length = 0;
185
+ this.#nextKey = 0;
186
+ this.requestUpdate();
187
+ }
188
+
189
+ override wasShown(): void {
190
+ super.wasShown();
191
+ if (this.#frames.length > 0) {
192
+ this.requestUpdate();
193
+ }
194
+ }
195
+
196
+ override performUpdate(): void {
197
+ this.#view({frames: [...this.#frames]}, undefined, this.contentElement);
198
+ }
199
+ }
200
+
141
201
  export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
142
202
  private readonly clientObjects: Map<string, unknown>;
143
203
  private readonly handlers:
@@ -162,9 +222,11 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
162
222
  // Origin of the extension that currently owns the extension-set user agent
163
223
  // override in MultitargetNetworkManager, if any.
164
224
  private userAgentOverrideOwner: Platform.DevToolsPath.UrlString|null = null;
225
+ readonly #framesWidget: ExtensionFramesWidget;
165
226
 
166
- private constructor() {
227
+ private constructor(framesWidget: ExtensionFramesWidget = new ExtensionFramesWidget()) {
167
228
  super();
229
+ this.#framesWidget = framesWidget;
168
230
  this.clientObjects = new Map();
169
231
  this.handlers = new Map();
170
232
  this.subscribers = new Map();
@@ -260,7 +322,14 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
260
322
  return this.extensionsEnabled;
261
323
  }
262
324
 
325
+ framesWidget(): ExtensionFramesWidget {
326
+ return this.#framesWidget;
327
+ }
328
+
263
329
  dispose(): void {
330
+ this.#framesWidget.clear();
331
+ this.#framesWidget.detach();
332
+
264
333
  ThemeSupport.ThemeSupport.instance().removeEventListener(
265
334
  ThemeSupport.ThemeChangeEvent.eventName, this.#onThemeChange);
266
335
 
@@ -289,11 +358,12 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
289
358
 
290
359
  static instance(opts: {
291
360
  forceNew: boolean|null,
361
+ framesWidget?: ExtensionFramesWidget,
292
362
  } = {forceNew: null}): ExtensionServer {
293
- const {forceNew} = opts;
363
+ const {forceNew, framesWidget} = opts;
294
364
  if (!extensionServerInstance || forceNew) {
295
365
  extensionServerInstance?.dispose();
296
- extensionServerInstance = new ExtensionServer();
366
+ extensionServerInstance = new ExtensionServer(framesWidget);
297
367
  }
298
368
 
299
369
  return extensionServerInstance;
@@ -1625,12 +1695,12 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
1625
1695
  }
1626
1696
  }
1627
1697
 
1628
- addExtensionFrame({startPage, name}: Host.InspectorFrontendHostAPI.ExtensionDescriptor): void {
1629
- const iframe = document.createElement('iframe');
1630
- iframe.src = startPage;
1631
- iframe.dataset.devtoolsExtension = name;
1632
- iframe.style.display = 'none';
1633
- document.body.appendChild(iframe); // Only for main window.
1698
+ addExtensionFrame(extensionInfo: Host.InspectorFrontendHostAPI.ExtensionDescriptor): void {
1699
+ if (!this.#framesWidget.isShowing()) {
1700
+ this.#framesWidget.markAsRoot();
1701
+ this.#framesWidget.show(document.body); // Only for main window.
1702
+ }
1703
+ this.#framesWidget.addFrame(extensionInfo);
1634
1704
  }
1635
1705
 
1636
1706
  addExtension(extensionInfo: Host.InspectorFrontendHostAPI.ExtensionDescriptor): boolean|undefined {
@@ -1,7 +1,6 @@
1
1
  // Copyright 2020 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  /*
7
6
  * Copyright (C) 2009 Joseph Pecoraro
@@ -33,33 +32,73 @@
33
32
 
34
33
  import type * as Common from '../../core/common/common.js';
35
34
  import * as UI from '../../ui/legacy/legacy.js';
35
+ import {html, render} from '../../ui/lit/lit.js';
36
36
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
37
37
 
38
38
  import {ConsoleView} from './ConsoleView.js';
39
39
 
40
- let consolePanelInstance: ConsolePanel;
40
+ const {widget} = UI.Widget;
41
+
42
+ export interface ViewInput {
43
+ showConsoleView: boolean;
44
+ }
45
+
46
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
47
+
48
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
49
+ // clang-format off
50
+ render(html`
51
+ ${widget(UI.Widget.WrapperWidget, {
52
+ widget: input.showConsoleView ? ConsoleView.instance() : null,
53
+ })}
54
+ `, target, {
55
+ container: {
56
+ attributes: {
57
+ jslog: `${VisualLogging.panel('console').track({resize: true})}`,
58
+ },
59
+ },
60
+ });
61
+ // clang-format on
62
+ };
63
+
64
+ let consolePanelInstance: ConsolePanel|null = null;
41
65
 
42
66
  export class ConsolePanel extends UI.Panel.Panel {
43
- private readonly view: ConsoleView;
67
+ readonly #view: View;
44
68
  #drawerWasMinimized = false;
45
- constructor() {
69
+ #ownsConsoleView = false;
70
+
71
+ constructor(view: View = DEFAULT_VIEW) {
46
72
  super('console');
47
- this.view = ConsoleView.instance();
73
+ this.#view = view;
74
+ }
75
+
76
+ override performUpdate(): void {
77
+ this.#view(
78
+ {showConsoleView: this.#ownsConsoleView},
79
+ undefined,
80
+ this.contentElement,
81
+ );
48
82
  }
49
83
 
50
84
  static instance(opts: {
51
85
  forceNew: boolean|null,
86
+ view?: View,
52
87
  } = {forceNew: null}): ConsolePanel {
53
- const {forceNew} = opts;
88
+ const {forceNew, view} = opts;
54
89
  if (!consolePanelInstance || forceNew) {
55
- consolePanelInstance = new ConsolePanel();
90
+ consolePanelInstance = new ConsolePanel(view);
56
91
  }
57
92
 
58
93
  return consolePanelInstance;
59
94
  }
60
95
 
96
+ static removeInstance(): void {
97
+ consolePanelInstance = null;
98
+ }
99
+
61
100
  static updateContextFlavor(): void {
62
- const consoleView = ConsolePanel.instance().view;
101
+ const consoleView = ConsoleView.instance();
63
102
  UI.Context.Context.instance().setFlavor(ConsoleView, consoleView.isShowing() ? consoleView : null);
64
103
  }
65
104
 
@@ -68,15 +107,21 @@ export class ConsolePanel extends UI.Panel.Panel {
68
107
  const inspectorView = UI.InspectorView.InspectorView.instance();
69
108
  this.#drawerWasMinimized = inspectorView.isDrawerMinimized();
70
109
  const wrapper = wrapperViewInstance;
110
+ // Always take the view away from the wrapper, even when the drawer is
111
+ // minimized or hidden, so that only one of them owns the ConsoleView.
112
+ wrapper?.hideViewInWrapper();
71
113
  if (wrapper?.isShowing()) {
72
114
  inspectorView.setDrawerMinimized(true);
73
115
  }
74
- this.view.show(this.element);
116
+ this.#ownsConsoleView = true;
117
+ this.performUpdate();
75
118
  ConsolePanel.updateContextFlavor();
76
119
  }
77
120
 
78
121
  override willHide(): void {
79
122
  super.willHide();
123
+ this.#ownsConsoleView = false;
124
+ this.performUpdate();
80
125
  const inspectorView = UI.InspectorView.InspectorView.instance();
81
126
  // The minimized drawer has 0 height, and showing Console inside may set
82
127
  // Console's scrollTop to 0. Unminimize before calling show to avoid this.
@@ -99,25 +144,45 @@ export class ConsolePanel extends UI.Panel.Panel {
99
144
  let wrapperViewInstance: WrapperView|null = null;
100
145
 
101
146
  export class WrapperView extends UI.Widget.VBox {
102
- private readonly view: ConsoleView;
147
+ readonly #view: View;
148
+ #ownsConsoleView = false;
103
149
 
104
- private constructor() {
105
- super({jslog: `${VisualLogging.panel('console').track({resize: true})}`});
106
- this.view = ConsoleView.instance();
150
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
151
+ super(element);
152
+ this.#view = view;
107
153
  }
108
154
 
109
- static instance(): WrapperView {
110
- if (!wrapperViewInstance) {
111
- wrapperViewInstance = new WrapperView();
155
+ override performUpdate(): void {
156
+ this.#view(
157
+ {showConsoleView: this.#ownsConsoleView},
158
+ undefined,
159
+ this.contentElement,
160
+ );
161
+ }
162
+
163
+ static instance(opts: {
164
+ forceNew: boolean|null,
165
+ view?: View,
166
+ } = {forceNew: null}): WrapperView {
167
+ const {forceNew, view} = opts;
168
+ if (!wrapperViewInstance || forceNew) {
169
+ wrapperViewInstance = new WrapperView(undefined, view);
112
170
  }
113
171
  return wrapperViewInstance;
114
172
  }
115
173
 
174
+ static removeInstance(): void {
175
+ wrapperViewInstance = null;
176
+ }
177
+
116
178
  override wasShown(): void {
117
179
  super.wasShown();
118
180
  if (!ConsolePanel.instance().isShowing()) {
119
181
  this.showViewInWrapper();
120
182
  } else {
183
+ // Render with showConsoleView: false so the container jslog attribute is
184
+ // still set on contentElement when ConsolePanel owns ConsoleView.
185
+ this.performUpdate();
121
186
  UI.InspectorView.InspectorView.instance().setDrawerMinimized(true);
122
187
  }
123
188
  ConsolePanel.updateContextFlavor();
@@ -129,11 +194,20 @@ export class WrapperView extends UI.Widget.VBox {
129
194
  }
130
195
 
131
196
  showViewInWrapper(): void {
132
- this.view.show(this.element);
197
+ this.#ownsConsoleView = true;
198
+ // Update synchronously so ConsoleView is mounted before drawer minimize
199
+ // state and ConsoleView context flavor are updated by callers.
200
+ this.performUpdate();
201
+ }
202
+
203
+ hideViewInWrapper(): void {
204
+ this.#ownsConsoleView = false;
205
+ // Update synchronously so ConsoleView detaches before ConsolePanel claims it.
206
+ this.performUpdate();
133
207
  }
134
208
 
135
209
  insertIntoPrompt(text: string): void {
136
- this.view.insertIntoPrompt(text);
210
+ ConsoleView.instance().insertIntoPrompt(text);
137
211
  }
138
212
  }
139
213
 
@@ -10,7 +10,7 @@
10
10
  white-space: nowrap;
11
11
  display: flex;
12
12
  flex-direction: column;
13
- height: 36px;
13
+ height: calc(var(--sys-size-13) + 2 * var(--sys-size-2)); /* 32px two-line content box (.title + .subtitle) + top and bottom --sys-size-2 padding */
14
14
  justify-content: center;
15
15
  overflow-y: auto;
16
16
 
@@ -27,13 +27,6 @@
27
27
  text-overflow: ellipsis;
28
28
  flex-grow: 0;
29
29
  }
30
-
31
- .badge {
32
- pointer-events: none;
33
- margin-right: var(--sys-size-3);
34
- display: inline-block;
35
- height: 15px;
36
- }
37
30
  }
38
31
 
39
32
  &.highlighted .console-context-selector-element .subtitle {
@@ -26,23 +26,16 @@
26
26
  background-size: 400% 100%;
27
27
  animation: gradient 4s infinite linear;
28
28
  margin-top: var(--sys-size-5);
29
- }
30
-
31
- @media (prefers-color-scheme: light) {
32
- .loader {
33
- background-image: linear-gradient(
34
- 70deg,
35
- color-mix(in srgb, var(--sys-color-on-surface) 5%, transparent) 0%,
36
- color-mix(in srgb, var(--sys-color-on-surface) 5%, transparent) 30%,
37
- color-mix(in srgb, var(--sys-color-on-surface) 15%, transparent) 50%,
38
- color-mix(in srgb, var(--sys-color-on-surface) 5%, transparent) 70%,
39
- color-mix(in srgb, var(--sys-color-on-surface) 5%, transparent) 100%
40
- );
41
- }
42
- }
43
-
44
- @media (prefers-color-scheme: dark) {
45
- .loader {
29
+ background-image: linear-gradient(
30
+ 70deg,
31
+ color-mix(in srgb, var(--sys-color-on-surface) 5%, transparent) 0%,
32
+ color-mix(in srgb, var(--sys-color-on-surface) 5%, transparent) 30%,
33
+ color-mix(in srgb, var(--sys-color-on-surface) 15%, transparent) 50%,
34
+ color-mix(in srgb, var(--sys-color-on-surface) 5%, transparent) 70%,
35
+ color-mix(in srgb, var(--sys-color-on-surface) 5%, transparent) 100%
36
+ );
37
+
38
+ .theme-with-dark-background & {
46
39
  background-image: linear-gradient(
47
40
  70deg,
48
41
  color-mix(in srgb, var(--sys-color-on-surface) 10%, transparent) 0%,
@@ -45,7 +45,9 @@
45
45
  }
46
46
 
47
47
  .console-pin-name {
48
- margin-left: -5px;
48
+ /* Cancel CodeMirror .cm-line's 6px left padding so
49
+ * expression text aligns with .console-pin-preview. */
50
+ margin-left: calc(-1 * var(--sys-size-4));
49
51
  margin-bottom: var(--sys-size-1);
50
52
  height: auto;
51
53
  }
@@ -35,7 +35,6 @@
35
35
  overflow: hidden;
36
36
 
37
37
  --override-error-text-color: var(--sys-color-on-error-container);
38
- --message-corner-rounder-background: var(--sys-color-cdt-base-container);
39
38
  }
40
39
 
41
40
  .console-toolbar-container {
@@ -92,9 +91,7 @@
92
91
  }
93
92
 
94
93
  .console-prompt-editor-container {
95
- min-height: 21px;
96
94
  padding-left: var(--sys-size-2);
97
- padding-top: var(--sys-size-1);
98
95
  }
99
96
 
100
97
  .console-message,
@@ -131,7 +128,10 @@
131
128
  }
132
129
 
133
130
  .console-message-repeat-count {
134
- margin: 1.4px 0 0 10px;
131
+ display: inline-flex;
132
+ align-self: flex-start;
133
+ /* 24px (--sys-size-11) message gutter minus 14px (--sys-size-7) bubble size */
134
+ margin: var(--sys-size-2) 0 0 calc(var(--sys-size-11) - var(--sys-size-7));
135
135
  flex: none;
136
136
  }
137
137
 
@@ -180,7 +180,7 @@
180
180
  flex: none;
181
181
  position: relative;
182
182
  left: var(--sys-size-5);
183
- top: 3px;
183
+ top: var(--sys-size-3);
184
184
  margin-right: var(--sys-size-2);
185
185
  }
186
186
 
@@ -321,14 +321,10 @@
321
321
 
322
322
  .console-error-level {
323
323
  background-color: var(--sys-color-surface-error);
324
-
325
- --message-corner-rounder-background: var(--sys-color-surface-error);
326
324
  }
327
325
 
328
326
  .console-warning-level {
329
327
  background-color: var(--sys-color-surface-yellow);
330
-
331
- --message-corner-rounder-background: var(--sys-color-surface-yellow);
332
328
  }
333
329
 
334
330
  .console-view-object-properties-section {
@@ -504,14 +500,14 @@
504
500
 
505
501
  .object-state-note {
506
502
  display: inline-block;
507
- width: 11px;
508
- height: 11px;
503
+ width: var(--sys-size-6);
504
+ height: var(--sys-size-6);
509
505
  color: var(--sys-color-on-tonal-container);
510
506
  text-align: center;
511
- border-radius: 3px;
512
- line-height: 13px;
507
+ border-radius: var(--sys-shape-corner-extra-small);
508
+ line-height: var(--sys-size-6);
513
509
  margin: 0 var(--sys-size-4);
514
- font-size: 9px;
510
+ font-size: var(--sys-typescale-label-size);
515
511
  }
516
512
 
517
513
  .console-object {
@@ -544,7 +540,7 @@
544
540
  }
545
541
 
546
542
  .devtools-console-insight {
547
- margin: 9px var(--sys-size-10) 11px var(--sys-size-11);
543
+ margin: var(--sys-size-5) var(--sys-size-10) var(--sys-size-5) var(--sys-size-11);
548
544
  }
549
545
 
550
546
  .hover-button {
@@ -554,7 +550,7 @@
554
550
  border-radius: var(--sys-shape-corner-full);
555
551
  border: none;
556
552
  /* todo: extract to global styles and make it work with dark mode. */
557
- box-shadow: 0 1px 3px 1px rgb(0 0 0 / 15%), 0 1px 2px 0 rgb(0 0 0 / 30%); /* stylelint-disable-line plugin/use_theme_colors */
553
+ box-shadow: var(--sys-elevation-level1);
558
554
  box-sizing: border-box;
559
555
  background-color: var(--sys-color-tonal-container);
560
556
  color: var(--sys-color-on-tonal-container);
@@ -599,7 +595,7 @@
599
595
  .hover-button:focus,
600
596
  .hover-button:hover {
601
597
  border-radius: var(--sys-shape-corner-extra-small);
602
- max-width: 200px;
598
+ max-width: var(--sys-size-26);
603
599
  transition:
604
600
  max-width var(--sys-motion-duration-short4) var(--sys-motion-easing-emphasized),
605
601
  border-radius 50ms linear;
@@ -15,10 +15,6 @@
15
15
  justify-content: flex-start;
16
16
  }
17
17
 
18
- .data-grid td .url-outer .filter-highlight {
19
- font-weight: bold;
20
- }
21
-
22
18
  .data-grid td .url-prefix {
23
19
  overflow-x: hidden;
24
20
  text-overflow: ellipsis;
@@ -52,28 +52,6 @@
52
52
  font-weight: bold;
53
53
  }
54
54
 
55
- .unused-rules-grid .header-container,
56
- .unused-rules-grid .data-container,
57
- .unused-rules-grid table.data {
58
- position: relative;
59
- }
60
-
61
- .unused-rules-grid .data-container {
62
- top: 0;
63
- max-height: 350px;
64
- }
65
-
66
- .unused-rules-grid {
67
- border-left: none;
68
- border-right: none;
69
- }
70
- /** Ensure links are rendered at the correct height */
71
-
72
- .unused-rules-grid .monospace {
73
- display: block;
74
- height: 18px;
75
- }
76
-
77
55
  .element-grid {
78
56
  flex: 1;
79
57
  border-left: none;
@@ -21,58 +21,15 @@
21
21
  width: fit-content;
22
22
  }
23
23
 
24
- .preview-feature {
25
- padding: var(--sys-size-6) var(--sys-size-8);
26
- border: var(--sys-size-1) solid var(--sys-color-neutral-outline);
27
- color: var(--sys-color-on-surface);
28
- font-size: var(--sys-typescale-body3-size);
29
- line-height: var(--sys-typescale-body3-line-height);
30
- border-radius: var(--sys-shape-corner-medium-small);
31
- margin: 42px 0;
32
- letter-spacing: 0.01em;
33
- }
34
-
35
- .preview-header {
36
- color: var(--sys-color-primary);
37
- font-size: var(--sys-typescale-body3-size);
38
- line-height: var(--sys-typescale-body3-line-height);
39
- letter-spacing: 0.01em;
40
- margin: 9px 0 var(--sys-size-7);
41
- }
42
-
43
24
  .preview-icon {
44
25
  vertical-align: middle;
45
26
  }
46
27
 
47
- .feedback-prompt {
48
- margin-bottom: var(--sys-size-11);
49
- }
50
-
51
- .feedback-prompt .devtools-link {
52
- color: -webkit-link;
53
- cursor: pointer;
54
- text-decoration: underline;
55
- }
56
-
57
28
  .resources {
58
29
  display: flex;
59
30
  flex-direction: row;
60
31
  }
61
32
 
62
- .thumbnail-wrapper {
63
- width: var(--sys-size-22);
64
- height: 92px;
65
- margin-right: var(--sys-size-9);
66
- }
67
-
68
- .video-doc-header {
69
- font-size: var(--sys-typescale-body3-size);
70
- line-height: var(--sys-typescale-body3-line-height);
71
- letter-spacing: 0.04em;
72
- color: var(--sys-color-on-surface);
73
- margin-bottom: var(--sys-size-2);
74
- }
75
-
76
33
  devtools-feedback-button {
77
34
  align-self: flex-end;
78
35
  }