chrome-devtools-frontend 1.0.1739869 → 1.0.1742811

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (272) hide show
  1. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  2. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +44 -7
  3. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +1 -1
  6. package/.agents/skills/code-review/SKILL.md +23 -6
  7. package/.agents/skills/devtools-verification/SKILL.md +2 -1
  8. package/.agents/skills/migrate-chromium-test/SKILL.md +1 -0
  9. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +27 -11
  10. package/.agents/skills/ui-eng-vision-orchestrator/SKILL.md +41 -23
  11. package/.agents/skills/ui-eng-vision-test-scaffolder/SKILL.md +12 -7
  12. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +3 -0
  13. package/.agents/skills/ui-widgets/SKILL.md +22 -7
  14. package/.agents/skills/version-control/SKILL.md +10 -1
  15. package/.agents/skills/visual-regression-audit/SKILL.md +88 -0
  16. package/.gitallowed +2 -1
  17. package/.stylelintignore +1 -0
  18. package/.stylelintrc.json +2 -0
  19. package/AUTHORS +1 -0
  20. package/DIR_METADATA +2 -1
  21. package/PRESUBMIT_test.py +143 -0
  22. package/config/owner/INFRA_OWNERS +0 -1
  23. package/docs/contributing/infrastructure.md +2 -2
  24. package/docs/ui_engineering.md +14 -4
  25. package/eslint.config.mjs +1 -18
  26. package/front_end/application_tokens.css +0 -35
  27. package/front_end/core/host/AidaClient.ts +1 -1
  28. package/front_end/core/host/AidaClientTypes.ts +2 -0
  29. package/front_end/core/host/AidaErrors.ts +3 -3
  30. package/front_end/core/host/AidaGcaTranslation.ts +39 -0
  31. package/front_end/core/host/GcaClient.ts +32 -20
  32. package/front_end/core/host/GcaTypes.ts +4 -2
  33. package/front_end/core/host/InspectorFrontendHostAPI.ts +2 -0
  34. package/front_end/core/i18n/DevToolsLocale.ts +0 -1
  35. package/front_end/core/sdk/DebuggerModel.ts +25 -13
  36. package/front_end/core/sdk/PreloadingModel.ts +2 -2
  37. package/front_end/core/sdk/RehydratingConnection.ts +59 -30
  38. package/front_end/core/sdk/StorageKeyManager.ts +0 -1
  39. package/front_end/core/sdk/Target.ts +6 -0
  40. package/front_end/core/sdk/TargetManager.ts +10 -4
  41. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts +12 -2
  42. package/front_end/entrypoints/inspector_main/OutermostTargetSelector.ts +159 -52
  43. package/front_end/entrypoints/inspector_main/outermostTargetSelector.css +77 -25
  44. package/front_end/entrypoints/main/MainImpl.ts +32 -15
  45. package/front_end/models/ai_assistance/AiAgent2.ts +95 -46
  46. package/front_end/models/ai_assistance/AiConversation.ts +1 -1
  47. package/front_end/models/ai_assistance/agents/AiAgent.ts +9 -2
  48. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +3 -2
  49. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +1 -1
  50. package/front_end/models/ai_assistance/data_formatters/FileFormatter.ts +1 -1
  51. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts +5 -4
  52. package/front_end/models/ai_assistance/performance/AICallTree.ts +7 -9
  53. package/front_end/models/ai_assistance/performance/AIQueries.ts +4 -8
  54. package/front_end/models/ai_assistance/skills/SkillRegistry.ts +11 -1
  55. package/front_end/models/ai_assistance/skills/lighthouse.md +1 -0
  56. package/front_end/models/ai_assistance/skills/network.md +3 -4
  57. package/front_end/models/ai_assistance/skills/sources.md +1 -2
  58. package/front_end/models/ai_assistance/skills/styling.md +3 -4
  59. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +11 -3
  60. package/front_end/models/ai_assistance/tools/ListNetworkRequests.ts +84 -23
  61. package/front_end/models/ai_assistance/tools/ListSources.ts +41 -13
  62. package/front_end/models/badges/Badge.ts +0 -1
  63. package/front_end/models/bindings/ResourceMapping.ts +1 -1
  64. package/front_end/models/bindings/ResourceScriptMapping.ts +1 -1
  65. package/front_end/models/breakpoints/BreakpointManager.ts +2 -4
  66. package/front_end/models/breakpoints/RecurringPauseDetector.ts +140 -0
  67. package/front_end/models/breakpoints/breakpoints.ts +2 -1
  68. package/front_end/models/heap_snapshot/HeapSnapshotModel.ts +2 -2
  69. package/front_end/models/persistence/Automapping.ts +0 -1
  70. package/front_end/models/trace/Processor.ts +16 -7
  71. package/front_end/models/trace/README.md +17 -1
  72. package/front_end/models/trace/extras/ThirdParties.ts +4 -6
  73. package/front_end/models/trace/extras/TraceTree.ts +69 -72
  74. package/front_end/models/trace/handlers/MetaHandler.ts +3 -0
  75. package/front_end/models/trace/handlers/types.ts +15 -0
  76. package/front_end/models/trace/helpers/Trace.ts +5 -3
  77. package/front_end/models/trace/lantern/simulation/Simulator.ts +4 -1
  78. package/front_end/models/web_mcp/WebMCPModel.ts +19 -9
  79. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +30 -3
  80. package/front_end/panels/ai_assistance/components/ChatMessage.ts +2 -4
  81. package/front_end/panels/ai_assistance/components/chatMessage.css +1 -22
  82. package/front_end/panels/ai_assistance/components/exploreWidget.css +1 -19
  83. package/front_end/panels/ai_assistance/components/optInChangeDialog.css +1 -1
  84. package/front_end/panels/ai_assistance/components/walkthroughView.css +0 -13
  85. package/front_end/panels/animation/AnimationGroupPreviewUI.ts +3 -2
  86. package/front_end/panels/animation/AnimationTimeline.ts +5 -3
  87. package/front_end/panels/animation/animationTimeline.css +10 -8
  88. package/front_end/panels/application/ApplicationPanelSidebar.ts +14 -11
  89. package/front_end/panels/application/ReportingApiView.ts +0 -1
  90. package/front_end/panels/application/SubAppsView.ts +0 -1
  91. package/front_end/panels/application/WebMCPTreeElement.ts +3 -6
  92. package/front_end/panels/application/WebMCPView.ts +30 -0
  93. package/front_end/panels/application/components/ReportsGrid.ts +0 -1
  94. package/front_end/panels/application/components/backForwardCacheView.css +0 -7
  95. package/front_end/panels/application/components/permissionsPolicySection.css +2 -2
  96. package/front_end/panels/application/components/protocolHandlersView.css +46 -39
  97. package/front_end/panels/application/components/trustTokensView.css +0 -4
  98. package/front_end/panels/application/cookieItemsView.css +0 -7
  99. package/front_end/panels/application/indexedDBViews.css +0 -6
  100. package/front_end/panels/application/preloading/components/PreloadingDetailsReportView.ts +0 -2
  101. package/front_end/panels/application/preloading/components/PreloadingString.ts +0 -1
  102. package/front_end/panels/application/preloading/components/UsedPreloadingView.ts +4 -5
  103. package/front_end/panels/application/preloading/components/preloadingGrid.css +0 -9
  104. package/front_end/panels/application/serviceWorkerUpdateCycleView.css +2 -9
  105. package/front_end/panels/application/serviceWorkersView.css +5 -4
  106. package/front_end/panels/application/storageView.css +0 -5
  107. package/front_end/panels/application/webMCPView.css +17 -0
  108. package/front_end/panels/browser_debugger/ObjectEventListenersSidebarPane.ts +15 -20
  109. package/front_end/panels/changes/changesView.css +0 -5
  110. package/front_end/panels/common/ExtensionServer.ts +80 -10
  111. package/front_end/panels/console/ConsolePanel.ts +92 -18
  112. package/front_end/panels/console/consoleContextSelector.css +1 -8
  113. package/front_end/panels/console/consoleInsightTeaser.css +10 -17
  114. package/front_end/panels/console/consolePinPane.css +3 -1
  115. package/front_end/panels/console/consoleView.css +13 -17
  116. package/front_end/panels/coverage/coverageListView.css +0 -4
  117. package/front_end/panels/css_overview/cssOverviewCompletedView.css +0 -22
  118. package/front_end/panels/css_overview/cssOverviewStartView.css +0 -43
  119. package/front_end/panels/developer_resources/developerResourcesListView.css +0 -4
  120. package/front_end/panels/elements/ColorSwatchPopoverIcon.ts +52 -45
  121. package/front_end/panels/elements/LayoutPane.ts +1 -3
  122. package/front_end/panels/elements/PropertiesWidget.ts +26 -8
  123. package/front_end/panels/elements/PropertyRenderer.ts +45 -21
  124. package/front_end/panels/elements/StandaloneStylesContainer.ts +6 -7
  125. package/front_end/panels/elements/StyleEditorWidget.ts +110 -63
  126. package/front_end/panels/elements/StylePropertiesSection.ts +14 -5
  127. package/front_end/panels/elements/StylePropertyTreeElement.ts +529 -518
  128. package/front_end/panels/elements/StylesContainer.ts +5 -6
  129. package/front_end/panels/elements/StylesSidebarPane.ts +12 -15
  130. package/front_end/panels/elements/components/CSSVariableValueView.ts +17 -4
  131. package/front_end/panels/elements/components/StylePropertyEditor.ts +178 -140
  132. package/front_end/panels/elements/components/cssQuery.css +1 -1
  133. package/front_end/panels/elements/components/stylePropertyEditor.css +60 -56
  134. package/front_end/panels/elements/layoutPane.css +2 -2
  135. package/front_end/panels/elements/metricsSidebarPane.css +6 -7
  136. package/front_end/panels/elements/platformFontsWidget.css +1 -1
  137. package/front_end/panels/elements/stylePropertiesTreeOutline.css +1 -6
  138. package/front_end/panels/elements/stylesSidebarPane.css +3 -4
  139. package/front_end/panels/emulation/deviceModeView.css +1 -1
  140. package/front_end/panels/event_listeners/EventListenersView.ts +9 -2
  141. package/front_end/panels/event_listeners/eventListenersView.css +1 -1
  142. package/front_end/panels/explain/components/consoleInsight.css +1 -2
  143. package/front_end/panels/issues/issuesTree.css +6 -43
  144. package/front_end/panels/layer_viewer/PaintProfilerView.ts +1 -1
  145. package/front_end/panels/layer_viewer/paintProfiler.css +4 -3
  146. package/front_end/panels/lighthouse/LighthouseReportSelector.ts +1 -6
  147. package/front_end/panels/lighthouse/lighthouseStartView.css +5 -16
  148. package/front_end/panels/linear_memory_inspector/components/LinearMemoryValueInterpreter.ts +0 -1
  149. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  150. package/front_end/panels/linear_memory_inspector/components/linearMemoryViewer.css +2 -2
  151. package/front_end/panels/linear_memory_inspector/components/valueInterpreterSettings.css +1 -1
  152. package/front_end/panels/media/playerListView.css +1 -2
  153. package/front_end/panels/media/playerPropertiesView.css +1 -1
  154. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +2 -2
  155. package/front_end/panels/network/NetworkLogView.ts +594 -580
  156. package/front_end/panels/network/RequestCookiesView.ts +0 -1
  157. package/front_end/panels/network/networkConfigView.css +1 -2
  158. package/front_end/panels/network/networkLogView.css +363 -364
  159. package/front_end/panels/network/networkPanel.css +1 -5
  160. package/front_end/panels/network/networkTimingTable.css +1 -1
  161. package/front_end/panels/network/networkWaterfallColumn.css +1 -1
  162. package/front_end/panels/network/requestConditionsDrawer.css +0 -4
  163. package/front_end/panels/network/requestCookiesView.css +7 -1
  164. package/front_end/panels/network/requestPayloadTree.css +0 -4
  165. package/front_end/panels/profiler/HeapProfileView.ts +1 -3
  166. package/front_end/panels/profiler/HeapSnapshotView.ts +0 -7
  167. package/front_end/panels/recorder/RecorderPanel.ts +1 -1
  168. package/front_end/panels/recorder/RecordingView.ts +10 -10
  169. package/front_end/panels/recorder/StepView.ts +5 -4
  170. package/front_end/panels/recorder/createRecordingView.css +1 -1
  171. package/front_end/panels/recorder/recorderPanel.css +0 -8
  172. package/front_end/panels/recorder/recordingListView.css +4 -4
  173. package/front_end/panels/recorder/recordingView.css +12 -20
  174. package/front_end/panels/recorder/stepEditor.css +4 -4
  175. package/front_end/panels/recorder/stepView.css +31 -9
  176. package/front_end/panels/recorder/timelineSection.css +4 -0
  177. package/front_end/panels/screencast/ScreencastApp.ts +0 -1
  178. package/front_end/panels/security/mainView.css +1 -1
  179. package/front_end/panels/security/originView.css +2 -2
  180. package/front_end/panels/sensors/SensorsView.ts +273 -346
  181. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +0 -1
  182. package/front_end/panels/settings/backendLinkingSettingsTab.css +7 -7
  183. package/front_end/panels/settings/components/syncSection.css +0 -1
  184. package/front_end/panels/settings/workspaceSettingsTab.css +0 -5
  185. package/front_end/panels/sources/CSSPlugin.ts +177 -98
  186. package/front_end/panels/sources/DebuggerPausedMessage.ts +100 -27
  187. package/front_end/panels/sources/NavigatorView.ts +926 -946
  188. package/front_end/panels/sources/SourcesPanel.ts +9 -2
  189. package/front_end/panels/sources/breakpointsView.css +6 -29
  190. package/front_end/panels/sources/components/HeadersView.css +2 -2
  191. package/front_end/panels/sources/debuggerPausedMessage.css +7 -0
  192. package/front_end/panels/sources/navigatorTree.css +7 -2
  193. package/front_end/panels/sources/sourcesNavigator.css +0 -9
  194. package/front_end/panels/sources/watchExpressionsSidebarPane.css +0 -10
  195. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +3 -0
  196. package/front_end/panels/timeline/LayoutShiftsTrackAppender.ts +0 -10
  197. package/front_end/panels/timeline/ModificationsManager.ts +0 -1
  198. package/front_end/panels/timeline/ThreadAppender.ts +2 -6
  199. package/front_end/panels/timeline/TimelinePanel.ts +2 -2
  200. package/front_end/panels/timeline/TimelineTreeView.ts +38 -41
  201. package/front_end/panels/timeline/TimelineUIUtils.ts +8 -10
  202. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +0 -2
  203. package/front_end/panels/timeline/components/fieldSettingsDialog.css +1 -6
  204. package/front_end/panels/timeline/components/insights/baseInsightComponent.css +0 -12
  205. package/front_end/panels/timeline/components/interactionBreakdown.css +1 -2
  206. package/front_end/panels/timeline/components/layoutShiftDetails.css +2 -9
  207. package/front_end/panels/timeline/components/liveMetricsView.css +0 -16
  208. package/front_end/panels/timeline/components/metricCard.css +1 -5
  209. package/front_end/panels/timeline/components/networkRequestDetails.css +3 -4
  210. package/front_end/panels/timeline/components/networkRequestTooltip.css +6 -4
  211. package/front_end/panels/timeline/components/sidebarAnnotationsTab.css +1 -1
  212. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -2
  213. package/front_end/panels/timeline/timelineDetailsView.css +1 -12
  214. package/front_end/panels/timeline/timelineFlamechartPopover.css +0 -4
  215. package/front_end/panels/timeline/timelineMiniMap.css +1 -4
  216. package/front_end/panels/timeline/timelinePanel.css +0 -4
  217. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  218. package/front_end/panels/timeline/timelineTreeView.css +0 -12
  219. package/front_end/panels/timeline/utils/EntryNodes.ts +1 -1
  220. package/front_end/panels/webauthn/webauthnPane.css +1 -7
  221. package/front_end/panels/whats_new/ReleaseNoteText.ts +1 -1
  222. package/front_end/third_party/chromium/README.chromium +1 -1
  223. package/front_end/ui/components/adorners/adorner.css +1 -1
  224. package/front_end/ui/components/buttons/button.css +0 -28
  225. package/front_end/ui/components/buttons/textButton.css +1 -45
  226. package/front_end/ui/components/input/checkbox.css +3 -3
  227. package/front_end/ui/components/issue_counter/issueLinkIcon.css +2 -2
  228. package/front_end/ui/components/menus/Menu.ts +14 -0
  229. package/front_end/ui/components/menus/menu.css +2 -14
  230. package/front_end/ui/components/menus/menuItem.css +0 -4
  231. package/front_end/ui/components/request_link_icon/requestLinkIcon.css +2 -2
  232. package/front_end/ui/components/survey_link/SurveyLink.ts +1 -1
  233. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  234. package/front_end/ui/components/switch/switch.css +3 -2
  235. package/front_end/ui/components/text_editor/theme.ts +1 -1
  236. package/front_end/ui/components/tooltips/Tooltip.ts +3 -3
  237. package/front_end/ui/components/tree_outline/treeOutline.css +0 -23
  238. package/front_end/ui/legacy/ContextMenu.ts +5 -5
  239. package/front_end/ui/legacy/SoftContextMenu.ts +24 -8
  240. package/front_end/ui/legacy/Toolbar.ts +1 -1
  241. package/front_end/ui/legacy/Treeoutline.ts +31 -78
  242. package/front_end/ui/legacy/UIUtils.ts +9 -17
  243. package/front_end/ui/legacy/checkboxTextLabel.css +2 -44
  244. package/front_end/ui/legacy/components/color_picker/Spectrum.ts +39 -27
  245. package/front_end/ui/legacy/components/color_picker/spectrum.css +2 -10
  246. package/front_end/ui/legacy/components/data_grid/dataGrid.css +2 -6
  247. package/front_end/ui/legacy/components/inline_editor/BezierEditor.ts +34 -26
  248. package/front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.ts +1 -0
  249. package/front_end/ui/legacy/components/inline_editor/cssShadowEditor.css +1 -1
  250. package/front_end/ui/legacy/components/inline_editor/swatchPopover.css +1 -1
  251. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +49 -1
  252. package/front_end/ui/legacy/components/object_ui/objectPopover.css +0 -4
  253. package/front_end/ui/legacy/components/perf_ui/chartViewport.css +1 -9
  254. package/front_end/ui/legacy/components/perf_ui/filmStripView.css +1 -1
  255. package/front_end/ui/legacy/components/perf_ui/overviewGrid.css +2 -1
  256. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +0 -5
  257. package/front_end/ui/legacy/components/settings_ui/SettingsUI.ts +6 -3
  258. package/front_end/ui/legacy/components/source_frame/JSONView.ts +95 -1
  259. package/front_end/ui/legacy/filter.css +1 -1
  260. package/front_end/ui/legacy/inspectorCommon.css +6 -28
  261. package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +1 -1
  262. package/front_end/ui/legacy/listWidget.css +1 -1
  263. package/front_end/ui/legacy/progressIndicator.css +1 -1
  264. package/front_end/ui/legacy/tabbedPane.css +6 -2
  265. package/front_end/ui/visual_logging/KnownContextValues.ts +1 -0
  266. package/front_end/ui/visual_logging/LoggingDriver.ts +4 -0
  267. package/front_end/ui/visual_logging/visual_logging.ts +1 -1
  268. package/inspector_overlay/common.ts +0 -3
  269. package/inspector_overlay/main.ts +1 -3
  270. package/inspector_overlay/tool_source_order.css +0 -4
  271. package/package.json +1 -1
  272. package/front_end/generated/SupportedCSSProperties.ts +0 -9705
@@ -22,9 +22,15 @@ git new-branch <branch-name>
22
22
  *Note: This automatically sets the upstream to `origin/main`.*
23
23
 
24
24
  ### Making Changes
25
- 1. Make your changes.
25
+ 1. Make your changes (keeping each CL `<= 350` lines of `insertions + deletions`, with 100% of new code called in production and tested in the same CL).
26
26
  2. Stage them: `git add <files>`.
27
27
  3. Create the commit: `git commit -m "Your message"`.
28
+ * Follow public commit message conventions: a concise summary line (`<= 72` characters) describing *what the CL changes functionally* (never migration pass/step labels such as `Pass 1:` or `(2/6)` in the subject line), a blank line, an explanatory body wrapping at 72 characters, and Git trailers (`Bug:`, `Fixed:`) in the footer. When splitting a migration into a stack, preserve the target Buganizer ID across every CL (`Bug: <id>` on intermediate CLs, `Fixed: <id>` only on the final complete CL).
29
+ * **Never add Piper `KEY=VALUE` tags** (such as `TAG=agy`, `CONV=...`, `BUG=...`, `FIXED=...`, or `MARKDOWN=true`). Commit messages must use Git trailers only; `PRESUBMIT.py` rejects Piper tags because they break Git trailer parsing and can cause duplicate `Change-Id:` footers.
30
+ * To associate agent conversations out of band without polluting commit descriptions with `CONV=`, configure:
31
+ ```bash
32
+ git config --global cl.upload-conversation-id true
33
+ ```
28
34
 
29
35
  ### Updating a CL (Amending)
30
36
  To update your CL after feedback or more work:
@@ -79,6 +85,7 @@ Or, if the WIP patchset is already uploaded, vote `Commit-Queue+1` via `/google/
79
85
  * Use the same writing style as the current committer.
80
86
  * Keep line length below 72.
81
87
  * Add a `Bug: <issue number>` (or `Fixed: <issue number>` / `Bug: None`) trailer on a separate line.
88
+ * Use Git trailers only; never add Piper `KEY=VALUE` tags (`TAG=`, `CONV=`, etc.), which are rejected by `PRESUBMIT.py`. Ensure `cl.upload-conversation-id` is enabled (`git config --global cl.upload-conversation-id true`) to link conversation metadata out of band.
82
89
  * Amend formatter/linter changes and fix linter issues before uploading.
83
90
  * For a brand new stack of CLs, perform the initial WIP upload on each branch individually in parent-to-child order so each CL receives its own commit description.
84
91
 
@@ -128,6 +135,7 @@ To upload an updated CL:
128
135
  git cl upload -f --cq-dry-run -t "<one sentence patch set description>"
129
136
  ```
130
137
  * **Updating an existing stack of CLs:** Once all CLs in a stack have been initially created, **only run `git cl upload` from the leaf (latest) branch in the chain** for subsequent updates. Uploading from the leaf branch automatically runs presubmit checks and uploads new patchsets for all parent CLs in the stack simultaneously. Never upload intermediate CLs one by one when updating a stack.
138
+ * **Cog (`citc`) Workspaces & Continuous Stack CQ/CRUAS Checks:** In Cog workspaces (`/google/cog/cloud/...`), use `cog_api.py` / `vcs.sh` instead of raw `git new-branch`, and **always finish on a clean, empty working copy `@`** (`The working copy has no changes`) by squashing or abandoning temporary `@` commits immediately. After publishing a stack from its leaf commit, trigger `Commit-Queue+1` (`"notify": "NONE"`, never `Commit-Queue+2`) and check `ChromiumCodeReviewAgent` (`gerrit findings --all` and inline comments) across **every** CL in the stack throughout development rather than waiting until human review.
131
139
 
132
140
  ## Release and Roll Status
133
141
 
@@ -154,6 +162,7 @@ To check whether a DevTools commit (`devtools/devtools-frontend`) has rolled int
154
162
  | Check release & roll status | Query `https://chromiumdash.appspot.com/fetch_commit?commit=<sha>` |
155
163
 
156
164
  ## Common Mistakes
165
+ - **Adding Piper `KEY=VALUE` tags to commit messages:** Never add `TAG=agy`, `CONV=...`, `BUG=...`, `FIXED=...`, or other Piper metadata tags to commit descriptions. DevTools is a public Git repository; internal Piper tags break Git trailer parsing and Gerrit `Change-Id` handling, and are rejected by `PRESUBMIT.py`. Use Git trailers (`Bug:`, `Fixed:`) instead, and enable `git config --global cl.upload-conversation-id true` so `git cl upload` attaches conversation IDs out of band.
157
166
  - **Starting human review before resolving `ChromiumCodeReviewAgent` findings:** Never pass `--send-mail` (`-s`) or `-c` (`--use-commit-queue`) on the initial upload, or add human reviewers to the attention set before AI review finishes. Upload in WIP with `--cq-dry-run`, wait for `ChromiumCodeReviewAgent` to complete, and address all `ERROR` and `WARNING` findings first.
158
167
  - **Multiple commits on one branch:** Gerrit expects one commit per CL. Always `commit --amend`.
159
168
  - **Using `git checkout -b`:** Does not set up tracking information correctly for `depot_tools`. Use `git new-branch`.
@@ -0,0 +1,88 @@
1
+ ---
2
+ name: visual-regression-audit
3
+ description: >-
4
+ Audits UI Engineering Vision migrations, CSS @scope conversions, widget
5
+ refactorings, and UI layout or styling changes for visual, layout, and
6
+ interaction regressions before merge. Use when reviewing changes touching
7
+ front_end/(panels|ui)/**/*.{ts,css} or whenever a CL changes UI layout or
8
+ rendered appearance.
9
+ ---
10
+
11
+ # Visual & Interaction Regression Audit
12
+
13
+ Apply this checklist whenever a CL migrates imperative DOM to `UI.Widget` +
14
+ `lit-html`, wraps Light DOM styles in `@scope`, swaps `TreeOutline`,
15
+ `DataGrid`, `ListControl`, or `ListWidget` to declarative components, or
16
+ whenever a CL changes UI layout, styling, or rendered appearance.
17
+
18
+ ## 1. Screenshot Golden Gate (`assertScreenshot`)
19
+
20
+ - **Require visual baselines on layout-affecting diffs:** Flag any CL that
21
+ wraps a `.css` file in `@scope to (devtools-widget > *)`, promotes a class to
22
+ `UI.Widget`, swaps a legacy tree/grid/list widget, or otherwise changes UI
23
+ layout or styling without either existing or newly added
24
+ `assertScreenshot(...)` tests covering its non-empty rendered state (and dark
25
+ mode or overflow state when styling colors/scrollbars). Check sibling
26
+ `*.test.ts` files before flagging standalone CSS CLs whose existing
27
+ `assertScreenshot(...)` tests are not modified in the diff.
28
+ - **Do not flag** pure Pass 0.5 `#private`/dead-code prefactors, presenter-only
29
+ logic moves that leave DOM structure and CSS untouched, or removals of
30
+ provably unreferenced CSS selectors or files (which touch CSS without
31
+ changing rendered appearance).
32
+
33
+ ## 2. Flex, Sizing, and Overflow Clipping (`<devtools-widget>` & Popovers)
34
+
35
+ - **Host vs. `contentElement` classes:** When removing `super(..., {classes})`
36
+ or imperative `this.element.classList.add(...)`, verify every layout class
37
+ (`vbox`, `hbox`, `flex-auto`, `overflow-auto`, custom root classes) moved to
38
+ `render(..., target, {container: {classes: [...]}})` (or `:scope` in CSS).
39
+ Dropping `vbox` or `min-height: 0` on a flex child collapses height to `0` or
40
+ clips scrollbars (e.g. popover and sidebar panes). Also check two manual
41
+ `@devtools/no-widget-constructor-classes` traps:
42
+ - **`useShadowDom: true` vs. `'pure'`:** Under `useShadowDom: true` (unlike
43
+ Light DOM or `useShadowDom: 'pure'`), `this.contentElement` is an inner
44
+ `<div>` inside the shadow root while `Widget` adds `vbox flex-auto` to
45
+ `this.element`. Moving host classes (such as `flex-none`) to
46
+ `render(..., target, {container: {classes}})` without switching to
47
+ `useShadowDom: 'pure'` applies them to the inner `<div>` instead of the
48
+ host element.
49
+ - **Multi-branch `render(..., target)` views:** Every `render(..., target)`
50
+ branch in a view function must pass `{container: {classes: [...]}}`, or
51
+ `render()` will strip those classes when switching branches/states.
52
+ - **`WrapperWidget` uses `display: contents`:** Flag any width, height, flex,
53
+ overflow, border, or background styling placed on a `<devtools-widget>` host
54
+ that mounts `UI.Widget.WrapperWidget`. Wrap it in a sized `<div>` instead.
55
+ - **`<devtools-tree>` overflow:** Check `?hide-overflow` vs. scrollable parent
56
+ containers so horizontal/vertical scrollbars are neither double-rendered nor
57
+ clipped at container edges.
58
+
59
+ ## 3. `<devtools-tree>` Parity Traps (Top Source of M152/M156 Regressions)
60
+
61
+ - **Event name is `@expand`, never `@expanded`:** `TreeViewElement` dispatches
62
+ `new ExpandEvent(...)` with type `'expand'` (`e.detail.expanded`,
63
+ `e.detail.recursively`). Flag any `@expanded=${...}` listener on
64
+ `<li role="treeitem">` as a dead handler that silently drops expansion state.
65
+ - **Lazy child population & `ifExpanded`:** When migrating recursive trees
66
+ (`DOMTreeWidget`, `ObjectTree`, `NavigatorView`), verify expanding a parent
67
+ populates child data *and* triggers `requestUpdate()`, and verify initial
68
+ root/default-open nodes render their children on first paint.
69
+ - **Context menus (`@contextmenu`):** Verify every legacy
70
+ `appendApplicableItems` / `treeElement.oncontextmenu` path (such as *Reveal
71
+ in Elements*, *Copy value*, *Expand recursively*) is wired on the migrated
72
+ `<li role="treeitem">` or root container, and check `event.target` assumptions
73
+ across `<devtools-tree>`'s shadow clone boundary.
74
+ - **Keyboard `@select` vs. mouse `@click`:** Ensure arrow-key navigation
75
+ triggers the same preview/highlight side effects (e.g. DOM node overlay
76
+ highlight) as clicking the row, respecting `e.detail.selectedByUser`.
77
+ - **Inline text selection & editing:** Check that `user-select` rules inside
78
+ tree rows still allow partial token selection where expected, and keep
79
+ editable `<devtools-prompt ?editing>` inside a child `${widget(...)}` so
80
+ attribute mutations do not re-clone the row and blur focus.
81
+
82
+ ## 4. `@scope` Visual Parity Checks
83
+
84
+ - Verify `@scope` wrapping is landed in a standalone CSS CL rather than mixed
85
+ with template or widget-promotion changes.
86
+ - Check removed selectors for layout side effects on legacy imperative child
87
+ widgets (`childWidget.show(container)` renders `<div class="widget">`, which
88
+ is *not* stopped by the `(devtools-widget > *)` lower boundary).
package/.gitallowed CHANGED
@@ -3,4 +3,5 @@
3
3
  CRUX_API_KEY
4
4
  # Publicly-visible API key for Firebase analytics, used in NetworkRequestHandler.test.ts
5
5
  AIzaSyCGxLbbFQxH4BV1fY0RODlxTos9nJa2l_g
6
-
6
+ # Publicly-visible API key for CrUX in for_agents/src/tools/performance.ts
7
+ AIzaSyBn5gimNjhiEyA_euicSKko6IlD3HdgUfk
package/.stylelintignore CHANGED
@@ -10,3 +10,4 @@ third_party
10
10
  front_end/ui/components/docs
11
11
  build
12
12
  buildtools
13
+ for_agents
package/.stylelintrc.json CHANGED
@@ -16,7 +16,9 @@
16
16
  "hue-degree-notation": "angle",
17
17
  "comment-empty-line-before": null,
18
18
  "declaration-no-important": true,
19
+ "declaration-block-no-duplicate-properties": true,
19
20
  "color-named": "never",
21
+ "selector-no-unmatchable": true,
20
22
  "selector-type-no-unknown": [
21
23
  true,
22
24
  {
package/AUTHORS CHANGED
@@ -75,6 +75,7 @@ Karntino Areros <karntino.c.areros@gmail.com>
75
75
  Kohei Ueno <kohei.ueno119@gmail.com>
76
76
  Krishnal Ciccolella <ciccolella.krishnal@gmail.com>
77
77
  Liam DeBeasi <ldebeasi@gmail.com>
78
+ Lisha Guo <guolisha@kylinos.cn>
78
79
  Luke Swiderski <luke.swiderski@gmail.com>
79
80
  Luke Warlow <luke@warlow.dev>
80
81
  Lyra Rebane <rebane2001@gmail.com>
package/DIR_METADATA CHANGED
@@ -47,7 +47,8 @@ agentic_review: {
47
47
  path_expression_exclusion: [".*\\.test\\.ts"]
48
48
  review_capability_skills: [
49
49
  ".agents/skills/ui-widgets/SKILL.md",
50
- ".agents/skills/ui-eng-vision-orchestrator/SKILL.md"
50
+ ".agents/skills/ui-eng-vision-orchestrator/SKILL.md",
51
+ ".agents/skills/visual-regression-audit/SKILL.md"
51
52
  ]
52
53
  rules: [
53
54
  ".agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md",
@@ -0,0 +1,143 @@
1
+ # Copyright 2026 The Chromium Authors
2
+ # Use of this source code is governed by a BSD-style license that can be
3
+ # found in the LICENSE file.
4
+
5
+ import unittest
6
+ import PRESUBMIT
7
+
8
+
9
+ class MockChange:
10
+
11
+ def __init__(self, description):
12
+ self._description = description
13
+
14
+ def FullDescriptionText(self):
15
+ return self._description
16
+
17
+
18
+ class MockInputApi:
19
+
20
+ def __init__(self, description):
21
+ self.change = MockChange(description)
22
+
23
+
24
+ class MockOutputApi:
25
+
26
+ class PresubmitResult:
27
+
28
+ def __init__(self, message, items=None, long_text=''):
29
+ self.message = message
30
+ self.items = items or []
31
+ self.long_text = long_text
32
+
33
+ def __repr__(self):
34
+ return f'{self.__class__.__name__}({self.message!r})'
35
+
36
+ class PresubmitError(PresubmitResult):
37
+ pass
38
+
39
+
40
+ class PiperTagsPresubmitTest(unittest.TestCase):
41
+
42
+ def testValidCleanDescription(self):
43
+ description = (
44
+ '[devtools] Add cool feature\n\n'
45
+ 'This is a clean commit description.\n\n'
46
+ 'Bug: 123456\n'
47
+ 'Change-Id: I1234567890abcdef1234567890abcdef12345678\n')
48
+ input_api = MockInputApi(description)
49
+ output_api = MockOutputApi()
50
+
51
+ errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
52
+ self.assertEqual(errors, [])
53
+
54
+ def testValidWithFixedAndNone(self):
55
+ description = ('[devtools] Fix issue\n\n'
56
+ 'Fixed: 123456, 7890\n')
57
+ input_api = MockInputApi(description)
58
+ output_api = MockOutputApi()
59
+
60
+ errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
61
+ self.assertEqual(errors, [])
62
+
63
+ description_none = ('[devtools] Minor cleanup\n\n'
64
+ 'Bug: None\n')
65
+ input_api_none = MockInputApi(description_none)
66
+ errors_none = PRESUBMIT.CheckNoPiperTagsInDescription(
67
+ input_api_none, output_api)
68
+ self.assertEqual(errors_none, [])
69
+
70
+ def testValidMidLineTags(self):
71
+ description = (
72
+ '[devtools] Update docs\n\n'
73
+ 'We previously fixed a bug where TAG=agy was incorrectly emitted.\n'
74
+ 'Also noted that BUG=123 is discussed in comments.\n\n'
75
+ 'Bug: 123456\n')
76
+ input_api = MockInputApi(description)
77
+ output_api = MockOutputApi()
78
+
79
+ errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
80
+ self.assertEqual(errors, [])
81
+
82
+ def testValidExcludedKeys(self):
83
+ description = (
84
+ '[devtools] Roll deps\n\n'
85
+ 'Roll third_party/something\n\n'
86
+ 'R=chrome-devtools-waterfall-gardener-emea-oncall@google.com\n'
87
+ 'TBR=someone@chromium.org\n'
88
+ 'CC=someone@chromium.org\n'
89
+ 'Bug: None\n')
90
+ input_api = MockInputApi(description)
91
+ output_api = MockOutputApi()
92
+
93
+ errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
94
+ self.assertEqual(errors, [])
95
+
96
+ def testRejectsPiperTags(self):
97
+ rejected_keys = [
98
+ 'TAG=agy',
99
+ 'CONV=c29008c7-cac9-4486-adb8-a74b42bd015e',
100
+ 'BUG=123456',
101
+ 'FIXED=123456',
102
+ 'MARKDOWN=true',
103
+ 'ORIGINAL_AUTHOR=author@example.com',
104
+ 'WANT_LGTM=1',
105
+ 'AUTOSUBMIT_BEHAVIOR=1',
106
+ 'R_FUTURE=someone@example.com',
107
+ ]
108
+ output_api = MockOutputApi()
109
+
110
+ for tag in rejected_keys:
111
+ with self.subTest(tag=tag):
112
+ description = f'[devtools] Change\n\nExplanation.\n\n{tag}\nBug: 123\n'
113
+ input_api = MockInputApi(description)
114
+ errors = PRESUBMIT.CheckNoPiperTagsInDescription(
115
+ input_api, output_api)
116
+ self.assertEqual(len(errors), 1,
117
+ f'Expected {tag} to be rejected')
118
+ self.assertIsInstance(errors[0], output_api.PresubmitError)
119
+ self.assertIn(tag, errors[0].message)
120
+ self.assertIn('Bug:', errors[0].message)
121
+ self.assertIn('Fixed:', errors[0].message)
122
+ self.assertIn('cl.upload-conversation-id', errors[0].message)
123
+
124
+ def testRejectsMultipleOffendingLines(self):
125
+ description = ('[devtools] Change\n\n'
126
+ 'Explanation.\n\n'
127
+ 'TAG=agy\n'
128
+ 'CONV=c29008c7-cac9-4486-adb8-a74b42bd015e\n'
129
+ 'BUG=12345\n'
130
+ 'Bug: 12345\n')
131
+ input_api = MockInputApi(description)
132
+ output_api = MockOutputApi()
133
+
134
+ errors = PRESUBMIT.CheckNoPiperTagsInDescription(input_api, output_api)
135
+ self.assertEqual(len(errors), 1)
136
+ self.assertIn('TAG=agy', errors[0].message)
137
+ self.assertIn('CONV=c29008c7-cac9-4486-adb8-a74b42bd015e',
138
+ errors[0].message)
139
+ self.assertIn('BUG=12345', errors[0].message)
140
+
141
+
142
+ if __name__ == '__main__':
143
+ unittest.main()
@@ -2,7 +2,6 @@ alexschulze@chromium.org
2
2
  alexrudenko@chromium.org
3
3
  dsv@chromium.org
4
4
  jacktfranklin@chromium.org
5
- liviurau@chromium.org
6
5
  machenbach@chromium.org
7
6
  mathias@chromium.org
8
7
  paulirish@chromium.org
@@ -130,8 +130,8 @@ and extended branch numbers in infra/config (example [CL](https://crrev.com/c/68
130
130
  - otherwise update it to the current stable number
131
131
  - stable number updates to the current beta number
132
132
  - beta number updates to the Chromium beta brunch number ([see](https://chromiumdash.appspot.com/branches))
133
- - regenerate the cfg files (`lucicfg main.star`), commit, upload and add
134
- liviurau@chromium.org as reviewer (or another infra team member)
133
+ - regenerate the cfg files (`lucicfg main.star`), commit, upload and add an
134
+ infra team member as reviewer
135
135
 
136
136
  Changing these numbers will reconfigure the CI and CQ for [beta](https://ci.chromium.org/p/devtools-frontend/g/beta/console),
137
137
  [stable](https://ci.chromium.org/p/devtools-frontend/g/stable/console) and
@@ -119,9 +119,18 @@ render(html`
119
119
  `, this.element);
120
120
  ```
121
121
 
122
- In this example, the `.title` style will apply within the parent widget but will not leak into the nested widget. Because this convention relies on developer discipline, it is important to verify its correct application during code reviews.
122
+ In this example, the `.title` style will apply within the parent widget but will not leak into the nested widget. Two automated lint rules enforce this encapsulation:
123
123
 
124
- **Note:** Inside a `<devtools-data-grid>`, any `<style>` tags must be placed as direct children of the `<table>` element.
124
+ - `@devtools/no-unscoped-light-dom-styles` (ESLint): checks stylesheets injected by Light DOM widgets (`<style>${styles}</style>`, `this.registerRequiredCSS()`, and `appendStyle()`) and requires every style rule to sit inside a top-level `@scope` block. Pre-existing outliers are tracked in a self-cleaning `burndown` list in `eslint.config.mjs` (never add new files to that list).
125
+ - `plugin/check_scope_selectors` (stylelint): unconditionally forbids `:host` inside `@scope` (even with `:scope` or `&`), and flags ancestor selectors that receive an implicit `:scope ` descendant combinator and never match without `:scope` or `&` (`:host-context()`, `:root`, `html`, `body`, `.theme-with-dark-background`, `.platform-*`, and `.overlay-scrollbar-enabled`).
126
+
127
+ ### Key `@scope` Traps and Best Practices
128
+
129
+ 1. **`:scope` instead of `:host`**: `:host` is Shadow DOM-only and never matches inside `@scope`. Style the widget's root container element with `:scope`.
130
+ 2. **Theme-aware tokens instead of theme or platform classes**: Because selectors inside `@scope` without `:scope` or `&` receive an implicit `:scope ` descendant prefix, selectors like `.theme-with-dark-background .foo` or `:host-context(.theme-with-dark-background) .foo` look for ancestor theme classes *inside* the scoped subtree and never match. Use theme-aware design tokens (`--sys-color-*` / `--app-color-*`) instead.
131
+ 3. **Shared stylesheets**: Do not inject `inspectorCommonStyles` or `textButtonStyles` into Light DOM views (`installComponentRootStyles()` already applies them to the document and shadow roots). Wrap other shared stylesheets inline as `<style>@scope to (devtools-widget > *) { ${styles} }</style>` so their Shadow DOM consumers stay unaffected. Note that inline wrapping disables CSS hot reload in DevTools-on-DevTools for that `<style>` element.
132
+ 4. **Lower boundary and imperative child widgets**: The `(devtools-widget > *)` lower boundary stops cascading into declarative `<devtools-widget>` children (`${widget(...)}`), but it does **not** stop at legacy imperatively attached `<div class="widget">` children (`childWidget.show(container)`).
133
+ 5. **`<devtools-data-grid>`**: Inside a `<devtools-data-grid>`, any `<style>` tags must be placed as direct children of the `<table>` element. `<style>` tags inside `<devtools-data-grid>` stay connected in Light DOM, so their stylesheets still require `@scope`.
125
134
 
126
135
  ## Examples
127
136
 
@@ -587,7 +596,7 @@ export const DEFAULT_VIEW = (input, _output, target) => {
587
596
 
588
597
  ## Migrating `UI.Toolbar.ToolbarButton`
589
598
 
590
- Replace the imperative creation of a `ToolbarButton` with the declarative `<devtools-button>` component.
599
+ Replace the imperative creation of a `ToolbarButton` with the declarative `<devtools-button>` component. For icon-only buttons, always bind `.accessibleLabel` (in addition to `title`) because `<devtools-button>` sets `role="presentation"` on its host element and forwards `.accessibleLabel` to its inner `<button>`.
591
600
 
592
601
  **Before:**
593
602
  ```typescript
@@ -611,7 +620,8 @@ export const DEFAULT_VIEW = (input, _output, target) => {
611
620
  render(html`
612
621
  <div>
613
622
  <devtools-toolbar>
614
- <devtools-button title=${i18nString(UIStrings.editName)} @click=${this.onClick.bind(this)}
623
+ <devtools-button title=${i18nString(UIStrings.editName)}
624
+ .accessibleLabel=${i18nString(UIStrings.editName)} @click=${this.onClick.bind(this)}
615
625
  .variant=${Buttons.Button.Variant.TOOLBAR} .iconName=${'edit'}
616
626
  .jslogContext=${'edit-name'}></devtools-button>
617
627
  </devtools-toolbar>
package/eslint.config.mjs CHANGED
@@ -25,6 +25,7 @@ export default defineConfig([
25
25
  'out/',
26
26
  // Don't include third party code
27
27
  'third_party/',
28
+ 'for_agents/',
28
29
 
29
30
  'front_end/diff/diff_match_patch.js',
30
31
  'front_end/models/javascript_metadata/NativeFunctions.ts',
@@ -879,16 +880,12 @@ export default defineConfig([
879
880
  'front_end/panels/application/DeviceBoundSessionsView.ts',
880
881
  'front_end/panels/application/IndexedDBViews.ts',
881
882
  'front_end/panels/application/KeyValueStorageItemsView.ts',
882
- 'front_end/panels/application/ReportingApiView.ts',
883
883
  'front_end/panels/application/ResourcesPanel.ts',
884
884
  'front_end/panels/application/ServiceWorkerCacheViews.ts',
885
885
  'front_end/panels/application/ServiceWorkersView.ts',
886
- 'front_end/panels/application/SubAppsView.ts',
887
886
  'front_end/panels/application/WebMCPView.ts',
888
887
  'front_end/panels/application/components/EndpointsGrid.ts',
889
888
  'front_end/panels/application/components/ProtocolHandlersView.ts',
890
- 'front_end/panels/application/components/ReportsGrid.ts',
891
- 'front_end/panels/application/preloading/components/PreloadingDetailsReportView.ts',
892
889
  'front_end/panels/changes/CombinedDiffView.ts',
893
890
  'front_end/panels/common/CommentThreadWidget.ts',
894
891
  'front_end/panels/console/ConsolePinPane.ts',
@@ -903,7 +900,6 @@ export default defineConfig([
903
900
  'front_end/panels/layer_viewer/Layers3DView.ts',
904
901
  'front_end/panels/lighthouse/LighthousePanel.ts',
905
902
  'front_end/panels/linear_memory_inspector/components/LinearMemoryNavigator.ts',
906
- 'front_end/panels/linear_memory_inspector/components/LinearMemoryValueInterpreter.ts',
907
903
  'front_end/panels/linear_memory_inspector/components/ValueInterpreterDisplay.ts',
908
904
  'front_end/panels/media/EventDisplayTable.ts',
909
905
  'front_end/panels/media/PlayerMessagesView.ts',
@@ -911,7 +907,6 @@ export default defineConfig([
911
907
  'front_end/panels/network/NetworkLogView.ts',
912
908
  'front_end/panels/network/NetworkPanel.ts',
913
909
  'front_end/panels/network/NetworkWaterfallColumn.ts',
914
- 'front_end/panels/network/RequestCookiesView.ts',
915
910
  'front_end/panels/network/RequestDeviceBoundSessionsView.ts',
916
911
  'front_end/panels/network/RequestHeadersView.ts',
917
912
  'front_end/panels/network/RequestPayloadView.ts',
@@ -919,9 +914,7 @@ export default defineConfig([
919
914
  'front_end/panels/profiler/HeapProfileView.ts',
920
915
  'front_end/panels/profiler/ProfileLauncherView.ts',
921
916
  'front_end/panels/profiler/ProfilesPanel.ts',
922
- 'front_end/panels/screencast/ScreencastApp.ts',
923
917
  'front_end/panels/settings/AISettingsTab.ts',
924
- 'front_end/panels/settings/BackendLinkingSettingsTab.ts',
925
918
  'front_end/panels/settings/emulation/DevicesSettingsTab.ts',
926
919
  'front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts',
927
920
  'front_end/panels/sources/FilteredUISourceCodeListProvider.ts',
@@ -937,7 +930,6 @@ export default defineConfig([
937
930
  'front_end/panels/timeline/TimelinePanel.ts',
938
931
  'front_end/panels/timeline/TimelineSelectorStatsView.ts',
939
932
  'front_end/panels/timeline/TimelineTreeView.ts',
940
- 'front_end/panels/timeline/components/LayoutShiftDetails.ts',
941
933
  'front_end/panels/webauthn/WebauthnPane.ts',
942
934
  'front_end/ui/components/dialogs/FreDialog.ts',
943
935
  'front_end/ui/components/text_editor/AiCodeGenerationUpgradeDialog.ts',
@@ -1124,7 +1116,6 @@ export default defineConfig([
1124
1116
  'front_end/panels/network/EventSourceMessagesView.ts',
1125
1117
  'front_end/panels/network/NetworkDataGridNode.ts',
1126
1118
  'front_end/panels/network/NetworkFrameGrouper.ts',
1127
- 'front_end/panels/network/NetworkLogView.ts',
1128
1119
  'front_end/panels/network/NetworkLogViewColumns.ts',
1129
1120
  'front_end/panels/network/NetworkManageCustomHeadersView.ts',
1130
1121
  'front_end/panels/network/NetworkOverview.ts',
@@ -1159,7 +1150,6 @@ export default defineConfig([
1159
1150
  'front_end/panels/sources/EditingLocationHistoryManager.ts',
1160
1151
  'front_end/panels/sources/FilePathScoreFunction.ts',
1161
1152
  'front_end/panels/sources/FilteredUISourceCodeListProvider.ts',
1162
- 'front_end/panels/sources/NavigatorView.ts',
1163
1153
  'front_end/panels/sources/OutlineQuickOpen.ts',
1164
1154
  'front_end/panels/sources/SourcesPanel.ts',
1165
1155
  'front_end/panels/sources/SourcesSearchScope.ts',
@@ -1273,13 +1263,6 @@ export default defineConfig([
1273
1263
  '@devtools/prefer-private-class-members': 'off',
1274
1264
  },
1275
1265
  },
1276
- {
1277
- name: 'Supported CSS properties rules',
1278
- files: ['front_end/generated/SupportedCSSProperties.ts'],
1279
- rules: {
1280
- '@devtools/jslog-context-list': 'error',
1281
- },
1282
- },
1283
1266
  {
1284
1267
  name: 'EsLint rules test',
1285
1268
  files: ['scripts/eslint_rules/tests/**/*'],
@@ -58,20 +58,15 @@
58
58
  --color-grid-focus-selected: var(--sys-color-tonal-container);
59
59
  --color-grid-selected: var(--sys-color-surface-variant);
60
60
  --color-grid-hovered: var(--sys-color-state-hover-on-subtle);
61
- --color-primary-old: rgb(26 115 232);
62
61
  --color-background: rgb(255 255 255);
63
62
  --color-background-inverted-opacity-0: rgb(0 0 0 / 0%);
64
63
  --color-background-inverted-opacity-2: rgb(0 0 0 / 2%);
65
64
  --color-background-inverted-opacity-50: rgb(0 0 0 / 50%);
66
65
  --color-background-opacity-80: rgb(255 255 255 / 80%);
67
- --color-background-elevation-1: rgb(241 243 244);
68
66
  --color-background-elevation-2: rgb(222 225 230);
69
- /** Used when the elevation is visible only on dark theme */
70
- --color-background-elevation-dark-only: var(--color-background);
71
67
  /** To draw grid lines behind elements */
72
68
  --divider-line: rgb(0 0 0 / 10%);
73
69
  --color-text-primary: rgb(32 33 36);
74
- --color-text-secondary: rgb(95 99 104);
75
70
  --color-text-disabled: rgb(128 134 139);
76
71
  --color-red: rgb(238 68 47);
77
72
  --drop-shadow:
@@ -105,10 +100,6 @@
105
100
  --color-evaluated-expression: var(--ref-palette-yellow95);
106
101
  --color-evaluated-expression-border: var(--ref-palette-yellow70);
107
102
  --color-variable-values: var(--ref-palette-orange90);
108
-
109
- /* Color tokens for icons */
110
- --color-primary: rgb(11 87 208);
111
- --legacy-accent-color: #1a73e8;
112
103
  --legacy-focus-ring-inactive-shadow-color: #e0e0e0;
113
104
  --legacy-input-validation-error: #db1600;
114
105
  --legacy-focus-ring-inactive-shadow: 0 0 0 1px var(--legacy-focus-ring-inactive-shadow-color);
@@ -126,23 +117,14 @@
126
117
  /* Colors for timeline in Performance Panel */
127
118
 
128
119
  --app-color-loading: var(--ref-palette-blue70);
129
- --app-color-loading-children: var(--ref-palette-blue80);
130
120
  --app-color-scripting: var(--ref-palette-yellow70);
131
- --app-color-scripting-children: var(--ref-palette-yellow80);
132
121
  --app-color-rendering: var(--ref-palette-purple70);
133
122
  --app-color-rendering-children: var(--ref-palette-purple80);
134
123
  --app-color-painting: var(--ref-palette-green70);
135
- --app-color-painting-children: var(--ref-palette-green80);
136
124
  --app-color-messaging: var(--ref-palette-cyan70);
137
- --app-color-task: var(--ref-palette-neutral80);
138
- --app-color-task-children: var(--ref-palette-neutral90);
139
125
  --app-color-system: var(--ref-palette-neutral80);
140
- --app-color-system-children: var(--ref-palette-neutral90);
141
126
  --app-color-idle: var(--ref-palette-neutral90);
142
- --app-color-idle-children: var(--ref-palette-neutral100);
143
127
  --app-color-async: var(--ref-palette-error60);
144
- --app-color-async-children: var(--ref-palette-error70);
145
- --app-color-other: var(--ref-palette-neutral87);
146
128
  --app-color-doc: var(--ref-palette-blue60);
147
129
  --app-color-css: var(--ref-palette-purple60);
148
130
  --app-color-image: var(--ref-palette-green80);
@@ -243,17 +225,13 @@
243
225
  --comment-cursor: var(--image-file-comment-mode-cursor) 10 28, auto;
244
226
 
245
227
  &.theme-with-dark-background {
246
- --color-primary-old: rgb(138 180 248);
247
228
  --color-background: rgb(32 33 36);
248
229
  --color-background-inverted-opacity-2: rgb(255 255 255 / 2%);
249
230
  --color-background-inverted-opacity-50: rgb(255 255 255 / 50%);
250
231
  --color-background-opacity-80: rgb(32 33 36 / 80%);
251
- --color-background-elevation-1: rgb(41 42 45);
252
232
  --color-background-elevation-2: rgb(53 54 58);
253
- --color-background-elevation-dark-only: var(--color-background-elevation-1);
254
233
  --divider-line: rgb(255 255 255 / 10%);
255
234
  --color-text-primary: rgb(232 234 237);
256
- --color-text-secondary: rgb(154 160 166);
257
235
  --color-text-disabled: rgb(128 134 139);
258
236
  --color-red: rgb(237 78 76);
259
237
  --drop-shadow:
@@ -280,16 +258,12 @@
280
258
  --color-evaluated-expression-border: var(--ref-palette-yellow40);
281
259
  --color-variable-values: var(--sys-color-surface-error);
282
260
 
283
- /* Color tokens for icons */
284
- --color-primary: rgb(168 199 250);
285
-
286
261
  /**
287
262
  * Inherit the native form control colors when using a dark theme.
288
263
  * Override them using CSS variables if needed.
289
264
  */
290
265
  color-scheme: dark;
291
266
 
292
- --legacy-accent-color: #0e639c;
293
267
  --legacy-focus-ring-inactive-shadow-color: #5a5a5a;
294
268
  --legacy-focus-ring-inactive-shadow: 0 0 0 1px var(--legacy-focus-ring-inactive-shadow-color);
295
269
 
@@ -305,22 +279,13 @@
305
279
  /* Colors for timeline in Performance Panel */
306
280
 
307
281
  --app-color-loading: var(--ref-palette-blue60);
308
- --app-color-loading-children: var(--ref-palette-blue50);
309
282
  --app-color-scripting: var(--ref-palette-yellow70);
310
- --app-color-scripting-children: var(--ref-palette-yellow60);
311
283
  --app-color-rendering: var(--ref-palette-purple60);
312
284
  --app-color-rendering-children: var(--ref-palette-purple50);
313
285
  --app-color-painting: var(--ref-palette-green70);
314
- --app-color-painting-children: var(--ref-palette-green60);
315
- --app-color-task: var(--ref-palette-neutral80);
316
- --app-color-task-children: var(--ref-palette-neutral70);
317
286
  --app-color-system: var(--ref-palette-neutral50);
318
- --app-color-system-children: var(--ref-palette-neutral40);
319
287
  --app-color-idle: var(--ref-palette-neutral30);
320
- --app-color-idle-children: var(--ref-palette-neutral20);
321
288
  --app-color-async: var(--ref-palette-error60);
322
- --app-color-async-children: var(--ref-palette-error50);
323
- --app-color-other: var(--ref-palette-neutral60);
324
289
  --app-color-doc: var(--ref-palette-blue60);
325
290
  --app-color-css: var(--ref-palette-purple60);
326
291
  --app-color-image: var(--ref-palette-green80);
@@ -286,7 +286,7 @@ export class AidaClient {
286
286
  ...result.metadata,
287
287
  };
288
288
  if (metadata?.attributionMetadata?.attributionAction === RecitationAction.BLOCK) {
289
- throw new AidaBlockError();
289
+ throw new AidaBlockError(result.blockMessage);
290
290
  }
291
291
  }
292
292
  if (result.textChunk) {
@@ -486,6 +486,8 @@ export interface AidaChunkResponse {
486
486
  * {"code": 429, "message": "You have exhausted your capacity on this model.", "status": "RESOURCE_EXHAUSTED", "details": [...]}).
487
487
  */
488
488
  error?: string|Record<string, unknown>;
489
+ /** Why GCA blocked the prompt or the response, for the `AidaBlockError` message. */
490
+ blockMessage?: string;
489
491
  }
490
492
 
491
493
  // Reads `devToolsAiDebug` directly because `core/host` cannot depend on `models/ai-utils`.
@@ -162,8 +162,8 @@ export function mapError(err: unknown, detail?: string): AidaClientError {
162
162
  * - `'AIDA request was blocked'`: `HandleAidaClientUnavailable()` returns this string on
163
163
  * `aidaCodeComplete` when `AidaClient::CanUseAida()` blocks the profile, and the embedder
164
164
  * dispatcher returns it when a non-local frontend invokes `aidaCodeComplete`.
165
- * - `'Disallowed path or method'`: `OnHttpRequestPerformed()` returns this string for
166
- * `kAccessDenied` when `DevToolsHttpServiceRegistry` rejects the endpoint path or HTTP method.
165
+ * - `'Disallowed path, method, or header'`: `OnHttpRequestPerformed()` returns this string for
166
+ * `kAccessDenied` when `DevToolsHttpServiceRegistry` rejects the endpoint path, HTTP method, or header.
167
167
  * - `'Request validation failed'`: `OnHttpRequestPerformed()` returns this string for
168
168
  * `kValidationFailed` when `CanMakeRequest()` rejects the profile (off-the-record, enterprise
169
169
  * policy, age, or geo restrictions), and the embedder dispatcher returns it when a non-local
@@ -173,7 +173,7 @@ export function mapError(err: unknown, detail?: string): AidaClientError {
173
173
  */
174
174
  const VALIDATION_ERROR_MESSAGES = new Set<string>([
175
175
  'AIDA request was blocked',
176
- 'Disallowed path or method',
176
+ 'Disallowed path, method, or header',
177
177
  'Request validation failed',
178
178
  'Service not found',
179
179
  ]);