chrome-devtools-frontend 1.0.1739869 → 1.0.1742811

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (272) hide show
  1. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  2. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +44 -7
  3. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +1 -1
  6. package/.agents/skills/code-review/SKILL.md +23 -6
  7. package/.agents/skills/devtools-verification/SKILL.md +2 -1
  8. package/.agents/skills/migrate-chromium-test/SKILL.md +1 -0
  9. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +27 -11
  10. package/.agents/skills/ui-eng-vision-orchestrator/SKILL.md +41 -23
  11. package/.agents/skills/ui-eng-vision-test-scaffolder/SKILL.md +12 -7
  12. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +3 -0
  13. package/.agents/skills/ui-widgets/SKILL.md +22 -7
  14. package/.agents/skills/version-control/SKILL.md +10 -1
  15. package/.agents/skills/visual-regression-audit/SKILL.md +88 -0
  16. package/.gitallowed +2 -1
  17. package/.stylelintignore +1 -0
  18. package/.stylelintrc.json +2 -0
  19. package/AUTHORS +1 -0
  20. package/DIR_METADATA +2 -1
  21. package/PRESUBMIT_test.py +143 -0
  22. package/config/owner/INFRA_OWNERS +0 -1
  23. package/docs/contributing/infrastructure.md +2 -2
  24. package/docs/ui_engineering.md +14 -4
  25. package/eslint.config.mjs +1 -18
  26. package/front_end/application_tokens.css +0 -35
  27. package/front_end/core/host/AidaClient.ts +1 -1
  28. package/front_end/core/host/AidaClientTypes.ts +2 -0
  29. package/front_end/core/host/AidaErrors.ts +3 -3
  30. package/front_end/core/host/AidaGcaTranslation.ts +39 -0
  31. package/front_end/core/host/GcaClient.ts +32 -20
  32. package/front_end/core/host/GcaTypes.ts +4 -2
  33. package/front_end/core/host/InspectorFrontendHostAPI.ts +2 -0
  34. package/front_end/core/i18n/DevToolsLocale.ts +0 -1
  35. package/front_end/core/sdk/DebuggerModel.ts +25 -13
  36. package/front_end/core/sdk/PreloadingModel.ts +2 -2
  37. package/front_end/core/sdk/RehydratingConnection.ts +59 -30
  38. package/front_end/core/sdk/StorageKeyManager.ts +0 -1
  39. package/front_end/core/sdk/Target.ts +6 -0
  40. package/front_end/core/sdk/TargetManager.ts +10 -4
  41. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts +12 -2
  42. package/front_end/entrypoints/inspector_main/OutermostTargetSelector.ts +159 -52
  43. package/front_end/entrypoints/inspector_main/outermostTargetSelector.css +77 -25
  44. package/front_end/entrypoints/main/MainImpl.ts +32 -15
  45. package/front_end/models/ai_assistance/AiAgent2.ts +95 -46
  46. package/front_end/models/ai_assistance/AiConversation.ts +1 -1
  47. package/front_end/models/ai_assistance/agents/AiAgent.ts +9 -2
  48. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +3 -2
  49. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +1 -1
  50. package/front_end/models/ai_assistance/data_formatters/FileFormatter.ts +1 -1
  51. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts +5 -4
  52. package/front_end/models/ai_assistance/performance/AICallTree.ts +7 -9
  53. package/front_end/models/ai_assistance/performance/AIQueries.ts +4 -8
  54. package/front_end/models/ai_assistance/skills/SkillRegistry.ts +11 -1
  55. package/front_end/models/ai_assistance/skills/lighthouse.md +1 -0
  56. package/front_end/models/ai_assistance/skills/network.md +3 -4
  57. package/front_end/models/ai_assistance/skills/sources.md +1 -2
  58. package/front_end/models/ai_assistance/skills/styling.md +3 -4
  59. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +11 -3
  60. package/front_end/models/ai_assistance/tools/ListNetworkRequests.ts +84 -23
  61. package/front_end/models/ai_assistance/tools/ListSources.ts +41 -13
  62. package/front_end/models/badges/Badge.ts +0 -1
  63. package/front_end/models/bindings/ResourceMapping.ts +1 -1
  64. package/front_end/models/bindings/ResourceScriptMapping.ts +1 -1
  65. package/front_end/models/breakpoints/BreakpointManager.ts +2 -4
  66. package/front_end/models/breakpoints/RecurringPauseDetector.ts +140 -0
  67. package/front_end/models/breakpoints/breakpoints.ts +2 -1
  68. package/front_end/models/heap_snapshot/HeapSnapshotModel.ts +2 -2
  69. package/front_end/models/persistence/Automapping.ts +0 -1
  70. package/front_end/models/trace/Processor.ts +16 -7
  71. package/front_end/models/trace/README.md +17 -1
  72. package/front_end/models/trace/extras/ThirdParties.ts +4 -6
  73. package/front_end/models/trace/extras/TraceTree.ts +69 -72
  74. package/front_end/models/trace/handlers/MetaHandler.ts +3 -0
  75. package/front_end/models/trace/handlers/types.ts +15 -0
  76. package/front_end/models/trace/helpers/Trace.ts +5 -3
  77. package/front_end/models/trace/lantern/simulation/Simulator.ts +4 -1
  78. package/front_end/models/web_mcp/WebMCPModel.ts +19 -9
  79. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +30 -3
  80. package/front_end/panels/ai_assistance/components/ChatMessage.ts +2 -4
  81. package/front_end/panels/ai_assistance/components/chatMessage.css +1 -22
  82. package/front_end/panels/ai_assistance/components/exploreWidget.css +1 -19
  83. package/front_end/panels/ai_assistance/components/optInChangeDialog.css +1 -1
  84. package/front_end/panels/ai_assistance/components/walkthroughView.css +0 -13
  85. package/front_end/panels/animation/AnimationGroupPreviewUI.ts +3 -2
  86. package/front_end/panels/animation/AnimationTimeline.ts +5 -3
  87. package/front_end/panels/animation/animationTimeline.css +10 -8
  88. package/front_end/panels/application/ApplicationPanelSidebar.ts +14 -11
  89. package/front_end/panels/application/ReportingApiView.ts +0 -1
  90. package/front_end/panels/application/SubAppsView.ts +0 -1
  91. package/front_end/panels/application/WebMCPTreeElement.ts +3 -6
  92. package/front_end/panels/application/WebMCPView.ts +30 -0
  93. package/front_end/panels/application/components/ReportsGrid.ts +0 -1
  94. package/front_end/panels/application/components/backForwardCacheView.css +0 -7
  95. package/front_end/panels/application/components/permissionsPolicySection.css +2 -2
  96. package/front_end/panels/application/components/protocolHandlersView.css +46 -39
  97. package/front_end/panels/application/components/trustTokensView.css +0 -4
  98. package/front_end/panels/application/cookieItemsView.css +0 -7
  99. package/front_end/panels/application/indexedDBViews.css +0 -6
  100. package/front_end/panels/application/preloading/components/PreloadingDetailsReportView.ts +0 -2
  101. package/front_end/panels/application/preloading/components/PreloadingString.ts +0 -1
  102. package/front_end/panels/application/preloading/components/UsedPreloadingView.ts +4 -5
  103. package/front_end/panels/application/preloading/components/preloadingGrid.css +0 -9
  104. package/front_end/panels/application/serviceWorkerUpdateCycleView.css +2 -9
  105. package/front_end/panels/application/serviceWorkersView.css +5 -4
  106. package/front_end/panels/application/storageView.css +0 -5
  107. package/front_end/panels/application/webMCPView.css +17 -0
  108. package/front_end/panels/browser_debugger/ObjectEventListenersSidebarPane.ts +15 -20
  109. package/front_end/panels/changes/changesView.css +0 -5
  110. package/front_end/panels/common/ExtensionServer.ts +80 -10
  111. package/front_end/panels/console/ConsolePanel.ts +92 -18
  112. package/front_end/panels/console/consoleContextSelector.css +1 -8
  113. package/front_end/panels/console/consoleInsightTeaser.css +10 -17
  114. package/front_end/panels/console/consolePinPane.css +3 -1
  115. package/front_end/panels/console/consoleView.css +13 -17
  116. package/front_end/panels/coverage/coverageListView.css +0 -4
  117. package/front_end/panels/css_overview/cssOverviewCompletedView.css +0 -22
  118. package/front_end/panels/css_overview/cssOverviewStartView.css +0 -43
  119. package/front_end/panels/developer_resources/developerResourcesListView.css +0 -4
  120. package/front_end/panels/elements/ColorSwatchPopoverIcon.ts +52 -45
  121. package/front_end/panels/elements/LayoutPane.ts +1 -3
  122. package/front_end/panels/elements/PropertiesWidget.ts +26 -8
  123. package/front_end/panels/elements/PropertyRenderer.ts +45 -21
  124. package/front_end/panels/elements/StandaloneStylesContainer.ts +6 -7
  125. package/front_end/panels/elements/StyleEditorWidget.ts +110 -63
  126. package/front_end/panels/elements/StylePropertiesSection.ts +14 -5
  127. package/front_end/panels/elements/StylePropertyTreeElement.ts +529 -518
  128. package/front_end/panels/elements/StylesContainer.ts +5 -6
  129. package/front_end/panels/elements/StylesSidebarPane.ts +12 -15
  130. package/front_end/panels/elements/components/CSSVariableValueView.ts +17 -4
  131. package/front_end/panels/elements/components/StylePropertyEditor.ts +178 -140
  132. package/front_end/panels/elements/components/cssQuery.css +1 -1
  133. package/front_end/panels/elements/components/stylePropertyEditor.css +60 -56
  134. package/front_end/panels/elements/layoutPane.css +2 -2
  135. package/front_end/panels/elements/metricsSidebarPane.css +6 -7
  136. package/front_end/panels/elements/platformFontsWidget.css +1 -1
  137. package/front_end/panels/elements/stylePropertiesTreeOutline.css +1 -6
  138. package/front_end/panels/elements/stylesSidebarPane.css +3 -4
  139. package/front_end/panels/emulation/deviceModeView.css +1 -1
  140. package/front_end/panels/event_listeners/EventListenersView.ts +9 -2
  141. package/front_end/panels/event_listeners/eventListenersView.css +1 -1
  142. package/front_end/panels/explain/components/consoleInsight.css +1 -2
  143. package/front_end/panels/issues/issuesTree.css +6 -43
  144. package/front_end/panels/layer_viewer/PaintProfilerView.ts +1 -1
  145. package/front_end/panels/layer_viewer/paintProfiler.css +4 -3
  146. package/front_end/panels/lighthouse/LighthouseReportSelector.ts +1 -6
  147. package/front_end/panels/lighthouse/lighthouseStartView.css +5 -16
  148. package/front_end/panels/linear_memory_inspector/components/LinearMemoryValueInterpreter.ts +0 -1
  149. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  150. package/front_end/panels/linear_memory_inspector/components/linearMemoryViewer.css +2 -2
  151. package/front_end/panels/linear_memory_inspector/components/valueInterpreterSettings.css +1 -1
  152. package/front_end/panels/media/playerListView.css +1 -2
  153. package/front_end/panels/media/playerPropertiesView.css +1 -1
  154. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +2 -2
  155. package/front_end/panels/network/NetworkLogView.ts +594 -580
  156. package/front_end/panels/network/RequestCookiesView.ts +0 -1
  157. package/front_end/panels/network/networkConfigView.css +1 -2
  158. package/front_end/panels/network/networkLogView.css +363 -364
  159. package/front_end/panels/network/networkPanel.css +1 -5
  160. package/front_end/panels/network/networkTimingTable.css +1 -1
  161. package/front_end/panels/network/networkWaterfallColumn.css +1 -1
  162. package/front_end/panels/network/requestConditionsDrawer.css +0 -4
  163. package/front_end/panels/network/requestCookiesView.css +7 -1
  164. package/front_end/panels/network/requestPayloadTree.css +0 -4
  165. package/front_end/panels/profiler/HeapProfileView.ts +1 -3
  166. package/front_end/panels/profiler/HeapSnapshotView.ts +0 -7
  167. package/front_end/panels/recorder/RecorderPanel.ts +1 -1
  168. package/front_end/panels/recorder/RecordingView.ts +10 -10
  169. package/front_end/panels/recorder/StepView.ts +5 -4
  170. package/front_end/panels/recorder/createRecordingView.css +1 -1
  171. package/front_end/panels/recorder/recorderPanel.css +0 -8
  172. package/front_end/panels/recorder/recordingListView.css +4 -4
  173. package/front_end/panels/recorder/recordingView.css +12 -20
  174. package/front_end/panels/recorder/stepEditor.css +4 -4
  175. package/front_end/panels/recorder/stepView.css +31 -9
  176. package/front_end/panels/recorder/timelineSection.css +4 -0
  177. package/front_end/panels/screencast/ScreencastApp.ts +0 -1
  178. package/front_end/panels/security/mainView.css +1 -1
  179. package/front_end/panels/security/originView.css +2 -2
  180. package/front_end/panels/sensors/SensorsView.ts +273 -346
  181. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +0 -1
  182. package/front_end/panels/settings/backendLinkingSettingsTab.css +7 -7
  183. package/front_end/panels/settings/components/syncSection.css +0 -1
  184. package/front_end/panels/settings/workspaceSettingsTab.css +0 -5
  185. package/front_end/panels/sources/CSSPlugin.ts +177 -98
  186. package/front_end/panels/sources/DebuggerPausedMessage.ts +100 -27
  187. package/front_end/panels/sources/NavigatorView.ts +926 -946
  188. package/front_end/panels/sources/SourcesPanel.ts +9 -2
  189. package/front_end/panels/sources/breakpointsView.css +6 -29
  190. package/front_end/panels/sources/components/HeadersView.css +2 -2
  191. package/front_end/panels/sources/debuggerPausedMessage.css +7 -0
  192. package/front_end/panels/sources/navigatorTree.css +7 -2
  193. package/front_end/panels/sources/sourcesNavigator.css +0 -9
  194. package/front_end/panels/sources/watchExpressionsSidebarPane.css +0 -10
  195. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +3 -0
  196. package/front_end/panels/timeline/LayoutShiftsTrackAppender.ts +0 -10
  197. package/front_end/panels/timeline/ModificationsManager.ts +0 -1
  198. package/front_end/panels/timeline/ThreadAppender.ts +2 -6
  199. package/front_end/panels/timeline/TimelinePanel.ts +2 -2
  200. package/front_end/panels/timeline/TimelineTreeView.ts +38 -41
  201. package/front_end/panels/timeline/TimelineUIUtils.ts +8 -10
  202. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +0 -2
  203. package/front_end/panels/timeline/components/fieldSettingsDialog.css +1 -6
  204. package/front_end/panels/timeline/components/insights/baseInsightComponent.css +0 -12
  205. package/front_end/panels/timeline/components/interactionBreakdown.css +1 -2
  206. package/front_end/panels/timeline/components/layoutShiftDetails.css +2 -9
  207. package/front_end/panels/timeline/components/liveMetricsView.css +0 -16
  208. package/front_end/panels/timeline/components/metricCard.css +1 -5
  209. package/front_end/panels/timeline/components/networkRequestDetails.css +3 -4
  210. package/front_end/panels/timeline/components/networkRequestTooltip.css +6 -4
  211. package/front_end/panels/timeline/components/sidebarAnnotationsTab.css +1 -1
  212. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -2
  213. package/front_end/panels/timeline/timelineDetailsView.css +1 -12
  214. package/front_end/panels/timeline/timelineFlamechartPopover.css +0 -4
  215. package/front_end/panels/timeline/timelineMiniMap.css +1 -4
  216. package/front_end/panels/timeline/timelinePanel.css +0 -4
  217. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  218. package/front_end/panels/timeline/timelineTreeView.css +0 -12
  219. package/front_end/panels/timeline/utils/EntryNodes.ts +1 -1
  220. package/front_end/panels/webauthn/webauthnPane.css +1 -7
  221. package/front_end/panels/whats_new/ReleaseNoteText.ts +1 -1
  222. package/front_end/third_party/chromium/README.chromium +1 -1
  223. package/front_end/ui/components/adorners/adorner.css +1 -1
  224. package/front_end/ui/components/buttons/button.css +0 -28
  225. package/front_end/ui/components/buttons/textButton.css +1 -45
  226. package/front_end/ui/components/input/checkbox.css +3 -3
  227. package/front_end/ui/components/issue_counter/issueLinkIcon.css +2 -2
  228. package/front_end/ui/components/menus/Menu.ts +14 -0
  229. package/front_end/ui/components/menus/menu.css +2 -14
  230. package/front_end/ui/components/menus/menuItem.css +0 -4
  231. package/front_end/ui/components/request_link_icon/requestLinkIcon.css +2 -2
  232. package/front_end/ui/components/survey_link/SurveyLink.ts +1 -1
  233. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  234. package/front_end/ui/components/switch/switch.css +3 -2
  235. package/front_end/ui/components/text_editor/theme.ts +1 -1
  236. package/front_end/ui/components/tooltips/Tooltip.ts +3 -3
  237. package/front_end/ui/components/tree_outline/treeOutline.css +0 -23
  238. package/front_end/ui/legacy/ContextMenu.ts +5 -5
  239. package/front_end/ui/legacy/SoftContextMenu.ts +24 -8
  240. package/front_end/ui/legacy/Toolbar.ts +1 -1
  241. package/front_end/ui/legacy/Treeoutline.ts +31 -78
  242. package/front_end/ui/legacy/UIUtils.ts +9 -17
  243. package/front_end/ui/legacy/checkboxTextLabel.css +2 -44
  244. package/front_end/ui/legacy/components/color_picker/Spectrum.ts +39 -27
  245. package/front_end/ui/legacy/components/color_picker/spectrum.css +2 -10
  246. package/front_end/ui/legacy/components/data_grid/dataGrid.css +2 -6
  247. package/front_end/ui/legacy/components/inline_editor/BezierEditor.ts +34 -26
  248. package/front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.ts +1 -0
  249. package/front_end/ui/legacy/components/inline_editor/cssShadowEditor.css +1 -1
  250. package/front_end/ui/legacy/components/inline_editor/swatchPopover.css +1 -1
  251. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +49 -1
  252. package/front_end/ui/legacy/components/object_ui/objectPopover.css +0 -4
  253. package/front_end/ui/legacy/components/perf_ui/chartViewport.css +1 -9
  254. package/front_end/ui/legacy/components/perf_ui/filmStripView.css +1 -1
  255. package/front_end/ui/legacy/components/perf_ui/overviewGrid.css +2 -1
  256. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +0 -5
  257. package/front_end/ui/legacy/components/settings_ui/SettingsUI.ts +6 -3
  258. package/front_end/ui/legacy/components/source_frame/JSONView.ts +95 -1
  259. package/front_end/ui/legacy/filter.css +1 -1
  260. package/front_end/ui/legacy/inspectorCommon.css +6 -28
  261. package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +1 -1
  262. package/front_end/ui/legacy/listWidget.css +1 -1
  263. package/front_end/ui/legacy/progressIndicator.css +1 -1
  264. package/front_end/ui/legacy/tabbedPane.css +6 -2
  265. package/front_end/ui/visual_logging/KnownContextValues.ts +1 -0
  266. package/front_end/ui/visual_logging/LoggingDriver.ts +4 -0
  267. package/front_end/ui/visual_logging/visual_logging.ts +1 -1
  268. package/inspector_overlay/common.ts +0 -3
  269. package/inspector_overlay/main.ts +1 -3
  270. package/inspector_overlay/tool_source_order.css +0 -4
  271. package/package.json +1 -1
  272. package/front_end/generated/SupportedCSSProperties.ts +0 -9705
@@ -1,7 +1,9 @@
1
1
  // Copyright 2023 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
4
+
5
+ import '../../ui/components/menus/menus.js';
6
+ import '../../ui/kit/kit.js';
5
7
 
6
8
  import type * as Common from '../../core/common/common.js';
7
9
  import * as i18n from '../../core/i18n/i18n.js';
@@ -9,7 +11,10 @@ import * as Platform from '../../core/platform/platform.js';
9
11
  import * as SDK from '../../core/sdk/sdk.js';
10
12
  import type * as Protocol from '../../generated/protocol.js';
11
13
  import * as Bindings from '../../models/bindings/bindings.js';
14
+ import type * as Menus from '../../ui/components/menus/menus.js';
12
15
  import * as UI from '../../ui/legacy/legacy.js';
16
+ import {html, render} from '../../ui/lit/lit.js';
17
+ import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
13
18
 
14
19
  import outermostTargetSelectorStyles from './outermostTargetSelector.css.js';
15
20
 
@@ -27,21 +32,94 @@ const UIStrings = {
27
32
  const str_ = i18n.i18n.registerUIStrings('entrypoints/inspector_main/OutermostTargetSelector.ts', UIStrings);
28
33
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
29
34
 
30
- export class OutermostTargetSelector implements SDK.TargetManager.Observer, UI.SoftDropDown.Delegate<SDK.Target.Target>,
31
- UI.Toolbar.Provider {
32
- readonly listItems: UI.ListModel.ListModel<SDK.Target.Target> = new UI.ListModel.ListModel();
33
- readonly #dropDown: UI.SoftDropDown.SoftDropDown<SDK.Target.Target>;
35
+ export interface TargetItem {
36
+ title: string;
37
+ subtitle: string;
38
+ }
39
+
40
+ export interface ViewInput {
41
+ items: TargetItem[];
42
+ selectedIndex: number;
43
+ open: boolean;
44
+ onToggleMenu: () => void;
45
+ onCloseMenu: () => void;
46
+ onSelect: (index: number) => void;
47
+ }
48
+
49
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
50
+
51
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
52
+ const selectedItem = input.selectedIndex >= 0 && input.selectedIndex < input.items.length ?
53
+ input.items[input.selectedIndex] :
54
+ undefined;
55
+ const buttonTitle =
56
+ selectedItem ? i18nString(UIStrings.targetS, {PH1: selectedItem.title}) : i18nString(UIStrings.targetNotSelected);
57
+ // clang-format off
58
+ render(html`
59
+ <style>${outermostTargetSelectorStyles}</style>
60
+ <button
61
+ id="outermost-target-selector-button"
62
+ class="soft-dropdown toolbar-has-dropdown"
63
+ type="button"
64
+ jslog=${VisualLogging.dropDown('outermost-target-selector').track({click: true})}
65
+ title=${buttonTitle}
66
+ aria-label=${buttonTitle}
67
+ aria-haspopup="true"
68
+ aria-expanded=${input.open}
69
+ ?disabled=${input.items.length === 0}
70
+ @click=${input.onToggleMenu}
71
+ @keydown=${(event: KeyboardEvent) => {
72
+ if (!input.open && (event.key === 'ArrowDown' || event.key === 'ArrowUp')) {
73
+ event.consume(true);
74
+ input.onToggleMenu();
75
+ }
76
+ }}
77
+ >
78
+ <span class="title">${selectedItem?.title ?? ''}</span>
79
+ <devtools-icon name="triangle-down"></devtools-icon>
80
+ </button>
81
+ <devtools-menu
82
+ origin="outermost-target-selector-button"
83
+ .showDivider=${false}
84
+ .showSelectedItem=${true}
85
+ .open=${input.open}
86
+ @menucloserequest=${input.onCloseMenu}
87
+ @menuitemselected=${(event: Menus.Menu.MenuItemSelectedEvent) => {
88
+ input.onSelect(Number(event.itemValue));
89
+ }}
90
+ >
91
+ ${input.items.map((item, index) => html`
92
+ <devtools-menu-item
93
+ .value=${index}
94
+ .selected=${index === input.selectedIndex}
95
+ jslog=${VisualLogging.item().track({click: true, resize: true})}
96
+ >
97
+ <div class="outermost-target-selector-item">
98
+ <div class="title">${Platform.StringUtilities.trimEndWithMaxLength(item.title, 100)}</div>
99
+ <div class="subtitle">${item.subtitle}</div>
100
+ </div>
101
+ </devtools-menu-item>
102
+ `)}
103
+ </devtools-menu>`,
104
+ target);
105
+ // clang-format on
106
+ };
107
+
108
+ export class OutermostTargetSelector extends UI.Widget.Widget implements SDK.TargetManager.Observer,
109
+ UI.Toolbar.Provider {
110
+ readonly #targets: SDK.Target.Target[] = [];
34
111
  readonly #toolbarItem: UI.Toolbar.ToolbarItem;
112
+ readonly #view: View;
113
+ #selectedTarget: SDK.Target.Target|null = null;
114
+ #open = false;
35
115
 
36
- constructor() {
37
- this.#dropDown = new UI.SoftDropDown.SoftDropDown(this.listItems, this);
38
- this.#dropDown.setRowHeight(36);
39
- this.#toolbarItem = new UI.Toolbar.ToolbarItem(this.#dropDown.element);
40
- this.#toolbarItem.setTitle(i18nString(UIStrings.targetNotSelected));
41
- this.listItems.addEventListener(
42
- UI.ListModel.Events.ITEMS_REPLACED, () => this.#toolbarItem.setEnabled(Boolean(this.listItems.length)));
116
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
117
+ super(element);
118
+ this.#view = view;
119
+ this.#toolbarItem = new UI.Toolbar.ToolbarItem(this.element);
120
+ this.#toolbarItem.setEnabled(false);
121
+ this.#toolbarItem.setVisible(false);
43
122
 
44
- this.#toolbarItem.element.classList.add('toolbar-has-dropdown');
45
123
  const targetManager = SDK.TargetManager.TargetManager.instance();
46
124
  targetManager.addModelListener(
47
125
  SDK.ChildTargetManager.ChildTargetManager, SDK.ChildTargetManager.Events.TARGET_INFO_CHANGED,
@@ -50,47 +128,92 @@ export class OutermostTargetSelector implements SDK.TargetManager.Observer, UI.S
50
128
  targetManager.observeTargets(this);
51
129
 
52
130
  UI.Context.Context.instance().addFlavorChangeListener(SDK.Target.Target, this.#targetChanged, this);
131
+ this.requestUpdate();
53
132
  }
54
133
 
55
- item(): UI.Toolbar.ToolbarItem {
56
- return this.#toolbarItem;
134
+ override show(parentElement: Element|DocumentFragment, insertBefore?: Node|null,
135
+ suppressOrphanWidgetError?: boolean): void {
136
+ super.show(parentElement, insertBefore, suppressOrphanWidgetError);
137
+ this.#toolbarItem.setVisible(this.#targets.length > 1);
57
138
  }
58
139
 
59
- highlightedItemChanged(
60
- _from: SDK.Target.Target|null, _to: SDK.Target.Target|null, fromElement: Element|null,
61
- toElement: Element|null): void {
62
- if (fromElement) {
63
- fromElement.classList.remove('highlighted');
64
- }
65
- if (toElement) {
66
- toElement.classList.add('highlighted');
67
- }
140
+ override wasShown(): void {
141
+ super.wasShown();
142
+ this.#toolbarItem.setVisible(this.#targets.length > 1);
143
+ this.requestUpdate();
68
144
  }
69
145
 
70
- titleFor(target: SDK.Target.Target): string {
71
- return target.name();
146
+ override performUpdate(): void {
147
+ const items: TargetItem[] = this.#targets.map(target => ({
148
+ title: target.name(),
149
+ subtitle: this.#subtitleFor(target),
150
+ }));
151
+ const selectedIndex = this.#selectedTarget ? this.#targets.indexOf(this.#selectedTarget) : -1;
152
+ this.#view({
153
+ items,
154
+ selectedIndex,
155
+ open: this.#open,
156
+ onToggleMenu: () => {
157
+ if (this.#targets.length === 0) {
158
+ return;
159
+ }
160
+ this.#open = !this.#open;
161
+ this.requestUpdate();
162
+ },
163
+ onCloseMenu: () => {
164
+ if (!this.#open) {
165
+ return;
166
+ }
167
+ this.#open = false;
168
+ this.requestUpdate();
169
+ },
170
+ onSelect: (index: number) => {
171
+ this.#open = false;
172
+ const target = this.#targets[index] ?? null;
173
+ this.#selectTarget(target);
174
+ },
175
+ },
176
+ undefined, this.contentElement);
177
+ }
178
+
179
+ item(): UI.Toolbar.ToolbarItem {
180
+ return this.#toolbarItem;
72
181
  }
73
182
 
74
183
  targetAdded(target: SDK.Target.Target): void {
75
184
  if (target.outermostTarget() !== target) {
76
185
  return;
77
186
  }
78
- this.listItems.insertWithComparator(target, this.#targetComparator());
79
- this.#toolbarItem.setVisible(this.listItems.length > 1);
187
+ const insertIndex =
188
+ Platform.ArrayUtilities.upperBound(this.#targets, target, this.#targetComparator(), 0, this.#targets.length);
189
+ this.#targets.splice(insertIndex, 0, target);
190
+ this.#toolbarItem.setEnabled(this.#targets.length > 0);
191
+ this.#toolbarItem.setVisible(this.#targets.length > 1);
80
192
 
81
193
  const primaryTarget = SDK.TargetManager.TargetManager.instance().primaryPageTarget();
82
194
  if (target === primaryTarget || target === UI.Context.Context.instance().flavor(SDK.Target.Target)) {
83
- this.#dropDown.selectItem(target);
195
+ this.#selectTarget(target);
196
+ } else {
197
+ this.requestUpdate();
84
198
  }
85
199
  }
86
200
 
87
201
  targetRemoved(target: SDK.Target.Target): void {
88
- const index = this.listItems.indexOf(target);
202
+ const index = this.#targets.indexOf(target);
89
203
  if (index === -1) {
90
204
  return;
91
205
  }
92
- this.listItems.remove(index);
93
- this.#toolbarItem.setVisible(this.listItems.length > 1);
206
+ this.#targets.splice(index, 1);
207
+ this.#toolbarItem.setEnabled(this.#targets.length > 0);
208
+ this.#toolbarItem.setVisible(this.#targets.length > 1);
209
+ if (this.#targets.length <= 1) {
210
+ this.#open = false;
211
+ }
212
+ if (this.#selectedTarget === target) {
213
+ this.#selectTarget(null);
214
+ } else {
215
+ this.requestUpdate();
216
+ }
94
217
  }
95
218
 
96
219
  #targetComparator() {
@@ -133,18 +256,7 @@ export class OutermostTargetSelector implements SDK.TargetManager.Observer, UI.S
133
256
  #targetChanged({
134
257
  data: target,
135
258
  }: Common.EventTarget.EventTargetEvent<SDK.Target.Target|null>): void {
136
- this.#dropDown.selectItem(target?.outermostTarget() || null);
137
- }
138
-
139
- createElementForItem(item: SDK.Target.Target): Element {
140
- const element = document.createElement('div');
141
- element.classList.add('target');
142
- const shadowRoot = UI.UIUtils.createShadowRootWithCoreStyles(element, {cssFile: outermostTargetSelectorStyles});
143
- const title = shadowRoot.createChild('div', 'title');
144
- UI.UIUtils.createTextChild(title, Platform.StringUtilities.trimEndWithMaxLength(this.titleFor(item), 100));
145
- const subTitle = shadowRoot.createChild('div', 'subtitle');
146
- UI.UIUtils.createTextChild(subTitle, this.#subtitleFor(item));
147
- return element;
259
+ this.#selectTarget(target?.outermostTarget() || null);
148
260
  }
149
261
 
150
262
  #subtitleFor(target: SDK.Target.Target): string {
@@ -155,16 +267,11 @@ export class OutermostTargetSelector implements SDK.TargetManager.Observer, UI.S
155
267
  return target.targetInfo()?.subtype || '';
156
268
  }
157
269
 
158
- isItemSelectable(_item: SDK.Target.Target): boolean {
159
- return true;
160
- }
161
-
162
- itemSelected(item: SDK.Target.Target|null): void {
163
- const title =
164
- item ? i18nString(UIStrings.targetS, {PH1: this.titleFor(item)}) : i18nString(UIStrings.targetNotSelected);
165
- this.#toolbarItem.setTitle(title);
270
+ #selectTarget(item: SDK.Target.Target|null): void {
271
+ this.#selectedTarget = item;
166
272
  if (item && item !== UI.Context.Context.instance().flavor(SDK.Target.Target)?.outermostTarget()) {
167
273
  UI.Context.Context.instance().setFlavor(SDK.Target.Target, item);
168
274
  }
275
+ this.requestUpdate();
169
276
  }
170
277
  }
@@ -4,32 +4,84 @@
4
4
  * found in the LICENSE file.
5
5
  */
6
6
 
7
- :host {
8
- padding: var(--sys-size-2) var(--sys-size-1) var(--sys-size-2) var(--sys-size-2);
9
- white-space: nowrap;
10
- display: flex;
11
- flex-direction: column;
12
- height: 36px;
13
- justify-content: center;
14
- overflow-y: auto;
15
- }
7
+ @scope to (devtools-widget > *) {
8
+ button.soft-dropdown {
9
+ height: var(--sys-size-11);
10
+ text-align: left;
11
+ position: relative;
12
+ border: none;
13
+ background: none;
14
+ padding: 0 var(--sys-size-3) 0 var(--sys-size-4);
15
+ font: inherit;
16
+ color: var(--sys-color-on-surface-subtle);
17
+ display: inline-flex;
18
+ align-items: center;
19
+ border-radius: var(--sys-shape-corner-extra-small);
16
20
 
17
- .title {
18
- overflow: hidden;
19
- padding-left: var(--sys-size-5);
20
- text-overflow: ellipsis;
21
- flex-grow: 0;
22
- }
21
+ &:hover:not(:disabled) {
22
+ background-color: var(--sys-color-state-hover-on-subtle);
23
+ }
23
24
 
24
- .subtitle {
25
- color: var(--sys-color-token-subtle);
26
- margin-right: 3px;
27
- overflow: hidden;
28
- padding-left: var(--sys-size-5);
29
- text-overflow: ellipsis;
30
- flex-grow: 0;
31
- }
25
+ &:active:not(:disabled) {
26
+ background-color: var(--sys-color-state-ripple-neutral-on-subtle);
27
+ }
28
+
29
+ &:focus-visible {
30
+ outline: 2px solid var(--sys-color-state-focus-ring);
31
+ outline-offset: -2px;
32
+ border-radius: var(--sys-shape-corner-extra-small);
33
+ }
34
+
35
+ & > .title {
36
+ padding-right: var(--sys-size-2);
37
+ width: 120px;
38
+ overflow: hidden;
39
+ text-overflow: ellipsis;
40
+ white-space: nowrap;
41
+ }
42
+
43
+ & > devtools-icon {
44
+ width: var(--sys-size-7);
45
+ height: var(--sys-size-7);
46
+ }
47
+
48
+ &[disabled] {
49
+ pointer-events: none;
50
+ color: var(--sys-color-state-disabled);
51
+
52
+ & > devtools-icon {
53
+ color: var(--sys-color-state-disabled);
54
+ }
55
+ }
56
+ }
57
+
58
+ .outermost-target-selector-item {
59
+ padding: var(--sys-size-2) var(--sys-size-1) var(--sys-size-2) var(--sys-size-2);
60
+ white-space: nowrap;
61
+ display: flex;
62
+ flex-direction: column;
63
+ height: 36px;
64
+ justify-content: center;
65
+ overflow-y: auto;
66
+ }
67
+
68
+ .outermost-target-selector-item .title {
69
+ overflow: hidden;
70
+ padding-left: var(--sys-size-5);
71
+ text-overflow: ellipsis;
72
+ flex-grow: 0;
73
+ }
74
+
75
+ .outermost-target-selector-item .subtitle {
76
+ color: var(--sys-color-token-subtle);
77
+ margin-right: 3px;
78
+ overflow: hidden;
79
+ padding-left: var(--sys-size-5);
80
+ text-overflow: ellipsis;
81
+ flex-grow: 0;
82
+ }
32
83
 
33
- :host(.highlighted) .subtitle {
34
- color: inherit;
84
+ devtools-menu-item[aria-selected="true"] .outermost-target-selector-item .subtitle {
85
+ color: inherit;
86
+ }
35
87
  }
@@ -146,10 +146,11 @@ const WINDOW_LOCAL_STORAGE: Common.Settings.SettingsBackingStore = {
146
146
 
147
147
  export class MainImpl {
148
148
  #readyForTestPromise = Promise.withResolvers<void>();
149
- #veStartPromise!: Promise<void>;
149
+ #veStartPromise = Promise.resolve();
150
150
  #toolbarsPromise!: Promise<void>;
151
151
  #universe!: Foundation.Universe.Universe;
152
152
  #supportsEmulation = false;
153
+ #veLogsTestMode = false;
153
154
 
154
155
  constructor(opts?: {supportsEmulation: boolean}) {
155
156
  MainImpl.instanceForTest = this;
@@ -222,31 +223,41 @@ export class MainImpl {
222
223
  const veLogging = config.devToolsVeLogging;
223
224
 
224
225
  // Used by e2e to put VE Logs into "test mode".
225
- const veLogsTestMode = Common.Settings.Settings.instance().createSetting('veLogsTestMode', false).get();
226
+ this.#veLogsTestMode = Common.Settings.Settings.instance().createSetting('veLogsTestMode', false).get();
226
227
 
227
228
  if (veLogging?.enabled) {
229
+ VisualLogging.enableLogging();
228
230
  // Note: as of https://crrev.com/c/6734500 landing, veLogging.testing is hard-coded to false.
229
231
  // But the e2e tests (test/conductor/frontend_tab.ts) use this to enable this flag for e2e tests.
230
232
  // TODO(crbug.com/432411398): remove the host config for VE logs + find a better way to set this up in e2e tests.
231
- if (veLogging?.testing || veLogsTestMode) {
233
+ if (veLogging.testing || this.#veLogsTestMode) {
232
234
  VisualLogging.setVeDebugLoggingEnabled(true, VisualLogging.DebugLoggingFormat.TEST);
233
- const options = {
234
- processingThrottler: new Common.Throttler.Throttler(0),
235
- keyboardLogThrottler: new Common.Throttler.Throttler(10),
236
- hoverLogThrottler: new Common.Throttler.Throttler(50),
237
- dragLogThrottler: new Common.Throttler.Throttler(50),
238
- clickLogThrottler: new Common.Throttler.Throttler(10),
239
- resizeLogThrottler: new Common.Throttler.Throttler(10),
240
- };
241
- this.#veStartPromise = VisualLogging.startLogging(options);
242
- } else {
243
- this.#veStartPromise = VisualLogging.startLogging();
244
235
  }
245
236
  }
246
237
 
247
238
  void this.#createAppUI();
248
239
  }
249
240
 
241
+ async #startVeLogging(): Promise<void> {
242
+ const veLogging = Root.Runtime.hostConfig.devToolsVeLogging;
243
+ if (!veLogging?.enabled) {
244
+ return;
245
+ }
246
+ if (veLogging.testing || this.#veLogsTestMode) {
247
+ const options = {
248
+ processingThrottler: new Common.Throttler.Throttler(0),
249
+ keyboardLogThrottler: new Common.Throttler.Throttler(10),
250
+ hoverLogThrottler: new Common.Throttler.Throttler(50),
251
+ dragLogThrottler: new Common.Throttler.Throttler(50),
252
+ clickLogThrottler: new Common.Throttler.Throttler(10),
253
+ resizeLogThrottler: new Common.Throttler.Throttler(10),
254
+ };
255
+ await VisualLogging.startLogging(options);
256
+ } else {
257
+ await VisualLogging.startLogging();
258
+ }
259
+ }
260
+
250
261
  #initializeGlobalsForLayoutTests(): void {
251
262
  // @ts-expect-error e2e test global
252
263
  self.Extensions ||= {};
@@ -533,6 +544,7 @@ export class MainImpl {
533
544
  inspectorView.displaySelectOverrideFolderInfobar(event.data);
534
545
  });
535
546
  this.#toolbarsPromise = inspectorView.createToolbars();
547
+ this.#veStartPromise = this.#toolbarsPromise.then(() => this.#startVeLogging());
536
548
  inspectorView.renderStatusBar(this.#universe.commentManager.isAgentAttached());
537
549
  this.#universe.commentManager.addEventListener(
538
550
  CommentManager.CommentManager.Events.AGENT_ATTACHED_CHANGED,
@@ -607,7 +619,12 @@ export class MainImpl {
607
619
 
608
620
  async #lateInitialization(): Promise<void> {
609
621
  MainImpl.time('Main._lateInitialization');
610
- PanelCommon.ExtensionServer.ExtensionServer.instance().initializeExtensions();
622
+ const extensionServer = PanelCommon.ExtensionServer.ExtensionServer.instance();
623
+ if (!extensionServer.framesWidget().isShowing()) {
624
+ extensionServer.framesWidget().markAsRoot();
625
+ extensionServer.framesWidget().show(document.body);
626
+ }
627
+ extensionServer.initializeExtensions();
611
628
  void Promise.all(Common.Runnable.lateInitializationRunnables().map(async lateInitializationLoader => {
612
629
  const runnable = await lateInitializationLoader();
613
630
  return await runnable.run();