chrome-devtools-frontend 1.0.1668390 → 1.0.1669021

package/front_end/core/host/AidaClient.ts

@@ -33,7 +33,7 @@ import * as GcaClient from './GcaClient.js';
 import type {GenerateContentResponse} from './GcaTypes.js';
 import {InspectorFrontendHostInstance} from './InspectorFrontendHost.js';
 import type {AidaClientResult, AidaCodeCompleteResult, SyncInformation} from './InspectorFrontendHostAPI.js';
-import {bindOutputStream} from './ResourceLoader.js';
+import {bindOutputStream, discardOutputStream} from './ResourceLoader.js';
 
 export * from './AidaClientTypes.js';
 
@@ -159,6 +159,10 @@ export class AidaClient {
       throw new Error('dispatchHttpRequest is not available');
     }
 
+    if (options?.signal?.aborted) {
+      throw new AidaAbortError();
+    }
+
     // Disable logging for now.
     // For context, see b/454563259#comment35.
     // We should be able to remove this ~end of April.
@@ -166,51 +170,67 @@ export class AidaClient {
       request.metadata.disable_user_content_logging = true;
     }
 
-    const stream = (() => {
-      let {promise, resolve, reject} = Promise.withResolvers<string|null>();
-      options?.signal?.addEventListener('abort', () => {
-        reject(new AidaAbortError());
-      }, {once: true});
-      return {
-        write: async(data: string): Promise<void> => {
-          resolve(data);
-          ({promise, resolve, reject} = Promise.withResolvers<string|null>());
-        },
-        close: async(): Promise<void> => {
-          resolve(null);
-        },
-        read: (): Promise<string|null> => {
-          return promise;
+    let abortListener: (() => void)|undefined;
+    let streamId: number|undefined;
+    try {
+      const stream = (() => {
+        let {promise, resolve, reject} = Promise.withResolvers<string|null>();
+        // Prevent unhandled promise rejections if stream.fail() is called after
+        // doConversation has already exited early (e.g. on recitation block or abort).
+        // Active readers calling await stream.read() will still receive the rejection.
+        promise.catch(() => {});
+        abortListener = () => {
+          reject(new AidaAbortError());
+        };
+        options?.signal?.addEventListener('abort', abortListener, {once: true});
+        return {
+          write: async(data: string): Promise<void> => {
+            resolve(data);
+            ({promise, resolve, reject} = Promise.withResolvers<string|null>());
+            promise.catch(() => {});
+          },
+          close: async(): Promise<void> => {
+            resolve(null);
+          },
+          read: (): Promise<string|null> => {
+            return promise;
+          },
+          fail: (e: Error) => reject(e),
+        };
+      })();
+      streamId = bindOutputStream(stream);
+
+      let response;
+      if (this.#gcaClient.enabled()) {
+        // Inline and remove the else clause after migration
+        response = this.#gcaClient.conversationRequest(request, streamId, options);
+      } else {
+        response = DispatchHttpRequestClient.makeHttpRequest({
+          service: SERVICE_NAME,
+          path: '/v1/aida:doConversation',
+          method: 'POST',
+          body: JSON.stringify(request),
+          streamId,
         },
-        fail: (e: Error) => reject(e),
-      };
-    })();
-    const streamId = bindOutputStream(stream);
-
-    let response;
-    if (this.#gcaClient.enabled()) {
-      // Inline and remove the else clause after migration
-      response = this.#gcaClient.conversationRequest(request, streamId, options);
-    } else {
-      response = DispatchHttpRequestClient.makeHttpRequest(
-          {
-            service: SERVICE_NAME,
-            path: '/v1/aida:doConversation',
-            method: 'POST',
-            body: JSON.stringify(request),
-            streamId,
+                                                             options);
+      }
+      response.then(
+          () => {
+            void stream.close();
           },
-          options);
+          err => {
+            debugLog('doConversation failed with error:', JSON.stringify(err));
+            stream.fail(mapError(err));
+          });
+      yield* this.#handleResponseStream(stream);
+    } finally {
+      if (options?.signal && abortListener) {
+        options.signal.removeEventListener('abort', abortListener);
+      }
+      if (streamId !== undefined) {
+        discardOutputStream(streamId);
+      }
     }
-    response.then(
-        () => {
-          void stream.close();
-        },
-        err => {
-          debugLog('doConversation failed with error:', JSON.stringify(err));
-          stream.fail(mapError(err));
-        });
-    await (yield* this.#handleResponseStream(stream));
   }
 
   async * #handleResponseStream(stream: AiStream): AsyncGenerator<DoConversationResponse, void, void> {
@@ -397,8 +417,7 @@ export class AidaClient {
     return {generatedSamples, metadata};
   }
 
-  async generateCode(request: GenerateCodeRequest, options?: {signal?: AbortSignal}):
-      Promise<GenerateCodeResponse|null> {
+  async generateCode(request: GenerateCodeRequest, options?: {signal?: AbortSignal}): Promise<GenerateCodeResponse> {
     // Disable logging for now.
     // For context, see b/454563259#comment35.
     // We should be able to remove this ~end of April.
@@ -495,8 +514,8 @@ export class HostConfigTracker extends Common.ObjectWrapper.ObjectWrapper<EventT
     return eventDescriptor;
   }
 
-  override removeEventListener(eventType: Events, listener: Common.EventTarget.EventListener<EventTypes, Events>):
-      void {
+  override removeEventListener(eventType: Events,
+                               listener: Common.EventTarget.EventListener<EventTypes, Events>): void {
     super.removeEventListener(eventType, listener);
     if (!this.hasEventListeners(eventType)) {
       clearTimeout(this.#pollTimer);

package/front_end/core/host/GcaClient.ts

@@ -77,18 +77,16 @@ export class GcaClient {
         });
   }
 
-  async completeCode(request: CompletionRequest): Promise<CompletionResponse|null> {
+  async completeCode(request: CompletionRequest): Promise<CompletionResponse> {
     const gcaRequest = aidaCompletionRequestToGcaRequest(request);
     const result = await this.#requestContent(gcaRequest);
-    const aidaResult = result ? gcaResponseToAidaCompletionResponse(result) : null;
-    return aidaResult;
+    return gcaResponseToAidaCompletionResponse(result);
   }
 
-  async generateCode(request: GenerateCodeRequest, options?: {signal?: AbortSignal}):
-      Promise<GenerateCodeResponse|null> {
+  async generateCode(request: GenerateCodeRequest, options?: {signal?: AbortSignal}): Promise<GenerateCodeResponse> {
     const gcaRequest = aidaGenerateCodeRequestToGcaRequest(request);
     const result = await this.#requestContent(gcaRequest, options);
-    return result ? gcaResponseToAidaGenerateCodeResponse(result) : null;
+    return gcaResponseToAidaGenerateCodeResponse(result);
   }
 
   async #requestContent(request: GenerateContentRequest,

package/front_end/core/host/ResourceLoader.ts

@@ -80,8 +80,10 @@ export const bindOutputStream = function(stream: Common.StringOutputStream.Outpu
 };
 
 export const discardOutputStream = function(id: number): void {
-  void _boundStreams[id].close();
-  delete _boundStreams[id];
+  if (_boundStreams[id]) {
+    void _boundStreams[id].close();
+    delete _boundStreams[id];
+  }
 };
 
 export const streamWrite = function(id: number, chunk: string): void {

package/front_end/core/root/Runtime.ts

@@ -560,10 +560,6 @@ export interface HostConfigJpegXlImageFormat {
   enabled: boolean;
 }
 
-export interface HostConfigAiAssistanceV2 {
-  enabled: boolean;
-}
-
 interface AiGeneratedTimelineLabels {
   enabled: boolean;
 }
@@ -677,7 +673,6 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAiAssistancePerformanceAgent: HostConfigAiAssistancePerformanceAgent,
   devToolsAiAssistanceAccessibilityAgent: HostConfigAiAssistanceAccessibilityAgent,
   devToolsAiAssistanceStorageAgent: HostConfigAiAssistanceStorageAgent,
-  devToolsAiAssistanceV2: HostConfigAiAssistanceV2,
   devToolsAiV2Architecture: DevToolsAiV2Architecture,
   devToolsAiCodeCompletion: HostConfigAiCodeCompletion,
   devToolsAiCodeGeneration: HostConfigAiCodeGeneration,

package/front_end/core/sdk/ConsoleModel.ts

@@ -34,6 +34,7 @@ import {
   RuntimeModel,
 } from './RuntimeModel.js';
 import {SDKModel} from './SDKModel.js';
+import {preserveConsoleLogSettingDescriptor} from './SDKSettings.js';
 import {Capability, type Target, Type} from './Target.js';
 import type {TargetManager} from './TargetManager.js';
 
@@ -287,7 +288,7 @@ export class ConsoleModel extends SDKModel<EventTypes> {
 
   private clearIfNecessary(): void {
     const settings = this.target().targetManager().settings;
-    if (!settings.moduleSetting('preserve-console-log').get()) {
+    if (!settings.resolve(preserveConsoleLogSettingDescriptor).get()) {
       this.clear();
     }
     ++this.#pageLoadSequenceNumber;
@@ -296,7 +297,7 @@ export class ConsoleModel extends SDKModel<EventTypes> {
   private primaryPageChanged(
       event: Common.EventTarget.EventTargetEvent<{frame: ResourceTreeFrame, type: PrimaryPageChangeType}>): void {
     const settings = this.target().targetManager().settings;
-    if (settings.moduleSetting('preserve-console-log').get()) {
+    if (settings.resolve(preserveConsoleLogSettingDescriptor).get()) {
       const {frame} = event.data;
       if (frame.backForwardCacheDetails.restoredFromCache) {
         this.#console.log(i18nString(UIStrings.bfcacheNavigation, {PH1: frame.url}));

package/front_end/core/sdk/DebuggerModel.ts

@@ -15,7 +15,11 @@ import {Events as ResourceTreeModelEvents, ResourceTreeModel} from './ResourceTr
 import {type EvaluationOptions, type EvaluationResult, type ExecutionContext, RuntimeModel} from './RuntimeModel.js';
 import {Script} from './Script.js';
 import {SDKModel} from './SDKModel.js';
-import {jsSourceMapsEnabledSettingDescriptor} from './SDKSettings.js';
+import {
+  jsSourceMapsEnabledSettingDescriptor,
+  pauseOnCaughtExceptionSettingDescriptor,
+  pauseOnExceptionEnabledSettingDescriptor,
+} from './SDKSettings.js';
 import {SourceMap} from './SourceMap.js';
 import {SourceMapManager} from './SourceMapManager.js';
 import {Capability, type Target} from './Target.js';
@@ -175,8 +179,10 @@ export class DebuggerModel extends SDKModel<EventTypes> {
                                  compiledURL, sourceMappingURL, payload, target.targetManager().getConsole(), script));
 
     const settings = this.target().targetManager().settings;
-    settings.moduleSetting('pause-on-exception-enabled').addChangeListener(this.pauseOnExceptionStateChanged, this);
-    settings.moduleSetting('pause-on-caught-exception').addChangeListener(this.pauseOnExceptionStateChanged, this);
+    settings.resolve(pauseOnExceptionEnabledSettingDescriptor)
+        .addChangeListener(this.pauseOnExceptionStateChanged, this);
+    settings.resolve(pauseOnCaughtExceptionSettingDescriptor)
+        .addChangeListener(this.pauseOnExceptionStateChanged, this);
     settings.moduleSetting('pause-on-uncaught-exception').addChangeListener(this.pauseOnExceptionStateChanged, this);
     settings.moduleSetting('disable-async-stack-traces').addChangeListener(this.asyncStackTracesStateChanged, this);
     settings.moduleSetting('breakpoints-active').addChangeListener(this.breakpointsActiveChanged, this);
@@ -356,7 +362,7 @@ export class DebuggerModel extends SDKModel<EventTypes> {
 
   private pauseOnExceptionStateChanged(): void {
     const settings = this.target().targetManager().settings;
-    const pauseOnCaughtEnabled = settings.moduleSetting('pause-on-caught-exception').get();
+    const pauseOnCaughtEnabled = settings.resolve(pauseOnCaughtExceptionSettingDescriptor).get();
     let state: Protocol.Debugger.SetPauseOnExceptionsRequestState;
 
     const pauseOnUncaughtEnabled = settings.moduleSetting('pause-on-uncaught-exception').get();
@@ -868,8 +874,10 @@ export class DebuggerModel extends SDKModel<EventTypes> {
       debuggerIdToModel.delete(this.#debuggerId);
     }
     const settings = this.target().targetManager().settings;
-    settings.moduleSetting('pause-on-exception-enabled').removeChangeListener(this.pauseOnExceptionStateChanged, this);
-    settings.moduleSetting('pause-on-caught-exception').removeChangeListener(this.pauseOnExceptionStateChanged, this);
+    settings.resolve(pauseOnExceptionEnabledSettingDescriptor)
+        .removeChangeListener(this.pauseOnExceptionStateChanged, this);
+    settings.resolve(pauseOnCaughtExceptionSettingDescriptor)
+        .removeChangeListener(this.pauseOnExceptionStateChanged, this);
     settings.moduleSetting('disable-async-stack-traces').removeChangeListener(this.asyncStackTracesStateChanged, this);
   }
 

package/front_end/core/sdk/SDKSettings.ts

@@ -17,3 +17,22 @@ export const cssSourceMapsEnabledSettingDescriptor: Common.Settings.SettingDescr
   defaultValue: true,
   storageType: Common.Settings.SettingStorageType.SYNCED,
 };
+
+export const preserveConsoleLogSettingDescriptor: Common.Settings.SettingDescriptor<boolean> = {
+  name: 'preserve-console-log',
+  type: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: false,
+  storageType: Common.Settings.SettingStorageType.SYNCED,
+};
+
+export const pauseOnExceptionEnabledSettingDescriptor: Common.Settings.SettingDescriptor<boolean> = {
+  name: 'pause-on-exception-enabled',
+  type: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: false,
+};
+
+export const pauseOnCaughtExceptionSettingDescriptor: Common.Settings.SettingDescriptor<boolean> = {
+  name: 'pause-on-caught-exception',
+  type: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: false,
+};

package/front_end/core/sdk/sdk-meta.ts

@@ -6,22 +6,6 @@ import * as Common from '../common/common.js';
 import * as i18n from '../i18n/i18n.js';
 
 const UIStrings = {
-  /**
-   * @description Title of a setting under the Console category that can be invoked through the Command Menu.
-   */
-  preserveLogUponNavigation: 'Keep log on navigation',
-  /**
-   * @description Title of a setting under the Console category that can be invoked through the Command Menu.
-   */
-  doNotPreserveLogUponNavigation: 'Don’t keep log on navigation',
-  /**
-   * @description Text for pausing the debugger on exceptions.
-   */
-  pauseOnExceptions: 'Pause on exceptions',
-  /**
-   * @description Title of a setting under the Debugger category that can be invoked through the Command Menu.
-   */
-  doNotPauseOnExceptions: 'Do not pause on exceptions',
   /**
    * @description Title of a setting under the Debugger category that can be invoked through the Command Menu.
    */
@@ -471,48 +455,6 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('core/sdk/sdk-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
-Common.Settings.registerSettingExtension({
-  category: Common.Settings.SettingCategory.CONSOLE,
-  storageType: Common.Settings.SettingStorageType.SYNCED,
-  title: i18nLazyString(UIStrings.preserveLogUponNavigation),
-  settingName: 'preserve-console-log',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  defaultValue: false,
-  options: [
-    {
-      value: true,
-      title: i18nLazyString(UIStrings.preserveLogUponNavigation),
-    },
-    {
-      value: false,
-      title: i18nLazyString(UIStrings.doNotPreserveLogUponNavigation),
-    },
-  ],
-});
-
-Common.Settings.registerSettingExtension({
-  category: Common.Settings.SettingCategory.DEBUGGER,
-  settingName: 'pause-on-exception-enabled',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  defaultValue: false,
-  options: [
-    {
-      value: true,
-      title: i18nLazyString(UIStrings.pauseOnExceptions),
-    },
-    {
-      value: false,
-      title: i18nLazyString(UIStrings.doNotPauseOnExceptions),
-    },
-  ],
-});
-
-Common.Settings.registerSettingExtension({
-  settingName: 'pause-on-caught-exception',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  defaultValue: false,
-});
-
 Common.Settings.registerSettingExtension({
   settingName: 'pause-on-uncaught-exception',
   settingType: Common.Settings.SettingType.BOOLEAN,

package/front_end/generated/InspectorBackendCommands.ts

@@ -1487,9 +1487,9 @@ inspectorBackend.registerCommand("WebAuthn.removeCredential", [{"name": "authent
 inspectorBackend.registerCommand("WebAuthn.clearCredentials", [{"name": "authenticatorId", "type": "string", "optional": false, "description": "", "typeRef": "WebAuthn.AuthenticatorId"}], [], "Clears all the credentials from the specified device.");
 inspectorBackend.registerCommand("WebAuthn.setUserVerified", [{"name": "authenticatorId", "type": "string", "optional": false, "description": "", "typeRef": "WebAuthn.AuthenticatorId"}, {"name": "isUserVerified", "type": "boolean", "optional": false, "description": "", "typeRef": null}], [], "Sets whether User Verification succeeds or fails for an authenticator. The default is true.");
 inspectorBackend.registerCommand("WebAuthn.setAutomaticPresenceSimulation", [{"name": "authenticatorId", "type": "string", "optional": false, "description": "", "typeRef": "WebAuthn.AuthenticatorId"}, {"name": "enabled", "type": "boolean", "optional": false, "description": "", "typeRef": null}], [], "Sets whether tests of user presence will succeed immediately (if true) or fail to resolve (if false) for an authenticator. The default is true.");
-inspectorBackend.registerCommand("WebAuthn.setCredentialProperties", [{"name": "authenticatorId", "type": "string", "optional": false, "description": "", "typeRef": "WebAuthn.AuthenticatorId"}, {"name": "credentialId", "type": "string", "optional": false, "description": "", "typeRef": null}, {"name": "backupEligibility", "type": "boolean", "optional": true, "description": "", "typeRef": null}, {"name": "backupState", "type": "boolean", "optional": true, "description": "", "typeRef": null}, {"name": "activeCmtgKeyIndex", "type": "number", "optional": true, "description": "", "typeRef": null}, {"name": "generateCmtgKeyOnNextOperation", "type": "boolean", "optional": true, "description": "", "typeRef": null}], [], "Allows setting credential properties. https://w3c.github.io/webauthn/#sctn-automation-set-credential-properties");
+inspectorBackend.registerCommand("WebAuthn.setCredentialProperties", [{"name": "authenticatorId", "type": "string", "optional": false, "description": "", "typeRef": "WebAuthn.AuthenticatorId"}, {"name": "credentialId", "type": "string", "optional": false, "description": "", "typeRef": null}, {"name": "backupEligibility", "type": "boolean", "optional": true, "description": "", "typeRef": null}, {"name": "backupState", "type": "boolean", "optional": true, "description": "", "typeRef": null}, {"name": "activeCmtgKeyIndex", "type": "number", "optional": true, "description": "", "typeRef": null}, {"name": "generateCmtgKeyOnNextOperation", "type": "boolean", "optional": true, "description": "", "typeRef": null}, {"name": "signCount", "type": "number", "optional": true, "description": "Must be equal to or greater than -1. If -1, the signature counter is removed from the credential, and every assertion operation will report a value of 0. See https://w3c.github.io/webauthn/#signature-counter", "typeRef": null}], [], "Allows setting credential properties. https://w3c.github.io/webauthn/#sctn-automation-set-credential-properties");
 inspectorBackend.registerType("WebAuthn.VirtualAuthenticatorOptions", [{"name": "protocol", "type": "string", "optional": false, "description": "", "typeRef": "WebAuthn.AuthenticatorProtocol"}, {"name": "ctap2Version", "type": "string", "optional": true, "description": "Defaults to ctap2_0. Ignored if |protocol| == u2f.", "typeRef": "WebAuthn.Ctap2Version"}, {"name": "transport", "type": "string", "optional": false, "description": "", "typeRef": "WebAuthn.AuthenticatorTransport"}, {"name": "hasResidentKey", "type": "boolean", "optional": true, "description": "Defaults to false.", "typeRef": null}, {"name": "hasUserVerification", "type": "boolean", "optional": true, "description": "Defaults to false.", "typeRef": null}, {"name": "hasLargeBlob", "type": "boolean", "optional": true, "description": "If set to true, the authenticator will support the largeBlob extension. https://w3c.github.io/webauthn#largeBlob Defaults to false.", "typeRef": null}, {"name": "hasCredBlob", "type": "boolean", "optional": true, "description": "If set to true, the authenticator will support the credBlob extension. https://fidoalliance.org/specs/fido-v2.1-rd-20201208/fido-client-to-authenticator-protocol-v2.1-rd-20201208.html#sctn-credBlob-extension Defaults to false.", "typeRef": null}, {"name": "hasMinPinLength", "type": "boolean", "optional": true, "description": "If set to true, the authenticator will support the minPinLength extension. https://fidoalliance.org/specs/fido-v2.1-ps-20210615/fido-client-to-authenticator-protocol-v2.1-ps-20210615.html#sctn-minpinlength-extension Defaults to false.", "typeRef": null}, {"name": "hasPrf", "type": "boolean", "optional": true, "description": "If set to true, the authenticator will support the prf extension. https://w3c.github.io/webauthn/#prf-extension Defaults to false.", "typeRef": null}, {"name": "hasHmacSecret", "type": "boolean", "optional": true, "description": "If set to true, the authenticator will support the hmac-secret extension. https://fidoalliance.org/specs/fido-v2.1-ps-20210615/fido-client-to-authenticator-protocol-v2.1-ps-20210615.html#sctn-hmac-secret-extension Defaults to false.", "typeRef": null}, {"name": "hasHmacSecretMc", "type": "boolean", "optional": true, "description": "If set to true, the authenticator will support the hmac-secret-mc extension. https://fidoalliance.org/specs/fido-v2.2-rd-20241003/fido-client-to-authenticator-protocol-v2.2-rd-20241003.html#sctn-hmac-secret-make-cred-extension Defaults to false.", "typeRef": null}, {"name": "hasCmtgKey", "type": "boolean", "optional": true, "description": "If set to true, the authenticator will support the cmtgKey (Credential Manager Trust Group Key) extension. https://github.com/w3c/webauthn/pull/2377 Defaults to false.", "typeRef": null}, {"name": "automaticPresenceSimulation", "type": "boolean", "optional": true, "description": "If set to true, tests of user presence will succeed immediately. Otherwise, they will not be resolved. Defaults to true.", "typeRef": null}, {"name": "isUserVerified", "type": "boolean", "optional": true, "description": "Sets whether User Verification succeeds or fails for an authenticator. Defaults to false.", "typeRef": null}, {"name": "defaultBackupEligibility", "type": "boolean", "optional": true, "description": "Credentials created by this authenticator will have the backup eligibility (BE) flag set to this value. Defaults to false. https://w3c.github.io/webauthn/#sctn-credential-backup", "typeRef": null}, {"name": "defaultBackupState", "type": "boolean", "optional": true, "description": "Credentials created by this authenticator will have the backup state (BS) flag set to this value. Defaults to false. https://w3c.github.io/webauthn/#sctn-credential-backup", "typeRef": null}]);
-inspectorBackend.registerType("WebAuthn.Credential", [{"name": "credentialId", "type": "string", "optional": false, "description": "", "typeRef": null}, {"name": "isResidentCredential", "type": "boolean", "optional": false, "description": "", "typeRef": null}, {"name": "rpId", "type": "string", "optional": true, "description": "Relying Party ID the credential is scoped to. Must be set when adding a credential.", "typeRef": null}, {"name": "privateKey", "type": "string", "optional": false, "description": "The ECDSA P-256 private key in PKCS#8 format.", "typeRef": null}, {"name": "userHandle", "type": "string", "optional": true, "description": "An opaque byte sequence with a maximum size of 64 bytes mapping the credential to a specific user.", "typeRef": null}, {"name": "signCount", "type": "number", "optional": false, "description": "Signature counter. This is incremented by one for each successful assertion. See https://w3c.github.io/webauthn/#signature-counter", "typeRef": null}, {"name": "largeBlob", "type": "string", "optional": true, "description": "The large blob associated with the credential. See https://w3c.github.io/webauthn/#sctn-large-blob-extension", "typeRef": null}, {"name": "backupEligibility", "type": "boolean", "optional": true, "description": "Assertions returned by this credential will have the backup eligibility (BE) flag set to this value. Defaults to the authenticator's defaultBackupEligibility value.", "typeRef": null}, {"name": "backupState", "type": "boolean", "optional": true, "description": "Assertions returned by this credential will have the backup state (BS) flag set to this value. Defaults to the authenticator's defaultBackupState value.", "typeRef": null}, {"name": "userName", "type": "string", "optional": true, "description": "The credential's user.name property. Equivalent to empty if not set. https://w3c.github.io/webauthn/#dom-publickeycredentialentity-name", "typeRef": null}, {"name": "userDisplayName", "type": "string", "optional": true, "description": "The credential's user.displayName property. Equivalent to empty if not set. https://w3c.github.io/webauthn/#dom-publickeycredentialuserentity-displayname", "typeRef": null}, {"name": "cmtgKeys", "type": "array", "optional": true, "description": "The CMTG keys associated with the credential.", "typeRef": "binary"}, {"name": "activeCmtgKeyIndex", "type": "number", "optional": true, "description": "The 0-based index of the active key in cmtgKeys.", "typeRef": null}, {"name": "generateCmtgKeyOnNextOperation", "type": "boolean", "optional": true, "description": "If true, the authenticator will generate a new CMTG key on the next operation.", "typeRef": null}]);
+inspectorBackend.registerType("WebAuthn.Credential", [{"name": "credentialId", "type": "string", "optional": false, "description": "", "typeRef": null}, {"name": "isResidentCredential", "type": "boolean", "optional": false, "description": "", "typeRef": null}, {"name": "rpId", "type": "string", "optional": true, "description": "Relying Party ID the credential is scoped to. Must be set when adding a credential.", "typeRef": null}, {"name": "privateKey", "type": "string", "optional": false, "description": "The ECDSA P-256 private key in PKCS#8 format.", "typeRef": null}, {"name": "userHandle", "type": "string", "optional": true, "description": "An opaque byte sequence with a maximum size of 64 bytes mapping the credential to a specific user.", "typeRef": null}, {"name": "signCount", "type": "number", "optional": true, "description": "Signature counter. Must be equal to or greater than -1. If -1, the credential won't have an associated signature counter, and every assertion operation will report a value of 0. See https://w3c.github.io/webauthn/#signature-counter", "typeRef": null}, {"name": "largeBlob", "type": "string", "optional": true, "description": "The large blob associated with the credential. See https://w3c.github.io/webauthn/#sctn-large-blob-extension", "typeRef": null}, {"name": "backupEligibility", "type": "boolean", "optional": true, "description": "Assertions returned by this credential will have the backup eligibility (BE) flag set to this value. Defaults to the authenticator's defaultBackupEligibility value.", "typeRef": null}, {"name": "backupState", "type": "boolean", "optional": true, "description": "Assertions returned by this credential will have the backup state (BS) flag set to this value. Defaults to the authenticator's defaultBackupState value.", "typeRef": null}, {"name": "userName", "type": "string", "optional": true, "description": "The credential's user.name property. Equivalent to empty if not set. https://w3c.github.io/webauthn/#dom-publickeycredentialentity-name", "typeRef": null}, {"name": "userDisplayName", "type": "string", "optional": true, "description": "The credential's user.displayName property. Equivalent to empty if not set. https://w3c.github.io/webauthn/#dom-publickeycredentialuserentity-displayname", "typeRef": null}, {"name": "cmtgKeys", "type": "array", "optional": true, "description": "The CMTG keys associated with the credential.", "typeRef": "binary"}, {"name": "activeCmtgKeyIndex", "type": "number", "optional": true, "description": "The 0-based index of the active key in cmtgKeys.", "typeRef": null}, {"name": "generateCmtgKeyOnNextOperation", "type": "boolean", "optional": true, "description": "If true, the authenticator will generate a new CMTG key on the next operation.", "typeRef": null}]);
 
 // WebMCP.
 inspectorBackend.registerEnum("WebMCP.InvocationStatus", {Completed: "Completed", Canceled: "Canceled", Error: "Error"});

package/front_end/generated/protocol.ts

@@ -20327,11 +20327,12 @@ export namespace WebAuthn {
      */
     userHandle?: binary;
     /**
-     * Signature counter. This is incremented by one for each successful
-     * assertion.
+     * Signature counter. Must be equal to or greater than -1.
+     * If -1, the credential won't have an associated signature counter, and
+     * every assertion operation will report a value of 0.
      * See https://w3c.github.io/webauthn/#signature-counter
      */
-    signCount: integer;
+    signCount?: integer;
     /**
      * The large blob associated with the credential.
      * See https://w3c.github.io/webauthn/#sctn-large-blob-extension
@@ -20464,6 +20465,13 @@ export namespace WebAuthn {
     backupState?: boolean;
     activeCmtgKeyIndex?: integer;
     generateCmtgKeyOnNextOperation?: boolean;
+    /**
+     * Must be equal to or greater than -1.
+     * If -1, the signature counter is removed from the credential, and every
+     * assertion operation will report a value of 0.
+     * See https://w3c.github.io/webauthn/#signature-counter
+     */
+    signCount?: integer;
   }
 
   /**

package/front_end/models/ai_assistance/AiUtils.ts

@@ -4,11 +4,78 @@
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
+import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 
 import {debugLog} from './debug.js';
 
+export const enum DisabledReason {
+  GEO_RESTRICTED = 'geo-restricted',
+  POLICY_RESTRICTED = 'policy-restricted',
+  WRONG_LOCALE = 'wrong-locale',
+  NOT_SUPPORTED = 'not-supported',
+}
+
+function isLocaleRestricted(): boolean {
+  try {
+    const devtoolsLocale = i18n.DevToolsLocale.DevToolsLocale.instance();
+    return !devtoolsLocale.locale.startsWith('en-');
+  } catch {
+    return false;
+  }
+}
+
+function isGeoRestricted(config?: Root.Runtime.HostConfig): boolean {
+  return config?.aidaAvailability?.blockedByGeo === true;
+}
+
+function isPolicyRestricted(config?: Root.Runtime.HostConfig): boolean {
+  return config?.aidaAvailability?.blockedByEnterprisePolicy === true;
+}
+
+function isConsoleInsightsFeatureEnabled(config?: Root.Runtime.HostConfig): boolean {
+  return config?.aidaAvailability?.enabled !== false && config?.devToolsConsoleInsights?.enabled === true;
+}
+
+export const consoleInsightsEnabledSettingDescriptor:
+    Common.Settings.ConditionalSettingDescriptor<boolean, DisabledReason[]> = {
+  name: 'console-insights-enabled',
+  type: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: false,
+  isAvailable: (config?: Root.Runtime.HostConfig): Common.Settings.SettingAvailabilityStatus<DisabledReason[]> => {
+    if (!isConsoleInsightsFeatureEnabled(config)) {
+      return {
+        status: Common.Settings.SettingAvailability.UNAVAILABLE,
+        reason: [DisabledReason.NOT_SUPPORTED],
+      };
+    }
+    const reasons: DisabledReason[] = [];
+    if (isGeoRestricted(config)) {
+      reasons.push(DisabledReason.GEO_RESTRICTED);
+    }
+    if (isPolicyRestricted(config)) {
+      reasons.push(DisabledReason.POLICY_RESTRICTED);
+    }
+    if (isLocaleRestricted()) {
+      reasons.push(DisabledReason.WRONG_LOCALE);
+    }
+    if (reasons.length > 0) {
+      return {
+        status: Common.Settings.SettingAvailability.DISABLED,
+        reason: reasons,
+      };
+    }
+    return {
+      status: Common.Settings.SettingAvailability.AVAILABLE,
+    };
+  },
+};
+
+export function isGeminiBranding(): boolean {
+  return !!Root.Runtime.hostConfig.devToolsGeminiRebranding?.enabled;
+}
+
 /**
  * Preconditions determined entirely on the DevTools frontend side (e.g. Incognito
  * mode or age restrictions) that prevent AI assistance features from running.
@@ -53,10 +120,6 @@ export function getDisabledReasons(aidaAvailability: Host.AidaClient.AidaAccessP
   return reasons;
 }
 
-export function isGeminiBranding(): boolean {
-  return !!Root.Runtime.hostConfig.devToolsGeminiRebranding?.enabled;
-}
-
 export function getIconName(): string {
   return isGeminiBranding() ? 'spark' : 'smart-assistant';
 }

package/front_end/models/ai_assistance/StorageItem.ts

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+export const EMPTY_ORIGIN = '';
+
 export class StorageItem {
   constructor(
       /**
@@ -10,12 +12,20 @@ export class StorageItem {
        */
       readonly primaryTargetOrigin: string,
       /**
-       * The origin of the selected storage or cookie item (if any).
-       * If no item is selected, this is the same as primaryTargetOrigin.
+       * The origin of the selected storage or cookie item.
+       * If empty (''), this represents a generic category-level context (e.g., all Local Storage or all Cookies).
        */
-      readonly origin: string,
+      readonly origin: string = EMPTY_ORIGIN,
   ) {
   }
+
+  get isGenericContext(): boolean {
+    return this.origin === EMPTY_ORIGIN;
+  }
+
+  static createGenericContext(primaryTargetOrigin: string, ..._args: unknown[]): StorageItem {
+    return new StorageItem(primaryTargetOrigin, EMPTY_ORIGIN);
+  }
 }
 
 export class DOMStorageItem extends StorageItem {
@@ -23,18 +33,29 @@ export class DOMStorageItem extends StorageItem {
       primaryTargetOrigin: string,
       origin: string,
       /** The storage key partition identifier used by the browser storage engine. */
-      readonly storageKey: string,
+      readonly storageKey: string|undefined,
       /** The sub-category of DOM storage: 'localStorage' or 'sessionStorage'. */
-      readonly type: string,
+      readonly type: 'localStorage'|'sessionStorage',
       /** The optional specific key of the selected item in this storage partition. */
       readonly key?: string,
   ) {
     super(primaryTargetOrigin, origin);
   }
+
+  static override createGenericContext(
+      primaryTargetOrigin: string,
+      type: 'localStorage'|'sessionStorage',
+      ): DOMStorageItem {
+    return new DOMStorageItem(primaryTargetOrigin, EMPTY_ORIGIN, undefined, type);
+  }
 }
 
 export class CookieItem extends StorageItem {
   constructor(primaryTargetOrigin: string, origin: string, readonly name?: string) {
     super(primaryTargetOrigin, origin);
   }
+
+  static override createGenericContext(primaryTargetOrigin: string): CookieItem {
+    return new CookieItem(primaryTargetOrigin, EMPTY_ORIGIN);
+  }
 }

package/front_end/models/ai_code_completion/AiCodeCompletion.ts

@@ -145,18 +145,15 @@ export class AiCodeCompletion {
   #renderingTimeout?: number;
   #aidaRequestCache?: CachedRequest;
   #lastEmptyResponseText?: string;
-  // TODO(b/445394511): Remove panel from the class
-  #panel: ContextFlavor;
   #callbacks?: Callbacks;
 
   readonly #sessionId: string = crypto.randomUUID();
   readonly #aidaClient: Host.AidaClient.AidaClient;
   readonly #serverSideLoggingEnabled: boolean;
 
-  constructor(opts: AgentOptions, panel: ContextFlavor, callbacks?: Callbacks, stopSequences?: string[]) {
+  constructor(opts: AgentOptions, callbacks?: Callbacks, stopSequences?: string[]) {
     this.#aidaClient = opts.aidaClient;
     this.#serverSideLoggingEnabled = opts.serverSideLoggingEnabled ?? false;
-    this.#panel = panel;
     this.#stopSequences = stopSequences ?? [];
     this.#callbacks = callbacks;
   }
@@ -172,15 +169,7 @@ export class AiCodeCompletion {
     // As a temporary fix for b/441221870 we are prepending a newline for each prefix.
     prefix = '\n' + prefix;
 
-    let additionalContextFiles = additionalFiles;
-    if (!additionalContextFiles) {
-      additionalContextFiles = this.#panel === ContextFlavor.CONSOLE ? [{
-        path: 'devtools-console-context.js',
-        content: consoleAdditionalContextFileContent,
-        included_reason: Host.AidaClient.Reason.RELATED_FILE,
-      }] :
-                                                                       undefined;
-    }
+    const additionalContextFiles = additionalFiles;
     return {
       client: Host.AidaClient.CLIENT_NAME,
       prefix,
@@ -384,9 +373,3 @@ export class AiCodeCompletion {
     return Boolean(aidaAvailability.enabled && AiCodeCompletion.isAiCodeCompletionStylesAvailable());
   }
 }
-
-export const enum ContextFlavor {
-  CONSOLE = 'console',  // generated code can contain console specific APIs like `$0`.
-  SOURCES = 'sources',
-  STYLES = 'styles',
-}