chrome-devtools-frontend 1.0.1668390 → 1.0.1669021

package/.agents/skills/devtools-ci/SKILL.md

@@ -0,0 +1,65 @@
+---
+name: devtools-ci
+description: >-
+  Triage and analyze Chromium/DevTools LUCI build results and trybot failures,
+  including high-level builder status, compile errors, and detailed test
+  failures. Use this to inspect trybot buildbucket (bb) results for a patchset
+  overview or to query ResultDB directly for comprehensive, actionable information
+  about specific test regressions and infrastructure issues.
+---
+
+# LUCI Build Triage & Analysis
+
+This skill provides access to specialized triage tools maintained within the
+`depot_tools` repository. These tools are used to inspect Buildbucket results
+and ResultDB test failures.
+
+## Environment & Auth Discovery
+
+- **Environment**: Always execute these scripts using **`vpython3`** instead
+  of `python3` to ensure all hermetic dependencies (like `httplib2`) are
+  satisfied.
+- **Authentication**: Use `bb auth-info` to proactively check if you are
+  logged into Buildbucket. If not, inform the user they must run `bb auth-login`.
+
+## Locating the Tools
+
+The triage scripts and their detailed documentation are located relative to
+the `depot_tools` installation:
+
+1.  **Locate Depot Tools**: Run `which gerrit_client.py` to find your local
+    `depot_tools` root.
+2.  **Navigation**:
+    - **Buildbucket (`bb_wrapper.py`)**: Found in `<DEPOT_TOOLS_ROOT>/agents/skills/buildbucket/`
+      - *Strengths*: High-level Build info (is it failing? what steps failed?),
+        compile errors, and infra issues.
+    - **Test Results (`luci_triage.py`)**: Found in `<DEPOT_TOOLS_ROOT>/agents/skills/luci-test-results/`
+      - *Strengths*: Detailed Test info (specific test case failures in
+        ResultDB).
+
+## Troubleshooting
+
+- **"No Artifacts Found"**: This usually occurs if:
+  1. The build failed so early (e.g., bot setup) that no artifacts were produced.
+  2. The build is too old and logs have been purged.
+  3. There is an authentication issue.
+  - **Fallback**: Try `bb log <build_id> <step_name>` to see the raw output
+    for the failed step.
+
+## Available Skills in Depot Tools
+
+Once you have located the `depot_tools` directory, read the following files
+to understand how to use each tool:
+
+- **`buildbucket`**: Used for high-level builder status and compile failures.
+  - Read: `<DEPOT_TOOLS_ROOT>/agents/skills/buildbucket/SKILL.md`
+- **`luci-test-results`**: Used for detailed ResultDB test failure analysis.
+  - Read: `<DEPOT_TOOLS_ROOT>/agents/skills/luci-test-results/SKILL.md`
+
+## Usage at Runtime
+
+When you need to triage a build:
+1.  Locate `depot_tools` as described above.
+2.  Read the relevant `SKILL.md` file from `depot_tools`.
+3.  Follow the instructions in that file to execute the Python scripts (e.g.,
+    `bb_wrapper.py` or `luci_triage.py`) using their absolute paths.

package/.agents/skills/gerrit-cli/SKILL.md

@@ -0,0 +1,59 @@
+---
+name: gerrit-cli
+description: >-
+  Interacts with the public Gerrit Code Review platform using depot_tools'
+  gerrit_client.py. Use this skill when asked to query public CLs, retrieve
+  file revisions, add patchset comments, vote on review labels, submit changes,
+  or abandon/restore public CLs. Do not use this skill for Google-internal
+  attention set updates or internal AI-assisted code reviews (CRUAS) which are
+  unsupported by the public API.
+---
+
+# Gerrit CLI Skill
+
+Execute public Gerrit Code Review commands using `gerrit_client.py` from
+depot_tools.
+
+## Prerequisites
+
+- **Environment**: Always execute the wrapper script using **`vpython3`** instead of `python3` to ensure all internal dependencies are satisfied.
+
+- Ensure `gerrit_client.py` is available in the system `PATH` (typically part of
+  `depot_tools`). If `gerrit_client.py` is not available in your environment,
+  stop execution immediately.
+- Use the wrapper script directly instead of an environment variable.
+  Substitute:
+  `vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py`
+  as the executable command in all examples and invocations.
+
+## Just-in-Time (JiT) Loading Guidance
+
+- Before running any Gerrit CLI command, read `references/commands.md`
+  to locate the required parameters and specific subcommand syntax.
+- Before querying public CLs, adding comments, voting, or submitting changes,
+  read `references/workflows.md` for step-by-step procedures.
+
+## Global Flags
+
+The wrapper script includes DevTools-specific defaults for `--host` and
+`--project`. You do not need to provide them unless you are targeting a
+different host or project.
+
+- **Default Host**: `https://chromium-review.googlesource.com`
+- **Default Project**: `devtools/devtools-frontend`
+- **JSON Output**: Always use the `--json_file=<path>` flag when querying
+  changes or fetching metadata to obtain structured, machine-readable output.
+
+> [!CAUTION]
+> **NEVER** use this to add patchset comments to an existing comment thread that
+> contains human reviewers in it. Using an agent to reply to a human is a
+> violation of Chromium's code of conduct.
+>
+> If the user requests this or you encounter this scenario as part of your work,
+> inform the user about which comment threads cannot be updated but otherwise
+> continue work.
+
+
+> [!NOTE]
+> This skill was adapted from the [Chromium Gerrit CLI skill](https://chromium.googlesource.com/chromium/agents/+/main/skills/gerrit-cli/)
+> (automatically rolled in from upstream).

package/.agents/skills/gerrit-cli/references/commands.md

@@ -0,0 +1,93 @@
+# Gerrit CLI Common Commands & Usage (Public)
+
+Run the tool directly using the wrapper script path with the `--help` flag:
+- `vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py --help`
+- `vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py changes --help`
+
+## Global Flags
+
+Use the following global flags for all commands:
+
+- `--host <url>` (e.g., `--host https://chromium-review.googlesource.com`).
+- `--project <project_name>` (e.g., `--project chromium/src`).
+- `--json_file <path>` (saves the structured response as a JSON file).
+
+______________________________________________________________________
+
+## Common Invocations
+
+### 1. Inspecting and Searching Changes
+
+- **Query active changes:**
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    changes \
+    --query "owner:self status:open"
+  ```
+- **View the content of a specific file in a change:**
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    content \
+    --json_file output.json \
+    --change <change_id> --revision <revision> --path <file_path>
+  ```
+- **Get related changes:**
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    relatedchanges \
+    --change <change_id> --revision <revision>
+  ```
+
+### 2. Reviewing and Voting
+
+- **Add a patchset-level comment:**
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    addpatchsetcomment \
+    --change <change_id> --revision <revision> \
+    --message "Review findings: <message>"
+  ```
+- **Vote on a review label (e.g., Code-Review +1):**
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    setlabel \
+    --change <change_id> \
+    --label Code-Review 1
+  ```
+
+### 3. Actions and Shepherding
+
+- **Submit/Merge a change:**
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    submitchange \
+    --change <change_id>
+  ```
+- **Abandon a change:**
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    abandon \
+    --change <change_id> \
+    --message "<reason>"
+  ```
+- **Restore an abandoned change:**
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    restore \
+    --change <change_id> \
+    --message "<reason>"
+  ```
+
+______________________________________________________________________
+
+## Just-in-Time Help
+
+Explore the built-in CLI help for additional subcommands or advanced syntax:
+
+- Display all top-level commands:
+  `vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py --help`
+- Display help for a specific subcommand:
+  ```bash
+  vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+    help <command>
+  ```

package/.agents/skills/gerrit-cli/references/workflows.md

@@ -0,0 +1,56 @@
+# Gerrit CLI Workflows (Public)
+
+## 1. Change List Review Workflow
+
+Execute these steps in chronological order to review a Change List (CL) when
+provided with a link or ID:
+
+1. **Query CL Metadata**: Retrieve CL details and verify its current status:
+   ```bash
+   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+     changes \
+     --query "change:<id>"
+   ```
+2. **Fetch File Contents**: Retrieve the content of specific files modified in
+   the CL:
+   ```bash
+   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+     content \
+     --change <change_id> --revision current --path <file_path>
+   ```
+3. **Analyze Local Modifications**: Inspect the fetched contents and local diffs
+   for any logic or formatting issues.
+4. **Add Review Comment**: Post a patchset-level comment containing the review
+   findings:
+   ```bash
+   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+     addpatchsetcomment \
+     --change <change_id> --revision current \
+     --message "Review findings: ..."
+   ```
+
+## 2. Shepherding & Submission Workflow
+
+Execute these steps in chronological order to approve and merge a Change List:
+
+1. **Check Related Changes**: Retrieve the status of all related changes to
+   ensure there are no unresolved blockers:
+   ```bash
+   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+     relatedchanges \
+     --change <change_id> --revision current
+   ```
+2. **Vote on Review Labels**: Apply the required Code-Review approval vote:
+   ```bash
+   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+     setlabel \
+     --change <change_id> \
+     --label Code-Review 1
+   ```
+3. **Submit Change**: Merge the change once all CQ presubmits pass and all
+   approval requirements are satisfied:
+   ```bash
+   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+     submitchange \
+     --change <change_id>
+   ```

package/.agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py

@@ -0,0 +1,47 @@
+#!/usr/bin/env python3
+# Copyright 2026 The Chromium Authors
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+"""Helper wrapper script to run gerrit_client.py from PATH."""
+
+import shutil
+import subprocess
+import sys
+
+
+def main():
+    client = shutil.which('gerrit_client.py')
+    if not client:
+        print('gerrit_client.py not found. '
+              'Is depot_tools available and added to PATH?')
+        sys.exit(1)
+
+    # DevTools specific defaults
+    default_args = [
+        '--host',
+        'https://chromium-review.googlesource.com',
+        '--project',
+        'devtools/devtools-frontend',
+    ]
+
+    # gerrit_client.py expects: <command> [options] [args]
+    # We need to extract the command from sys.argv and put it first.
+    user_args = sys.argv[1:]
+    command = []
+    other_args = []
+    for i, arg in enumerate(user_args):
+        if not arg.startswith('-'):
+            command = [arg]
+            other_args = user_args[:i] + user_args[i + 1:]
+            break
+    else:
+        other_args = user_args
+
+    full_args = command + default_args + other_args
+
+    rc = subprocess.call(['vpython3', client] + full_args)
+    sys.exit(rc)
+
+
+if __name__ == '__main__':
+    main()

package/.agents/skills/gerrit-cli/scripts/import_upstream.py

@@ -0,0 +1,230 @@
+#!/usr/bin/env python3
+# Copyright 2026 The Chromium Authors
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+"""Imports the Gerrit CLI skill from upstream and applies DevTools revisions.
+
+No external checkouts (like chromium/src) are required. The script downloads
+the skill directly from the public Git repository.
+"""
+
+import io
+import re
+import sys
+import tarfile
+import urllib.request
+from pathlib import Path
+
+UPSTREAM_URL = "https://chromium.googlesource.com/chromium/agents/+archive/refs/heads/main/skills/gerrit-cli.tar.gz"
+
+DEVTOOLS_WRAPPER_LOGIC = """    # DevTools specific defaults
+    default_args = [
+        '--host', 'https://chromium-review.googlesource.com',
+        '--project', 'devtools/devtools-frontend',
+    ]
+
+    # gerrit_client.py expects: <command> [options] [args]
+    # We need to extract the command from sys.argv and put it first.
+    user_args = sys.argv[1:]
+    command = []
+    other_args = []
+    for i, arg in enumerate(user_args):
+        if not arg.startswith('-'):
+            command = [arg]
+            other_args = user_args[:i] + user_args[i + 1:]
+            break
+    else:
+        other_args = user_args
+
+    full_args = command + default_args + other_args
+
+    rc = subprocess.call(['vpython3', client] + full_args)"""
+
+CAUTION_TEXT = """> [!CAUTION]
+> **NEVER** use this to add patchset comments to an existing comment thread that
+> contains human reviewers in it. Using an agent to reply to a human is a
+> violation of Chromium's code of conduct.
+>
+> If the user requests this or you encounter this scenario as part of your work,
+> inform the user about which comment threads cannot be updated but otherwise
+> continue work.
+"""
+
+
+def fetch_upstream_skill(target_dir: Path):
+    print(f"Downloading upstream skill from {UPSTREAM_URL}...")
+    try:
+        req = urllib.request.Request(UPSTREAM_URL,
+                                     headers={'User-Agent': 'Mozilla/5.0'})
+        with urllib.request.urlopen(req) as response:
+            tar_data = response.read()
+    except Exception as e:
+        print(f"Failed to download upstream skill: {e}")
+        sys.exit(1)
+
+    print(f"Extracting to {target_dir}...")
+    target_dir.mkdir(parents=True, exist_ok=True)
+    with tarfile.open(fileobj=io.BytesIO(tar_data), mode='r:gz') as tar:
+        tar.extractall(path=target_dir)
+
+
+def apply_devtools_revisions(target_dir: Path):
+    print("Applying DevTools-specific adaptations...")
+
+    # 1. Update gerrit_client_wrapper.py
+    wrapper_path = target_dir / "scripts" / "gerrit_client_wrapper.py"
+    if wrapper_path.exists():
+        code = wrapper_path.read_text()
+        # Remove ". All rights reserved." from license header to satisfy DevTools presubmit
+        code = code.replace(". All rights reserved.", "")
+        target_line = "    rc = subprocess.call(['vpython3', client] + sys.argv[1:])"
+        if target_line in code:
+            code = code.replace(target_line, DEVTOOLS_WRAPPER_LOGIC)
+        else:
+            # Fallback if upstream changed to python3
+            fallback_line = "    rc = subprocess.call(['python3', client] + sys.argv[1:])"
+            code = code.replace(fallback_line, DEVTOOLS_WRAPPER_LOGIC)
+        wrapper_path.write_text(code)
+        print("  - Adapted gerrit_client_wrapper.py")
+
+    # 2. Update SKILL.md
+    skill_md_path = target_dir / "SKILL.md"
+    if skill_md_path.exists():
+        content = skill_md_path.read_text()
+
+        # Re-route wrapper script path & change python3 to vpython3
+        content = content.replace(
+            "python3 agents/shared/skills/gerrit-cli/scripts/gerrit_client_wrapper.py",
+            "vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py"
+        )
+
+        # Add vpython3 environment warning under Prerequisites
+        if "- **Environment**:" not in content:
+            prereq_note = "- **Environment**: Always execute the wrapper script using **`vpython3`** instead of `python3` to ensure all internal dependencies are satisfied.\n"
+            content = content.replace("## Prerequisites\n",
+                                      f"## Prerequisites\n\n{prereq_note}")
+
+        # Replace Gotchas section with DevTools defaults info
+        global_flags_section = """## Global Flags
+
+The wrapper script includes DevTools-specific defaults for `--host` and
+`--project`. You do not need to provide them unless you are targeting a
+different host or project.
+
+- **Default Host**: `https://chromium-review.googlesource.com`
+- **Default Project**: `devtools/devtools-frontend`
+- **JSON Output**: Always use the `--json_file=<path>` flag when querying
+  changes or fetching metadata to obtain structured, machine-readable output.
+"""
+        gotchas_pattern = r"## Gotchas & Environment Constraints\n\n(?:[^\n]+\n)+"
+        content = re.sub(gotchas_pattern, global_flags_section, content)
+
+        # Add attribution note at the bottom
+        attribution = """
+> [!NOTE]
+> This skill was adapted from the [Chromium Gerrit CLI skill](https://chromium.googlesource.com/chromium/agents/+/main/skills/gerrit-cli/)
+> (automatically rolled in from upstream).
+"""
+        if "> [!NOTE]" not in content:
+            content += "\n" + attribution
+
+        skill_md_path.write_text(content)
+        print("  - Adapted SKILL.md")
+
+    # 3. Update references/commands.md and references/workflows.md
+    for filename in ["commands.md", "workflows.md"]:
+        ref_path = target_dir / "references" / filename
+        if ref_path.exists():
+            c = ref_path.read_text()
+
+            # Path & executable transformations
+            c = c.replace("python3 agents/shared/skills/gerrit-cli/",
+                          "vpython3 .agents/skills/gerrit-cli/")
+
+            # Remove redundant host/project flags since our wrapper defaults them
+            # This matches the flag and any trailing backslash & newline to keep shell syntax valid
+            c = re.sub(r'^[ \t]+--(host|project)[ \t]+\S+[ \t]*(?:\\)?\n',
+                       '',
+                       c,
+                       flags=re.M)
+
+            # Re-route positional arguments to flags for various commands.
+            # TODO(b/40292850): Simplify/remove these once CL lands upstream:
+            # https://chromium-review.googlesource.com/c/chromium/agents/+/8146436
+
+            # content
+            c = c.replace(
+                "<change_id> <revision> <file_path>",
+                "--change <change_id> --revision <revision> --path <file_path>"
+            )
+            c = c.replace(
+                "<change_id> current <file_path>",
+                "--change <change_id> --revision current --path <file_path>")
+
+            # changes (query flag is required)
+            c = c.replace('changes \\\n    "owner:self status:open"',
+                          'changes \\\n    --query "owner:self status:open"')
+            c = c.replace('changes \\\n     "change:<id>"',
+                          'changes \\\n     --query "change:<id>"')
+
+            # relatedchanges
+            c = c.replace(
+                "relatedchanges \\\n    <change_id> <revision>",
+                "relatedchanges \\\n    --change <change_id> --revision <revision>"
+            )
+            c = c.replace(
+                "relatedchanges \\\n     <change_id> current",
+                "relatedchanges \\\n     --change <change_id> --revision current"
+            )
+
+            # addpatchsetcomment
+            c = c.replace(
+                'addpatchsetcomment \\\n    --message "Review findings: <message>" \\\n    <change_id> <revision>',
+                'addpatchsetcomment \\\n    --change <change_id> --revision <revision> \\\n    --message "Review findings: <message>"'
+            )
+            c = c.replace(
+                'addpatchsetcomment \\\n     --message "Review findings: ..." \\\n     <change_id> current',
+                'addpatchsetcomment \\\n     --change <change_id> --revision current \\\n     --message "Review findings: ..."'
+            )
+
+            # setlabel
+            c = c.replace(
+                'setlabel \\\n    --label "Code-Review" \\\n    --value 1 \\\n    <change_id>',
+                'setlabel \\\n    --change <change_id> \\\n    --label Code-Review 1'
+            )
+            c = c.replace(
+                'setlabel \\\n     --label "Code-Review" \\\n     --value 1 \\\n     <change_id>',
+                'setlabel \\\n     --change <change_id> \\\n     --label Code-Review 1'
+            )
+
+            # submitchange
+            c = c.replace("submitchange \\\n    <change_id>",
+                          "submitchange \\\n    --change <change_id>")
+            c = c.replace("submitchange \\\n     <change_id>",
+                          "submitchange \\\n     --change <change_id>")
+
+            # abandon
+            c = c.replace(
+                'abandon \\\n    --message "<reason>" \\\n    <change_id>',
+                'abandon \\\n    --change <change_id> \\\n    --message "<reason>"'
+            )
+
+            # restore
+            c = c.replace(
+                'restore \\\n    --message "<reason>" \\\n    <change_id>',
+                'restore \\\n    --change <change_id> \\\n    --message "<reason>"'
+            )
+
+            ref_path.write_text(c)
+            print(f"  - Adapted references/{filename}")
+
+
+def main():
+    skill_dir = Path(__file__).parent.parent.resolve()
+    fetch_upstream_skill(skill_dir)
+    apply_devtools_revisions(skill_dir)
+    print("Upstream sync completed successfully!")
+
+
+if __name__ == "__main__":
+    main()

package/docs/contributing/infrastructure.md

@@ -257,7 +257,13 @@ because they picked up the test as it was being touched.
 
 You can skip Flake Detection for your tests by adding the `Skip-Flake-Detection`
 CL footer (see example [CL](https://crrev.com/c/6994031)). Make sure you use the
-full path to your test.
+full path to your test. If you need to skip multiple tests, you can repeat the footer:
+```
+Skip-Flake-Detection: test/e2e/foo.test.ts
+Skip-Flake-Detection: test/e2e/bar.test.ts
+```
+
+You can also skip Flake Detection for multiple tests using a glob pattern by adding the `Skip-Flake-Detection-Pattern` CL footer. For example: `Skip-Flake-Detection-Pattern: test/e2e/performance/*`.
 
 ### Common build failures