chrome-devtools-frontend 1.0.1668390 → 1.0.1669021

package/front_end/panels/sources/sources-meta.ts

@@ -18,6 +18,14 @@ import * as SettingsUI from '../../ui/settings/settings.js';
 import type * as Sources from './sources.js';
 
 const UIStrings = {
+  /**
+   * @description Text for pausing the debugger on exceptions.
+   */
+  pauseOnExceptions: 'Pause on exceptions',
+  /**
+   * @description Title of a setting under the Debugger category that can be invoked through the Command Menu.
+   */
+  doNotPauseOnExceptions: 'Do not pause on exceptions',
   /**
    * @description Command for showing the 'Sources' tool
    */
@@ -91,11 +99,11 @@ const UIStrings = {
    */
   breakpoints: 'Breakpoints',
   /**
-   * @description Title of an action under the Debugger category that can be invoked through the Command Menu
+   * @description Title of an action under the Debugger category that can be invoked through the command menu
    */
   pauseScriptExecution: 'Pause script execution',
   /**
-   * @description Title of an action under the Debugger category that can be invoked through the Command Menu
+   * @description Title of an action under the Debugger category that can be invoked through the command menu
    */
   resumeScriptExecution: 'Resume script execution',
   /**
@@ -119,75 +127,75 @@ const UIStrings = {
    */
   runSnippet: 'Run snippet',
   /**
-   * @description Text in Java Script Breakpoints Sidebar Pane of the Sources panel
+   * @description Text in JavaScript breakpoint sidebar of the Sources panel.
    */
   deactivateBreakpoints: 'Deactivate breakpoints',
   /**
-   * @description Text in Java Script Breakpoints Sidebar Pane of the Sources panel
+   * @description Text in JavaScript breakpoint sidebar of the Sources panel.
    */
   activateBreakpoints: 'Activate breakpoints',
   /**
-   * @description Title of an action in the sources tool to add to watch
+   * @description Title of an action in the sources tool to add to watch.
    */
   addSelectedTextToWatches: 'Add selected text to watches',
   /**
-   * @description Title of an action in the debugger tool to evaluate selection
+   * @description Title of an action in the debugger tool to evaluate selection.
    */
   evaluateSelectedTextInConsole: 'Evaluate selected text in console',
   /**
-   * @description Title of an action that switches files in the Sources panel
+   * @description Title of an action that switches files in the Sources panel.
    */
   switchFile: 'Switch file',
   /**
-   * @description Title of a sources panel action that renames a file
+   * @description Title of a sources panel action that renames a file.
    */
   rename: 'Rename',
   /**
-   * @description Title of an action in the sources tool to close all
+   * @description Title of an action in the sources tool to close all.
    */
   closeAll: 'Close all',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (jump to previous editing location in text editor)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (jump to previous editing location in text editor).
    */
   jumpToPreviousEditingLocation: 'Jump to previous editing location',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (jump to next editing location in text editor)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (jump to next editing location in text editor).
    */
   jumpToNextEditingLocation: 'Jump to next editing location',
   /**
-   * @description Title of an action that closes the active editor tab in the Sources panel
+   * @description Title of an action that closes the active editor tab in the Sources panel.
    */
   closeTheActiveTab: 'Close the active tab',
   /**
-   * @description Text to go to a given line
+   * @description Text to go to a given line.
    */
   goToLine: 'Go to line',
   /**
-   * @description Title of an action that opens the go to member menu
+   * @description Title of an action that opens the go to member menu.
    */
   goToAFunctionDeclarationruleSet: 'Go to a function declaration/rule set',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (toggle breakpoint in debugger)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (toggle breakpoint in debugger).
    */
   toggleBreakpoint: 'Toggle breakpoint',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (enable toggle breakpoint shortcut in debugger)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (enable toggle breakpoint shortcut in debugger).
    */
   toggleBreakpointEnabled: 'Toggle breakpoint enabled',
   /**
-   * @description Title of a sources panel action that opens the breakpoint input window
+   * @description Title of a sources panel action that opens the breakpoint input window.
    */
   toggleBreakpointInputWindow: 'Toggle breakpoint input window',
   /**
-   * @description Text to save something
+   * @description Text to save something.
    */
   save: 'Save',
   /**
-   * @description Title of an action to save all files in the Sources panel
+   * @description Title of an action to save all files in the Sources panel.
    */
   saveAll: 'Save all',
   /**
-   * @description Title of an action in the sources tool to create snippet
+   * @description Title of an action in the sources tool to create a snippet.
    */
   createNewSnippet: 'Create new snippet',
   /**
@@ -201,37 +209,37 @@ const UIStrings = {
    */
   addFolderToWorkspace: 'Add folder to workspace',
   /**
-   * @description Title of an action in the debugger tool to previous call frame
+   * @description Title of an action in the debugger tool to previous call frame.
    */
   previousCallFrame: 'Previous call frame',
   /**
-   * @description Title of an action in the debugger tool to next call frame
+   * @description Title of an action in the debugger tool to next call frame.
    */
   nextCallFrame: 'Next call frame',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (increment CSS unit by the amount passed in the placeholder in Styles pane)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (increment CSS unit by the amount passed in the placeholder in Styles pane).
    * @example {10} PH1
    */
   incrementCssUnitBy: 'Increment CSS unit by {PH1}',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (decrement CSS unit by the amount passed in the placeholder in Styles pane)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (decrement CSS unit by the amount passed in the placeholder in Styles pane).
    * @example {10} PH1
    */
   decrementCssUnitBy: 'Decrement CSS unit by {PH1}',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   searchInAnonymousAndContent: 'Search in anonymous and content scripts',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   doNotSearchInAnonymousAndContent: 'Do not search in anonymous and content scripts',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   automaticallyRevealFilesIn: 'Automatically reveal files in sidebar',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   doNotAutomaticallyRevealFilesIn: 'Do not automatically reveal files in sidebar',
   /**
@@ -243,7 +251,7 @@ const UIStrings = {
    */
   tabMovesFocus: 'Tab moves focus',
   /**
-   * @description Title of a setting that can be invoked through the Command Menu.
+   * @description Title of a setting that can be invoked through the command menu.
    *'tab moves focus' is the name of the setting, which means that when the user
    *hits the tab key, the focus in the UI will be moved to the next part of the
    *text editor, as opposed to inserting a tab character into the text in the
@@ -251,7 +259,7 @@ const UIStrings = {
    */
   enableTabMovesFocus: 'Enable tab moves focus',
   /**
-   * @description Title of a setting that can be invoked through the Command Menu.
+   * @description Title of a setting that can be invoked through the command menu.
    *'tab moves focus' is the name of the setting, which means that when the user
    *hits the tab key, the focus in the UI will be moved to the next part of the
    *text editor, as opposed to inserting a tab character into the text in the
@@ -259,79 +267,79 @@ const UIStrings = {
    */
   disableTabMovesFocus: 'Disable tab moves focus',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   detectIndentation: 'Detect indentation',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   doNotDetectIndentation: 'Do not detect indentation',
   /**
-   * @description Title of a setting under Sources category that can be invoked through the Command Menu.
+   * @description Title of a setting under Sources category that can be invoked through the command menu.
    *This setting turns on the automatic formatting of source files in the Sources panel that are detected
    *to be minified.
    */
   automaticallyPrettyPrintMinifiedSources: 'Automatically pretty print minified sources',
   /**
-   * @description Title of a setting under Sources category that can be invoked through the Command Menu.
+   * @description Title of a setting under Sources category that can be invoked through the command menu.
    *This setting turns off the automatic formatting of source files in the Sources panel that are detected
    *to be minified.
    */
   doNotAutomaticallyPrettyPrintMinifiedSources: 'Do not automatically pretty print minified sources',
   /**
-   * @description Text for autocompletion
+   * @description Text for autocompletion.
    */
   autocompletion: 'Autocompletion',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   enableAutocompletion: 'Enable autocompletion',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   disableAutocompletion: 'Disable autocompletion',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   bracketClosing: 'Auto closing brackets',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   enableBracketClosing: 'Enable auto closing brackets',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   disableBracketClosing: 'Disable auto closing brackets',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   bracketMatching: 'Bracket matching',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   enableBracketMatching: 'Enable bracket matching',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   disableBracketMatching: 'Disable bracket matching',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   codeFolding: 'Code folding',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   enableCodeFolding: 'Enable code folding',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   disableCodeFolding: 'Disable code folding',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   showWhitespaceCharacters: 'Show whitespace characters:',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   doNotShowWhitespaceCharacters: 'Do not show whitespace characters',
   /**
@@ -340,84 +348,84 @@ const UIStrings = {
    */
   none: 'None',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   showAllWhitespaceCharacters: 'Show all whitespace characters',
   /**
-   * @description Text for everything
+   * @description Text for everything.
    */
   all: 'All',
   /**
-   * @description Title of a setting under the Sources category that can be invoked through the Command Menu
+   * @description Title of a setting under the Sources category that can be invoked through the command menu.
    */
   showTrailingWhitespaceCharacters: 'Show trailing whitespace characters',
   /**
-   * @description A drop-down menu option to show trailing whitespace characters
+   * @description A drop-down menu option to show trailing whitespace characters.
    */
   trailing: 'Trailing',
   /**
-   * @description Title of a setting under the Sources category
+   * @description Title of a setting under the Sources category.
    */
   variableValuesInlineWhile: 'Variable values inline',
   /**
-   * @description Title of an option under the Sources category that can be invoked through the Command Menu
+   * @description Title of an option under the Sources category that can be invoked through the command menu.
    */
   displayVariableValuesInlineWhile: 'Display variable values inline while debugging',
   /**
-   * @description Title of an option under the Sources category that can be invoked through the Command Menu
+   * @description Title of an option under the Sources category that can be invoked through the command menu.
    */
   doNotDisplayVariableValuesInline: 'Don’t show variable values inline',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   allowScrollingPastEndOfFile: 'Allow scrolling past end of file',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   disallowScrollingPastEndOfFile: 'Disallow scrolling past end of file',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   wasmAutoStepping: 'Wasm auto-stepping bytecode',
   /**
-   * @description Tooltip text for a setting that controls Wasm will try to skip wasm bytecode
+   * @description Tooltip text for a setting that controls Wasm will try to skip wasm bytecode.
    */
   wasmAutoSteppingInfo: 'When debugging Wasm with debug information, try to skip wasm bytecode',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   enableWasmAutoStepping: 'Enable Wasm auto-stepping',
   /**
-   * @description Title of a setting under the Sources category in Settings
+   * @description Title of a setting under the Sources category in Settings.
    */
   disableWasmAutoStepping: 'Disable Wasm auto-stepping',
 
   /**
-   * @description Text for command prefix of go to a given line or symbol
+   * @description Text for command prefix of go to a given line or symbol.
    */
   goTo: 'Go to',
   /**
-   * @description Text for command suggestion of go to a given line
+   * @description Text for command suggestion of go to a given line.
    */
   line: 'Line',
   /**
-   * @description Text for command suggestion of go to a given symbol
+   * @description Text for command suggestion of go to a given symbol.
    */
   symbol: 'Symbol',
   /**
-   * @description Text for help title of go to symbol menu
+   * @description Text for help title of go to symbol menu.
    */
   goToSymbol: 'Go to symbol',
   /**
-   * @description Text for command prefix of open a file
+   * @description Text for command prefix of open a file.
    */
   open: 'Open',
   /**
-   * @description Text for command suggestion of open a file
+   * @description Text for command suggestion of open a file.
    */
   file: 'File',
   /**
-   * @description Text for help title of open file menu
+   * @description Text for help title of open file menu.
    */
   openFile: 'Open file',
   /**
@@ -433,15 +441,15 @@ const UIStrings = {
    */
   enableAutoFocusOnDebuggerPaused: 'Focus Sources panel when triggering a breakpoint',
   /**
-   * @description Title of an action to reveal the active file in the navigator sidebar of the Sources panel
+   * @description Title of an action to reveal the active file in the navigator sidebar of the Sources panel.
    */
   revealActiveFileInSidebar: 'Reveal active file in navigator sidebar',
   /**
-   * @description Text for command of toggling navigator sidebar in Sources panel
+   * @description Text for command of toggling navigator sidebar in Sources panel.
    */
   toggleNavigatorSidebar: 'Toggle navigator sidebar',
   /**
-   * @description Text for command of toggling debugger sidebar in Sources panel
+   * @description Text for command of toggling debugger sidebar in Sources panel.
    */
   toggleDebuggerSidebar: 'Toggle debugger sidebar',
   /**
@@ -1108,6 +1116,14 @@ UI.ActionRegistration.registerActionExtension({
         UI.ActionRegistration.KeybindSet.VS_CODE,
       ],
     },
+    {
+      platform: UI.ActionRegistration.Platforms.MAC,
+      shortcut: 'Meta+g',
+      keybindSets: [
+        UI.ActionRegistration.KeybindSet.DEVTOOLS_DEFAULT,
+        UI.ActionRegistration.KeybindSet.VS_CODE,
+      ],
+    },
   ],
 });
 
@@ -1327,6 +1343,10 @@ UI.ActionRegistration.registerActionExtension({
     {
       shortcut: 'Ctrl+,',
     },
+    {
+      platform: UI.ActionRegistration.Platforms.MAC,
+      shortcut: 'Meta+,',
+    },
   ],
 });
 
@@ -1345,6 +1365,10 @@ UI.ActionRegistration.registerActionExtension({
     {
       shortcut: 'Ctrl+.',
     },
+    {
+      platform: UI.ActionRegistration.Platforms.MAC,
+      shortcut: 'Meta+.',
+    },
   ],
 });
 
@@ -1567,6 +1591,20 @@ SettingsUI.SettingUIRegistration.register(SDK.SDKSettings.cssSourceMapsEnabledSe
   ],
 });
 
+SettingsUI.SettingUIRegistration.register(SDK.SDKSettings.pauseOnExceptionEnabledSettingDescriptor, {
+  category: Common.Settings.SettingCategory.DEBUGGER,
+  options: [
+    {
+      value: true,
+      title: i18nLazyString(UIStrings.pauseOnExceptions),
+    },
+    {
+      value: false,
+      title: i18nLazyString(UIStrings.doNotPauseOnExceptions),
+    },
+  ],
+});
+
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.SOURCES,
   storageType: Common.Settings.SettingStorageType.SYNCED,

package/front_end/panels/sources/sources.ts

@@ -4,7 +4,6 @@
 
 import * as AddSourceMapURLDialog from './AddSourceMapURLDialog.js';
 import * as AiCodeCompletionPlugin from './AiCodeCompletionPlugin.js';
-import * as AiWarningInfobarPlugin from './AiWarningInfobarPlugin.js';
 import * as BreakpointEditDialog from './BreakpointEditDialog.js';
 import * as BreakpointsView from './BreakpointsView.js';
 import * as BreakpointsViewUtils from './BreakpointsViewUtils.js';
@@ -39,7 +38,6 @@ import * as WatchExpressionsSidebarPane from './WatchExpressionsSidebarPane.js';
 export {
   AddSourceMapURLDialog,
   AiCodeCompletionPlugin,
-  AiWarningInfobarPlugin,
   BreakpointEditDialog,
   BreakpointsView,
   BreakpointsViewUtils,

package/front_end/panels/timeline/TimelineHistoryManager.ts

@@ -49,6 +49,12 @@ const UIStrings = {
    * @example {2} PH2
    */
   sD: '{PH1} #{PH2}',
+  /**
+   * @description Text in Timeline History Manager showing custom title alongside domain sequence number
+   * @example {Custom Profile} PH1
+   * @example {example.com #2} PH2
+   */
+  customTitleWithSequence: '{PH1} ({PH2})',
   /**
    * @description Accessible label for the timeline session selection menu
    */
@@ -346,7 +352,8 @@ export class TimelineHistoryManager {
     const domain = parsedURL ? parsedURL.host : '';
 
     const sequenceNumber = this.nextNumberByDomain.get(domain) || 1;
-    const titleWithSequenceNumber = i18nString(UIStrings.sD, {PH1: domain, PH2: sequenceNumber});
+    const titleWithSequenceNumber =
+        domain ? i18nString(UIStrings.sD, {PH1: domain, PH2: sequenceNumber}) : `#${sequenceNumber}`;
     this.nextNumberByDomain.set(domain, sequenceNumber + 1);
 
     const preview = document.createElement('div');
@@ -354,16 +361,20 @@ export class TimelineHistoryManager {
     preview.classList.add('vbox');
     preview.setAttribute('jslog', `${VisualLogging.dropDown('timeline.history-item').track({click: true})}`);
     preview.style.width = `${previewWidth}px`;
+    const customTitle = parsedTrace.metadata.title;
+    const title = customTitle ?
+        i18nString(UIStrings.customTitleWithSequence, {PH1: customTitle, PH2: titleWithSequenceNumber}) :
+        titleWithSequenceNumber;
     const data = {
       preview,
-      title: titleWithSequenceNumber,
+      title,
       lastUsed: Date.now(),
     };
     parsedTraceIndexToPerformancePreviewData.set(parsedTraceIndex, data);
 
     // eslint-disable-next-line @devtools/no-lit-render-outside-of-view
     render(html`
-      ${this.#renderTextDetails(parsedTrace.metadata, domain)}
+      ${this.#renderTextDetails(parsedTrace.metadata, title)}
       <div class="hbox">
         ${this.#renderScreenshotThumbnail(filmStrip)}
         ${this.#buildOverview(parsedTrace)}