chrome-devtools-frontend 1.0.1581708 → 1.0.1583146

package/front_end/panels/network/RequestConditionsDrawer.ts

@@ -10,7 +10,6 @@ import '../../ui/components/tooltips/tooltips.js';
 import type * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Logs from '../../models/logs/logs.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
@@ -28,34 +27,18 @@ const {ref, live} = Directives;
 const {widgetConfig} = UI.Widget;
 
 const UIStrings = {
-  /**
-   * @description Text to enable blocking of network requests
-   */
-  enableNetworkRequestBlocking: 'Enable network request blocking',
   /**
    * @description Text to enable blocking of network requests
    */
   enableBlockingAndThrottling: 'Enable blocking and throttling',
-  /**
-   * @description Tooltip text that appears when hovering over the plus button in the Blocked URLs Pane of the Network panel
-   */
-  addPattern: 'Add pattern',
   /**
    * @description Tooltip text that appears when hovering over the plus button in the Blocked URLs Pane of the Network panel
    */
   addRule: 'Add rule',
-  /**
-   * @description Accessible label for the button to add request blocking patterns in the network request blocking tool
-   */
-  addNetworkRequestBlockingPattern: 'Add network request blocking pattern',
   /**
    * @description Accessible label for the button to add request blocking patterns in the network request blocking tool
    */
   addPatternLabel: 'Add network request throttling or blocking pattern',
-  /**
-   * @description Text that shows in the network request blocking panel if no pattern has yet been added.
-   */
-  noNetworkRequestsBlocked: 'No blocked network requests',
   /**
    * @description Text that shows in the network request blocking panel if no pattern has yet been added.
    */
@@ -66,25 +49,11 @@ const UIStrings = {
    */
   noThrottlingOrBlockingPattern:
       `To throttle or block a network request, add a rule here manually or via the network panel's context menu. {PH1}`,
-  /**
-   * @description Text that shows  in the network request blocking panel if no pattern has yet been added.
-   * @example {Add pattern} PH1
-   */
-  addPatternToBlock: 'Add a pattern by clicking on the "{PH1}" button.',
-  /**
-   * @description Text in Blocked URLs Pane of the Network panel
-   * @example {4} PH1
-   */
-  dBlocked: '{PH1} blocked',
   /**
    * @description Text in Blocked URLs Pane of the Network panel
    * @example {4} PH1
    */
   dAffected: '{PH1} affected',
-  /**
-   * @description Text in Blocked URLs Pane of the Network panel
-   */
-  textPatternToBlockMatching: 'Text pattern to block matching requests; use * for wildcard',
   /**
    * @description Text in Blocked URLs Pane of the Network panel
    */
@@ -178,7 +147,6 @@ interface ViewInput {
 }
 type View = (input: ViewInput, output: object, target: HTMLElement) => void;
 export const DEFAULT_VIEW: View = (input, output, target) => {
-  const individualThrottlingEnabled = Boolean(Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled);
   render(
       // clang-format off
     html`
@@ -187,31 +155,24 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
         ?checked=${input.enabled}
         @click=${input.toggleEnabled}
         .jslogContext=${'network.enable-request-blocking'}>
-        ${individualThrottlingEnabled ? i18nString(UIStrings.enableBlockingAndThrottling)
-                                      : i18nString(UIStrings.enableNetworkRequestBlocking)}
+        ${i18nString(UIStrings.enableBlockingAndThrottling)}
       </devtools-checkbox>
       <div class="toolbar-divider"></div>
       <devtools-button ${bindToAction('network.add-network-request-blocking-pattern')}></devtools-button>
       <devtools-button ${bindToAction('network.remove-all-network-request-blocking-patterns')}></devtools-button>
     </devtools-toolbar>
     <div class=empty-state ${ref(e => input.list.setEmptyPlaceholder(e ?? null))}>
-      <span class=empty-state-header>${individualThrottlingEnabled
-                                       ? i18nString(UIStrings.noPattern)
-                                       : i18nString(UIStrings.noNetworkRequestsBlocked)}</span>
+      <span class=empty-state-header>${i18nString(UIStrings.noPattern)}</span>
       <div class=empty-state-description>
-        ${individualThrottlingEnabled
-        ? uiI18n.getFormatLocalizedStringTemplate(str_, UIStrings.noThrottlingOrBlockingPattern, {PH1: learnMore()})
-        : html`<span>${i18nString(UIStrings.addPatternToBlock,
-                                  {PH1: i18nString(UIStrings.addPattern)})}</span>${learnMore()}`}
+        ${uiI18n.getFormatLocalizedStringTemplate(str_, UIStrings.noThrottlingOrBlockingPattern, {PH1: learnMore()})}
       </div>
       <devtools-button
         @click=${input.addPattern}
         class=add-button
         .jslogContext=${'network.add-network-request-blocking-pattern'}
-        title=${individualThrottlingEnabled ? i18nString(UIStrings.addPatternLabel)
-                                                 : i18nString(UIStrings.addNetworkRequestBlockingPattern)}
+        title=${i18nString(UIStrings.addPatternLabel)}
         .variant=${Buttons.Button.Variant.TONAL}>
-          ${individualThrottlingEnabled ? i18nString(UIStrings.addRule) : i18nString(UIStrings.addPattern)}
+          ${i18nString(UIStrings.addRule)}
       </devtools-button>
     </div>
     <devtools-widget .widgetConfig=${UI.Widget.widgetConfig(UI.Widget.VBox)}>
@@ -227,35 +188,11 @@ interface AffectedCountViewInput {
 }
 type AffectedCountView = (input: AffectedCountViewInput, output: object, target: HTMLElement) => void;
 export const AFFECTED_COUNT_DEFAULT_VIEW: AffectedCountView = (input, output, target) => {
-  if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-    render(html`${i18nString(UIStrings.dAffected, {PH1: input.count})}`, target);
-  } else {
-    render(html`${i18nString(UIStrings.dBlocked, {PH1: input.count})}`, target);
-  }
+  render(html`${i18nString(UIStrings.dAffected, {PH1: input.count})}`, target);
 };
 
 function matchesUrl(conditions: SDK.NetworkManager.RequestCondition, url: string): boolean {
-  function matchesPattern(pattern: string, url: string): boolean {
-    let pos = 0;
-    const parts = pattern.split('*');
-    for (let index = 0; index < parts.length; index++) {
-      const part = parts[index];
-      if (!part.length) {
-        continue;
-      }
-      pos = url.indexOf(part, pos);
-      if (pos === -1) {
-        return false;
-      }
-      pos += part.length;
-    }
-    return true;
-  }
-
-  return Boolean(
-      Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled ?
-          conditions.originalOrUpgradedURLPattern?.test(url) :
-          (conditions.wildcardURL && matchesPattern(conditions.wildcardURL, url)));
+  return Boolean(conditions.originalOrUpgradedURLPattern?.test(url));
 }
 
 export class AffectedCountWidget extends UI.Widget.Widget {
@@ -290,9 +227,8 @@ export class AffectedCountWidget extends UI.Widget.Widget {
       return;
     }
 
-    const count = !Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled || this.#condition.isBlocking ?
-        this.#drawer.blockedRequestsCount(this.#condition) :
-        this.#drawer.throttledRequestsCount(this.#condition);
+    const count = this.#condition.isBlocking ? this.#drawer.blockedRequestsCount(this.#condition) :
+                                               this.#drawer.throttledRequestsCount(this.#condition);
 
     this.#view({count}, {}, this.element);
   }
@@ -420,23 +356,22 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
 
     const {enabled, originalOrUpgradedURLPattern, constructorStringOrWildcardURL, wildcardURL} = condition;
 
-    if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-      const moveUp = (e: Event): void => {
-        if (this.manager.requestConditions.conditionsEnabled) {
-          UI.ARIAUtils.LiveAnnouncer.status(i18nString(UIStrings.patternMovedUp));
-          e.consume(true);
-          this.manager.requestConditions.increasePriority(condition);
-        }
-      };
-      const moveDown = (e: Event): void => {
-        if (this.manager.requestConditions.conditionsEnabled) {
-          UI.ARIAUtils.LiveAnnouncer.status(i18nString(UIStrings.patternMovedDown));
-          e.consume(true);
-          this.manager.requestConditions.decreasePriority(condition);
-        }
-      };
-      render(
-          // clang-format off
+    const moveUp = (e: Event): void => {
+      if (this.manager.requestConditions.conditionsEnabled) {
+        UI.ARIAUtils.LiveAnnouncer.status(i18nString(UIStrings.patternMovedUp));
+        e.consume(true);
+        this.manager.requestConditions.increasePriority(condition);
+      }
+    };
+    const moveDown = (e: Event): void => {
+      if (this.manager.requestConditions.conditionsEnabled) {
+        UI.ARIAUtils.LiveAnnouncer.status(i18nString(UIStrings.patternMovedDown));
+        e.consume(true);
+        this.manager.requestConditions.decreasePriority(condition);
+      }
+    };
+    render(
+        // clang-format off
         html`
     <input class=blocked-url-checkbox
       @change=${toggle}
@@ -512,23 +447,8 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
     <devtools-widget
       ?disabled=${!editable || !originalOrUpgradedURLPattern}
       .widgetConfig=${widgetConfig(AffectedCountWidget, {condition, drawer: this})}></devtools-widget>`,
-          // clang-format on
-          element);
-    } else {
-      render(
-          // clang-format off
-        html`
-    <input class=blocked-url-checkbox
-      @change=${toggle}
-      type=checkbox
-      .checked=${condition.enabled}
-      .disabled=${!editable}
-      jslog=${VisualLogging.toggle().track({ change: true })}>
-    <div @click=${toggle} class=blocked-url-label>${wildcardURL}</div>
-    <devtools-widget .widgetConfig=${widgetConfig(AffectedCountWidget, {condition, drawer: this})}></devtools-widget>`,
-          // clang-format on
-          element);
-    }
+        // clang-format on
+        element);
   }
 
   private toggleEnabled(): void {
@@ -543,9 +463,7 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
 
   beginEdit(pattern: SDK.NetworkManager.RequestCondition): UI.ListWidget.Editor<SDK.NetworkManager.RequestCondition> {
     this.editor = this.createEditor();
-    this.editor.control('url').value = Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled ?
-        pattern.constructorStringOrWildcardURL :
-        pattern.wildcardURL ?? '';
+    this.editor.control('url').value = pattern.constructorStringOrWildcardURL;
     return this.editor;
   }
 
@@ -553,9 +471,7 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
       item: SDK.NetworkManager.RequestCondition, editor: UI.ListWidget.Editor<SDK.NetworkManager.RequestCondition>,
       isNew: boolean): void {
     const constructorString = editor.control('url').value as SDK.NetworkManager.URLPatternConstructorString;
-    const pattern = Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled ?
-        SDK.NetworkManager.RequestURLPattern.create(constructorString) :
-        constructorString;
+    const pattern = SDK.NetworkManager.RequestURLPattern.create(constructorString);
     if (!pattern) {
       throw new Error('Failed to parse pattern');
     }
@@ -574,14 +490,10 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
     const content = editor.contentElement();
     const titles = content.createChild('div', 'blocked-url-edit-row');
     const label = titles.createChild('label');
-    if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-      const learnMore = Link.create(PATTERN_API_DOCS_URL, i18nString(UIStrings.learnMore), undefined, 'learn-more');
-      learnMore.title = i18nString(UIStrings.learnMoreLabel);
-      titles.append('\xA0', learnMore);
-      label.textContent = i18nString(UIStrings.textEditPattern);
-    } else {
-      label.textContent = i18nString(UIStrings.textPatternToBlockMatching);
-    }
+    const learnMore = Link.create(PATTERN_API_DOCS_URL, i18nString(UIStrings.learnMore), undefined, 'learn-more');
+    learnMore.title = i18nString(UIStrings.learnMoreLabel);
+    titles.append('\xA0', learnMore);
+    label.textContent = i18nString(UIStrings.textEditPattern);
     const fields = content.createChild('div', 'blocked-url-edit-row');
     const validator =
         (_item: SDK.NetworkManager.RequestCondition, _index: number, input: UI.ListWidget.EditorControl): {
@@ -594,14 +506,12 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
           if (this.manager.requestConditions.has(input.value)) {
             return {errorMessage: i18nString(UIStrings.patternAlreadyExists), valid: false};
           }
-          if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-            const isValid = SDK.NetworkManager.RequestURLPattern.isValidPattern(input.value);
-            switch (isValid) {
-              case SDK.NetworkManager.RequestURLPatternValidity.FAILED_TO_PARSE:
-                return {errorMessage: i18nString(UIStrings.patternFailedToParse), valid: false};
-              case SDK.NetworkManager.RequestURLPatternValidity.HAS_REGEXP_GROUPS:
-                return {errorMessage: i18nString(UIStrings.patternFailedWithRegExpGroups), valid: false};
-            }
+          const isValid = SDK.NetworkManager.RequestURLPattern.isValidPattern(input.value);
+          switch (isValid) {
+            case SDK.NetworkManager.RequestURLPatternValidity.FAILED_TO_PARSE:
+              return {errorMessage: i18nString(UIStrings.patternFailedToParse), valid: false};
+            case SDK.NetworkManager.RequestURLPatternValidity.HAS_REGEXP_GROUPS:
+              return {errorMessage: i18nString(UIStrings.patternFailedWithRegExpGroups), valid: false};
           }
           return {valid: true, errorMessage: undefined};
         };
@@ -613,8 +523,7 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
 
   update(): void {
     const enabled = this.manager.requestConditions.conditionsEnabled;
-    const newItems = Array.from(this.manager.requestConditions.conditions.filter(
-        pattern => Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled || pattern.wildcardURL));
+    const newItems = Array.from(this.manager.requestConditions.conditions);
 
     let oldIndex = 0;
     for (; oldIndex < newItems.length; ++oldIndex) {

package/front_end/panels/network/RequestInitiatorView.ts

@@ -37,7 +37,7 @@ const str_ = i18n.i18n.registerUIStrings('panels/network/RequestInitiatorView.ts
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 export interface ViewInput {
   initiatorGraph: Logs.NetworkLog.InitiatorGraph;
-  hasStackTrace: boolean;
+  stackTrace: StackTrace.StackTrace.StackTrace|null;
   request: SDK.NetworkRequest.NetworkRequest;
   linkifier: Components.Linkifier.Linkifier;
   target?: SDK.Target.Target;
@@ -45,7 +45,7 @@ export interface ViewInput {
 
 export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLElement): void => {
   const hasInitiatorData =
-      input.initiatorGraph.initiators.size > 1 || input.initiatorGraph.initiated.size > 1 || input.hasStackTrace;
+      input.initiatorGraph.initiators.size > 1 || input.initiatorGraph.initiated.size > 1 || input.stackTrace;
 
   if (!hasInitiatorData) {
     render(
@@ -59,6 +59,9 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
   }
 
   const renderStackTraceSection = (): Lit.TemplateResult => {
+    if (!input.stackTrace) {
+      return html`${nothing}`;
+    }
     return html`
       <li role="treeitem" class="request-initiator-view-section-title" aria-expanded="true">
         ${i18nString(UIStrings.requestCallStack)}
@@ -67,7 +70,8 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
             <devtools-widget .widgetConfig=${widgetConfig(Components.JSPresentationUtils.StackTracePreviewContent, {
       target: input.target,
       linkifier: input.linkifier,
-      options: {runtimeStackTrace: input.request.initiator()?.stack, tabStops: true}
+      options: {tabStops: true},
+      stackTrace: input.stackTrace,
     })}></devtools-widget>
           </li>
         </ul>
@@ -146,7 +150,7 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
           ${requestInitiatorViewTreeStyles}
         </style>
         <ul role="tree">
-           ${input.hasStackTrace ? renderStackTraceSection() : Lit.nothing}
+           ${renderStackTraceSection()}
            ${
               (input.initiatorGraph.initiators.size > 1 || input.initiatorGraph.initiated.size > 1) ?
                   renderInitiatorChain(input.initiatorGraph) :
@@ -198,15 +202,22 @@ export class RequestInitiatorView extends UI.Widget.VBox {
     return {preview, stackTrace};
   }
 
-  override performUpdate(): void {
+  override async performUpdate(): Promise<void> {
     const initiatorGraph = Logs.NetworkLog.NetworkLog.instance().initiatorGraphForRequest(this.request);
-    const hasStackTrace = !!this.request.initiator()?.stack;
+    const targetManager = SDK.TargetManager.TargetManager.instance();
     const networkManager = SDK.NetworkManager.NetworkManager.forRequest(this.request);
-    const target = networkManager ? networkManager.target() : undefined;
+    const target = networkManager?.target() ?? targetManager.primaryPageTarget() ?? targetManager.rootTarget();
+
+    const rawStack = this.request.initiator()?.stack;
+    let stackTrace: StackTrace.StackTrace.StackTrace|null = null;
+    if (rawStack && target) {
+      stackTrace = await Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance()
+                       .createStackTraceFromProtocolRuntime(rawStack, target);
+    }
 
     const viewInput: ViewInput = {
       initiatorGraph,
-      hasStackTrace,
+      stackTrace,
       request: this.request,
       linkifier: this.linkifier,
       target: target || undefined,

package/front_end/panels/network/network-meta.ts

@@ -23,18 +23,10 @@ const UIStrings = {
    * @description Title of the Network tool
    */
   network: 'Network',
-  /**
-   * @description Command for showing the 'Network request blocking' tool
-   */
-  showNetworkRequestBlocking: 'Show Network request blocking',
   /**
    * @description Command for showing the 'Network request blocking' tool
    */
   showRequestConditions: 'Show Request conditions',
-  /**
-   * @description Title of the 'Network request blocking' tool in the bottom drawer
-   */
-  networkRequestBlocking: 'Network request blocking',
   /**
    * @description Title of the 'Request conditions' tool in the bottom drawer
    */
@@ -123,14 +115,6 @@ const UIStrings = {
    * @description Title of a button for clearing the network log
    */
   clear: 'Clear network log',
-  /**
-   * @description Title of an action in the Network request blocking panel to add a new URL pattern to the blocklist.
-   */
-  addNetworkRequestBlockingPattern: 'Add network request blocking pattern',
-  /**
-   * @description Title of an action in the Network request blocking panel to clear all URL patterns.
-   */
-  removeAllNetworkRequestBlockingPatterns: 'Remove all network request blocking patterns',
   /**
    * @description Title of an action in the Network request blocking panel to add a new URL pattern to the blocklist.
    */
@@ -190,15 +174,11 @@ UI.ViewManager.registerViewExtension({
   },
 });
 
-const individualThrottlingEnabled = (): boolean =>
-    Boolean(Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled);
 UI.ViewManager.registerViewExtension({
   location: UI.ViewManager.ViewLocationValues.DRAWER_VIEW,
   id: 'network.blocked-urls',
-  commandPrompt: () => individualThrottlingEnabled() ? i18nString(UIStrings.showRequestConditions) :
-                                                       i18nString(UIStrings.showNetworkRequestBlocking),
-  title: () => individualThrottlingEnabled() ? i18nString(UIStrings.networkRequestConditions) :
-                                               i18nString(UIStrings.networkRequestBlocking),
+  commandPrompt: () => i18nString(UIStrings.showRequestConditions),
+  title: () => i18nString(UIStrings.networkRequestConditions),
   persistence: UI.ViewManager.ViewPersistence.CLOSEABLE,
   order: 60,
   async loadView() {
@@ -350,8 +330,7 @@ UI.ActionRegistration.registerActionExtension({
 UI.ActionRegistration.registerActionExtension({
   actionId: 'network.add-network-request-blocking-pattern',
   category: UI.ActionRegistration.ActionCategory.NETWORK,
-  title: () => individualThrottlingEnabled() ? i18nString(UIStrings.addNetworkRequestBlockingOrThrottlingPattern) :
-                                               i18nString(UIStrings.addNetworkRequestBlockingPattern),
+  title: () => i18nString(UIStrings.addNetworkRequestBlockingOrThrottlingPattern),
   iconClass: UI.ActionRegistration.IconClass.PLUS,
   contextTypes() {
     return maybeRetrieveContextTypes(Network => [Network.RequestConditionsDrawer.RequestConditionsDrawer]);
@@ -365,9 +344,7 @@ UI.ActionRegistration.registerActionExtension({
 UI.ActionRegistration.registerActionExtension({
   actionId: 'network.remove-all-network-request-blocking-patterns',
   category: UI.ActionRegistration.ActionCategory.NETWORK,
-  title: () => individualThrottlingEnabled() ?
-      i18nString(UIStrings.removeAllNetworkRequestBlockingOrThrottlingPatterns) :
-      i18nString(UIStrings.removeAllNetworkRequestBlockingPatterns),
+  title: () => i18nString(UIStrings.removeAllNetworkRequestBlockingOrThrottlingPatterns),
   iconClass: UI.ActionRegistration.IconClass.CLEAR,
   contextTypes() {
     return maybeRetrieveContextTypes(Network => [Network.RequestConditionsDrawer.RequestConditionsDrawer]);

package/front_end/panels/settings/AISettingsTab.ts

@@ -10,7 +10,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 import * as AiAssistanceModel from '../../models/ai_assistance/ai_assistance.js';
-import * as AiCodeGeneration from '../../models/ai_code_generation/ai_code_generation.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as Input from '../../ui/components/input/input.js';
 import * as Switch from '../../ui/components/switch/switch.js';
@@ -537,10 +536,7 @@ export class AISettingsTab extends UI.Widget.VBox {
     }
 
     if (this.#aiCodeCompletionSetting) {
-      const devtoolsLocale = i18n.DevToolsLocale.DevToolsLocale.instance();
-      const isAiCodeGenerationEnabled =
-          AiCodeGeneration.AiCodeGeneration.AiCodeGeneration.isAiCodeGenerationEnabled(devtoolsLocale.locale);
-      const settingItems = isAiCodeGenerationEnabled ?
+      const settingItems = Root.Runtime.hostConfig.devToolsAiCodeGeneration?.enabled ?
           [
             {iconName: 'code', text: i18nString(UIStrings.asYouTypeRelevantDataIsBeingSentToGoogle)}, {
               iconName: 'text-analysis',

package/front_end/panels/settings/SettingsScreen.ts

@@ -631,16 +631,6 @@ const GREENDEV_VIEW: View = (input, _output, target) => {
                ${renderPrototypeCheckboxes(input.settings, ['aiAnnotations', 'inDevToolsFloaty', 'copyToGemini'])}
              </div>
            </devtools-card>
-
-           <devtools-card .heading=${'GreenDev widgets'}>
-             <div class="experiments-warning-subsection">
-              <devtools-icon .name=${'warning'}></devtools-icon>
-              <span>${i18nString(UIStrings.greenDevUnstable)}</span>
-             </div>
-             <div class="settings-experiments-block greendev-widgets">
-               ${renderWidgetOptions(input.settings)}
-             </div>
-           </devtools-card>
          </div>
        `, target);
   // clang-format on
@@ -649,50 +639,9 @@ const GREENDEV_VIEW: View = (input, _output, target) => {
 const GREENDEV_PROTOTYPE_NAMES: Record<keyof GreenDev.GreenDevSettings, string> = {
   inDevToolsFloaty: 'In DevTools context picker',
   aiAnnotations: 'AI auto-annotations',
-  inlineWidgets: 'Inline widgets in AI Assistance',
-  artifactViewer: 'Widgets in the Artifact viewer',
   copyToGemini: 'Copy changes to AI Prompt'
 };
 
-function renderWidgetOptions(settings: GreenDev.GreenDevSettings): TemplateResult {
-  function onChange(nowActiveRadio: 'inlineWidgets'|'artifactViewer'|'none') {
-    return () => {
-      switch (nowActiveRadio) {
-        case 'inlineWidgets': {
-          settings.artifactViewer.set(false);
-          settings.inlineWidgets.set(true);
-          break;
-        }
-        case 'artifactViewer': {
-          settings.artifactViewer.set(true);
-          settings.inlineWidgets.set(false);
-          break;
-        }
-        case 'none': {
-          settings.artifactViewer.set(false);
-          settings.inlineWidgets.set(false);
-        }
-      }
-
-      UI.InspectorView.InspectorView.instance().displayReloadRequiredWarning(
-          i18nString(UIStrings.settingsChangedReloadDevTools));
-    };
-  }
-  // clang-format off
-  return html`
-    <p class="settings-experiment">
-      <label><input type="radio" name="widgets-choice" @change=${onChange('inlineWidgets')}>${GREENDEV_PROTOTYPE_NAMES['inlineWidgets']}</label>
-    </p>
-    <p class="settings-experiment">
-      <label><input type="radio" name="widgets-choice" @change=${onChange('artifactViewer')}>${GREENDEV_PROTOTYPE_NAMES['artifactViewer']}</label>
-    </p>
-    <p class="settings-experiment">
-      <label><input type="radio" name="widgets-choice" @change=${onChange('none')}>None</label>
-    </p>
-  `;
-  // clang-format on
-}
-
 function renderPrototypeCheckboxes(
     settings: GreenDev.GreenDevSettings,
     keys: Array<keyof GreenDev.GreenDevSettings>,

package/front_end/panels/settings/WorkspaceSettingsTab.ts

@@ -61,7 +61,7 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
             <input
               class="harmony-input"
               jslog=${VisualLogging.textField().track({keydown: 'Enter', change: true}).context(input.excludePatternSetting.name)}
-              ${UI.UIUtils.bindToSetting(input.excludePatternSetting)}
+              ${UI.UIUtils.bindToSetting(input.excludePatternSetting, {jslog: false})}
               id="workspace-setting-folder-exclude-pattern"></input>
           </div>
           <div class="mappings-info">${i18nString(UIStrings.mappingsAreInferredAutomatically)}</div>

package/front_end/panels/sources/CallStackSidebarPane.ts

@@ -428,14 +428,14 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
       UI.Context.Context.instance().setFlavor(
           StackTrace.StackTrace.DebuggableFrameFlavor,
           StackTrace.StackTrace.DebuggableFrameFlavor.for(debuggerCallFrame));
+    } else {
+      void Common.Revealer.reveal(uiLocation);
     }
     if (oldItem !== item) {
       if (oldItem) {
         this.refreshItem(oldItem);
       }
       this.refreshItem(item);
-    } else {
-      void Common.Revealer.reveal(uiLocation);
     }
   }
 

package/front_end/panels/timeline/AnimationsTrackAppender.ts

@@ -48,7 +48,10 @@ export class AnimationsTrackAppender implements TrackAppender {
   }
 
   #appendTrackHeaderAtLevel(currentLevel: number, expanded?: boolean): void {
-    const style = buildGroupStyle({useFirstLineForOverview: false});
+    const style = buildGroupStyle({
+      useFirstLineForOverview: false,
+      collapsible: PerfUI.FlameChart.GroupCollapsibleState.IF_MULTI_ROW,
+    });
     const group = buildTrackHeader(
         VisualLoggingTrackName.ANIMATIONS, currentLevel, i18nString(UIStrings.animations), style,
         /* selectable= */ true, expanded);

package/front_end/panels/timeline/InteractionsTrackAppender.ts

@@ -71,7 +71,7 @@ export class InteractionsTrackAppender implements TrackAppender {
   #appendTrackHeaderAtLevel(currentLevel: number, expanded?: boolean): void {
     const trackIsCollapsible = this.#parsedTrace.data.UserInteractions.interactionEvents.length > 0;
     const style = buildGroupStyle({
-      collapsible: trackIsCollapsible ? PerfUI.FlameChart.GroupCollapsibleState.ALWAYS :
+      collapsible: trackIsCollapsible ? PerfUI.FlameChart.GroupCollapsibleState.IF_MULTI_ROW :
                                         PerfUI.FlameChart.GroupCollapsibleState.NEVER,
       useDecoratorsForOverview: true,
     });

package/front_end/panels/timeline/TimelineUIUtils.ts

@@ -2502,24 +2502,21 @@ export class TimelineDetailsContentHelper {
       return null;
     }
 
-    let callFrameContents;
-    if (this.target) {
-      const stackTrace = await Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance()
-                             .createStackTraceFromProtocolRuntime(runtimeStackTrace, this.target);
-      callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
-          undefined, this.target ?? undefined, this.#linkifier, {tabStops: true, showColumnNumber: true});
-      callFrameContents.stackTrace = stackTrace;
-    } else {
-      // I _think_ this only happens during tests.
-      // See "TimelineFlameChartView > shows the details for a selected main thread event".
-      // For now, just defer to the still-supported legacy runtime stack trace. When
-      // that is removed, we could instead create a stub StackTrace ourselves, even
-      // without a `target`.
-      callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
-          undefined, this.target ?? undefined, this.#linkifier,
-          {runtimeStackTrace, tabStops: true, showColumnNumber: true});
+    // Fallback to the main page/root target. Maybe the main page has a source map we need.
+    // Worst case the stack is identity mapped.
+    const targetManager = SDK.TargetManager.TargetManager.instance();
+    const target = this.target ?? targetManager.primaryPageTarget() ?? targetManager.rootTarget();
+    if (!target) {
+      return null;
     }
 
+    const stackTrace =
+        await Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance().createStackTraceFromProtocolRuntime(
+            runtimeStackTrace, target);
+    const callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
+        undefined, target, this.#linkifier, {tabStops: true, showColumnNumber: true});
+    callFrameContents.stackTrace = stackTrace;
+
     await callFrameContents.updateComplete;
     if (!callFrameContents.hasContent()) {
       return null;

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: https://chromium.googlesource.com/chromium/src
 Version: N/A
-Revision: eb058eb950a74d8f8ffe880684c8a41a4cea87f2
+Revision: 294287c423bbeff3981714f04e193960f503e773
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE