chrome-devtools-frontend 1.0.1581708 → 1.0.1583146

package/front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import type * as SDK from '../../../core/sdk/sdk.js';
+import type * as Protocol from '../../../generated/protocol.js';
 import * as Annotations from '../../annotations/annotations.js';
 import * as Logs from '../../logs/logs.js';
 import * as NetworkTimeCalculator from '../../network_time_calculator/network_time_calculator.js';
@@ -75,6 +76,51 @@ export class NetworkRequestFormatter {
     return '<redacted cross-origin initiator URL>';
   }
 
+  static formatStatus(status: {
+    statusCode: number,
+    statusText: string,
+    failed: boolean,
+    canceled: boolean,
+    preserved: boolean,
+    finished: boolean,
+  }): string {
+    let responseStatus = '';
+    if (status.statusCode) {
+      responseStatus = `Response status: ${status.statusCode} ${status.statusText}\n`;
+    }
+    const flags = [];
+    flags.push(status.finished ? 'finished' : 'pending');
+    if (status.failed) {
+      flags.push('failed');
+    }
+    if (status.canceled) {
+      flags.push('canceled');
+    }
+    if (status.preserved) {
+      flags.push('preserved');
+    }
+    const requestStatus = flags.length > 0 ? `Network request status: ${flags.join(', ')}\n` : '';
+    return `${responseStatus}${requestStatus}`;
+  }
+
+  static formatFailureReasons(reasons: {
+    blockedReason?: Protocol.Network.BlockedReason,
+    corsErrorStatus?: Protocol.Network.CorsErrorStatus,
+    localizedFailDescription?: string|null,
+  }): string {
+    const lines = [];
+    if (reasons.blockedReason) {
+      lines.push(`Blocked reason: ${reasons.blockedReason}`);
+    }
+    if (reasons.corsErrorStatus) {
+      lines.push(`CORS error: ${reasons.corsErrorStatus.corsError} ${reasons.corsErrorStatus.failedParameter}`);
+    }
+    if (reasons.localizedFailDescription) {
+      lines.push(`Fail description: ${reasons.localizedFailDescription}`);
+    }
+    return lines.length > 0 ? `${lines.join('\n')}\n` : '';
+  }
+
   constructor(
       request: SDK.NetworkRequest.NetworkRequest, calculator: NetworkTimeCalculator.NetworkTransferTimeCalculator) {
     this.#request = request;
@@ -111,13 +157,31 @@ ${this.formatRequestHeaders()}
 
 ${this.formatResponseHeaders()}${responseBody}
 
-Response status: ${this.#request.statusCode} ${this.#request.statusText}
-
+${this.formatStatus()}${this.formatFailureReasons()}
 Request timing:\n${this.formatNetworkRequestTiming()}
 
 Request initiator chain:\n${this.formatRequestInitiatorChain()}`;
   }
 
+  formatStatus(): string {
+    return NetworkRequestFormatter.formatStatus({
+      statusCode: this.#request.statusCode,
+      statusText: this.#request.statusText,
+      failed: this.#request.failed,
+      canceled: this.#request.canceled,
+      preserved: this.#request.preserved,
+      finished: this.#request.finished,
+    });
+  }
+
+  formatFailureReasons(): string {
+    return NetworkRequestFormatter.formatFailureReasons({
+      blockedReason: this.#request.blockedReason(),
+      corsErrorStatus: this.#request.corsErrorStatus(),
+      localizedFailDescription: this.#request.localizedFailDescription,
+    });
+  }
+
   /**
    * Note: nothing here should include information from origins other than
    * the request's origin.

package/front_end/models/greendev/Prototypes.ts

@@ -9,8 +9,6 @@ let instance: Prototypes|null = null;
 
 export interface GreenDevSettings {
   inDevToolsFloaty: Common.Settings.Setting<boolean>;
-  inlineWidgets: Common.Settings.Setting<boolean>;
-  artifactViewer: Common.Settings.Setting<boolean>;
   aiAnnotations: Common.Settings.Setting<boolean>;
   copyToGemini: Common.Settings.Setting<boolean>;
 }
@@ -41,21 +39,14 @@ export class Prototypes {
     const inDevToolsFloaty =
         settings.createSetting('greendev-in-devtools-floaty-enabled', false, Common.Settings.SettingStorageType.LOCAL);
 
-    const inlineWidgets =
-        settings.createSetting('greendev-inline-widgets-enabled', false, Common.Settings.SettingStorageType.LOCAL);
-
     const aiAnnotations = settings.createSetting(
         'greendev-ai-annotations-enabled',
         false,
         Common.Settings.SettingStorageType.LOCAL,
     );
-
-    const artifactViewer =
-        settings.createSetting('greendev-artifact-viewer-enabled', false, Common.Settings.SettingStorageType.LOCAL);
-
     const copyToGemini =
         settings.createSetting('greendev-copy-to-gemini-enabled', false, Common.Settings.SettingStorageType.LOCAL);
 
-    return {inDevToolsFloaty, inlineWidgets, aiAnnotations, artifactViewer, copyToGemini};
+    return {inDevToolsFloaty, aiAnnotations, copyToGemini};
   }
 }

package/front_end/models/issues_manager/ConnectionAllowlistIssue.ts

@@ -0,0 +1,75 @@
+// Copyright 2026 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as i18n from '../../core/i18n/i18n.js';
+import type * as SDK from '../../core/sdk/sdk.js';
+import * as Protocol from '../../generated/protocol.js';
+
+import {Issue, IssueCategory, IssueKind} from './Issue.js';
+import {
+  type LazyMarkdownIssueDescription,
+  type MarkdownIssueDescription,
+  resolveLazyDescription,
+} from './MarkdownIssueDescription.js';
+
+const UIStrings = {
+  /**
+   *@description Title for Connection-Allowlist specification url
+   */
+  connectionAllowlistHeader: 'Connection-Allowlist specification',
+} as const;
+const str_ = i18n.i18n.registerUIStrings('models/issues_manager/ConnectionAllowlistIssue.ts', UIStrings);
+const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
+
+export class ConnectionAllowlistIssue extends Issue<Protocol.Audits.ConnectionAllowlistIssueDetails> {
+  constructor(
+      issueDetails: Protocol.Audits.ConnectionAllowlistIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
+    super(
+        {
+          code: `${Protocol.Audits.InspectorIssueCode.ConnectionAllowlistIssue}::${issueDetails.error}`,
+          umaCode: `${Protocol.Audits.InspectorIssueCode.ConnectionAllowlistIssue}::${issueDetails.error}`,
+        },
+        issueDetails, issuesModel);
+  }
+
+  override primaryKey(): string {
+    return JSON.stringify(this.details());
+  }
+
+  override getDescription(): MarkdownIssueDescription|null {
+    const description: LazyMarkdownIssueDescription = {
+      file: `connectionAllowlist${this.details().error}.md`,
+      links: [
+        {
+          link: 'https://wicg.github.io/private-network-access/#connection-allowlist',
+          linkTitle: i18nLazyString(UIStrings.connectionAllowlistHeader),
+        },
+      ],
+    };
+    return resolveLazyDescription(description);
+  }
+
+  override getCategory(): IssueCategory {
+    return IssueCategory.OTHER;
+  }
+
+  override getKind(): IssueKind {
+    return IssueKind.PAGE_ERROR;
+  }
+
+  override requests(): Iterable<Protocol.Audits.AffectedRequest> {
+    return this.details().request ? [this.details().request] : [];
+  }
+
+  static fromInspectorIssue(
+      issuesModel: SDK.IssuesModel.IssuesModel|null,
+      inspectorIssue: Protocol.Audits.InspectorIssue): ConnectionAllowlistIssue[] {
+    const details = inspectorIssue.details.connectionAllowlistIssueDetails;
+    if (!details) {
+      console.warn('Connection-Allowlist issue without details received.');
+      return [];
+    }
+    return [new ConnectionAllowlistIssue(details, issuesModel)];
+  }
+}

package/front_end/models/issues_manager/FederatedAuthRequestIssue.ts

@@ -109,36 +109,6 @@ const issueDescriptions = new Map<Protocol.Audits.FederatedAuthRequestIssueReaso
       }],
     },
   ],
-  [
-    Protocol.Audits.FederatedAuthRequestIssueReason.ClientMetadataHttpNotFound,
-    {
-      file: 'federatedAuthRequestClientMetadataHttpNotFound.md',
-      links: [{
-        link: 'https://fedidcg.github.io/FedCM/',
-        linkTitle: i18nLazyString(UIStrings.fedCm),
-      }],
-    },
-  ],
-  [
-    Protocol.Audits.FederatedAuthRequestIssueReason.ClientMetadataNoResponse,
-    {
-      file: 'federatedAuthRequestClientMetadataNoResponse.md',
-      links: [{
-        link: 'https://fedidcg.github.io/FedCM/',
-        linkTitle: i18nLazyString(UIStrings.fedCm),
-      }],
-    },
-  ],
-  [
-    Protocol.Audits.FederatedAuthRequestIssueReason.ClientMetadataInvalidResponse,
-    {
-      file: 'federatedAuthRequestClientMetadataInvalidResponse.md',
-      links: [{
-        link: 'https://fedidcg.github.io/FedCM/',
-        linkTitle: i18nLazyString(UIStrings.fedCm),
-      }],
-    },
-  ],
   [
     Protocol.Audits.FederatedAuthRequestIssueReason.ErrorFetchingSignin,
     {

package/front_end/models/issues_manager/IssuesManager.ts

@@ -9,6 +9,7 @@ import * as Protocol from '../../generated/protocol.js';
 import {AttributionReportingIssue} from './AttributionReportingIssue.js';
 import {BounceTrackingIssue} from './BounceTrackingIssue.js';
 import {ClientHintIssue} from './ClientHintIssue.js';
+import {ConnectionAllowlistIssue} from './ConnectionAllowlistIssue.js';
 import {ContentSecurityPolicyIssue} from './ContentSecurityPolicyIssue.js';
 import {CookieDeprecationMetadataIssue} from './CookieDeprecationMetadataIssue.js';
 import {CookieIssue} from './CookieIssue.js';
@@ -144,6 +145,10 @@ const issueCodeHandlers = new Map<
     Protocol.Audits.InspectorIssueCode.UnencodedDigestIssue,
     UnencodedDigestIssue.fromInspectorIssue,
   ],
+  [
+    Protocol.Audits.InspectorIssueCode.ConnectionAllowlistIssue,
+    ConnectionAllowlistIssue.fromInspectorIssue,
+  ],
   [
     Protocol.Audits.InspectorIssueCode.PermissionElementIssue,
     PermissionElementIssue.fromInspectorIssue,

package/front_end/models/issues_manager/descriptions/connectionAllowlistInvalidAllowlistItemType.md

@@ -0,0 +1,12 @@
+# An item in the `Connection-Allowlist` header is invalid.
+
+Each item in the `Connection-Allowlist`'s header's [Inner List](sfInnerList)
+must be a [String](sfString) representing a [URL Pattern](urlPatternSpec), or
+the [Token](sfToken) `response-origin`.
+
+For example, the following header allows connections to (only)
+`https://example.com/` and the origin from which the response was delivered:
+
+```
+Connection-Allowlist: ("https://example.com" response-origin)
+```

package/front_end/models/issues_manager/descriptions/connectionAllowlistInvalidHeader.md

@@ -0,0 +1,12 @@
+# The `Connection-Allowlist` header is not formatted as a Structured Field List.
+
+Responses' `Connection-Allowlist` header should be formatted as a [List](sfList)
+containing a single [Inner List](sfInnerList) that declares the allowed set of
+[URL Patterns](urlPatternSpec) for a given context.
+
+For example, the following header allows connections to (only)
+`https://example.com/`:
+
+```
+Connection-Allowlist: ("https://example.com")
+```

package/front_end/models/issues_manager/descriptions/connectionAllowlistInvalidUrlPattern.md

@@ -0,0 +1,8 @@
+# An item in the `Connection-Allowlist` header is not a valid URL pattern.
+
+Each item in the `Connection-Allowlist` header must be a valid
+[URL Pattern](urlPatternSpec) that can be used to match against the request's
+origin.
+
+Note that our current implementation does not allow regular expressions to be
+used as part of the pattern.

package/front_end/models/issues_manager/descriptions/connectionAllowlistItemNotInnerList.md

@@ -0,0 +1,12 @@
+# An item in the `Connection-Allowlist` header is not an Inner List.
+
+Responses' `Connection-Allowlist` header should be formatted as a [List](sfList)
+containing a single [Inner List](sfInnerList) that declares the allowed set of
+[URL Patterns](urlPatternSpec) for a given context.
+
+For example, the following header allows connections to (only)
+`https://example.com/`:
+
+```
+Connection-Allowlist: ("https://example.com")
+```

package/front_end/models/issues_manager/descriptions/connectionAllowlistMoreThanOneList.md

@@ -0,0 +1,7 @@
+# `Connection-Allowlist` has multiple items.
+
+Responses' `Connection-Allowlist` header should be formatted as a [List](sfList)
+containing a single [Inner List](sfInnerList) that declares the allowed set of
+[URL Patterns](urlPatternSpec) for a given context. This response was a
+[List](sfList) containing more than one item: all but the first have been
+ignored.

package/front_end/models/issues_manager/descriptions/connectionAllowlistReportingEndpointNotToken.md

@@ -0,0 +1,10 @@
+# The `report-to` parameter in the `Connection-Allowlist` header is not a token.
+
+If provided, the `report-to` parameter must be a [Token](sfToken)
+naming a reporting endpoint.
+
+For example:
+
+```
+Connection-Allowlist: ("https://example.com");report-to=endpoint
+```

package/front_end/models/issues_manager/issues_manager.ts

@@ -5,6 +5,7 @@
 import * as AttributionReportingIssue from './AttributionReportingIssue.js';
 import * as CheckFormsIssuesTrigger from './CheckFormsIssuesTrigger.js';
 import * as ClientHintIssue from './ClientHintIssue.js';
+import * as ConnectionAllowlistIssue from './ConnectionAllowlistIssue.js';
 import * as ContentSecurityPolicyIssue from './ContentSecurityPolicyIssue.js';
 import * as ContrastCheckTrigger from './ContrastCheckTrigger.js';
 import * as CookieDeprecationMetadataIssue from './CookieDeprecationMetadataIssue.js';
@@ -39,6 +40,7 @@ export {
   AttributionReportingIssue,
   CheckFormsIssuesTrigger,
   ClientHintIssue,
+  ConnectionAllowlistIssue,
   ContentSecurityPolicyIssue,
   ContrastCheckTrigger,
   CookieDeprecationMetadataIssue,

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -707,12 +707,24 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   // We select the default agent based on the open panels if
   // there isn't any active conversation.
   #selectDefaultAgentIfNeeded(): void {
+    // We don't change the current agent when there is a message in flight.
+    if (this.#isLoading) {
+      return;
+    }
+
     // If there already is an agent and if it is not empty,
-    // we don't automatically change the agent. In addition to this,
-    // we don't change the current agent when there is a message in flight.
-    if ((this.#conversation && !this.#conversation.isEmpty) || this.#isLoading) {
+    // we don't automatically change the agent.
+    if (this.#conversation && !this.#conversation.isEmpty) {
+      // If the context selection agent is enabled,
+      // we update the context of the current agent.
+      const context = this.#getConversationContext(this.#getDefaultConversationType());
+      if (context && isAiAssistanceContextSelectionAgentEnabled()) {
+        this.#conversation?.setContext(context);
+        this.requestUpdate();
+      }
       return;
     }
+
     const targetConversationType = this.#getDefaultConversationType();
     if (this.#conversation?.type === targetConversationType) {
       // The above if makes sure even if we have an active agent it's empty
@@ -1417,7 +1429,13 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     });
 
     void this.#toggleSearchElementAction.execute();
-    return await result;
+    try {
+      return await result;
+    } finally {
+      if (this.#toggleSearchElementAction.toggled()) {
+        void this.#toggleSearchElementAction.execute();
+      }
+    }
   }
 
   async #startConversation(

package/front_end/panels/ai_assistance/components/ChatInput.ts

@@ -42,7 +42,11 @@ const UIStrings = {
   /**
    * @description Label added to the button that remove the currently selected context in AI Assistance panel.
    */
-  removeContext: 'Remove selected context',
+  removeContext: 'Remove from context',
+  /**
+   * @description Label added to the button that add selected context from the current panel in AI Assistance panel.
+   */
+  addContext: 'Add selected item as context',
 } as const;
 
 /*
@@ -387,8 +391,8 @@ export const
                   :
                     input.onContextAdd ? html`
                                   <devtools-button
-                                    title=${i18nString(UIStrings.removeContext)}
-                                    aria-label=${i18nString(UIStrings.removeContext)}
+                                    title=${i18nString(UIStrings.addContext)}
+                                    aria-label=${i18nString(UIStrings.addContext)}
                                     class="add-context"
                                     .iconName=${'plus'}
                                     .size=${Buttons.Button.Size.SMALL}

package/front_end/panels/ai_assistance/components/ChatMessage.ts

@@ -221,6 +221,7 @@ export interface RatingViewInput {
 export interface ActionViewInput {
   onReportClick: () => void;
   onCopyResponseClick: () => void;
+  showActions: boolean;
 }
 
 export interface SuggestionViewInput {
@@ -330,7 +331,7 @@ export const DEFAULT_VIEW = (input: ChatMessageViewInput, output: ViewOutput, ta
         },
       )}
       ${renderError(message)}
-      ${input.isLastMessage && !input.isLoading ? renderActions(input, output) : Lit.nothing}
+      ${input.showActions ? renderActions(input, output) : Lit.nothing}
     </section>
   `, target);
   // clang-format on
@@ -812,8 +813,9 @@ export class ChatMessage extends UI.Widget.Widget {
           onInputChange: this.#handleInputChange.bind(this),
           isSubmitButtonDisabled: this.#isSubmitButtonDisabled,
           // Props for actions logic
+          showActions: !(this.isLastMessage && this.isLoading),
           showRateButtons: this.message.entity === ChatMessageEntity.MODEL && !!this.message.rpcId,
-          suggestions: (this.message.entity === ChatMessageEntity.MODEL && !this.isReadOnly &&
+          suggestions: (this.isLastMessage && this.message.entity === ChatMessageEntity.MODEL && !this.isReadOnly &&
                         this.message.parts.at(-1)?.type === 'answer') ?
               (this.message.parts.at(-1) as AnswerPart).suggestions :
               undefined,

package/front_end/panels/application/preloading/PreloadingView.ts

@@ -22,7 +22,7 @@ import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
 
 import * as PreloadingComponents from './components/components.js';
 import {ruleSetTagOrLocationShort} from './components/PreloadingString.js';
-import type * as PreloadingHelper from './helper/helper.js';
+import * as PreloadingHelper from './helper/helper.js';
 import preloadingViewStyles from './preloadingView.css.js';
 import preloadingViewDropDownStyles from './preloadingViewDropDown.css.js';
 
@@ -501,10 +501,17 @@ export class PreloadingAttemptView extends UI.Widget.VBox {
         const ruleSet = this.model.getRuleSetById(id);
         return ruleSet === null ? [] : [ruleSet];
       });
+
+      // Lookup status code for prefetch attempts
+      const statusCode = attempt.action === Protocol.Preload.SpeculationAction.Prefetch ?
+          PreloadingHelper.PreloadingForward.prefetchStatusCode(attempt.requestId) :
+          undefined;
+
       return {
         id,
         pipeline,
         ruleSets,
+        statusCode,
       };
     });
     this.preloadingGrid.rows = rows;

package/front_end/panels/application/preloading/components/PreloadingDetailsReportView.ts

@@ -349,7 +349,10 @@ export class PreloadingDetailsReportView extends LegacyWrapper.LegacyWrapper.Wra
       return Lit.nothing;
     }
 
-    const failureDescription = prefetchFailureReason(attempt);
+    // Lookup status code for Non2XX failures
+    const statusCode = PreloadingHelper.PreloadingForward.prefetchStatusCode(attempt.requestId);
+
+    const failureDescription = prefetchFailureReason(attempt, statusCode);
     if (failureDescription === null) {
       return Lit.nothing;
     }

package/front_end/panels/application/preloading/components/PreloadingGrid.ts

@@ -51,6 +51,7 @@ export interface PreloadingGridRow {
   id: string;
   pipeline: SDK.PreloadingModel.PreloadPipeline;
   ruleSets: Protocol.Preload.RuleSet[];
+  statusCode?: number;
 }
 
 export interface ViewInput {
@@ -107,7 +108,7 @@ export const PRELOADING_GRID_DEFAULT_VIEW: View = (input, _output, target): void
                         'vertical-align': 'sub',
                       })}
                     ></devtools-icon>` : ''}
-                  ${hasWarning ? i18nString(UIStrings.prefetchFallbackReady) : composedStatus(attempt)}
+                  ${hasWarning ? i18nString(UIStrings.prefetchFallbackReady) : composedStatus(attempt, row.statusCode)}
                 </div>
               </td>
             </tr>`;

package/front_end/panels/application/preloading/components/PreloadingString.ts

@@ -31,6 +31,11 @@ const UIStrings = {
    * @description  Description text for Prefetch status PrefetchFailedNon2XX.
    */
   PrefetchFailedNon2XX: 'The prefetch failed because of a non-2xx HTTP response status code.',
+  /**
+   * @description  Description text for Prefetch status PrefetchFailedNon2XX when the HTTP status code is known.
+   * @example {404} PH1
+   */
+  PrefetchFailedNon2XXWithStatusCode: 'The prefetch failed because of a non-2xx HTTP response status code ({PH1}).',
   /**
    * @description  Description text for Prefetch status PrefetchIneligibleRetryAfter.
    */
@@ -446,7 +451,8 @@ export const PrefetchReasonDescription: Record<string, {name: () => Platform.UIS
 };
 
 /** Decoding PrefetchFinalStatus prefetchAttempt to failure description. **/
-export function prefetchFailureReason({prefetchStatus}: SDK.PreloadingModel.PrefetchAttempt): string|null {
+export function prefetchFailureReason(
+    {prefetchStatus}: SDK.PreloadingModel.PrefetchAttempt, statusCode?: number): string|null {
   // If you face an error on rolling CDP changes, see
   // https://docs.google.com/document/d/1PnrfowsZMt62PX1EvvTp2Nqs3ji1zrklrAEe1JYbkTk
   switch (prefetchStatus) {
@@ -478,6 +484,9 @@ export function prefetchFailureReason({prefetchStatus}: SDK.PreloadingModel.Pref
     case Protocol.Preload.PrefetchStatus.PrefetchFailedNetError:
       return PrefetchReasonDescription['PrefetchFailedNetError'].name();
     case Protocol.Preload.PrefetchStatus.PrefetchFailedNon2XX:
+      if (statusCode !== undefined) {
+        return i18nString(UIStrings.PrefetchFailedNon2XXWithStatusCode, {PH1: String(statusCode)});
+      }
       return PrefetchReasonDescription['PrefetchFailedNon2XX'].name();
     case Protocol.Preload.PrefetchStatus.PrefetchIneligibleRetryAfter:
       return PrefetchReasonDescription['PrefetchIneligibleRetryAfter'].name();
@@ -795,7 +804,7 @@ export function status(status: SDK.PreloadingModel.PreloadingStatus): string {
   }
 }
 
-export function composedStatus(attempt: SDK.PreloadingModel.PreloadingAttempt): string {
+export function composedStatus(attempt: SDK.PreloadingModel.PreloadingAttempt, statusCode?: number): string {
   const short = status(attempt.status);
 
   if (attempt.status !== SDK.PreloadingModel.PreloadingStatus.FAILURE) {
@@ -804,7 +813,7 @@ export function composedStatus(attempt: SDK.PreloadingModel.PreloadingAttempt):
 
   switch (attempt.action) {
     case Protocol.Preload.SpeculationAction.Prefetch: {
-      const detail = prefetchFailureReason(attempt) ?? i18n.i18n.lockedString('Internal error');
+      const detail = prefetchFailureReason(attempt, statusCode) ?? i18n.i18n.lockedString('Internal error');
       return short + ' - ' + detail;
     }
     case Protocol.Preload.SpeculationAction.Prerender:

package/front_end/panels/application/preloading/helper/PreloadingForward.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import type * as Protocol from '../../../../generated/protocol.js';
+import * as Logs from '../../../../models/logs/logs.js';
 
 export class RuleSetView {
   readonly ruleSetId: Protocol.Preload.RuleSetId|null;
@@ -19,3 +20,16 @@ export class AttemptViewWithFilter {
     this.ruleSetId = ruleSetId;
   }
 }
+
+/**
+ * Retrieves the HTTP status code for a prefetch attempt by looking up its
+ * network request in the network log.
+ */
+export function prefetchStatusCode(requestId: Protocol.Network.RequestId): number|undefined {
+  const networkLog = Logs.NetworkLog.NetworkLog.instance();
+  const requests = networkLog.requestsForId(requestId);
+  if (requests.length > 0) {
+    return requests[requests.length - 1].statusCode;
+  }
+  return undefined;
+}

package/front_end/panels/autofill/AutofillView.ts

@@ -228,14 +228,12 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: ViewOutput, target: HTMLE
           <div class="top-left-corner">
             <devtools-checkbox
                 ${bindToSetting(input.showTestAddressesInAutofillMenuSetting)}
-                title=${i18nString(UIStrings.showTestAddressesInAutofillMenu)}
-                jslog=${VisualLogging.toggle(input.showTestAddressesInAutofillMenuSetting.name).track({ change: true })}>
+                title=${i18nString(UIStrings.showTestAddressesInAutofillMenu)}>
               ${i18nString(UIStrings.showTestAddressesInAutofillMenu)}
             </devtools-checkbox>
             <devtools-checkbox
                 ${bindToSetting(input.autoOpenViewSetting)}
-                title=${i18nString(UIStrings.autoShowTooltip)}
-                jslog=${VisualLogging.toggle(input.autoOpenViewSetting.name).track({ change: true })}>
+                title=${i18nString(UIStrings.autoShowTooltip)}>
               ${i18nString(UIStrings.autoShow)}
             </devtools-checkbox>
             <devtools-link href=${AUTOFILL_FEEDBACK_URL} class="feedback link" jslogcontext="feedback">${i18nString(UIStrings.sendFeedback)}</devtools-link>
@@ -267,16 +265,14 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: ViewOutput, target: HTMLE
               <div class="label-container">
                 <devtools-checkbox
                     ${bindToSetting(input.showTestAddressesInAutofillMenuSetting)}
-                    title=${i18nString(UIStrings.showTestAddressesInAutofillMenu)}
-                    jslog=${VisualLogging.toggle(input.showTestAddressesInAutofillMenuSetting.name).track({ change: true })}>
+                    title=${i18nString(UIStrings.showTestAddressesInAutofillMenu)}>
                   ${i18nString(UIStrings.showTestAddressesInAutofillMenu)}
                 </devtools-checkbox>
               </div>
               <div class="label-container">
                 <devtools-checkbox
                     ${bindToSetting(input.autoOpenViewSetting)}
-                    title=${i18nString(UIStrings.autoShowTooltip)}
-                    jslog=${VisualLogging.toggle(input.autoOpenViewSetting.name).track({ change: true })}>
+                    title=${i18nString(UIStrings.autoShowTooltip)}>
                   ${i18nString(UIStrings.autoShow)}
                 </devtools-checkbox>
               </div>