chrome-devtools-frontend 1.0.1581708 → 1.0.1583146

package/front_end/core/root/Runtime.ts

@@ -582,10 +582,6 @@ interface AiPromptApi {
   allowWithoutGpu: boolean;
 }
 
-interface DevToolsIndividualRequestThrottling {
-  enabled: boolean;
-}
-
 export interface DevToolsEnableDurableMessages {
   enabled: boolean;
 }
@@ -631,7 +627,6 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAiCodeGeneration: HostConfigAiCodeGeneration,
   devToolsVeLogging: HostConfigVeLogging,
   devToolsWellKnown: HostConfigWellKnown,
-  devToolsIndividualRequestThrottling: DevToolsIndividualRequestThrottling,
   /**
    * OffTheRecord here indicates that the user's profile is either incognito,
    * or guest mode, rather than a "normal" profile.

package/front_end/core/sdk/NetworkManager.ts

@@ -1687,19 +1687,8 @@ export class RequestCondition extends Common.ObjectWrapper.ObjectWrapper<Request
         (this.#pattern.upgradedPattern?.constructorString ?? this.#pattern.wildcardURL);
   }
 
-  set pattern(pattern: RequestURLPattern|string) {
-    if (typeof pattern === 'string') {
-      // TODO(pfaffe) Remove once the feature flag is no longer required
-      if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-        throw new Error('Should not use wildcard urls');
-      }
-      this.#pattern = {
-        wildcardURL: pattern,
-        upgradedPattern: RequestURLPattern.upgradeFromWildcard(pattern) ?? undefined
-      };
-    } else {
-      this.#pattern = pattern;
-    }
+  set pattern(pattern: RequestURLPattern) {
+    this.#pattern = pattern;
     this.dispatchEventToListeners(RequestCondition.Events.REQUEST_CONDITION_CHANGED);
   }
 
@@ -1792,10 +1781,7 @@ export class RequestConditions extends Common.ObjectWrapper.ObjectWrapper<Reques
   }
 
   findCondition(pattern: string): RequestCondition|undefined {
-    if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-      return this.#conditions.find(condition => condition.constructorString === pattern);
-    }
-    return this.#conditions.find(condition => condition.wildcardURL === pattern);
+    return this.#conditions.find(condition => condition.constructorString === pattern);
   }
 
   has(url: string): boolean {
@@ -1862,84 +1848,72 @@ export class RequestConditions extends Common.ObjectWrapper.ObjectWrapper<Reques
     function isNonBlockingCondition(condition: ThrottlingConditions): condition is Conditions {
       return !('block' in condition);
     }
-    if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-      const urlPatterns: Protocol.Network.BlockPattern[] = [];
-      // We store all this info out-of-band to prevent races with changing conditions while the promise is still pending
-      const matchedNetworkConditions: Array<{conditions: Conditions, ruleIds?: Set<string>, urlPattern?: string}> = [];
-      if (this.conditionsEnabled) {
-        for (const condition of this.#conditions) {
-          const urlPattern = condition.constructorString;
-          const conditions = condition.conditions;
-          if (!condition.enabled || !urlPattern || conditions === NoThrottlingConditions) {
-            continue;
-          }
-          const block = !isNonBlockingCondition(conditions);
-          urlPatterns.push({urlPattern, block});
-          if (!block) {
-            const {ruleIds} = condition;
-            matchedNetworkConditions.push({ruleIds, urlPattern, conditions});
-          }
+    const urlPatterns: Protocol.Network.BlockPattern[] = [];
+    // We store all this info out-of-band to prevent races with changing conditions while the promise is still pending
+    const matchedNetworkConditions: Array<{conditions: Conditions, ruleIds?: Set<string>, urlPattern?: string}> = [];
+    if (this.conditionsEnabled) {
+      for (const condition of this.#conditions) {
+        const urlPattern = condition.constructorString;
+        const conditions = condition.conditions;
+        if (!condition.enabled || !urlPattern || conditions === NoThrottlingConditions) {
+          continue;
+        }
+        const block = !isNonBlockingCondition(conditions);
+        urlPatterns.push({urlPattern, block});
+        if (!block) {
+          const {ruleIds} = condition;
+          matchedNetworkConditions.push({ruleIds, urlPattern, conditions});
         }
       }
+    }
 
-      if (globalConditions) {
-        matchedNetworkConditions.push({conditions: globalConditions});
-      }
-
-      const promises: Array<Promise<unknown>> = [];
-
-      for (const agent of agents) {
-        promises.push(agent.invoke_setBlockedURLs({urlPatterns}));
-        promises.push(agent
-                          .invoke_emulateNetworkConditionsByRule({
-                            offline,
-                            matchedNetworkConditions: matchedNetworkConditions.map(
-                                ({urlPattern, conditions}) => ({
-                                  urlPattern: urlPattern ?? '',
-                                  latency: conditions.latency,
-                                  downloadThroughput: conditions.download < 0 ? 0 : conditions.download,
-                                  uploadThroughput: conditions.upload < 0 ? 0 : conditions.upload,
-                                  packetLoss: (conditions.packetLoss ?? 0) < 0 ? 0 : conditions.packetLoss,
-                                  packetQueueLength: conditions.packetQueueLength,
-                                  packetReordering: conditions.packetReordering,
-                                  connectionType: NetworkManager.connectionType(conditions),
-                                }))
-                          })
-                          .then(response => {
-                            if (!response.getError()) {
-                              for (let i = 0; i < response.ruleIds.length; ++i) {
-                                const ruleId = response.ruleIds[i];
-                                const {ruleIds, conditions, urlPattern} = matchedNetworkConditions[i];
-                                if (ruleIds) {
-                                  this.#requestConditionsById.set(ruleId, {urlPattern, conditions});
-                                  matchedNetworkConditions[i].ruleIds?.add(ruleId);
-                                }
-                              }
-                            }
-                          }));
-        promises.push(agent.invoke_overrideNetworkState({
-          offline,
-          latency: globalConditions?.latency ?? 0,
-          downloadThroughput: globalConditions?.download ?? -1,
-          uploadThroughput: globalConditions?.upload ?? -1,
-          connectionType: globalConditions ? NetworkManager.connectionType(globalConditions) :
-                                             Protocol.Network.ConnectionType.None,
-        }));
-      }
-
-      this.#conditionsAppliedForTestPromise = this.#conditionsAppliedForTestPromise.then(() => Promise.all(promises));
-      return urlPatterns.length > 0;
+    if (globalConditions) {
+      matchedNetworkConditions.push({conditions: globalConditions});
     }
 
-    const urls = this.conditionsEnabled ?
-        this.#conditions.filter(condition => condition.enabled && condition.wildcardURL)
-            .map(condition => condition.wildcardURL as string) :
-        [];
+    const promises: Array<Promise<unknown>> = [];
 
     for (const agent of agents) {
-      void agent.invoke_setBlockedURLs({urls});
+      promises.push(agent.invoke_setBlockedURLs({urlPatterns}));
+      promises.push(agent
+                        .invoke_emulateNetworkConditionsByRule({
+                          offline,
+                          matchedNetworkConditions: matchedNetworkConditions.map(
+                              ({urlPattern, conditions}) => ({
+                                urlPattern: urlPattern ?? '',
+                                latency: conditions.latency,
+                                downloadThroughput: conditions.download < 0 ? 0 : conditions.download,
+                                uploadThroughput: conditions.upload < 0 ? 0 : conditions.upload,
+                                packetLoss: (conditions.packetLoss ?? 0) < 0 ? 0 : conditions.packetLoss,
+                                packetQueueLength: conditions.packetQueueLength,
+                                packetReordering: conditions.packetReordering,
+                                connectionType: NetworkManager.connectionType(conditions),
+                              }))
+                        })
+                        .then(response => {
+                          if (!response.getError()) {
+                            for (let i = 0; i < response.ruleIds.length; ++i) {
+                              const ruleId = response.ruleIds[i];
+                              const {ruleIds, conditions, urlPattern} = matchedNetworkConditions[i];
+                              if (ruleIds) {
+                                this.#requestConditionsById.set(ruleId, {urlPattern, conditions});
+                                matchedNetworkConditions[i].ruleIds?.add(ruleId);
+                              }
+                            }
+                          }
+                        }));
+      promises.push(agent.invoke_overrideNetworkState({
+        offline,
+        latency: globalConditions?.latency ?? 0,
+        downloadThroughput: globalConditions?.download ?? -1,
+        uploadThroughput: globalConditions?.upload ?? -1,
+        connectionType: globalConditions ? NetworkManager.connectionType(globalConditions) :
+                                           Protocol.Network.ConnectionType.None,
+      }));
     }
-    return urls.length > 0;
+
+    this.#conditionsAppliedForTestPromise = this.#conditionsAppliedForTestPromise.then(() => Promise.all(promises));
+    return urlPatterns.length > 0;
   }
 
   conditionsAppliedForTest(): Promise<unknown> {
@@ -2082,9 +2056,6 @@ export class MultitargetNetworkManager extends Common.ObjectWrapper.ObjectWrappe
     }
     this.#networkAgents.add(networkAgent);
     this.#fetchAgents.add(fetchAgent);
-    if (this.isThrottling() && !Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-      this.updateNetworkConditions(networkAgent);
-    }
   }
 
   modelRemoved(networkManager: NetworkManager): void {
@@ -2110,14 +2081,8 @@ export class MultitargetNetworkManager extends Common.ObjectWrapper.ObjectWrappe
 
   setNetworkConditions(conditions: Conditions): void {
     this.#networkConditions = conditions;
-    if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
-      this.#requestConditions.applyConditions(
-          this.isOffline(), this.isThrottling() ? this.#networkConditions : null, ...this.#networkAgents);
-    } else {
-      for (const agent of this.#networkAgents) {
-        this.updateNetworkConditions(agent);
-      }
-    }
+    this.#requestConditions.applyConditions(
+        this.isOffline(), this.isThrottling() ? this.#networkConditions : null, ...this.#networkAgents);
     this.dispatchEventToListeners(MultitargetNetworkManager.Events.CONDITIONS_CHANGED);
   }
 
@@ -2224,23 +2189,6 @@ export class MultitargetNetworkManager extends Common.ObjectWrapper.ObjectWrappe
     return this.#isBlocking && this.requestConditions.conditionsEnabled;
   }
 
-  /**
-   * @deprecated Kept for layout tests
-   * TODO(pfaffe) remove
-   */
-  private setBlockingEnabled(enabled: boolean): void {
-    this.requestConditions.conditionsEnabled = enabled;
-  }
-
-  /**
-   * @deprecated Kept for layout tests
-   * TODO(pfaffe) remove
-   */
-  private setBlockedPatterns(patterns: Array<{url: string, enabled: boolean}>): void {
-    this.requestConditions.clear();
-    this.requestConditions.add(...patterns.map(pattern => RequestCondition.createFromSetting(pattern)));
-  }
-
   private updateBlockedPatterns(): void {
     this.#isBlocking = this.#requestConditions.applyConditions(
         this.isOffline(), this.isThrottling() ? this.#networkConditions : null, ...this.#networkAgents);

package/front_end/core/sdk/RemoteObject.ts

@@ -66,6 +66,11 @@ export abstract class RemoteObject {
     return matches ? parseInt(matches[1], 10) : 0;
   }
 
+  static isEmptyArray(object: RemoteObject|Protocol.Runtime.RemoteObject|Protocol.Runtime.ObjectPreview): boolean {
+    const matches = object.description?.match(descriptionLengthParenRegex);
+    return Boolean(matches?.[1] === '0');
+  }
+
   static unserializableDescription(object: unknown): string|null {
     if (typeof object === 'number') {
       const description = String(object);
@@ -582,7 +587,8 @@ export class RemoteObjectImpl extends RemoteObject {
 
   override isLinearMemoryInspectable(): boolean {
     return this.type === 'object' && this.subtype !== undefined &&
-        ['webassemblymemory', 'typedarray', 'dataview', 'arraybuffer'].includes(this.subtype);
+        ['webassemblymemory', 'typedarray', 'dataview', 'arraybuffer'].includes(this.subtype) &&
+        !RemoteObject.isEmptyArray(this);
   }
 }
 

package/front_end/entrypoints/greendev_floaty/FloatyEntrypoint.ts

@@ -254,6 +254,10 @@ class GreenDevFloaty {
     return messages;
   }
 
+  #formatError(errorMessage: string): string {
+    return `Error: '${errorMessage}' - Protip: to use AI features you need to be signed in.`;
+  }
+
   runConversation = async(): Promise<void> => {
     if (!this.#textField || !this.#node) {
       return;
@@ -276,7 +280,7 @@ class GreenDevFloaty {
       nodeDescription: document.querySelector('.green-dev-floaty-dialog-node-description')?.textContent,
     });
 
-    const {content: aiContent} = this.#addMessageInternal('Thinking...', false);
+    const aiContent = this.#addMessageInternal('Thinking...', false);
     this.#syncChannel.postMessage({
       type: 'new-message',
       text: 'Thinking...',
@@ -297,9 +301,9 @@ class GreenDevFloaty {
                 {type: 'update-last-message', text: result.text, sessionId: this.#backendNodeId});
             break;
           case ResponseType.ERROR:
-            aiContent.textContent = `Error: ${result.error}`;
+            aiContent.textContent = this.#formatError(result.error);
             this.#syncChannel.postMessage(
-                {type: 'update-last-message', text: `Error: ${result.error}`, sessionId: this.#backendNodeId});
+                {type: 'update-last-message', text: this.#formatError(result.error), sessionId: this.#backendNodeId});
             break;
           case ResponseType.SIDE_EFFECT:
             result.confirm(true);
@@ -316,7 +320,7 @@ class GreenDevFloaty {
     }
   };
 
-  #addMessageInternal(text: string, isUser: boolean): {content: HTMLDivElement, details?: HTMLDivElement} {
+  #addMessageInternal(text: string, isUser: boolean): HTMLDivElement {
     const messageElement = document.createElement('div');
     messageElement.className = `message ${isUser ? 'user-message' : 'ai-message'}`;
 
@@ -325,30 +329,11 @@ class GreenDevFloaty {
     content.textContent = text;
     messageElement.appendChild(content);
 
-    let details: HTMLDivElement|undefined;
-    if (!isUser) {
-      details = document.createElement('div');
-      details.className = 'message-details';
-      details.style.display = 'none';
-      messageElement.appendChild(details);
-
-      const toggle = document.createElement('div');
-      toggle.className = 'message-details-toggle';
-      toggle.textContent = 'Show details';
-      toggle.onclick = () => {
-        if (details) {
-          const isHidden = details.style.display === 'none';
-          details.style.display = isHidden ? 'block' : 'none';
-          toggle.textContent = isHidden ? 'Hide details' : 'Show details';
-        }
-      };
-      messageElement.appendChild(toggle);
-    }
     if (this.#chatContainer) {
       this.#chatContainer.appendChild(messageElement);
       this.#chatContainer.scrollTop = this.#chatContainer.scrollHeight;
     }
-    return {content, details};
+    return content;
   }
 }
 

package/front_end/entrypoints/greendev_floaty/floaty.css

@@ -251,7 +251,7 @@ html, body {
 }
 
 .green-dev-floaty-disclaimer {
-  font-size: 16px;
+  font-size: 15px;
   color: #666;
   text-align: center;
   margin-top: 8px;

package/front_end/entrypoints/greendev_floaty/greendev_floaty.ts

@@ -186,7 +186,7 @@ class GreenDevFloaty {
             aiContent.textContent = result.text;
             break;
           case ResponseType.ERROR:
-            aiContent.textContent = `Error: ${result.error}`;
+            aiContent.textContent = `Error: '${result.error}' - Protip: to use AI features you need to be signed in.`;
             break;
           case ResponseType.THOUGHT:
             if (aiDetails) {

package/front_end/generated/InspectorBackendCommands.ts

@@ -84,7 +84,7 @@ inspectorBackend.registerEnum("Audits.UnencodedDigestError", {MalformedDictionar
 inspectorBackend.registerEnum("Audits.ConnectionAllowlistError", {InvalidHeader: "InvalidHeader", MoreThanOneList: "MoreThanOneList", ItemNotInnerList: "ItemNotInnerList", InvalidAllowlistItemType: "InvalidAllowlistItemType", ReportingEndpointNotToken: "ReportingEndpointNotToken", InvalidUrlPattern: "InvalidUrlPattern"});
 inspectorBackend.registerEnum("Audits.GenericIssueErrorType", {FormLabelForNameError: "FormLabelForNameError", FormDuplicateIdForInputError: "FormDuplicateIdForInputError", FormInputWithNoLabelError: "FormInputWithNoLabelError", FormAutocompleteAttributeEmptyError: "FormAutocompleteAttributeEmptyError", FormEmptyIdAndNameAttributesForInputError: "FormEmptyIdAndNameAttributesForInputError", FormAriaLabelledByToNonExistingIdError: "FormAriaLabelledByToNonExistingIdError", FormInputAssignedAutocompleteValueToIdOrNameAttributeError: "FormInputAssignedAutocompleteValueToIdOrNameAttributeError", FormLabelHasNeitherForNorNestedInputError: "FormLabelHasNeitherForNorNestedInputError", FormLabelForMatchesNonExistingIdError: "FormLabelForMatchesNonExistingIdError", FormInputHasWrongButWellIntendedAutocompleteValueError: "FormInputHasWrongButWellIntendedAutocompleteValueError", ResponseWasBlockedByORB: "ResponseWasBlockedByORB", NavigationEntryMarkedSkippable: "NavigationEntryMarkedSkippable", AutofillAndManualTextPolicyControlledFeaturesInfo: "AutofillAndManualTextPolicyControlledFeaturesInfo", AutofillPolicyControlledFeatureInfo: "AutofillPolicyControlledFeatureInfo", ManualTextPolicyControlledFeatureInfo: "ManualTextPolicyControlledFeatureInfo"});
 inspectorBackend.registerEnum("Audits.ClientHintIssueReason", {MetaTagAllowListInvalidOrigin: "MetaTagAllowListInvalidOrigin", MetaTagModifiedHTML: "MetaTagModifiedHTML"});
-inspectorBackend.registerEnum("Audits.FederatedAuthRequestIssueReason", {ShouldEmbargo: "ShouldEmbargo", TooManyRequests: "TooManyRequests", WellKnownHttpNotFound: "WellKnownHttpNotFound", WellKnownNoResponse: "WellKnownNoResponse", WellKnownInvalidResponse: "WellKnownInvalidResponse", WellKnownListEmpty: "WellKnownListEmpty", WellKnownInvalidContentType: "WellKnownInvalidContentType", ConfigNotInWellKnown: "ConfigNotInWellKnown", WellKnownTooBig: "WellKnownTooBig", ConfigHttpNotFound: "ConfigHttpNotFound", ConfigNoResponse: "ConfigNoResponse", ConfigInvalidResponse: "ConfigInvalidResponse", ConfigInvalidContentType: "ConfigInvalidContentType", ClientMetadataHttpNotFound: "ClientMetadataHttpNotFound", ClientMetadataNoResponse: "ClientMetadataNoResponse", ClientMetadataInvalidResponse: "ClientMetadataInvalidResponse", ClientMetadataInvalidContentType: "ClientMetadataInvalidContentType", IdpNotPotentiallyTrustworthy: "IdpNotPotentiallyTrustworthy", DisabledInSettings: "DisabledInSettings", DisabledInFlags: "DisabledInFlags", ErrorFetchingSignin: "ErrorFetchingSignin", InvalidSigninResponse: "InvalidSigninResponse", AccountsHttpNotFound: "AccountsHttpNotFound", AccountsNoResponse: "AccountsNoResponse", AccountsInvalidResponse: "AccountsInvalidResponse", AccountsListEmpty: "AccountsListEmpty", AccountsInvalidContentType: "AccountsInvalidContentType", IdTokenHttpNotFound: "IdTokenHttpNotFound", IdTokenNoResponse: "IdTokenNoResponse", IdTokenInvalidResponse: "IdTokenInvalidResponse", IdTokenIdpErrorResponse: "IdTokenIdpErrorResponse", IdTokenCrossSiteIdpErrorResponse: "IdTokenCrossSiteIdpErrorResponse", IdTokenInvalidRequest: "IdTokenInvalidRequest", IdTokenInvalidContentType: "IdTokenInvalidContentType", ErrorIdToken: "ErrorIdToken", Canceled: "Canceled", RpPageNotVisible: "RpPageNotVisible", SilentMediationFailure: "SilentMediationFailure", ThirdPartyCookiesBlocked: "ThirdPartyCookiesBlocked", NotSignedInWithIdp: "NotSignedInWithIdp", MissingTransientUserActivation: "MissingTransientUserActivation", ReplacedByActiveMode: "ReplacedByActiveMode", InvalidFieldsSpecified: "InvalidFieldsSpecified", RelyingPartyOriginIsOpaque: "RelyingPartyOriginIsOpaque", TypeNotMatching: "TypeNotMatching", UiDismissedNoEmbargo: "UiDismissedNoEmbargo", CorsError: "CorsError", SuppressedBySegmentationPlatform: "SuppressedBySegmentationPlatform"});
+inspectorBackend.registerEnum("Audits.FederatedAuthRequestIssueReason", {ShouldEmbargo: "ShouldEmbargo", TooManyRequests: "TooManyRequests", WellKnownHttpNotFound: "WellKnownHttpNotFound", WellKnownNoResponse: "WellKnownNoResponse", WellKnownInvalidResponse: "WellKnownInvalidResponse", WellKnownListEmpty: "WellKnownListEmpty", WellKnownInvalidContentType: "WellKnownInvalidContentType", ConfigNotInWellKnown: "ConfigNotInWellKnown", WellKnownTooBig: "WellKnownTooBig", ConfigHttpNotFound: "ConfigHttpNotFound", ConfigNoResponse: "ConfigNoResponse", ConfigInvalidResponse: "ConfigInvalidResponse", ConfigInvalidContentType: "ConfigInvalidContentType", IdpNotPotentiallyTrustworthy: "IdpNotPotentiallyTrustworthy", DisabledInSettings: "DisabledInSettings", DisabledInFlags: "DisabledInFlags", ErrorFetchingSignin: "ErrorFetchingSignin", InvalidSigninResponse: "InvalidSigninResponse", AccountsHttpNotFound: "AccountsHttpNotFound", AccountsNoResponse: "AccountsNoResponse", AccountsInvalidResponse: "AccountsInvalidResponse", AccountsListEmpty: "AccountsListEmpty", AccountsInvalidContentType: "AccountsInvalidContentType", IdTokenHttpNotFound: "IdTokenHttpNotFound", IdTokenNoResponse: "IdTokenNoResponse", IdTokenInvalidResponse: "IdTokenInvalidResponse", IdTokenIdpErrorResponse: "IdTokenIdpErrorResponse", IdTokenCrossSiteIdpErrorResponse: "IdTokenCrossSiteIdpErrorResponse", IdTokenInvalidRequest: "IdTokenInvalidRequest", IdTokenInvalidContentType: "IdTokenInvalidContentType", ErrorIdToken: "ErrorIdToken", Canceled: "Canceled", RpPageNotVisible: "RpPageNotVisible", SilentMediationFailure: "SilentMediationFailure", NotSignedInWithIdp: "NotSignedInWithIdp", MissingTransientUserActivation: "MissingTransientUserActivation", ReplacedByActiveMode: "ReplacedByActiveMode", RelyingPartyOriginIsOpaque: "RelyingPartyOriginIsOpaque", TypeNotMatching: "TypeNotMatching", UiDismissedNoEmbargo: "UiDismissedNoEmbargo", CorsError: "CorsError", SuppressedBySegmentationPlatform: "SuppressedBySegmentationPlatform"});
 inspectorBackend.registerEnum("Audits.FederatedAuthUserInfoRequestIssueReason", {NotSameOrigin: "NotSameOrigin", NotIframe: "NotIframe", NotPotentiallyTrustworthy: "NotPotentiallyTrustworthy", NoAPIPermission: "NoApiPermission", NotSignedInWithIdp: "NotSignedInWithIdp", NoAccountSharingPermission: "NoAccountSharingPermission", InvalidConfigOrWellKnown: "InvalidConfigOrWellKnown", InvalidAccountsResponse: "InvalidAccountsResponse", NoReturningUserFromFetchedAccounts: "NoReturningUserFromFetchedAccounts"});
 inspectorBackend.registerEnum("Audits.PartitioningBlobURLInfo", {BlockedCrossPartitionFetching: "BlockedCrossPartitionFetching", EnforceNoopenerForNavigation: "EnforceNoopenerForNavigation"});
 inspectorBackend.registerEnum("Audits.ElementAccessibilityIssueReason", {DisallowedSelectChild: "DisallowedSelectChild", DisallowedOptGroupChild: "DisallowedOptGroupChild", NonPhrasingContentOptionChild: "NonPhrasingContentOptionChild", InteractiveContentOptionChild: "InteractiveContentOptionChild", InteractiveContentLegendChild: "InteractiveContentLegendChild", InteractiveContentSummaryDescendant: "InteractiveContentSummaryDescendant"});

package/front_end/generated/SupportedCSSProperties.js

@@ -4552,6 +4552,7 @@ export const generatedProperties = [
    "uppercase",
    "lowercase",
    "full-width",
+   "full-size-kana",
    "none",
    "math-auto"
   ],
@@ -7048,6 +7049,7 @@ export const generatedPropertyValues = {
    "uppercase",
    "lowercase",
    "full-width",
+   "full-size-kana",
    "none",
    "math-auto"
   ]

package/front_end/generated/protocol.ts

@@ -1292,10 +1292,6 @@ export namespace Audits {
     ConfigNoResponse = 'ConfigNoResponse',
     ConfigInvalidResponse = 'ConfigInvalidResponse',
     ConfigInvalidContentType = 'ConfigInvalidContentType',
-    ClientMetadataHttpNotFound = 'ClientMetadataHttpNotFound',
-    ClientMetadataNoResponse = 'ClientMetadataNoResponse',
-    ClientMetadataInvalidResponse = 'ClientMetadataInvalidResponse',
-    ClientMetadataInvalidContentType = 'ClientMetadataInvalidContentType',
     IdpNotPotentiallyTrustworthy = 'IdpNotPotentiallyTrustworthy',
     DisabledInSettings = 'DisabledInSettings',
     DisabledInFlags = 'DisabledInFlags',
@@ -1317,11 +1313,9 @@ export namespace Audits {
     Canceled = 'Canceled',
     RpPageNotVisible = 'RpPageNotVisible',
     SilentMediationFailure = 'SilentMediationFailure',
-    ThirdPartyCookiesBlocked = 'ThirdPartyCookiesBlocked',
     NotSignedInWithIdp = 'NotSignedInWithIdp',
     MissingTransientUserActivation = 'MissingTransientUserActivation',
     ReplacedByActiveMode = 'ReplacedByActiveMode',
-    InvalidFieldsSpecified = 'InvalidFieldsSpecified',
     RelyingPartyOriginIsOpaque = 'RelyingPartyOriginIsOpaque',
     TypeNotMatching = 'TypeNotMatching',
     UiDismissedNoEmbargo = 'UiDismissedNoEmbargo',

package/front_end/models/ai_assistance/agents/ContextSelectionAgent.snapshot.txt

@@ -31,7 +31,7 @@ Content:
   "function_declarations": [
     {
       "name": "listNetworkRequests",
-      "description": "Gives a list of network requests including URL, status code, and duration in ms",
+      "description": "Gives a list of network requests including URL, status code, and duration in ms.",
       "parameters": {
         "type": 6,
         "description": "",
@@ -42,7 +42,7 @@ Content:
     },
     {
       "name": "selectNetworkRequest",
-      "description": "From the list of selected request select one to debug",
+      "description": "Selects a specific network request to further provide information about. Use this when asked about network requests issues.",
       "parameters": {
         "type": 6,
         "description": "",
@@ -72,7 +72,7 @@ Content:
     },
     {
       "name": "selectSourceFile",
-      "description": "Returns a list of all files in the project.",
+      "description": "Selects a source file. Use this when asked about files on the page.",
       "parameters": {
         "type": 6,
         "description": "",
@@ -83,7 +83,7 @@ Content:
         "properties": {
           "name": {
             "type": 1,
-            "description": "The name of the file",
+            "description": "The name of the file you want to select.",
             "nullable": false
           }
         }
@@ -91,7 +91,7 @@ Content:
     },
     {
       "name": "performanceRecordAndReload",
-      "description": "Start a new performance recording and reload the page.",
+      "description": "Records a new performance trace, to help debug performance issue.",
       "parameters": {
         "type": 6,
         "description": "",
@@ -102,7 +102,7 @@ Content:
     },
     {
       "name": "inspectDom",
-      "description": "Prompts user to select a DOM element from the page.",
+      "description": "Prompts user to select a DOM element from the page. Use this when you don't know which element is selected.",
       "parameters": {
         "type": 6,
         "description": "",

package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts

@@ -32,7 +32,7 @@ You aim to help developers of all levels, prioritizing teaching web concepts as
 
 # Considerations
 * Determine what the question the domain of the question is - styling, network, sources, performance or other part of DevTools.
-* When possible proactively try to gather additional data and select context that they user may find relevant to the question they are asking utilizing the function calls available to you.
+* Proactively try to gather additional data. If a select specific data can be selected, select one.
 * Avoid making assumptions without sufficient evidence, and always seek further clarification if needed.
 * Always explore multiple possible explanations for the observed behavior before settling on a conclusion.
 * When presenting solutions, clearly distinguish between the primary cause and contributing factors.
@@ -85,7 +85,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
     this.#onInspectElement = opts.onInspectElement;
 
     this.declareFunction<Record<string, never>>('listNetworkRequests', {
-      description: `Gives a list of network requests including URL, status code, and duration in ms`,
+      description: `Gives a list of network requests including URL, status code, and duration in ms.`,
       parameters: {
         type: Host.AidaClient.ParametersTypes.OBJECT,
         description: '',
@@ -116,6 +116,12 @@ export class ContextSelectionAgent extends AiAgent<never> {
           });
         }
 
+        if (requests.length === 0) {
+          return {
+            error: 'No requests recorded by DevTools',
+          };
+        }
+
         return {
           result: requests,
         };
@@ -123,7 +129,8 @@ export class ContextSelectionAgent extends AiAgent<never> {
     });
 
     this.declareFunction<{url: string}>('selectNetworkRequest', {
-      description: `From the list of selected request select one to debug`,
+      description:
+          `Selects a specific network request to further provide information about. Use this when asked about network requests issues.`,
       parameters: {
         type: Host.AidaClient.ParametersTypes.OBJECT,
         description: '',
@@ -191,7 +198,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
     });
 
     this.declareFunction<{name: string}>('selectSourceFile', {
-      description: `Returns a list of all files in the project.`,
+      description: `Selects a source file. Use this when asked about files on the page.`,
       parameters: {
         type: Host.AidaClient.ParametersTypes.OBJECT,
         description: '',
@@ -200,14 +207,14 @@ export class ContextSelectionAgent extends AiAgent<never> {
         properties: {
           name: {
             type: Host.AidaClient.ParametersTypes.STRING,
-            description: 'The name of the file',
+            description: 'The name of the file you want to select.',
             nullable: false,
           },
         },
       },
       displayInfoFromArgs: args => {
         return {
-          title: lockedString('Getting source file'),
+          title: lockedString('Getting source file…'),
           action: `selectSourceFile(${args.name})`,
         };
       },
@@ -225,7 +232,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
     });
 
     this.declareFunction('performanceRecordAndReload', {
-      description: 'Start a new performance recording and reload the page.',
+      description: 'Records a new performance trace, to help debug performance issue.',
       parameters: {
         type: Host.AidaClient.ParametersTypes.OBJECT,
         description: '',
@@ -254,7 +261,8 @@ export class ContextSelectionAgent extends AiAgent<never> {
     });
 
     this.declareFunction<Record<string, never>>('inspectDom', {
-      description: `Prompts user to select a DOM element from the page.`,
+      description:
+          `Prompts user to select a DOM element from the page. Use this when you don't know which element is selected.`,
       parameters: {
         type: Host.AidaClient.ParametersTypes.OBJECT,
         description: '',
@@ -264,7 +272,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
       },
       displayInfoFromArgs: () => {
         return {
-          title: lockedString('Please select an element on the page...'),
+          title: lockedString('Please select an element on the page…'),
           action: 'selectElement()',
         };
       },

package/front_end/models/ai_assistance/agents/NetworkAgent.ts

@@ -80,10 +80,6 @@ const UIStringsNotTranslate = {
    * @description Title text for request timing details.
    */
   timing: 'Timing',
-  /**
-   * @description Prefix text for response status.
-   */
-  responseStatus: 'Response Status',
   /**
    * @description Title text for request initiator chain.
    */
@@ -178,8 +174,8 @@ async function createContextDetailsForNetworkAgent(
 
   const responseContextDetail: ContextDetail = {
     title: lockedString(UIStringsNotTranslate.response),
-    text: lockedString(UIStringsNotTranslate.responseStatus) + ': ' + request.statusCode + ' ' + request.statusText +
-        `\n\n${formatter.formatResponseHeaders()}` + responseBodyString,
+    text: formatter.formatResponseHeaders() + responseBodyString +
+        `\n\n${formatter.formatStatus()}${formatter.formatFailureReasons()}`,
   };
   const timingContextDetail: ContextDetail = {
     title: lockedString(UIStringsNotTranslate.timing),