chrome-devtools-frontend 1.0.1526630 → 1.0.1528866

package/front_end/panels/network/RequestHTMLView.ts

@@ -51,6 +51,7 @@ export class RequestHTMLView extends UI.Widget.VBox {
   }
 
   override willHide(): void {
+    super.willHide();
     this.requestUpdate();
   }
 

package/front_end/panels/network/RequestInitiatorView.ts

@@ -140,6 +140,7 @@ export class RequestInitiatorView extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     if (this.hasShown) {
       return;
     }

package/front_end/panels/network/RequestPayloadView.ts

@@ -145,6 +145,7 @@ export class RequestPayloadView extends UI.Widget.VBox {
   }
 
   override willHide(): void {
+    super.willHide();
     this.request.removeEventListener(SDK.NetworkRequest.Events.REQUEST_HEADERS_CHANGED, this.refreshFormData, this);
   }
 

package/front_end/panels/network/RequestPreviewView.ts

@@ -53,6 +53,7 @@ export class RequestPreviewView extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     void this.doShowPreview();
   }
 

package/front_end/panels/network/RequestResponseView.ts

@@ -94,6 +94,7 @@ export class RequestResponseView extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.requestUpdate();
   }
 

package/front_end/panels/network/RequestTimingView.ts

@@ -634,6 +634,7 @@ export class RequestTimingView extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.request.addEventListener(SDK.NetworkRequest.Events.TIMING_CHANGED, this.refresh, this);
     this.request.addEventListener(SDK.NetworkRequest.Events.FINISHED_LOADING, this.refresh, this);
     this.calculator.addEventListener(NetworkTimeCalculator.Events.BOUNDARIES_CHANGED, this.boundaryChanged, this);
@@ -641,6 +642,7 @@ export class RequestTimingView extends UI.Widget.VBox {
   }
 
   override willHide(): void {
+    super.willHide();
     this.request.removeEventListener(SDK.NetworkRequest.Events.TIMING_CHANGED, this.refresh, this);
     this.request.removeEventListener(SDK.NetworkRequest.Events.FINISHED_LOADING, this.refresh, this);
     this.calculator.removeEventListener(NetworkTimeCalculator.Events.BOUNDARIES_CHANGED, this.boundaryChanged, this);

package/front_end/panels/network/ResourceDirectSocketChunkView.ts

@@ -79,6 +79,7 @@ export class ResourceDirectSocketChunkView extends ResourceChunkView<SDK.Network
   }
 
   override willHide(): void {
+    super.willHide();
     this.request.removeEventListener(
         SDK.NetworkRequest.Events.DIRECTSOCKET_CHUNK_ADDED, this.onDirectSocketChunkAdded, this);
   }

package/front_end/panels/network/ResourceWebSocketFrameView.ts

@@ -120,6 +120,7 @@ export class ResourceWebSocketFrameView extends ResourceChunkView<SDK.NetworkReq
   }
 
   override willHide(): void {
+    super.willHide();
     this.request.removeEventListener(SDK.NetworkRequest.Events.WEBSOCKET_FRAME_ADDED, this.onWebSocketFrameAdded, this);
   }
 

package/front_end/panels/network/components/RequestHeadersView.ts

@@ -127,6 +127,7 @@ export class RequestHeadersView extends LegacyWrapper.LegacyWrapper.WrappableCom
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.#request.addEventListener(SDK.NetworkRequest.Events.REMOTE_ADDRESS_CHANGED, this.#refreshHeadersView, this);
     this.#request.addEventListener(SDK.NetworkRequest.Events.FINISHED_LOADING, this.#refreshHeadersView, this);
     this.#request.addEventListener(SDK.NetworkRequest.Events.REQUEST_HEADERS_CHANGED, this.#refreshHeadersView, this);
@@ -137,6 +138,7 @@ export class RequestHeadersView extends LegacyWrapper.LegacyWrapper.WrappableCom
   }
 
   override willHide(): void {
+    super.willHide();
     this.#request.removeEventListener(SDK.NetworkRequest.Events.REMOTE_ADDRESS_CHANGED, this.#refreshHeadersView, this);
     this.#request.removeEventListener(SDK.NetworkRequest.Events.FINISHED_LOADING, this.#refreshHeadersView, this);
     this.#request.removeEventListener(

package/front_end/panels/network/components/RequestTrustTokensView.ts

@@ -112,11 +112,13 @@ export class RequestTrustTokensView extends LegacyWrapper.LegacyWrapper.Wrappabl
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.#request.addEventListener(SDK.NetworkRequest.Events.TRUST_TOKEN_RESULT_ADDED, this.render, this);
     void this.render();
   }
 
   override willHide(): void {
+    super.willHide();
     this.#request.removeEventListener(SDK.NetworkRequest.Events.TRUST_TOKEN_RESULT_ADDED, this.render, this);
   }
 

package/front_end/panels/performance_monitor/PerformanceMonitor.ts

@@ -157,6 +157,7 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
   }
 
   override wasShown(): void {
+    super.wasShown();
     if (!this.model) {
       return;
     }
@@ -176,6 +177,7 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
   }
 
   override willHide(): void {
+    super.willHide();
     if (!this.model) {
       return;
     }

package/front_end/panels/profiler/HeapSnapshotDataGrids.ts

@@ -212,6 +212,7 @@ export class HeapSnapshotSortableDataGrid extends Common.ObjectWrapper
   }
 
   override wasShown(): void {
+    super.wasShown();
     if (this.nameFilter) {
       this.nameFilter.addEventListener(UI.Toolbar.ToolbarInput.Event.TEXT_CHANGED, this.onNameFilterChanged, this);
       this.updateVisibleNodes(true);
@@ -228,6 +229,7 @@ export class HeapSnapshotSortableDataGrid extends Common.ObjectWrapper
   }
 
   override willHide(): void {
+    super.willHide();
     if (this.nameFilter) {
       this.nameFilter.removeEventListener(UI.Toolbar.ToolbarInput.Event.TEXT_CHANGED, this.onNameFilterChanged, this);
     }

package/front_end/panels/profiler/HeapSnapshotView.ts

@@ -143,6 +143,11 @@ const UIStrings = {
    * objects kept alive by the DevTools console
    */
   objectsRetainedByConsole: 'Objects retained by DevTools Console',
+  /**
+   * @description An option which will filter the heap snapshot to show only
+   * objects retained by event handlers
+   */
+  objectsRetainedByEventHandlers: 'Objects retained by Event Handlers',
   /**
    * @description Text for the summary view
    */
@@ -624,6 +629,7 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
   }
 
   override willHide(): void {
+    super.willHide();
     this.currentSearchResultIndex = -1;
     this.popoverHelper.hidePopover();
   }
@@ -771,6 +777,7 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     {uiName: i18nString(UIStrings.duplicatedStrings), filterName: 'duplicatedStrings'},
     {uiName: i18nString(UIStrings.objectsRetainedByDetachedDomNodes), filterName: 'objectsRetainedByDetachedDomNodes'},
     {uiName: i18nString(UIStrings.objectsRetainedByConsole), filterName: 'objectsRetainedByConsole'},
+    {uiName: i18nString(UIStrings.objectsRetainedByEventHandlers), filterName: 'objectsRetainedByEventHandlers'},
   ];
 
   changeFilter(): void {

package/front_end/panels/profiler/IsolateSelector.ts

@@ -102,6 +102,7 @@ export class IsolateSelector extends UI.Widget.VBox implements UI.ListControl.Li
   }
 
   override willHide(): void {
+    super.willHide();
     SDK.IsolateManager.IsolateManager.instance().removeEventListener(
         SDK.IsolateManager.Events.MEMORY_CHANGED, this.heapStatsChanged, this);
   }

package/front_end/panels/profiler/LiveHeapProfileView.ts

@@ -178,6 +178,7 @@ export class LiveHeapProfileView extends UI.Widget.VBox {
   }
 
   override willHide(): void {
+    super.willHide();
     ++this.currentPollId;
     this.setting.removeChangeListener(this.settingChanged, this);
   }

package/front_end/panels/profiler/ProfileView.ts

@@ -325,6 +325,7 @@ export class ProfileView extends UI.View.SimpleView implements UI.SearchableView
   }
 
   override willHide(): void {
+    super.willHide();
     this.currentSearchResultIndex = -1;
   }
 

package/front_end/panels/protocol_monitor/ProtocolMonitor.ts

@@ -530,6 +530,7 @@ export class ProtocolMonitorImpl extends UI.Panel.Panel {
   }
 
   override wasShown(): void {
+    super.wasShown();
     if (this.started) {
       return;
     }

package/front_end/panels/recorder/RecorderPanel.ts

@@ -36,12 +36,14 @@ export class RecorderPanel extends UI.Panel.Panel {
   }
 
   override wasShown(): void {
+    super.wasShown();
     UI.Context.Context.instance().setFlavor(RecorderPanel, this);
     // Focus controller so shortcuts become active
     this.#controller.focus();
   }
 
   override willHide(): void {
+    super.willHide();
     UI.Context.Context.instance().setFlavor(RecorderPanel, null);
   }
 

package/front_end/panels/screencast/ScreencastView.ts

@@ -175,6 +175,7 @@ export class ScreencastView extends UI.Widget.VBox implements SDK.OverlayModel.H
   }
 
   override willHide(): void {
+    super.willHide();
     this.stopCasting();
   }
 

package/front_end/panels/search/SearchView.ts

@@ -542,6 +542,7 @@ export class SearchView extends UI.Widget.VBox {
   }
 
   override willHide(): void {
+    super.willHide();
     this.#stopSearch();
   }
 

package/front_end/panels/settings/AISettingsTab.ts

@@ -474,7 +474,7 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen
       }
     } else if (setting.name === 'ai-assistance-enabled' && !setting.get()) {
       // If the "AI Assistance" is toggled off, we remove all the history entries related to the feature.
-      void AiAssistanceModel.AiHistoryStorage.instance().deleteAll();
+      void AiAssistanceModel.AiHistoryStorage.AiHistoryStorage.instance().deleteAll();
     }
     void this.render();
   }
@@ -551,7 +551,7 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen
     if (!settingData) {
       return Lit.nothing;
     }
-    const disabledReasons = AiAssistanceModel.getDisabledReasons(this.#aidaAvailability);
+    const disabledReasons = AiAssistanceModel.AiUtils.getDisabledReasons(this.#aidaAvailability);
     const isDisabled = disabledReasons.length > 0;
     const disabledReasonsJoined = disabledReasons.join('\n') || undefined;
     const detailsClasses = {
@@ -639,7 +639,7 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen
   }
 
   override async render(): Promise<void> {
-    const disabledReasons = AiAssistanceModel.getDisabledReasons(this.#aidaAvailability);
+    const disabledReasons = AiAssistanceModel.AiUtils.getDisabledReasons(this.#aidaAvailability);
 
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off

package/front_end/panels/settings/WorkspaceSettingsTab.ts

@@ -106,6 +106,7 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.#eventListeners = [
       Persistence.IsolatedFileSystemManager.IsolatedFileSystemManager.instance().addEventListener(
           Persistence.IsolatedFileSystemManager.Events.FileSystemAdded, this.requestUpdate.bind(this)),
@@ -117,6 +118,7 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
   }
 
   override willHide(): void {
+    super.willHide();
     Common.EventTarget.removeEventListeners(this.#eventListeners);
     this.#eventListeners = [];
   }

package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts

@@ -868,14 +868,14 @@ export class UserAgentClientHintsForm extends HTMLElement {
             <devtools-icon name=triangle-down></devtools-icon>
             ${i18nString(UIStrings.title)}
           </div>
-          <devtools-icon class=info-icon name=info title=${i18nString(UIStrings.userAgentClientHintsInfo)}></devtools-icon>
+          <devtools-icon tabindex=${this.#isFormDisabled ? '-1' : '0'} class=info-icon name=info aria-label=${i18nString(UIStrings.userAgentClientHintsInfo)} title=${i18nString(UIStrings.userAgentClientHintsInfo)}></devtools-icon>
           <x-link
            tabindex=${this.#isFormDisabled ? '-1' : '0'}
            href="https://web.dev/user-agent-client-hints/"
            target="_blank"
            class="link"
            @keypress=${this.#handleLinkPress}
-           aria-label=${i18nString(UIStrings.userAgentClientHintsInfo)}
+           aria-label=${i18nString(UIStrings.learnMore)}
            jslog=${VisualLogging.link('learn-more').track({click: true})}
           >
             ${i18nString(UIStrings.learnMore)}

package/front_end/panels/sources/AiCodeCompletionPlugin.ts

@@ -4,6 +4,7 @@
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
+import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as AiCodeCompletion from '../../models/ai_code_completion/ai_code_completion.js';
 import type * as Workspace from '../../models/workspace/workspace.js';
@@ -334,6 +335,17 @@ export class AiCodeCompletionPlugin extends Plugin {
   }
 
   #isAiCodeCompletionEnabled(): boolean {
+    const devtoolsLocale = i18n.DevToolsLocale.DevToolsLocale.instance();
+    const aidaAvailability = Root.Runtime.hostConfig.aidaAvailability;
+    if (!devtoolsLocale.locale.startsWith('en-')) {
+      return false;
+    }
+    if (aidaAvailability?.blockedByGeo) {
+      return false;
+    }
+    if (aidaAvailability?.blockedByAge) {
+      return false;
+    }
     return Boolean(Root.Runtime.hostConfig.devToolsAiCodeCompletion?.enabled);
   }
 

package/front_end/panels/sources/BreakpointsView.ts

@@ -720,6 +720,7 @@ export class BreakpointsView extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.requestUpdate();
   }
 

package/front_end/panels/sources/DebuggerPlugin.ts

@@ -449,6 +449,7 @@ export class DebuggerPlugin extends Plugin {
   }
 
   override willHide(): void {
+    super.willHide();
     this.popoverHelper?.hidePopover();
   }
 

package/front_end/panels/sources/UISourceCodeFrame.ts

@@ -6,6 +6,7 @@
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
+import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as FormatterActions from '../../entrypoints/formatter_worker/FormatterActions.js';  // eslint-disable-line rulesdir/es-modules-import
 import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
@@ -320,8 +321,7 @@ export class UISourceCodeFrame extends Common.ObjectWrapper
       AiWarningInfobarPlugin,
     ];
 
-    if (Root.Runtime.hostConfig.aidaAvailability?.enabled &&
-        Root.Runtime.hostConfig.devToolsAiCodeCompletion?.enabled) {
+    if (this.#isAiCodeCompletionEnabled()) {
       sourceFramePluginsList.push(AiCodeCompletionPlugin);
     }
     return sourceFramePluginsList;
@@ -511,6 +511,21 @@ export class UISourceCodeFrame extends Common.ObjectWrapper
         this.#uiSourceCode.url().startsWith('debugger://'));
     Host.userMetrics.sourcesPanelFileOpened(mediaType);
   }
+
+  static #isAiCodeCompletionEnabled(): boolean {
+    const devtoolsLocale = i18n.DevToolsLocale.DevToolsLocale.instance();
+    const aidaAvailability = Root.Runtime.hostConfig.aidaAvailability;
+    if (!devtoolsLocale.locale.startsWith('en-')) {
+      return false;
+    }
+    if (aidaAvailability?.blockedByGeo) {
+      return false;
+    }
+    if (aidaAvailability?.blockedByAge) {
+      return false;
+    }
+    return Boolean(aidaAvailability?.enabled && Root.Runtime.hostConfig.devToolsAiCodeCompletion?.enabled);
+  }
 }
 
 function getIconDataForLevel(level: Workspace.UISourceCode.Message.Level): IconButton.Icon.IconWithName {

package/front_end/panels/timeline/README.md

@@ -28,8 +28,8 @@ This option loads the DevTools frontend in a browser tab in Chrome, but requires
 
 1.  Head to `devtools-frontend/test/unittests/fixtures/traces` and run `npx statikk --cors`. [This is a tool built by @paulirish to serve local files on a server](https://github.com/paulirish/statikk).
 2.  Build and run the Chrome for Testing binary from devtools-frontend.
-3.  Visit `devtools://devtools/bundled/devtools_app.html` and let it load (you only need to do this the first time you load up the Chrome for Testing binary).
-4.  Update the URL by appending `?loadTimelineFromURL=http://localhost:1234/name-of-trace-file.json`. **Swap the port to the one `statikk` is using on your machine**.
+3.  Visit `devtools://devtools/bundled/trace_app.html` and let it load (you only need to do this the first time you load up the Chrome for Testing binary).
+4.  Update the URL by appending `?traceURL=http://localhost:1234/name-of-trace-file.json`. **Swap the port to the one `statikk` is using on your machine**.
 5.  When you make changes and rebuild DevTools, simply refresh the URL! **Make sure you disable network caching in your DevTools on DevTools instance.**
 
 Each one has its pros and cons, but typically **this option is preferred** for quick iteration because you don't have to manually record or import a trace every time you reload.

package/front_end/panels/timeline/TimelineFlameChartDataProvider.ts

@@ -252,7 +252,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
 
     const contextMenu = new UI.ContextMenu.ContextMenu(mouseEvent);
     if (perfAIEntryPointEnabled && this.parsedTrace) {
-      const callTree = AIAssistance.AICallTree.fromEvent(entry, this.parsedTrace);
+      const callTree = AIAssistance.AICallTree.AICallTree.fromEvent(entry, this.parsedTrace);
       if (callTree) {
         const action = UI.ActionRegistry.ActionRegistry.instance().getAction(PERF_AI_ACTION_ID);
 

package/front_end/panels/timeline/TimelineFlameChartView.ts

@@ -1408,6 +1408,7 @@ export class TimelineFlameChartView extends Common.ObjectWrapper.eventMixin<Even
   }
 
   override willHide(): void {
+    super.willHide();
     this.#networkPersistedGroupConfigSetting.removeChangeListener(this.resizeToPreferredHeights, this);
     Workspace.IgnoreListManager.IgnoreListManager.instance().removeChangeListener(this.#boundRefreshAfterIgnoreList);
   }
@@ -1535,16 +1536,16 @@ export class TimelineFlameChartView extends Common.ObjectWrapper.eventMixin<Even
 
       const event = selectionIsEvent(selection) ? selection.event : null;
 
-      let focus = UI.Context.Context.instance().flavor(AIAssistance.AgentFocus);
+      let focus = UI.Context.Context.instance().flavor(AIAssistance.AIContext.AgentFocus);
       if (focus) {
         focus = focus.withEvent(event);
       } else if (event) {
-        focus = AIAssistance.AgentFocus.fromEvent(this.#parsedTrace, event);
+        focus = AIAssistance.AIContext.AgentFocus.fromEvent(this.#parsedTrace, event);
       } else {
         focus = null;
       }
 
-      UI.Context.Context.instance().setFlavor(AIAssistance.AgentFocus, focus);
+      UI.Context.Context.instance().setFlavor(AIAssistance.AIContext.AgentFocus, focus);
     });
   }
 

package/front_end/panels/timeline/TimelineLayersView.ts

@@ -55,6 +55,7 @@ export class TimelineLayersView extends UI.SplitWidget.SplitWidget {
   }
 
   override wasShown(): void {
+    super.wasShown();
     if (this.updateWhenVisible) {
       this.updateWhenVisible = false;
       this.update();