chrome-devtools-frontend 1.0.1030457 → 1.0.1031822

package/front_end/panels/elements/components/CSSHintDetailsView.ts

@@ -23,7 +23,7 @@ interface Hint {
     getHintPrefix(): string;
     getHintMessage(): string;
     getPossibleFixMessage(): string|null;
-    getLearnMoreLink(): string|null;
+    getLearnMoreLink(): string|undefined;
 }
 
 export class CSSHintDetailsView extends HTMLElement {
@@ -39,25 +39,28 @@ export class CSSHintDetailsView extends HTMLElement {
     }
 
     #render(): void {
-        render(html`
-            <div class="hint-popup-wrapper">
-                <div class="hint-popup-reason">
-                    <strong>${this.#authoringHint.getHintPrefix()}:</strong> ${Directives.unsafeHTML(this.#authoringHint.getHintMessage())}
-                </div>
-                ${this.#authoringHint.getPossibleFixMessage() ? html`
-                    <div class="hint-popup-possible-fix">
-                        ${Directives.unsafeHTML(this.#authoringHint.getPossibleFixMessage())}
-                        ${this.#authoringHint.getLearnMoreLink() ? html`
-                            <x-link id='learn-more' href='${this.#authoringHint.getLearnMoreLink()}' class='clickable underlined unbreakable-text'}>
-                                ${i18nString(UIStrings.learnMore)}
-                            </x-link>
-                        `: ''}
-                    </div>
-                ` : ''}
-            </div>
-        `, this.#shadow, {
-            host: this,
-          });
+      const link = this.#authoringHint.getLearnMoreLink();
+      // clang-format off
+      render(html`
+        <div class="hint-popup-wrapper">
+          <div class="hint-popup-reason">
+              <strong>${this.#authoringHint.getHintPrefix()}:</strong> ${Directives.unsafeHTML(this.#authoringHint.getHintMessage())}
+          </div>
+          ${this.#authoringHint.getPossibleFixMessage() ? html`
+              <div class="hint-popup-possible-fix">
+                  ${Directives.unsafeHTML(this.#authoringHint.getPossibleFixMessage())}
+                  ${link ? html`
+                      <x-link id="learn-more" href=${link} class="clickable underlined unbreakable-text"}>
+                          ${i18nString(UIStrings.learnMore)}
+                      </x-link>
+                  `: ''}
+              </div>
+          ` : ''}
+        </div>
+      `, this.#shadow, {
+        host: this,
+      });
+      // clang-format on
     }
 }
 

package/front_end/panels/elements/components/accessibilityTreeNode.css

@@ -4,6 +4,15 @@
  * found in the LICENSE file.
  */
 
+.container {
+  width: 100%;
+  display: inline-block;
+}
+
+.container:hover {
+  background-color: var(--item-hover-color);
+}
+
 span {
   color: var(--color-syntax-8);
   font-family: var(--monospace-font-family);

package/front_end/panels/elements/components/cssHintDetailsView.css

@@ -4,15 +4,21 @@
  * found in the LICENSE file.
  */
 
+:host {
+  padding: 6px;
+}
+
 .hint-popup-wrapper {
-  width: 400px;
-  line-height: 1.1;
+  max-width: 232px;
   font-size: 12px;
+  line-height: 1.4;
 }
 
 code {
   background-color: var(--color-background-elevation-1);
   padding: 0 2px;
+  font-size: var(--source-code-font-size);
+  font-family: var(--source-code-font-family);
 }
 
 .property {

package/front_end/panels/elements/stylesSectionTree.css

@@ -159,7 +159,7 @@ ol.expanded {
   position: absolute;
   top: 0;
   bottom: 0;
-  margin: auto auto auto 5px;
+  margin: auto auto auto 3px;
   display: inline-block;
   cursor: pointer;
   transform: scale(0.9);

package/front_end/panels/issues/AttributionReportingIssueDetailsView.ts

@@ -22,6 +22,10 @@ const UIStrings = {
    * @description Noun, label for the column showing the invalid header value in the issue details table.
    */
   invalidHeaderValue: 'Invalid Header Value',
+  /**
+   * @description Noun, label for the column showing the maximum concurrent registrations header value in the issue details table.
+   */
+  maximumConcurrentRegistrations: 'Maximum Concurrent Registrations',
   /**
    * @description Noun, label for the column showing the associated network request in the issue details table.
    */
@@ -71,6 +75,10 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         this.appendColumnTitle(header, i18nString(UIStrings.element));
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.TooManyConcurrentRequests:
+        this.appendColumnTitle(header, i18nString(UIStrings.element));
+        this.appendColumnTitle(header, i18nString(UIStrings.maximumConcurrentRegistrations));
+        break;
     }
 
     this.affectedResources.appendChild(header);
@@ -107,6 +115,10 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         await this.#appendElementOrEmptyCell(element, issue);
         this.#appendRequestOrEmptyCell(element, details.request);
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.TooManyConcurrentRequests:
+        await this.#appendElementOrEmptyCell(element, issue);
+        this.appendIssueDetailCell(element, details.invalidParameter || '');
+        break;
     }
 
     this.affectedResources.appendChild(element);

package/front_end/panels/network/components/RequestHeadersView.css

@@ -64,6 +64,7 @@ div.raw-headers-row {
   font-weight: 500;
   width: 160px;
   flex-shrink: 0;
+  text-transform: capitalize;
 }
 
 .header-value {

package/front_end/panels/network/components/RequestHeadersView.ts

@@ -311,6 +311,10 @@ export class RequestHeadersComponent extends HTMLElement {
       this.#render();
     };
 
+    if (!mergedHeaders.length) {
+      return LitHtml.nothing;
+    }
+
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     return html`
@@ -395,6 +399,9 @@ export class RequestHeadersComponent extends HTMLElement {
       return Platform.StringUtilities.compare(a.name.toLowerCase(), b.name.toLowerCase());
     });
     const requestHeadersText = this.#request.requestHeadersText();
+    if (!headers.length && requestHeadersText !== undefined) {
+      return LitHtml.nothing;
+    }
 
     const toggleShowRaw = (): void => {
       this.#showRequestHeadersText = !this.#showRequestHeadersText;

package/front_end/panels/sources/FilteredUISourceCodeListProvider.ts

@@ -4,7 +4,9 @@
 
 import type * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Bindings from '../../models/bindings/bindings.js';
 import * as Persistence from '../../models/persistence/persistence.js';
+import * as Root from '../../core/root/root.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as QuickOpen from '../../ui/legacy/components/quick_open/quick_open.js';
 import * as UI from '../../ui/legacy/legacy.js';
@@ -62,6 +64,11 @@ export class FilteredUISourceCodeListProvider extends QuickOpen.FilteredListWidg
     if (this.uiSourceCodeUrls.has(uiSourceCode.url())) {
       return false;
     }
+    if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.JUST_MY_CODE) &&
+        Bindings.IgnoreListManager.IgnoreListManager.instance().isUserOrSourceMapIgnoreListedUISourceCode(
+            uiSourceCode)) {
+      return false;
+    }
     const binding = Persistence.Persistence.PersistenceImpl.instance().binding(uiSourceCode);
     return !binding || binding.fileSystem === uiSourceCode;
   }

package/front_end/panels/sources/NavigatorView.ts

@@ -211,6 +211,16 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
       this.navigatorGroupByAuthoredExperiment = Root.Runtime.ExperimentName.AUTHORED_DEPLOYED_GROUPING;
     }
 
+    Common.Settings.Settings.instance()
+        .moduleSetting('skipStackFramesPattern')
+        .addChangeListener(this.ignoreListChanged.bind(this));
+    Common.Settings.Settings.instance()
+        .moduleSetting('skipContentScripts')
+        .addChangeListener(this.ignoreListChanged.bind(this));
+    Common.Settings.Settings.instance()
+        .moduleSetting('automaticallyIgnoreListKnownThirdPartyScripts')
+        .addChangeListener(this.ignoreListChanged.bind(this));
+
     this.initGrouping();
 
     Persistence.Persistence.PersistenceImpl.instance().addEventListener(
@@ -443,6 +453,12 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
   }
 
   private addUISourceCode(uiSourceCode: Workspace.UISourceCode.UISourceCode): void {
+    if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.JUST_MY_CODE) &&
+        Bindings.IgnoreListManager.IgnoreListManager.instance().isUserOrSourceMapIgnoreListedUISourceCode(
+            uiSourceCode)) {
+      return;
+    }
+
     if (!this.acceptsUISourceCode(uiSourceCode)) {
       return;
     }
@@ -1033,6 +1049,12 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
     this.workspaceInternal.uiSourceCodes().forEach(this.addUISourceCode.bind(this));
   }
 
+  private ignoreListChanged(): void {
+    if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.JUST_MY_CODE)) {
+      this.groupingChanged();
+    }
+  }
+
   private initGrouping(): void {
     this.groupByFrame = true;
     this.groupByDomain = this.navigatorGroupByFolderSetting.get();

package/front_end/panels/sources/ScopeChainSidebarPane.ts

@@ -319,14 +319,14 @@ export class OpenLinearMemoryInspector extends UI.Widget.VBox implements UI.Cont
           LinearMemoryInspector.LinearMemoryInspectorController.isMemoryObjectProperty(target.property.value)) {
         contextMenu.debugSection().appendItem(
             i18nString(UIStrings.revealInMemoryInspectorPanel),
-            this.openMemoryInspector.bind(this, target.property.value));
+            this.openMemoryInspector.bind(this, target.property.name, target.property.value));
       }
     }
   }
 
-  private async openMemoryInspector(obj: SDK.RemoteObject.RemoteObject): Promise<void> {
+  private async openMemoryInspector(name: string, obj: SDK.RemoteObject.RemoteObject): Promise<void> {
     const controller = LinearMemoryInspector.LinearMemoryInspectorController.LinearMemoryInspectorController.instance();
     Host.userMetrics.linearMemoryInspectorRevealedFrom(Host.UserMetrics.LinearMemoryInspectorRevealedFrom.ContextMenu);
-    void controller.openInspectorView(obj);
+    void controller.openInspectorView(obj, undefined /* address */, name);
   }
 }

package/front_end/services/puppeteer/PuppeteerConnection.ts

@@ -88,7 +88,8 @@ export async function getPuppeteerConnection(
     return targetInfo.targetId === mainTargetId || targetInfo.openerId === mainTargetId || targetInfo.type === 'iframe';
   };
 
-  const browser = await puppeteer.Browser._create(
+  const browserPromise = puppeteer.Browser._create(
+      'chrome',
       connection,
       [] /* contextIds */,
       false /* ignoreHTTPSErrors */,
@@ -98,6 +99,11 @@ export async function getPuppeteerConnection(
       targetFilterCallback,
   );
 
+  const [, browser] = await Promise.all([
+    connection.createSession({ targetId: mainTargetId }),
+    browserPromise,
+  ]);
+
   const pages = await browser.pages();
   const page = pages.find(p => p.mainFrame()._id === mainFrameId) || null;
 

package/front_end/third_party/codemirror.next/bundle.ts

@@ -78,7 +78,7 @@ export async function shell() {
   return StreamLanguage.define((await import('@codemirror/legacy-modes/mode/shell')).shell);
 }
 export async function cssStreamParser() {
-  return (await import('@codemirror/legacy-modes/mode/css') as any).sCSS;
+  return (await import('@codemirror/legacy-modes/mode/css') as any).css;
 }
 export function wast() {
   return import('@codemirror/lang-wast');